1
0
mirror of https://github.com/samba-team/samba.git synced 2025-01-21 18:04:06 +03:00

27377 Commits

Author SHA1 Message Date
Volker Lendecke
ffb53c3574 Even for srclen == 0 we have to return something
This fixes a regression reported by Corinna Vinschen <corinna@vinschen.de>

Thanks,

Volker
2009-01-12 10:52:00 +01:00
Tim Prouty
44937c55ff s3: Fix uninitialized variable in OneFS streams 2009-01-11 23:29:14 -08:00
Tim Prouty
9872dbf439 s3: Differentiate between posix files with colons and actual streams
It is possible for a posix file created locally or over nfs to have a
":" in the name.  Since ":" is a reserved character in windows,
filenames containing a colon must be mangled in a directory listing.
Right now files containing colons will not even be displayed in
directory listings if streams modules are in use.  During the
directory listing the file will be detected as a stream because of the
colon, but the streams module will fail to find the stream since it
doesn't exist.  This fix adds a step to is_ntfs_stream_name that stats
the filename to differentiate between actual streams and files
containing colons.

While this is an improvement, it isn't perfect. Consider the case
where there is a file on disk called "a.txt:s1" and also a file called
"a.txt" that has a stream called "s1".  This patch will always
preference "a.txt:s1" over a.txt's s1 stream.

The real issue is that at the vfs level, the vfs modules have no way
to tell between a demangled name with a colon and an actual stream.  A
more invasive, but better, long-term fix would be to add all paths
that come over the wire into a struct containing metadata about the
path.  This metadata could include a flag to indicate whether the path
came over the wire with a colon ":" (guaranteeing that the client is
requesting a stream). Passing this struct down to the lower levels,
including all path-based vfs calls, would allow the above case to be
handled correctly in all cases.
2009-01-11 22:13:37 -08:00
Tim Prouty
a1e428914b s3: Add OneFS alternate data streams implementation 2009-01-11 22:13:36 -08:00
Tim Prouty
5c48ba6563 s3: General cleanup of the open path in the OneFS vfs module 2009-01-11 22:13:36 -08:00
Volker Lendecke
ce5eded7e0 Move cli_api_pipe() to its only user cli_pipe.c 2009-01-11 22:53:24 +01:00
Bo Yang
0c2f8ab3ec Don't set child->requests to NULL in parent after fork 2009-01-10 14:12:08 -08:00
Volker Lendecke
d9c40172bf Fix a type-punned error 2009-01-10 13:05:35 +01:00
Volker Lendecke
50aa8a4ac8 Fix a C++ warning 2009-01-10 13:05:34 +01:00
Jeremy Allison
cda0b70519 Minor tidyup of unix account missing code.
Jeremy.
2009-01-09 19:40:09 -08:00
Volker Lendecke
964acde86e Remove the rpc_srv_register wrapper around rpc_pipe_register_commands 2009-01-09 23:17:57 +01:00
Volker Lendecke
2729c484fb Call rpc_srv_register instead of rpc_pipe_register_commands in eventlog and svcctl 2009-01-09 23:17:57 +01:00
Volker Lendecke
106e65a3b3 Fake up ndr_table_spoolss 2009-01-09 23:17:57 +01:00
Volker Lendecke
125696b73d Pass the full ndr_interface_table into the s3 rpcserver when registering 2009-01-09 23:17:57 +01:00
Volker Lendecke
f8f878285d Add derpc_transport_string_by_transport(), apply some const 2009-01-09 23:08:16 +01:00
Volker Lendecke
ad6e9c6012 start rpcclient epmapper 2009-01-09 23:08:16 +01:00
Volker Lendecke
c1a8e8adac Simplify find_pipe_fns_by_context slightly 2009-01-09 22:48:09 +01:00
Volker Lendecke
2714ac4d3a Fix some nonempty blank lines 2009-01-09 22:30:56 +01:00
Tim Prouty
29384794cc s3: Remove rendundant op_tuple entry in xattr streams 2009-01-09 11:50:28 -08:00
Tim Prouty
f2269e6cc8 s3: Fix open path to delete streams depending on the create disposition
The new create disposition test in smbtorture RAW-STREAMS verifies
this fix.
2009-01-09 11:45:31 -08:00
Tim Prouty
6dde84553c s3: Add delete_all_streams to proto.h 2009-01-09 11:45:31 -08:00
Günther Deschner
22a96cbe31 s3-svcctl: remove last traces of hand-marshalled svcctl code.
Guenther
2009-01-09 17:08:19 +01:00
Günther Deschner
03611c6c9d s3-svcctl: remove old marshalling of svcctl_EnumServicesStatusW.
Guenther
2009-01-09 17:08:18 +01:00
Günther Deschner
2d218c93cd s3-svcctl: build svcctl marshalling helper.
Guenther
2009-01-09 17:08:18 +01:00
Günther Deschner
fa6053fe6d s3-svcctl: use pidl for _svcctl_EnumServicesStatusW.
Guenther
2009-01-09 17:08:18 +01:00
Günther Deschner
9e6e3bc010 s3-net: use rpccli_svcctl_EnumServicesStatusW.
Guenther
2009-01-09 17:08:18 +01:00
Karolin Seeger
b516a2abca s3/net: Display error message if user does not exist.
net rpc rights grant: Verify if the username can be resolved to a SID and
display a proper error message if it does not. Otherwise users might think
setting privileges worked fine, but in fact it does not.

Karolin
2009-01-09 17:00:22 +01:00
Günther Deschner
abc2843481 s3-svcctl: use pidl defined constants in services implementation.
Guenther
2009-01-09 16:32:06 +01:00
Karolin Seeger
1b9ae1a6bb s3/smbpasswd: Check if Unix account exists before asking for the password.
Admins shouldn't have to type in the password twice when the passdb account
cannot be created because the Unix account is missing.

Karolin
2009-01-09 16:11:58 +01:00
Stefan Metzmacher
aeb798c325 s3:smbd: handle incoming smb requests via event handlers
We use a fd event and receive incoming smb requests
when the fd becomes readable. It's not completely
nonblocking yet, but it should behave like the old code.

We use timed events to trigger retries for deferred open calls.

metze
2009-01-09 08:45:40 +01:00
Stefan Metzmacher
d524e5f417 s3:events: debug sys_select() errors
metze
2009-01-09 08:45:40 +01:00
Stefan Metzmacher
def5e8e889 s3:events: install a tevent debug handler that calls DEBUG()
metze
2009-01-09 08:45:40 +01:00
Jeremy Allison
590c9b7b6d Fix bug #6021 - smbclient du command does not recuse properly
Jeremy.
2009-01-08 15:41:49 -08:00
Volker Lendecke
84292022bf Now that all policy_handle free_fn's are just TALLOC_FREE, dump free_fn 2009-01-08 22:29:54 +01:00
Volker Lendecke
825500f5da Use TALLOC for struct lsa_info 2009-01-08 22:29:54 +01:00
Volker Lendecke
e94d7f53f9 Make use of a talloc_destructor for free_printer_entry 2009-01-08 22:29:54 +01:00
Volker Lendecke
baa5c5eeb0 Make use of a talloc_destructor for free_eventlog_info() 2009-01-08 22:29:53 +01:00
Volker Lendecke
52b6756c4e Make samr_info a talloc context of its own 2009-01-08 22:29:53 +01:00
Volker Lendecke
5a4f71d40c Simplify init_pipe_handle_list a bit 2009-01-08 22:29:53 +01:00
Günther Deschner
8cddcefb13 s3-rpcclient: add eventlog test client.
Guenther
2009-01-08 19:37:29 +01:00
Günther Deschner
252d271fe4 s3-eventlog: minor cosmetics.
Guenther
2009-01-08 19:37:29 +01:00
Günther Deschner
dad5141c78 s3-eventlog: trying to make eventlog_io_q_read_eventlog readable.
Guenther
2009-01-08 19:37:29 +01:00
Günther Deschner
c0f1309010 s3-eventlog: trying to avoid to pass around full ndr structures in rpc_server.
Jerry, please check.

Guenther
2009-01-08 19:37:29 +01:00
Jeremy Allison
c07ea13d30 Fix race condition in alarm lock processing noticed by Richard Sharpe <realrichardsharpe@gmail.com>.
"It seems to me that if the lock is already held by another process when we
enter this code, there is a race between the timeout and the granting. If
the lock is subsequently granted, the process releasing the lock will signal
the wait variable (or whatever) and our process will be scheduled. However,
if the timeout occurs before we are scheduled, the timeout will be delivered
first.

We will have the lock but will forget we have the lock, and never release
it."
Jeremy.
2009-01-08 10:36:10 -08:00
Günther Deschner
154e08f275 s3-net: fix type in rpc_service_list_internal(). Sorry...
Guenther
2009-01-08 19:15:41 +01:00
Stefan Metzmacher
74a5ccec96 s3:smbd: fix the build with dmapi support
struct smbd_dmapi_context *dmapi_ctx;
is in globals.c

metze
2009-01-08 16:24:28 +01:00
Jelmer Vernooij
8c18d3a316 Merge branch 'master' of ssh://git.samba.org/data/git/samba 2009-01-08 15:47:34 +01:00
Volker Lendecke
260c4e17e8 Attempt to fix the build 2009-01-08 15:27:36 +01:00
Jelmer Vernooij
2c1cd0c9fe Make sure smbtorture4 can find all gensec modules. (Fixes RPC-BINDSAMBA3) 2009-01-08 15:23:35 +01:00
Günther Deschner
50721b485f s3-svcctl: use pidl based struct SERVICE_STATUS.
Guenther
2009-01-08 13:24:22 +01:00