1
0
mirror of https://github.com/samba-team/samba.git synced 2025-02-02 09:47:23 +03:00

56558 Commits

Author SHA1 Message Date
Andrew Bartlett
ba0eba9e09 s4:ntvfs Don't attempt to follow NULL in unixuid_setup_security()
This segfault occoured in cases where we rejected (or never attempted)
the tree connect, so had an invalid private pointer for the logoff
codepath.

Andrew Bartlett
2009-10-02 12:44:58 +02:00
Andrew Bartlett
642dd95d81 s4:Ensure the selected RDN is the right one per the schema
The relative DN must be the one that the most specific structural
objectclass specifies.

Andrew Bartlett
2009-10-02 12:44:58 +02:00
Andrew Tridgell
6159825845 s4-samldb: the samldb module requires that the primary group exists
We need to create Domain Users in the test ldb
2009-10-02 20:00:42 +10:00
Andrew Tridgell
48e5e215c9 s4-samdb: added some debugging
This helped track down the samba3sam.py failures
2009-10-02 20:00:08 +10:00
Andrew Tridgell
860dad2605 s4-test: skip python gensec test until its finished 2009-10-02 18:52:51 +10:00
Andrew Tridgell
5a5c30cb38 s4-pygensec: a bit closer to working
I'll need help from Andrew on how to get gensec to initialise it's ops
element
2009-10-02 18:50:59 +10:00
Andrew Tridgell
084407fe20 pidl: fixed unit tests for trailer alignment 2009-10-02 17:14:15 +10:00
Andrew Tridgell
a01713d3dc pid: update ndr testsuite for new union alignment 2009-10-02 17:11:26 +10:00
Andrew Tridgell
7bdb4306b0 s4-torture: added a very simple samr ValidatePassword test 2009-10-02 16:03:02 +10:00
Andrew Tridgell
caa9e3ff8e s4-samr: fake up a samr_ValidatePassword response
mdw is working on the correct call to check the password strength
2009-10-02 16:02:42 +10:00
Andrew Tridgell
7a59e6c222 idl: rebuilt the IDL for the build farm 2009-10-02 15:11:02 +10:00
Andrew Tridgell
5c07c7eac2 s4-libnet: give sane error messages when functional levels don't match
It is nice to tell the user why their command failed :-)
2009-10-02 15:09:59 +10:00
Matthias Dieter Wallnöfer
0227697bf4 s4:dsdb/common/sidmap - Remove
As metze pointed out - this seems to be completely dead code. I too didn't find
any dependencies in other code parts. Therefore remove it.
2009-10-02 14:22:49 +10:00
Matthias Dieter Wallnöfer
bf0855e8e3 s4:provision - Change the default forest/domain function level back to Windows 2003 Native 2009-10-02 14:22:06 +10:00
Matthias Dieter Wallnöfer
45a237ce88 s4:libnet_become_dc - add checks for valid domain/forest function levels
Add checks to make sure that we join only supported AD domains (we agreed that
those are >= (Windows) 2003 Native per default - this is changeable with the
"ads:function level" option).
Add also checks to make sure that we cannot join domains which have a bigger
function level than our DC capable function level (e.g. a (Windows) 2008 DC
cannot join a (Windows) 2008 R2 domain).
2009-10-02 14:22:01 +10:00
Andrew Tridgell
9eb78be4a6 ndr64: added support for trailing gap alignment
NDR64 has a 'trailing gap' alignment, which aligns the end of a
structure on the overall structure alignment.

This explains the discrepancy we had with the RPC-SAMR test and NDR64
2009-10-02 12:05:59 +10:00
Andrew Tridgell
1726038708 s4-ldb: accept the binary DN OIDs in extended DN modules 2009-10-02 12:05:59 +10:00
Andrew Tridgell
fd22e03047 s4-ldb: Add support for binary blobs in DNs
AD has the concept of a DN prefixed with B:NN:XXXXXX: that contains a
binary blob. We need to support those in order to give correctly
formatted binary blobs for things like wellKnownObjects

This implementation is not ideal, as it allows for binary blobs on all
DNs, whereas it should only allow them on those with a syntax of
2.5.5.7. We should clean this up in the future, but meanwhile this
implementation at least gets us a working DC join of w2k8 to s4.

This patch also uses a static function for marking DNs as invalid,
which is very useful when debugging this code, as you can break on it
in gdb.
2009-10-02 12:03:05 +10:00
Andrew Tridgell
634d9d6476 s4-cldap: match w2k8-r2 for cldap netlogon bits
Windows does not set the 3 high bits, which is strange given their
meaning. I've submitted a CAR on this.
2009-10-02 12:03:04 +10:00
Andrew Tridgell
4cb055cacd ds-flags: use the new name DS_DNS_FOREST_ROOT
Update to use the new DS_DNS_FOREST_ROOT name, which makes it clearer
what this bit means (according to MS-ADTS doc)
2009-10-02 12:02:00 +10:00
Andrew Tridgell
5d60a7e23e s3-ads: removed 3 unused defines
These are in nbt.idl and netlogon.idl as well, no need to have them
here under different names, especially when the comments are wrong
2009-10-02 12:01:59 +10:00
Andrew Tridgell
2b332e6dfe idl: use common netlogon bit definitions
The DS_ bits had got a bit ahead of the NBT_ bits.

Ideally we'd make these a single set of bits at some point.

This also removes NBT_SERVER_DNS_FOREST as this bit doesn't exist. I
think it came from someone mis-reading the docs, which show the bits
in reverse order within bytes (one of the worst bit table
representations I have ever seen!)
2009-10-02 12:01:00 +10:00
Aravind Srinivasan
b529a1e987 s4/torture: Add two new SMB RAW-OPEN tests
* Add chained NTCREATEX_READX test which first tries to open/read
  a non-existant file failing on the open, then attempts the same
  operation on a file that does exist, opening and reading
  successfully.

* Add test for open_dispositions on directories.
2009-10-01 17:14:53 -07:00
Aravind Srinivasan
50db2902ee s4/torture: convert printf to torture_comment() in RAW-OPEN
Allows "make test" and other harnesses to print cleaner output.
2009-10-01 17:14:53 -07:00
Jeremy Allison
ce791d6645 Fix bug #6769 - symlink unlink does nothing.
Always use LSTAT for POSIX pathnames.
Jeremy.
2009-10-01 16:54:06 -07:00
Steven Danneman
c38c99af91 s4/torture: second try on renaming oplocks.c to oplock.c
Forgot to "git add" the new file in commit b2bcfaae
2009-10-01 16:40:33 -07:00
Jeremy Allison
295fec2b46 NULL is not a valid event context.
Jeremy.
2009-10-01 16:18:33 -07:00
Steven Danneman
b2bcfaaeed s4/torture: rename oplocks.c to oplock.c to match SMB1 file layout 2009-10-01 14:59:52 -07:00
Steven Danneman
1160d68062 s4/torture: Ported SMB oplock torture tests to SMB2
I've ported all applicable SMB oplock torture tests to SMB2, giving us
a good base for SMB2 oplock testing.

There are several differences between oplocks in SMB and SMB2, mostly
because of differences in W2K3 and W2K8.  The existing SMB oplock
tests all pass against W2K3, but several fail against W2K8.  These
same tests were failing in SMB2, util I reworked them.

BATCH19, BATCH20: In W2K3/SMB a setfileinfo - rename command wouldn't
cause a sharing violation or break an existing oplock.  It appears that
in W2K8/SMB2 a sharing violation is raised.

BATCH22: In W2K3/SMB when a second opener was waiting the full timeout
of an oplock break, it would receive NT_STATUS_SHARING_VIOLATION after
about 35 seconds.  This bug has been fixed in W2K8/SMB2 and instead
the second opener succeeds.

LEVELII500: Added 1 new test checking that the server returns a proper
error code when a client improperly replies to a levelII to none break
notification.

STREAM1: W2K8 now grants oplocks on alternate data streams.
2009-10-01 14:59:52 -07:00
Steven Danneman
49fdeaeaf6 s4/torture: fix typo in test comment 2009-10-01 14:59:52 -07:00
Kamen Mazdrashki
a58bc2c9a9 s4/asn1: ber_read_OID_String() to be based on _ber_read_OID_String_impl() 2009-10-01 23:13:00 +02:00
Kamen Mazdrashki
a96c8c2355 s4/asn1: local TALLOC_CTX should be child of torture_context 2009-10-01 23:13:00 +02:00
Kamen Mazdrashki
a51571bf41 s4/asn1: fixed typo in torture messages 2009-10-01 23:13:00 +02:00
Kamen Mazdrashki
97e7f48f75 s4/asn1: Added test for ber_read_partial_OID_String() 2009-10-01 23:13:00 +02:00
Kamen Mazdrashki
5021301a0e s4/asn1: Added test for ber_read_OID_String() 2009-10-01 23:12:59 +02:00
Kamen Mazdrashki
681064e66e s4/asn1: Added test for ber_write_partial_OID_String() 2009-10-01 23:12:59 +02:00
Kamen Mazdrashki
3c3ef94ab3 s4/asn1: Added test for ber_write_OID_String() 2009-10-01 23:12:59 +02:00
Kamen Mazdrashki
bd5343924f s4/asn1: Added torture suite for ASN1 2009-10-01 23:12:59 +02:00
Kamen Mazdrashki
8330d78b21 util: strhex_to_str() fixed to handle '0x' correctly 2009-10-01 23:12:58 +02:00
Kamen Mazdrashki
154ab0b047 util: fixed compile time "discards qualifiers" warning 2009-10-01 23:12:58 +02:00
Kamen Mazdrashki
540759ec4d s4/drsuapi: ber_read_partial_OID_String() implementation 2009-10-01 23:12:58 +02:00
Kamen Mazdrashki
55dfc116f4 s4/drsuapi: Internal implementation for ber_read_OID_String
Modified implementation _ber_read_OID_String_impl()
returns how much bytes are converted.
The intentation is to use this implementation both for
reading OIDs and partial-OIDs in the future
2009-10-01 23:12:58 +02:00
Kamen Mazdrashki
715c790600 s4/drsuapi: ber_write_partial_OID_String() implementation 2009-10-01 23:12:57 +02:00
Björn Jacke
2af2334522 s3:Makefile: fix talloc dependencies with static build
When configure options --with-libtalloc=no --enable-shared-libs=no are used,
LIBTALLOC_TARGET stays empty. Actually LIBTALLOC_TARGET which is only used for
Makefile dependencies is obsolete as LIBTALLOC contains exactly the targets
that make the dependencies are. Obnox, pleaѕe check!
2009-10-01 19:27:37 +02:00
Björn Jacke
0265891cfc s3:configure: don't throw away PRINT_LIBS
PRINT_LIBS might have been set before intentionally, so don't thow it away.
2009-10-01 19:27:37 +02:00
Björn Jacke
e9616e4c6d s3: update comment about (deprecated) a6 records 2009-10-01 19:27:37 +02:00
Jeremy Allison
00ce3e143f Fix for CVE-2009-2813.
===========================================================
== Subject:     Misconfigured /etc/passwd file may share folders unexpectedly
==
== CVE ID#:     CVE-2009-2813
==
== Versions:    All versions of Samba later than 3.0.11
==
== Summary:     If a user in /etc/passwd is misconfigured to have
==              an empty home directory then connecting to the home
==              share of this user will use the root of the filesystem
==              as the home directory.
===========================================================
2009-10-01 10:23:29 -07:00
Karolin Seeger
75f90772ce s3/VERSION: Raise version number up to 3.6.0.
Karolin
2009-10-01 14:50:28 +02:00
Jeremy Allison
8a6b90d401 Fix for CVE-2009-2906.
Summary:
Specially crafted SMB requests on
authenticated SMB connections can send smbd
into a 100% CPU loop, causing a DoS on the
Samba server.
2009-10-01 14:32:36 +02:00
Jeff Layton
0597b97d15 mount.cifs: don't leak passwords with verbose option
When running mount.cifs with the --verbose option, it'll print out the
option string that it passes to the kernel...including the mount
password if there is one. Print a placeholder string instead to help
ensure that this info can't be used for nefarious purposes.

Also, the --verbose option printed the option string before it was
completely assembled anyway. This patch should also make sure that
the complete option string is printed out.

Finally, strndup passwords passed in on the command line to ensure that
they aren't shown by --verbose as well. Passwords used this way can
never be truly kept private from other users on the machine of course,
but it's simple enough to do it this way for completeness sake.

Reported-by: Ronald Volgers <r.c.volgers@student.utwente.nl>
Signed-off-by: Jeff Layton <jlayton@redhat.com>
Acked-by: Steve French <sfrench@us.ibm.com>
2009-10-01 14:29:22 +02:00