1
0
mirror of https://github.com/samba-team/samba.git synced 2025-01-12 09:18:10 +03:00
Commit Graph

72072 Commits

Author SHA1 Message Date
Günther Deschner
9d813406e6 s4-libcli/rap: add NDR_RAP dependency to LIBCLI_RAP.
Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Fri Mar 18 14:10:57 CET 2011 on sn-devel-104
2011-03-18 14:10:57 +01:00
Günther Deschner
4e0521300f s3-waf: enable nss_winbind in make test for nss_wrapper.
Guenther
2011-03-18 13:22:07 +01:00
Günther Deschner
fa8471a616 s3-registry: remove some unused headers.
Guenther
2011-03-18 13:22:07 +01:00
Stefan Metzmacher
2f048e458b s3:locking: simplify the non cluster case of brl_get_locks_readonly()
Pair-Programmed-With: Michael Adam <obnox@samba.org>

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Fri Mar 18 13:00:51 CET 2011 on sn-devel-104
2011-03-18 13:00:51 +01:00
Stefan Metzmacher
e8411d6f9f s3:locking: brl_get_locks_internal() should not expose a write lock if the caller wants read_only
This triggered deadlocks in the cluster case of brl_get_locks_readonly().

Pair-Programmed-With: Michael Adam <obnox@samba.org>

metze
2011-03-18 07:51:46 +01:00
Andrew Tridgell
c4cfffa4ed s4-rootdse: improved operations error messages
this gives better localisation of errors in rootdse. This is to help
track down a production error

Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Fri Mar 18 05:46:58 CET 2011 on sn-devel-104
2011-03-18 05:46:58 +01:00
Günther Deschner
de5cec48a4 s4-smbtorture: add netsessiongetinfo() test.
Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Fri Mar 18 02:11:38 CET 2011 on sn-devel-104
2011-03-18 02:11:38 +01:00
Günther Deschner
26ddcd3da1 s4-smbtorture: add missing error code check in test_netsessionenum().
Guenther
2011-03-18 01:24:07 +01:00
Günther Deschner
436b497714 s4-libcli/rap: add smbcli_rap_netsessiongetinfo().
Guenther
2011-03-18 01:24:07 +01:00
Günther Deschner
f87a072b95 rap: add rap_NetSessionGetInfo to IDL.
Guenther
2011-03-18 01:24:07 +01:00
Günther Deschner
9ef1a8cf4c s4-smbtorture: add test for rap_NetUserDelete().
Guenther
2011-03-18 01:24:07 +01:00
Günther Deschner
5def6f0eca s3-net: make sure we set correct default user flags in rap_user_add().
Guenther
2011-03-18 01:24:07 +01:00
Günther Deschner
249340c9c8 s4-smbtorture: add test for rap_NetUserAdd().
Guenther
2011-03-18 01:24:07 +01:00
Günther Deschner
980ceb2f70 s4-libcli/rap: add smbcli_rap_netuserdelete().
Guenther
2011-03-18 01:24:07 +01:00
Günther Deschner
9b1f2df3b1 rap: add rap_NetUserDelete IDL.
Guenther
2011-03-18 01:24:07 +01:00
Günther Deschner
f91bc89a52 s4-libcli/rap: add smbcli_rap_netuseradd().
Guenther
2011-03-18 01:24:06 +01:00
Günther Deschner
dd5460c2e5 rap: add rap_NetUserAdd IDL.
Guenther
2011-03-18 01:24:06 +01:00
Günther Deschner
40398acf75 s4-smbtorture: use torture_assert_ and comment functions in raw.eas test.
Guenther
2011-03-18 01:24:06 +01:00
Günther Deschner
4a48c9d4ac s4-smbtorture: use torture_context in raw.eas test.
Guenther
2011-03-18 01:24:06 +01:00
Günther Deschner
ac851935e2 s4-smbtorture: remove trailing whitespace from raw.eas test.
Guenther
2011-03-18 01:24:06 +01:00
Günther Deschner
faf8becf22 s3-utils: run minimal_includes.pl over utils/*.c
Guenther
2011-03-18 01:24:06 +01:00
Jeremy Allison
066fecd315 The searches struct is still being used and idled in SMB2 - move it to the global
section until we decide if we want to idle SMB2 directory handles.

Jeremy.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Fri Mar 18 01:13:53 CET 2011 on sn-devel-104
2011-03-18 01:13:53 +01:00
Jeremy Allison
4c77d620e6 Fix crash bug on smbd shutdown when using FOPENDIR() found by Volker.
The key was allowing the dptr_idle code to be triggered. We were
closing the dirp->dir handle without updating the underlying fd
in the open fsp.

Jeremy.
2011-03-17 15:55:15 -07:00
Volker Lendecke
9bc10bde14 s3: Expose num_opens via api_RNetSessionEnum
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Thu Mar 17 22:05:10 CET 2011 on sn-devel-104
2011-03-17 22:05:10 +01:00
Jeremy Allison
fdb98fbdd8 Nulling out the op_mid is never the right thing to do. We depend on
this value when searching for specific share mode entries.

Jeremy.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Thu Mar 17 19:59:51 CET 2011 on sn-devel-104
2011-03-17 19:59:51 +01:00
Jeremy Allison
3d6a92a37b Fix compiler warning in debug message. 2011-03-17 10:35:10 -07:00
Stefan Metzmacher
ef078307d9 s3:Makefile.in: make sure we rebuild bin/smbtorture4 if there where changes
and bin/ndrdump4...

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Thu Mar 17 16:31:45 CET 2011 on sn-devel-104
2011-03-17 16:31:45 +01:00
Simo Sorce
5d55ae0a29 lib-util: put data_blob back in the public library
data_blob is defined ina public header, so it needs to be exposed in the public
library.

Autobuild-User: Simo Sorce <idra@samba.org>
Autobuild-Date: Thu Mar 17 15:39:08 CET 2011 on sn-devel-104
2011-03-17 15:39:08 +01:00
Günther Deschner
1413af95fc s3-waf: add --with-pam_smbpass configure option.
We build pam_smbpass independent from this configure option though.

Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Thu Mar 17 14:52:33 CET 2011 on sn-devel-104
2011-03-17 14:52:33 +01:00
Günther Deschner
7bc381bdc5 s3-waf: move HAVE_LDAP_SASL_WRAPPING define to the HAVE_LDAP block.
Guenther
2011-03-17 14:05:48 +01:00
Sumit Bose
4562a7914d s3:net Find uid before using it
Signed-off-by: Günther Deschner <gd@samba.org>
2011-03-17 13:57:28 +01:00
Günther Deschner
717beda638 s4-smbtorture: more torture_fail usage in raw.write test.
Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Thu Mar 17 13:10:14 CET 2011 on sn-devel-104
2011-03-17 13:10:14 +01:00
Günther Deschner
1d516f0d76 s3-username: rename static getpwnam_alloc to getpwnam_alloc_cached.
Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Thu Mar 17 00:32:40 CET 2011 on sn-devel-104
2011-03-17 00:32:40 +01:00
Günther Deschner
3aa9d3005a s3-build: only include asn1 headers where actually needed.
Guenther
2011-03-16 23:46:18 +01:00
Simo Sorce
2a608ba856 dcerpc: we do not need these as public headers
latest openchange doesn't need these headers either
fix _PRINTF_ATTRIBUTE in tdr.h, as it was failing to work after removing
proto.h due to side effects. PRINTF_ATTRIBUTE is ok and is define in talloc.h
which is included by tdr.h

Autobuild-User: Simo Sorce <idra@samba.org>
Autobuild-Date: Wed Mar 16 23:45:20 CET 2011 on sn-devel-104
2011-03-16 23:45:20 +01:00
Volker Lendecke
ab37eae79c s3: Fix Coverity ID 2231, REVERSE_INULL
No point in checking for !ctx after dereferencing it

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Wed Mar 16 22:51:52 CET 2011 on sn-devel-104
2011-03-16 22:51:52 +01:00
Volker Lendecke
889e03617d s3: Fix Coverity ID 2232, REVERSE_INULL
No point checking for !cli after dereferencing it
2011-03-16 22:07:24 +01:00
Volker Lendecke
37870e28ab s3: Fix Coverity ID 2233, REVERSE_INULL
We have dereferenced h already in dcerpc_lsa_open_policy2 in line 425
2011-03-16 22:07:24 +01:00
Volker Lendecke
dacb392db6 s3: Fix Coverity ID 2234: REVERSE_INULL
We have dereferenced "b" already in dcerpc_samr_Connect2 in line 521
2011-03-16 22:07:24 +01:00
Volker Lendecke
fb47b7fd67 s3: Fix Coverity ID 2140, DEADCODE
This routine was never executed after f0dcc90f because "netname" was always
NULL.

Jeremy, please check!
2011-03-16 22:07:24 +01:00
Volker Lendecke
dd3d6a160c s3: Fix Coverity ID 2144, DEADCODE
We could never have assigned the real value in line 481.

Andreas, please check!
2011-03-16 22:07:24 +01:00
Volker Lendecke
4f46ad96f2 s3: Fix Coverity ID 2147, FORWARD_NULL
How could this ever have worked???
2011-03-16 22:07:24 +01:00
Volker Lendecke
c58eb1f8c5 s3: Fix Coverity ID 2148, FORWARD_NULL
Further down we unconditionally reference *info
2011-03-16 22:07:23 +01:00
Volker Lendecke
2581cb7ada s3: Fix Coverity ID 1402: PASS_BY_VALUE
There's no point in passing GROUP_MAP on the stack

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Wed Mar 16 21:58:08 CET 2011 on sn-devel-104
2011-03-16 21:58:08 +01:00
Volker Lendecke
a7a638c3cf s3: Fix Coverity ID 2213, PASS_BY_VALUE
There's little point to pass a copy of this structure on the stack.

Günther, please check!
2011-03-16 21:14:58 +01:00
Volker Lendecke
a282455978 s3: Fix Coverity ID 1012, CHECKED_RETURN
This is probably more or less taste. Removing the necessity for a comment is a
good thing though IMO.
2011-03-16 21:14:58 +01:00
Volker Lendecke
9c9ed33cb7 s3: Fix Coverity ID 1013, CHECKED_RETURN
This is probably more or less taste. Removing the necessity for a comment is a
good thing though IMO.
2011-03-16 21:14:58 +01:00
Volker Lendecke
3835d77795 s3: Fix Coverity ID 1017, CHECKED_RETURN
Günther, please check!
2011-03-16 21:14:58 +01:00
Volker Lendecke
920b2fddc6 s3: Fix Coverity ID 1018, CHECKED_RETURN 2011-03-16 21:14:58 +01:00
Volker Lendecke
4668ac8b16 s3: Fix Coverity ID 1034, CHECKED_RETURN
In all other places we check the result of secrets_init.
2011-03-16 21:14:58 +01:00