1
0
mirror of https://github.com/samba-team/samba.git synced 2025-01-12 09:18:10 +03:00
Commit Graph

37028 Commits

Author SHA1 Message Date
Jeremy Allison
40c54a736d Part 2 of bugfix for #8211 - "inherit owner = yes" doesn't interact correctly with "inherit permissions = yes" and POSIX ACLs
When changing ownership on a new file make sure we
also change the returned stat struct to have the correct uid.
2011-06-07 16:48:14 -07:00
Jeremy Allison
cabed2fb17 Part 1 of bugfix for #8211 - "inherit owner = yes" doesn't interact correctly with "inherit permissions = yes" and POSIX ACLs
When changing ownership on a new directory make sure we
also change the returned stat struct to have the correct uid.
2011-06-07 16:42:02 -07:00
Jeremy Allison
aff6c52370 Fix re-opened bug 8083 - "inherit owner = yes" doesn't interact correctly with vfs_acl_xattr or vfs_acl_tdb module.
Fix incorrect interaction when all of

"inherit permissions = yes"
"inherit acls = yes"
"inherit owner = yes"

are set. Found by Björn Jacke. Thanks Björn !

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Tue Jun  7 22:32:18 CEST 2011 on sn-devel-104
2011-06-07 22:32:18 +02:00
Stefan Metzmacher
c3ac298a1f s3:libsmb/cli_np_tstream: use larger buffers to avoid a bug NT4 servers (bug #8195)
NT4 servers return NT_STATUS_PIPE_BUSY if we try a SMBtrans
and the SMBwriteX before hasn't transmited the whole DCERPC fragment.

W2K and above is happy with that.

As a result we try to match the behavior of Windows and older Samba clients,
they use write and read buffers of 4280 bytes instead of 1024 bytes.
On Windows only the SMBtrans based read uses 1024 (while we also use 4280
there).

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Tue Jun  7 20:25:32 CEST 2011 on sn-devel-104
2011-06-07 20:25:32 +02:00
Michael Adam
cd8dc47bf1 s3:idmap_autorid: fail initialization if the domain is not "*"
autorid can only be used as a backend for the default idmap configuration.

Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Tue Jun  7 19:13:18 CEST 2011 on sn-devel-104
2011-06-07 19:13:18 +02:00
Michael Adam
b0b0b625b5 s3:idmap_autorid: use "idmap config <DOMAIN> : rangesize" instead of "autorid:rangesize" 2011-06-07 15:55:08 +02:00
Michael Adam
65490ea4e6 s3:idmap_autorid: add a talloc_stackframe() to idmap_autorid_initialize() 2011-06-07 15:55:07 +02:00
Andrew Bartlett
a8d1d0c94c s3-auth Use loadparm_init_s3() to get an lp_ctx for auth_samba4
This avoids loading the smb.conf twice.

Andrew Bartlett
2011-06-07 09:11:01 +10:00
Volker Lendecke
56eab757d0 s3: Remove unused variables
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Tue Jun  7 00:42:51 CEST 2011 on sn-devel-104
2011-06-07 00:42:51 +02:00
Andreas Schneider
8b02b78044 s3-waf: Fix pthreadpool build which needs librt now.
Autobuild-User: Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date: Mon Jun  6 23:31:09 CEST 2011 on sn-devel-104
2011-06-06 23:31:09 +02:00
Volker Lendecke
976a43c5aa s3: Remove a pointless if-statement
We are here only if we have more than one num_pending

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Mon Jun  6 18:21:17 CEST 2011 on sn-devel-104
2011-06-06 18:21:17 +02:00
Volker Lendecke
411c52aba3 s3: Fix two debug messages
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Mon Jun  6 14:11:06 CEST 2011 on sn-devel-104
2011-06-06 14:11:06 +02:00
Björn Jacke
4778d35c34 s3/pthreadpool: replace bad portable gettimeofday by clock_gettime
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2011-06-06 11:48:10 +02:00
Andrew Bartlett
b9108cac52 s3-s4-param: Add hooks for parametric options in the s3/s4 glue layer
Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Mon Jun  6 10:48:53 CEST 2011 on sn-devel-104
2011-06-06 10:48:53 +02:00
Andrew Bartlett
d72b05cfe7 s3-passdb use new loadparm_init_s3 rather than reloading the smb.conf 2011-06-06 17:37:51 +10:00
Andrew Bartlett
de46ad9084 lib/util use modules_path(), data_path() and shlib_ext() from source3
This brings these helpful utility functions in common, as they are not
based on either loadparm system.

(The 'modules dir' parameter from Samba4 will shortly be removed, so
there is no loss in functionality)

Andrew Bartlett
2011-06-06 17:37:51 +10:00
Andrew Bartlett
876b1b3d19 s3-lib Remove unused lib_path() 2011-06-06 17:37:51 +10:00
Andrew Bartlett
1dfc6fa558 s4-param Add hook between Samba3 and Samba4 loadparm systems.
In the top level build, this allows calls to code that requires a
lpcfg_ style loadparm_context, while using the global parameters
loaded from the source3 loadparm code.

Andrew Bartlett
2011-06-06 17:37:51 +10:00
Andrew Bartlett
698538e594 s3-param always allow the realm parameter 2011-06-06 17:37:50 +10:00
Volker Lendecke
10f5fa8a1e s3: Make use of name_resolve_bcast in nmblookup 2011-06-05 14:08:01 +02:00
Volker Lendecke
2d90a89942 s3: Make name_resolve_bcast do parallel lookups to all interfaces 2011-06-05 14:08:00 +02:00
Volker Lendecke
fbe7b47c34 s3: Add name_queries_send/recv 2011-06-05 14:08:00 +02:00
Volker Lendecke
114fbc385c s3: Fix a valgrind error
For me this fixes

==1950== Invalid read of size 4
==1950==    at 0x81EBED5: GUID_equal (uuid.c:239)
==1950==    by 0x81E51AB: ndr_syntax_id_equal (ndr_misc.c:35)
==1950==    by 0x82EB0D1: get_iface_from_syntax (rpc_common.c:160)
==1950==    by 0x82EB25E: get_pipe_name_from_syntax (rpc_common.c:179)
==1950==    by 0x8509E4F: close_policy_by_pipe (rpc_handles.c:322)
==1950==    by 0x8507941: close_internal_rpc_pipe_hnd (rpc_ncacn_np.c:109)
==1950==    by 0x468270: _talloc_free_internal (talloc.c:826)
==1950==    by 0x467EE0: _talloc_free_internal (talloc.c:1268)
==1950==    by 0x467EE0: _talloc_free_internal (talloc.c:1268)
==1950==    by 0x467EE0: _talloc_free_internal (talloc.c:1268)
==1950==    by 0x467EE0: _talloc_free_internal (talloc.c:1268)
==1950==    by 0x80E6487: sam_trusted_domains (winbindd_samr.c:406)
==1950==  Address 0x687ea4 is 20 bytes inside a block of size 40 free'd
==1950==    at 0x58CDC: free (in /usr/local/lib/valgrind/vgpreload_memcheck-x86-freebsd.so)
==1950==    by 0x8507812: free_pipe_rpc_context_internal (rpc_ncacn_np.c:74)
==1950==    by 0x8507936: close_internal_rpc_pipe_hnd (rpc_ncacn_np.c:106)
==1950==    by 0x468270: _talloc_free_internal (talloc.c:826)
==1950==    by 0x467EE0: _talloc_free_internal (talloc.c:1268)
==1950==    by 0x467EE0: _talloc_free_internal (talloc.c:1268)
==1950==    by 0x467EE0: _talloc_free_internal (talloc.c:1268)
==1950==    by 0x467EE0: _talloc_free_internal (talloc.c:1268)
==1950==    by 0x80E6487: sam_trusted_domains (winbindd_samr.c:406)
==1950==    by 0x80C2F85: trusted_domains (winbindd_cache.c:2820)
==1950==    by 0x80D5188: winbindd_dual_list_trusted_domains (winbindd_misc.c:162)
==1950==    by 0x80E987F: wb_child_request_trigger (winbindd_dual.c:437)
==1950==

Andreas, Guenther, please check!

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sun Jun  5 13:19:39 CEST 2011 on sn-devel-104
2011-06-05 13:19:39 +02:00
Volker Lendecke
5a6368f1e2 s3:winbind: Convert WINBINDD_WINS_BYIP to the async API 2011-06-05 12:10:15 +02:00
Volker Lendecke
e28df27f2a s3: Fix the build on FreeBSD 8
This is probably not the last word on gss_mech_krb5, but for now it fixes
the build on FreeBSD
2011-06-04 12:44:58 +02:00
Jeremy Allison
3c9b3b2bef Add the same fix to the S3 event backend as the previous commit added to the tevent poll backend.
Metze please check !

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Sat Jun  4 00:27:37 CEST 2011 on sn-devel-104
2011-06-04 00:27:37 +02:00
Herb Lewis
710444d110 In samba_version.m4 the test to get the version now returns several
lines instead of the one we really wanted which causes some spurious
output when configure tries to print the samba version when it starts
running. This is only a cosmetic problem but still looks ugly.

Signed-off-by: Jeremy Allison <jra@samba.org>
2011-06-02 10:15:18 -07:00
Jeremy Allison
e98fb2f2b9 Remove another PATH_MAX.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Thu Jun  2 02:51:06 CEST 2011 on sn-devel-104
2011-06-02 02:51:06 +02:00
Jeremy Allison
c06a31dd65 Fix const warnings.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Thu Jun  2 01:02:53 CEST 2011 on sn-devel-104
2011-06-02 01:02:53 +02:00
Jeremy Allison
cbfe8029a4 Fix const warning. 2011-06-01 23:53:07 +02:00
Jeremy Allison
24ce9d52a6 Fix const warning. 2011-06-01 23:53:07 +02:00
Jeremy Allison
06fb258500 release_ip() is only used with CLUSTER_SUPPORT. 2011-06-01 23:53:07 +02:00
Jeremy Allison
b08bd96dc0 Fix bug where format arguments were reversed. Please compile with -Wall ! 2011-06-01 23:53:07 +02:00
Jeremy Allison
febde0de54 Move fd_close on error path to be identical to all other error paths.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Wed Jun  1 22:30:03 CEST 2011 on sn-devel-104
2011-06-01 22:30:03 +02:00
Jeremy Allison
61e8c5949a TALLOC_FREE already checks for null. 2011-06-01 12:12:26 -07:00
Jeremy Allison
5a2b5b6cfe Fix bug #8175 - smbd deadlock.
Force the open operation (which is the expensive one anyway) to
acquire and release locks in a way compatible with the more common
do_lock check.

Jeremy.
2011-06-01 12:11:53 -07:00
Volker Lendecke
2ab34a5736 Revert "s3: Mark sockets in error state writable"
This reverts commit 5f6f719564.

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Wed Jun  1 14:56:25 CEST 2011 on sn-devel-104
2011-06-01 14:56:25 +02:00
Andreas Schneider
b5aeee76c9 s3-epmapper: Register ports on IPv4 too.
Autobuild-User: Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date: Wed Jun  1 13:14:53 CEST 2011 on sn-devel-104
2011-06-01 13:14:53 +02:00
Andreas Schneider
4640d908f7 s3-rpc_server: Remove unused variable pipes_open. 2011-06-01 12:02:16 +02:00
Andreas Schneider
f086057ce8 s3-rpc_server: Remove syntax from pipes_struct. 2011-06-01 12:02:16 +02:00
Andreas Schneider
751ecd9bf7 s3-rpc_server: Fixed debug messages of srv_pipe_hnd. 2011-06-01 12:02:15 +02:00
Andreas Schneider
9f1b20e971 s3-rpc_server: Fixed debug messages for rpc_handles. 2011-06-01 12:02:15 +02:00
Andreas Schneider
89ced2cc49 s3-rpc_server: Fix debug messages. 2011-06-01 12:02:15 +02:00
Andreas Schneider
e744222e41 s3-rpc_server: Don't segfault if there are not handles to free. 2011-06-01 12:02:15 +02:00
Andreas Schneider
438b24a77f s3-rpc_server: Remove guessing of the syntax id.
This is only a wild guess. We don't know to which rpc service the client
wants to talk until we read the the rpc bind packet.
2011-06-01 12:02:15 +02:00
Andreas Schneider
7d800a8694 s3-rpc_server: Use the correct syntax id for debugging. 2011-06-01 12:02:15 +02:00
Andreas Schneider
6b0f82eeab s3-rpc_server: Migrate init_pipe_handles() to new syntax. 2011-06-01 12:02:15 +02:00
Andreas Schneider
58485afd91 s3-rpc_server: Use the context syntax id in api_pipe_request(). 2011-06-01 12:02:15 +02:00
Andreas Schneider
c8ec695cb3 s3-rpc_server: Use the correct syntax id in api_pipe_bind_req(). 2011-06-01 12:02:15 +02:00
Andreas Schneider
6e8c7d0834 s3-rpc_server: Use the correct context syntax. 2011-06-01 12:02:15 +02:00
Andreas Schneider
34a600a27f s3-rpc_server: Move the context functions to own file. 2011-06-01 12:02:15 +02:00
Andreas Schneider
e39e09ffb5 s3-rpc_server: Store the ndr syntax id in the pipe context.
The client tell us in the rpc bind to which rpc service it wants to
connect. We did set the p->syntax earlier by guessing to which pipe name
it connects, but we don't know to which rpc service it wants to bind
until we read the first packet.
2011-06-01 12:02:15 +02:00
Andreas Schneider
44fb1140bb s3-rpc_server: Added syntax id to pipe_rpc_fns struct. 2011-06-01 12:02:15 +02:00
Rusty Russell
0204ae6229 lib/util/time.c: timeval_current_ofs_usec
Several places want "microseconds from current time", and several were
simply handing "usecs" values which could be over a million.

Using a helper to do this is safer and more readable.

I didn't replace any obviously correct callers (ie. constants).

I also renamed wait_nsec in source3/lib/util_sock.c; it's actually
microseconds not nanoseconds (introduced with this code in Volker's
19b783cc Async wrapper for open_socket_out_send/recv).

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2011-06-01 10:38:47 +02:00
Rusty Russell
56e72337b0 lib/util/time.c: timeval_current_ofs_msec
Several places want "milliseconds from current time", and several were
simply doing "msec * 1000" which can (and does in one place) result in
a usec value over 1 a million.

Using a helper to do this is safer and more readable.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2011-06-01 10:38:47 +02:00
Andrew Bartlett
5a8218b147 s3-param Make lp_ncalrpc_dir() const
This disables % substitutions in the 'ncalrpc dir' parameter.  This is
used as a communication point between multiple parts of the codebase,
and needs to be internally consistent between all the Samba tasks.

Andrew Bartlett

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Wed Jun  1 05:30:53 CEST 2011 on sn-devel-104
2011-06-01 05:30:53 +02:00
Andrew Bartlett
b9d61ef55a s3-param Make lp_dedicated_keytab_file() const
This disables % substitutions in the 'dedicated keytab file' parameter.

Andrew Bartlett
2011-06-01 04:19:06 +02:00
Andrew Bartlett
edc3041093 s3-param Make lp_realm() const
This disables % substitutions in the 'realm' parameter.  This is
used all over the codebase, and needs to be internally consistent
between all the Samba tasks.

Andrew Bartlett
2011-06-01 04:19:05 +02:00
Andrew Bartlett
860b43737c s3-param Make lp_name_resolv_order() const
This disables % substitutions in the 'name resolv order' parameter.  This is
used all over the codebase, and needs to be internally consistent
between all the Samba tasks.

Andrew Bartlett
2011-06-01 04:19:05 +02:00
Andrew Bartlett
08a72f3a15 s3-param Make lp_utmpdir() and lp_wtmpdir const
This disables % substitutions in the 'utmp dir' and 'wtmp dir'
parameters.  These are system paths, and need to be consistent between
all the Samba tasks.

Andrew Bartlett
2011-06-01 04:19:05 +02:00
Andrew Bartlett
47ece3f897 s3-param Make lp_piddir() const
This disables % substitutions in the 'pid dir' parameter.  This is
used all over the codebase, and need to be internally consistent
between all the Samba tasks.

Andrew Bartlett
2011-06-01 04:19:05 +02:00
Andrew Bartlett
a0758bb5e5 s3-param Make lp_cachedir() const
This disables % substitutions in the 'cache dir' parameter.  This is
used all over the codebase, and need to be internally consistent
between all the Samba tasks.

Andrew Bartlett
2011-06-01 04:19:05 +02:00
Andrew Bartlett
9aef68f4c2 s3-param Make lp_statedir() const
This disables % substitutions in the 'state dir' parameter.  This is
used all over the codebase, and need to be internally consistent
between all the Samba tasks.

Andrew Bartlett
2011-06-01 04:19:05 +02:00
Andrew Bartlett
5f176378a8 s3-param Make lp_lockdir() const
This disables % substitutions in the 'lock dir' parameter.  This is
used all over the codebase, and needs to be internally consistent
for the life of the process, as they determine the location of
our locking databases.

Andrew Bartlett
2011-06-01 04:19:05 +02:00
Andrew Bartlett
f331936db2 s3-param Make lp_smb_passwd_file() and lp_private_dir() const
This disables % substitutions in the 'smb passwd file' and 'private
dir' parameters.  These are used all over the codebase, and need to be
internally consistent for the life of the process, as they determine
the location of secrets.tdb, as well as the passdb databases.

Andrew Bartlett
2011-06-01 04:19:05 +02:00
Andrew Bartlett
a74e7fbc6a s3-param Make lp_smb_ports() const
It makes no sense to have a % substiution in the 'smb ports' parameter.

Andrew Bartlett
2011-06-01 04:19:05 +02:00
Andrew Bartlett
f52b97a129 s3-param Make charset parameters const
This removes the dangerous ability for these parameters to change
based on % substitutions.

Andrew Bartlett
2011-06-01 04:19:05 +02:00
Andrew Bartlett
ec9ff19e60 s3-param Make lp_passwordserver() const.
This means that it no longer takes % substituations, and so the documentation for this behaviour is removed from the smb.conf manpage.  (This mode is only useful in security=server, which is already marked as deprecated in 3.6).

Andrew Bartlett
2011-06-01 04:19:05 +02:00
Andrew Bartlett
7630e73dac s3-param prepare for some lp_ functions to return const 2011-06-01 04:19:05 +02:00
Jeremy Allison
c7d2f6d35a Remove the char * argument from the SMB_VFS_GETWD() call. Now always
returns malloc'ed memory.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Wed Jun  1 04:06:12 CEST 2011 on sn-devel-104
2011-06-01 04:06:12 +02:00
Jeremy Allison
1cee71713f Change sys_getcd() to take no arguments and always return malloc'ed memory (or NULL).
Part of the efforts to remove PATH_MAX on modern systems.
2011-06-01 02:54:51 +02:00
Jeremy Allison
5abab13851 Add check for the getcwd function being able to take NULL,0 arguments. 2011-06-01 02:54:51 +02:00
Jeremy Allison
313bb1fb9c Split the ACE flag mapping between nfs4 and Windows
into two separate functions rather than trying to do
it inline. Allows us to carefully control what flags
are mapped to what in one place. Modification to
bug #8191 - vfs_gpfs dosn't honor ACE_FLAG_INHERITED_ACE
2011-06-01 02:54:51 +02:00
Michael Adam
74cd06b3df s3:idmap_ldap: allow creation of ldap stored mappings for explicitly configured domains.
After the preparations, this is achieved by using idmap_ldap_allocate_id_internal()
as get_new_id rw method instead of idmap_ldap_allocate_id().
2011-06-01 01:43:23 +02:00
Michael Adam
dea3ef1ab6 s3:idmap_ldap: rename idmap_ldap_get_new_id to idmap_ldap_allocate_id
This is in preparation of allowing allocating ldap based domain-specific configs.
2011-06-01 01:43:23 +02:00
Michael Adam
2de65b97b9 s3:idmap_ldap: rename idmap_ldap_allocate_id to idmap_ldap_allocate_id_internal
This is in preparation of allowing allocating ldap based domain-specific configs.
2011-06-01 01:43:23 +02:00
Günther Deschner
f103e0c39f s3: fix more -Wunused-but-set-variable build warnings.
Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Wed Jun  1 00:29:30 CEST 2011 on sn-devel-104
2011-06-01 00:29:30 +02:00
Volker Lendecke
d77854fbb2 struct make "struct shadow_copy_data" its own talloc context 2011-05-31 21:47:07 +02:00
Volker Lendecke
0ec9a90c29 s3: Remove SHADOW_COPY_DATA typedef 2011-05-31 21:47:07 +02:00
Volker Lendecke
5f6f719564 s3: Mark sockets in error state writable
Without this patch, when a socket only has a write event pending, we will never
detect an error condition. I've seen winbind doing

12:19:13.659964 gettimeofday({1306837153, 659984}, NULL) = 0 <0.000016>
12:19:13.660109 poll([{fd=35, events=POLLOUT}, {fd=32, events=POLLIN|POLLHUP}], 2, 9996) = 1 ([{fd=35, revents=POLLERR|POLLHUP}]) <0.000015>
12:19:13.660253 gettimeofday({1306837153, 660269}, NULL) = 0 <0.000013>
12:19:13.660298 poll([{fd=35, events=POLLOUT}, {fd=32, events=POLLIN|POLLHUP}], 2, 9996) = 1 ([{fd=35, revents=POLLERR|POLLHUP}]) <0.000015>

for a while when trying to connect to a DC when the socket had died already.

Volker

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Tue May 31 20:59:10 CEST 2011 on sn-devel-104
2011-05-31 20:59:10 +02:00
Michael Adam
c0fc7aa129 s3:passdb: add GPL/copyright header to machine_sid.h 2011-05-31 18:37:29 +02:00
Michael Adam
fdd225c3e4 s3:nmbd: add _NMBD_NMBD_H_ guard to nmbd.h 2011-05-31 18:37:29 +02:00
Michael Adam
75cfafd698 s3:nmbd: add GPL/Copyright header to nmbd.h 2011-05-31 18:37:29 +02:00
Michael Adam
e403315521 s3:rpc_server: add _RPC_SERVER_SRV_ACCESS_CHECK_H_ guard to srv_access_check.h 2011-05-31 18:37:29 +02:00
Michael Adam
942ae874b8 s3:rpc_server: add GPL/Copyright header to rpc_server/srv_access_check.h 2011-05-31 18:37:29 +02:00
Michael Adam
c2887f0609 s3: add _LIB_IDMAP_CACHE_H_ guard to lib/idmap_cache.h 2011-05-31 18:37:29 +02:00
Michael Adam
2b8803d458 s3: add GPL/Copyright header to lib/idmap_cache.h 2011-05-31 18:37:29 +02:00
Michael Adam
9549cf125a s3:librpc: remove unused file librpc/ndr/util.h
Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Tue May 31 15:19:46 CEST 2011 on sn-devel-104
2011-05-31 15:19:46 +02:00
Michael Adam
52bc63aa85 s3:winbindd_nrd: include ../librpc/ndr/libndr.h instead of librpc/ndr/util.h 2011-05-31 12:54:22 +02:00
Michael Adam
72f2bd6a86 s3:libads/ndr: include ../librpc/ndr/libndr.h instead of librpc/ndr/util.h 2011-05-31 12:54:22 +02:00
Volker Lendecke
0fcafbf69b s3: Support shadow copy display over SMB2
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Tue May 31 12:53:10 CEST 2011 on sn-devel-104
2011-05-31 12:53:10 +02:00
Michael Adam
36feb8a240 s3:lib/eventlog/proto.h: add _LIB_EVENTLOG_PROTO_H_ guard 2011-05-31 10:33:55 +02:00
Michael Adam
00530e3d01 s3:lib/eventlog/proto.h: add GPL/Copyright header 2011-05-31 10:33:54 +02:00
Andrew Bartlett
c7b9dbea10 s3-libsmb remove ldap_err2string() as common nterrs[] has the constants
Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Tue May 31 08:58:00 CEST 2011 on sn-devel-104
2011-05-31 08:58:00 +02:00
Andrew Bartlett
6552561b87 s3-build Don't allow undefined symbols in pam_smbpass.so 2011-05-31 15:46:10 +10:00
Günther Deschner
4ac4ad2108 s3-utils: fix another -Wunused-but-set-variable build warning.
Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Tue May 31 05:18:42 CEST 2011 on sn-devel-104
2011-05-31 05:18:42 +02:00
Günther Deschner
6a6af31148 s3-libsmb: fix build warning of cli_qfilename().
Guenther
2011-05-31 04:09:30 +02:00
Andrew Bartlett
7e5660282e s3-build Put memcache in a standalone library
Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Tue May 31 04:08:08 CEST 2011 on sn-devel-104
2011-05-31 04:08:07 +02:00
Andrew Bartlett
8c8ff2cd6b s3-lib Move source3-specific malloc replacements into a seperate file
This will make it easier to create a dep tree for otherwise simple
libraries.

Andrew Bartlett
2011-05-31 02:57:19 +02:00
Andrew Bartlett
52399f3177 lib/util Move sys_memalign into lib/util/system.c 2011-05-31 02:57:19 +02:00
Andrew Bartlett
38fee2b521 s3-smbd Fix conn_msg.c: Cannot return in a void function 2011-05-31 02:57:19 +02:00
Andrew Bartlett
9d5b53921d s3-lib Improve indentation of errmap_unix
This also makes it easier to compare and contrast with the source4
version, because the differences here matter, and need to be resolved
with care.

Andrew Bartlett
2011-05-31 02:57:19 +02:00
Andrew Bartlett
aa848c12eb s3-lib: Use ARRAY_SIZE() to walk the error mapping tables
This gives a constant termination condition, and may help the compiler.

Andrew Bartlett
2011-05-31 02:57:19 +02:00
Michael Adam
6ef8122cba s3:libgpo/gpo_proto.h: add _LIBGPO_GPO_PROTO_H_ guard 2011-05-31 01:44:27 +02:00
Michael Adam
59950faddc s3:libgpo/gpo_proto.h: add GPL/Copyright header 2011-05-31 01:44:27 +02:00
Michael Adam
4c542015a1 s3:libads/kerberos_proto.h: add _LIBADS_KERBEROS_PROTO_H_ guard 2011-05-31 01:44:27 +02:00
Michael Adam
6bf3228f28 s3:libads/kerberos_proto.h: add GPL/Copyright header 2011-05-31 01:44:27 +02:00
Michael Adam
eb5db22771 s3:libads/ads_proto.h: add _LIBADS_ADS_PROTO_H_ guard 2011-05-31 01:44:27 +02:00
Michael Adam
6e9c055ce2 s3:libads/ads_proto.h: add GPL/Copyright header 2011-05-31 01:44:27 +02:00
Michael Adam
d8f269feef s3:nmbd/nmbd_proto.h: add GPL/Copyright header 2011-05-31 01:44:27 +02:00
Michael Adam
b88d80a975 s3:winbindd/idmap_proto.h: add _WINBINDD_IDMAP_PROTO_H_ guard 2011-05-31 01:44:27 +02:00
Michael Adam
88078c8569 s3:winbindd/idmap_proto.h: add GPL/Copyright header 2011-05-31 01:44:27 +02:00
Michael Adam
447f0d356b s3:groupdb/proto.h: add _GROUPDB_PROTO_H_ guard 2011-05-31 01:44:27 +02:00
Michael Adam
f2cbced75e s3:groupdb/proto.h: add GPL/Copyright header 2011-05-31 01:44:27 +02:00
Michael Adam
2e6f8f7bda s3:smbd/proto.h: add _SMBD_PROTO_H_ guard 2011-05-31 01:44:27 +02:00
Michael Adam
e1bad49f3e s3:smbd/proto.h: add GPL/Copyright header 2011-05-31 01:44:27 +02:00
Michael Adam
ff82f77796 s3:locking/proto.h: add _LOCKING_PROTO_H_ guard 2011-05-31 01:44:27 +02:00
Michael Adam
93b8e90b5b s3:locking/proto.h: add GPL/Copyright header 2011-05-31 01:44:27 +02:00
Michael Adam
9cc1410718 s3:auth/proto.h: add _AUTH_PROTO_H_ guard 2011-05-31 01:44:27 +02:00
Michael Adam
1b7077204d s3:auth/proto.h: add GPL/Copyright header 2011-05-31 01:44:27 +02:00
Michael Adam
7d40c88695 s3:passdb/proto.h: add _PASSDB_PROTO_H_ guard 2011-05-31 01:44:27 +02:00
Michael Adam
b3cbcd0eda s3:passdb/proto.h: add GPL/copyright comment header 2011-05-31 01:44:27 +02:00
Andrew Bartlett
caf0df2dde s3-build Specify more of the smbconf dependencies
This brings more functions into util_names.c, and util_names.c into
PARAM_WITHOUT_REG_SRC.

This is not yet a full list, that would formalise the implicit
dependency loop.

Andrew Bartlett

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Tue May 31 01:43:37 CEST 2011 on sn-devel-104
2011-05-31 01:43:37 +02:00
Andrew Bartlett
3aa9eead27 s3-build Make smbregistry depend on more of the subsystems it needs
This is not the full list (that can be seen by setting
allow_undefined_symbols=True).

Andrew Bartlett
2011-05-31 00:32:08 +02:00
Andrew Bartlett
3557032494 s3-build Add util_sec subsystem 2011-05-31 00:32:08 +02:00
Andrew Bartlett
83e62de9a7 s3-build Move dbwrap_rbt into dbwrap_util subsystem 2011-05-31 00:32:08 +02:00
Andrew Bartlett
0199100348 s3-build Create dbwrap_util subsystem
This contains the functions from dbwrap that don't require lp_
functions, and can therefore be put into a library (without dependency
loops).

Andrew Bartlett
2011-05-31 00:32:08 +02:00
Andrew Bartlett
e65f4dd9d4 s3-build: Rearrange build system to seperate out simple libraries
This will slowly allow us to develop a proper dependency tree without
interlibrary loops and unresolved symbols.

Andrew Bartlett
2011-05-31 00:32:08 +02:00
Andrew Bartlett
c7131e6b73 s3-build Add dependency on 'ldap' and 'ber'
These external libraries are required for the hooks in lib/ldap_debug_handler.c
2011-05-31 00:32:08 +02:00
Andrew Bartlett
702d8d5f87 s3-lib Move free_namearray() into it's own file
This makes it easier to have conn_smbd strictly depend on all it's
dependencies.

Andrew Bartlett
2011-05-31 00:32:08 +02:00
Andrew Bartlett
3b7e1ac31c s3-lib Move realloc based string substitution functions out of util_str.c
This makes the dependency set for source3/lib/util_str.c simpiler,
which in turn makes it easier to build a dependency tree.

Andrew Bartlett
2011-05-31 00:32:08 +02:00
Andrew Bartlett
a5a2373979 s3-lib Move sstring_sub() to it's only user and make static
This should not be used more generally, as it is specifically not for
multibyte strings, and uses malloc rather than talloc.

Andrew Bartlett
2011-05-31 00:32:07 +02:00
Andrew Bartlett
8d639feed9 s3-param Move init_iconv() to loadparm.c
This assists with some dependency loops

Andrew Bartlett
2011-05-31 00:32:07 +02:00
Andrew Bartlett
381423b1bd libcli/security: move secdesc.c to the top level libcli/security
This code does not rely on lp_ or other source3 only functions, so can
be part of the common library.

Andrew Bartlett
2011-05-31 00:32:07 +02:00
Andrew Bartlett
e5dd03d199 s3-globals Remove smbd_event_context() (use server_event_context())
This has been a wrapper around server_event_context() for some time
now, and removing this from dummmysmbd.c assists with library
dependencies.

Andrew Bartlett
2011-05-31 00:32:07 +02:00
Andrew Bartlett
33e8126c3c s3-param split service.c into param and smbd components
The dependency chain of find_service can't be satisfied sensibly
outside smbd, so don't include this in the main 'param' subsystem.

Also remove the duplicate find_service() and conn_snum_used() from
dummysmbd.c: The WAF build does not need these dummies any more, but
file.

Andrew Bartlett
2011-05-31 00:32:07 +02:00
Andrew Bartlett
ade01f083c s3-smbd Split conn.c into 3 files
The idea with this split is to make it easier to handle dependencies,
avoiding having the loadparm code depend on the global server
variables, without resorting to dummy functions and linker tricks.

conn_clear_vuid_cache() is brought in from uid.c to make it static

Andrew Bartlett
2011-05-31 00:32:07 +02:00
Andrew Bartlett
4e374d1679 s3-build: Move user_util.c into it's own subsystem 2011-05-31 00:32:07 +02:00
Andrew Bartlett
53140724f1 s3-lib Move string_init functions into their own file
These have not been moved in common, as they are not talloc-based, but
it helps with dependencies if these are seperated from the rest of
util_str.c

Andrew Bartlett
2011-05-31 00:32:07 +02:00
Andrew Bartlett
8524924a46 s3-smbd provide struct smbd_server_connection * to conn_snum_used
This provides the 'sconn' parameter to this key functions, that
is currently duplicated in dummysmbd.c, which causes duplicate symbol
issues in the waf build.

This has natrually caused a number of consequential changes across the
codebase, includning not passing a messaging context into initial
reload_services():

This causes problems because the global smbd_server_connection isn't
yet set up, as there isn't a connection here, just the initial
process.

Andrew Bartlett
2011-05-31 00:32:07 +02:00
Volker Lendecke
c981d4fa12 s3: Safely mark our sconn as smb2 if we have that protocol
Otherwise smbd will crash at an unclean exit. Without this conn_close_all will
do a close_cnum() on all connection_struct's. In smb2, those are talloc
children of the smbd_smb2_tcon's. sconn is talloc_free'ed after the
conn_close_all, but the smbd_smb2_tcon destructor will still reference
tcon->compat_conn, referencing then free'ed (and null'ed out) memory.

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Mon May 30 22:49:53 CEST 2011 on sn-devel-104
2011-05-30 22:49:53 +02:00
Sumit Bose
e10f27d575 Improve documentation for net rpc trust
Add man pages entries and fix usage output.

Signed-off-by: Günther Deschner <gd@samba.org>

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Mon May 30 20:05:34 CEST 2011 on sn-devel-104
2011-05-30 20:05:34 +02:00
Gregor Beck
723ba6024c s3:net: registry export: close key after recursion returns
Signed-off-by: Michael Adam <obnox@samba.org>

Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Mon May 30 18:53:28 CEST 2011 on sn-devel-104
2011-05-30 18:53:28 +02:00
Michael Adam
0d746f653e s3:net registry: polish output of net registry enumerate[_recursive]
so that net registry enumerate output is as before, and
net registry enumerate_recursive is formatted more nicely
2011-05-30 17:42:27 +02:00
Gregor Beck
5ec479fa0c s3:net: registry: use recursive implementation for enumerate
Signed-off-by: Michael Adam <obnox@samba.org>
2011-05-30 17:42:27 +02:00
Gregor Beck
22011ddc9e s3:net: registry: add new command enumerate_recursive
Signed-off-by: Michael Adam <obnox@samba.org>
2011-05-30 17:42:27 +02:00
Gregor Beck
817c64f5de nfs4_acls: pass ACE_FLAG_INHERITED_ACE down from the client
Signed-off-by: Michael Adam <obnox@samba.org>
2011-05-30 17:42:27 +02:00
Gregor Beck
b0471303ba nfs4_acls: pass ACE_FLAG_INHERITED_ACE up to the client
Signed-off-by: Michael Adam <obnox@samba.org>
2011-05-30 17:42:27 +02:00
Gregor Beck
c967e8fae5 s3:smbcacls: fix parsing of multiple flags
Signed-off-by: Michael Adam <obnox@samba.org>
2011-05-30 17:42:27 +02:00
Günther Deschner
508e160776 s3: fix some -Wunused-but-set-variable build warnings.
Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Mon May 30 17:41:18 CEST 2011 on sn-devel-104
2011-05-30 17:41:18 +02:00