1
0
mirror of https://github.com/samba-team/samba.git synced 2025-01-12 09:18:10 +03:00
Commit Graph

37028 Commits

Author SHA1 Message Date
Andrew Bartlett
38fee2b521 s3-smbd Fix conn_msg.c: Cannot return in a void function 2011-05-31 02:57:19 +02:00
Andrew Bartlett
9d5b53921d s3-lib Improve indentation of errmap_unix
This also makes it easier to compare and contrast with the source4
version, because the differences here matter, and need to be resolved
with care.

Andrew Bartlett
2011-05-31 02:57:19 +02:00
Andrew Bartlett
aa848c12eb s3-lib: Use ARRAY_SIZE() to walk the error mapping tables
This gives a constant termination condition, and may help the compiler.

Andrew Bartlett
2011-05-31 02:57:19 +02:00
Michael Adam
6ef8122cba s3:libgpo/gpo_proto.h: add _LIBGPO_GPO_PROTO_H_ guard 2011-05-31 01:44:27 +02:00
Michael Adam
59950faddc s3:libgpo/gpo_proto.h: add GPL/Copyright header 2011-05-31 01:44:27 +02:00
Michael Adam
4c542015a1 s3:libads/kerberos_proto.h: add _LIBADS_KERBEROS_PROTO_H_ guard 2011-05-31 01:44:27 +02:00
Michael Adam
6bf3228f28 s3:libads/kerberos_proto.h: add GPL/Copyright header 2011-05-31 01:44:27 +02:00
Michael Adam
eb5db22771 s3:libads/ads_proto.h: add _LIBADS_ADS_PROTO_H_ guard 2011-05-31 01:44:27 +02:00
Michael Adam
6e9c055ce2 s3:libads/ads_proto.h: add GPL/Copyright header 2011-05-31 01:44:27 +02:00
Michael Adam
d8f269feef s3:nmbd/nmbd_proto.h: add GPL/Copyright header 2011-05-31 01:44:27 +02:00
Michael Adam
b88d80a975 s3:winbindd/idmap_proto.h: add _WINBINDD_IDMAP_PROTO_H_ guard 2011-05-31 01:44:27 +02:00
Michael Adam
88078c8569 s3:winbindd/idmap_proto.h: add GPL/Copyright header 2011-05-31 01:44:27 +02:00
Michael Adam
447f0d356b s3:groupdb/proto.h: add _GROUPDB_PROTO_H_ guard 2011-05-31 01:44:27 +02:00
Michael Adam
f2cbced75e s3:groupdb/proto.h: add GPL/Copyright header 2011-05-31 01:44:27 +02:00
Michael Adam
2e6f8f7bda s3:smbd/proto.h: add _SMBD_PROTO_H_ guard 2011-05-31 01:44:27 +02:00
Michael Adam
e1bad49f3e s3:smbd/proto.h: add GPL/Copyright header 2011-05-31 01:44:27 +02:00
Michael Adam
ff82f77796 s3:locking/proto.h: add _LOCKING_PROTO_H_ guard 2011-05-31 01:44:27 +02:00
Michael Adam
93b8e90b5b s3:locking/proto.h: add GPL/Copyright header 2011-05-31 01:44:27 +02:00
Michael Adam
9cc1410718 s3:auth/proto.h: add _AUTH_PROTO_H_ guard 2011-05-31 01:44:27 +02:00
Michael Adam
1b7077204d s3:auth/proto.h: add GPL/Copyright header 2011-05-31 01:44:27 +02:00
Michael Adam
7d40c88695 s3:passdb/proto.h: add _PASSDB_PROTO_H_ guard 2011-05-31 01:44:27 +02:00
Michael Adam
b3cbcd0eda s3:passdb/proto.h: add GPL/copyright comment header 2011-05-31 01:44:27 +02:00
Andrew Bartlett
caf0df2dde s3-build Specify more of the smbconf dependencies
This brings more functions into util_names.c, and util_names.c into
PARAM_WITHOUT_REG_SRC.

This is not yet a full list, that would formalise the implicit
dependency loop.

Andrew Bartlett

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Tue May 31 01:43:37 CEST 2011 on sn-devel-104
2011-05-31 01:43:37 +02:00
Andrew Bartlett
3aa9eead27 s3-build Make smbregistry depend on more of the subsystems it needs
This is not the full list (that can be seen by setting
allow_undefined_symbols=True).

Andrew Bartlett
2011-05-31 00:32:08 +02:00
Andrew Bartlett
3557032494 s3-build Add util_sec subsystem 2011-05-31 00:32:08 +02:00
Andrew Bartlett
83e62de9a7 s3-build Move dbwrap_rbt into dbwrap_util subsystem 2011-05-31 00:32:08 +02:00
Andrew Bartlett
0199100348 s3-build Create dbwrap_util subsystem
This contains the functions from dbwrap that don't require lp_
functions, and can therefore be put into a library (without dependency
loops).

Andrew Bartlett
2011-05-31 00:32:08 +02:00
Andrew Bartlett
e65f4dd9d4 s3-build: Rearrange build system to seperate out simple libraries
This will slowly allow us to develop a proper dependency tree without
interlibrary loops and unresolved symbols.

Andrew Bartlett
2011-05-31 00:32:08 +02:00
Andrew Bartlett
c7131e6b73 s3-build Add dependency on 'ldap' and 'ber'
These external libraries are required for the hooks in lib/ldap_debug_handler.c
2011-05-31 00:32:08 +02:00
Andrew Bartlett
702d8d5f87 s3-lib Move free_namearray() into it's own file
This makes it easier to have conn_smbd strictly depend on all it's
dependencies.

Andrew Bartlett
2011-05-31 00:32:08 +02:00
Andrew Bartlett
3b7e1ac31c s3-lib Move realloc based string substitution functions out of util_str.c
This makes the dependency set for source3/lib/util_str.c simpiler,
which in turn makes it easier to build a dependency tree.

Andrew Bartlett
2011-05-31 00:32:08 +02:00
Andrew Bartlett
a5a2373979 s3-lib Move sstring_sub() to it's only user and make static
This should not be used more generally, as it is specifically not for
multibyte strings, and uses malloc rather than talloc.

Andrew Bartlett
2011-05-31 00:32:07 +02:00
Andrew Bartlett
8d639feed9 s3-param Move init_iconv() to loadparm.c
This assists with some dependency loops

Andrew Bartlett
2011-05-31 00:32:07 +02:00
Andrew Bartlett
381423b1bd libcli/security: move secdesc.c to the top level libcli/security
This code does not rely on lp_ or other source3 only functions, so can
be part of the common library.

Andrew Bartlett
2011-05-31 00:32:07 +02:00
Andrew Bartlett
e5dd03d199 s3-globals Remove smbd_event_context() (use server_event_context())
This has been a wrapper around server_event_context() for some time
now, and removing this from dummmysmbd.c assists with library
dependencies.

Andrew Bartlett
2011-05-31 00:32:07 +02:00
Andrew Bartlett
33e8126c3c s3-param split service.c into param and smbd components
The dependency chain of find_service can't be satisfied sensibly
outside smbd, so don't include this in the main 'param' subsystem.

Also remove the duplicate find_service() and conn_snum_used() from
dummysmbd.c: The WAF build does not need these dummies any more, but
file.

Andrew Bartlett
2011-05-31 00:32:07 +02:00
Andrew Bartlett
ade01f083c s3-smbd Split conn.c into 3 files
The idea with this split is to make it easier to handle dependencies,
avoiding having the loadparm code depend on the global server
variables, without resorting to dummy functions and linker tricks.

conn_clear_vuid_cache() is brought in from uid.c to make it static

Andrew Bartlett
2011-05-31 00:32:07 +02:00
Andrew Bartlett
4e374d1679 s3-build: Move user_util.c into it's own subsystem 2011-05-31 00:32:07 +02:00
Andrew Bartlett
53140724f1 s3-lib Move string_init functions into their own file
These have not been moved in common, as they are not talloc-based, but
it helps with dependencies if these are seperated from the rest of
util_str.c

Andrew Bartlett
2011-05-31 00:32:07 +02:00
Andrew Bartlett
8524924a46 s3-smbd provide struct smbd_server_connection * to conn_snum_used
This provides the 'sconn' parameter to this key functions, that
is currently duplicated in dummysmbd.c, which causes duplicate symbol
issues in the waf build.

This has natrually caused a number of consequential changes across the
codebase, includning not passing a messaging context into initial
reload_services():

This causes problems because the global smbd_server_connection isn't
yet set up, as there isn't a connection here, just the initial
process.

Andrew Bartlett
2011-05-31 00:32:07 +02:00
Volker Lendecke
c981d4fa12 s3: Safely mark our sconn as smb2 if we have that protocol
Otherwise smbd will crash at an unclean exit. Without this conn_close_all will
do a close_cnum() on all connection_struct's. In smb2, those are talloc
children of the smbd_smb2_tcon's. sconn is talloc_free'ed after the
conn_close_all, but the smbd_smb2_tcon destructor will still reference
tcon->compat_conn, referencing then free'ed (and null'ed out) memory.

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Mon May 30 22:49:53 CEST 2011 on sn-devel-104
2011-05-30 22:49:53 +02:00
Sumit Bose
e10f27d575 Improve documentation for net rpc trust
Add man pages entries and fix usage output.

Signed-off-by: Günther Deschner <gd@samba.org>

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Mon May 30 20:05:34 CEST 2011 on sn-devel-104
2011-05-30 20:05:34 +02:00
Gregor Beck
723ba6024c s3:net: registry export: close key after recursion returns
Signed-off-by: Michael Adam <obnox@samba.org>

Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Mon May 30 18:53:28 CEST 2011 on sn-devel-104
2011-05-30 18:53:28 +02:00
Michael Adam
0d746f653e s3:net registry: polish output of net registry enumerate[_recursive]
so that net registry enumerate output is as before, and
net registry enumerate_recursive is formatted more nicely
2011-05-30 17:42:27 +02:00
Gregor Beck
5ec479fa0c s3:net: registry: use recursive implementation for enumerate
Signed-off-by: Michael Adam <obnox@samba.org>
2011-05-30 17:42:27 +02:00
Gregor Beck
22011ddc9e s3:net: registry: add new command enumerate_recursive
Signed-off-by: Michael Adam <obnox@samba.org>
2011-05-30 17:42:27 +02:00
Gregor Beck
817c64f5de nfs4_acls: pass ACE_FLAG_INHERITED_ACE down from the client
Signed-off-by: Michael Adam <obnox@samba.org>
2011-05-30 17:42:27 +02:00
Gregor Beck
b0471303ba nfs4_acls: pass ACE_FLAG_INHERITED_ACE up to the client
Signed-off-by: Michael Adam <obnox@samba.org>
2011-05-30 17:42:27 +02:00
Gregor Beck
c967e8fae5 s3:smbcacls: fix parsing of multiple flags
Signed-off-by: Michael Adam <obnox@samba.org>
2011-05-30 17:42:27 +02:00
Günther Deschner
508e160776 s3: fix some -Wunused-but-set-variable build warnings.
Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Mon May 30 17:41:18 CEST 2011 on sn-devel-104
2011-05-30 17:41:18 +02:00
Volker Lendecke
bcc08dcc52 s3: Add ioctl code to smbd_smb2_ioctl_send debug
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Mon May 30 12:47:27 CEST 2011 on sn-devel-104
2011-05-30 12:47:27 +02:00
Volker Lendecke
c7c0e4ca71 s3: Remove unused cli_session_request
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sun May 29 22:25:55 CEST 2011 on sn-devel-104
2011-05-29 22:25:55 +02:00
Volker Lendecke
4ee443d7b3 s3: Remove unused cli_connect 2011-05-29 21:17:27 +02:00
Volker Lendecke
f92b90c676 s3: Use cli_connect_nb in SMBC_server_internal 2011-05-29 21:10:26 +02:00
Volker Lendecke
040d917c10 s3: Run BAD-NBT-SESSION in make test 2011-05-29 21:10:26 +02:00
Volker Lendecke
87e99150d0 s3: Reply correctly to a bad nbt session request 2011-05-29 21:10:26 +02:00
Volker Lendecke
ef0260ddbc s3: Fix cli_bad_session_request
We expect a negative session response with a 0x82 error (called name not
present), not a 0x82 message
2011-05-29 21:10:26 +02:00
Volker Lendecke
97dcdcd5c2 s3: Simplify run_bad_nbt_session 2011-05-29 21:10:26 +02:00
Volker Lendecke
18a54fe4eb s3: Simplify cli_bad_session_request
For this purpose we don't need the full cli_state
2011-05-29 21:10:26 +02:00
Volker Lendecke
debaf40e99 s3: Add set_socket_options to cli_connect_sock()
A leftover of stuff that cli_connect() does

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sun May 29 15:47:17 CEST 2011 on sn-devel-104
2011-05-29 15:47:17 +02:00
Volker Lendecke
7d47e65e32 s3: Use cli_connect_nb in nmbd sync_child 2011-05-29 14:39:12 +02:00
Volker Lendecke
5676f817c7 s3: Remove unused attempt_netbios_session_request 2011-05-29 14:39:12 +02:00
Volker Lendecke
3f8621b5d3 s3: Use cli_connect_nb in do_connect 2011-05-29 14:39:11 +02:00
Volker Lendecke
0969c3398e s3: Use the correct guest_login field in auth_server
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sun May 29 13:57:21 CEST 2011 on sn-devel-104
2011-05-29 13:57:21 +02:00
Volker Lendecke
01386ff313 s3: Extract the guest_login field in sesssetup 2011-05-29 12:49:34 +02:00
Volker Lendecke
4ec00fd621 s3: Fix wct check in cli_sesssetup_blob_done 2011-05-29 12:49:34 +02:00
Volker Lendecke
8c1bb9b210 s3: Use cli_connect_nb in auth_server 2011-05-29 12:49:34 +02:00
Volker Lendecke
c05802f5a0 s3: Fix a type-punned warning 2011-05-29 12:49:34 +02:00
Volker Lendecke
a036dcd8f0 s3: Check password server loop earlier
We do that in the loop for the ip address anyway
2011-05-29 12:49:33 +02:00
Volker Lendecke
edfa62f2a0 s3: Use cli_connect_nb in do_message_op
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sun May 29 10:11:54 CEST 2011 on sn-devel-104
2011-05-29 10:11:54 +02:00
Volker Lendecke
8a3199e00d s3: Use cli_connect_nb in smbtorture open_nbt_connection 2011-05-28 23:04:02 +02:00
Volker Lendecke
797316ae97 s3: Use cli_connect_nb in net_rpc_check
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sat May 28 21:57:04 CEST 2011 on sn-devel-104
2011-05-28 21:57:04 +02:00
Volker Lendecke
230cb3b904 s3: Use cli_connect_nb in smbd_running() 2011-05-28 20:50:10 +02:00
Volker Lendecke
54970f90f6 s3: Use cli_connect_nb in cli_servertime 2011-05-28 20:50:10 +02:00
Volker Lendecke
06eec02e74 s3: Use cli_connect_nb in remote_password_change 2011-05-28 20:50:10 +02:00
Volker Lendecke
57ae32794f s3: Add called name_type param to cli_connect_nb 2011-05-28 20:50:09 +02:00
Volker Lendecke
c430b57ce4 s3: Fix a type-punned warning 2011-05-28 20:50:09 +02:00
Volker Lendecke
649873bcf3 s3: Use cli_connect_nb in masktest 2011-05-28 20:50:09 +02:00
Volker Lendecke
1173a4f83d s3: Fix some nonemtpy blank lines 2011-05-28 20:50:09 +02:00
Volker Lendecke
5df87913d7 s3: Use cli_connect_nb in locktest
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sat May 28 18:06:49 CEST 2011 on sn-devel-104
2011-05-28 18:06:49 +02:00
Volker Lendecke
6bf5d9a61f s3: Fix smbsock_connect
If all connection attempts fail, return immediately. Plain bug.
2011-05-28 16:57:24 +02:00
Volker Lendecke
9e05d3430f s3: Fix a tiny memleak in copy_unix_token
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sat May 28 11:47:11 CEST 2011 on sn-devel-104
2011-05-28 11:47:11 +02:00
Volker Lendecke
77ce431fdb s3: Use talloc_memdup in copy_unix_token 2011-05-28 10:39:48 +02:00
Volker Lendecke
4586f5176b s3: Fix some nonempty blank lines 2011-05-28 10:29:54 +02:00
Volker Lendecke
1c11186837 s3: Use cli_connect_nb in cli_start_connection 2011-05-28 10:29:53 +02:00
Volker Lendecke
defcd409a3 s3: Add cli_connect_nb
This builds up a cli_state until after the netbios session setup. It makes use
of smbsock_connect, so it connects to 139 and 445 simultaneously. This improves
the connection to Windows 2008 which does not listen on *SMBSERVER anymore.
2011-05-28 10:29:53 +02:00
Jeremy Allison
e05c9cdcb6 Fix bug #6911 - Kerberos authentication from vista to samba fails when security blob size is greater than 16 kB
We were not correctly checking the output of asn1_start_tag().
asn1_start_tag() returns -1 and sets data->has_error if the
remaining blob size is too short to contain the tag length.
We were checking data->has_error and returning NT_STATUS_OK
(to allow the second asn.1 parse to fail in that case). We
should not be checking data->has_error in this case, but
falling through to the code that already checks the length.

Thanks to Jim for reproducing this for me. We don't get bitten
by this as we announce a max buffer size of 16k, greater than
Windows's 4k, which means that most krb5 spnego packets already
fit.

Jeremy.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Fri May 27 02:57:27 CEST 2011 on sn-devel-104
2011-05-27 02:57:27 +02:00
Jeremy Allison
d10674326b Fix bug #8165 - Inverted WITH_SYSLOG condition in vfs_full_audit.c.
Found by freeserif@yahoo.com.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Wed May 25 22:37:23 CEST 2011 on sn-devel-104
2011-05-25 22:37:23 +02:00
Sean Finney
0f8018676a Fix numerous missing dependencies in WAF build scripts
With the recent consolidation of code between s3 and s4, a number of new
dependencies have been implicitly introduced.  For example, previous s3
code gained an implicit dependency on talloc after the charset related
consolidation (lib/util/charset/charset.h now includes talloc.h).  When
building against the embedded version of talloc this isn't a problem
since the paths are automatically added to the search path, but when
building against the external libraries build failures will occur for
all components that don't directly or indirectly include talloc as
a dependency.

Since charset.h is included from util.h, which in turn is included from
includes.h, this means most of the codebase (s3 and s4) has such an
undeclared dependency.

Therefore, samba-util-common and samba-util have been added as
dependencies to the s3 and s4 code respectively, for all cases where
the source would otherwise fail to build.  Additionally, a few other
dependencies are added in specific wscript_build files to address
similar dependency-related problems.

https://bugzilla.samba.org/show_bug.cgi?id=8128

Signed-off-by: Sean Finney <seanius@seanius.net>
Signed-off-by: Matthias Dieter Wallnöfer <mdw@samba.org>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>

Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Wed May 25 19:22:13 CEST 2011 on sn-devel-104
2011-05-25 19:22:13 +02:00
Jim McDonough
b58534f1fc s3-winbind: BUG 8166 - Don't lockout users when offline.
Windows does not track bad password attempts when offline.  We were locking users out but not honoring the lockout duration.

Autobuild-User: Jim McDonough <jmcd@samba.org>
Autobuild-Date: Wed May 25 18:11:10 CEST 2011 on sn-devel-104
2011-05-25 18:11:10 +02:00
Andrew Bartlett
ee0ee5e925 s3-testparm Warn about incorrect use of 'password server'
This merges master with v3-6-test

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Wed May 25 05:20:57 CEST 2011 on sn-devel-104
2011-05-25 05:20:57 +02:00
Andrew Bartlett
3ba32439c1 s3-param Depricate 'password server = foo:12389' syntax
This was originally intended to allow the LDAP port on a DC to be
varied, but makes little sense to change one port when in an
environment where krb5, ldap, smb and potentially DCE/RPC over TCP are
involved.

Andrew Bartlett
2011-05-25 12:13:01 +10:00
Andrew Bartlett
e7cf95c541 selftest: Make knowfail/skip files consistent, always use ^prefix
Except in one case (where we mark printing tests as knownfail), this
has all our regular expressions start with ^, which ensures we don't
accidentially mix up the samba3/samba4 prefix here.

Because of the particular values in these files at the moment, this
should not change the set of tests, but it will help to ensure that
future edits follow the correct pattern.

Andrew Bartlett
2011-05-25 09:15:18 +10:00
Holger Hetterich
13d20faa1d Actually make use of the SMBTA_SUBRELEASE define in smb_traffic_analyzer.h. This will allow to introduce new features or fixes into the protocol after the 3.6.0 release. The client software is designed to take care for the subrelease number.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Tue May 24 21:23:22 CEST 2011 on sn-devel-104
2011-05-24 21:23:22 +02:00
Jeremy Allison
309a8fd7c6 Fix bug #7054 - X account flag does not work when pwdlastset is 0.
Don't allow pass_last_set_time to be set to zero (which means
"user must change password on next logon") if user object doesn't
allow password change.

Don't automatically allow user object password change if
"user must change password on next logon" is set.

Jim please check.

Jeremy.
2011-05-24 20:14:35 +02:00
Christian Ambach
53829fd495 s3:modules properly terminate enums in nfs4 acl code
same issue as with the audit modules:
using a wrong parameter leads to smbd crash as lp_enum()
will not terminate on last entry of the array

Autobuild-User: Christian Ambach <ambi@samba.org>
Autobuild-Date: Tue May 24 20:13:39 CEST 2011 on sn-devel-104
2011-05-24 20:13:39 +02:00
Christian Ambach
425ac2c361 s3:vfs properly terminate enums in audit modules
without the proper terminations of the enums, invalid arguments
for the audit modules will lead to a smbd crash as the loop in
lp_enum() will attempt to access memory behind the array
2011-05-24 18:29:45 +02:00
Jeremy Allison
9c3e5380ec Fix bug #8150 - Ban 'dos charset = utf8'
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Tue May 24 03:52:50 CEST 2011 on sn-devel-104
2011-05-24 03:52:50 +02:00
Volker Lendecke
18ec1dab59 s3: Remove unused cli_get_nt_error
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Mon May 23 16:54:21 CEST 2011 on sn-devel-104
2011-05-23 16:54:21 +02:00
Volker Lendecke
502a9924ca s3: Remove unused cli_set_nt_error 2011-05-23 15:45:37 +02:00
Volker Lendecke
fddb944a04 s3: Remove unused cli_reset_error 2011-05-23 15:45:37 +02:00
Volker Lendecke
e77da2f408 s3: Remove a reference to cli->inbuf
This is only used for utf16 alignment calculations, "rdata" is aligned the
same way as cli->inbuf is.
2011-05-23 15:45:37 +02:00
Volker Lendecke
b1a7bdb93c s3: Remove two false references to cli->inbuf 2011-05-23 15:45:37 +02:00
Volker Lendecke
9514f96856 s3: Fix a leftover from fstring removal in cli_state
Jeremy, please check!
2011-05-23 15:45:36 +02:00
Volker Lendecke
28d7282738 s3: Remove unused cli_[en|de]crypt_message
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Mon May 23 12:15:33 CEST 2011 on sn-devel-104
2011-05-23 12:15:33 +02:00
Volker Lendecke
1a393b7cd6 s3: Directly call common_encrypt_buffer in cli_smb_req_iov_send 2011-05-23 11:06:08 +02:00
Volker Lendecke
df0e33008e s3: Remove cli_send/receive_smb
A moment of silence is due here, R.I.P.

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sun May 22 22:17:12 CEST 2011 on sn-devel-104
2011-05-22 22:17:12 +02:00
Volker Lendecke
ce9d63d161 s3: Remove the smbtorture3 OPLOCK3 test
This is the last user of cli_receive_smb. Oplocks are nowadays tested
in smbtorture4, this mainly has historic value
2011-05-22 21:07:40 +02:00
Volker Lendecke
9a787bbad1 s3: Convert the OPEN4 test to async oplock handling
This removes a caller of cli_receive_smb
2011-05-22 21:07:40 +02:00
Volker Lendecke
feb1d9fef3 s3: Remove clistr_align_out
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sat May 21 23:31:12 CEST 2011 on sn-devel-104
2011-05-21 23:31:12 +02:00
Volker Lendecke
dca321f62b s3: Remove unused cli_setup_bcc
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sat May 21 21:24:13 CEST 2011 on sn-devel-104
2011-05-21 21:24:13 +02:00
Jeremy Allison
4360c5bf27 Patch for bug #8156 - net ads join fails to use the user's kerberos ticket.
If kerberos_get_realm_from_hostname() or kerberos_get_default_realm_from_ccache() fails due to
 a misconfigured krb5.conf, try the "realm =" from smb.conf as a fallcback before going back to
 NTLMSSP (which we'll do anyway).

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Sat May 21 00:58:09 CEST 2011 on sn-devel-104
2011-05-21 00:58:09 +02:00
Jeremy Allison
e0b2f6bd26 The "workgroup" parameter is not used at all in cli_session_setup_kerberos(). Remove it. 2011-05-20 23:49:04 +02:00
Jeremy Allison
9f14d10366 Fix bug #8157 - std_pcap_cache_reload() fails to parse a cups printcap file correctly.
The parsing code made some strange assumptions about what is a printer
name, and what is a comment.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Fri May 20 22:52:23 CEST 2011 on sn-devel-104
2011-05-20 22:52:23 +02:00
Jeremy Allison
95a55e2fea Fix bug 8133 - strange behavior for the file (whose filename first character is period ) in SMB2 case.
When doing SMB2 renames, we need to match all filetypes (no attributes field in the SMB2 call).
By default a file starting with a period is returned as FILE_ATTRIBUTE_HIDDEN in Samba.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Fri May 20 19:26:04 CEST 2011 on sn-devel-104
2011-05-20 19:26:03 +02:00
Jeremy Allison
38c77db989 Optimization. If the attributes passed to can_rename() include both FILE_ATTRIBUTE_HIDDEN and FILE_ATTRIBUTE_SYSTEM then there's no point in reading the source DOS attribute, as we're not going to deny the rename on attribute match. 2011-05-20 09:18:13 -07:00
Christian Ambach
df650fa8cf s3:smbd remove unused code
in the early CTDB days, the RELEASE_IP message was defined
and some code was added to react on such a message to make
smbd exit if the IP address it was using for the server socket
is removed by CTDB.
Later, it was discovered that we need to stop smbd immediately
and logic was added to ctdb_conn to call release_ip() without
going through the messaging system.

So this code is not used and can be removed

Autobuild-User: Christian Ambach <ambi@samba.org>
Autobuild-Date: Fri May 20 16:18:24 CEST 2011 on sn-devel-104
2011-05-20 16:18:24 +02:00
Volker Lendecke
8a2eff871f s3: Fork the echo handler only after SMB1 negprot is done
This enables activating the echo responder also if SMB2 is enabled, albeit it
will only be used for SMB1 at this moment.

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Fri May 20 15:06:03 CEST 2011 on sn-devel-104
2011-05-20 15:06:03 +02:00
Volker Lendecke
af9afe9f4f s3: Fix Coverity ID 2573: UNUSED_VALUE
Andrew B., please check!
2011-05-20 13:26:04 +02:00
Volker Lendecke
f043babcbd s3: Fix an uninitialized variable 2011-05-20 13:22:27 +02:00
Stefan Metzmacher
1e472f1534 s3:testparm: don't return an error for a warning message
metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Fri May 20 13:14:39 CEST 2011 on sn-devel-104
2011-05-20 13:14:38 +02:00
Andreas Schneider
7ab9e26b60 s3-epmapper: Fixed endpoint registration.
Autobuild-User: Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date: Fri May 20 12:03:18 CEST 2011 on sn-devel-104
2011-05-20 12:03:18 +02:00
Volker Lendecke
d432c7e278 s3: Remove unused cli_setup_packet()
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Fri May 20 10:51:36 CEST 2011 on sn-devel-104
2011-05-20 10:51:36 +02:00
Christian Ambach
642c6ba2b9 Fix Bug 8152 - smbd crash in release_ip()
release_ip() needs the private_data, but it was never saved away
to feed it into release_ip() later

Autobuild-User: Christian Ambach <ambi@samba.org>
Autobuild-Date: Thu May 19 21:21:14 CEST 2011 on sn-devel-104
2011-05-19 21:21:14 +02:00
Volker Lendecke
58b77f2267 s3: Remove a use of cli_send_smb
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Thu May 19 20:11:33 CEST 2011 on sn-devel-104
2011-05-19 20:11:33 +02:00
Volker Lendecke
d753b3b063 fix the WAF build
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Thu May 19 18:46:51 CEST 2011 on sn-devel-104
2011-05-19 18:46:51 +02:00
Volker Lendecke
0645deb1b4 s3: Do central cli_set_error 2011-05-19 17:31:30 +02:00
Volker Lendecke
bc7df52653 s3: Remove the use of cli->inbuf/outbuf from cli_session_request 2011-05-19 13:46:47 +02:00
Volker Lendecke
efbed2ce90 s3: Add sync read_smb 2011-05-19 13:46:47 +02:00
Volker Lendecke
e7e43ba6a1 s3: Make read_smb_send/recv public 2011-05-19 13:46:47 +02:00
Holger Hetterich
eb57d4719f Make protocol version 2 the default protocol, and only run on version 1 if V1 is explcitly given as a module option.
I haven't received a single line of feedback on protocol v1
for at least 1 1/2 years, whereas protocol v2 has an active
userbase and more people developing around it.

This patch includes a manpage update, describing the new
version handling, as well as documenting the recent changes
making the module transfer the IP address of the client machine
as submitted with
464c69609a.

Signed-off-by: Jeremy Allison <jra@samba.org>

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Wed May 18 21:36:44 CEST 2011 on sn-devel-104
2011-05-18 21:36:44 +02:00
Andrew Bartlett
2a12424e4b s3-selftest Remove unused and unimplemented info3cache test 2011-05-18 16:12:08 +02:00
Andrew Bartlett
fa3e2fc8bb selftest: Re-enable strings.py from source3/stf as a python subunit test 2011-05-18 16:12:08 +02:00
Andrew Bartlett
06435acf3b s3-testparm Warn more on incorrect use of 'password server' 2011-05-18 16:12:08 +02:00
Andrew Bartlett
3c8de7dd66 lib/util/charset Don't allow invalid 'dos charset = utf8'
No DOS client used UTF8, and this creates subtle, difficult to
disagnose breakage of schannel (domain membership).

Andrew Bartlett
2011-05-18 16:12:08 +02:00
Andrew Bartlett
035dbce3ad s3-selftest Remove unused sambalib.py from comfychair test system
The test binary t_snprintf has moved to lib/replace
2011-05-18 16:12:08 +02:00
Andrew Bartlett
da662b82b8 s3-lib Replace StrnCaseCmp() with strncasecmp_m()
strncasecmp_m() never needs to call to talloc, and via next_codepoint()
still has an ASCII fast-path bypassing iconv() calls.

Andrew Bartlett
2011-05-18 16:12:08 +02:00
Andrew Bartlett
c615ebed6e s3-lib Replace StrCaseCmp() with strcasecmp_m()
strcasecmp_m() never needs to call to talloc, and via next_codepoint()
still has an ASCII fast-path bypassing iconv() calls.

Andrew Bartlett
2011-05-18 16:12:08 +02:00
Andrew Bartlett
7a11e5de39 s3-param: Remove unused snum2params_static 2011-05-18 16:12:08 +02:00
Andrew Bartlett
b3258addb4 s3-param: remove unused share_iterator functions 2011-05-18 16:12:08 +02:00
Andrew Bartlett
c47b078ec3 build: Add 'cap' as a dependency of samba3core 2011-05-18 16:12:08 +02:00
Andrew Bartlett
75faa9eec5 build: Make POPT_SAMBA3 a library
This avoids some duplicate symbols when libnet and libsmbclient are
linked into the same binary (smbtorture4).

Andrew Bartlett
2011-05-18 16:12:08 +02:00
Andrew Bartlett
41b3c38587 librpc/ndr Merge ndr_print_sockaddr_storage() into common code
There is no longer a reason to leave this source3 specific, and this
brings it into a library (avoiding duplicate symbols).

Andrew Bartlett
2011-05-18 16:12:08 +02:00
Andrew Bartlett
fc466282f8 build: Add rpc_client grouping library 2011-05-18 16:12:08 +02:00
Andrew Bartlett
d17367bd68 build: Add depenencies needed by Samba3 subsystems 2011-05-18 16:12:08 +02:00
Andrew Bartlett
baad855bca build: Make msrpc3 a library 2011-05-18 16:12:08 +02:00
Andrew Bartlett
2fc342c20a waf-build: Add more libraries to avoid duplicate symbols
The new source of duplicates is calling libnetapi from inside smbtorture.

Andrew Bartlett
2011-05-18 16:12:07 +02:00
Günther Deschner
d97faae7db s3-smbtorture: fix build warning (shadowed NTSTATUS variable).
Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Wed May 18 14:17:13 CEST 2011 on sn-devel-104
2011-05-18 14:17:13 +02:00
Björn Baumbach
192198ad70 s3-modules: Fix the build of gpfs.c on RHEL 6.0 with gpfs 3.4.0-4
Signed-off-by: Stefan Metzmacher <metze@samba.org>

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Wed May 18 11:58:14 CEST 2011 on sn-devel-104
2011-05-18 11:58:14 +02:00
Björn Baumbach
23e23d0836 s3-torture/nbio.c: Fix cli_errstr() usage (part of bug #7864)
Convert cli_errstr() to nt_errstr()

Signed-off-by: Stefan Metzmacher <metze@samba.org>
2011-05-18 10:55:52 +02:00
Björn Baumbach
26f7c0771b s3-client/clitar.c: Fix cli_errstr() usage (part of bug #7864)
Convert cli_errstr() to nt_errstr()

Signed-off-by: Stefan Metzmacher <metze@samba.org>
2011-05-18 10:55:15 +02:00
Björn Baumbach
25f1583b9f s3-net_rpc_printer.c: Fix cli_errstr() usage (part of bug #7864)
Convert cli_errstr() to nt_errstr()

Signed-off-by: Stefan Metzmacher <metze@samba.org>
2011-05-18 10:53:45 +02:00
Björn Baumbach
6552ed64c1 s3-libsmb/passchange.c: Fix cli_errstr() usage (part of bug #7864)
Convert cli_errstr() to nt_errstr()

Signed-off-by: Stefan Metzmacher <metze@samba.org>
2011-05-18 10:50:57 +02:00
Björn Baumbach
310502a15a s3-torture/mangle_test.c: Fix cli_errstr() usage (part of bug #7864)
Convert cli_errstr() to nt_errstr()

Signed-off-by: Stefan Metzmacher <metze@samba.org>
2011-05-18 10:50:34 +02:00
Björn Baumbach
6fd0e062d3 s3-torture: torture.c: Fix cli_errstr() usage (part of bug #7864)
Convert cli_errstr() to nt_errstr()

Signed-off-by: Stefan Metzmacher <metze@samba.org>
2011-05-18 10:49:41 +02:00
Jeremy Allison
2873429555 Fix bug #8144 - touch /mnt/newfile fails to set timestamp with CIFS client.
The extra checks added for Windows correctness in our metadata changing paths
to ensure the file handle has been opened with the correct access mask to
allow FILE_WRITE_ATTRIBUTES etc. caused problems with the POSIX open code.

The old POSIX open code maped O_RDONLY into FILE_READ, O_WRONLY into FILE_WRITE,
and O_RDWR into FILE_READ|FILE_WRITE. This patch extends the mapping to add
FILE_WRITE_ATTRIBUTES, FILE_READ_ATTRIBUTES and FILE_WRITE_EA, FILE_READ_EA to
allow POSIX opens to set these values.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Wed May 18 02:22:32 CEST 2011 on sn-devel-104
2011-05-18 02:22:32 +02:00
Jeremy Allison
9d9d7a7cfd is_my_ipaddr() should recognise loopback addresses as ours.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Tue May 17 20:05:42 CEST 2011 on sn-devel-104
2011-05-17 20:05:42 +02:00
Jeremy Allison
9dd5704aba Remove duplicate definition of SMB_VFS_NEXT_STRICT_UNLOCK. Found by herb@samba.org 2011-05-17 19:01:18 +02:00
Volker Lendecke
fc79169ca4 s3: conn->sconn in smbd_server_connection_read/write_handler
"struct smbd_server_connection" is called sconn elsewhere, avoid confusion

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Tue May 17 19:00:20 CEST 2011 on sn-devel-104
2011-05-17 19:00:20 +02:00
Stefan Metzmacher
cb227d6d14 s3:rpc_server: create lp_ncalrpc_dir() with 0755 before lp_ncalrpc_dir()/np with 0700
metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Tue May 17 13:01:14 CEST 2011 on sn-devel-104
2011-05-17 13:01:14 +02:00
Stefan Metzmacher
e0624f773c Revert "s3-rpc_server: Force ncalrpc dir to be mode 755."
This reverts commit a032c9c8fe.
2011-05-17 11:57:23 +02:00
Jeremy Allison
8cf14c21b3 Fix the SMB2 showstopper, found by an extended torture test from Volker.
In the oplock refactoring, the algorithm underwent an unnoticed change.
In 3.5.x stat_opens were silently (i.e. no explicit code had comments
explaining this) ignored when looking for oplock breaks and share mode
violations. After the refactoring, the function find_oplock_types()
no longer ignored stat_open entries in the share mode table when looking
for batch and exclusive oplocks. This patch adds two changes to find_oplock_types()
to ignore the case where the incoming open request is a stat open being
tested against existing opens, and also when the incoming open request
is a non-stat open being tested against existing stat opens. Neither
of these cause an oplock break or share mode violation. Thanks a *lot*
to Volker, who persevered in reproducing this problem.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Mon May 16 22:38:20 CEST 2011 on sn-devel-104
2011-05-16 22:38:20 +02:00
Jeremy Allison
fe21bdc43c Ensure we always write the correct incoming mid into the share mode
table entries.
2011-05-16 10:41:51 -07:00
Andreas Schneider
a032c9c8fe s3-rpc_server: Force ncalrpc dir to be mode 755.
This completes aae9353ecf.

directory_create_or_exist() is not needed cause create_pipe_sock() takes
care of setting up the directory correctly.

Andrew please check!

Autobuild-User: Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date: Mon May 16 17:54:20 CEST 2011 on sn-devel-104
2011-05-16 17:54:20 +02:00
David Disseldorp
6bfe488f29 s3-printing: remove cups_pull_comment_location from header file
Signed-off-by: Günther Deschner <gd@samba.org>

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Mon May 16 16:03:57 CEST 2011 on sn-devel-104
2011-05-16 16:03:57 +02:00
Gregor Beck
2ddfbbbdba gpfs.so: Add gpfs:syncio option
This enables optimizations for shared file access on gpfs
2011-05-16 13:58:24 +02:00
Günther Deschner
320789b890 s3-selftest: no point in running base.chkpath and base.delaywrite twice.
Thanks to Bjoern Baumbach for pointing this out!

Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
2011-05-16 12:54:33 +02:00
Andreas Schneider
01bc556d03 s3-printing: Remove obsolete and unused cups_pull_comment_location().
Signed-off-by: Günther Deschner <gd@samba.org>
2011-05-16 12:54:33 +02:00
Andreas Schneider
da1fa20104 s3-spoolss: Get the printer location from cups.
Signed-off-by: Günther Deschner <gd@samba.org>
2011-05-16 12:54:33 +02:00
Günther Deschner
854467851d s3-printing: Get the location info from cups.
Signed-off-by: Günther Deschner <gd@samba.org>
2011-05-16 12:54:33 +02:00
Andreas Schneider
d4d31b3176 s3: Added waf build header locations for clang complete.
Signed-off-by: Günther Deschner <gd@samba.org>
2011-05-16 12:54:33 +02:00
Christian Ambach
20179bb550 s3:libsmb convert user-specified domain to uppercase
with client ntlmv2 auth = yes, there is a small difference between
using smbclient -U user\domain and smbclient -U user -W domain
if domain is provided in lowercase

using -W will uppercase the given parameter, while picking the
domain name from -U will not convert it to uppercase and this
leads to failing NTLMv2 authentication

with this patch, there is no difference between
smbclient -U domain\user and smbclient -U user -W domain any more

Autobuild-User: Christian Ambach <ambi@samba.org>
Autobuild-Date: Mon May 16 11:42:55 CEST 2011 on sn-devel-104
2011-05-16 11:42:55 +02:00
Volker Lendecke
30be9fe554 s3: Make&use set_socket_addr_v4
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sat May 14 18:57:57 CEST 2011 on sn-devel-104
2011-05-14 18:57:57 +02:00
Volker Lendecke
f1cdce6c13 s3: Paranoia in smbsock_connect_state_destructor
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sat May 14 14:19:01 CEST 2011 on sn-devel-104
2011-05-14 14:19:00 +02:00
Andrew Bartlett
46168e99f7 s3-param Deprecate a number of security parameters for 3.6
This follows up on the agreement on the samba-technical list in Jan
2011 to deprecate these options, and to possibly remove these in the
4.0 release after user feedback.

Andrew Bartlett

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Fri May 13 19:51:41 CEST 2011 on sn-devel-104
2011-05-13 19:51:41 +02:00
Andrew Bartlett
816c5ccc34 s3-build: use ndr-standard in msrpc3
This avoids pulling in the symbols from the NDR_ subsystems directly.

Andrew Bartlett
2011-05-13 18:50:23 +02:00
Andrew Bartlett
f18cca9a0a lib/util/charset Move built-in charset modules to the top level
This removes the 'charset' subsystem and allows these modules to be
used across the whole of Samba.

Andrew Bartlett
2011-05-13 18:50:23 +02:00
Andrew Bartlett
ef2a7c6538 s3-netapi Initialise global variables in libnetapi
It is important to initalise the global variables when loading this
configuration for the potentially first time.

Andrew Bartlett
2011-05-13 18:50:23 +02:00
Andrew Bartlett
a37de9a959 s3-libnetapi Don't create a talloc_stackframe() in a global variable
This also ensures that libnetapi_free() invalidates the global
stat_ctx variable, and changes the API so that the behaviour of the
error string routines is to consistently return a allocated string.

Pair-Programmed-With: Günther Deschner <gd@samba.org>

Andrew Bartlett
2011-05-13 18:50:23 +02:00
Günther Deschner
3d100216b8 s3-net: fix potential crash bug in display_print_driver3().
Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Fri May 13 18:49:06 CEST 2011 on sn-devel-104
2011-05-13 18:49:06 +02:00
Michael Adam
5bcc0b2138 s3:build: install libtdb with full version number instead of only SO version
Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Fri May 13 17:45:01 CEST 2011 on sn-devel-104
2011-05-13 17:45:01 +02:00
Michael Adam
4acb8c3f59 s3:build: install libtalloc with full version number instead of only SO version 2011-05-13 16:42:25 +02:00
Michael Adam
d04efc703b s3:build: build libtalloc.so.$VERSION with full version number instead only SO version 2011-05-13 16:42:25 +02:00
Michael Adam
9c76fdd80c s3:build: build libtdb.so.$VERSION with full version number instead only SO version 2011-05-13 16:42:25 +02:00
Michael Adam
3f222513cc s3:build: link libtdb as shared lib if using shared libs at all 2011-05-13 16:42:24 +02:00
Michael Adam
23637b5789 s3:build: determine full version of libtdb for the samba build 2011-05-13 16:42:24 +02:00
Michael Adam
6c300ec4b5 s3:build: link libtalloc as shared lib if using shared libs at all 2011-05-13 16:42:24 +02:00
Michael Adam
472cabbdea s3:build: determine full version of libtalloc for the samba build 2011-05-13 16:42:24 +02:00
Michael Adam
b731b6e032 s3:build: fix typo in definition of --enable-external-libtdb 2011-05-13 16:42:24 +02:00
Michael Adam
abef191fb9 s3:build: reformat AC_ARG_ENABLE(external_libtalloc...) 2011-05-13 16:42:24 +02:00
Michael Adam
7e230b31d1 s3:build: print the full version number in the showlibs targets 2011-05-13 16:42:24 +02:00
Michael Adam
d5d53ba514 s3:build: add LIBWBCLIENT_FULLVER for consistency with SMB_LIBRARY() 2011-05-13 16:42:23 +02:00
Michael Adam
adb3fc2f1d s3:build: add an optional full version argument to the SMB_LIBRARY() macro. 2011-05-13 16:42:23 +02:00
Michael Adam
f8e32980f4 s3:configure: add --enable-smbtorture4 switch 2011-05-13 16:42:23 +02:00
Simo Sorce
d31181214c rpc_server: Always use rpc_pipe_open_interface()
This way we can configure which rpc service we actually want to connect to.
By default it uses an "embedded" interface and calls rpc_pipe_open_internal()

Signed-off-by: Günther Deschner <gd@samba.org>

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Fri May 13 14:40:26 CEST 2011 on sn-devel-104
2011-05-13 14:40:26 +02:00
Günther Deschner
62862e27bb s3-libnetjoin: fix uninitialized variable.
Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Fri May 13 01:22:18 CEST 2011 on sn-devel-104
2011-05-13 01:22:18 +02:00
Günther Deschner
04c101e873 s3-libnetapi/libnetjoin: fix uninitialized variables after the libsmbconf changes.
Guenther
2011-05-13 00:18:49 +02:00
Günther Deschner
7da530e1e4 s3-lib/smbconf: fix uninitialized error code in smbconf_reg_init().
Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Thu May 12 18:09:16 CEST 2011 on sn-devel-104
2011-05-12 18:09:16 +02:00
Günther Deschner
c1ac023b58 s3-waf: stop building smbtortre4.
Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Thu May 12 15:35:02 CEST 2011 on sn-devel-104
2011-05-12 15:35:02 +02:00
Michael Adam
26b6831164 s3:registry: add a warning debug message when the sorted subkeys is created from key_exists() 2011-05-12 11:48:30 +02:00
Michael Adam
daf5f29d49 s3:registry: recreate the sorted subkeys cache when storing keys
This is to avoid turning the next read operation into a write op.
2011-05-12 11:48:30 +02:00
Michael Adam
1a6ac6a944 s3:registry: add create_sorted_subkeys() to delete and recreate the sorted subkeys key
This is to be used from other places than the key_exists() code path.
2011-05-12 11:48:30 +02:00
Michael Adam
b1eac2daf3 s3:registry: turn create_sorted_subkeys_internal to NTSTATUS return type
(from bool)
2011-05-12 11:48:30 +02:00
Michael Adam
f5f9355ebe s3:registry: rename create_sorted_subkeys() to create_sorted_subkeys_internal() 2011-05-12 11:48:29 +02:00
Michael Adam
04f0a1cb7b s3:registry: fix a typo in a debug message 2011-05-12 11:48:29 +02:00
Volker Lendecke
2b40899bd3 s3: Slightly simplify smbd_smb2_request_next_vector
Metze, Jeremy, please check!
2011-05-12 11:48:29 +02:00
Günther Deschner
f99d6f079a s3-printing: make cups_pull_comment_location() work again.
we deal with lp_cups_server in cups_connect() already, inside the URI all our
other cups functions we use ipp://localhost, do the same here.

Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Wed May 11 11:36:07 CEST 2011 on sn-devel-104
2011-05-11 11:36:07 +02:00
Michael Adam
05e8881fef s3:librpc: remove unneded gssapi includes from source3/librpc/crypto/gse.c
These come in via the smb_krb5.h include (and lib/replace/system/kerberos.h)
in the end.

Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>

Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Tue May 10 23:12:31 CEST 2011 on sn-devel-104
2011-05-10 23:12:31 +02:00
Andreas Schneider
c31fd2b22a s3-waf: Create a public libsmconf.
Signed-off-by: Michael Adam <obnox@samba.org>
2011-05-10 19:13:22 +02:00
Andreas Schneider
6d9f330641 s3-waf: Create a registry private library.
Signed-off-by: Michael Adam <obnox@samba.org>
2011-05-10 19:13:22 +02:00
Andreas Schneider
4d391d29f8 libsmbconf: Convert smbconf_get_config() to sbcErr.
Signed-off-by: Michael Adam <obnox@samba.org>
2011-05-10 19:13:22 +02:00
Andreas Schneider
e1f0b91c5f libsmbconf: Convert smbconf_transaction_*() to sbcErr.
Signed-off-by: Michael Adam <obnox@samba.org>
2011-05-10 19:13:22 +02:00
Andreas Schneider
72d15f0c03 libsmbconf: Convert smbconf_delete_includes() to sbcErr.
Signed-off-by: Michael Adam <obnox@samba.org>
2011-05-10 19:13:22 +02:00
Andreas Schneider
d911bafea6 libsmbconf: Convert smbconf_set_includes() to sbcErr.
Signed-off-by: Michael Adam <obnox@samba.org>
2011-05-10 19:13:22 +02:00
Andreas Schneider
9f9711490a libsmbconf: Convert smbconf_get_includes() to sbcErr.
Signed-off-by: Michael Adam <obnox@samba.org>
2011-05-10 19:13:21 +02:00
Andreas Schneider
e19c4f278b libsmbconf: Convert smbconf_delete_parameter() to sbcErr.
Signed-off-by: Michael Adam <obnox@samba.org>
2011-05-10 19:13:21 +02:00
Andreas Schneider
ff5838d97a libsmbconf: Convert smbconf_get_parameter() to sbcErr.
Signed-off-by: Michael Adam <obnox@samba.org>
2011-05-10 19:13:21 +02:00
Andreas Schneider
ddc28a683f libsmbconf: Convert smbconf_set_parameter() to sbcErr.
Signed-off-by: Michael Adam <obnox@samba.org>
2011-05-10 19:13:21 +02:00
Andreas Schneider
fbd7626656 libsmbconf: Convert smbconf_delete_share() to sbcErr.
Signed-off-by: Michael Adam <obnox@samba.org>
2011-05-10 19:13:21 +02:00
Andreas Schneider
7f355e05f9 libsmbconf: Convert smbconf_get_share() to sbcErr.
Signed-off-by: Michael Adam <obnox@samba.org>
2011-05-10 19:13:21 +02:00
Andreas Schneider
7af2876e45 libsmbconf: Convert smbconf_create_share() to smbErr.
Signed-off-by: Michael Adam <obnox@samba.org>
2011-05-10 19:13:20 +02:00
Andreas Schneider
823cd472b4 libsmbconf: Convert smbconf_get_share_names() to sbcErr.
Signed-off-by: Michael Adam <obnox@samba.org>
2011-05-10 19:13:20 +02:00
Andreas Schneider
720ba8e7e7 libsmbconf: Convert smbconf_drop() to sbcErr.
Signed-off-by: Michael Adam <obnox@samba.org>
2011-05-10 19:13:20 +02:00
Andreas Schneider
9082c7cee8 libsmbconf: Convert smbconf_open() to sbcErr.
Signed-off-by: Michael Adam <obnox@samba.org>
2011-05-10 19:13:20 +02:00
Andreas Schneider
29eea4b09a libsmbconf: Convert smbconf_init() to sbcErr.
Signed-off-by: Michael Adam <obnox@samba.org>
2011-05-10 19:13:20 +02:00
Günther Deschner
019f11dd5b s3-printing: Fix double free of cups request.
We never free the request in our cups api usage except for here. The reason is
probably htis (from the cupsDoConnect API docs):

"This function sends the IPP request to the specified server, retrying and
authenticating as necessary. The request is freed with ippDelete() after
receiving a valid IPP response."

Revert "Fix a memory leak in cups_pull_comment_location"

This reverts commit fee2664dad.

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Tue May 10 17:32:58 CEST 2011 on sn-devel-104
2011-05-10 17:32:58 +02:00
Günther Deschner
3ba3f68e03 s3-printing: very obvious fix for cups_pull_comment_location().
This has been in there since 2008...

Guenther
2011-05-10 16:30:28 +02:00
Andrew Tridgell
628fcd111a s3-events: tevent_internal.h is not a public header
We need to use the "foo.h" form instead of the <foo.h> form for
headers that are not installed publicly. Otherwise when an external
version of tevent is used we won't find the header and the build will
fail.

Note that this creates a structure dependency between the
tevent structures in the external library and the headers in our
source tree. That is not ideal, but is currently OK as the waf build
will only use the external library if it is at least the same version
as the internal tree, which means it will actually be the same
version, as we release the external version from our tree.

We should come up with a better solution, but for now this allows
openchange to build again.

Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Tue May 10 16:06:40 CEST 2011 on sn-devel-104
2011-05-10 16:06:40 +02:00
Volker Lendecke
44cc165627 s3: Use tevent_req_ntstatus properly in a few places
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Tue May 10 13:11:10 CEST 2011 on sn-devel-104
2011-05-10 13:11:10 +02:00
Volker Lendecke
06a2ff5796 s3: Use tevent_req_ntstatus properly in a few places 2011-05-10 12:10:25 +02:00
Rusty Russell
87e3542174 async_smb.c: convert cli->timeout properly
I have a test failure on my 32-bit Ubuntu system, in that
samba3.smbtorture_s3.plain(s3dc).LOCK9 immediately times out (rather than
waiting 5 seconds for the child).

Debugging revealed this code: timeout is in ms and is set to > 1000 in
various places.  The code dates from 2002, and other perturbations didn't
reveal why it breaks now, but fix it anyway.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

Autobuild-User: Rusty Russell <rusty@rustcorp.com.au>
Autobuild-Date: Tue May 10 12:09:07 CEST 2011 on sn-devel-104
2011-05-10 12:09:07 +02:00
Rusty Russell
7deeacae2b gencache: don't use CLEAR_IF_FIRST as fallback.
CLEAR_IF_FIRST only works if *all* openers use that flag.

So just truncate the file: it's racy, but that's what we're doing anyway.

We'd really need a TDB_OPENCHECK_OR_CLEAR flag to do this properly (or in
TDB2, a open hook at the right point).

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2011-04-19 12:06:05 +09:30
Andrew Bartlett
7e8f086798 s3-build: Move generated config.h and config.h.in to include/autoconf
This ensures that these are not found by the waf build, which causes
issues when the wrong config.h is used by the recursive smbtorture build

Andrew Bartlett
2011-05-09 11:21:09 +02:00
Andrew Bartlett
aae9353ecf ncalrpc: Force ncalrpc dir to be mode 755 in all users
This allows this directory to be shared between Samba3 and Samba4 in a
Franky-style setup easily.

Andrew Bartlett
2011-05-08 19:00:29 +02:00
Andrew Bartlett
f52c6eeacc s3-auth Add auth_samba4 module
This module makes a direct call into the Samba4 auth stack to
authenticate Samba4 uses in a Samba3 file server.  The direct call
avoids the need to obtain schannel credentials.

Andrew Bartlett

Pair-Programmed-With: Andrew Tridgell <tridge@samba.org>
2011-05-08 19:00:28 +02:00
Andrew Bartlett
a47c7f6b4c s3-passdb: added pdb_samba4
This uses direct LDB operations and calls to the dsdb library to allow
passdb operations (such as pdbedit and smbpasswd) offline, and uses
transactions internally for database consistency.

Pair-Programmed-With: Andrew Tridgell <tridge@samba.org>
2011-05-08 19:00:28 +02:00
Andrew Bartlett
25cfa29e29 s3-passdb Redirect domain GUID and SID queries to the passdb stack
This is done if the passdb module supports PDB_ADS, and ensures that a
random SID is never made up locally for these directories.

This is only enabled when in the waf build, due to dependency issues.

Andrew Bartlett
2011-05-08 17:48:33 +02:00
Andrew Bartlett
d1df1cb714 build: Allow the C code to know if this is a waf build
This allows addition of functionality that can't be handled (for
example, due to dependencies) in the autoconf build.

Andrew Bartlett
2011-05-08 17:36:25 +02:00
Andrew Tridgell
64adea3d85 s3-test: build smbtorture with --enable-developer
this makes debugging of tests much easier, as we get debug symbols
2011-05-08 12:57:04 +02:00
Andrew Bartlett
897ef820a4 s3-lib Use common lib/socket code for get_interfaces() et al 2011-05-08 12:57:04 +02:00
Andrew Tridgell
45e26fdeec s3-smbd: expose smbd_set_server_fd()
this allows the fd to be setup by subsystems that want to use the s3
server core code

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Sun May  8 12:01:13 CEST 2011 on sn-devel-104
2011-05-08 12:01:13 +02:00
Andrew Tridgell
2c569cd8ba s3-waf: expose the server_exit code in the smbd_base library
these functions are called from the rest of smbd_base
2011-05-08 11:00:23 +02:00
Andrew Bartlett
f946668b7a Improve debug messages when creating socket directories
This makes clear what the permissions error and directory name actually is

Andrew Bartlett
2011-05-08 10:56:28 +02:00
Andrew Tridgell
8b2ba64d60 libds: moved enum security_types to a common header
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
2011-05-08 10:56:27 +02:00
Andrew Bartlett
c3bb5b04e2 s3-utils Set dyn_CONFIGFILE from -c on smbpasswd command line
This is similar to the code in popt_common and allows the smb.conf to
be re-loaded from this file later in the code (or for Samba4 plugins
to attempt to parse the same smb.conf).

Andrew Bartlett
2011-05-08 10:56:27 +02:00
Volker Lendecke
622faa2687 s3: Fix including libsmb/proto.h without prior ads.h
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sat May  7 11:38:11 CEST 2011 on sn-devel-104
2011-05-07 11:38:11 +02:00
Gordon Ross
ac25835ab7 Fix Samba3 on OpenIndiana.
I'd like Samba to use the native OpenLDAP and MIT Kerberos libs.
Attached are some patches to do that. (relative to git master)
It does not build for me without these.

(OpenIndiana is an off-shoot of OpenSolaris  See http://www.openindiana.org)

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Sat May  7 02:20:14 CEST 2011 on sn-devel-104
2011-05-07 02:20:14 +02:00
Jeremy Allison
f7b3909103 A couple more off-by-one calculations with strlcpy.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Fri May  6 18:39:17 CEST 2011 on sn-devel-104
2011-05-06 18:39:17 +02:00
Günther Deschner
1e208a7057 s3-includes: no need to globally include libads/ads_status.h.
Guenther
2011-05-06 16:37:22 +02:00
Günther Deschner
675573d54b s3-includes: finally only include client.h when libsmb is used.
Guenther
2011-05-06 16:37:22 +02:00