1
0
mirror of https://github.com/samba-team/samba.git synced 2024-12-28 07:21:54 +03:00
Commit Graph

22992 Commits

Author SHA1 Message Date
Derrell Lipman
c638a84cb1 r24410: - I got tricked by function naming. Contrary to what seemed obvious to me,
prs_mem_free() is not the function to be called to free memory allocated by
  prs_alloc_mem().  I've added a comment so others may not get bitten too.

- Remove incorrect memory free calls added yesterday to replace SAFE_FREE.
  The memory is actually now on a talloc context, so gets freed by the caller
  when that context is freed.  We don't need to free it iternally.

Derrell
(This used to be commit 2fde343150)
2007-10-10 12:29:41 -05:00
Volker Lendecke
a12e7ef30a r24409: Check wct in reply_open
(This used to be commit ee6f212ed0)
2007-10-10 12:29:41 -05:00
Volker Lendecke
ec5b2a7181 r24408: Remove reply_prep_legacy from reply_lockingX
(This used to be commit e0db5fd11b)
2007-10-10 12:29:41 -05:00
Volker Lendecke
29df25351d r24406: Push reply_prep_legacy into reply_lockingX
(This used to be commit bce87ebdc0)
2007-10-10 12:29:41 -05:00
Volker Lendecke
439d6020e9 r24405: Check wct in reply_lockingX
(This used to be commit c4972632f8)
2007-10-10 12:29:41 -05:00
Volker Lendecke
ae89ba48ec r24404: Remove get_OutBuffer usage from blocking.c
(This used to be commit cb8fab5663)
2007-10-10 12:29:41 -05:00
Volker Lendecke
e0880fa7bd r24403: Remove reply_prep_legacy from send_nttrans_replies
(This used to be commit a6400ca6e2)
2007-10-10 12:29:40 -05:00
Volker Lendecke
df6edb0d3c r24402: Fix a 64-bit warning
(This used to be commit 73d99d6f9a)
2007-10-10 12:29:40 -05:00
Volker Lendecke
f7f176dd0d r24401: Push reply_prep_legacy into send_nt_replies
(This used to be commit 489436a656)
2007-10-10 12:29:40 -05:00
Volker Lendecke
52a738301a r24400: Fix a valgrind bug
(This used to be commit 7c65deaed7)
2007-10-10 12:29:40 -05:00
Volker Lendecke
6a5bdb79e1 r24399: Change change_notify_reply to use send_nt_replies_new
(This used to be commit be67bb50ee)
2007-10-10 12:29:40 -05:00
Volker Lendecke
b41b38031f r24398: Convert call_nt_transact_notify_change to the new API
(This used to be commit 607b3ab8bc)
2007-10-10 12:29:40 -05:00
Volker Lendecke
bba684f2c0 r24394: Convert call_nt_transact_rename to the new API
(This used to be commit 189876a664)
2007-10-10 12:29:39 -05:00
Volker Lendecke
4f111b6e78 r24393: Convert call_nt_transact_set_user_quota to the new API
(This used to be commit 4cb60abd4c)
2007-10-10 12:29:39 -05:00
Volker Lendecke
3038f27a59 r24392: Minor simplifications
(This used to be commit 96a9435874)
2007-10-10 12:29:39 -05:00
Volker Lendecke
4b485d807e r24391: Convert call_nt_transact_get_user_quota to the new API
(This used to be commit 0e47a6643e)
2007-10-10 12:29:39 -05:00
Derrell Lipman
83fc92c82c r24388: - ACL retrieval provided incomplete information because the buffer pointer was
incremented too far in some circumstances.  In these cases, only the first
 of multiple concatenated strings would be seen.

- Working on bug 4649 pertaining to delete an ACL, this fixes the reported
 crash.  It appears to have been an incomplete switchover from malloc to
 talloc, as the memory was still being freed with SAFE_FREE.

 Deleting ACLs still doesn't work.  Although a valid request is sent to the
 server and a SUCCESS response is returned, the method that's used in
 libsmbclient for deleting ACLs seems to be incorrect.  In looking at the
 samba4 torture tests, it appears that we should be turning on the INHERIT
 flag if we want to delete the ACL.  (I could use some assistance on the
 proper flags to send, from anyone familiar with this stuff.)

- Apply patch from SATOH Fumiyasu to fix bug 4750.  smbc_telldir_ctx() was not
  returning a value useful to smbc_lseekdir_ctx().

Derrell
(This used to be commit 2ac502e29b)
2007-10-10 12:29:39 -05:00
Jeremy Allison
d701a47c73 r24387: Convert readbraw to the new api. Volker, keep checking in
your patches please :-). I'll work on SMBreadBmpx tomorrow.
Jeremy.
(This used to be commit 27e183afa8)
2007-10-10 12:29:38 -05:00
Jeremy Allison
5cc0a6b43c r24386: Piss off Volker (not deliberately) by checking in a reply_mknew -> conversion.
Sorry vl, remove one of your 15 patches :-).
Jeremy.
(This used to be commit a7648ed9d4)
2007-10-10 12:29:38 -05:00
Volker Lendecke
6624bf7fd2 r24385: Convert call_nt_transact_query_security_desc to the new API
(This used to be commit f44e0aac2b)
2007-10-10 12:29:38 -05:00
Volker Lendecke
ff355558e3 r24384: Convert call_nt_transact_set_security_desc to the new API
(This used to be commit 925ed1e186)
2007-10-10 12:29:38 -05:00
Volker Lendecke
89dfa3883f r24383: Convert call_nt_transact_ioctl to the new API
(This used to be commit 8e6485e078)
2007-10-10 12:29:38 -05:00
Volker Lendecke
89f27bb35b r24382: Remove reply_prep_legacy from call_nt_transact_create
(This used to be commit 73392485f4)
2007-10-10 12:29:37 -05:00
Volker Lendecke
8590265e94 r24381: Push reply_prep_legacy into call_nt_transact_create
(This used to be commit ca18ba96be)
2007-10-10 12:29:37 -05:00
Volker Lendecke
20b3daec50 r24368: Push down reply_prep_legacy one level
Not pretty, but necessary to convert the calls one by one
(This used to be commit 523a463be4)
2007-10-10 12:29:37 -05:00
Volker Lendecke
1b034a8f9e r24367: Push reply_prep_legacy into handle_nttrans
(This used to be commit 8b5e51c266)
2007-10-10 12:29:37 -05:00
Volker Lendecke
2a375f12be r24362: Initialize padding also when no params are sent back
(This used to be commit 03c5e960a2)
2007-10-10 12:29:36 -05:00
Volker Lendecke
1d8e64aece r24361: Push reply_prep_legacy down in reply_nttrans[s]
(This used to be commit d97a2e91d3)
2007-10-10 12:29:36 -05:00
Günther Deschner
968c43f874 r24360: Make ndr_print_debug_helper() output readable.
Guenther
(This used to be commit 45ee3b55d5)
2007-10-10 12:29:36 -05:00
Volker Lendecke
6216cd58c2 r24359: Fix the build
(This used to be commit b2ac1a3ec5)
2007-10-10 12:29:36 -05:00
Volker Lendecke
6bee410431 r24358: Push reply_prep_legacy into reply_nttrans[s]
(This used to be commit 197c231079)
2007-10-10 12:29:36 -05:00
Volker Lendecke
ecb32af916 r24357: Check wct in reply_nttrans[s]
(This used to be commit 9ab87e644e)
2007-10-10 12:29:35 -05:00
Volker Lendecke
2d8e4456cd r24356: Add send_nt_replies_new wrapper
(This used to be commit 8a910d37cc)
2007-10-10 12:29:35 -05:00
Stefan Metzmacher
5af3e2d613 r24355: move reply_outbuf() to the place where it's used
metze
(This used to be commit c7ed550483)
2007-10-10 12:29:35 -05:00
Volker Lendecke
b01978f2a9 r24354: Remove offsetof macro
Samba4 seems not to suffer from it
(This used to be commit d93b5d50a0)
2007-10-10 12:29:35 -05:00
Kai Blin
0bb638a798 r24353: Add a getpwuid lookup to wbinfo.
Merged from my Samba4 GSoC branch.
Volker, can you check if that's done the way you thought?
(This used to be commit f8560ea66c)
2007-10-10 12:29:32 -05:00
Volker Lendecke
5d39acf2f8 r24351: Remove reply_prep_legacy from reply_read_and_X
(This used to be commit 8f3e3a2100)
2007-10-10 12:29:32 -05:00
Volker Lendecke
2fb27fcb69 r24349: For large read&x we need more than 64k of outbuf.
(This used to be commit f7e2eec35f)
2007-10-10 12:29:32 -05:00
Volker Lendecke
a0ad547ccb r24348: Do not use inbuf/outbuf in the sendfile path of read_and_X
(This used to be commit 595ea708ee)
2007-10-10 12:29:31 -05:00
Volker Lendecke
6dcf0c64cf r24347: fake_sendfile does not need Inbuf/Outbuf
In the future, we might put the new Linux splice(2) syscall here. This
should also work for reply_write, but getting that in is a bit trickier.
We need to decide very early before fetching the whole buffer that we
have a write call.
(This used to be commit 32921c878a)
2007-10-10 12:29:31 -05:00
Volker Lendecke
d198962d14 r24346: Push reply_prep_legacy into send_file_readX
(This used to be commit cded66a7dc)
2007-10-10 12:29:31 -05:00
Jelmer Vernooij
db2666759d r24341: Make libreplace provide offsetof.
(This used to be commit 4a5fa715a6)
2007-10-10 12:29:31 -05:00
Jelmer Vernooij
594bbfcdee r24340: Use standard data type uint32_t rather than tdb-specific u32.
(This used to be commit 26d1430283)
2007-10-10 12:29:30 -05:00
Volker Lendecke
921fbb25eb r24332: schedule_aio_read_and_X does not need InBuf/OutBuf
(This used to be commit 9ad91bd205)
2007-10-10 12:29:30 -05:00
Volker Lendecke
ef6c3a3c7a r24331: Fix an error where gid_t != 32 bit
(This used to be commit 748fdfbd7b)
2007-10-10 12:29:30 -05:00
Volker Lendecke
1b69659315 r24330: Fix a 64-bit error
(This used to be commit 30fd903465)
2007-10-10 12:29:30 -05:00
Volker Lendecke
99a1f5a75c r24329: Fix a 64-bit bug
enums are not necessarily represented as 32-bit uints. On assignment
(see line 1029) implicit conversion happens, but not when pointers are
taken.
(This used to be commit 67ec6863dd)
2007-10-10 12:29:30 -05:00
Volker Lendecke
d90f6fa1bd r24328: Restore chain_reply error handling
Get the whole smb header from the second chained function, in particular
the error fields
(This used to be commit 0eb831ca0e)
2007-10-10 12:29:30 -05:00
Volker Lendecke
26f6826dfc r24327: First round of fixes to chain_reply
The argument to smb_setlen does not contain the nbt header of 4 bytes

The chained function might allocate outbuf itself (as now happens with
reply_read_and_X). This would erroneously overwrite the caller's outbuf.
Give it an outbuf pointer of it's own
(This used to be commit f923bba908)
2007-10-10 12:29:29 -05:00
Volker Lendecke
bf47a89c98 r24326: Fix the build for Solaris CC
(This used to be commit 7af4c1f547)
2007-10-10 12:29:29 -05:00