1
0
mirror of https://github.com/samba-team/samba.git synced 2025-01-26 10:04:02 +03:00

54829 Commits

Author SHA1 Message Date
Tim Prouty
c9b8a01714 s3: Finish plumbing the fsp->fsp_name smb_fname conversion through the modules. 2009-07-20 17:26:57 -07:00
Tim Prouty
5a8d70d465 s3: Change fsp->fsp_name to be an smb_filename struct! 2009-07-20 17:26:56 -07:00
Tim Prouty
635e5e7ff0 s3 onefs oplocks: Replace static fstring with talloc'd dbg_ctx() 2009-07-20 17:26:56 -07:00
Tim Prouty
12a5db45e2 s3: Change file_structs to be allocated with talloc instead of malloc 2009-07-20 17:26:56 -07:00
Tim Prouty
04c3dfde0f lib util: Fix const warning 2009-07-20 16:08:24 -07:00
Jeremy Allison
9357049171 Make cli_send_mailslot() static. Preparing to do away with unexpected.tdb....
Jeremy.
2009-07-20 15:15:08 -07:00
Rusty Russell
54a51839ea Make tdb transaction lock recursive (samba version)
This patch replaces 6ed27edbcd3ba1893636a8072c8d7a621437daf7 and
1a416ff13ca7786f2e8d24c66addf00883e9cb12, which fixed the bug where traversals
inside transactions would release the transaction lock early.

This solution is more general, and solves the more minor symptom that nested
traversals would also release the transaction lock early.  (It was also suggestd in
Volker's comment in 6ed27ed).

This patch also applies to ctdb, if the traverse.c part is removed (ctdb's tdb
code never received the previous two fixes).

Tested using the testsuite from ccan (adapted to the samba code).  Thanks to
Michael Adam for feedback.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Michael Adam <obnox@samba.org>
2009-07-20 22:17:20 +02:00
Jelmer Vernooij
c80783eafd Re-add accidently removed shares test. 2009-07-20 13:34:50 +02:00
Andrew Bartlett
09135ee5a0 s4:kdc Add in a simple check for constrained delegation to self
To do this properly, we must use the PAC, but for now this is enough
to check that we are delegating to another name on the same host
(which must be safe).

(Windows 7 does this a lot, also noted in bug 6273)

Andrew Bartlett
2009-07-20 14:21:18 +10:00
Matthias Dieter Wallnöfer
2fc5331e5c [SAMBA 4 directory] Refactoring and clean up of directory structure
- Adds more system objects which make sense to have them in SAMBA 4 also to
  have them when we add more and more services related to the directory (volume
  support, DFS, replication service, COM...)
- Make sure that "isCriticalSystemObject" and "showInAdvancedViewOnly" attributes
  are set correctly on each object
2009-07-20 14:21:09 +10:00
Jelmer Vernooij
7889823783 pidl: Print actual type names in errors about unknown origins rather than 'HASH(0x....)'. 2009-07-19 21:12:56 +02:00
Jelmer Vernooij
54a2f51d57 pidl: Print proper errors when arrays don't have a specified size rather than spewing pages of perl warnings. 2009-07-19 20:42:52 +02:00
Jelmer Vernooij
54670bb400 Remove unused parameter setting. 2009-07-19 18:58:22 +02:00
Jelmer Vernooij
478446f96d Remove unnecessary imports. 2009-07-19 18:51:15 +02:00
Jelmer Vernooij
8557d14f65 Merge branch 'master' of git://git.samba.org/samba 2009-07-19 17:39:23 +02:00
Jelmer Vernooij
4447bd96b9 Include ntsvc NDR in libndr-standard. 2009-07-19 17:18:04 +02:00
Jelmer Vernooij
de2a9fb607 Remove unused variable. 2009-07-19 17:17:23 +02:00
Slava Semushin
11fa3ed9ee source4/lib/registry/patchfile.c(reg_diff_load): fixed possible resource leak.
File descriptor leaks when write(2) fails and we are returning from
function.

Found by cppcheck:
[./source4/lib/registry/patchfile.c:319]: (error) Resource leak: fd
2009-07-19 16:01:12 +02:00
Slava Semushin
5f8df16471 lib/util/util_file.c(file_save): fixed file descriptor leak when read(2) fails.
Found by cppcheck:
[./lib/util/util_file.c:383]: (error) Resource leak: fd
2009-07-19 16:00:39 +02:00
Matthieu Patou
a817cff5a0 Fix broken password quality check
This fixes broken password tests when the passwords contain non ASCII characters
(e.g. accentuated chars like ('e, `e, ...)
2009-07-19 16:00:19 +02:00
Matthias Dieter Wallnöfer
295c3724a3 Fix typo 2009-07-19 16:00:14 +02:00
Matthias Dieter Wallnöfer
cb53b78080 [SAMBA 4] Some cosmetic changes for the LDB modules
Some corrections which make the code a bit more readable (no functional changes here)
2009-07-19 15:59:13 +02:00
Matt Kraai
dbedfc318e include unix.h if it's available 2009-07-19 15:59:03 +02:00
Matthias Dieter Wallnöfer
5b4cb31ef1 Cosmetic correction
Changes the order of two commands. First set up the "priv" structure, then
assign it to the "ntvfs" structure.
2009-07-19 15:58:45 +02:00
Jelmer Vernooij
de04e00ec2 Merge more ndr interfaces into libndr-standard. 2009-07-19 15:39:52 +02:00
Jelmer Vernooij
63a6ca084d librpc: Integrate some subsystems now part of libndr-standard and integrate ndr_dfs in libndr-standard. 2009-07-19 13:41:04 +02:00
Jelmer Vernooij
28d155499a Add missing includes. 2009-07-19 13:39:38 +02:00
Jelmer Vernooij
7a765b65b7 provision: Remove unused imports. 2009-07-19 13:19:54 +02:00
Jelmer Vernooij
d8ce8f9b61 Create libndr-standard, which includes the NDR marshalling code for
the "standard" set of DCE/RPC interfaces found on Windows.
2009-07-19 12:41:09 +02:00
Jelmer Vernooij
04c1d02021 Remove unnecessary include, update README. 2009-07-19 12:15:59 +02:00
Jelmer Vernooij
5bf6203bc2 Remove outdated status file about samba3 -> samba4 upgrade project. 2009-07-19 12:10:47 +02:00
Volker Lendecke
ce378e7c51 Fix a few type errors in VFS modules 2009-07-19 02:36:59 +02:00
Jelmer Vernooij
27087e6a87 VFS examples: Update copy of config.{guess,sub}. 2009-07-18 20:04:11 +02:00
Jelmer Vernooij
7883897b8d python: Set right ldb modules directory when using system ldb. 2009-07-18 18:39:20 +02:00
Jelmer Vernooij
d884fcf9a0 Actually fill in ldb modules directory. 2009-07-18 18:28:57 +02:00
Jelmer Vernooij
d356669492 Remove pyldb_util and simply duplicate the 5-line function it contains,
rather than creating a separate shared library for it.
2009-07-18 16:11:21 +02:00
Jelmer Vernooij
8c5aff207d ldb: Display SHLD_FLAGS when building. 2009-07-18 10:37:59 +02:00
Jeremy Allison
0259a303f4 Fix Coverity CIDs 887, 888. Don't pass NULL's to functions
that deref them.
Jeremy.
2009-07-17 21:50:33 -07:00
Jeremy Allison
0bd13fda76 Fix Coverity CID 928. Removed check as this can never be null.
Jeremy.
2009-07-17 21:40:23 -07:00
Jeremy Allison
3036a9c7c1 Fix Coverity CID 929. Potential NULL deref after code refactoring.
Jeremy.
2009-07-17 21:36:55 -07:00
Jeremy Allison
d654782806 Fix coverity CID 930. Pointer check can never be null here.
Jeremy
2009-07-17 21:29:28 -07:00
Jeremy Allison
7254898bc7 Fix coverity CID 931. This check is redundent as smb_fname can
never be null in this function.
Jeremy.
2009-07-17 21:26:16 -07:00
Jeremy Allison
eba2eb45e2 Fix a typo reading uninitialized memory. Caught by valgrind.
Jeremy.
2009-07-17 18:05:10 -07:00
Jeremy Allison
55b4231c77 Move the initialization of smbd_server_conn from smbd/process,
after the accept and fork, to smbd_init_globals(), so it's
done immediately on server startup. This is needed as some
messages are sent to all active smbd processes (including
the master listening daemon). If it gets a message that
forces it to scan it's current connections (ie. conn_find())
then it discovers that sconn->smb1.tcons.Connections dereferences
null (as sconn == NULL in the parent) and crashes. Yes,
I could fix all cases where sconn is used and explicitly
check for NULL but this fix is easier. It means that
the smbd_event_context() is initialized in the master
daemon and then re-initialized after fork, but that
should be being done correctly in every fork call anyway.
Without this change the previous fix 6a9e0039100b57f9626e87defec6720c476b9789
still panics in the reproducible test case for bug
6564, as this is one case where such a message
(MSG_SMB_CONF_UPDATED) is sent to the parent. Metze
please check. This change passes valgrind.
Jeremy.
2009-07-17 17:57:48 -07:00
Jeremy Allison
6a9e003910 Fix bug #6564 - SetPrinter fails (panics) as non root.
Missing become_root()/unbecome_root() around reload_services.
Jeremy.
2009-07-17 17:36:26 -07:00
Volker Lendecke
33251da861 3.4 is released... 2009-07-17 22:40:24 +02:00
Günther Deschner
3b44c0c21e s4-spoolss: fix the build after OsVersion changes.
Guenther
2009-07-17 17:20:30 +02:00
Günther Deschner
1a7a8d4330 spoolss: fill in some unknowns in spoolss_OSVersion and spoolss_OSVersionEx.
Guenther
2009-07-17 17:20:30 +02:00
Bo Yang
f394fa7766 s3: add failure check.
Signed-off-by: Bo Yang <boyang@samba.org>
2009-07-18 14:12:26 +08:00
Günther Deschner
ffbcf3b491 s3-rpcclient: add createprinteric command.
Guenther
2009-07-17 15:40:18 +02:00