1
0
mirror of https://github.com/samba-team/samba.git synced 2025-01-27 14:04:05 +03:00

59323 Commits

Author SHA1 Message Date
Jeremy Allison
cd18695fc2 Suplementary patch for bug #7104 - "wide links" and "unix extensions" are incompatible.
Bug reported by Ralf Zimmermann <r.zimmermann@siegnetz.de>. Reproduced by jra.

If the target directory of a share doesn't exist, but is designed to
be created by a "root preexec" script call, then the widelinks check
is done too early - thus preventing the user from connecting to the
share.

Fix is to re-arrange the order of checks in make_connection_snum()
to always do the following order of operations:

(1). Turn off wide links if unix extensions = yes.
(2). Call any root preexec scripts.
(3). Canonicalize the share path to remove any symlinks (ie. end
up with the realpath in the connection_struct).

Jeremy.
2010-02-11 10:19:33 -08:00
Matthias Dieter Wallnöfer
14c4c2c735 ldb_match - Ignore ":dn" part of extended matches for now
It's not fully clear what this ":dn" part means for us. What we know is that
older AD implementations (Windows Server 2000, 2003) need it to have extended
matches working in the expected way.

To be able to interoperate with s3's winbind and other tools I and gd decided
to transform this into a warning until we know what to do.

This should fix bug #6511.
2010-02-11 15:51:56 +01:00
Andrew Tridgell
45defdb90c s4-provision: import the R2 functional level
this makes it easier to modify the script to set us at R2 level in
provision. We should make this a parameter.
2010-02-12 01:08:12 +11:00
Andrew Tridgell
960fab4bba s4-build: avoid finding python symlinks
emacs creates symlinks to .py files while you are editing them. This
could cause build failures.
2010-02-12 01:08:12 +11:00
Andrew Tridgell
4aaa7fe43b s4-provision: fixed --function-level option to provision
we need the DS_DOMAIN_* levels imported
2010-02-12 01:08:11 +11:00
Andrew Tridgell
802f6b71dd s4-script: make enablerecyclebin use system_session
This allows it to work against our local ldb
2010-02-12 01:08:11 +11:00
Andrew Tridgell
9ba0d105cc s4-pyldb: null terminate string ldb message elements from python
We need to eventually get rid of ldb_msg_find_attr_as_string() (or add
a mem_ctx to it), but meanwhile we have too many places that break if
we don't add a nul to the end of ldb msg strings from python.
2010-02-12 01:08:11 +11:00
Andrew Tridgell
76a2e936a0 libds: added recyclebin feature GUID 2010-02-12 01:08:11 +11:00
Günther Deschner
2a0b16c430 s3: re-run make samba3-idl.
Guenther
2010-02-11 13:32:44 +01:00
Günther Deschner
a16e974593 spoolss: allow to set server architecture via parametric option.
This allows to set "spoolss:architecture = 'Windows x64'" for debugging purpose.

Guenther
2010-02-11 13:29:59 +01:00
Günther Deschner
25001bbd1b s3-spoolss: implement spoolss_EnumJobs level 3.
Level 3 has been added with NT 4.0 and Windows 7 (at least 64bit version) makes
use of it in order to display queued jobs. Windows 7 will *not* fall back to
level 2 if we just return WERR_UNKNOWN_LEVEL, instead there will be no printjobs
displayed at all.

Guenther
2010-02-11 13:27:46 +01:00
Günther Deschner
5e1dd19221 testprogs: one more error code for spoolss test.
Guenther
2010-02-11 13:26:13 +01:00
Günther Deschner
4f8a4cb81b testprogs: print secdesc->Control in spoolss test.
Guenther
2010-02-11 13:24:41 +01:00
Günther Deschner
490e1f84fe testprogs: use ConvertSidToStringSid in order to print sids in spoolss test.
Guenther
2010-02-11 13:24:41 +01:00
Fernando J V da Silva
7bd7194c2b s4-drs: Add DRSUAPI_DRS_NONGC_RO_REP bit to DRS_OPTIONS
Signed-off-by: Matthias Dieter Wallnöfer <mwallnoefer@yahoo.de>
2010-02-11 12:19:51 +01:00
Andrew Tridgell
f78a534dd2 s4-net-drs: fix some coding style issues
We should use the system/*.h headers for system includes. We also try
to avoid C++ comments.

Signed-off-by: Andrew Tridgell <tridge@samba.org>
2010-02-11 21:59:40 +11:00
Kamen Mazdrashki
976201d24a s4/net_drs: 'net drs kcc' command implementation
Signed-off-by: Andrew Tridgell <tridge@samba.org>
2010-02-11 21:59:39 +11:00
Kamen Mazdrashki
fedc1152b5 s4/net_drs: 'net drs bind' command implementation
Signed-off-by: Andrew Tridgell <tridge@samba.org>
2010-02-11 21:59:38 +11:00
Kamen Mazdrashki
61246da63c s4/net_drs: 'net drs' utility initial creation
Signed-off-by: Andrew Tridgell <tridge@samba.org>
2010-02-11 21:59:38 +11:00
Kamen Mazdrashki
0a05af9277 s4/idl: regenerating drsuapi.idl
Signed-off-by: Andrew Tridgell <tridge@samba.org>
2010-02-11 21:59:37 +11:00
Kamen Mazdrashki
7dde20ae45 s4/idl: Naming reserved flags for DRSUAPI_SUPPORTED_EXTENSION_ field
Signed-off-by: Andrew Tridgell <tridge@samba.org>
2010-02-11 21:59:36 +11:00
Matthieu Patou
a4d0563392 provision: Use short name for assignee of ACE (BA, SA, CO, ...)
Use short name (shortcut for wellknown SID/RID) for assignee in each entry of ACL (when possible)
  of sysvol files (GPO objects and netlogon folders).
  This avoid error prone substitution of DOMAINSID in ACL and make ACL clearer by using shortname
  for assignee accordingly with SDDL synthax rules. Translation to real SID is handled internaly by the
  from_sddl function.

Signed-off-by: Matthias Dieter Wallnöfer <mwallnoefer@yahoo.de>
2010-02-11 11:47:04 +01:00
Matthieu Patou
bcba41c351 python-s4: use secrets.ldb instead of sam.ldb for reading domain SID
This allow to be able to run net acl set xxx yyy on DC, but also on domain
  member.

Signed-off-by: Matthias Dieter Wallnöfer <mwallnoefer@yahoo.de>
2010-02-11 11:47:04 +01:00
Matthieu Patou
d1c2923151 provision: Fix an error with eadb when using not default install dir and running as a non root user
Signed-off-by: Matthias Dieter Wallnöfer <mwallnoefer@yahoo.de>
2010-02-11 11:47:04 +01:00
Andrew Tridgell
2cf97c403f s4-dns: don't leave behind a tmp file
If the dns update file doesn't need updating we need to delete the tmp
file
2010-02-11 21:04:16 +11:00
Andrew Tridgell
1e1b081189 s4-selftest: don't run rndc reload in selftest
We don't want rndc calls on the build farm
2010-02-11 21:04:15 +11:00
Andrew Tridgell
89b6a80e72 s4-dns: added a dns update task
This task watches for changes in the list of DCs, and creates a bind9
formatted file that grants update permission to all DCs, plus to the
administration, and machines update for their own names.

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
2010-02-11 21:04:14 +11:00
Andrew Tridgell
6bfb216293 s4-provision: cope with umask in creating private/dns 2010-02-11 21:04:14 +11:00
Andrew Tridgell
ae95d611b6 util: added file_compare() utility function
file_compare() returns true if two files are the same. It is meant for
small files.

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
2010-02-11 21:04:13 +11:00
Andrew Tridgell
d6fb64c512 libreplace: added replacements for dprintf() and vdprintf()
these are very useful for writing files with formatted writes

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
2010-02-11 21:04:13 +11:00
Andrew Tridgell
c986bfb22e s4-provision: pre-create a named.conf.update file
The named.conf.update file will be filled in at runtime by Samba to 
contain the list of bind9 grant rules for granting DNS dynamic update
permissions on the domain.
2010-02-11 21:04:12 +11:00
Andrew Tridgell
5a72eca574 s4-provision: move zone file to dns subdirectory
This allows the permissions to be correctly set for bind to write to
a journal file. It also sets the right group ownership and permissions
on the files that bind needs to access.

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
2010-02-11 21:04:11 +11:00
Andrew Bartlett
5a2ff4d16f s4:provision Be more polite to long-suffering Samba testers.
Our testers put up with a lot of odd things when testing out Samba4.

Andrew Bartlett
2010-02-11 17:16:55 +11:00
Jeremy Allison
0f0229c454 Fix unused variable warning after change to new DLINK macros.
Jeremy.
2010-02-10 17:20:21 -08:00
Jeremy Allison
ed0e0a2005 Fix bad use when freeing linked list. Todd Stecher (Original author) please check !
Jeremy.
2010-02-10 16:23:33 -08:00
Andrew Tridgell
91cb7b7c60 test:local added LOCAL-DLINKLIST testsuite
(cherry picked from commit 95a5bee2c30a67a35604b0456ab7836f6dc67702)
2010-02-10 15:55:34 -08:00
Andrew Tridgell
32809bd8c1 util: rewrite dlinklist.h so that DLIST_ADD_END() is O(1)
This changes the meaning of the ->prev pointer in our doubly linked
lists to point at the end of the list from the front of the list. That
allows us to implement DLIST_ADD_END() and related functions in O(1)
time, which can be a huge saving in many places in Samba.

This also means that the 'type' argument to various DLIST_*() macros
is no longer needed, but I have left it in for now to keep the
patchset small, which will make it easier to revert if any problems
are found. In the future we should remove the 'type' arguments.

(jra. Move the one use of DLIST_TAIL over to the new macros).
2010-02-10 15:53:58 -08:00
Andrew Tridgell
13ac4ad521 s3-smbd: update to use new DLIST macros
(cherry picked from commit 365b408c458c848a818637d9b36a0423aeb1ba54)
2010-02-10 15:43:49 -08:00
Andrew Tridgell
aa52a0925d s3-registry: update to use new DLIST macros
(cherry picked from commit 3437713ad7e5bccafde30553a8232119fd2a9eb9)
2010-02-10 15:42:00 -08:00
Andrew Tridgell
f592d42047 s3-perfcount: update to use new DLIST macros
(cherry picked from commit a13b507f2d8be7f90c8872094cd0732926a6fcbb)
2010-02-10 15:41:22 -08:00
Andrew Tridgell
4689826e39 s3-locking: update to use DLIST_ADD_AFTER()
(cherry picked from commit 6c6df527e14514027cbcaa6deac25adf04363926)
2010-02-10 15:40:44 -08:00
Andrew Tridgell
d550621561 s3-libsmb: update libsmb to use new DLIST macros
manipulating p->prev directly is not safe any more
(cherry picked from commit 3c650ac1e3e1cdbbabecfddcd29325f20b5dcb48)
2010-02-10 15:38:48 -08:00
Andrew Tridgell
7842b391b9 s3-memcache: update memcache to use new DLIST macros
we don't need a separate lru pointer any more
(cherry picked from commit 4ffd7aca3e38728077bd80c2a65c4efbcfd216fc)
2010-02-10 15:38:31 -08:00
Andrew Tridgell
54fc99e04b s3-ldb: update the old ldb in s3 to use new DLIST macros
(cherry picked from commit a7d8bfd373392eecf4fff33d39b85e1b55ad901d)
2010-02-10 15:38:16 -08:00
Andrew Tridgell
ece7089918 s3-nmbd: update nmbd to use new DLIST_ macros
(cherry picked from commit 4d23d777bc6d4fad20d0f3084fe658635812bee9)
2010-02-10 15:36:37 -08:00
Andrew Tridgell
a5d2fb752c s4-ldb: update ldb_tdb to use new DLIST_ macros
(cherry picked from commit 6ede911654566a7e21ded70dacac68df3b6a1bca)
2010-02-10 15:36:20 -08:00
Jeremy Allison
f017edc59f s4-dsdb: update repl_meta_data.c to use new DLIST_ macros 2010-02-10 15:35:38 -08:00
Jeremy Allison
32575ed70f Temporary changes to dlinklist to keep the implementation static whilst
uses of (list)->prev are moved over to DLIST_PREV. This will be replaced
when the final (new) version of the dlinklist.h header is added.

Jeremy.
2010-02-10 15:30:59 -08:00
Jeremy Allison
f2d7d9774e Revert "Change the default of "nmbd bind explicit broadcast" to "no""
This reverts commit 84fba3c1bc962804259f201d465acfdf0cd3c6a8.

Now we have a "processed packet queue" in nmbd we can go back
to doing this by default.

Jeremy.
2010-02-10 12:42:27 -08:00
Jeremy Allison
c2f3ed48c5 More of the fix for bug #7118 - nmbd problems with socket address.
Add a simple "processed packet queue" cache to stop nmbd responding to
packets received on the broadcast and non-broadcast socket (which
it has opened when "nmbd bind explicit broadcast = yes").

This is a very simple packet queue - it only keeps the packets
processed during a single call to listen_for_packets() (i.e. one
select call). This means that if the delivery notification for a
packet received on both broadcast and non-broadcast addresses
is done in two different select calls, the packet will still be
processed twice. This is a very rare occurrance and we can just
live with it when it does as the protocol is stateless. If this
is ever flagged as a repeatable problem then we can add a longer
lived cache, using timeout processing to clear etc. etc. But without
storing all packets processed we can never be *sure* we've eliminated
the race condition so I'm going to go with this simple solution until
someone proves a more complex one is needed :-).

Jeremy.
2010-02-10 12:32:05 -08:00