1
0
mirror of https://github.com/samba-team/samba.git synced 2024-12-23 17:34:34 +03:00
Commit Graph

20149 Commits

Author SHA1 Message Date
Volker Lendecke
cf7c83d462 r17536: Add a debug message citing the reason why an LDAP connection failed, inspired
by Christian M Ambach <CAMBACH1@de.ibm.com>.

Volker
2007-10-10 11:38:37 -05:00
Volker Lendecke
0f483cf66c r17535: Reformatting, this had many tabs instead of ^$ 2007-10-10 11:38:37 -05:00
Simo Sorce
4fc773080a r17509: same for old woody packaging stuff 2007-10-10 11:38:37 -05:00
Simo Sorce
47a4623595 r17508: I didn;t realize we had this in our packages, remove it 2007-10-10 11:38:37 -05:00
Jeremy Allison
2ba0d93d53 r17496: net groupmap add could add uninitialized sid_name_type
entries to the group mapping db. Ensure this can't happen.
Jeremy.
2007-10-10 11:38:37 -05:00
Andrew Bartlett
199a33ac80 r17487: Allocate some OID space for Samba4, so we don't trip on each other.
Andrew Bartlett
2007-10-10 11:38:37 -05:00
Volker Lendecke
c0ff2afe06 r17477: Add talloc_asprintf_len and make use of it.
Volker
2007-10-10 11:38:37 -05:00
Volker Lendecke
f0f0e893ca r17470: This is the group mapping rewrite announced a few days ago. I'm afraid it's
more than 1000 lines of patch, but doing it in smaller pieces is hardly
possible.

Anybody interested please look over this. The patch is not really interesting,
just look at the new groupdb/mapping.c file.

Jerry, one entry for the 3.0.24 release notes: smbd will refuse to start if we
have overlapping mappings in group_mapping.tdb. With the old db a unix gid can
be mapped to two different SIDs. This will be refused with the new code.

Volker
2007-10-10 11:38:36 -05:00
Simo Sorce
c7d115a7d0 r17469: remove unused variable 2007-10-10 11:38:36 -05:00
Volker Lendecke
4ebfc30a28 r17468: To minimize the diff later on, pre-commit some changes independently: Change
internal mapping.c functions to return NTSTATUS instead of BOOL.

Volker
2007-10-10 11:38:36 -05:00
Volker Lendecke
244b25ae49 r17465: Get rid of add_initial_entry. In the two places it was called in it seemed a
bit pointless to me.

Volker
2007-10-10 11:38:36 -05:00
Jeremy Allison
c8e6f7e41c r17464: Ensure we use a hash16 data type, not a string,
for storing offline hashes.
Jeremy.
2007-10-10 11:38:36 -05:00
Volker Lendecke
f9856f6490 r17463: A bit of cleanup work:
Remove some unused code: pdb_find_alias is not used anymore, and nobody I
think has ever used the pdb_nop operations for group mapping. smbpasswd and
tdb use the default ones and ldap has its own.

Make the functions pdb_getgr* return NTSTATUS instead of BOOL. Nobody right
now really makes use of it, but it feels wrong to throw away information so
early.

Volker
2007-10-10 11:38:36 -05:00
Simo Sorce
954593bd41 r17462: Fix a cut&paste bug that caused us to return a null SID on some error conditions 2007-10-10 11:38:35 -05:00
Jeremy Allison
f8584a4758 r17461: Ensure we never save a NULL SID mapping. || should be &&.
Found by Whitfield school.
Jeremy.
2007-10-10 11:38:35 -05:00
Volker Lendecke
a1c3774e01 r17460: First step at fixing the build breakage with the groupmapping test. On Linux,
F_RDLCK is defined to 0, for example NetBSD has it at 1.

Still does not work fully though. Still investigating.

This might also be interesting to Samba4.

Volker
2007-10-10 11:38:35 -05:00
Simo Sorce
b8578bfab6 r17459: As by Jerry's word commit this without his review.
This patch add some missing async functions to
solve UID/GID -> SID requests not just out of the cache,
but down the remote idmap if necessary.

This patch solves the problem of servers not showing users/groups names
for allocated UID/GIDs when joined to a group of servers that share a
prepopulated idmap backend.

Also correctly resolve UID/GIDs to SIDs when looking ACLs from the
windows security tab on teh same situation.

Simo.
2007-10-10 11:38:35 -05:00
Volker Lendecke
68db058fdf r17457: Add a test to do some operations on group mapping.
Volker
2007-10-10 11:38:35 -05:00
Günther Deschner
8c1198c159 r17454: Adding dfs_EnumEx for rpcclient (Samba4 IDL to follow).
Guenther
2007-10-10 11:38:35 -05:00
Günther Deschner
f9bef1f08f r17453: Fix msdfs RPC management (this broke with the autogenerated dfs rpcs).
* Remove "unknown" from dfs_Enum (samba4 dfs IDL updates to follow).

* When encountering an unsupported infolevel the rpc server must reply
with a dfs_info_0 structure and WERR_OK (observed from w2k3 when talking
to nt4).

Guenther
2007-10-10 11:38:34 -05:00
Volker Lendecke
e4b8c79a9d r17452: Some C++ warnings 2007-10-10 11:38:34 -05:00
Volker Lendecke
873a5a1211 r17451: Change pdb_getgrsid not to take a DOM_SID but a const DOM_SID * as an
argument.

Volker
2007-10-10 11:38:34 -05:00
Volker Lendecke
4f6605a488 r17446: Fix some C++ warnings and two memleaks found by Coverity, IDs 304 and 305.
Volker
2007-10-10 11:38:34 -05:00
Gerald Carter
d44a3228f0 r17445: fix bad PAM file on 64 bit boxes 2007-10-10 11:38:34 -05:00
Gerald Carter
cad3d27e05 r17444: put pam and nss libs in samba-common on RHEL for compatibility with system provides rpms 2007-10-10 11:38:34 -05:00
Jeremy Allison
06aea05c52 r17439: Fix logic error in checking TALLOC return. Spotted by Volker.
Jeremy.
2007-10-10 11:38:33 -05:00
Jeremy Allison
85841a0198 r17431: Fix bug #4003, reported by dale-keyword-samba.c7b741@codefu.org.
NTcancel doesn't send a reply, so in this case the signing
sequence number is only incremented by 1, not 2.
Jeremy.
2007-10-10 11:38:33 -05:00
Volker Lendecke
6915adb978 r17425: Add the multi-key wrapper. If it's necessary to add general blobs as keys,
this can trivially be added later.

Volker
2007-10-10 11:38:33 -05:00
Simo Sorce
c065341d3f r17408: Let us use netgroups even without a NIS domain but just using files 2007-10-10 11:38:32 -05:00
Jeremy Allison
b5f0b1b644 r17407: Don't do strchr_m twice when once will do.
Jeremy.
2007-10-10 11:38:32 -05:00
Volker Lendecke
255475901c r17406: We need to do a translation of winbind separator -> '\\' in
lookup_name_smbconf, otherwise

force user = domain+administrator

can not work. Also attempt to fix the 'valid users = domain+group' bug at the
same time.

Volker
2007-10-10 11:38:32 -05:00
Volker Lendecke
250b9f3531 r17404: Is this XP (extreme programming)? :-)
With lp_workgroup we end up with remote names again...

Volker
2007-10-10 11:38:32 -05:00
Gerald Carter
63325b3687 r17403: add a helpful debug msg 2007-10-10 11:38:32 -05:00
Jeremy Allison
1e1fcb5eb2 r17402: Added lookup_name_smbconf() to be called when looking
up names from smb.conf. If the name is unqualified it
causes the lookup to be done in WORKGROUP\name, then
"Unix [users|groups]"\name rather than searching the
domain. Should fix the problems with "force user"
selecting a domain user by preference.
Jeremy.
2007-10-10 11:38:31 -05:00
Gerald Carter
92ccdec33f r17401: BUG 3855: remove bits of XML and SQL checks from aclocal.m4 2007-10-10 11:38:31 -05:00
Volker Lendecke
d12b08fc61 r17399: Some C++ warnings 2007-10-10 11:38:31 -05:00
Jeremy Allison
16ebccbc58 r17393: Remove Volker's ASSERT that num_groupsids > 0.
For guest connection they may well be zero.
This should fix up the buildfarm (fingers
crossed).
Jeremy.
2007-10-10 11:38:31 -05:00
Jeremy Allison
6d822b8567 r17392: Commit Volker's fix for the valid users problem.
Let's look at the build farm now... :-).
Jeremy.
2007-10-10 11:38:31 -05:00
Jeremy Allison
65003e1b25 r17391: Revert the second part of the valid users fix - the
netlogon code uses pdb_get_group_sid() which could
return a S-1-1-22 unix sid. Who knew.... :-(.
I'm going to test Volker's fix instead. Once
3.0.23b is out we *have* to rip out the pdb_set_group_sid()
code....
Jeremy.
2007-10-10 11:38:31 -05:00
Jeremy Allison
79b1e668e2 r17388: Fix the "valid users"/token issue for now. Volker,
please come in and fix it in a less ugly way once
you have some time. Thanks,
Jeremy.
2007-10-10 11:38:30 -05:00
Gerald Carter
c05e2bdc0c r17386: fix inverted logic pointed out by Volker. When deleting a printer return access denied if the printer still exists after the delete_printer_hook() is called 2007-10-10 11:38:30 -05:00
Gerald Carter
24de2d83ff r17383: Patch from Michael Adams <ma@sernet.de> to catch
some memory leaks on error paths in net_ads_join()
2007-10-10 11:38:29 -05:00
Jeremy Allison
0b5b2b53ec r17378: Fix the issues people have been having with mapped
users (username map) and failure to connect to a
share. Essentially, even on a standalone system
we were going into the create_token_from_username()
code (I think by mistake) if the username was mapped.
Fixes bug #3991.

Volker & Jerry - please go over this with a very careful eye
and let me know if this isn't correct (I think it is,
but this isn't my code and it's a dangerous area for
me to be playing in :-).

Jeremy
2007-10-10 11:38:29 -05:00
Jeremy Allison
e9e711fe37 r17376: Fix bug #3985 - ensure in msdfs we check for our
netbios aliases. Reported by Björn Jacke <bjoern@j3e.de>.
Probably needs to be in 3.0.23b (if Björn approves
of the fix).
Jeremy.
2007-10-10 11:38:29 -05:00
Volker Lendecke
795d06f427 r17375: If a field containts only whitespace, we need to do base64 as well.
Volker
2007-10-10 11:38:29 -05:00
Volker Lendecke
61e7ed593b r17374: Get rid of a silly "System User" default for "description", also fetch the
sambaProfilePath.

Volker
2007-10-10 11:38:29 -05:00
Jeremy Allison
330899ec30 r17367: Reverting the ab code. Note I'm not saying this
code is wrong or bad or anything, just that it
needs to be discussed & reviewed on the samba-technical
list before we add a platform-specific NFSv4 mapping.
That way lies a lot of future pain :-).
Jeremy.
2007-10-10 11:38:29 -05:00
Günther Deschner
b3ac5a586b r17366: Save the logon script path from the info3 in the PAM session allowing
other PAM modules to pick it up from there.

Guenther
2007-10-10 11:38:28 -05:00
Günther Deschner
62a8e0b089 r17365: Fix memleak.
Guenther
2007-10-10 11:38:28 -05:00
Volker Lendecke
f002a36338 r17364: Another NT4 join bug: The idealx tools set the primary group sid, and if we do
an update_sam_account later on, we want to also set it using the delete/add
method. As the idealx tools use the replace method, they don't care about what
has been in there before.

Jerry, this is a likely 3.0.23b candidate. Not merging, it's your call :-)

Volker
2007-10-10 11:38:28 -05:00