1
0
mirror of https://github.com/samba-team/samba.git synced 2025-01-12 09:18:10 +03:00
Commit Graph

72389 Commits

Author SHA1 Message Date
Volker Lendecke
d2d1d17323 s3: Fix Coverity ID 2473, UNINIT
Signed-off-by: Günther Deschner <gd@samba.org>
2011-04-11 16:30:19 +02:00
Volker Lendecke
0958695022 s3: Fix timeout calculation in event_add_to_poll_args
In the initial phase nmbd does not yet have timed events. This led to nmbd
not correctly registering its names in make test and certainly everywhere
else.

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Mon Apr 11 14:35:45 CEST 2011 on sn-devel-104
2011-04-11 14:35:45 +02:00
Björn Baumbach
e6cf92c574 s3-modules: Fix debug message
Print child descriptor instead of parent.

Signed-off-by: Stefan Metzmacher <metze@samba.org>

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Mon Apr 11 11:48:42 CEST 2011 on sn-devel-104
2011-04-11 11:48:42 +02:00
Jeremy Allison
af45636166 Fix bug 8072 - PANIC: create_file_acl_common frees handle two times.
Caused by premature optimisation storing the parent ACL on the
module handle instead of (correctly) on the file fsp. Previous
code wasn't reentrant safe. This is less optimal but doesn't
crash in the specific case :-).

Jeremy.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Sat Apr  9 02:05:15 CEST 2011 on sn-devel-104
2011-04-09 02:05:15 +02:00
Jeremy Allison
c6c17242d2 Subtle change. Microsoft SMB2 tests return different access mask than for SMB1 with raw.acls. 2011-04-08 16:18:56 -07:00
Michael Adam
58a0c8a9e0 s3:net idmap check: fix output of an invalid record
Only print the value number for hwm, version and seqnum keys.

Pair-Programmed-With: Gregor Beck <gbeck@sernet.de>

Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Fri Apr  8 17:29:31 CEST 2011 on sn-devel-104
2011-04-08 17:29:31 +02:00
Gregor Beck
6db4fc15df s3-net: "idmap check" ignore __db_sequence_number__
Signed-off-by: Michael Adam <obnox@samba.org>
2011-04-08 16:44:57 +02:00
Stefan Metzmacher
eb0e276f3a talloc/testsuite: avoid memory leak reported by valgrind
metze

Signed-off-By: Andrew Tridgell <tridge@samba.org>

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Fri Apr  8 10:15:41 CEST 2011 on sn-devel-104
2011-04-08 10:15:40 +02:00
Stefan Metzmacher
f9fdef870e talloc/testsuite: test more talloc_pool related things
metze

Signed-off-By: Andrew Tridgell <tridge@samba.org>
2011-04-08 09:28:10 +02:00
Stefan Metzmacher
2146ffd764 talloc: include valgrind headers if available
metze

Signed-off-By: Andrew Tridgell <tridge@samba.org>
2011-04-08 09:28:10 +02:00
Stefan Metzmacher
73cc85ac90 talloc: add TC_INVALIDATE_POOL marco
metze

Signed-off-By: Andrew Tridgell <tridge@samba.org>
2011-04-08 09:28:10 +02:00
Stefan Metzmacher
9c9f208598 talloc: add TC_UNDEFINE_GROW_CHUNK() marco
metze

Signed-off-By: Andrew Tridgell <tridge@samba.org>
2011-04-08 09:28:10 +02:00
Stefan Metzmacher
6126c3506d talloc: add TC_INVALIDATE_SHRINK_CHUNK() marco
This invalidates the unused bytes if we shrink memory.

metze

Signed-off-By: Andrew Tridgell <tridge@samba.org>
2011-04-08 09:28:10 +02:00
Stefan Metzmacher
4895f55f06 talloc: add TC_INVALIDATE_FULL_CHUNK() macro
This makes it easier to mark a talloc pointer as
invalid.

metze

Signed-off-By: Andrew Tridgell <tridge@samba.org>
2011-04-08 09:28:10 +02:00
Stefan Metzmacher
efbb35824e talloc: use VALGRIND_MAKE_MEM_UNDEFINED() before memmove()
metze

Signed-off-By: Andrew Tridgell <tridge@samba.org>
2011-04-08 09:28:10 +02:00
Stefan Metzmacher
1e70439f77 talloc: optimize talloc_free() and talloc_realloc() for talloc pools
metze

Signed-off-By: Andrew Tridgell <tridge@samba.org>
2011-04-08 09:28:10 +02:00
Stefan Metzmacher
73330f8436 talloc: add TC_POOL_FIRST_CHUNK() macro
metze

Signed-off-By: Andrew Tridgell <tridge@samba.org>
2011-04-08 09:28:10 +02:00
Stefan Metzmacher
13fab67995 talloc: add TC_POOL_SPACE_LEFT() macro
metze

Signed-off-By: Andrew Tridgell <tridge@samba.org>
2011-04-08 09:28:10 +02:00
Stefan Metzmacher
4084cb723c talloc: add TC_ALIGN16() macro
metze

Signed-off-By: Andrew Tridgell <tridge@samba.org>
2011-04-08 09:28:10 +02:00
Stefan Metzmacher
d39940113a talloc: use TC_HDR_SIZE instead of sizeof(struct talloc_chunk)
As this includes the padding to 16 bytes.

metze

Signed-off-By: Andrew Tridgell <tridge@samba.org>
2011-04-08 09:28:09 +02:00
Matthias Dieter Wallnöfer
ab0a881bb4 ldb:ldb/common/ldb_modules.c - change the request counter type to be "unsigned"
Just for consistency since all other LDB counters are unsigned as well.

And also the debug output specifier has been chosen to be "%u" - so it
really should be unsigned.

Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Fri Apr  8 09:17:47 CEST 2011 on sn-devel-104
2011-04-08 09:17:47 +02:00
Matthias Dieter Wallnöfer
a15ebe61c3 ldb:ldb/common/ldb_modules.c - trivial - fix integer output specifiers 2011-04-08 08:29:51 +02:00
Michael Adam
9705dab835 s3:net rpc trust: fix two C++ implicit void * cast warnings
Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Thu Apr  7 17:52:28 CEST 2011 on sn-devel-104
2011-04-07 17:52:28 +02:00
Michael Adam
32d816d59b s3:passdb:pdb_ipa: fix a C++ implicit void * cast warnings 2011-04-07 17:08:16 +02:00
Michael Adam
838e2dd1f1 s3:net idmap check: fix a couple of c++ implicit void * cast warnings 2011-04-07 17:08:16 +02:00
Michael Adam
7e4f2614ab packaging(RHEL-CTDB): fix configure.rpm (honour additional cmdline parameters) 2011-04-07 17:08:16 +02:00
Matthias Dieter Wallnöfer
94f5b2f413 ldb:ldb_msg.c - make "ldb_msg_find_attr_as_*" more robust against invalid values
- Integer handling was modeled after validate code from "schema_syntax.c".
- Double handling was modeled similar, but with a dynamic buffer.
  I don't know if there is a maximum literal length for double values but an
  allocation shouldn't a problem here since doubles are rare.
- String handlind is enhanced with a terminating "0" test for safety.

Reviewed-by: abartlet + metze

Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Thu Apr  7 16:38:57 CEST 2011 on sn-devel-104
2011-04-07 16:38:57 +02:00
Matthias Dieter Wallnöfer
df9d46a353 ldb:ldb_msg_check_sanity - clean it up from unneeded stuff 2011-04-07 15:53:20 +02:00
Matthias Dieter Wallnöfer
ddb41f2af4 dsdb:schema/schema_syntax.c - correctly check error code of "ldb_string_utc_to_time"
This one doesn't set ERRNO. An error happens if the result is "0".

Reviewed-by: abartlet
2011-04-07 15:53:20 +02:00
Matthias Dieter Wallnöfer
6cef940b40 dsdb:schema/schema_syntax.c - add some empty value checks on validate functions
They are needed since the check in "ldb_msg_sanity_check" will be removed.

Reviewed-by: abartlet
2011-04-07 15:53:20 +02:00
Matthias Dieter Wallnöfer
b7de06e8e7 s4:objectclass LDB module - "ldb_msg_sanity_check" call not really needed
This call should only be performed at the beginning of a request.
"ldb_msg_sanity_check" checks for DN validity (which should already have been
done at the beginning of the request) and empty attributes (which should
be done by the "objectclass_attrs" LDB module).

Hence it is superflous here.

Reviewed-by: abartlet
2011-04-07 15:53:20 +02:00
Matthias Dieter Wallnöfer
17f34136bf ldb:ldbadd/modify tool - return error code when at least one operation has failed
This is required to better detect failures and should raise the
compatiblity to "ldapadd"/"ldapmodify".

Reviewed-by: abartlet
2011-04-07 15:53:20 +02:00
Matthias Dieter Wallnöfer
f14699287c ldb:tests - "init.ldif" - deactivate empty "seeAlso" attribute 2011-04-07 15:53:20 +02:00
Matthias Dieter Wallnöfer
3cd11b5b75 ldb:ldb/common/ldb_modules.c - always use LDB error codes if possible
The callers do compare against LDB error codes - hence don't give back
"-1".

Reviewed-by: Tridge + abartlet
2011-04-07 15:53:20 +02:00
Matthias Dieter Wallnöfer
32cad7601a ldb:common/*.c - check for some OOM conditions
Reviewed-by: abartlet
2011-04-07 15:53:20 +02:00
Matthias Dieter Wallnöfer
1d8980df04 s4:objectclass LDB module - fix a comment - add a ")"
Reviewed-by: abartlet
2011-04-07 15:53:19 +02:00
Stefan Metzmacher
02c6f9d0d9 selftest:Samba4: setup DC_* variables in provision_rpc_proxy()
The "rpc_proxy" should behave like "member", just with a different
configuration.

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Thu Apr  7 15:52:25 CEST 2011 on sn-devel-104
2011-04-07 15:52:25 +02:00
Günther Deschner
ead6faab27 s4-smbtorture: fix lsa forest trust test.
lsa_lsaRSetForestTrustInformation takes a policy handle obtained from
lsaopenpolicy/lsaopenpolicy2 and not a trusted domain handle
(MS-LSAD 3.1.4.7.16 LsarSetForestTrustInformation (Opnum 74)).

Sumit, please check.

Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Thu Apr  7 14:52:52 CEST 2011 on sn-devel-104
2011-04-07 14:52:51 +02:00
Günther Deschner
26d67846d4 lsa: use lsa_TrustedAccessMask in some more places in the lsa IDL.
Guenther
2011-04-07 14:08:44 +02:00
Gregor Beck
c1a5670e4f s3-net: document "idmap check"
Signed-off-by: Michael Adam <obnox@samba.org>

Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Thu Apr  7 13:58:13 CEST 2011 on sn-devel-104
2011-04-07 13:58:13 +02:00
Gregor Beck
7d040434dc s3-net: fix the usage output of "net idmap check"
Signed-off-by: Michael Adam <obnox@samba.org>
2011-04-07 13:13:27 +02:00
Andrew Bartlett
17fe5e0ca4 s4-samba_dnsupate Fix syntax error
This particular sub-part of the script isn't tested in 'make test' due
to it making real changes to DNS.

Andrew Bartlett

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Thu Apr  7 08:51:11 CEST 2011 on sn-devel-104
2011-04-07 08:51:11 +02:00
Andrew Bartlett
e78d4652fa Revert "s3-test: disable ktest for now"
This reverts commit 77820d59fe.

I beleive this is now reliable, after the changes to wait for an
actual connection at startup and to use the fake DNS file.

Andrew Bartlett

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Thu Apr  7 07:20:03 CEST 2011 on sn-devel-104
2011-04-07 07:20:03 +02:00
Andrew Bartlett
4cdbb88c4b s3-selftest actually wait for smbclient to connect
This means that we actually have a working smbd.  The previous code didn't know if it worked or not, and so created flaky tests.

Andrew Bartlett
2011-04-07 14:35:36 +10:00
Andrew Bartlett
1862e904a8 s3-selftest Fix use of the 'fake DNS' file
This ensures we don't use netbios before the hosts file and that we do
fill in the fake DNS zone correctly for the way we invoke smbtorture4.
Currently this works because the realm in client.conf is "", if this
changes then this will need to change too (perhaps an additional
entry).

Andrew Bartlett
2011-04-07 14:35:36 +10:00
Andrew Bartlett
1367e2b303 wintest Allow setting of the firewall to fail
This is also required to allow a telnet connection as non-admin.

Andrew Bartlett
2011-04-07 14:35:36 +10:00
Andrew Bartlett
e410a1af30 s3-wintest Add test of 'net use' against the Samba3 member 2011-04-07 14:35:36 +10:00
Andrew Bartlett
9ced0df379 wintest Allow changing the telnet settings to fail, we might not be admin
This allows us to test logging in as non-admin users over telnet
2011-04-07 14:35:36 +10:00
Andrew Bartlett
36029a0343 samba_dnsupdate: Don't use subprocess.check_call, it isn't in python 2.4
RHEL5 and clones use python 2.5
2011-04-07 14:35:36 +10:00
Andrew Tridgell
77820d59fe s3-test: disable ktest for now
the ktest tests are currently flakey. Once andrew has found the
problem they can be re-enabled

Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Thu Apr  7 03:36:36 CEST 2011 on sn-devel-104
2011-04-07 03:36:36 +02:00