1
0
mirror of https://github.com/samba-team/samba.git synced 2025-01-08 21:18:16 +03:00
Commit Graph

4693 Commits

Author SHA1 Message Date
Richard Sharpe
d45e667a74 Needed a callback arg on cli_list ... 0001-01-01 00:00:00 +00:00
Tim Potter
d006e6adca Added extra argument to calls to smbw_share_add() 0001-01-01 00:00:00 +00:00
David O'Neill
1dba9c5cd1 Changes from APPLIANCE_HEAD:
source/Makefile.in
        - changes to ctags and etags rules that somehow got lost along the way.

    source/include/proto.h
        - make proto

    source/smbd/sec_ctx.c
    source/smbd/password.c
        - merge debugs for debugging user groups and NT token stuff.

    source/lib/util_str.c
        - capitalise domain name returned from parse_domain_user()

    source/nsswitch/wb_client.c
        - fix broken conditional in debug statement.

    source/include/rpc_secdes.h
    source/include/rpc_spoolss.h
    source/printing/nt_printing.c
    source/lib/util_seaccess.c
        - fix printer permission bugs related to ACE masks for printers.
          This adds mapping of generic access rights to object specific
          rights for NT printers.  Still need to work out whether or not to
          ignore ACEs with certain flags set, though. See comments in
          util_seaccess.c:check_ace() for details.

    source/printing/nt_printing.c
    source/printing/printing.c
        - use PRINTER_ACCESS_ADMINISTER instead of JOB_ACCESS_ADMINISTER
          until we sort out printer/printjob permission stuff.
0001-01-01 00:00:00 +00:00
Richard Sharpe
7f862e387f I need a callback arg for cli_NetServerEnum and cli_RNetShareEnum, so I had
to modifiy any routine that calls it to pass NULL and so forth.

Should have no impact. It compiles OK.
0001-01-01 00:00:00 +00:00
Richard Sharpe
f7466ba67c Add a new file clidgram with routines that are used by the libsmbclient code.
These routines handle the sending of dgrams in ways that don't bind us to
the nmbd code, but we may merge the two routines at some stage.

Also fix Makefile.in so the new code is compiled ...

Let's see whether or not it compiles on other architectures ...

Seems OK under Linux.
0001-01-01 00:00:00 +00:00
Richard Sharpe
05e2dd5e85 We only want to mark mailslot packets as loopback packets if they are to
the DGRAM_PORT, since we want to actually send those to other ports.

They might be for the client library running on the Samba server!
0001-01-01 00:00:00 +00:00
Tim Potter
9255e52624 Return an empty directory for a stat on a share we aren't allowed to
connect to.  This gives a permission denied when a cd is attempted, but
not a permission denied in the directory listing one level up.
0001-01-01 00:00:00 +00:00
Tim Potter
143006d32f Return EACCES for bad password. 0001-01-01 00:00:00 +00:00
Richard Sharpe
46a3a56ecf Make the use of generate_name_trn_id conform to the usage elsewhere ... 0001-01-01 00:00:00 +00:00
Richard Sharpe
fb5798e1d9 Comment out unused generate_name_trn_id ... 0001-01-01 00:00:00 +00:00
Tim Potter
44c5eb4def Fixed -d option for rpcclient. 0001-01-01 00:00:00 +00:00
Christopher R. Hertel
e651d1d642 The line was:
struct tdb_traverse_lock tl = { tdb->travlocks.next, 0, 0 };

The IRIX compiler complained that the first initialization value was not a
constant and errored out.  Here's what it looks like now:

        struct tdb_traverse_lock tl = { NULL, 0, 0 };
        int ret, count = 0;

        /* This was in the initializaton, above, but the IRIX compiler
         * did not like it.  crh
         */
        tl.next = tdb->travlocks.next;

That worked.

Chris -)-----
0001-01-01 00:00:00 +00:00
Richard Sharpe
51c0436a50 First pass at the libsmbclient code ...
This code handles the basic stuff and compiles and links under Linux, but
I do not know about any other operating systems. Now onto directory
listing routines, including those that list workgroups, servers, etc.

Nothing is built automatically yet, you have to make client/testsmbc to build
the library and test program. Also, no make install targets are defined for
libsmbclient.so as yet, either.

Would be good if people test on operating systems other than Linux.
0001-01-01 00:00:00 +00:00
Gerald Carter
393c5f14e0 merge from appliance head 0001-01-01 00:00:00 +00:00
Tim Potter
b4773618ac Return appropriate exit codes for various situations:
0 for success
    1 if operation failed
    2 command line parse error
0001-01-01 00:00:00 +00:00
Tim Potter
f9450cd7b7 Documentation updates for smbcacls program. 0001-01-01 00:00:00 +00:00
Tim Potter
b57fbcca06 If extra arguments passed make yodl docs for these files rather than *.yo 0001-01-01 00:00:00 +00:00
Gerald Carter
4671a31377 merge from appliance head 0001-01-01 00:00:00 +00:00
Tim Potter
a1ea59c9af make proto 0001-01-01 00:00:00 +00:00
Tim Potter
01a89978ff Don't call string_to_sid after cli_lsa_lookup_names() fails.
Can't use space as a ACL separator as it breaks NT user/group names that
contain spaces (i.e most of the default ones).

The MSDN is contradictory over the exact ordering of ACE entries in an ACL.
However NT4 gives a "The information may have been modified by a computer
running Windows NT 5.0" if denied ACEs do not appear before allowed ACEs.
Sort ACE list before calling cli_set_secdesc().
0001-01-01 00:00:00 +00:00
Tim Potter
935b77573e Some systems seem to only accept a ntcreate&x with a unicode filename
despite samba negotiating ascii filenames.  Retry with unicode pathnames
if the ascii version fails.

Convert all forward slashes to backslashes in the filename argument.
0001-01-01 00:00:00 +00:00
Tim Potter
c4476c6315 Added a cli_nt_create_uni() to do a ntcreate&x with a unicode filename,
regardless of the settings negotiated in the flags2 smb field.
0001-01-01 00:00:00 +00:00
Tim Potter
1a228868cf Replace magic number with constant. 0001-01-01 00:00:00 +00:00
Tim Potter
e21f2ef4fb Cleaned up SidToString() and StringToSid() exit paths.
Can now use user%password format in $USER environment variable.  -U option
is now optional.
0001-01-01 00:00:00 +00:00
Jeremy Allison
56a93567a1 Removed uninitialised variable.
Jeremy.
0001-01-01 00:00:00 +00:00
Andrew Tridgell
f2be88a873 implemented a much nicer name_status() interface. It now returns a
list of structures rather than the dodgy parsing code we had before

this also gets smbw working correctly with no initial workgroup (using
name_status_find on __MSBROWSE__ returns)
0001-01-01 00:00:00 +00:00
Jeremy Allison
c25533de99 Fixed bug found by Gerald. If a Samba server joins a domain and is set
to search for a DC to authenticate to using the "*" syntax than ensure
that for the first hour after the password change is searches for the
PDC using the 1B name not the 1C name as domain replication may not
have occured.
Jeremy.
0001-01-01 00:00:00 +00:00
Jeremy Allison
0f39895ab0 Split set_nt_acls into owner set (which uses chown) and permission set
(which currently uses chmod) in preparation for ACL creation.
Jeremy.
0001-01-01 00:00:00 +00:00
Jeremy Allison
1a31b4eb08 Split the one sys_acl_free call into sys_acl_free_TYPE calls, to allow
easier wrapping of non-POSIX ACL interfaces.
Jeremy.
0001-01-01 00:00:00 +00:00
Jeremy Allison
a83702c99f A couple more UMR fixes.
Jeremy.
0001-01-01 00:00:00 +00:00
Jeremy Allison
e0931cda80 Cast prs_alloc_mem to correct type.
Jeremy.
0001-01-01 00:00:00 +00:00
Jeremy Allison
c48e95297e Fix typos in new group sid check.
Jeremy.
0001-01-01 00:00:00 +00:00
Tim Potter
dcea2a4bc0 Added query info policy call. 0001-01-01 00:00:00 +00:00
Jeremy Allison
26f873540c Merged Tim's fixes from appliance-head.
Jeremy.
0001-01-01 00:00:00 +00:00
Tim Potter
8ccd06ee96 Streamlined exit path.
Allow NULL to be passed to cli_lsa_initialise() which creates an anonymous
connection to the server.
0001-01-01 00:00:00 +00:00
Jeremy Allison
43ca0d991c Fixed chown/chgrp setting from smbcacls.
Jeremy.
0001-01-01 00:00:00 +00:00
Jeremy Allison
12f88c9ba7 Added -C username and -G username that allow a user (usually Administrator)
to change the ownership or group ownership of a file to any arbitrary user
from the UNIX command line.
This will show the people who quote NT manuals at us about how this is
"impossible" how their operating system really works :-).
Jeremy.
0001-01-01 00:00:00 +00:00
Jeremy Allison
89708be73a Documented -C and -G options to smbcacls.
Jeremy.
0001-01-01 00:00:00 +00:00
Jeremy Allison
ce4f461965 Never free anything in the rpc_parse/prs_XXX functions. Do it in the enclosing
function.
lib/util_unistr.c: Check lengths *before* reading source - prevent uninitialised
memory reads.
Jeremy.
0001-01-01 00:00:00 +00:00
Jeremy Allison
506b5e34c3 Added lock backouts on fail.
When chaining together long lines of bloody "if" statements, which should
logically be separated, and one of them allocates memory, remember to
*free* it *WHETHER OR NOT THE IF STATEMENTS SUCCEEDED* !!!!
Yes I do consider this a bug in the coding style of Tridge, Rusty, Tim et al. :-).
I'm just pissed 'cos this took 4 hours to track down even with an insure error report
stating me in the face and also Ben Woodward looking over the code with me :-).
Jeremy.
0001-01-01 00:00:00 +00:00
Jean-François Micouleau
69fe739303 lib/util_unistr.c:
rewrote unistr2_to_ascii() to correct a bug seen on SGI boxes.

rpc_parse/parse_misc.c:
rpc_parse/parse_prs.c:
        rewrote of BUFFER5 handling to NOT byteswap when it was already in
        network byte order.

rpc_parse/parse_samr.c:
        cleanup of samr_io_q_lookup_domain(), remove the over-parsing by 2
        bytes.

rpc_server/srv_lsa.c:
        UNISTR2 strings need to be NULL terminated to pleased W2K.

rpc_server/srv_spoolss_nt.c:
        use snprintf instead of safe_strcpy as we want the string
        truncated at 32 chars.


That should fix SUN and SGI box not able to act as printserver and the
problem with joining from a W2K wks.

        J.F.
0001-01-01 00:00:00 +00:00
Jeremy Allison
d0d31eead3 Fixed memory leak in JOB_INFO_2 code.
Jeremy.
0001-01-01 00:00:00 +00:00
Jeremy Allison
0a40bc83e1 Fixed memory leaks in lsa_XX calls. Fixed memory leaks in smbcacls. Merged
in fixes from appliance-head and 2.2. Fixed multiple connection.tdb open
problem.
Jeremy.
0001-01-01 00:00:00 +00:00
David O'Neill
505a8a2277 Changes from APPLIANCE_HEAD:
- add some debugs for comparing two security descriptors.
      (source/rpc_parse/parse_sec.c)
0001-01-01 00:00:00 +00:00
Jeremy Allison
15ae2c335b Updates from appliance-head.
Jeremy.
0001-01-01 00:00:00 +00:00
Tim Potter
5e547ddcb5 Renamed parameters and variables called acl to the_acl as it conflicts
with a Solaris system call.
0001-01-01 00:00:00 +00:00
Tim Potter
bd87398b5a Updated smbcacls documentation. 0001-01-01 00:00:00 +00:00
Tim Potter
09d2d972fd Cache lsa connection and policy handle for resolving names and sids. 0001-01-01 00:00:00 +00:00
Gerald Carter
0e5c1df284 inverted dword value
jerry
0001-01-01 00:00:00 +00:00
David O'Neill
c533e77f19 Changes from APPLIANCE_HEAD:
- trivial typo in definition of enum_printing[]
	  (source/param/loadparm.c)
	- fixed printer status display bug.  When no jobs existed in queue, the
	  clients were not properly notified of printer status.  This caused
	  native tools for pausing/unpausing a print queue to not work.
	  (source/printing/printing.c)
0001-01-01 00:00:00 +00:00