1
0
mirror of https://github.com/samba-team/samba.git synced 2024-12-23 17:34:34 +03:00
Commit Graph

73444 Commits

Author SHA1 Message Date
Volker Lendecke
5df87913d7 s3: Use cli_connect_nb in locktest
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sat May 28 18:06:49 CEST 2011 on sn-devel-104
2011-05-28 18:06:49 +02:00
Volker Lendecke
6bf5d9a61f s3: Fix smbsock_connect
If all connection attempts fail, return immediately. Plain bug.
2011-05-28 16:57:24 +02:00
Volker Lendecke
9e05d3430f s3: Fix a tiny memleak in copy_unix_token
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sat May 28 11:47:11 CEST 2011 on sn-devel-104
2011-05-28 11:47:11 +02:00
Volker Lendecke
77ce431fdb s3: Use talloc_memdup in copy_unix_token 2011-05-28 10:39:48 +02:00
Volker Lendecke
4586f5176b s3: Fix some nonempty blank lines 2011-05-28 10:29:54 +02:00
Volker Lendecke
1c11186837 s3: Use cli_connect_nb in cli_start_connection 2011-05-28 10:29:53 +02:00
Volker Lendecke
defcd409a3 s3: Add cli_connect_nb
This builds up a cli_state until after the netbios session setup. It makes use
of smbsock_connect, so it connects to 139 and 445 simultaneously. This improves
the connection to Windows 2008 which does not listen on *SMBSERVER anymore.
2011-05-28 10:29:53 +02:00
Christian Ambach
51b43a4c3e packaging(RHEL-CTDB): align configure.rpm to the spec file
Signed-off-by: Michael Adam <obnox@samba.org>

Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Fri May 27 13:27:03 CEST 2011 on sn-devel-104
2011-05-27 13:27:02 +02:00
Volker Lendecke
a7a4cb56e5 s3: Fix a typo
Thanks to Samba-JP oota <ribbon@samba.gr.jp>

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Fri May 27 10:12:12 CEST 2011 on sn-devel-104
2011-05-27 10:12:12 +02:00
Volker Lendecke
127d417e8e s3: Fix a typo
Thanks to Samba-JP oota <ribbon@samba.gr.jp>
2011-05-27 08:43:47 +02:00
Jeremy Allison
e05c9cdcb6 Fix bug #6911 - Kerberos authentication from vista to samba fails when security blob size is greater than 16 kB
We were not correctly checking the output of asn1_start_tag().
asn1_start_tag() returns -1 and sets data->has_error if the
remaining blob size is too short to contain the tag length.
We were checking data->has_error and returning NT_STATUS_OK
(to allow the second asn.1 parse to fail in that case). We
should not be checking data->has_error in this case, but
falling through to the code that already checks the length.

Thanks to Jim for reproducing this for me. We don't get bitten
by this as we announce a max buffer size of 16k, greater than
Windows's 4k, which means that most krb5 spnego packets already
fit.

Jeremy.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Fri May 27 02:57:27 CEST 2011 on sn-devel-104
2011-05-27 02:57:27 +02:00
Volker Lendecke
875e29ba83 s3: Document "async smb echo handler"
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Thu May 26 12:50:55 CEST 2011 on sn-devel-104
2011-05-26 12:50:55 +02:00
Jeremy Allison
d10674326b Fix bug #8165 - Inverted WITH_SYSLOG condition in vfs_full_audit.c.
Found by freeserif@yahoo.com.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Wed May 25 22:37:23 CEST 2011 on sn-devel-104
2011-05-25 22:37:23 +02:00
Sean Finney
0f8018676a Fix numerous missing dependencies in WAF build scripts
With the recent consolidation of code between s3 and s4, a number of new
dependencies have been implicitly introduced.  For example, previous s3
code gained an implicit dependency on talloc after the charset related
consolidation (lib/util/charset/charset.h now includes talloc.h).  When
building against the embedded version of talloc this isn't a problem
since the paths are automatically added to the search path, but when
building against the external libraries build failures will occur for
all components that don't directly or indirectly include talloc as
a dependency.

Since charset.h is included from util.h, which in turn is included from
includes.h, this means most of the codebase (s3 and s4) has such an
undeclared dependency.

Therefore, samba-util-common and samba-util have been added as
dependencies to the s3 and s4 code respectively, for all cases where
the source would otherwise fail to build.  Additionally, a few other
dependencies are added in specific wscript_build files to address
similar dependency-related problems.

https://bugzilla.samba.org/show_bug.cgi?id=8128

Signed-off-by: Sean Finney <seanius@seanius.net>
Signed-off-by: Matthias Dieter Wallnöfer <mdw@samba.org>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>

Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Wed May 25 19:22:13 CEST 2011 on sn-devel-104
2011-05-25 19:22:13 +02:00
Jim McDonough
b58534f1fc s3-winbind: BUG 8166 - Don't lockout users when offline.
Windows does not track bad password attempts when offline.  We were locking users out but not honoring the lockout duration.

Autobuild-User: Jim McDonough <jmcd@samba.org>
Autobuild-Date: Wed May 25 18:11:10 CEST 2011 on sn-devel-104
2011-05-25 18:11:10 +02:00
Matthias Dieter Wallnöfer
ff47927fb9 s4:samldb LDB module - check if the RODC group exists if creating an RODC
Older AD deployments simply don't have it and hence there is no RODC
support.

Reviewed-by: abartlet

Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Wed May 25 10:26:37 CEST 2011 on sn-devel-104
2011-05-25 10:26:37 +02:00
Matthias Dieter Wallnöfer
08f5ed8b4f s4:samldb LDB module - better to call "samldb_prim_group_trigger"
"samldb_prim_group_trigger" which as a wrapper calls "samldb_prim_group_change"
for a LDB modify operation.

Reviewed-by: abartlet
2011-05-25 08:57:51 +02:00
Matthias Dieter Wallnöfer
779d882aca s4:samldb LDB module - convert a "dsdb_module_search" into "dsdb_module_search_dn"
It saves us from checking the number of returned entries.

Reviewed-by: abartlet
2011-05-25 08:57:46 +02:00
Matthias Dieter Wallnöfer
11937ce5e1 s4:sam.py - uncomment/enhance some account type tests
Reviewed-by: abartlet
2011-05-25 08:57:42 +02:00
Matthias Dieter Wallnöfer
2ad0100d5b s4:samldb LDB modules - only objectClass "computer" is allowed to embed all types of account
Reviewed-by: abartlet
2011-05-25 08:57:35 +02:00
Matthias Dieter Wallnöfer
4740473591 s4:sam.py - tests for "isCriticalSystemObject" attribute
Reviewed-by: abartlet
2011-05-25 08:57:29 +02:00
Matthias Dieter Wallnöfer
0c753e503c s4:samldb LDB module - fix "isCriticalSystemObject" behaviour
Tests against Windows Server show that it gets set to "FALSE" (not
deleted) if we change the account type to a domain member.

Reviewed-by: abartlet
2011-05-25 08:57:24 +02:00
Matthias Dieter Wallnöfer
c72d32da6d s4:sam.py - unchanged "primaryGroupID" when account type remains the same
Enhance the testcase with a workstation example.

Reviewed-by: abartlet
2011-05-25 08:57:19 +02:00
Matthias Dieter Wallnöfer
b712c7273d s4:samldb LDB module - fix the behaviour when changing the "userAccountControl"
Ekacnet was not quite right yet but his patch made me think further.
This primary group changing is only needed if the account type changes.
With this patch we do one more search if the "userAccountControl"
changes but we save us from doing these unneeded and wrong modify replace
operations most of the time.

Reviewed-by: abartlet
2011-05-25 08:57:09 +02:00
Andrew Bartlett
ee0ee5e925 s3-testparm Warn about incorrect use of 'password server'
This merges master with v3-6-test

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Wed May 25 05:20:57 CEST 2011 on sn-devel-104
2011-05-25 05:20:57 +02:00
Andrew Bartlett
3ba32439c1 s3-param Depricate 'password server = foo:12389' syntax
This was originally intended to allow the LDAP port on a DC to be
varied, but makes little sense to change one port when in an
environment where krb5, ldap, smb and potentially DCE/RPC over TCP are
involved.

Andrew Bartlett
2011-05-25 12:13:01 +10:00
Andrew Bartlett
ddbc5fa236 docs: Rewrite 'password server' documentation
I think this new version is more clear.

Andrew Bartlett
2011-05-25 12:13:01 +10:00
Andrew Bartlett
53b0c44d8c s4-provision Use correct tkey-gssapi-credential
We changed to ${DNSNAME} (the fully qualified domain name) a while
back, and while it's usually functionally idential to the previous
setting, this breaks down if there is more than one DNS server.

Andrew Bartlett
2011-05-25 12:12:53 +10:00
Andrew Bartlett
387cbb1c37 docs: Clarify the 'security=server' fails for NTLMv2 2011-05-25 09:15:18 +10:00
Andrew Bartlett
e7cf95c541 selftest: Make knowfail/skip files consistent, always use ^prefix
Except in one case (where we mark printing tests as knownfail), this
has all our regular expressions start with ^, which ensures we don't
accidentially mix up the samba3/samba4 prefix here.

Because of the particular values in these files at the moment, this
should not change the set of tests, but it will help to ensure that
future edits follow the correct pattern.

Andrew Bartlett
2011-05-25 09:15:18 +10:00
Jeremy Allison
e719dfd4dc Fix our asn.1 parser to handle negative numbers.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Tue May 24 22:57:16 CEST 2011 on sn-devel-104
2011-05-24 22:57:16 +02:00
Andrew Bartlett
ede98c0e51 lib/util Add Volker's asn1_Integer test into code that runs in 'make test'
The comfychair test harness isn't hooked up, and with the current
infrustructure C code is better tested directly here.

Andrew Bartlett
2011-05-24 12:48:00 -07:00
Holger Hetterich
13d20faa1d Actually make use of the SMBTA_SUBRELEASE define in smb_traffic_analyzer.h. This will allow to introduce new features or fixes into the protocol after the 3.6.0 release. The client software is designed to take care for the subrelease number.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Tue May 24 21:23:22 CEST 2011 on sn-devel-104
2011-05-24 21:23:22 +02:00
Jeremy Allison
309a8fd7c6 Fix bug #7054 - X account flag does not work when pwdlastset is 0.
Don't allow pass_last_set_time to be set to zero (which means
"user must change password on next logon") if user object doesn't
allow password change.

Don't automatically allow user object password change if
"user must change password on next logon" is set.

Jim please check.

Jeremy.
2011-05-24 20:14:35 +02:00
Christian Ambach
53829fd495 s3:modules properly terminate enums in nfs4 acl code
same issue as with the audit modules:
using a wrong parameter leads to smbd crash as lp_enum()
will not terminate on last entry of the array

Autobuild-User: Christian Ambach <ambi@samba.org>
Autobuild-Date: Tue May 24 20:13:39 CEST 2011 on sn-devel-104
2011-05-24 20:13:39 +02:00
Christian Ambach
425ac2c361 s3:vfs properly terminate enums in audit modules
without the proper terminations of the enums, invalid arguments
for the audit modules will lead to a smbd crash as the loop in
lp_enum() will attempt to access memory behind the array
2011-05-24 18:29:45 +02:00
Jeremy Allison
9c3e5380ec Fix bug #8150 - Ban 'dos charset = utf8'
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Tue May 24 03:52:50 CEST 2011 on sn-devel-104
2011-05-24 03:52:50 +02:00
Volker Lendecke
18ec1dab59 s3: Remove unused cli_get_nt_error
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Mon May 23 16:54:21 CEST 2011 on sn-devel-104
2011-05-23 16:54:21 +02:00
Volker Lendecke
502a9924ca s3: Remove unused cli_set_nt_error 2011-05-23 15:45:37 +02:00
Volker Lendecke
fddb944a04 s3: Remove unused cli_reset_error 2011-05-23 15:45:37 +02:00
Volker Lendecke
e77da2f408 s3: Remove a reference to cli->inbuf
This is only used for utf16 alignment calculations, "rdata" is aligned the
same way as cli->inbuf is.
2011-05-23 15:45:37 +02:00
Volker Lendecke
b1a7bdb93c s3: Remove two false references to cli->inbuf 2011-05-23 15:45:37 +02:00
Volker Lendecke
9514f96856 s3: Fix a leftover from fstring removal in cli_state
Jeremy, please check!
2011-05-23 15:45:36 +02:00
Stefan Metzmacher
8167e84073 selftest: create ncalrpcdir with 0755 permissions
We need to reset the umask in order to set to the desired permissions.

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Mon May 23 13:26:33 CEST 2011 on sn-devel-104
2011-05-23 13:26:33 +02:00
Volker Lendecke
28d7282738 s3: Remove unused cli_[en|de]crypt_message
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Mon May 23 12:15:33 CEST 2011 on sn-devel-104
2011-05-23 12:15:33 +02:00
Volker Lendecke
1a393b7cd6 s3: Directly call common_encrypt_buffer in cli_smb_req_iov_send 2011-05-23 11:06:08 +02:00
Volker Lendecke
df0e33008e s3: Remove cli_send/receive_smb
A moment of silence is due here, R.I.P.

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sun May 22 22:17:12 CEST 2011 on sn-devel-104
2011-05-22 22:17:12 +02:00
Volker Lendecke
ce9d63d161 s3: Remove the smbtorture3 OPLOCK3 test
This is the last user of cli_receive_smb. Oplocks are nowadays tested
in smbtorture4, this mainly has historic value
2011-05-22 21:07:40 +02:00
Volker Lendecke
9a787bbad1 s3: Convert the OPEN4 test to async oplock handling
This removes a caller of cli_receive_smb
2011-05-22 21:07:40 +02:00
Volker Lendecke
feb1d9fef3 s3: Remove clistr_align_out
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sat May 21 23:31:12 CEST 2011 on sn-devel-104
2011-05-21 23:31:12 +02:00