1
0
mirror of https://github.com/samba-team/samba.git synced 2024-12-28 07:21:54 +03:00
Commit Graph

19806 Commits

Author SHA1 Message Date
Volker Lendecke
ded2952e00 r16338: Fix Klocwork ID 150 2007-10-10 11:17:36 -05:00
Volker Lendecke
1b3a24732d r16337: Add configure fixes by Bjoern Jacke <samba@j3e.de>.
Volker
2007-10-10 11:17:36 -05:00
Volker Lendecke
def075baf8 r16336: Fix Klocwork ID's 1087, 1095, 1096, 1098, 1099, 1101, 1102, 1105, 1107, 1109,
1111

Volker
2007-10-10 11:17:35 -05:00
Volker Lendecke
555984ea77 r16335: Fix Klocwork IDs 107 108 109 111 112 113 114 116 117 118 121 2007-10-10 11:17:34 -05:00
Volker Lendecke
d3f5acb16e r16334: Fix Klocwork ID's 1087, 1095, 1096, 1098, 1099, 1101, 1102, 1105, 1107, 1109,
1111

Volker
2007-10-10 11:17:34 -05:00
Jeremy Allison
7e397b534a r16326: Klocwork #509. Always check return allocs.
Jeremy.
2007-10-10 11:17:33 -05:00
Jeremy Allison
2b69d436da r16324: Klocwork #499. Allways check results from alloc.
Jeremy.
2007-10-10 11:17:33 -05:00
Jeremy Allison
dd31f3fc0e r16322: Klocwork #481., Don't deref null on malloc fail.
Jeremy.
2007-10-10 11:17:33 -05:00
Jeremy Allison
fed55d653a r16320: Ensure variable is not null before calling fclose.
Klocwork #412.
Jeremy.
2007-10-10 11:17:33 -05:00
Jeremy Allison
aa0d739834 r16317: Klocwork #300. Check for error return on malloc.
Jeremy.
2007-10-10 11:17:33 -05:00
Jeremy Allison
22a345deed r16313: Not a problem - but ensure Klocwork is quiet (#872).
Jeremy.
2007-10-10 11:17:33 -05:00
Jeremy Allison
c430730f5a r16311: Check for NULL return. Klocwork #998.
Jeremy.
2007-10-10 11:17:33 -05:00
Jeremy Allison
34b6b6723b r16309: Fix Klocwork #1596. Check for NULL on talloc.
Jeremy.
2007-10-10 11:17:32 -05:00
Jeremy Allison
e8d86362ba r16307: Make sure we know we must pass a valid pointer here.
Klocwork #1129.
Jeremy.
2007-10-10 11:17:32 -05:00
Jeremy Allison
8ef11a7c6d r16306: Error handling in this asn1 code *sucks*. Fix a generic
class of memory leak bugs on error found by Klocwork (#123).
Many of these functions didn't free allocated memory on
error exit.
Jeremy.
2007-10-10 11:17:32 -05:00
Volker Lendecke
21aaede518 r16301: Fix a memleak 2007-10-10 11:17:32 -05:00
Jeremy Allison
ee77dde9b6 r16299: Fix another "dereferencing type-punned pointer will break
strict-aliasing rules" gcc4 warning.
Jeremy.
2007-10-10 11:17:32 -05:00
Jeremy Allison
db5b4e3f13 r16298: On request of jiri sasek - Sun Microsystems - Prague Czech Republic <Jiri.Sasek@Sun.COM>
change priv_op and priv_info to names that don't
conflict with the solaris namespace.
Jeremy.
2007-10-10 11:17:32 -05:00
Jeremy Allison
7ac5aee88c r16295: Fix gcc4 "warning: dereferencing type-punned pointer will break
strict-aliasing rules" warning.
Jeremy.
2007-10-10 11:17:32 -05:00
Lars Müller
da4c5c3b75 r16294: Fix syntax error.
Credits to Andreas Schwab from SUSE Linux for this fix.
2007-10-10 11:17:31 -05:00
Volker Lendecke
b96808bb62 r16290: Fix Coverity bugs 298 and 298 2007-10-10 11:17:31 -05:00
James Peach
3eee126458 r16289: Fix smbclient test hang. This is caused by readline refusing to believe
the end of file it receives when reading from a pipe after we force
interactive mode.
2007-10-10 11:17:31 -05:00
Jeremy Allison
e24361ecdd r16287: Use intptr_t to return an integer of an unknown type cast
to void *.
Jeremy.
2007-10-10 11:17:31 -05:00
Jeremy Allison
938545f535 r16285: On a 64-bit box, size_t != uint32. Ensure we use
the right parameter type.
Jeremy.
2007-10-10 11:17:31 -05:00
Jeremy Allison
face01ef01 r16284: Start fixing up gcc4 -O6 warnings on an x86_64 box. size_t != unsigned
int
in a format string.
Jeremy.
2007-10-10 11:17:31 -05:00
Jeremy Allison
c49ad9200b r16281: Start fixing up gcc4 -O6 warnings on an x86_64 box. size_t != unsigned
int
in a format string.
Jeremy.
2007-10-10 11:17:30 -05:00
Jeremy Allison
45d5cad8c2 r16280: Start fixing up gcc4 -O6 warnings on an x86_64 box. size_t != unsigned
int
in a format string.
Jeremy.
2007-10-10 11:17:30 -05:00
Jeremy Allison
3a15fff219 r16277: Start fixing up gcc4 -O6 warnings on an x86_64 box. size_t != unsigned int
in a format string.
Jeremy.
2007-10-10 11:17:30 -05:00
Jeremy Allison
952547471f r16275: Start fixing up gcc4 -O6 warnings on an x86_64 box. size_t != unsigned int
in a format string.
Jeremy.
2007-10-10 11:17:30 -05:00
James Peach
848ac756f6 r16274: Fix the smbclient prompting behaviour for both systems that have
libreadline and those that don't. We always use the built-in readline
replacement for non-interactive mode. Interactive prompts are always
emitted to stdout and non-interactive mode never prompts at all.

Introduce x_fdup to avoid spuriously closing stdout when a logfile is
specified on the command line and setup_logging is called a second time.
2007-10-10 11:17:30 -05:00
James Peach
dff1eba81e r16273: Add smbclient tests to verify that
in interactive mode, smbclient always prompts on stdout
        in non-interactive mode, smbclient never prompts
2007-10-10 11:17:30 -05:00
Günther Deschner
afdb118902 r16272: Fix memleak.
Guenther
2007-10-10 11:17:30 -05:00
Jeremy Allison
dc53d35b0a r16270: Fix Klocwork #706 - ensure sscanf has correct format
specifier.
Jeremy.
2007-10-10 11:17:29 -05:00
Günther Deschner
546710d58c r16269: Fix the build.
Guenther
2007-10-10 11:17:29 -05:00
Günther Deschner
535d03cbe8 r16268: Add TCP fallback for our implementation of the CHANGEPW kpasswd calls.
This patch is mainly based on the work of Todd Stecher
<tstecher@isilon.com> and has been reviewed by Jeremy.

I sucessfully tested and valgrinded it with MIT 1.4.3, 1.3.5, Heimdal
0.7.2 and 0.6.1rc3.

Guenther
2007-10-10 11:17:29 -05:00
Jeremy Allison
81731e1f68 r16267: Fix Klocwork #401, #402 - ensure format specifier
limited. Fix memleak in printing gencache contents.
Jeremy.
2007-10-10 11:17:28 -05:00
Günther Deschner
689ae22c80 r16261: Smaller fixes for net ads password.
Guenther
2007-10-10 11:17:28 -05:00
Gerald Carter
95763b94f7 r16255: Fix 'net ads join' when the workgroup is set incorrectly
in smb.conf.  This did work before the join rewrite.
Samba will have problems if you try to run any of the daemons
with an incorrect workgroup but it should not fail to join.

The summary is that a member server should always use it's
own machine name when setting up schannel since that is
the only account it has.  Thanks to Volker for the discussion.
2007-10-10 11:17:28 -05:00
Günther Deschner
fa19099112 r16253: Fix another host/ UPN case in (the currently unused)
cli_rpc_pipe_open_krb5.

Guenther
2007-10-10 11:17:28 -05:00
Volker Lendecke
678bbcf061 r16252: Fix Klocwork ID 1119, 1121.
Volker
2007-10-10 11:17:28 -05:00
Volker Lendecke
4974c598c0 r16251: for i in seq 1 1000
do
	echo "I will always compile before commit :-)"
done

Also fix Klokwork ID 806.

Volker
2007-10-10 11:17:28 -05:00
Volker Lendecke
d7a75ee94d r16250: Fix Klokwork IDs 148, 151, 152, 154.
Volker
2007-10-10 11:17:28 -05:00
Volker Lendecke
09586824f6 r16249: Fix Klokwork ID 130 2007-10-10 11:17:27 -05:00
Volker Lendecke
e56e3c19e1 r16248: Fix Coverity ID 297 2007-10-10 11:17:27 -05:00
Volker Lendecke
b82c95cb43 r16247: Fix Coverity ID 296 2007-10-10 11:17:27 -05:00
Jeremy Allison
afe2d4c493 r16245: Cope with string being zero len. Klocwork bug #410.
Jeremy.
2007-10-10 11:17:27 -05:00
Jeremy Allison
66275bd3bc r16243: Fix Klocwork bugs #581 and #706, ensure we check
the end of array first in the loop. Reformat to
modern standards.
Jeremy.
2007-10-10 11:17:27 -05:00
Jeremy Allison
a0d368197d r16241: Fix Klocwork #106 and others like it.
Make 2 important changes. pdb_get_methods()
returning NULL is a *fatal* error. Don't try
and cope with it just call smb_panic. This
removes a *lot* of pointless "if (!pdb)" handling
code. Secondly, ensure that if samu_init()
fails we *always* back out of a function. That
way we are never in a situation where the pdb_XXX()
functions need to start with a "if (sampass)"
test - this was just bad design, not defensive
programming.
Jeremy.
2007-10-10 11:17:27 -05:00
Jeremy Allison
6c61dc8ed6 r16230: Fix Klocwork #861 and others. localtime and asctime
can return NULL. Ensure we check all returns correctly.
Jeremy.
2007-10-10 11:17:26 -05:00
Günther Deschner
5ecfaf7d50 r16222: Fix DEBUG statements.
Guenther
2007-10-10 11:17:26 -05:00