sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-01-14 19:24:43 +03:00
Code
72,264 Commits 60 Branches 1,145 Tags
Commit Graph

36189 Commits

Author SHA1 Message Date
Volker Lendecke
37870e28ab s3: Fix Coverity ID 2233, REVERSE_INULL 
We have dereferenced h already in dcerpc_lsa_open_policy2 in line 425
 2011-03-16 22:07:24 +01:00
Volker Lendecke
dacb392db6 s3: Fix Coverity ID 2234: REVERSE_INULL 
We have dereferenced "b" already in dcerpc_samr_Connect2 in line 521
 2011-03-16 22:07:24 +01:00
Volker Lendecke
fb47b7fd67 s3: Fix Coverity ID 2140, DEADCODE 
This routine was never executed after f0dcc90f because "netname" was always
NULL.

Jeremy, please check!
 2011-03-16 22:07:24 +01:00
Volker Lendecke
dd3d6a160c s3: Fix Coverity ID 2144, DEADCODE 
We could never have assigned the real value in line 481.

Andreas, please check!
 2011-03-16 22:07:24 +01:00
Volker Lendecke
4f46ad96f2 s3: Fix Coverity ID 2147, FORWARD_NULL 
How could this ever have worked???
 2011-03-16 22:07:24 +01:00
Volker Lendecke
2581cb7ada s3: Fix Coverity ID 1402: PASS_BY_VALUE 
There's no point in passing GROUP_MAP on the stack

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Wed Mar 16 21:58:08 CET 2011 on sn-devel-104
 2011-03-16 21:58:08 +01:00
Volker Lendecke
a7a638c3cf s3: Fix Coverity ID 2213, PASS_BY_VALUE 
There's little point to pass a copy of this structure on the stack.

Günther, please check!
 2011-03-16 21:14:58 +01:00
Volker Lendecke
a282455978 s3: Fix Coverity ID 1012, CHECKED_RETURN 
This is probably more or less taste. Removing the necessity for a comment is a
good thing though IMO.
 2011-03-16 21:14:58 +01:00
Volker Lendecke
9c9ed33cb7 s3: Fix Coverity ID 1013, CHECKED_RETURN 
This is probably more or less taste. Removing the necessity for a comment is a
good thing though IMO.
 2011-03-16 21:14:58 +01:00
Volker Lendecke
3835d77795 s3: Fix Coverity ID 1017, CHECKED_RETURN 
Günther, please check!
 2011-03-16 21:14:58 +01:00
Volker Lendecke
920b2fddc6 s3: Fix Coverity ID 1018, CHECKED_RETURN 2011-03-16 21:14:58 +01:00
Volker Lendecke
4668ac8b16 s3: Fix Coverity ID 1034, CHECKED_RETURN 
In all other places we check the result of secrets_init.
 2011-03-16 21:14:58 +01:00
Volker Lendecke
7bb76bc7c7 s3: Fix Coverity ID 2100, BAD_SIZEOF 
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Wed Mar 16 18:52:18 CET 2011 on sn-devel-104
 2011-03-16 18:52:18 +01:00
Volker Lendecke
df79b3ba76 s3: Fix Coverity ID 2317: Uninitialized read 
We passed the structure including the uninitialized elements to
dcerpc_winreg_SetValue.
 2011-03-16 18:08:51 +01:00
Volker Lendecke
329fcd4e34 s3: Fix Coverity ID 2318: Uninitialized read 
We passed the structure including the uninitialized elements to
dcerpc_winreg_SetValue.
 2011-03-16 18:08:51 +01:00
Volker Lendecke
d8068b5a4b s3: Fix Coverity ID 2319: Uninitialized read 
We passed the structure including the uninitialized elements to
dcerpc_winreg_SetValue.
 2011-03-16 18:08:51 +01:00
Günther Deschner
9f9e195124 s3-packet: only include packet.h where needed. 
Guenther
 2011-03-16 16:56:47 +01:00
Günther Deschner
1f6aecb5cf s3-interfaces: only include interfaces.h where needed. 
Guenther
 2011-03-16 16:56:46 +01:00
Günther Deschner
1ce4d2d83a s3-msdfs: avoid global inclusion of msdfs.h. 
Guenther
 2011-03-16 16:56:46 +01:00
David Disseldorp
97cdf15f09 s3-printing: fix memory leak in print_cups.c 
As found by valgrind, tmp_pcap_cache is not freed following printer list
tdb update.

Signed-off-by: Andreas Schneider <asn@samba.org>

Autobuild-User: Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date: Wed Mar 16 16:37:58 CET 2011 on sn-devel-104
 2011-03-16 16:37:58 +01:00
David Disseldorp
52845c1054 s3-printing: remove duplicate cups response processing code 
There is currently a lot of duplicate code included for processing
responses to CUPS_GET_PRINTERS and CUPS_GET_CLASSES requests. This
change splits this code into a separate function.

Signed-off-by: Andreas Schneider <asn@samba.org>
 2011-03-16 15:52:21 +01:00
David Disseldorp
d6cb4feae1 s3-printing: use printcap IDL for IPC 
Use printcap IDL for marshalling and unmarshalling messages between cups
child and parent smbd processes. This simplifies the IPC and ensures
the parent is notified of cups errors encountered by the child.

https://bugzilla.samba.org/show_bug.cgi?id=7994
Signed-off-by: Andreas Schneider <asn@samba.org>
 2011-03-16 15:52:21 +01:00
Günther Deschner
fad0112373 s3-build: stop including ldap and lber headers everywhere in the code. 
Instead use new header smb_ldap.h where all LDAP API related things are handled,
while smbldap.h only deals with our smbldap_X() API.

Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Wed Mar 16 10:54:51 CET 2011 on sn-devel-104
 2011-03-16 10:54:50 +01:00
Günther Deschner
d19ea55e9e s3-includes: avoid global include of gssapi headers. 
Guenther
 2011-03-16 10:11:16 +01:00
Günther Deschner
6c8d802391 s3-libsmb: move smb encryption structs into own header. 
Guenther
 2011-03-16 10:11:16 +01:00
Günther Deschner
e1f84330ba libcli/security: move display_sec headers to own header file and add to 
security.h grouping header.

Guenther
 2011-03-16 10:11:08 +01:00
Volker Lendecke
9bc14afe96 s3: Fix a cut&paste error in pdb_ads_connect 
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Wed Mar 16 08:22:28 CET 2011 on sn-devel-104
 2011-03-16 08:22:28 +01:00
Volker Lendecke
831ff4519e s3: Use jenkins hash for str_checksum, fix bug 8010 
From the bugreport:

I have a folder with ~90 photos: IMG_XXXX.JPG where XXXX is a four digit
number, almost consecutive (photos from camera for one day).
Current implementation gives about 30 different checksums for this set of
files.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Wed Mar 16 01:15:41 CET 2011 on sn-devel-104
 2011-03-16 01:15:41 +01:00
Günther Deschner
5e3da3fc50 s3-build: try to silence annoying "Ignoring invalid value 'vlp' for parameter 'printing'" 
warning on the buildfarm.

Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Tue Mar 15 23:38:43 CET 2011 on sn-devel-104
 2011-03-15 23:38:43 +01:00
Günther Deschner
7a91282c9f s3-libsmb: only include rap client when needed. 
Guenther
 2011-03-15 21:16:35 +01:00
Günther Deschner
c91b897caa s3-build: share smbtorture4 build rules with s3-waf build. 
Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Tue Mar 15 16:10:17 CET 2011 on sn-devel-104
 2011-03-15 16:10:16 +01:00
Volker Lendecke
d9a58791b0 s3: Fix Coverity ID 2278: Uninitialized read 
We passed the structure including the uninitialized elements to
dcerpc_winreg_SetValue.
 2011-03-15 11:10:46 +01:00
Volker Lendecke
f0d491205c s3: Fix Coverity ID 2279: Uninitialized read 
We passed the structure including the uninitialized elements to
dcerpc_winreg_SetValue.
 2011-03-15 11:10:46 +01:00
Volker Lendecke
c98c36e38b s3: Fix Coverity ID 2280: Uninitialized read 
We passed the structure including the uninitialized elements to
dcerpc_winreg_SetValue.
 2011-03-15 11:10:46 +01:00
Volker Lendecke
6b584e0e9a s3: Fix Coverity ID 2281: Uninitialized read 
We passed the structure including the uninitialized elements to
dcerpc_winreg_SetValue.
 2011-03-15 11:10:45 +01:00
Volker Lendecke
e68cf5e9bf s3: Fix Coverity ID 2282: Uninitialized read 
We passed the structure including the uninitialized elements to
dcerpc_winreg_SetValue.
 2011-03-15 11:10:45 +01:00
Volker Lendecke
b753b0ab82 s3: Fix Coverity ID 2283: Uninitialized read 
We passed the structure including the uninitialized elements to
dcerpc_winreg_OpenKey.
 2011-03-15 11:10:45 +01:00
Volker Lendecke
2992ccfe9c s3: Fix Coverity ID 2284: Uninitialized read 
We passed the structure including the uninitialized elements to
dcerpc_winreg_DeleteValue.
 2011-03-15 11:10:45 +01:00
Volker Lendecke
2b26c86fe6 s3: Fix Coverity ID 2285: Uninitialized read 
We passed the structure including the uninitialized elements to
dcerpc_winreg_DeleteValue.
 2011-03-15 11:10:45 +01:00
Volker Lendecke
c09877113d s3: Fix Coverity ID 2286: Uninitialized read 
We passed the structure including the uninitialized elements to
dcerpc_winreg_SetValue.
 2011-03-15 11:10:44 +01:00
Volker Lendecke
31ff8f38e7 s3: Fix Coverity ID 2287: Uninitialized read 
We passed the structure including the uninitialized elements to
dcerpc_winreg_CreateKey.
 2011-03-15 11:10:43 +01:00
Volker Lendecke
09677d664f s3: Fix Coverity ID 2288: Uninitialized read 
We passed the structure including the uninitialized elements to
dcerpc_winreg_SetValue.
 2011-03-15 11:10:43 +01:00
Volker Lendecke
cc90415062 s3: Fix Coverity ID 2289: Uninitialized read 
We passed the structure including the uninitialized elements to
dcerpc_winreg_OpenKey.
 2011-03-15 11:10:42 +01:00
Volker Lendecke
4f34955e2c s3: Fix Coverity ID 2290: Uninitialized read 
We passed the structure including the uninitialized elements to
dcerpc_winreg_DeleteKey.
 2011-03-15 11:10:42 +01:00
Volker Lendecke
420be02a60 s3: Read uidNumber/gidNumber in pdb_ads_sid_to_id 
Question: How shall we allocate those? Something like the rid allocator?

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Tue Mar 15 09:59:55 CET 2011 on sn-devel-104
 2011-03-15 09:59:55 +01:00
Volker Lendecke
b0667f7fda s3: Remove some unused code 2011-03-15 09:15:36 +01:00
Volker Lendecke
a4d7b3a1df s3: "hex_encode" does the same as "binary_string" 2011-03-15 09:15:35 +01:00
Andrew Tridgell
af28facc03 s3-waf: enable public_headers_allow_broken 2011-03-15 12:22:20 +11:00
Andrew Tridgell
7a57f72ef4 s3-waf: enable public header building in s3 2011-03-15 12:22:20 +11:00
Jeremy Allison
a6d07a8e69 Re-enable base.tcondev test for S3, now we pass it correctly. 
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Tue Mar 15 00:59:37 CET 2011 on sn-devel-104
 2011-03-15 00:59:37 +01:00