1
0
mirror of https://github.com/samba-team/samba.git synced 2025-12-13 16:23:50 +03:00
Commit Graph

83 Commits

Author SHA1 Message Date
Kai Blin
f6c80d0d9c r26514: Revert the talloc.c part of r26511, as talloc.h already takes care of thois.
Thanks to metze for pointing this out
(This used to be commit 4a5e1047ff)
2007-12-21 05:51:19 +01:00
Kai Blin
ac4237e997 r26511: Janitorial: Fix a warning for the 'printf' attribute on gendb_search_v
While at it, also add a PRINTF_ATTRIBUTE for talloc_vasprintf.
(This used to be commit 5b3a8c8ae1)
2007-12-21 05:51:17 +01:00
Stefan Metzmacher
bc94aa19f3 r25216: make talloc_append_string() a deprecated macro instead of
having it as a real function.

metze
(This used to be commit 2b2e841465)
2007-10-10 15:06:56 -05:00
Stefan Metzmacher
3864520c9a r25211: fix compiler warning
metze
(This used to be commit c0d095c8c9)
2007-10-10 15:06:54 -05:00
Stefan Metzmacher
4a40dd2669 r25209: unify logic of talloc_vasprintf_append() and talloc_vasprintf_append_buffer()
metze
(This used to be commit 780c1c776e)
2007-10-10 15:06:53 -05:00
Stefan Metzmacher
46d369b0f0 r25208: add talloc_str[n]dup_append[_buffer]() functions
metze
(This used to be commit 8532076720)
2007-10-10 15:06:53 -05:00
Stefan Metzmacher
22b827ccbd r25207: remove one nesting level and use unlikely()
metze
(This used to be commit c2931540bc)
2007-10-10 15:06:53 -05:00
Stefan Metzmacher
3e58b6fd46 r25206: unify logic of talloc_strdup() and talloc_strndup(),
only strlen() vs. strnlen() is the difference now.

metze
(This used to be commit 92106e6b7e)
2007-10-10 15:06:52 -05:00
Jeremy Allison
151f422247 r25164: Add talloc_asprintf_append_buffer() and the docs for it.
Jeremy.
(This used to be commit 5bb8613b86)
2007-10-10 15:06:44 -05:00
Jeremy Allison
d8a5ed33b3 r25116: Fix talloc_asprintf_append to do the right thing with
truncated strings.
Jeremy.
(This used to be commit 948d32bb62)
2007-10-10 15:06:42 -05:00
Stefan Metzmacher
69de8f9ac8 r24626: as TALLOC_ABORT() is defined to abort() by default
wrap it into a function so that the function name
in the backtrace shows what happens.

metze
(This used to be commit 0216ff6daa)
2007-10-10 15:02:26 -05:00
Andrew Tridgell
6c973f4e8c r23798: updated old Temple Place FSF addresses to new URL
(This used to be commit 40c0919aaa)
2007-10-10 14:59:15 -05:00
Andrew Tridgell
b8d69a7ea2 r23795: more v2->v3 conversion
(This used to be commit 84b468b2f8)
2007-10-10 14:59:14 -05:00
Stefan Metzmacher
7ef755d150 r22758: - add missing _talloc_set_name_const(ret, ret); to talloc_append_string()
- update manpage and add comments about _talloc_set_name_const(ret, ret);
  in all places which use them

metze
(This used to be commit 5cd100de82)
2007-10-10 14:52:15 -05:00
Jeremy Allison
522f9ace14 r22563: As tridge requested remove the _strict calls - for Samba3 I'm moving
to a separate file.
Jeremy.
(This used to be commit 80706cf98d)
2007-10-10 14:51:44 -05:00
Jeremy Allison
b06fc3b53c r22539: Added _strict varients of the talloc calls to
return NULL on size == 0 varients.
Jeremy.
(This used to be commit 1ef269067c)
2007-10-10 14:51:39 -05:00
Andrew Tridgell
8538af1107 r21174: many thanks to Paul Wayper for pointing out that C99 requires a
matching va_end() for each va_copy(). This doesn't matter for most
architectures, but there could be some obscure ones where it does
matter.

some of this should be ported to Samba3
(This used to be commit 21eb316473)
2007-10-10 14:44:42 -05:00
Stefan Metzmacher
90d106de8a r20195: fix typo
metze
(This used to be commit 9d06a4b6e2)
2007-10-10 14:29:21 -05:00
Stefan Metzmacher
0d2bedbdd7 r20194: inline all static talloc functions
metze
(This used to be commit ee47b40441)
2007-10-10 14:29:21 -05:00
Stefan Metzmacher
bfbf6d546b r20193: - let talloc_parent_chunk() handle a NULL pointer
- use talloc_parent_chunk() in talloc_parent_name()
- add prototype of talloc_parent_name()

metze
(This used to be commit 85fc18f047)
2007-10-10 14:29:21 -05:00
Andrew Tridgell
5370afe8c2 r19412: some rather strange looking changes to talloc that gain us about 50%
in the talloc benchmark. These changes were driven by some cachegrind
profiles, with the biggest improvements coming from inlining some
functions.

I don't think it would be a good idea to start spreading inline and
likely()/unlikely() in other parts of Samba, as the benefit in most
code will be very small, but talloc() is such a speed critical part of
Samba that I think these changes are worthwhile
(This used to be commit 8644708c3f)
2007-10-10 14:21:29 -05:00
Simo Sorce
666a72e39a r19304: If you really want to look at the contents undef this one
(This used to be commit fe20ac404d)
2007-10-10 14:21:05 -05:00
Stefan Metzmacher
4ccdd53704 r18995: - fix bug 4078
- talloc_free(talloc_autofree_context()); should not result
  in a SIGABORT on exit
- add a test for this, but this test can also pass in the standalone build
  and samba3, as samba4 uses talloc_autofree_context()

metze
(This used to be commit 2be48c1b03)
2007-10-10 14:20:27 -05:00
Stefan Metzmacher
ee97148354 r18946: fix compiler warning
metze
(This used to be commit 4505958224)
2007-10-10 14:20:23 -05:00
Andrew Tridgell
c902a8927c r18521: implement volkers suggestion for avoiding the type punning warnings
(This used to be commit 9b9f058edb)
2007-10-10 14:18:41 -05:00
Andrew Tridgell
1a59784451 r18435: added a function talloc_move() which is like talloc_steal(), but is
meant for moving pointers between structures. The difference is that
talloc_move() will zero the source pointer, thus ensuring you don't
reference the pointer in the old context.

talloc_move() is appropriate in some, but not all cases where we use
talloc_steal() now. The interface came out of a discussion with
Jeremy.
(This used to be commit 200756017e)
2007-10-10 14:18:29 -05:00
Andrew Tridgell
a983b06d37 r18129: moved the system includes into libreplace - this gives much more
isolation of our portability environment from the main code, and also
simplifies the includes system (no separate #ifdef _SAMBA_BUILD for
tdb. ldb etc now)
(This used to be commit 77d1a468e0)
2007-10-10 14:17:36 -05:00
Stefan Metzmacher
3c6ce57101 r18100: actually make usage of libreplace :-)
metze
(This used to be commit 357882e6ec)
2007-10-10 14:17:16 -05:00
Volker Lendecke
f6f4d868ea r18027: Fix some 64-bit warnings
(This used to be commit cd495d8931)
2007-10-10 14:17:04 -05:00
Stefan Metzmacher
4ce057c3f4 r17950: sync talloc with samba3
metze
(This used to be commit 5697841e29)
2007-10-10 14:16:56 -05:00
Stefan Metzmacher
832ac85ba3 r17907: - add a generic talloc_report_depth_cb() function which takes a callback
to do the actual report.
- make the talloc_report_depth_file() a wrapper of it
- and talloc_report() and talloc_report_full() are wrapper of
  talloc_report_depth_file()

metze
(This used to be commit b199557b35)
2007-10-10 14:16:54 -05:00
Stefan Metzmacher
59057c8d56 r17895: - talloc_increase_ref_count() can fail
- make talloc_reference() typesafe when gcc >= 3 is used

metze
(This used to be commit 933d1b47ad)
2007-10-10 14:16:53 -05:00
Stefan Metzmacher
3400d91197 r17893: add a function to disable the null_context
metze
(This used to be commit 7cab4285b1)
2007-10-10 14:16:52 -05:00
Stefan Metzmacher
98a1bd7fb3 r17892: fix the last talloc c++ warning
metze
(This used to be commit 6955ffe454)
2007-10-10 14:16:52 -05:00
Stefan Metzmacher
45b8c41038 r17891: remove c++ warnings from talloc
metze
(This used to be commit fb73ce8d43)
2007-10-10 14:16:52 -05:00
Andrew Tridgell
c0e60d0535 r17578: in standalone talloc build ensure we get intptr_t if available (which
makes the discard_const stuff nicer)
(This used to be commit 662f01f8ba)
2007-10-10 14:15:38 -05:00
Stefan Metzmacher
da9723c224 r17264: - remove unused includes from talloc
- check explicit check for varargs.h as fallback from stdarg.h
  and fail the build if both are not present

metze
(This used to be commit b091d182fe)
2007-10-10 14:10:25 -05:00
Stefan Metzmacher
550f5fb26e r17176: remove off_t from talloc. size_t is large enough to hold
the max amount of memory of one process

metze
(This used to be commit f47b7bb656)
2007-10-10 14:10:16 -05:00
Stefan Metzmacher
4e4e698f2b r17062: make correct use of talloc destructors, and make the code much simpler
should I merge that aslo to samba3?

metze
(This used to be commit c5672a54a0)
2007-10-10 14:10:10 -05:00
Stefan Metzmacher
cab68a413b r17061: - remove the currect talloc chunk from it's parent before freeing the children
this fixes an endless loop bug!
- reenable the test for this

should I merge this to samba3?

metze
(This used to be commit 0559222b62)
2007-10-10 14:10:09 -05:00
Stefan Metzmacher
816c055123 r16446: talloc_set_name() allocates and can fail...
pass the error to the callers

metze
(This used to be commit 7aa07a1e0b)
2007-10-10 14:09:15 -05:00
Andrew Tridgell
d5e3f86ece r15856: fixed talloc_asprintf_append() on solaris
(This used to be commit bba33a976b)
2007-10-10 14:08:33 -05:00
Andrew Tridgell
a665cccd2e r15852: patch from Rusty to make talloc_set_destructor() and talloc_steal()
type safe. This only works on recent gcc versions. With other
compilers it reverts to a non-typesafe cast

The patch also ensures that talloc_free() does not change error on
systems where free() can change errno
(This used to be commit babbff5f77)
2007-10-10 14:08:32 -05:00
Andrew Tridgell
0db0de6190 r15828: a talloc steal optimisation spotted by metze
(This used to be commit e00ff9f35e)
2007-10-10 14:08:29 -05:00
Andrew Tridgell
5da75f5c36 r15824: fixed a subtle talloc bug to do with memory context loops. When you
have a structure that references one of its parents, and a parent of
that parent is freed, then the whole structure should be freed, not
just the reference.

this was found by the change notify code, as a side effect of fixing
the memory leak yesterday
(This used to be commit 70531dcaee)
2007-10-10 14:08:28 -05:00
Jelmer Vernooij
4a61e4901e r14999: Remove more unused autoconf code
Simplify va_copy() replacement code a bit
(This used to be commit a5c87360a7)
2007-10-10 14:04:00 -05:00
Andrew Tridgell
335d07d811 r14288: - make the snprintf call in talloc portable to older solaris boxes
- fixed an error found sing the beam analyser
(This used to be commit bc45451ddd)
2007-10-10 13:57:08 -05:00
Volker Lendecke
640509e6a7 r14131: Fix Coverity bug # 127
(This used to be commit 4d0aa6f525)
2007-10-10 13:56:53 -05:00
James Peach
b56dab83a4 r13400: Only return NULL from talloc_asprintf if vsnprintf returns an
error (ie. zero is not an error).
(This used to be commit 1ab4674196)
2007-10-10 13:51:52 -05:00
James Peach
f9f55ad5fc r13397: Propagate the error return from vsnprintf to trap the case where
we aren't linked against a C99 vsnprintf.
(This used to be commit 23782f899a)
2007-10-10 13:51:52 -05:00