Endi S. Dewata
ed4c107bc1
s4/dsdb: Fixed partition_search() not to pass special DN's to LDAP backend.
...
Signed-off-by: Matthias Dieter Wallnöfer <mdw@samba.org>
2010-06-28 19:33:45 +02:00
Endi S. Dewata
fa9557fee3
s4/auth: Fixed authsam_expand_nested_groups() to find entry SID if not available in the DN.
...
Signed-off-by: Matthias Dieter Wallnöfer <mdw@samba.org>
2010-06-28 19:33:44 +02:00
Volker Lendecke
ba0ba4e85b
s3: Make some routines static in smbldap
2010-06-28 16:57:04 +02:00
Matthias Dieter Wallnöfer
4fc51ad07a
s4:repl_meta_data LDB module - fix counter type
2010-06-28 14:51:09 +02:00
Matthias Dieter Wallnöfer
fc2d8fcb83
s4:acl LDB module - fix counter type
2010-06-28 14:51:09 +02:00
Matthias Dieter Wallnöfer
e5c5d371d1
s4:dcesrv_drsuapi.c - fix a counter variable
2010-06-28 14:51:09 +02:00
Matthias Dieter Wallnöfer
666b611182
s4:selftest - also "rpc.samr.users.privileges" does work now
2010-06-28 14:51:08 +02:00
Matthias Dieter Wallnöfer
4826fdf95f
s4:lsa RPC server - Fix up "dcesrv_lsa_DeleteObject"
...
- Return always "NT_STATUS_OK" on success
- Remove "talloc_free"s on handles since the frees are automatically performed by
the DCE/RPC server code
2010-06-28 14:51:08 +02:00
Matthias Dieter Wallnöfer
d01e36e647
s4:knownfail - "pwdLastSet" test does work now
2010-06-28 14:51:08 +02:00
Matthias Dieter Wallnöfer
5606173997
s4:torture/rpc/samr.c - test_SetPassword_LastSet - introduce the delays also for s4
2010-06-28 14:51:07 +02:00
Matthias Dieter Wallnöfer
c0160d0614
s4:torture - SAMR password tests - activate support for password sets on level "18" and "21"
2010-06-28 14:51:06 +02:00
Matthias Dieter Wallnöfer
b200d8a5ca
s4:selftest - activate the lanman password changes
...
This is needed for a working "OemChangePasswordUser2" operation.
2010-06-28 14:51:05 +02:00
Matthias Dieter Wallnöfer
d6098de507
s4:dcesrv_samr_SetUserInfo - implement right "pwdLastSet" behaviour
...
Behaviour as the torture SAMR passwords tests show.
2010-06-28 14:51:05 +02:00
Matthias Dieter Wallnöfer
3c1a9fb87f
s4:dcesrv_samr_SetUserInfo - deny operations when "fields_present" is 0
...
Taken from s3
2010-06-28 14:51:05 +02:00
Matthias Dieter Wallnöfer
ea83d21341
s4:dcesrv_samr_SetUserInfo - port the "SAMR_FIELD_LAST_PWD_CHANGE" check from s3 to s4
2010-06-28 14:51:04 +02:00
Matthias Dieter Wallnöfer
4c63bb312f
s4:dcesrv_samr_SetUserInfo - implement password set level 21
2010-06-28 14:51:04 +02:00
Matthias Dieter Wallnöfer
b705026771
s4:dcesrv_samr_SetUserInfo - implement case 18 which allows to reset the user password
2010-06-28 14:51:04 +02:00
Matthias Dieter Wallnöfer
8feda76d4f
s4:OemChangePasswordUser2 - return "NT_STATUS_WRONG_PASSWORD" when we haven't activated the the lanman auth
...
This is what s3 does.
2010-06-28 14:51:03 +02:00
Matthias Dieter Wallnöfer
8f20a5512a
s4:samr_password.c - add a function which sets the password through encrypted password hashes
...
Used for password sets on "samr_SetUserInfo" level 18 and 21.
2010-06-28 14:51:03 +02:00
Günther Deschner
427c953273
s4-smbtorture: fix typo.
...
Not my day...
Guenther
2010-06-28 14:47:16 +02:00
Matthias Dieter Wallnöfer
f2e0ca2662
s4:torture/rpc/samr.c - test_SetPassword_LastSet - fix "pwdLastSet" test
...
- Remove superflous checks (on level 18, 24, 26 we do always have "pwdLastSet"
resets if "password_expired" > 0)
- Fixed some bugs
Signed-off-by: Günther Deschner <gd@samba.org>
2010-06-28 14:33:17 +02:00
Günther Deschner
c5bab3ea33
s4-smbtorture: add trustDomainPasswords blob test to LOCAL-NDR testsuite.
...
Our parsing of this struct is incorrect atm. and apparently also causes the s4
server to crash.
Thanks to Sumit Bose <sbose@redhat.com> for providing the auth data retrieved
from a w2k3 domain.msc operation.
Guenther
2010-06-28 14:18:04 +02:00
Günther Deschner
158504381e
s3-registry: missed one perflib keyname delimiter.
...
Guenther
2010-06-28 14:18:04 +02:00
Volker Lendecke
121214df91
s3: More cleanup in winbindd_ads.c:query_user
...
We can't ads_msgfree after the ads struct has been killed. Do early returns.
2010-06-28 14:09:58 +02:00
Volker Lendecke
8707be6d75
s3: Fix a valgrind error
...
nss_get_info_cached does not necessarily fill in gid
2010-06-28 13:54:45 +02:00
Volker Lendecke
09a9cc32ee
s3: Re-arrange winbindd_ads.c:query_user
...
We can't access the LDAP message after nss_get_info_cached has potentially
destroyed the ads_struct
2010-06-28 13:54:45 +02:00
Volker Lendecke
a670804579
s3: free -> SAFE_FREE
2010-06-28 13:54:44 +02:00
Volker Lendecke
c79e0c0ce4
s3: Do an early TALLOC_FREE
2010-06-28 13:54:44 +02:00
Günther Deschner
658048ecbc
s3-registry: fix printing keyname delimiter.
...
Guenther
2010-06-28 13:16:31 +02:00
Günther Deschner
3d24040ac6
s3-registry: fix perfmon keyname delimiter.
...
Guenther
2010-06-28 13:16:31 +02:00
Andreas Schneider
0c579bc3e6
s3-net: Make sure that the data blob is initialized.
...
Found by clang-analyzer.
2010-06-28 12:56:13 +02:00
Andreas Schneider
f8b6ac6a08
s3-eventlog: Fixed the keyname delimiter for the registry key.
2010-06-28 12:56:13 +02:00
Andreas Schneider
378cd5dc38
s3-registry: Fixed keyname delimiter in KEY_CURRENT_VERSION_NORM.
2010-06-28 12:56:13 +02:00
Andreas Schneider
e716924590
s3-smbd: Make sure that status is initialized when used.
...
Found by clang-analyzer.
2010-06-28 12:56:13 +02:00
Andreas Schneider
6ac050f73f
s3-lanman: Make sure count is not used uninitialized if we jump to out.
...
Found by clang-analyzer.
2010-06-28 12:56:13 +02:00
Andreas Schneider
d11e184ed2
s3-vfs: Make sure that retval isn't used uninitialized.
...
Found by clang-analyzer.
2010-06-28 12:56:13 +02:00
Andreas Schneider
ac5600fc7e
s3-passdb: Make sure dn is initialized and don't free it.
...
dn is just a pointer to a memory which hasn't been duplicated.
Found by clang-analyzer.
2010-06-28 12:56:13 +02:00
Andreas Schneider
6d89116afe
s3-passdb: Make sure we don't call free on a garbage pointer.
...
Found by clang-analyzer.
2010-06-28 12:56:13 +02:00
Andreas Schneider
06a1766315
s3-lanman: Make sure that job_info is not undefined.
...
Found by clang-analyzer.
2010-06-28 12:56:13 +02:00
Andreas Schneider
459a1d58b1
s3-nmbd: Leave the sync function if there are no syncs.
...
Found by clang-analyzer.
2010-06-28 12:56:13 +02:00
Andreas Schneider
34de8a00dd
s3-libsmb: Make sure that finfo is initialized.
...
Found by clang-analyzer.
2010-06-28 12:56:13 +02:00
Günther Deschner
b6100fa72f
s3-eventlog: make sure _eventlog_OpenEventLogW fails when we cannot open the registry key.
...
Guenther
2010-06-28 12:53:10 +02:00
Volker Lendecke
c4d5cbbdc5
s3: Fix some valgrind errors
...
Essentially the same change as 15297ee
, this time for the client side.
Günther, Andrew B, please check!
Thanks,
Volker
2010-06-28 12:28:07 +02:00
Andreas Schneider
a81b97ff34
s3-passdb: Make sure that we don't assign garbage.
2010-06-28 10:18:12 +02:00
Andreas Schneider
dc2e41a16a
librpc: Use switch in GUID_from_data_blob().
2010-06-28 10:18:12 +02:00
Andreas Schneider
b46eccfb19
nss_wrapper: Fixed a possible NULL pointer problem.
2010-06-28 10:18:12 +02:00
Stefan Metzmacher
bdfba236e9
s4:ldap_server: don't start if we can't bind to port 389
...
metze
2010-06-28 09:58:13 +02:00
Nadezhda Ivanova
5a18fc2b2a
Implementation of self membership validated right.
...
When this right is granted, the user can add or remove themselves from a group even
if they dont have write property right.
2010-06-28 10:43:50 +03:00
Kamen Mazdrashki
a0bb31df5d
s4/test: Run DrsDeleteObjectTestCase as part of S4 testing
...
I put this test in the end of the list of tests as it
runs with 'vampire_dc' environment running.
Currently there are tests that are failing when we have
2 DCs constantly replicating in the test environment
(this, of course, should be fixed in the near future)
2010-06-28 04:43:29 +03:00
Kamen Mazdrashki
431386f327
s4/drs: re-implement 'renaming' object replication
...
We should rename objects only after we make sure, that
changes on the partner DC are newer than what we have.
This fixes a bug, when we have following situation with 2 DCs:
- we have an object O on the two DCs
- we rename (delete) object O on DC1
- DC1 replicates from DC2
In the above scenario, object O will be renamed back
to its original name (i.e. it will be restored).
Now, we check that DC2 state is older than what we have,
so nothing happens with object's DN.
2010-06-28 04:43:29 +03:00