Günther Deschner
f2243e8197
s3-netapi: Fix Coverity #775 (REVERSE_INULL).
...
Guenther
2009-03-20 11:19:59 +01:00
Günther Deschner
d2e348b191
s3-netapi: Fix Coverity #776 (REVERSE_INULL).
...
Guenther
2009-03-20 11:17:50 +01:00
Günther Deschner
97190ae184
s3-krb5: Fix Coverity #762 (REVERSE_INULL).
...
Guenther
2009-03-20 11:11:04 +01:00
Günther Deschner
73030b107d
s3-net: Fix Coverity #861 (UNINIT).
...
Guenther
2009-03-20 11:07:21 +01:00
Günther Deschner
d2fb6d3482
s3-net: Fix Coverity #898 (UNINIT).
...
Guenther
2009-03-20 11:04:59 +01:00
Günther Deschner
045151b767
s3-spoolss: pure comsetics.
...
sorry, I just need to do that.
Guenther
2009-03-20 10:49:45 +01:00
Günther Deschner
1524abd8bf
s3-krb5: Fix Coverity #722 (RESOURCE_LEAK).
...
Guenther
2009-03-20 10:41:44 +01:00
Günther Deschner
2c186be0df
s3-net: Fix Coverity #886 (FORWARD_NULL).
...
Guenther
2009-03-20 10:41:44 +01:00
Günther Deschner
842edcd2b0
s3-samr: try to to fix password_expired flag handling.
...
Guenther
2009-03-20 10:39:18 +01:00
Stefan Metzmacher
da46c37100
s4:build: include ../libcli/cldap/config.mk
...
This fixes commit 84a140f187
,
sorry!
metze
2009-03-20 10:16:00 +01:00
Bo Yang
808928c24b
Fix crash in async_smb.c
2009-03-20 09:56:15 +01:00
Andrew Bartlett
37f130fd89
s4:fullschema Use server-side sort to make the output deterministic
2009-03-20 16:47:34 +11:00
Andrew Bartlett
4a45b0da57
s4:ldb Allow paged_searches to be mixed with other controls
...
I want to mix this with the server-side sort in particular.
Andrew Bartlett
2009-03-20 16:45:52 +11:00
Andrew Bartlett
f696bb81f8
s4: Remove autogenerated attributes from minschema and fullschema output
...
These attributes will be generated by Samba on import, and do not need
to be in the schema file.
Andrew Bartlett
2009-03-20 16:28:42 +11:00
Andrew Bartlett
653dd024a6
Add minschema like tool to extract and dump the full schema from AD
2009-03-20 16:28:41 +11:00
Andrew Bartlett
5bfed623f5
s4:minschma Fix aggregate schema generation in minschema
...
The conversion from EJS to python I did with Jelmer this morning was
not quite complete, due mostly to the difference between print in EJS
and python (python implies a newline).
Andrew Bartlett
2009-03-20 16:28:41 +11:00
Andrew Bartlett
6906c01cac
s4:ldb Ensure to pass down options to LDB from python
...
This is needed for things such as to load modules, like the
paged_searches module.
Andrew Bartlett
2009-03-20 16:28:41 +11:00
Andrew Bartlett
1dc5b90e86
s4:ldb Fix the paged_searches module
...
This simplifies the code, removes presumptions about being the only
control in the reply, and allows it to function against Windows 2008.
For searches which did not require a paged result, the module was
simply returning a failure when the compleated search did not include
a paged result control.
Andrew Bartlett
2009-03-20 16:28:40 +11:00
Jelmer Vernooij
5fe2b28f45
Merge branch 'master' of git://git.samba.org/samba into minschema
2009-03-20 01:30:36 +01:00
Jelmer Vernooij
ec9aeeab00
Fix up minschema after the conversion from JavaScript.
...
Pair programmed over the phone with Andrew :-)
2009-03-20 01:29:31 +01:00
Jelmer Vernooij
722dc9eed3
pyldb: Improve exception message when a list is expected.
2009-03-20 00:33:43 +01:00
Michael Adam
3a4638db03
add a versiontest program to print samba_version_string().
...
This is to allow for testing samba_version_string() without
the need to compile any of the larger binaries like smbd or net...
Michael
2009-03-19 23:57:35 +01:00
Michael Adam
d813a90d18
version: fix handling of SAMBA_VERSION_VENDOR_PATCH.
...
We need a string version of this, or else version.c does not compile.
Michael
2009-03-19 23:57:34 +01:00
Dan Sledz
f603903cb0
s3: Fix a free of an uninitialized variable in winbind_get_sid_aliases
2009-03-19 14:59:23 -07:00
Stefan Metzmacher
18b4925031
s3:libads: use libcli/cldap code
...
metze
2009-03-19 16:26:00 +01:00
Stefan Metzmacher
4508152282
s3:build: compile lib/tsocket and libcli/cldap
...
metze
2009-03-19 16:25:59 +01:00
Stefan Metzmacher
84a140f187
move source4/libcli/cldap => libcli/cldap
...
metze
2009-03-19 16:25:59 +01:00
Stefan Metzmacher
c600e8ef42
s4:cldap: rewrite the cldap library based on tsocket
...
metze
2009-03-19 16:25:59 +01:00
Stefan Metzmacher
b69e72deda
lib/util: build tevent_unix.o and tevent_ntstatus.o as UTIL_TEVENT subsystem
...
metze
2009-03-19 16:25:58 +01:00
Stefan Metzmacher
4e18c24e2e
lib/tsocket: add tsocket_guide.txt section with specific details about bsd style sockets
...
metze
2009-03-19 16:25:58 +01:00
Stefan Metzmacher
f6efec5dd4
lib/tsocket: add a fast path to tsocket_writev_send/recv()
...
This is similar to the tsocket_sendto_send/recv() fast path.
metze
2009-03-19 16:25:57 +01:00
Stefan Metzmacher
b900e92425
lib/tsocket: add a fast path to tsocket_sendto_send/recv()
...
By first trying to send data without waiting for the socket
to become writeable we gain about 10-20% performance in the
LDAP-BENCH-CLDAP test.
metze
2009-03-19 16:25:57 +01:00
Stefan Metzmacher
235a7a420b
lib/tsocket: add tsocket_guide.txt section about the async _send/recv() helper functions
...
metze
2009-03-19 16:25:56 +01:00
Stefan Metzmacher
a27c6eb8e2
lib/tsocket: add tsocket_readv_send/recv()
...
metze
2009-03-19 16:25:56 +01:00
Stefan Metzmacher
6c8bd1005d
lib/tsocket: add tsocket_writev_queue_send/recv()
...
metze
2009-03-19 16:25:55 +01:00
Stefan Metzmacher
2e44ceaea8
lib/tsocket: add tsocket_writev_send/recv()
...
metze
2009-03-19 16:25:55 +01:00
Stefan Metzmacher
a140823cc9
lib/tsocket: add tsocket_connect_send/recv()
...
metze
2009-03-19 16:25:54 +01:00
Stefan Metzmacher
4002b7bdc1
lib/tsocket: add tsocket_sendto_queue_send/recv()
...
metze
2009-03-19 16:25:54 +01:00
Stefan Metzmacher
9ed7a45c88
lib/tsocket: add tsocket_sendto_send/recv()
...
metze
2009-03-19 16:25:54 +01:00
Stefan Metzmacher
ccfd6a6e39
lib/tsocket: add tsocket_recvfrom_send/recv()
...
metze
2009-03-19 16:25:53 +01:00
Stefan Metzmacher
6c88d61bdd
lib/tsocket: add an implementation for bsd style sockets.
...
metze
2009-03-19 16:25:53 +01:00
Stefan Metzmacher
c00126e609
lib/tsocket: add a tsocket_guide.txt with a description of the design
...
metze
2009-03-19 16:25:52 +01:00
Stefan Metzmacher
d848d517b5
lib/tsocket: add some useful helper functions
...
metze
2009-03-19 16:20:22 +01:00
Stefan Metzmacher
2e0e416676
lib/tsocket: add generic socket abstraction layer
...
This will replace source4/lib/socket/.
metze
2009-03-19 15:01:12 +01:00
Björn Jacke
011ad7245d
fix build on old Heimdal based systems
...
Signed-off-by: Günther Deschner <gd@samba.org>
2009-03-19 14:47:48 +01:00
Stefan Metzmacher
36e7045340
tevent: fix the nesting logic
...
Only tevent_loop_once and tevent_loop_until() should care
about the nesting level.
This fixes the samba3 printing code where we use tevent_loop_wait()
and don't allow nested events.
We still call the nesting hook for all levels, we need to decide
if we really want this...
metze
2009-03-19 14:39:22 +01:00
Stefan Metzmacher
88dd6af605
s3:libsmb: always create bytes array in cli_trans code
...
Otherwise we return NO_MEMORY without a reason for fragmented trans
requests, as talloc_append_blob() returns buf if we append a 0 length
blob. When we pass buf = NULL we'll get back NULL and then assume
NO_MEMORY...
metze
2009-03-19 13:57:21 +01:00
Stefan Metzmacher
880fbc4e8c
s3:libsmb: fix smb signing for fragmented trans/trans2/nttrans requests
...
Before we send the secondary requests we need to remove the
old mid=>seqnum mapping and reset cli->mid and make the new
mid=>seqnum mapping "persistent".
The bug we had in cli_send_trans was this:
The first cli_send_smb() incremented cli->mid
and the secondary requests used the incremented mid,
but as cli->outbuf still had the correct mid,
we send the correct mid to the server. The real problem
was that the cli_send_smb() function stored the seqnum
under the wrong mid.
cli_send_nttrans() was totally broken and now follows the
same logic as cli_send_trans().
The good thing is that in practice the problem is unlikely to happen,
because max_xmit is large enough to avoid secondary requests.
metze
2009-03-19 13:54:22 +01:00
Stefan Metzmacher
0dfdb7b911
s3:lib/util_sock: use sys_recv() instead of sys_read() on sockets
...
This ways the pcap support in socket wrapper sees the received data.
metze
2009-03-19 13:54:17 +01:00
Björn Jacke
2d1fcdc807
fix some typos
...
Signed-off-by: Michael Adam <obnox@samba.org>
2009-03-19 12:08:55 +01:00