1
0
mirror of https://github.com/samba-team/samba.git synced 2025-01-28 17:47:29 +03:00

80399 Commits

Author SHA1 Message Date
Andrew Bartlett
f38638d451 s3-smbd: Consider a group with the same SID as sufficient duplication
This code is to ensure that the user does not loose rights when their file
ownership is taken away.  If the owner (an IDMAP_BOTH SID) appears as a group
then a duplicate user is not required.

Signed-off-by: Jeremy Allison <jra@samba.org>
2012-05-17 03:17:05 +02:00
Andrew Bartlett
5b1c42228b s3-smbd: Handle ID_TYPE_BOTH by mapping to both a group ACL entry and file ownership This will allow groups, such as domain administrators, to own files while correctly handling the rest of the ACL permissions.
Andrew Bartlett

Signed-off-by: Jeremy Allison <jra@samba.org>
2012-05-17 03:17:05 +02:00
Andrew Bartlett
367a644c4d We need to split things up into a new helper function add_current_ace_to_acl() in order for there to be more posix ACL elements than NT ACL elements (so a group SID can own a file, but also get the group permissions that will be honoured)
Andrew Bartlett

Slightly modified by Jeremy to reduce diff size.

Signed-off-by: Jeremy Allison <jra@samba.org>
2012-05-17 03:17:05 +02:00
Jeremy Allison
173f818a29 This covers a case where an ID_TYPE_BOTH mapping creates group permissions, but must own the file. Based on an original patch by Andrew Bartlett. 2012-05-17 03:17:05 +02:00
Andrew Bartlett
59106473d3 s3-smbd: Do not merge UID ACE values with GID ACE values for posix ACL
This might happen when we get a SID mapped to IDMAP_BOTH.

Andrew Bartlett

Signed-off-by: Jeremy Allison <jra@samba.org>
2012-05-17 03:17:05 +02:00
Stefan Metzmacher
70be41c772 s3:onefs: remove all onefs related code as it not maintained anymore
See https://lists.samba.org/archive/samba-technical/2012-May/083631.html
for the discussion.

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Wed May 16 11:23:05 CEST 2012 on sn-devel-104
2012-05-16 11:23:04 +02:00
Richard Sharpe
bfe4a2baee Fix the overwriting of errno before use in a DEBUG statement and use the return value from store_acl_blob_fsp rather than ignoring it.
Autobuild-User: Richard Sharpe <sharpe@samba.org>
Autobuild-Date: Wed May 16 03:43:41 CEST 2012 on sn-devel-104
2012-05-16 03:43:40 +02:00
Andrew Bartlett
b6e36089e5 build: Add explicit mention of --abi-check-disable to ABI checker
This information has always been in the linked wiki page, but put it
in the build to unblock developers using platforms with slightly
different GDB output.

We can also assist this by improving the string normalisiation in the
ABI checker when example errors are provided.

It is better to build with the waf build and the full testsuite than
to avoid the waf build or not to use the developer options simply to
skip the ABI checker.

Andrew Bartlett

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Wed May 16 01:53:42 CEST 2012 on sn-devel-104
2012-05-16 01:53:42 +02:00
Volker Lendecke
18e2e86c08 libwbclient: Fix an invalid free()
Autobuild-User: Volker Lendecke <vl@samba.org>
Autobuild-Date: Wed May 16 00:00:00 CEST 2012 on sn-devel-104
2012-05-16 00:00:00 +02:00
Volker Lendecke
e5825ab22d wbinfo: Fix Coverity ID 242684 Resource leak 2012-05-15 22:03:24 +02:00
Volker Lendecke
c5eab2e9ac wbinfo: Fix Coverity ID 242685 Resource leak 2012-05-15 22:03:24 +02:00
Volker Lendecke
fc77ee5171 s3: Fix Coverity ID 242710 Untrusted pointer read
According to susv3 we have to make sure that we call isupper with
values only in the range of an unsigned char. This is best achieved
by automatic narrowing through assignment.
2012-05-15 21:37:17 +02:00
Volker Lendecke
2298622243 dbwrap: Fix Coverity ID 242750 Incorrect sizeof expression
Taking the size of "db" is correct, but a bit fishy. Silence Coverity.
2012-05-15 21:37:07 +02:00
Björn Baumbach
5f494c424c libcli/smb: move smb2cli_ioctl.c from source3 to the toplevel
Signed-off-by: Stefan Metzmacher <metze@samba.org>

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Tue May 15 20:17:01 CEST 2012 on sn-devel-104
2012-05-15 20:17:01 +02:00
Björn Baumbach
c16e263d0e libcli/smb: move smb2cli_query_directory.c from source3 to the toplevel
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2012-05-15 18:26:00 +02:00
Björn Baumbach
b2d9c02665 libcli/smb: move smb2cli_query_info.c from source3 to the toplevel
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2012-05-15 18:26:00 +02:00
Björn Baumbach
22b76de2ff libcli/smb: move smb2cli_set_info.c from source3 to the toplevel
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2012-05-15 18:26:00 +02:00
Björn Baumbach
1d7c6bfd7a libcli/smb: move smb2cli_flush.c from source3 to the toplevel
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2012-05-15 18:26:00 +02:00
Björn Baumbach
f50fc00306 libcli/smb: move smb2cli_write.c from source3 to the toplevel
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2012-05-15 18:26:00 +02:00
Björn Baumbach
269000b1b3 libcli/smb: move smb2cli_read.c from source3 to the toplevel
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2012-05-15 18:26:00 +02:00
Stefan Metzmacher
4022edc906 libcli/smb: move smb2cli_close.c from source3 to the toplevel
metze
2012-05-15 18:25:59 +02:00
Stefan Metzmacher
2674d0c458 libcli/smb: move smb2cli_create.c from source3 to the toplevel
metze
2012-05-15 18:25:59 +02:00
Stefan Metzmacher
35b54ae5a9 s3:libsmb: avoid interpret_long_date() in smb2cli_create
metze
2012-05-15 18:25:59 +02:00
Stefan Metzmacher
b488567a18 s3:cli_np_tstream: include smbXcli_base.h, because we'll use functions from there
metze
2012-05-15 18:25:59 +02:00
Volker Lendecke
8ae354ed4e s3: Remove some unused code
Autobuild-User: Volker Lendecke <vl@samba.org>
Autobuild-Date: Tue May 15 18:24:10 CEST 2012 on sn-devel-104
2012-05-15 18:24:10 +02:00
Volker Lendecke
c562a534c8 s3: Fix a likely cut&paste error 2012-05-15 16:18:50 +02:00
Stefan Metzmacher
5e6357b421 lib/ccan: add a missing dependency to 'execinfo' for 'backtrace()'
metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Tue May 15 16:12:54 CEST 2012 on sn-devel-104
2012-05-15 16:12:53 +02:00
Andreas Schneider
78af4738e7 s3-auth: Rename to init_system_session_info().
Autobuild-User: Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date: Tue May 15 13:56:00 CEST 2012 on sn-devel-104
2012-05-15 13:56:00 +02:00
Andreas Schneider
caaebb455c s3-auth: Don't lookup the system user in pdb.
This fixes bug #8944, ldapsam:trusted and ipasam. It is an additional
fix for bug #8567 (0528cb5f3a15b72dcb34ece21a3ffb3e7b8d6eb9).
2012-05-15 12:08:34 +02:00
Guy Harris
a66865dd28 Use ENC_ values for proto_tree_add_item() calls.
It appears that the integral value containing the bits in a bitmap should be
dissected according to the data representation, as the individual fields are
fetched by dissect_ndr_XXX, which is passed the data representation and
extracts the value appropriately for the data representation, so the patch
replaces TRUE (which meant "always little-endian" when the last argument to
proto_tree_add_item() was a byte-order Boolean) with DREP_ENC_INTEGER(drep)
(which means "ENC_BIG_ENDIAN or ENC_LITTLE_ENDIAN, depending on the data
representation").

For structures, I'm just using ENC_NA.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=8942
Signed-off-by: Jelmer Vernooij <jelmer@samba.org>

Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Tue May 15 12:07:06 CEST 2012 on sn-devel-104
2012-05-15 12:07:06 +02:00
Stefan Metzmacher
8588d10861 s4:ntvfs/smb2: remove misleading comment regarding security=server
metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Tue May 15 10:12:53 CEST 2012 on sn-devel-104
2012-05-15 10:12:52 +02:00
Stefan Metzmacher
12ce84f0cf s4:ntvfs/cifs: remove misleading comment regarding security=server
metze
2012-05-15 08:18:29 +02:00
Stefan Metzmacher
7cb4acd5dd s4:auth: remove unused auth_server.c
metze
2012-05-15 08:18:29 +02:00
Stefan Metzmacher
413e1be773 s3:auth: remove unused auth_server.c
metze
2012-05-15 08:18:29 +02:00
Stefan Metzmacher
0239f680a7 docs-xml: remove documentation of "SECURITY = SERVER"
metze
2012-05-15 08:18:28 +02:00
Stefan Metzmacher
b4abd3faaf s3-auth: remove "security=server" (depricated since 3.6)
"security=server" has a lot of problems in the world with
modern security (ntlmv2 and krb5). It was also not very
reliable, as it needed a stable connection to the password
server for the lifetime of the whole client connection!

Please use "security=domain" or "security=ads" is you
authentication against remote servers (domain controllers).

metze
                       --------------
                      /              \
                     /      REST      \
                    /        IN        \
                   /       PEACE        \
                  /                      \
                  |      SEC_SERVER      |
                  |    security=server   |
                  |                      |
                  |                      |
                  |       12 May         |
                  |                      |
                  |        2012          |
                 *|     *  *  *          | *
        _________)/\\_//(\/(/\)/\//\/\///|_)_______
2012-05-15 08:18:28 +02:00
Stefan Metzmacher
053fcfef0f s4:param/tests: remove "security=server" test
metze
2012-05-15 08:18:28 +02:00
Andrew Bartlett
f67cb32b51 selftest: Remove tests for security=server
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2012-05-15 08:18:27 +02:00
Amitay Isaacs
747e539ad0 samba-upgradedns: Use the correct magic incantation of sys.path.insert()
This replaces "bin/python" with the correct path for python libraries. The
pattern requires double quotes (") instead of single quotes (').

Autobuild-User: Amitay Isaacs <amitay@samba.org>
Autobuild-Date: Tue May 15 05:19:46 CEST 2012 on sn-devel-104
2012-05-15 05:19:46 +02:00
Volker Lendecke
997da4a28b s3: talloc_zero is not needed for structs we ndr_pull into
Autobuild-User: Volker Lendecke <vl@samba.org>
Autobuild-Date: Mon May 14 18:59:07 CEST 2012 on sn-devel-104
2012-05-14 18:59:07 +02:00
Stefan Metzmacher
aca64f642d libcli/smb: move smb2cli_logoff_* from source3 to the top level
metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Mon May 14 17:02:46 CEST 2012 on sn-devel-104
2012-05-14 17:02:46 +02:00
Stefan Metzmacher
ce0d6d89ee libcli/smb: git mv smb2_session.c smb2cli_session.c
metze
2012-05-14 15:12:35 +02:00
Stefan Metzmacher
bf6b2fa96b s3:libsmb: s/\<event_context/tevent_context/gc in smb2cli_write.c
metze
2012-05-14 15:12:35 +02:00
Stefan Metzmacher
2a39c5f513 s3:libsmb: s/\<event_context/tevent_context/gc in smb2cli_session.c
metze
2012-05-14 15:12:35 +02:00
Stefan Metzmacher
640154c434 s3:libsmb: s/\<event_context/tevent_context/gc in smb2cli_read.c
metze
2012-05-14 15:12:34 +02:00
Stefan Metzmacher
1395e46a8c s3:libsmb: s/\<event_context/tevent_context/gc in smb2cli_query_directory.c
metze
2012-05-14 15:12:34 +02:00
Stefan Metzmacher
f88c60bc70 s3:libsmb: s/\<event_context/tevent_context/gc in smb2cli_ioctl.c
metze
2012-05-14 15:12:34 +02:00
Stefan Metzmacher
1355552452 s3:libsmb: s/\<event_context/tevent_context/gc in smb2cli_flush.c
metze
2012-05-14 15:12:34 +02:00
Stefan Metzmacher
820160ca0d s3:libsmb: s/\<event_context/tevent_context/gc in smb2cli_create.c
metze
2012-05-14 15:12:34 +02:00
Stefan Metzmacher
b2dcc7a061 s3:libsmb: s/\<event_context/tevent_context/gc in smb2cli_close.c
metze
2012-05-14 15:12:34 +02:00