Jeremy Allison
fccae57310
Fix a really subtle old, old bug :-). When canonicalizing the
...
NT ACL into a POSIX one, if the group being set is the primary group
of the file, map it into a SMB_ACL_GROUP_OBJ, not a SMB_ACL_GROUP.
Otherwise we get an extra bogus group entry in the POSIX ACL.
Jeremy.
(This used to be commit 4d302254fd
)
2008-01-24 18:13:22 -08:00
Jeremy Allison
dd67913a99
Correctly set flags in ACE's inherited from parent. Still one bug
...
left to find then I'll back-port to 3.0.28.
Jeremy.
(This used to be commit 3df2f7ca78
)
2008-01-24 17:50:07 -08:00
Jeremy Allison
4ee9d715a0
Fix missing error check that caused crash when winbindd not running.
...
Jeremy.
(This used to be commit f5ca241e2c
)
2008-01-24 17:40:35 -08:00
Michael Adam
76e5c1f79a
Fix lookup_sids to detect unix_groups and unix_users domain sids.
...
This fixes panics in wbcLookupRids when 1-2-22 was passed as a
domain sid.
Michael
(This used to be commit c0d9732cf4
)
2008-01-25 01:42:22 +01:00
Michael Adam
60daaeeb34
Add a debug message: show the sid lookup_sid() was called for.
...
Michael
(This used to be commit 6c7c6c3f85
)
2008-01-25 01:42:22 +01:00
Michael Adam
9912f82067
Add debug message: show which domain_child is being forked.
...
Michael
(This used to be commit 373a00ae0d
)
2008-01-25 01:42:22 +01:00
Michael Adam
d682e04828
Add a debug message to lookup_rids() printing the domain SID.
...
This is to ease debugging. I sporadically get panics that are
apparently due to NULL domain sid passed to lookup_rids somewhere.
Michael
(This used to be commit 723e877c24
)
2008-01-25 01:42:22 +01:00
Michael Adam
2a542ce772
Add a debug message winbindd_can_contact_domain()
...
explaining the reason for failure.
Michael
(This used to be commit ba5373ed7f
)
2008-01-25 01:42:22 +01:00
Michael Adam
614ba32b22
Fix assignment to request->data.init_conn.is_primary in init_child_connection().
...
The present assignment
"request->data.init_conn.is_primary = domain->internal ? False : True"
simply feels wrong. This seems to be the thing right to do:
"request->data.init_conn.is_primary = domain->primary ? true : false".
The question is: Does this have any purpose at all?
data.init_conn.is_primary seems to be used nowhere
in the whole code at all.
Is it (still) needed?
Michael
(This used to be commit 8bb21b8b38
)
2008-01-25 01:42:22 +01:00
Jeremy Allison
d490d8d52d
Merge branch 'v3-2-test' of ssh://jra@git.samba.org/data/git/samba into v3-2-test
...
(This used to be commit ef2913a66c
)
2008-01-24 16:16:40 -08:00
Jeremy Allison
50c7e98a46
Make explicit in debug we're ignoring flags from the parent SD.
...
Jeremy
(This used to be commit 58cfa4b1bd
)
2008-01-24 16:13:53 -08:00
Günther Deschner
92183450f1
Trying to avoid defining new SAMR acct creation flags when we already have them with different
...
names. Matt, Jeremy, please check.
Guenther
(This used to be commit d4a9e46edf
)
2008-01-25 01:04:30 +01:00
Günther Deschner
ed8385a177
Re-run make idl.
...
Guenther
(This used to be commit c0bf3af692
)
2008-01-25 00:11:58 +01:00
Günther Deschner
9f7170f5aa
Rename samr_*AccessMask bitfields to start with SAMR_.
...
Guenther
(This used to be commit 6226f2294e
)
2008-01-25 00:07:39 +01:00
Günther Deschner
372f74bba2
Add WERR_INVALID_COMPUTER_NAME.
...
Guenther
(This used to be commit cb1ff32eff
)
2008-01-24 23:41:59 +01:00
Günther Deschner
96b41578a7
Add cmd_netlogon_gettrustrid() to rpcclient.
...
Guenther
(This used to be commit 231a4d051f
)
2008-01-24 23:41:53 +01:00
Günther Deschner
cd8ef2e41d
make idl.
...
Guenther
(This used to be commit 212f6fc000
)
2008-01-24 23:41:45 +01:00
Günther Deschner
5546c09d8b
Add IDL for netr_LogonGetTrustRid.
...
Guenther
(This used to be commit 6f38c2f060
)
2008-01-24 23:41:37 +01:00
Jeremy Allison
85a44396a7
Add debug messages to trace this if needed.
...
Jeremy.
(This used to be commit b628269b32
)
2008-01-24 13:27:00 -08:00
Jeremy Allison
47a8e77513
The checks for OI and CI were just wrong.... Fix them. Thanks to
...
Jim for testing this.
Jeremy.
(This used to be commit e898789e0d
)
2008-01-24 13:06:11 -08:00
Jeremy Allison
70e1ce6403
First part of fix for bug #4929 - worked out by jmcd.
...
Cope with protected ACL set correctly.
Jeremy.
(This used to be commit f5e50f42e7
)
2008-01-24 12:59:08 -08:00
Günther Deschner
6b1c45a5c2
Fix winbindd build w/o ADS.
...
Guenther
(This used to be commit 40daef4c3d
)
2008-01-24 17:40:35 +01:00
Volker Lendecke
1eb484d4b4
Fix Coverity ID 454
...
(This used to be commit 902d1d6709
)
2008-01-24 16:31:55 +01:00
Volker Lendecke
ba6c78c355
Fix Coverity ID 463
...
(This used to be commit 21d126c56a
)
2008-01-24 16:31:55 +01:00
Volker Lendecke
0ff38a8263
Fix Coverity ID 465
...
(This used to be commit 8629a0e1c3
)
2008-01-24 16:31:55 +01:00
Günther Deschner
fcf42bb19c
Add winbind_msg_dump_domain_list to winbindd.
...
Guenther
(This used to be commit 54ad97bd83
)
2008-01-24 16:22:04 +01:00
Günther Deschner
af7f24d979
Add winbindd debugging ndr_print helpers.
...
Guenther
(This used to be commit 4389e4dadb
)
2008-01-24 16:21:59 +01:00
Günther Deschner
108fc52c6b
Add dump-domain-list command for debugging winbindd's domain_list.
...
Guenther
(This used to be commit 10fa43f284
)
2008-01-24 16:21:53 +01:00
Stefan Metzmacher
048c80bf54
rerun 'make idl'
...
metze
(This used to be commit 37b9545051
)
2008-01-24 15:17:46 +01:00
Stefan Metzmacher
530e503a92
netlogon.idl: add some MSV1_0_ values from samba3 and use a bitmap32
...
metze
(cherry picked from commit 7222edb9cd
)
(This used to be commit 503082e15e
)
2008-01-24 15:17:45 +01:00
Günther Deschner
df5b03a780
Re-run make idl and use generated ndr based on samba4 security.idl (except for DOM_SID).
...
Guenther
(This used to be commit 1781a57b18
)
2008-01-24 13:54:45 +01:00
Günther Deschner
b00529585d
Merge over security.idl from samba4.
...
Guenther
(This used to be commit 57f2b8d0a8
)
2008-01-24 13:54:33 +01:00
Günther Deschner
3b5913810c
Fix samr_EnumDomainUsers in samba3, must not be a ref pointer here.
...
Guenther
(This used to be commit 3b87c5ce4f
)
2008-01-24 13:54:26 +01:00
Stefan Metzmacher
5695f9b09f
netlogon.idl: make use of bitmap samr_GroupAttrs
...
metze
(from v4-0-test 6d68161e67
)
(This used to be commit 9b5f69cb1f
)
2008-01-24 10:30:51 +01:00
Stefan Metzmacher
0bcb0c8d80
netlogon.idl: remove unused netr_GroupsMembership structure
...
We have samr_RidWithAttribute and use that in all cases.
metze
(cherry picked from commit 3c5bae2249
)
(This used to be commit 6ed640fade
)
2008-01-24 10:29:11 +01:00
Volker Lendecke
9344628bef
More read_data -> read_socket_with_timeout
...
(This used to be commit f1d7de462c
)
2008-01-24 09:41:22 +01:00
Derrell Lipman
2e7e3095a6
Merge branch 'setxattr-dos-mode' into v3-2-test
...
(This used to be commit 4c08725a42
)
2008-01-23 20:50:24 -05:00
Derrell Lipman
e0021b586d
Allow clearing all settable DOS mode bits. A mode value of zero is ignored by
...
Windows. If the requested mode is zero, we instead send the appropriate one
of 0x80 (NORMAL) or 0x10 (DIRECTORY).
Thanks Jeremy!
Derrell
(This used to be commit 54abf7d0e5
)
2008-01-23 20:44:54 -05:00
Jeremy Allison
ffc84a1044
Don't leak memory in error path.
...
Jeremy.
(This used to be commit 2df0cdaafd
)
2008-01-23 15:23:16 -08:00
Jeremy Allison
fe8a8f47e0
Use strchr_m in seaching for '.' in the hostname to make sure we're mb safe.
...
Jeremy.
(This used to be commit 090061b73a
)
2008-01-23 15:00:40 -08:00
Andreas Schneider
cfe7b54e96
Fix Windows 2008 (Longhorn) join.
...
During 'net ads join' the cli->desthost is a hostname (e.g.
rupert.galaxy.site). Check if we have a hostname and use only the
first part, the machine name, of the string.
(This used to be commit 5f60ed4af6
)
2008-01-23 14:57:45 -08:00
Andreas Schneider
691c4b1a41
Windows 2008 (Longhorn) auth2 flag fixes.
...
Interop fixes for AD specific flags. Original patch from Todd Stetcher.
(This used to be commit 5aadfcdaac
)
2008-01-23 14:55:22 -08:00
Jeremy Allison
a0186fb78d
Forward ported version of Matt Geddes <musicalcarrion@gmail.com>
...
patch for adding acct_flags to rpccli_samr_create_dom_user().
Jerry please test.
Jeremy.
(This used to be commit 7d94f97947
)
2008-01-23 13:54:02 -08:00
Volker Lendecke
a925a53f61
read_socket_with_timeout has timeout=0 handling
...
(This used to be commit 7101026061
)
2008-01-23 17:09:10 +01:00
Volker Lendecke
587cf54c61
strtok -> strtok_r
...
(This used to be commit fd34ce4370
)
2008-01-23 15:08:04 +01:00
Michael Adam
2051243132
Fix panic: Don't free the logfilename in winbind_child_died().
...
The child struct is immediately reused, and this results
in a panic when child->logfilename == NULL.
Michael
(This used to be commit da131d089d
)
2008-01-23 14:33:22 +01:00
Michael Adam
3b83f49158
Initialize _domain_list to NULL.
...
Just to be sure the "if (!_domain_list)" in domain_list() test always works.
Michael
(This used to be commit 1f49065d44
)
2008-01-23 13:52:42 +01:00
Günther Deschner
5f962d9b98
Fix get_trust_creds() to return always an upper-cased krb5 principal (this
...
fixes winbind krb5 session at least with heimdal).
Guenther
(This used to be commit 9cf3a98eac
)
2008-01-23 12:05:01 +01:00
Volker Lendecke
5b35ecd930
Remove two unused variables
...
(This used to be commit f12ac1eced
)
2008-01-23 10:33:36 +01:00
Michael Adam
a60b913a37
Fix tab_depth: it should not create an extra debug header.
...
In pstring removal 4ae4b23586
, the behaviour of tab_depth was
changed to create an extra debug header (by using the DEBUGLVL
macro).
This extracts the debug level check from DEBUGLVL into
a macro CHECK_DEBUGLVL without the debug header creation
and uses this instead of DEBUGLVL in tab_depth.
Michael
(This used to be commit cbc7d921fa
)
2008-01-23 08:16:37 +01:00