sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-01-27 14:04:05 +03:00
Code
samba-mirror/source3/smbd
History
David Disseldorp 22edd69503 smbd: improve reinit_after_fork error handling 
reinit_after_fork() may panic or return an error on failure. When smbd
is started in interactive mode, it ignores the reinit_after_fork()
return status and unconditionally proceeds to smbd_process().

Similarly, if messaging_reinit() fails within reinit_after_fork() then
it will subsequently call ctdb_async_ctx_reinit() if clustering is
enabled.

There's no reason why these errors shouldn't be handled immediately, so
add appropriate error handling.

Found by code inspection; not seen in the wild.

Signed-off-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>

Autobuild-User(master): David Disseldorp <ddiss@samba.org>
Autobuild-Date(master): Wed Sep  4 09:53:01 UTC 2024 on atb-devel-224
2024-09-04 09:53:01 +00:00
..
notifyd
smbd: Slightly simplify notifyd_send_delete()
2024-04-23 17:53:36 +00:00
avahi_register.c
…
blocking.c
s3:smbd: Fix code spelling
2023-07-19 09:58:37 +00:00
close.c
smbd: Modernize a few DEBUGs
2024-05-15 16:51:39 +00:00
conn_idle.c
smbd: Remove sconn->using_smb2
2024-04-17 07:57:36 +00:00
conn_msg.c
smbd: Add close-denied-share message
2020-01-15 21:25:35 +00:00
conn.c
smbd: maintain veto_list and hide_list in the vuid cache
2024-07-26 10:06:30 +00:00
connection.c
s3:param: make "servicename" a substituted option
2019-11-27 10:25:37 +00:00
dfree.c
s3:smbd: Fix code spelling
2023-07-19 09:58:37 +00:00
dir.c
s3:smbd: let mkdir_internal() work more atomically using a temporary name
2024-08-21 08:02:30 +00:00
dir.h
smbd: Give source3/smbd/dir.c its own header file
2023-12-19 16:05:36 +00:00
dmapi.c
s3:smbd: Fix code spelling
2023-07-19 09:58:37 +00:00
dnsregister.c
…
dosmode.c
smbd: Inline set_sticky_write_time_path into set_sticky_write_time_fsp
2024-08-27 07:19:32 +00:00
durable.c
smbd: Modernize a DEBUG statement
2023-11-15 05:10:35 +00:00
error.c
s3: smbd: Rename reply_outbuf() -> reply_smb1_outbuf().
2022-04-07 17:37:30 +00:00
fake_file.c
smbd: Fix whitespace
2023-11-01 18:55:32 +00:00
fd_handle.c
s3:smbd: Fix code spelling
2023-07-19 09:58:37 +00:00
fd_handle.h
smbd: fd_handle.h does not need includes.h
2022-04-26 21:41:29 +00:00
file_access.c
smbd: use check_any_access_fsp() for all access checks
2024-01-08 15:53:36 +00:00
fileio.c
smbd: allow POSIX opens for file_set_dosmode() in mark_file_modified()
2023-11-05 18:34:38 +00:00
filename.c
smbd: Use new symlink_target_path routine
2024-07-04 15:26:36 +00:00
files.c
s3/lib: move path_to_strv() to util_path.c
2024-07-26 10:06:30 +00:00
globals.c
smbd: Slightly simplify set_current_case_sensitive()
2022-12-14 22:54:29 +00:00
globals.h
s3:smbd: let mkdir_internal() work more atomically using a temporary name
2024-08-21 08:02:30 +00:00
mangle_hash2.c
s3:smbd: Add missing newlines to logging messages
2023-08-08 04:39:38 +00:00
mangle_hash.c
s3:smbd: Fix code spelling
2023-07-19 09:58:37 +00:00
mangle.c
smbdotconf: mark "mangling method" with constant="1"
2019-11-27 10:25:37 +00:00
msdfs.c
s3:smbd: Fix code spelling
2024-02-08 02:48:44 +00:00
notify_fam.c
…
notify_inotify.c
smbd: Align two integer types
2020-11-04 18:55:39 +00:00
notify_msg.c
notifyd: Factor out notify_walk() into its own file
2020-10-24 05:57:31 +00:00
notify.c
smbd: Simplify notify_filter_string
2024-06-24 16:21:32 +00:00
ntquotas.c
smbd: Fix some whitespace
2023-11-01 18:55:32 +00:00
open.c
s3:smbd: fix NULL dereference in case of readlink failure
2024-08-23 09:27:06 +00:00
oplock_linux.c
s3:smbd: Add missing newlines to logging messages
2023-08-08 04:39:38 +00:00
password.c
smbd: Give smbXsrv_session.c its own header file
2024-03-12 13:31:31 +00:00
posix_acls.c
smbd: use metadata_fsp(fsp) in copy_access_posix_acl() for SMB_VFS_SYS_ACL_SET_FD
2024-09-02 08:55:28 +00:00
proto.h
smbd: Inline set_sticky_write_time_path into set_sticky_write_time_fsp
2024-08-27 07:19:32 +00:00
pysmbd.c
Use python.h from libreplace
2023-11-20 15:37:33 +00:00
quotas.c
s3:smbd: Fix code spelling
2023-07-19 09:58:37 +00:00
scavenger.c
s3:smbd: Avoid integer overflow (CID 1035487)
2023-10-13 02:18:31 +00:00
scavenger.h
…
seal.c
s3:smbd: Fix invalid memory free
2024-07-08 07:36:32 +00:00
sec_ctx.c
libcli/security: Rename dup_nt_token() -> security_token_duplicate()
2023-09-26 23:45:36 +00:00
server_exit.c
smbd: Give smbXsrv_session.c its own header file
2024-03-12 13:31:31 +00:00
server_reload.c
smbd: Remove source3/smbd/statcache.c
2022-12-14 22:54:29 +00:00
server.c
smbd: improve reinit_after_fork error handling
2024-09-04 09:53:01 +00:00
session.c
…
share_access.c
smbd: return errors from token_contains_name()
2024-07-26 10:06:31 +00:00
smb1_aio.c
smbd: Remove unused "pcd" arg from smb1_srv_send()
2023-06-05 17:17:35 +00:00
smb1_aio.h
smbd: Move schedule_aio_write_and_X to smb1_aio.c
2022-04-07 17:37:29 +00:00
smb1_ipc.c
s3: smbd: Ensure all callers to srvstr_pull_req_talloc() pass a zeroed-out dest pointer.
2023-08-14 15:55:43 +00:00
smb1_ipc.h
smbd: Move ipc.c -> smb1_ipc.c
2022-04-07 17:37:29 +00:00
smb1_lanman.c
lib: Give lib/util/util_file.c its own header file
2024-04-16 23:51:45 +00:00
smb1_lanman.h
smbd: Move lanman.c -> smb1_lanman.c
2022-04-07 17:37:29 +00:00
smb1_message.c
s3: smbd: Ensure all callers to srvstr_pull_req_talloc() pass a zeroed-out dest pointer.
2023-08-14 15:55:43 +00:00
smb1_message.h
smbd: Move message.c -> smb1_message.c
2022-04-07 17:37:29 +00:00
smb1_negprot.c
smbd: Don't leave a pointer variable uninitialized
2024-06-28 13:26:24 +00:00
smb1_negprot.h
smbd: Move negprot.c -> smb1_negprot.c
2022-04-07 17:37:29 +00:00
smb1_nttrans.c
smbd: Modernize a DEBUG
2024-06-28 13:26:24 +00:00
smb1_nttrans.h
smbd: Remove duplicate read_nttrans_ea_list function prototype
2022-04-07 17:37:30 +00:00
smb1_oplock.c
smbd: Remove unused "pcd" arg from smb1_srv_send()
2023-06-05 17:17:35 +00:00
smb1_oplock.h
smbd: Move send_break_message_smb1 to smb1_oplock.c
2022-04-07 17:37:29 +00:00
smb1_pipes.c
smbd: Remove code #ifdef'ed out >23years ago
2023-11-01 18:55:32 +00:00
smb1_pipes.h
smbd: Move reply_pipe_write to smb1_pipes.c
2022-04-07 17:37:30 +00:00
smb1_process.c
s3:smbd: Fix invalid memory free
2024-07-08 07:36:32 +00:00
smb1_process.h
smbd: Remove unused "deferred_pcd" from process_smb1()
2023-06-05 17:17:35 +00:00
smb1_reply.c
smbd: Fix a comment and an error message
2024-08-06 16:29:33 +00:00
smb1_reply.h
s3: smbd: Move reply_findnclose() from trans2.c to smb1_reply.c
2022-04-07 17:37:30 +00:00
smb1_service.c
s3:smbd: Fix code spelling
2023-07-19 09:58:37 +00:00
smb1_service.h
smbd: Move make_connection to smb1_service.c
2022-04-07 17:37:29 +00:00
smb1_sesssetup.c
smbd: Give smbXsrv_session.c its own header file
2024-03-12 13:31:31 +00:00
smb1_sesssetup.h
smbd: Move sesssetup.c -> smb1_sesssetup.c
2022-04-07 17:37:29 +00:00
smb1_signing.c
CVE-2023-3347: smbd: pass lp_ctx to smb[1|2]_srv_init_signing()
2023-07-21 12:05:35 +00:00
smb1_signing.h
CVE-2023-3347: smbd: pass lp_ctx to smb[1|2]_srv_init_signing()
2023-07-21 12:05:35 +00:00
smb1_trans2.c
smbd: filename_convert_dirfsp always gives an fsp
2024-08-06 16:29:33 +00:00
smb1_trans2.h
smbd: Move handling smb_set_posix_lock() to smb1_trans2.c
2023-01-04 08:54:32 +00:00
smb1_utils.c
smbd: Move filename_convert_smb1_search_path() to smb1-only code
2023-11-01 18:55:32 +00:00
smb1_utils.h
smbd: Move filename_convert_smb1_search_path() to smb1-only code
2023-11-01 18:55:32 +00:00
smb2_aio.c
s3: smbd: Add some DEVELOPER-only code to panic if the destructor for an aio_lnk is called and the associated fsp doesn't exist.
2023-09-20 01:49:34 +00:00
smb2_break.c
s3: smbd: Correctly set smb2req->smb1req->posix_pathnames from the calling fsp on SMB2 calls.
2023-03-31 20:22:38 +00:00
smb2_close.c
smbd: don't leak the fsp if close_file_smb() fails
2023-07-10 21:32:32 +00:00
smb2_create.c
smbd: Add reparse tag to smb3_posix_cc_info
2024-05-14 23:29:46 +00:00
smb2_flush.c
smbd: use check_any_access_fsp() for all access checks
2024-01-08 15:53:36 +00:00
smb2_getinfo.c
smbd: use check_any_access_fsp() for all access checks
2024-01-08 15:53:36 +00:00
smb2_glue.c
s3: smbd: Correctly set smb2req->smb1req->posix_pathnames from the calling fsp on SMB2 calls.
2023-03-31 20:22:38 +00:00
smb2_ioctl_dfs.c
…
smb2_ioctl_filesys.c
smb2_ioctl: fix truncated FSCTL_QUERY_ALLOCATED_RANGES responses
2024-08-28 08:54:11 +00:00
smb2_ioctl_named_pipe.c
…
smb2_ioctl_network_fs.c
lib: Make GUID_to_ndr_buf() return void
2024-03-12 13:31:31 +00:00
smb2_ioctl_private.h
s3: smbd: Split out smb2_ioctl_smbtorture() into a separate file.
2021-08-11 19:16:29 +00:00
smb2_ioctl_smbtorture.c
s3: smbd: Call smbd_fsctl_torture_async_sleep() when we get FSCTL_SMBTORTURE_FSP_ASYNC_SLEEP.
2021-08-11 19:16:29 +00:00
smb2_ioctl.c
smb2_ioctl: fix truncated FSCTL_QUERY_ALLOCATED_RANGES responses
2024-08-28 08:54:11 +00:00
smb2_ipc.c
smbd: Move nt_status_np_pipe to smb2_ipc.c
2022-04-07 17:37:29 +00:00
smb2_keepalive.c
…
smb2_lock.c
s3:smbd: Fix code spelling
2023-07-19 09:58:37 +00:00
smb2_negprot.c
smbd: Save a few bytes of .text
2024-04-30 22:44:32 +00:00
smb2_notify.c
smbd: Simplify callers of notify_filter_string
2024-06-24 17:27:04 +00:00
smb2_nttrans.c
smbd: Modernize a few DEBUGs
2024-08-27 07:19:32 +00:00
smb2_oplock.c
smbd: Use struct oplock_break_message for MSG_SMB_KERNEL_BREAK
2024-04-30 22:44:32 +00:00
smb2_pipes.c
smbd: Use security_token_count_flag_sids() in open_np_file()
2023-05-16 10:53:40 +00:00
smb2_posix.c
smbd: add inode marshalling in smb3_file_posix_information_init()
2023-10-26 16:32:30 +00:00
smb2_process.c
smbd: Remove sconn->using_smb2
2024-04-17 07:57:36 +00:00
smb2_query_directory.c
smbd: Slightly simplify smbd_smb2_query_directory_send()
2023-12-19 16:05:36 +00:00
smb2_read.c
smbd: Remove a no-op call to init_strict_lock_struct
2024-05-22 04:23:29 +00:00
smb2_reply.c
s3:vfs: add vfs_rename_how to SMB_VFS_RENAMEAT()
2024-08-21 08:02:30 +00:00
smb2_server.c
s3:smb2_server: return NT_STATUS_NETWORK_SESSION_EXPIRED for compound requests
2024-08-13 22:29:28 +00:00
smb2_service.c
lib: Remove "token" parameter from set_namearray
2024-07-31 08:39:29 +00:00
smb2_sesssetup.c
s3:smbd: allow anonymous encryption after one authenticated session setup
2024-05-23 12:35:37 +00:00
smb2_setinfo.c
lib: Remove timeval_set()
2024-03-22 06:07:42 +00:00
smb2_signing.c
CVE-2023-3347: smbd: fix "server signing = mandatory"
2023-07-21 13:03:09 +00:00
smb2_tcon.c
s3:smbd: allow anonymous encryption after one authenticated session setup
2024-05-23 12:35:37 +00:00
smb2_trans2.c
smbd: add options "fs:[logical|aligned|performance|effective aligned] bytes per sector"
2024-08-20 07:01:19 +00:00
smb2_write.c
smbd: replace CHECK_WRITE() macro with calls to check_any_access_fsp()
2024-01-08 15:53:36 +00:00
smbd_cleanupd.c
s3:smbd: Fix code spelling
2023-07-19 09:58:37 +00:00
smbd_cleanupd.h
…
smbd.h
smbd: Hide the SMB1 posix symlink behaviour behind UCF_LCOMP_LNK_OK
2022-12-22 19:50:34 +00:00
smbXsrv_client.c
smbd: Fix a copy&paste error in smbXsrv_client_remove()
2024-04-30 22:44:32 +00:00
smbXsrv_open.c
smbd: Simplify smbXsrv_open_clear_replay_cache()
2024-04-30 22:44:32 +00:00
smbXsrv_open.h
smbd: Remove smbXsrv_open_global0->db_rec
2023-02-13 10:49:43 +00:00
smbXsrv_session.c
smbd: Simplify an if-condition
2024-04-30 22:44:32 +00:00
smbXsrv_session.h
smbd: Give smbXsrv_session.c its own header file
2024-03-12 13:31:31 +00:00
smbXsrv_tcon.c
s3:smbd: Fix code spelling
2023-10-25 22:23:37 +00:00
smbXsrv_version.c
smbXsrv_version: Use a struct assignment
2024-03-12 13:31:31 +00:00
srvstr.c
smbd: Fix whitespace
2024-06-04 07:11:35 +00:00
statvfs.c
smbd: Fix the build on FreeBSD
2022-08-04 20:44:32 +00:00
uid.c
smbd: Simplify check_user_ok()
2024-08-06 16:29:33 +00:00
utmp.c
…
vfs.c
s3:vfs: add vfs_rename_how to SMB_VFS_RENAMEAT()
2024-08-21 08:02:30 +00:00