1
0
mirror of https://github.com/samba-team/samba.git synced 2024-12-22 13:34:15 +03:00
https://gitlab.com/samba-team/samba is the Official GitLab mirror of https://git.samba.org/samba.git -- Merge requests should be made on GitLab (not on GitHub)
Go to file
Joseph Sutton 74a5a3b74e util/charset: Include final UTF‐16 code unit in length calculation loop
Change ‘<’ to ‘<=’ so that we check the final UTF‐16 code unit in our
search for the null terminator. This makes no difference to the result:
if we’ve reached the final code unit without finding a terminator, the
final code unit will be included in the length whether it is a null
terminator or not.

Why make this change? We’re about to factor out this loop into a new
function, utf16_len_n(), where including the final code unit *will*
matter.

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2023-11-15 22:07:36 +00:00
.github Added redirect from GitHub to GitLab 2018-12-05 16:35:33 +01:00
auth auth: Fix code spelling 2023-10-25 22:23:37 +00:00
bootstrap bootstrap: install codespell, shfmt and shellcheck also on debian/ubuntu 2023-10-11 11:47:44 +00:00
buildtools buildtools: Correctly raise exception 2023-10-17 03:19:38 +00:00
coverity
ctdb ctdb-scripts: Update detect_init_style to use /etc/os-release 2023-10-30 09:19:11 +00:00
dfs_server dfs_server: Fix debug statement if searched_site is NULL 2023-04-27 07:21:33 +00:00
docs-xml docs-xml: Fix a usage for case sensitive parameter 2023-11-15 18:52:16 +00:00
dynconfig dynconfig: Fix code spelling 2023-04-11 09:06:35 +00:00
examples examples: Fix code spelling 2023-10-25 22:23:37 +00:00
file_server s3: Remove --log-stdout from daemons 2021-04-29 03:58:37 +00:00
include
lib util/charset: Include final UTF‐16 code unit in length calculation loop 2023-11-15 22:07:36 +00:00
libcli util/charset: Rename utf16_len_n() to utf16_null_terminated_len_n() 2023-11-15 22:07:36 +00:00
libds/common libds: Add Managed Service Accounts well-known GUID 2023-05-05 02:54:31 +00:00
libgpo s3-lib: Modify merge_nt_token() into a GPO-specifc merge with SYSTEM 2023-09-26 23:45:36 +00:00
librpc util/charset: Rename utf16_len_n() to utf16_null_terminated_len_n() 2023-11-15 22:07:36 +00:00
nsswitch nsswitch: Fix script usage 2023-09-14 21:35:29 +00:00
packaging packaging:systemd: Fix code spelling 2023-06-23 13:44:31 +00:00
pidl librpc:ndr: Increase size of ‘libndr_flags’ type to 64 bits 2023-11-01 20:10:45 +00:00
python pytest:samba-tool domain auth policy: expect error message detail 2023-11-15 22:07:35 +00:00
release-scripts release-script: Fix shellcheck errors 2022-08-17 11:03:54 +00:00
script script: Fix code spelling 2023-10-25 22:23:38 +00:00
selftest libcli/security:sddl_decode_ace: fix ';' count message 2023-11-15 22:07:35 +00:00
source3 vfs_zfsacl: Call stat CAP_DAC_OVERRIDE functions 2023-11-15 19:55:07 +00:00
source4 util/charset: Rename utf16_len_n() to utf16_null_terminated_len_n() 2023-11-15 22:07:36 +00:00
testdata testdata: Fix spelling 2023-10-25 22:23:38 +00:00
testprogs CVE-2018-14628: python:descriptor: let samba-tool dbcheck fix the nTSecurityDescriptor on CN=Deleted Objects containers 2023-10-16 14:39:33 +00:00
tests tests: Fix code spelling 2023-08-14 21:45:30 +00:00
testsuite testsuite: Reformat shell scripts 2022-08-10 13:17:31 +00:00
third_party third_party/heimdal: krb5: Try to decode e-data as KERB-ERROR-DATA (falling back to METHOD-DATA) (Import lorikeet-heimdal-202311092338 (commit 50996e5f0b0f22a4eb755a6f22cb7b4ecab2aeea)) 2023-11-10 01:35:32 +00:00
wintest wintest: Fix invalid escape sequences 2023-10-13 04:55:06 +00:00
.bzrignore
.clang-format clang-format: sort alphabetically 2023-10-24 14:47:57 +00:00
.clangd Add .clangd configuration file 2023-03-29 16:57:34 +00:00
.codespellignore codespellignore: ignore some spellings introduced with wsp files 2023-10-25 22:23:38 +00:00
.codespellrc codespell: Ignore .git 2023-10-26 23:27:29 +00:00
.editorconfig editorconfig: We always inserted a new line so keep doing that 2022-02-28 10:22:34 +00:00
.git-blame-ignore-revs Add a git-blame-ignore-revs file 2023-03-03 02:02:51 +00:00
.gitattributes .gitattributes: Treat file containing test SDDL as binary 2023-10-25 22:23:37 +00:00
.gitignore gitignore: add WAF lockfile 2023-10-17 04:16:29 +00:00
.gitlab-ci-coverage-runners.yml add .gitlab-ci-coverage.yml for a scheduled build 2021-04-13 09:33:14 +00:00
.gitlab-ci-coverage.yml add .gitlab-ci-coverage.yml for a scheduled build 2021-04-13 09:33:14 +00:00
.gitlab-ci-default-runners.yml .gitlab-ci: make it explicit that some tests require ext4/5.15 kernel 2023-09-14 17:56:30 +00:00
.gitlab-ci-default.yml .gitlab-ci.yml: Honour AUTOBUILD_SKIP_SAMBA_O3 in GitLab CI 2021-10-13 11:10:44 +00:00
.gitlab-ci-main.yml gitlab-ci: run samba-codecheck on ubuntu22.04 2023-10-11 12:52:57 +00:00
.gitlab-ci-private.yml .gitlab-ci.yml: move the content to .gitlab-ci-main.yml 2021-04-13 08:23:35 +00:00
.gitlab-ci.yml .gitlab-ci.yml: move the content to .gitlab-ci-main.yml 2021-04-13 08:23:35 +00:00
.gitleaks.toml Add gitleaks configuration file to avoid false positives 2023-02-13 18:45:21 +00:00
.testr.conf
.ycm_extra_conf.py
callcatcher-exceptions.grep
configure configure/Makefile: export PYTHONHASHSEED=1 in all 'configure/Makefile' scripts 2022-03-29 22:32:32 +00:00
configure.developer
COPYING
GPG_AA99442FB680B620_replaces_6F33915B6568B7EA.txt ReleaseKey: add GnuPG key transition statement for the Samba release key 2021-01-21 13:57:45 +01:00
Makefile build: Add 'make printversion' to provide version string 2023-10-17 03:19:38 +00:00
PFIF.txt docs: protocolfreedom.org is no longer 2020-06-12 22:11:43 +00:00
README.cifs-utils
README.Coding.md Fix spelling in README.Coding.md 2023-04-04 07:31:36 +00:00
README.contributing Rename Samba's DCO to Samba Developer's Declaration 2020-10-20 22:54:01 +00:00
README.md Update README.md with more up to date information 2020-06-12 22:11:43 +00:00
SECURITY.md SECURITY.md: Fix spelling 2023-10-25 22:23:37 +00:00
setup.cfg pep8 tidy up config 2020-12-17 00:54:51 +00:00
VERSION VERSION: Bump version up to 4.20.0pre1... 2023-07-28 10:48:33 +00:00
VFS-License-clarification.txt VFS-License-clarification: minor improvements aligning w/ GPLv3 text 2020-11-04 21:29:40 +00:00
WHATSNEW.txt WHATSNEW: Mention logged on users list removal 2023-11-01 12:52:13 +00:00
wscript build: Add 'make printversion' to provide version string 2023-10-17 03:19:38 +00:00
wscript_build libcli/wsp: Add support for simplified Advanced Query Syntax 2023-10-25 22:23:38 +00:00
wscript_build_embedded_heimdal wafsamba: Remove clangdb code which doesn't work 2022-01-21 23:33:36 +00:00
wscript_build_system_heimdal wscript: Correctly determine dependencies for system Heimdal build 2022-11-08 02:39:37 +00:00
wscript_build_system_mitkrb5 wafsamba: Remove clangdb code which doesn't work 2022-01-21 23:33:36 +00:00
wscript_configure_embedded_heimdal HEIMDAL: move code from source4/heimdal* to third_party/heimdal* 2022-01-19 21:41:59 +00:00
wscript_configure_system_gnutls wscript: Remove unused imports 2023-08-30 02:15:29 +00:00
wscript_configure_system_heimdal wscript: Remove unused imports 2023-08-30 02:15:29 +00:00
wscript_configure_system_mitkrb5 wscript: Refer to correct ConfigSet variable 2023-08-30 03:15:05 +00:00

About Samba

Samba is the standard Windows interoperability suite of programs for Linux and Unix. Samba is Free Software licensed under the GNU General Public License and the Samba project is a member of the Software Freedom Conservancy. Since 1992, Samba has provided secure, stable and fast file and print services for all clients using the SMB/CIFS protocol, such as all versions of DOS and Windows, OS/2, Linux and many others. Samba is an important component to seamlessly integrate Linux/Unix Servers and Desktops into Active Directory environments. It can function both as a domain controller or as a regular domain member.

For the AD DC implementation a full HOWTO is provided at: https://wiki.samba.org/index.php/Samba4/HOWTO

Community guidelines can be read at: https://wiki.samba.org/index.php/How_to_do_Samba:_Nicely

This software is freely distributable under the GNU public license, a copy of which you should have received with this software (in a file called COPYING).

CONTRIBUTIONS

Please see https://wiki.samba.org/index.php/Contribute for detailed set-by-step instructions on how to submit a patch for Samba via GitLab.

Samba's GitLab mirror is at https://gitlab.com/samba-team/samba

OUR CONTRIBUTORS

See https://www.samba.org/samba/team/ for details of the Samba Team, as well as details of all those currently active in Samba development.

If you like a particular feature then look through the git change-log (on the web at https://gitweb.samba.org/?p=samba.git;a=summary) and see who added it, then send them an email.

Remember that free software of this kind lives or dies by the response we get. If no one tells us they like it then we'll probably move onto something else.

MORE INFO

DOCUMENTATION

There is quite a bit of documentation included with the package, including man pages and the wiki at https://wiki.samba.org

If you would like to help with our documentation, please contribute that improved content to the wiki, we are moving as much content there as possible.

MAILING LIST

Please do NOT send subscription/unsubscription requests to the lists!

There is a mailing list for discussion of Samba. For details go to https://lists.samba.org/ or send mail to samba-subscribe@lists.samba.org

There is also an announcement mailing list where new versions are announced. To subscribe go to https://lists.samba.org/ or send mail to samba-announce-subscribe@lists.samba.org. All announcements also go to the samba list, so you only need to be on one.

For details of other Samba mailing lists and for access to archives, see https://lists.samba.org/

MAILING LIST ETIQUETTE

A few tips when submitting to this or any mailing list.

  1. Make your subject short and descriptive. Avoid the words "help" or "Samba" in the subject. The readers of this list already know that a) you need help, and b) you are writing about samba (of course, you may need to distinguish between Samba PDC and other file sharing software). Avoid phrases such as "what is" and "how do i". Some good subject lines might look like "Slow response with Excel files" or "Migrating from Samba PDC to NT PDC".

  2. If you include the original message in your reply, trim it so that only the relevant lines, enough to establish context, are included. Chances are (since this is a mailing list) we've already read the original message.

  3. Trim irrelevant headers from the original message in your reply. All we need to see is a) From, b) Date, and c) Subject. We don't even really need the Subject, if you haven't changed it. Better yet is to just preface the original message with "On [date] [someone] wrote:".

  4. Please don't reply to or argue about spam, spam filters or viruses on any Samba lists. We do have a spam filtering system that is working quite well thank you very much but occasionally unwanted messages slip through. Deal with it.

  5. Never say "Me too." It doesn't help anyone solve the problem. Instead, if you ARE having the same problem, give more information. Have you seen something that the other writer hasn't mentioned, which may be helpful?

  6. If you ask about a problem, then come up with the solution on your own or through another source, by all means post it. Someone else may have the same problem and is waiting for an answer, but never hears of it.

  7. Give as much relevant information as possible such as Samba release number, OS, kernel version, etc...

  8. RTFM. Google.

WEBSITE

A Samba website has been setup with lots of useful info. Connect to:

https://www.samba.org/

As well as general information and documentation, this also has searchable archives of the mailing list and links to other useful resources such as the wiki.