sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-03-01 04:58:35 +03:00
Code
samba-mirror/source3/lib
History
Anoop C S ba53e284e6 s3: lib: dbwrap: Set rec->value_valid to avoid backtrace in smbstatus 
Following backtrace is observed on executing `smbstatus` with at least
one SMB client connection established:

PANIC: assert failed at ../../lib/dbwrap/dbwrap.c(82): rec->value_valid
PANIC (pid 350270): assert failed: rec->value_valid
BACKTRACE: 15 stack frames:
 #0 /usr/local/lib/libsamba-util.so.0(log_stack_trace+0x1f)
[0x7fbbd9b32047]
 #1 /usr/local/lib/libsmbconf.so.0(smb_panic_s3+0x74) [0x7fbbd9c1e6ff]
 #2 /usr/local/lib/libsamba-util.so.0(smb_panic+0x28) [0x7fbbd9b32012]
 #3 /usr/local/lib/samba/libdbwrap-
samba4.so(dbwrap_record_get_value+0x86) [0x7fbbd95800ac]
 #4 /usr/local/lib/samba/libsmbd-base-samba4.so(+0x28f563)
[0x7fbbd999e563]
 #5 /usr/local/lib/samba/libsamba-cluster-support-samba4.so(+0x7851)
[0x7fbbd92c7851]
 #6 /usr/local/lib/samba/libsamba-cluster-support-
samba4.so(ctdbd_traverse+0x4ca) [0x7fbbd92cc641]
 #7 /usr/local/lib/samba/libsamba-cluster-support-samba4.so(+0x73eb)
[0x7fbbd92c73eb]
 #8 /usr/local/lib/samba/libsamba-cluster-support-samba4.so(+0x7a52)
[0x7fbbd92c7a52]
 #9 /usr/local/lib/samba/libdbwrap-samba4.so(dbwrap_traverse_read+0x35)
[0x7fbbd9580de5]
 #10 /usr/local/lib/samba/libsmbd-base-
samba4.so(smbXsrv_tcon_global_traverse+0xc5) [0x7fbbd999e7d9]
 #11 smbstatus(connections_forall_read+0x114) [0x55d17872b8ee]
 #12 smbstatus(main+0x7b2) [0x55d17872a2f3]
 #13 /lib64/libc.so.6(__libc_start_main+0xf3) [0x7fbbd93a21a3]
 #14 smbstatus(_start+0x2e) [0x55d17872894e]
Can not dump core: corepath not set up

Assertion on rec->value_valid fails as it is uninitialized in the
following functions:

traverse_read_callback
traverse_persistent_callback_read

Signed-off-by: Anoop C S <anoopcs@redhat.com>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed Jan  8 23:24:58 UTC 2020 on sn-devel-184
2020-01-08 23:24:58 +00:00
..
ABI
smbldap: expose bind callback via API and increase smbldap ABI version
2017-07-04 11:14:49 +02:00
dbwrap
s3: lib: dbwrap: Set rec->value_valid to avoid backtrace in smbstatus
2020-01-08 23:24:58 +00:00
eventlog
lib: Use dom_sid_str_buf
2018-12-11 00:40:30 +01:00
netapi
smbdotconf: mark "server string" with substitution="1"
2019-11-27 10:25:36 +00:00
smbconf
s3/lib/smbconf: clang: 'Value stored during its initialization is never read'
2019-07-17 00:07:48 +00:00
addrchange.c
s3/lib: clang: 'Value stored to 'rta' is never read'
2019-07-16 22:52:25 +00:00
addrchange.h
…
adouble.c
lib/adouble: pass filesize to ad_unpack()
2019-10-30 14:52:33 +00:00
adouble.h
s3: lib: adouble: Add struct files_struct *dirfsp parameter to ad_convert().
2019-09-26 17:20:50 +00:00
adt_tree.c
…
audit.c
s3:lib: Use C99 initializer for audit_category_tab
2019-01-28 10:29:23 +01:00
avahi.c
…
background.c
s3: Move call to prctl_set_comment to reinit_after_fork
2015-09-24 08:00:16 +02:00
background.h
…
cbuf.c
lib: Remove an #include "includes.h"
2018-07-24 20:36:49 +02:00
cbuf.h
Fix spelling s/formated/formatted/
2018-05-12 02:09:26 +02:00
charcnv.c
s3:lib:charcnv: Remove use of global global_iconv_handle
2017-04-18 11:47:17 +02:00
cleanupdb.c
lib: Pass mem_ctx to lock_path()
2018-08-17 11:30:10 +02:00
cleanupdb.h
s3/lib: add smbd_cleanupd.tdb
2016-07-28 05:00:18 +02:00
cluster_support.c
lib: Move lp_ctdbd_socket() to cluster_support.c
2015-10-03 00:01:11 +02:00
cluster_support.h
lib: Move lp_ctdbd_socket() to cluster_support.c
2015-10-03 00:01:11 +02:00
cmdline_contexts.c
s3: Rename server_messaging_context() to global_messaging_context()
2018-09-07 17:26:17 +02:00
cmdline_contexts.h
s3:lib: Introduce cmdline context wrapper
2018-09-07 17:26:14 +02:00
ctdb_dummy.c
lib: Add "unique_id" to ctdbd_process_exists
2017-09-26 09:37:13 +02:00
ctdbd_conn.c
s3/lib/ctdbd_conn: assert hdr following read/recv
2019-09-04 14:20:16 +00:00
dmallocmsg.c
…
dumpcore.c
s3/dump_core: Have a newline towards the end of log message
2019-10-18 08:54:04 +00:00
errmap_unix.c
s3-lib: Fix error mapping for EROFS
2017-09-08 02:33:14 +02:00
file_id.c
lib: Remove unused file_id_string()
2019-11-12 22:18:39 +00:00
file_id.h
lib: Remove unused file_id_string()
2019-11-12 22:18:39 +00:00
filename_util.c
s3:lib: add is_named_stream()
2019-10-02 08:01:40 +00:00
fstring.c
…
g_lock.c
lib: Fix contending with a READ lock
2019-12-22 18:57:17 +00:00
gencache.c
s3:lib: Fix the debug message for adding cache entries.
2019-01-19 12:24:18 +01:00
gencache.h
gencache: Remove transaction-based tdb
2018-11-06 18:57:26 +01:00
global_contexts.c
s3:lib: Rename server_contexts to global_contexts
2018-09-07 17:26:17 +02:00
id_cache.c
lib/util: move memcache.[ch] to the toplevel 'samba-util' library
2014-07-18 15:43:33 +02:00
id_cache.h
s3-lib: remove some dead prototypes
2017-05-10 15:53:20 +02:00
idmap_cache.c
lib: Remove some unused code
2019-02-28 13:53:40 +00:00
idmap_cache.h
lib: Remove some unused code
2019-02-28 13:53:40 +00:00
interface.c
source3: Update all consumers of strtoul_err(), strtoull_err() to new API
2019-06-30 11:32:18 +00:00
ldap_debug_handler.c
…
ldap_escape.c
s3:lib: Use memcpy() in escape_ldap_string()
2018-05-17 17:30:09 +02:00
lsa.c
lib: Avoid an "includes.h"
2017-02-15 02:28:16 +01:00
messages_ctdb_ref.c
Revert "s3:messages: protect against usage of wrapper tevent_context objects for messaging"
2019-01-11 23:11:16 +01:00
messages_ctdb_ref.h
messaging: Add messages_ctdb_ref
2017-07-25 17:43:18 +02:00
messages_ctdb.c
Revert "s3:messages: protect against usage of wrapper tevent_context objects for messaging"
2019-01-11 23:11:16 +01:00
messages_ctdb.h
messages_ctdb: Add messaging_ctdb_connection
2017-07-25 17:43:18 +02:00
messages_dgm_ref.c
Revert "s3:messages: protect against usage of wrapper tevent_context objects for messaging"
2019-01-11 23:11:16 +01:00
messages_dgm_ref.h
messages_dgm_ref: Pass receiving "ev" to recv_cb
2016-10-05 00:06:22 +02:00
messages_dgm.c
s3:lib: Move NULL check before messaging_dgm_out_rearm_idle_timer()
2019-12-10 00:30:29 +00:00
messages_dgm.h
messaging: Add messaging_dgm_forall
2017-12-05 00:56:12 +01:00
messages_util.c
lib: Add lib/util/server_id.h
2017-01-22 18:30:11 +01:00
messages_util.h
messaging: Define a binary format for message headers
2015-02-13 23:32:07 +01:00
messages.c
s3/lib: clang: Fix 'Value stored during its initialization is never read'
2019-07-16 22:52:24 +00:00
ms_fnmatch.c
s3:lib: Fix size types in ms_fnmatch()
2018-03-21 20:43:19 +01:00
namearray.c
…
namemap_cache.c
source3: Update all consumers of strtoul_err(), strtoull_err() to new API
2019-06-30 11:32:18 +00:00
namemap_cache.h
namemap_cache: Absorb the expired calculation into namemap_cache.c
2018-10-16 18:00:10 +02:00
per_thread_cwd.c
s3:lib: add per_thread_cwd_{check,supported,disable,activate}() helper functions
2019-01-11 23:11:11 +01:00
popt_common_cmdline.c
s3: remove now unneeded call to cmdline_messaging_context()
2019-10-24 09:33:47 +00:00
popt_common.c
smbdotconf: mark "logfile" with substitution="1"
2019-11-27 10:25:35 +00:00
privileges.c
lib: Use dom_sid_str_buf
2018-12-20 23:40:25 +01:00
privileges.h
…
readdir_attr.h
s3:vfs: add SMB_VFS_READDIR_ATTR()
2014-12-04 22:11:07 +01:00
recvfile.c
lib: Move sys_rw* to lib/util
2015-10-13 01:23:07 +02:00
sendfile.c
s3: smbd: Fix AIX sendfile() for SMB2. Ensure we don't spin on EAGAIN.
2018-07-20 15:14:24 +02:00
server_id_db_util.c
lib: Add lib/util/server_id.h
2017-01-22 18:30:11 +01:00
server_id_db_util.h
lib: Add server_id_db_set_exclusive
2015-07-07 23:51:23 +02:00
server_id_watch.c
lib: Add server_id_watch_send
2016-07-15 16:56:13 +02:00
server_id_watch.h
lib: Add server_id_watch_send
2016-07-15 16:56:13 +02:00
server_mutex.c
lib: Pass mem_ctx to lock_path()
2018-08-17 11:30:10 +02:00
server_prefork_util.c
…
server_prefork_util.h
…
server_prefork.c
s3:prefork: Allow to associate private data with listening socket
2019-07-22 16:49:15 +00:00
server_prefork.h
s3:prefork: Allow to associate private data with listening socket
2019-07-22 16:49:15 +00:00
serverid.c
lib: Remove unused serverid.tdb
2017-12-05 04:58:26 +01:00
sessionid_tdb.c
smbstatus: show signing state of sessions and tcons
2016-01-22 07:52:21 +01:00
sharesec.c
sharesec: Return NTSTATUS from delete_share_security
2019-11-26 21:28:31 +00:00
smbd_shim.c
smbd: Remove unused brlock code
2019-06-20 17:18:19 +00:00
smbd_shim.h
smbd: Remove unused brlock code
2019-06-20 17:18:19 +00:00
smbldap.c
smbdotconf: mark "ldap suffix" with constant="1"
2019-11-27 10:25:36 +00:00
smbrun.c
Update smbrun to allow for settings environment variables.
2016-10-13 04:26:26 +02:00
srprs.c
s3: net: Harden srprs_str() against memcmp overread.
2019-05-15 21:26:12 +00:00
srprs.h
lib: Fix prototype of srprs_str
2018-07-24 20:36:50 +02:00
string_replace.c
s3: move fruit catia string replace mappings to s3/lib/
2019-07-12 21:31:29 +00:00
string_replace.h
s3: move fruit catia string replace mappings to s3/lib/
2019-07-12 21:31:29 +00:00
substitute_generic.c
s3:lib: Add FALL_THROUGH statements in substitute_generic.c
2018-03-01 04:37:41 +01:00
substitute.c
s3:lib: remove unused str_list_sub_basic()
2019-11-27 10:25:31 +00:00
sysacls.c
s3:lib: Add FALL_THROUGH statements in sysacls.c
2018-03-01 04:37:42 +01:00
sysquotas_4A.c
sys-quotas: do not fail if user has no quota
2016-03-31 20:30:10 +02:00
sysquotas_4B.c
sysquotas_4B: raise log level of a sometimes too noisy message
2019-02-17 13:33:14 +01:00
sysquotas_jfs2.c
add sysquotas_jfs2.c
2019-02-17 13:33:13 +01:00
sysquotas_linux.c
sysquotas_linux: fix inode limit setting, which is not depeding on blocksize
2019-02-17 13:33:12 +01:00
sysquotas_nfs.c
sysquotas_nfs: also honor reported inode/file limits
2019-02-17 13:33:13 +01:00
sysquotas_xfs.c
sysquotas_xfs: fix inode limit setting, which is not depeding on blocksize
2019-02-17 13:33:12 +01:00
sysquotas.c
smbdotconf: mark "set quota command" with substitution="1"
2019-11-27 10:25:36 +00:00
system_smbd.c
lib: Avoid a malloc/realloc in getgroups_unix_user
2015-03-11 16:11:08 +01:00
system.c
system: Rename argument for kernel_flock function
2020-01-08 00:01:35 +00:00
tallocmsg.c
lib: Fix CID 1453985: Null pointer dereferences (FORWARD_NULL)
2019-10-02 08:01:40 +00:00
tdb_validate.c
lib: Remove sys_waitpid
2016-02-23 22:03:16 +01:00
tdb_validate.h
lib: Remove tdb_compat
2015-03-17 11:30:52 +01:00
test_tldap.c
Fix uClibc build on 64bit platforms by including stdint.h
2019-05-19 17:34:20 +00:00
tevent_barrier.c
lib: Avoid a "includes.h"
2017-01-22 18:30:11 +01:00
tevent_barrier.h
…
tevent_glib_glue_tests.c
s3/lib: add a tevent_glib_glue subsystem test
2019-04-24 18:32:14 +00:00
tevent_glib_glue.c
s3/lib: new tevent_glib_glue subsystem
2019-04-24 18:32:14 +00:00
tevent_glib_glue.h
s3/lib: new tevent_glib_glue subsystem
2019-04-24 18:32:14 +00:00
tevent_wait.c
s3:tevent_wait: simplify the code by using tevent_req_defer_callback()
2015-05-19 16:37:52 +02:00
tevent_wait.h
…
time.c
s3:lib: use nt_time_to_full_timespec() in interpret_long_date()
2019-12-06 00:17:36 +00:00
tldap_gensec_bind.c
s3: tldap: Make tldap_gensec_bind_send()/tldap_gensec_bind_recv() static.
2016-06-28 11:19:33 +02:00
tldap_gensec_bind.h
s3: tldap: Make tldap_gensec_bind_send()/tldap_gensec_bind_recv() static.
2016-06-28 11:19:33 +02:00
tldap_util.c
tldap: Paged searches fail when they get to the end
2019-08-01 05:01:15 +00:00
tldap.c
tldap: avoid a use after free crash
2019-02-06 07:11:30 +01:00
username.c
lib/util: move memcache.[ch] to the toplevel 'samba-util' library
2014-07-18 15:43:33 +02:00
util_builtin.c
Change all uses of uint32/16/8 in proto.h to uint32_t/16_t/8_t.
2015-04-29 23:42:20 +02:00
util_cluster.c
lib: Make ctdbd_probe return 0/errno
2015-10-07 23:54:06 +02:00
util_cluster.h
…
util_cmdline.c
CVE-2017-12150: s3:lib: get_cmdline_auth_info_signing_state smb_encrypt SMB_SIGNING_REQUIRED
2017-09-20 13:04:10 +02:00
util_ea.c
dlist: remove unneeded type argument from DLIST_ADD_END()
2016-02-06 21:48:17 +01:00
util_ea.h
…
util_event.c
lib: #include "util_event.h" only where needed
2018-04-24 22:26:22 +02:00
util_file.c
s3: lib: Rename all uses of file_pload_XXX -> file_ploadv_XXX.
2019-05-24 19:00:06 +00:00
util_file.h
s3: lib: Rename all uses of file_pload_XXX -> file_ploadv_XXX.
2019-05-24 19:00:06 +00:00
util_macstreams.c
s3:lib: move Mac streams util functions to s3/lib
2019-07-12 21:31:29 +00:00
util_macstreams.h
s3:lib: move Mac streams util functions to s3/lib
2019-07-12 21:31:29 +00:00
util_malloc.c
…
util_names.c
s3:lib: add braces around if-block in my_sam_name()
2016-01-26 03:19:18 +01:00
util_nscd.c
…
util_nttoken.c
…
util_path.c
param: add FN_{GLOBAL,LOCAL}_SUBSTITUTED_STRING support
2019-11-27 10:25:32 +00:00
util_path.h
lib: Pass mem_ctx to cache_path()
2018-08-17 14:28:51 +02:00
util_procid.c
lib: Move some procid functions out of util.c
2015-11-09 07:53:18 +01:00
util_procid.h
lib: Move some procid functions out of util.c
2015-11-09 07:53:18 +01:00
util_sd.c
s3:lib: Add FALL_THROUGH statements in util_sd.c
2018-03-01 04:37:42 +01:00
util_sec.c
util_sec.c: Move __thread variable to global scope
2019-09-17 12:31:40 +00:00
util_sid_passdb.c
lib: Add lib/util_unixsids.h
2016-12-28 20:17:12 +01:00
util_sid_passdb.h
…
util_sid.c
lib: Remove sid_string_dbg
2018-12-20 23:40:26 +01:00
util_sock.c
lib: Explicitly refuse to truncate unix domain socket paths
2019-10-18 16:07:35 +00:00
util_specialsids.c
s3-util: add helper functions to deal with the S-1-18 domain.
2016-01-15 22:19:07 +01:00
util_str.c
s3:lib: remove unused str_list_substitute()
2019-11-27 10:25:31 +00:00
util_tdb.c
s3/lib: don't write to buffer (which might be NULL) if bufsize <=0
2019-05-29 10:10:23 +00:00
util_transfer_file.c
lib: Move sys_rw* to lib/util
2015-10-13 01:23:07 +02:00
util_tsock.c
lib: Introduce util_tsock.h
2016-01-10 22:24:17 +01:00
util_tsock.h
lib: Introduce util_tsock.h
2016-01-10 22:24:17 +01:00
util_unixsids.c
lib: Avoid an includes.h
2016-12-28 20:17:13 +01:00
util_unixsids.h
passdb: Move lookup_unix_[user|group]_name to lookup_sid.c
2016-12-28 20:17:12 +01:00
util_wellknown.c
lib: Use dom_sid_str_buf
2018-12-20 23:40:25 +01:00
util.c
lib: Remove unused smb_xvasprintf()
2019-12-02 21:23:35 +00:00
version_test.c
…
version.c
…
winbind_util.c
lib/winbind_util: Add winbind_xid_to_sid for --without-winbind
2019-03-06 01:53:16 +00:00
winbind_util.h
lib: Remove some unused code
2019-02-28 13:53:40 +00:00
wins_srv.c
s3:lib:wins fix a compile warning on Ubuntu 18.04
2019-10-23 04:57:08 +00:00
xattr_tdb.c
vfs: Use file_id_str_buf() in xattr_tdb_setattr()
2019-09-10 23:14:31 +00:00
xattr_tdb.h
…