1
0
mirror of https://github.com/samba-team/samba.git synced 2024-12-23 17:34:34 +03:00
https://gitlab.com/samba-team/samba is the Official GitLab mirror of https://git.samba.org/samba.git -- Merge requests should be made on GitLab (not on GitHub)
Go to file
Alexander Bokovoy 990a0fc4a0 ldb_ldap: fix off-by-one increment in lldb_add_msg_attr
Fix regression introduced by commit ce2bf5c72b

lldb_add_msg_attr() calls ldb_msg_add_empty() which, in turn, calls
calls _ldb_msg_add_el() which already increments msg->num_elements by one.

As a result, msg->num_elements is bigger than the actual number of
elements and any iteration over elements would step over elements array
boundary.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14413
Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>

Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Fri Jun 19 08:35:33 UTC 2020 on sn-devel-184
2020-06-19 08:35:33 +00:00
.github Added redirect from GitHub to GitLab 2018-12-05 16:35:33 +01:00
auth Fix clang 9 missing-field-initializer warnings 2020-05-08 09:31:31 +00:00
bootstrap gitlab-ci: Add ccache and wget 2020-04-01 05:46:30 +00:00
buildtools build: Put the note from the bottom of the old BUILD_SYSTEMS.txt somewhere useful 2020-06-12 22:11:43 +00:00
coverity coverity: Add modeling file for Coverity scan 2017-02-23 07:11:18 +01:00
ctdb ctdb-tests: Add a new fetch ring test that also checks hot keys 2020-05-22 08:05:54 +00:00
dfs_server dsdb: Allow the disable of the Windows server site fallback 2018-05-04 06:12:10 +02:00
docs-xml Fix a typo in recent net man page changes 2020-06-18 15:20:40 +00:00
dynconfig build: Remove workaround for missing os.path.relpath in Python < 2.6 2019-11-13 08:42:30 +00:00
examples docs: Point to wiki Contribute page rather than samba-technical 2020-06-12 22:11:43 +00:00
file_server source4 smdb: Add a post fork hook to the service API 2018-11-01 23:49:24 +01:00
include
lib ldb_ldap: fix off-by-one increment in lldb_add_msg_attr 2020-06-19 08:35:33 +00:00
libcli libcli: Add tevent_req_received() calls to smb2cli_create_recv() 2020-06-15 17:59:39 +00:00
libds/common libds: rename UF_MACHINE_ACCOUNT_MASK to UF_TRUST_ACCOUNT_MASK 2018-03-13 18:59:17 +01:00
libgpo s3: libsmb: In struct file_info rename mode -> attr. 2020-06-04 17:11:36 +00:00
librpc librpc: core: Move the s4 handles implementation to the RPC server core 2020-05-24 23:55:36 +00:00
nsswitch nsswitch: fix use-after-free causing segfault in _pam_delete_cred 2020-03-30 13:01:20 +00:00
packaging winbind.service: drop quotes from $WINBINDOPTIONS variable 2020-05-12 12:27:11 +00:00
pidl s3: rpc_server: Remove dead code 2020-05-24 23:55:37 +00:00
python s3:lib:tls: Use better priority lists for modern GnuTLS 2020-06-17 17:42:02 +00:00
release-scripts release-scripts/build-manpages-nogit: run make realdistclean at the end 2015-08-17 17:43:36 +02:00
script Add docs build to CI 2020-06-10 07:11:59 +00:00
selftest Properly handle msDS-AdditionalDnsHostName returned from Windows DC 2020-06-18 16:43:47 +00:00
source3 Properly handle msDS-AdditionalDnsHostName returned from Windows DC 2020-06-18 16:43:47 +00:00
source4 s3:lib:tls: Use better priority lists for modern GnuTLS 2020-06-17 17:42:02 +00:00
testdata regfio: Improve handling of malformed registry hive files 2019-03-20 05:26:18 +00:00
testprogs selftest: add tests for binary msDS-AdditionalDnsHostName 2020-06-18 15:20:40 +00:00
tests tests/sysquotas.c: include jfs/quota.h for 4B test on AIX 2019-02-17 13:33:13 +01:00
testsuite s3:rpc_server: Retrieve dcesrv_context from parent context to open NP 2020-03-20 15:36:35 +00:00
third_party third_party: Update nss_wrapper to version 1.1.11 2020-04-06 17:34:53 +00:00
wintest wintest: py3 telnet.sendline() doesn't like string with ^Z 2019-07-02 04:21:36 +00:00
.bzrignore
.gitattributes gitattributes: Ignore .SAMBABACKUP files 2018-08-16 23:42:22 +02:00
.gitignore gitignore: Add .build.log 2019-11-26 12:49:41 +00:00
.gitlab-ci-private.yml .gitlab-ci.yml: merge .gitlab-ci-private.yml 2019-02-18 10:54:19 +01:00
.gitlab-ci.yml Add docs build to CI 2020-06-10 07:11:59 +00:00
.testr.conf
.ycm_extra_conf.py PEP8: fix E302: expected 2 blank lines, found 1 2018-08-24 07:49:29 +02:00
callcatcher-exceptions.grep
configure build: Move python detection back into waf (instead of in configure and Makefile) 2018-12-14 14:40:19 +01:00
configure.developer
COPYING
Makefile Spelling fixes s/depencies/dependencies/ 2019-09-01 22:21:25 +00:00
PFIF.txt docs: protocolfreedom.org is no longer 2020-06-12 22:11:43 +00:00
README.cifs-utils
README.Coding.md doc: Add markup to README.Coding for samba wiki links 2020-06-12 23:32:30 +00:00
README.contributing Update README.contributing to point to new Contributing wiki page 2020-06-12 22:11:43 +00:00
README.md Update README.md with more up to date information 2020-06-12 22:11:43 +00:00
SECURITY.md Update SECURITY.md to point to security releases 2020-06-03 15:55:10 +00:00
setup.cfg PEP8: ignore rules and exclude files 2018-09-06 12:10:11 +02:00
VERSION VERSION: Bump version up to 4.13.0pre1... 2020-01-21 14:38:47 +00:00
WHATSNEW.txt Update WHATSNEW.txt to explain the vfs_widelinks module addition. 2020-04-09 21:21:46 +00:00
wscript build: Put the note from the bottom of the old BUILD_SYSTEMS.txt somewhere useful 2020-06-12 22:11:43 +00:00
wscript_build wscript_build: Remove duplicate recursion in source4/smbd 2020-05-06 00:06:40 +00:00
wscript_build_embedded_heimdal wscript_build_embedded_heimdal: update to handle waf 2.0.4 2018-09-05 06:37:25 +02:00
wscript_build_system_heimdal wscript: port build_system_heimdal to waf 2.0 2018-09-05 06:37:27 +02:00
wscript_build_system_mitkrb5 wscript: port build_system_mitkrb5 to waf 2.0 2018-09-05 06:37:27 +02:00
wscript_configure_embedded_heimdal wscript: separate embedded_heimdal from system_heimdal 2019-01-29 22:09:07 +01:00
wscript_configure_system_gnutls s3:lib:tls: Use better priority lists for modern GnuTLS 2020-06-17 17:42:02 +00:00
wscript_configure_system_heimdal wscript: Fix build with system heimdal 2019-11-13 17:49:38 +00:00
wscript_configure_system_mitkrb5 Fix uxsuccess test with new MIT krb5 library 1.18 2020-03-10 13:02:27 +00:00

About Samba

Samba is the standard Windows interoperability suite of programs for Linux and Unix. Samba is Free Software licensed under the GNU General Public License and the Samba project is a member of the Software Freedom Conservancy. Since 1992, Samba has provided secure, stable and fast file and print services for all clients using the SMB/CIFS protocol, such as all versions of DOS and Windows, OS/2, Linux and many others. Samba is an important component to seamlessly integrate Linux/Unix Servers and Desktops into Active Directory environments. It can function both as a domain controller or as a regular domain member.

For the AD DC implementation a full HOWTO is provided at: https://wiki.samba.org/index.php/Samba4/HOWTO

Community guidelines can be read at: https://wiki.samba.org/index.php/How_to_do_Samba:_Nicely

This software is freely distributable under the GNU public license, a copy of which you should have received with this software (in a file called COPYING).

CONTRIBUTIONS

Please see https://wiki.samba.org/index.php/Contribute for detailed set-by-step instructions on how to submit a patch for Samba via GitLab.

Samba's GitLab mirror is at https://gitlab.com/samba-team/samba

OUR CONTRIBUTORS

See https://www.samba.org/samba/team/ for details of the Samba Team, as well as details of all those currently active in Samba development.

If you like a particular feature then look through the git change-log (on the web at https://gitweb.samba.org/?p=samba.git;a=summary) and see who added it, then send them an email.

Remember that free software of this kind lives or dies by the response we get. If no one tells us they like it then we'll probably move onto something else.

MORE INFO

DOCUMENTATION

There is quite a bit of documentation included with the package, including man pages and the wiki at https://wiki.samba.org

If you would like to help with our documentation, please contribute that improved content to the wiki, we are moving as much content there as possible.

MAILING LIST

Please do NOT send subscription/unsubscription requests to the lists!

There is a mailing list for discussion of Samba. For details go to https://lists.samba.org/ or send mail to samba-subscribe@lists.samba.org

There is also an announcement mailing list where new versions are announced. To subscribe go to https://lists.samba.org/ or send mail to samba-announce-subscribe@lists.samba.org. All announcements also go to the samba list, so you only need to be on one.

For details of other Samba mailing lists and for access to archives, see https://lists.samba.org/

MAILING LIST ETIQUETTE

A few tips when submitting to this or any mailing list.

  1. Make your subject short and descriptive. Avoid the words "help" or "Samba" in the subject. The readers of this list already know that a) you need help, and b) you are writing about samba (of course, you may need to distinguish between Samba PDC and other file sharing software). Avoid phrases such as "what is" and "how do i". Some good subject lines might look like "Slow response with Excel files" or "Migrating from Samba PDC to NT PDC".

  2. If you include the original message in your reply, trim it so that only the relevant lines, enough to establish context, are included. Chances are (since this is a mailing list) we've already read the original message.

  3. Trim irrelevant headers from the original message in your reply. All we need to see is a) From, b) Date, and c) Subject. We don't even really need the Subject, if you haven't changed it. Better yet is to just preface the original message with "On [date] [someone] wrote:".

  4. Please don't reply to or argue about spam, spam filters or viruses on any Samba lists. We do have a spam filtering system that is working quite well thank you very much but occasionally unwanted messages slip through. Deal with it.

  5. Never say "Me too." It doesn't help anyone solve the problem. Instead, if you ARE having the same problem, give more information. Have you seen something that the other writer hasn't mentioned, which may be helpful?

  6. If you ask about a problem, then come up with the solution on your own or through another source, by all means post it. Someone else may have the same problem and is waiting for an answer, but never hears of it.

  7. Give as much relevant information as possible such as Samba release number, OS, kernel version, etc...

  8. RTFM. Google.

WEBSITE

A Samba website has been setup with lots of useful info. Connect to:

https://www.samba.org/

As well as general information and documentation, this also has searchable archives of the mailing list and links to other useful resources such as the wiki.