Alexander Bokovoy 990a0fc4a0 ldb_ldap: fix off-by-one increment in lldb_add_msg_attr ...

Fix regression introduced by commit ce2bf5c72b6423fff680b3d6a9042103a6cdda55

lldb_add_msg_attr() calls ldb_msg_add_empty() which, in turn, calls
calls _ldb_msg_add_el() which already increments msg->num_elements by one.

As a result, msg->num_elements is bigger than the actual number of
elements and any iteration over elements would step over elements array
boundary.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14413
Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>

Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Fri Jun 19 08:35:33 UTC 2020 on sn-devel-184

2020-06-19 08:35:33 +00:00

..

ABI

ldb: change the version to 2.2.0 for Samba 4.13

2020-02-26 23:11:39 +00:00

common

ldb/controls: avoid stealing our own stuff

2020-06-13 05:25:31 +00:00

docs

ldb: make ldb a top level library for Samba 4.0

2011-07-05 17:24:47 +10:00

examples

ldb: make ldb a top level library for Samba 4.0

2011-07-05 17:24:47 +10:00

include

ldb: also use portable __has_attribute macro to check for attribute support

2020-05-24 23:55:36 +00:00

ldb_key_value

ldb: Use ARRAY_DEL_ELEMENT() in ldb_kv_index_del_value()

2020-03-26 14:43:32 +00:00

ldb_ldap

ldb_ldap: fix off-by-one increment in lldb_add_msg_attr

2020-06-19 08:35:33 +00:00

ldb_ldb

ldb: Add MDB support to ldb://

2018-05-23 02:27:12 +02:00

ldb_map

ldb_map: check a return value (CID 241354)

2019-05-09 22:39:27 +00:00

ldb_mdb

Fix clang 9 parentheses-equality warnings

2020-05-08 09:31:31 +00:00

ldb_sqlite3

CVE-2018-1140 ldb: Check for ldb_dn_get_casefold() failure in ldb_sqlite

2018-08-14 13:57:15 +02:00

ldb_tdb

lib ldb key value backends: Add nested txn support

2019-06-21 04:27:12 +00:00

man

Spelling fixes s/overrided/overridden/

2019-04-02 01:12:11 +00:00

modules

ldb/mod/paged_searches: cope with NULL control data

2020-06-13 05:25:31 +00:00

nssldb

ldb: make ldb a top level library for Samba 4.0

2011-07-05 17:24:47 +10:00

tests

lib/ldb: add unit test for ldb_ldap internal code

2020-06-19 07:16:37 +00:00

tools

ldb: Avoid a cast (unsigned long long) in ldbmodify.c

2020-06-15 17:59:39 +00:00

web

ldb: make ldb a top level library for Samba 4.0

2011-07-05 17:24:47 +10:00

_ldb_text.py

ldb/tests/_ldb_text: remove unused imports

2018-10-25 21:45:55 +02:00

configure

build: Move python detection back into waf (instead of in configure and Makefile)

2018-12-14 14:40:19 +01:00

Doxyfile

ldb: make ldb a top level library for Samba 4.0

2011-07-05 17:24:47 +10:00

examples.dox

ldb: make ldb a top level library for Samba 4.0

2011-07-05 17:24:47 +10:00

ldb.pc.in

ldb: make ldb a top level library for Samba 4.0

2011-07-05 17:24:47 +10:00

mainpage.dox

ldb: make ldb a top level library for Samba 4.0

2011-07-05 17:24:47 +10:00

Makefile

Search for location of waf script

2019-02-26 10:39:24 +01:00

pyldb_util.c

pyldb: rename pyldb_Dn_AsDn() to pyldb_Dn_AS_DN()

2019-07-10 04:32:13 +00:00

pyldb-util.pc.in

lib/ldb: Enable use of a python3 pyldb-util system library

2017-03-10 07:31:10 +01:00

pyldb.c

Fix clang 9 missing-field-initializer warnings

2020-05-08 09:31:31 +00:00

pyldb.h

pyldb: rename pyldb_Dn_AsDn() to pyldb_Dn_AS_DN()

2019-07-10 04:32:13 +00:00

README_gcov.txt

ldb: make ldb a top level library for Samba 4.0

2011-07-05 17:24:47 +10:00

wscript

lib/ldb: add unit test for ldb_ldap internal code

2020-06-19 07:16:37 +00:00