sequoia-sq/sq-subplot.md
Justus Winter 6a4f32e493
Remove sq keyring join.
- This is the less useful and more dangerous variant of sq keyring
    merge.  The former does not merge two copies of the same
    certificate into one, and is likely not what the user wants or
    expects, and the resulting keyring is more likely to cause
    problems when consumed by implementations.

  - Further, we have to explain the difference between join and merge,
    hurting ergonomics.

  - Once, sq keyring join had the advantage of not buffering
    certificates, but we now do that in order to produce the right
    labels, so even that advantage was gone.

  - Remove it.  Developers who want to produce keyrings with multiple
    copies of the same cert for testing purposes can do so with sq
    packet join.

  - Adapt the subplot tests.  Notably, as sq keyring merge does not
    preserve the order of certs as encountered in the inputs (should
    it?), but orders them by fingerprint, the order in the output is
    not predictable.  To work around, just test listing one key.
2024-01-15 19:21:37 +01:00

57 KiB