IF YOU WOULD LIKE TO GET AN ACCOUNT, please write an
email to Administrator. User accounts are meant only to access repo
and report issues and/or generate pull requests.
This is a purpose-specific Git hosting for
BaseALT
projects. Thank you for your understanding!
Только зарегистрированные пользователи имеют доступ к сервису!
Для получения аккаунта, обратитесь к администратору.
The old tests' network bridge had a bogus <mac address="00:00:00:00:00:00">.
Older libvirt appeared to drop this completely. Newer libvirt appears
to rewrite it as a valid MAC, eg. <mac address="52:54:00:xx:xx:xx">
(for some randomly chosen "xx"'s). To make the tests stable, replace
the old bogus value with a valid value, and update the tests to check
for it.
Picking up these commits:
commit e711121607869363200aa80218719dcb25fcd98f
Author: Andrey Drobyshev <andrey.drobyshev@virtuozzo.com>
Date: Tue Oct 31 15:17:50 2023 +0200
mldrivers: look for bootloader config in /boot/grub/grub.cfg in case of UEFI
commit 9a8ba593511f94d59049bd920a6aee9210a2611f
Author: Richard W.M. Jones <rjones@redhat.com>
Date: Thu Oct 26 21:13:07 2023 +0100
mlcustomize: Update virt-customize generated files
commit e70d89a58dae068be2e19c7c21558707261af96a
Author: Richard W.M. Jones <rjones@redhat.com>
Date: Sat Jul 15 16:42:06 2023 +0100
customize: Update generated files for --chown with StringTriplet
commit bbb54714ce24c76e5761d96a0227a753896dc4c4
Author: Richard W.M. Jones <rjones@redhat.com>
Date: Thu Jun 29 13:34:12 2023 +0100
mlcustomize: Update generated files adding --chown option
Double quoting was removed in
commit e2af12ba69c4463bb73d30db63290a887cdd41eb ("input: -i vmx:
Remove support for openssh scp < 8.8", Nov 2021). However it should
only have been removed from scp commands, not for this ssh command
where it is still required.
See: https://github.com/libguestfs/virt-v2v/issues/35
Thanks: Laszlo Ersek for diagnosis and suggesting the fix
Reported-by: Bill Sanders
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
Almost every Linux guest expects the motherboard Real Time Clock (RTC)
to be set to UTC and they adjust the time displayed based on their
timezone (which may be different for each user).
Most Windows guests expect the RTC to be set to the local time.
Windows can be configured to use a UTC clock. We can detect this by
looking at the Windows registry.
To cope with this difference we need to add a guestcaps flag based on
what we think the guest is expecting. (We might also use the source
hypervisor RTC setting, but it is not thought to be as reliable as
inspecting the guest.)
This change simply adds the flag to guestcaps, and sets it to always
true, so there is no change to the output.
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
It has frequently tripped us up that on RHEL / Fedora, installing the
right set of libvirt RPMs (such as the one pulled in by
"libvirt-daemon-kvm") does not result in an immediately running libvirt
system instance. Document the need, and the simplest method, for starting
libvirt up manually.
Thanks: Daniel Berrangé
Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=2182024
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Message-Id: <20230629123443.188350-4-lersek@redhat.com>
Reviewed-by: Richard W.M. Jones <rjones@redhat.com>
Currently "chown_for_libvirt_rhbz_1045069" is best effort; if it fails, we
suppress the exception (we log it in verbose mode only, even).
That's not proved helpful: it almost certainly leads to later errors, but
those errors are less clear than the original (suppressed) exception.
Namely, the user sees something like
> Failed to connect to '/tmp/v2v.sKlulY/in0': Permission denied
rather than
> Failed to connect socket to '/var/run/libvirt/virtqemud-sock-ro':
> Connection refused
So just allow the exception to propagate outwards.
And then, now that "chown_for_libvirt_rhbz_1045069" will be able to fail,
hoist the call to "On_exit.rm_rf" before the call to
"chown_for_libvirt_rhbz_1045069", after creating the v2v temporary
directory. In the current order, if "chown_for_libvirt_rhbz_1045069" threw
an exception, then we'd leak the temp dir in the filesystem.
Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=2182024
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Message-Id: <20230629123443.188350-3-lersek@redhat.com>
[lersek@redhat.com: reinstate parens under "then" [Rich]]
Reviewed-by: Richard W.M. Jones <rjones@redhat.com>
Fix a small comment typo from commit 4e7f20684373 ("lib: Improve security
of in/out sockets when running virt-v2v as root", 2022-03-23).
Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=2182024
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Message-Id: <20230629123443.188350-2-lersek@redhat.com>
Reviewed-by: Richard W.M. Jones <rjones@redhat.com>
Update common submodule, picking up this fix:
commit 06721c00e2582daf1b3bedc4fbfb699b9b788a41
Author: Richard W.M. Jones <rjones@redhat.com>
Date: Thu Jun 29 13:10:24 2023 +0100
mltools: curl: Split out the url parameter
This requires a small change to input/vCenter.ml
glibc-2.37.9000-14.fc39.x86_64
gettext-0.21.1-2.fc38.x86_64
libvirt-daemon-9.0.0-3.fc38.x86_64
==704248== 24 bytes in 1 blocks are possibly lost in loss record 1,225 of 3,754
==704248== at 0x484182F: malloc (vg_replace_malloc.c:431)
==704248== by 0x54FE349: tsearch (tsearch.c:337)
==704248== by 0x5423C18: __dcigettext (dcigettext.c:797)
==704248== by 0x4A0D2C9: virDomainDefParse (domain_conf.c:19238)
==704248== by 0x4A251F1: virDomainDefCopy (domain_conf.c:28160)
==704248== by 0x49EB228: virDomainObjSetDefTransient (domain_conf.c:4160)
==704248== by 0x4B6D8B8: testDomainStartState.lto_priv.0 (test_driver.c:741)
==704248== by 0x4B6DFC4: testOpenParse (test_driver.c:1039)
==704248== by 0x4B6F143: testConnectOpen.lto_priv.0 (test_driver.c:1340)
==704248== by 0x4B88283: virConnectOpenInternal (libvirt.c:1128)
==704248== by 0x4B88A21: virConnectOpenAuth (libvirt.c:1271)
==704248== by 0x554ECE: _ocaml_libvirt_connect_open_auth_common (in /home/rjones/d/virt-v2v/v2v/virt-v2v)
==704248== by 0x557476: ocaml_libvirt_connect_open_auth (in /home/rjones/d/virt-v2v/v2v/virt-v2v)
==704248== by 0x5A0E46: caml_c_call (in /home/rjones/d/virt-v2v/v2v/virt-v2v)
==704248== by 0x6F5F6CF: ???
==704248== by 0x6F67507: ???
==704248==
==704248== 96 bytes in 1 blocks are possibly lost in loss record 2,500 of 3,754
==704248== at 0x484182F: malloc (vg_replace_malloc.c:431)
==704248== by 0x5423B4F: __dcigettext (dcigettext.c:764)
==704248== by 0x4A0D2C9: virDomainDefParse (domain_conf.c:19238)
==704248== by 0x4A251F1: virDomainDefCopy (domain_conf.c:28160)
==704248== by 0x49EB228: virDomainObjSetDefTransient (domain_conf.c:4160)
==704248== by 0x4B6D8B8: testDomainStartState.lto_priv.0 (test_driver.c:741)
==704248== by 0x4B6DFC4: testOpenParse (test_driver.c:1039)
==704248== by 0x4B6F143: testConnectOpen.lto_priv.0 (test_driver.c:1340)
==704248== by 0x4B88283: virConnectOpenInternal (libvirt.c:1128)
==704248== by 0x4B88A21: virConnectOpenAuth (libvirt.c:1271)
==704248== by 0x554ECE: _ocaml_libvirt_connect_open_auth_common (in /home/rjones/d/virt-v2v/v2v/virt-v2v)
==704248== by 0x557476: ocaml_libvirt_connect_open_auth (in /home/rjones/d/virt-v2v/v2v/virt-v2v)
==704248== by 0x5A0E46: caml_c_call (in /home/rjones/d/virt-v2v/v2v/virt-v2v)
==704248== by 0x6F5F6CF: ???
==704248== by 0x6F67507: ???
In the virt-v2v repo, commit 1e75569aa074 ("test-data/phony-guests: Allow
virt-v2v to work against phony Fedora") is an ancestor of commit
e4efe4b7d240 ("tests: add LUKS-on-LVM test"). The latter created a state
where "fedora-static-bin" and LUKS on LVM testing would coexist (i.e.,
where "fedora-static-bin" would be uploaded to the LUKS-on-LVM disk image
as well), but the commit didn't spell out the dependency in
"test-data/phony-guests/Makefile.am".
Do that now.
The problem can be triggered with:
> autoreconf -i
> ./configure
> make
> make -C test-data/phony-guests fedora-luks-on-lvm.img
where the last command fails with
> make: Entering directory '.../test-data/phony-guests'
> SRCDIR=. LAYOUT=luks-on-lvm ../../run --test ./make-fedora-img.pl
> open: fedora-static-bin: No such file or directory at
> .../test-data/phony-guests/make-fedora-img.pl line 373.
(In the guestfs-tools repo, the relative order (the descendancy) between
both commits is the opposite. There, commit 27da4b0c4991 ("inspector: add
LUKS-on-LVM test") came first, and commit eb0ff1859eb6
("test-data/phony-guests: Allow virt-v2v to work against phony Fedora"),
came second. The latter commit, in fact being a port of virt-v2v commit
1e75569aa074, brought together "fedora-static-bin" with "LUKS on LVM"
testing, and it correctly added "fedora-static-bin" as a pre-requisite
for building "fedora-luks-on-lvm.img".)
Fixes: e4efe4b7d240b66b1d53fbe5a127f4f5966f6903
Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=2168506
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Message-Id: <20230619162729.153334-1-lersek@redhat.com>
Reviewed-by: Richard W.M. Jones <rjones@redhat.com>
Since OCaml 4.07 (released 2018-07-10) the always-loaded standard
library module has been called Stdlib. The old Pervasives module was
finally removed in OCaml 5.
$ perl -pi.bak -e 's/Pervasives\./Stdlib./g' -- `git ls-files`
OCaml >= 4.07 is now required.
Also update the common submodule with:
commit d61cd820b49e403848d15c5deaccbf8dd7045370
Author: Jürgen Hötzel
Date: Sat May 20 18:16:40 2023 +0200
Add support for OCaml 5.0
In the LUKS-on-LVM conversion test, repeat the null conversion with such
"--key" options that exercise the recent "/dev/mapper/VG-LV" ->
"/dev/VG/LV" translation (unescaping) from libguestfs-common.
Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=2168506
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Message-Id: <20230515175529.290724-3-lersek@redhat.com>
Reviewed-by: Richard W.M. Jones <rjones@redhat.com>
In preparation for a subsequent patch, rename "VG" to "Volume-Group", and
"LV<n>" to "Logical-Volume-<n>", in the LUKS-on-LVM conversion test.
Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=2168506
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Message-Id: <20230515175529.290724-2-lersek@redhat.com>
Reviewed-by: Richard W.M. Jones <rjones@redhat.com>
eBlocker (https://eblocker.org) provides an OVA which contains this
manifest (*.mf) file:
SHA256 (eBlockerVM-2.9.1-amd64.ovf) = 7b25ea03c3b9eb143c7f6d1e8f76c3717e5b928f007e571cd96132bf6a15a30d
SHA256 (eBlocker VM-disk001.vmdk) = 646d1ec6ddf5a6d6604dbec421624ca2cea6ee5b57bf80ae635bf8f4f0bfea45
Note that the manifest is not conforming with the OVFS specification
which says the line format should be:
file_digest = algorithm "(" file_name ")" "=" sp digest nl
Space (sp) is not permitted after the algorithm or before the = sign.
However let's be tolerant of the extra whitespace.
Right now wait-pnp is the only firstboot script which does its logging
into a separate log file. Let's align its behaviour with that of the the
other scripts so that logs go to the common log file, i.e.
"C:\Program Files\Guestfs\Firstboot\log.txt".
Signed-off-by: Andrey Drobyshev <andrey.drobyshev@virtuozzo.com>
Message-Id: <20230316173438.100162-3-andrey.drobyshev@virtuozzo.com>
Acked-by: Laszlo Ersek <lersek@redhat.com>
During conversion we copy the necessary drivers to the directory
"%systemroot%\Drivers\Virtio", adding it to the DevicePath registry
value. As documented in [1], this should be enough for Windows to find
device drivers and successfully install them.
However, it doesn't always happen. Commit 73e009c04 ("v2v: windows:
Document use of pnputil to install drivers.") describes such issues with
Win2k12R2. I'm seeing the same problem with Win2k16 and netkvm.sys
driver not being installed.
That same commit 73e009c04 suggests adding a firstboot script invoking
pnputil at an early stage to install all the drivers we put into the
drivers store. So let's add such a script to make sure all the
necessary drivers are installed.
[1] https://learn.microsoft.com/en-us/windows-hardware/drivers/install/how-windows-selects-a-driver-for-a-device
Signed-off-by: Andrey Drobyshev <andrey.drobyshev@virtuozzo.com>
Acked-by: Laszlo Ersek <lersek@redhat.com>
Message-Id: <20230316173438.100162-2-andrey.drobyshev@virtuozzo.com>
