network: avoid trying to create global firewall rules if unprivileged

The unprivileged libvirtd does not have permission to create firewall
rules, or bridge devices, or do anything to the host network in
general. Historically we still activate the network driver though and
let the network start API call fail.

The startup code path which reloads firewall rules on active networks
would thus effectively be a no-op when unprivileged as it is impossible
for there to be any active networks

With the change to use a global set of firewall chains, however, we now
have code that is run unconditionally.

Ideally we would not register the network driver at all when
unprivileged, but the entanglement with the virt drivers currently makes
that impractical. As a temporary hack, we just make the firewall reload
into a no-op.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
(cherry picked from commit 5d010c3df6)

.gitignore

@@ -190,7 +190,6 @@
 /tools/virt-admin
 /tools/virt-*-validate
 /tools/virt-sanlock-cleanup
-/tools/wireshark/src/plugin.c
 /tools/wireshark/src/libvirt
 /update.log
 GPATH

.travis.yml

@@ -46,7 +46,7 @@ script:
       -e VIR_TEST_DEBUG="$VIR_TEST_DEBUG"
       -e MINGW="$MINGW"
       -e DISTCHECK_CONFIGURE_FLAGS="$DISTCHECK_CONFIGURE_FLAGS"
-      "libvirt/buildenv-$IMAGE"
+      "quay.io/libvirt/buildenv-$IMAGE:master"
       /bin/sh -xc "$DOCKER_CMD"
 
 git:

bootstrap

@@ -1,10 +1,10 @@
 #! /bin/sh
 # Print a version string.
-scriptversion=2018-07-01.02; # UTC
+scriptversion=2019-01-04.17; # UTC
 
 # Bootstrap this package from checked-out sources.
 
-# Copyright (C) 2003-2018 Free Software Foundation, Inc.
+# Copyright (C) 2003-2019 Free Software Foundation, Inc.
 
 # This program is free software: you can redistribute it and/or modify
 # it under the terms of the GNU General Public License as published by
@@ -142,6 +142,9 @@ die() { warn_ "$@"; exit 1; }
 
 # Configuration.
 
+# Name of the Makefile.am
+gnulib_mk=gnulib.mk
+
 # List of gnulib modules needed.
 gnulib_modules=
 
@@ -159,18 +162,11 @@ bootstrap_post_import_hook() { :; }
 # Override it via your own definition in bootstrap.conf.
 bootstrap_epilogue() { :; }
 
-# The command to download all .po files for a specified domain into
-# a specified directory.  Fill in the first %s is the domain name, and
-# the second with the destination directory.  Use rsync's -L and -r
-# options because the latest/%s directory and the .po files within are
-# all symlinks.
+# The command to download all .po files for a specified domain into a
+# specified directory.  Fill in the first %s with the destination
+# directory and the second with the domain name.
 po_download_command_format=\
-"rsync --delete --exclude '*.s1' -Lrtvz \
- 'translationproject.org::tp/latest/%s/' '%s'"
-
-# Fallback for downloading .po files (if rsync fails).
-po_download_command_format2=\
-"wget --mirror -nd -q -np -A.po -P '%s' \
+"wget --mirror --level=1 -nd -q -A.po -P '%s' \
  https://translationproject.org/latest/%s/"
 
 # Prefer a non-empty tarname (4th argument of AC_INIT if given), else
@@ -738,10 +734,7 @@ download_po_files() {
   subdir=$1
   domain=$2
   echo "$me: getting translations into $subdir for $domain..."
-  cmd=$(printf "$po_download_command_format" "$domain" "$subdir")
-  eval "$cmd" && return
-  # Fallback to HTTPS.
-  cmd=$(printf "$po_download_command_format2" "$subdir" "$domain")
+  cmd=$(printf "$po_download_command_format" "$subdir" "$domain")
   eval "$cmd"
 }
 
@@ -970,6 +963,16 @@ fi
 bootstrap_post_import_hook \
   || die "bootstrap_post_import_hook failed"
 
+# Don't proceed if there are uninitialized submodules.  In particular,
+# the next step will remove dangling links, which might be links into
+# uninitialized submodules.
+#
+# Uninitialized submodules are listed with an initial dash.
+if $use_git && git submodule | grep '^-' >/dev/null; then
+  die "some git submodules are not initialized. "     \
+      "Run 'git submodule init' and bootstrap again."
+fi
+
 # Remove any dangling symlink matching "*.m4" or "*.[ch]" in some
 # gnulib-populated directories.  Such .m4 files would cause aclocal to fail.
 # The following requires GNU find 4.2.3 or newer.  Considering the usual

bootstrap.conf

@@ -10,7 +10,7 @@
 # This program is distributed in the hope that it will be useful,
 # but WITHOUT ANY WARRANTY; without even the implied warranty of
 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-# GNU General Public License for more details.
+# GNU Lesser General Public License for more details.
 
 # You should have received a copy of the GNU Lesser General Public
 # License along with this library.  If not, see

build-aux/augeas-gentest.pl

@@ -16,9 +16,6 @@
 # You should have received a copy of the GNU Lesser General Public
 # License along with this library.  If not, see
 # <http://www.gnu.org/licenses/>.
-#
-# Authors:
-#     Daniel P. Berrange <berrange@redhat.com>
 
 use strict;
 use warnings;

build-aux/check-spacing.pl

@@ -16,363 +16,181 @@
 # You should have received a copy of the GNU Lesser General Public
 # License along with this library.  If not, see
 # <http://www.gnu.org/licenses/>.
-#
-# Authors:
-#     Daniel P. Berrange <berrange@redhat.com>
 
 use strict;
 use warnings;
 
-#
-# CheckFunctionBody:
-# $_[0]: $data(in)
-# $_[1]: $location(in), which format is file-path:line-num:line-code
-# $_[2]: $fn_linenum(inout), maintains start line-num of function body
-# Returns 0 in case of success or 1 on failure
-#
-# Check incorrect indentation and blank first line in function body.
-# For efficiency, it only checks the first line of function body.
-# But it's enough for most cases.
-# (It could be better that we use *state* to declare @fn_linenum and
-#  move it into this subroutine. But *state* requires version >= v5.10.)
-#
-sub CheckFunctionBody {
-    my $ret = 0;
-    my ($data, $location, $fn_linenum) = @_;
-
-    # Check first line of function block
-    if ($$fn_linenum) {
-        if ($$data =~ /^\s*$/) {
-            print "Blank line before content in function body:\n$$location";
-            $ret = 1;
-        } elsif ($$data !~ /^[ ]{4}\S/) {
-            unless ($$data =~ /^[ ]\w+:$/ || $$data =~ /^}/) {
-                print "Incorrect indentation in function body:\n$$location";
-                $ret = 1;
-            }
-        }
-        $$fn_linenum = 0;
-    }
-
-    # Detect start of function block
-    if ($$data =~ /^{$/) {
-        $$fn_linenum = $.;
-    }
-
-    return $ret;
-}
-
-#
-# KillComments:
-# $_[0]: $data(inout)
-# $_[1]: $incomment(inout)
-#
-# Remove all content of comments
-# (Also, the @incomment could be declared with *state* and move it in.)
-#
-sub KillComments {
-    my ($data, $incomment) = @_;
-
-    # Kill contents of multi-line comments
-    # and detect end of multi-line comments
-    if ($$incomment) {
-        if ($$data =~ m,\*/,) {
-            $$incomment = 0;
-            $$data =~ s,^.*\*/,*/,;
-        } else {
-            $$data = "";
-        }
-    }
-
-    # Kill single line comments, and detect
-    # start of multi-line comments
-    if ($$data =~ m,/\*.*\*/,) {
-        $$data =~ s,/\*.*\*/,/* */,;
-    } elsif ($$data =~ m,/\*,) {
-        $$incomment = 1;
-        $$data =~ s,/\*.*,/*,;
-    }
-
-    return;
-}
-
-#
-# CheckWhiteSpaces:
-# $_[0]: $data(in)
-# $_[1]: $location(in), which format is file-path:line-num:line-code
-# Returns 0 in case of success or 1 on failure
-#
-# Check whitespaces according to code spec of libvirt.
-#
-sub CheckWhiteSpaces {
-    my $ret = 0;
-    my ($data, $location) = @_;
-
-    # We need to match things like
-    #
-    #  int foo (int bar, bool wizz);
-    #  foo (bar, wizz);
-    #
-    # but not match things like:
-    #
-    #  typedef int (*foo)(bar wizz)
-    #
-    # we can't do this (efficiently) without
-    # missing things like
-    #
-    #  foo (*bar, wizz);
-    #
-    # We also don't want to spoil the $data so it can be used
-    # later on.
-
-    # For temporary modifications
-    my $tmpdata = $$data;
-    while ($tmpdata =~ /(\w+)\s\((?!\*)/) {
-        my $kw = $1;
-
-        # Allow space after keywords only
-        if ($kw =~ /^(?:if|for|while|switch|return)$/) {
-            $tmpdata =~ s/(?:$kw\s\()/XXX(/;
-        } else {
-            print "Whitespace after non-keyword:\n$$location";
-            $ret = 1;
-            last;
-        }
-    }
-
-    # Require whitespace immediately after keywords
-    if ($$data =~ /\b(?:if|for|while|switch|return)\(/) {
-        print "No whitespace after keyword:\n$$location";
-        $ret = 1;
-    }
-
-    # Forbid whitespace between )( of a function typedef
-    if ($$data =~ /\(\*\w+\)\s+\(/) {
-        print "Whitespace between ')' and '(':\n$$location";
-        $ret = 1;
-    }
-
-    # Forbid whitespace following ( or prior to )
-    # but allow whitespace before ) on a single line
-    # (optionally followed by a semicolon)
-    if (($$data =~ /\s\)/ && not $$data =~ /^\s+\);?$/) ||
-        $$data =~ /\((?!$)\s/) {
-        print "Whitespace after '(' or before ')':\n$$location";
-        $ret = 1;
-    }
-
-    # Forbid whitespace before ";" or ",". Things like below are allowed:
-    #
-    # 1) The expression is empty for "for" loop. E.g.
-    #   for (i = 0; ; i++)
-    #
-    # 2) An empty statement. E.g.
-    #   while (write(statuswrite, &status, 1) == -1 &&
-    #          errno == EINTR)
-    #       ;
-    #
-    if ($$data =~ /\s[;,]/) {
-        unless ($$data =~ /\S; ; / ||
-                $$data =~ /^\s+;/) {
-            print "Whitespace before semicolon or comma:\n$$location";
-            $ret = 1;
-        }
-    }
-
-    # Require EOL, macro line continuation, or whitespace after ";".
-    # Allow "for (;;)" as an exception.
-    if ($$data =~ /;[^	 \\\n;)]/) {
-        print "Invalid character after semicolon:\n$$location";
-        $ret = 1;
-    }
-
-    # Require EOL, space, or enum/struct end after comma.
-    if ($$data =~ /,[^ \\\n)}]/) {
-        print "Invalid character after comma:\n$$location";
-        $ret = 1;
-    }
-
-    # Require spaces around assignment '=', compounds and '=='
-    if ($$data =~ /[^ ]\b[!<>&|\-+*\/%\^=]?=/ ||
-        $$data =~ /=[^= \\\n]/) {
-        print "Spacing around '=' or '==':\n$$location";
-        $ret = 1;
-    }
-
-    return $ret;
-}
-
-#
-# CheckCurlyBrackets:
-# $_[0]: $data(in)
-# $_[1]: $file(in)
-# $_[2]: $line(in)
-# $_[3]: $cb_linenum(inout)
-# $_[4]: $cb_code(inout)
-# $_[5]: $cb_scolon(inout)
-# Returns 0 in case of success or 1 on failure
-#
-# Check whitespaces according to code spec of libvirt.
-#
-sub CheckCurlyBrackets {
-    my $ret = 0;
-    my ($data, $file, $line, $cb_linenum, $cb_code, $cb_scolon) = @_;
-
-    # One line conditional statements with one line bodies should
-    # not use curly brackets.
-    if ($$data =~ /^\s*(if|while|for)\b.*\{$/) {
-        $$cb_linenum = $.;
-        $$cb_code = $$line;
-        $$cb_scolon = 0;
-    }
-
-    # We need to check for exactly one semicolon inside the body,
-    # because empty statements (e.g. with comment only) are
-    # allowed
-    if ($$cb_linenum == $. - 1 && $$data =~ /^[^;]*;[^;]*$/) {
-        $$cb_code .= $$line;
-        $$cb_scolon = 1;
-    }
-
-    if ($$data =~ /^\s*}\s*$/ &&
-        $$cb_linenum == $. - 2 &&
-        $$cb_scolon) {
-
-        print "Curly brackets around single-line body:\n";
-        print "$$file:$$cb_linenum-$.:\n$$cb_code$$line";
-        $ret = 1;
-
-        # There _should_ be no need to reset the values; but to
-        # keep my inner peace...
-        $$cb_linenum = 0;
-        $$cb_scolon = 0;
-        $$cb_code = "";
-    }
-
-    return $ret;
-}
-
-#
-# CheckMisalignment:
-# $_[0]: $data(in)
-# $_[1]: $file(in)
-# $_[2]: $line(in)
-# $_[3]: @paren_stack(inout), which maintains information
-#         of the parenthesis
-# Returns 0 in case of success or 1 on failure
-#
-# Check misaligned stuff in parenthesis:
-# 1. For misaligned arguments of function
-# 2. For misaligned conditions of [if|while|switch|...]
-#
-sub CheckMisalignment {
-    my $ret = 0;
-    my ($data, $file, $line, $paren_stack) = @_;
-
-    # Check alignment based on @paren_stack
-    if (@$paren_stack) {
-        if ($$data =~ /(\S+.*$)/) {
-            my $pos = $$paren_stack[-1][0];
-            my $linenum = $$paren_stack[-1][1];
-            my $code = $$paren_stack[-1][2];
-            if ($pos + 1 != length($`)) {
-                my $pad = "";
-                if ($. > $linenum + 1) {
-                    $pad = " " x $pos . " ...\n";
-                }
-                print "Misaligned line in parenthesis:\n";
-                print "$$file:$linenum-$.:\n$code$pad$$line\n";
-                $ret = 1;
-            }
-        }
-    }
-
-    # Maintain @paren_stack
-    if ($$data =~ /.*[()]/) {
-        my $pos = 0;
-        my $temp = $$data;
-
-        # Kill the content between matched parenthesis and themselves
-        # within the current line.
-        $temp =~ s,(\((?:[^()]++|(?R))*+\)),"X" x (length $&),ge;
-
-        # Pop a item for the open-paren when finding close-paren
-        while (($pos = index($temp, "\)", $pos)) >= 0) {
-            if (@$paren_stack) {
-                pop(@$paren_stack);
-                $pos++;
-            } else {
-                print "Warning: found unbalanced parenthesis:\n";
-                print "$$file:$.:\n$$line\n";
-                $ret = 1;
-                last;
-            }
-        }
-
-        # Push the item for open-paren on @paren_stack
-        # @item = [ position of the open-paren, linenum, code-line ]
-        while (($pos = index($temp, "\(", $pos)) >= 0) {
-            push @$paren_stack, [$pos, $., $$line];
-            $pos++;
-        }
-    }
-
-    return $ret;
-}
-
 my $ret = 0;
+my $incomment = 0;
 
 foreach my $file (@ARGV) {
     # Per-file variables for multiline Curly Bracket (cb_) check
     my $cb_linenum = 0;
     my $cb_code = "";
     my $cb_scolon = 0;
-    my $fn_linenum = 0;
-    my $incomment = 0;
-    my @paren_stack;
 
     open FILE, $file;
 
     while (defined (my $line = <FILE>)) {
-        my $has_define = 0;
         my $data = $line;
-        my $location = "$file:$.:\n$line";
+        # For temporary modifications
+        my $tmpdata;
 
         # Kill any quoted , ; = or "
         $data =~ s/'[";,=]'/'X'/g;
 
-        # Kill any quoted strings. Replace with equal-length "XXXX..."
-        $data =~ s,"(([^\\\"]|\\.)*)","\"".'X'x(length $1)."\"",ge;
-        $data =~ s,'(([^\\\']|\\.)*)',"\'".'X'x(length $1)."\'",ge;
+        # Kill any quoted strings
+        $data =~ s,"(?:[^\\\"]|\\.)*","XXX",g;
 
-        # Kill any C++ style comments
-        $data =~ s,//.*$,//,;
+        next if $data =~ /^#/;
 
-        $has_define = 1 if $data =~ /(?:^#\s*define\b)/;
-        if (not $has_define) {
-            # Ignore all macros except for #define
-            next if $data =~ /^#/;
-
-            $ret = 1 if CheckFunctionBody(\$data, \$location, \$fn_linenum);
-
-            KillComments(\$data, \$incomment);
-
-            $ret = 1 if CheckWhiteSpaces(\$data, \$location);
-
-            $ret = 1 if CheckCurlyBrackets(\$data, \$file, \$line,
-                                           \$cb_linenum, \$cb_code, \$cb_scolon);
+        # Kill contents of multi-line comments
+        # and detect end of multi-line comments
+        if ($incomment) {
+            if ($data =~ m,\*/,) {
+                $incomment = 0;
+                $data =~ s,^.*\*/,*/,;
+            } else {
+                $data = "";
+            }
         }
 
-        #####################################################################
-        # Temporary Filter for CheckMisalignment:
-        # Here we introduce a white-list of path, since there're
-        # too much misalignment.
-        # We _need_ fix these misalignment in batches.
-        # We _should_ remove it as soon as fixing all.
-        #####################################################################
-        next unless $file =~ /^src\/util\//;
+        # Kill single line comments, and detect
+        # start of multi-line comments
+        if ($data =~ m,/\*.*\*/,) {
+            $data =~ s,/\*.*\*/,/* */,;
+        } elsif ($data =~ m,/\*,) {
+            $incomment = 1;
+            $data =~ s,/\*.*,/*,;
+        }
 
-        $ret = 1 if CheckMisalignment(\$data, \$file, \$line, \@paren_stack);
+        # We need to match things like
+        #
+        #  int foo (int bar, bool wizz);
+        #  foo (bar, wizz);
+        #
+        # but not match things like:
+        #
+        #  typedef int (*foo)(bar wizz)
+        #
+        # we can't do this (efficiently) without
+        # missing things like
+        #
+        #  foo (*bar, wizz);
+        #
+        # We also don't want to spoil the $data so it can be used
+        # later on.
+        $tmpdata = $data;
+        while ($tmpdata =~ /(\w+)\s\((?!\*)/) {
+            my $kw = $1;
+
+            # Allow space after keywords only
+            if ($kw =~ /^(?:if|for|while|switch|return)$/) {
+                $tmpdata =~ s/(?:$kw\s\()/XXX(/;
+            } else {
+                print "Whitespace after non-keyword:\n";
+                print "$file:$.: $line";
+                $ret = 1;
+                last;
+            }
+        }
+
+        # Require whitespace immediately after keywords
+        if ($data =~ /\b(?:if|for|while|switch|return)\(/) {
+            print "No whitespace after keyword:\n";
+            print "$file:$.: $line";
+            $ret = 1;
+        }
+
+        # Forbid whitespace between )( of a function typedef
+        if ($data =~ /\(\*\w+\)\s+\(/) {
+            print "Whitespace between ')' and '(':\n";
+            print "$file:$.: $line";
+            $ret = 1;
+        }
+
+        # Forbid whitespace following ( or prior to )
+        # but allow whitespace before ) on a single line
+        # (optionally followed by a semicolon)
+        if (($data =~ /\s\)/ && not $data =~ /^\s+\);?$/) ||
+            $data =~ /\((?!$)\s/) {
+            print "Whitespace after '(' or before ')':\n";
+            print "$file:$.: $line";
+            $ret = 1;
+        }
+
+        # Forbid whitespace before ";" or ",". Things like below are allowed:
+        #
+        # 1) The expression is empty for "for" loop. E.g.
+        #   for (i = 0; ; i++)
+        #
+        # 2) An empty statement. E.g.
+        #   while (write(statuswrite, &status, 1) == -1 &&
+        #          errno == EINTR)
+        #       ;
+        #
+        if ($data =~ /\s[;,]/) {
+            unless ($data =~ /\S; ; / ||
+                    $data =~ /^\s+;/) {
+                print "Whitespace before semicolon or comma:\n";
+                print "$file:$.: $line";
+                $ret = 1;
+            }
+        }
+
+        # Require EOL, macro line continuation, or whitespace after ";".
+        # Allow "for (;;)" as an exception.
+        if ($data =~ /;[^	 \\\n;)]/) {
+            print "Invalid character after semicolon:\n";
+            print "$file:$.: $line";
+            $ret = 1;
+        }
+
+        # Require EOL, space, or enum/struct end after comma.
+        if ($data =~ /,[^ \\\n)}]/) {
+            print "Invalid character after comma:\n";
+            print "$file:$.: $line";
+            $ret = 1;
+        }
+
+        # Require spaces around assignment '=', compounds and '=='
+        if ($data =~ /[^ ]\b[!<>&|\-+*\/%\^=]?=/ ||
+            $data =~ /=[^= \\\n]/) {
+            print "Spacing around '=' or '==':\n";
+            print "$file:$.: $line";
+            $ret = 1;
+        }
+
+        # One line conditional statements with one line bodies should
+        # not use curly brackets.
+        if ($data =~ /^\s*(if|while|for)\b.*\{$/) {
+            $cb_linenum = $.;
+            $cb_code = $line;
+            $cb_scolon = 0;
+        }
+
+        # We need to check for exactly one semicolon inside the body,
+        # because empty statements (e.g. with comment only) are
+        # allowed
+        if ($cb_linenum == $. - 1 && $data =~ /^[^;]*;[^;]*$/) {
+            $cb_code .= $line;
+            $cb_scolon = 1;
+        }
+
+        if ($data =~ /^\s*}\s*$/ &&
+            $cb_linenum == $. - 2 &&
+            $cb_scolon) {
+
+            print "Curly brackets around single-line body:\n";
+            print "$file:$cb_linenum-$.:\n$cb_code$line";
+            $ret = 1;
+
+            # There _should_ be no need to reset the values; but to
+            # keep my inner peace...
+            $cb_linenum = 0;
+            $cb_scolon = 0;
+            $cb_code = "";
+        }
     }
     close FILE;
 }

build-aux/header-ifdef.pl

@@ -0,0 +1,156 @@
+#!/usr/bin/perl
+#
+# Validate that header files follow a standard layout:
+#
+# /*
+#  ...copyright header...
+#  */
+# <one blank line>
+# #ifndef SYMBOL
+# # define SYMBOL
+# ....content....
+# #endif /* SYMBOL */
+#
+# For any file ending priv.h, before the #ifndef
+# We will have a further section
+#
+# #ifndef SYMBOL_ALLOW
+# # error ....
+# #endif /* SYMBOL_ALLOW */
+# <one blank line>
+
+use strict;
+use warnings;
+
+my $STATE_COPYRIGHT_COMMENT = 0;
+my $STATE_COPYRIGHT_BLANK = 1;
+my $STATE_PRIV_START = 2;
+my $STATE_PRIV_ERROR = 3;
+my $STATE_PRIV_END = 4;
+my $STATE_PRIV_BLANK = 5;
+my $STATE_GUARD_START = 6;
+my $STATE_GUARD_DEFINE = 7;
+my $STATE_GUARD_END = 8;
+my $STATE_EOF = 9;
+
+my $file = " ";
+my $ret = 0;
+my $ifdef = "";
+my $ifdefpriv = "";
+
+my $state = $STATE_EOF;
+my $mistake = 0;
+
+sub mistake {
+    my $msg = shift;
+    warn $msg;
+    $mistake = 1;
+    $ret = 1;
+}
+
+while (<>) {
+    if (not $file eq $ARGV) {
+        if ($state == $STATE_COPYRIGHT_COMMENT) {
+            &mistake("$file: missing copyright comment");
+        } elsif ($state == $STATE_COPYRIGHT_BLANK) {
+            &mistake("$file: missing blank line after copyright header");
+        } elsif ($state == $STATE_PRIV_START) {
+            &mistake("$file: missing '#ifndef $ifdefpriv'");
+        } elsif ($state == $STATE_PRIV_ERROR) {
+            &mistake("$file: missing '# error ...priv allow...'");
+        } elsif ($state == $STATE_PRIV_END) {
+            &mistake("$file: missing '#endif /* $ifdefpriv */'");
+        } elsif ($state == $STATE_PRIV_BLANK) {
+            &mistake("$file: missing blank line after priv header check");
+        } elsif ($state == $STATE_GUARD_START) {
+            &mistake("$file: missing '#ifndef $ifdef'");
+        } elsif ($state == $STATE_GUARD_DEFINE) {
+            &mistake("$file: missing '# define $ifdef'");
+        } elsif ($state == $STATE_GUARD_END) {
+            &mistake("$file: missing '#endif /* $ifdef */'");
+        }
+
+        $ifdef = uc $ARGV;
+        $ifdef =~ s,.*/,,;
+        $ifdef =~ s,[^A-Z0-9],_,g;
+        $ifdef =~ s,__+,_,g;
+        unless ($ifdef =~ /^LIBVIRT_/ && $ARGV !~ /libvirt_internal.h/) {
+            $ifdef = "LIBVIRT_" . $ifdef;
+        }
+        $ifdefpriv = $ifdef . "_ALLOW";
+
+        $file = $ARGV;
+        $state = $STATE_COPYRIGHT_COMMENT;
+        $mistake = 0;
+    }
+
+    if ($mistake ||
+        $ARGV =~ /config-post\.h$/ ||
+        $ARGV =~ /vbox_(CAPI|XPCOM)/) {
+        $state = $STATE_EOF;
+        next;
+    }
+
+    if ($state == $STATE_COPYRIGHT_COMMENT) {
+        if (m,\*/,) {
+            $state = $STATE_COPYRIGHT_BLANK;
+        }
+    } elsif ($state == $STATE_COPYRIGHT_BLANK) {
+        if (! /^$/) {
+            &mistake("$file: missing blank line after copyright header");
+        }
+        if ($ARGV =~ /priv\.h$/) {
+            $state = $STATE_PRIV_START;
+        } else {
+            $state = $STATE_GUARD_START;
+        }
+    } elsif ($state == $STATE_PRIV_START) {
+        if (/^$/) {
+            &mistake("$file: too many blank lines after coyright header");
+        } elsif (/#ifndef $ifdefpriv$/) {
+            $state = $STATE_PRIV_ERROR;
+        } else {
+            &mistake("$file: missing '#ifndef $ifdefpriv'");
+        }
+    } elsif ($state == $STATE_PRIV_ERROR) {
+        if (/# error ".*"$/) {
+            $state = $STATE_PRIV_END;
+        } else {
+            &mistake("$file: missing '#error ...priv allow...'");
+        }
+    } elsif ($state == $STATE_PRIV_END) {
+        if (m,#endif /\* $ifdefpriv \*/,) {
+            $state = $STATE_PRIV_BLANK;
+        } else {
+            &mistake("$file: missing '#endif /* $ifdefpriv */'");
+        }
+    } elsif ($state == $STATE_PRIV_BLANK) {
+        if (! /^$/) {
+            &mistake("$file: missing blank line after priv guard");
+        }
+        $state = $STATE_GUARD_START;
+    } elsif ($state == $STATE_GUARD_START) {
+        if (/^$/) {
+            &mistake("$file: too many blank lines after coyright header");
+        } elsif (/#ifndef $ifdef$/) {
+            $state = $STATE_GUARD_DEFINE;
+        } else {
+            &mistake("$file: missing '#ifndef $ifdef'");
+        }
+    } elsif ($state == $STATE_GUARD_DEFINE) {
+        if (/# define $ifdef$/) {
+            $state = $STATE_GUARD_END;
+        } else {
+            &mistake("$file: missing '# define $ifdef'");
+        }
+    } elsif ($state == $STATE_GUARD_END) {
+        if (m,#endif /\* $ifdef \*/$,) {
+            $state = $STATE_EOF;
+        }
+    } elsif ($state == $STATE_EOF) {
+        die "$file: unexpected content after '#endif /* $ifdef */'";
+    } else {
+        die "$file: unexpected state $state";
+    }
+}
+exit $ret;

cfg.mk

@@ -1,5 +1,5 @@
 # Customize Makefile.maint.                           -*- makefile -*-
-# Copyright (C) 2008-2015 Red Hat, Inc.
+# Copyright (C) 2008-2019 Red Hat, Inc.
 # Copyright (C) 2003-2008 Free Software Foundation, Inc.
 
 # This program is free software: you can redistribute it and/or modify
@@ -120,7 +120,6 @@ useless_free_options = \
   --name=virConfFreeValue \
   --name=virDomainActualNetDefFree \
   --name=virDomainChrDefFree \
-  --name=virDomainChrSourceDefFree \
   --name=virDomainControllerDefFree \
   --name=virDomainDefFree \
   --name=virDomainDeviceDefFree \
@@ -305,10 +304,11 @@ sc_flags_usage:
 	    $(srcdir)/include/libvirt/libvirt-qemu.h \
 	    $(srcdir)/include/libvirt/libvirt-lxc.h \
 	    $(srcdir)/include/libvirt/libvirt-admin.h \
-	  | grep -c '\(long\|unsigned\) flags')" != 4 && \
+	  | $(GREP) -c '\(long\|unsigned\) flags')" != 4 && \
 	  { echo '$(ME): new API should use "unsigned int flags"' 1>&2; \
 	    exit 1; } || :
 	@prohibit=' flags ATTRIBUTE_UNUSED' \
+	exclude='virSecurityDomainImageLabelFlags' \
 	halt='flags should be checked with virCheckFlags' \
 	  $(_sc_search_regexp)
 	@prohibit='^[^@]*([^d] (int|long long)|[^dg] long) flags[;,)]' \
@@ -472,6 +472,7 @@ sc_prohibit_canonicalize_file_name:
 # Insist on correct types for [pug]id.
 sc_correct_id_types:
 	@prohibit='\<(int|long) *[pug]id\>' \
+	exclude='exempt from syntax-check' \
 	halt='use pid_t for pid, uid_t for uid, gid_t for gid' \
 	  $(_sc_search_regexp)
 
@@ -638,10 +639,12 @@ sc_libvirt_unmarked_diagnostics:
 	exclude='_\(' \
 	halt='found unmarked diagnostic(s)' \
 	  $(_sc_search_regexp)
-	@{ grep     -nE '\<$(func_re) *\(.*;$$' $$($(VC_LIST_EXCEPT)); \
-	   grep -A1 -nE '\<$(func_re) *\(.*,$$' $$($(VC_LIST_EXCEPT)); } \
-	   | $(SED) 's/_("\([^\"]\|\\.\)\+"//;s/[	 ]"%s"//' \
-	   | grep '[	 ]"' && \
+	@{ $(VC_LIST_EXCEPT) | xargs \
+		$(GREP)     -nE '\<$(func_re) *\(.*;$$' /dev/null; \
+	   $(VC_LIST_EXCEPT) | xargs \
+		$(GREP) -A1 -nE '\<$(func_re) *\(.*,$$' /dev/null; } \
+	   | $(SED) -E 's/_\("([^\"]|\\.)+"//;s/"%s"//' \
+	   | $(GREP) '"' && \
 	  { echo '$(ME): found unmarked diagnostic(s)' 1>&2; \
 	    exit 1; } || :
 
@@ -653,9 +656,9 @@ sc_libvirt_unmarked_diagnostics:
 # there are functions to which this one applies but that do not get marked
 # diagnostics.
 sc_prohibit_newline_at_end_of_diagnostic:
-	@grep -A2 -nE \
-	    '\<$(func_re) *\(' $$($(VC_LIST_EXCEPT)) \
-	    | grep '\\n"' \
+	@$(VC_LIST_EXCEPT) | xargs $(GREP) -A2 -nE \
+	    '\<$(func_re) *\(' /dev/null \
+	    | $(GREP) '\\n"' \
 	  && { echo '$(ME): newline at end of message(s)' 1>&2; \
 	    exit 1; } || :
 
@@ -663,12 +666,14 @@ sc_prohibit_newline_at_end_of_diagnostic:
 # allow VIR_ERROR to do this, and ignore functions that take a single
 # string rather than a format argument.
 sc_prohibit_diagnostic_without_format:
-	@{ grep     -nE '\<$(func_re) *\(.*;$$' $$($(VC_LIST_EXCEPT)); \
-	   grep -A2 -nE '\<$(func_re) *\(.*,$$' $$($(VC_LIST_EXCEPT)); } \
+	@{ $(VC_LIST_EXCEPT) | xargs \
+		$(GREP)     -nE '\<$(func_re) *\(.*;$$' /dev/null; \
+	   $(VC_LIST_EXCEPT) | xargs \
+		$(GREP) -A2 -nE '\<$(func_re) *\(.*,$$' /dev/null; } \
 	   | $(SED) -rn -e ':l; /[,"]$$/ {N;b l;}' \
 		-e '/(xenapiSessionErrorHandler|vah_(error|warning))/d' \
 		-e '/\<$(func_re) *\([^"]*"([^%"]|"\n[^"]*")*"[,)]/p' \
-           | grep -vE 'VIR_ERROR' && \
+           | $(GREP) -vE 'VIR_ERROR' && \
 	  { echo '$(ME): found diagnostic without %' 1>&2; \
 	    exit 1; } || :
 
@@ -686,16 +691,16 @@ sc_prohibit_useless_translation:
 # When splitting a diagnostic across lines, ensure that there is a space
 # or \n on one side of the split.
 sc_require_whitespace_in_translation:
-	@grep -n -A1 '"$$' $$($(VC_LIST_EXCEPT)) \
+	@$(VC_LIST_EXCEPT) | xargs $(GREP) -n -A1 '"$$' /dev/null \
 	   | $(SED) -ne ':l; /"$$/ {N;b l;}; s/"\n[^"]*"/""/g; s/\\n/ /g' \
-		-e '/_(.*[^\ ]""[^\ ]/p' | grep . && \
+		-e '/_(.*[^\ ]""[^\ ]/p' | $(GREP) . && \
 	  { echo '$(ME): missing whitespace at line split' 1>&2; \
 	    exit 1; } || :
 
 # Enforce recommended preprocessor indentation style.
 sc_preprocessor_indentation:
 	@if cppi --version >/dev/null 2>&1; then \
-	  $(VC_LIST_EXCEPT) | grep -E '\.[ch](\.in)?$$' | xargs cppi -a -c \
+	  $(VC_LIST_EXCEPT) | $(GREP) -E '\.[ch](\.in)?$$' | xargs cppi -a -c \
 	    || { echo '$(ME): incorrect preprocessor indentation' 1>&2; \
 		exit 1; }; \
 	else \
@@ -706,13 +711,13 @@ sc_preprocessor_indentation:
 # (comment-only) C file that mirrors the same layout as the spec file.
 sc_spec_indentation:
 	@if cppi --version >/dev/null 2>&1; then \
-	  for f in $$($(VC_LIST_EXCEPT) | grep '\.spec\.in$$'); do \
+	  for f in $$($(VC_LIST_EXCEPT) | $(GREP) '\.spec\.in$$'); do \
 	    $(SED) -e 's|#|// #|; s|%ifn*\(arch\)* |#if a // |' \
 		-e 's/%\(else\|endif\|define\)/#\1/' \
 		-e 's/^\( *\)\1\1\1#/#\1/' \
 		-e 's|^\( *[^#/ ]\)|// \1|; s|^\( */[^/]\)|// \1|' $$f \
 	    | cppi -a -c 2>&1 | $(SED) "s|standard input|$$f|"; \
-	  done | { if grep . >&2; then false; else :; fi; } \
+	  done | { if $(GREP) . >&2; then false; else :; fi; } \
 	    || { echo '$(ME): incorrect preprocessor indentation' 1>&2; \
 		exit 1; }; \
 	else \
@@ -787,10 +792,8 @@ sc_prohibit_cross_inclusion:
 	  case $$dir in \
 	    util/) safe="util";; \
 	    access/ | conf/) safe="($$dir|conf|util)";; \
-	    cpu/| network/| node_device/| rpc/| storage/) \
+	    cpu/| network/| node_device/| rpc/| security/| storage/) \
 	      safe="($$dir|util|conf|storage)";; \
-	    security/) \
-	      safe="($$dir|util|conf|storage|locking)";; \
 	    xenapi/ | xenconfig/ ) safe="($$dir|util|conf|xen|cpu)";; \
 	    *) safe="($$dir|$(mid_dirs)|util)";; \
 	  esac; \
@@ -804,11 +807,12 @@ sc_prohibit_cross_inclusion:
 # When converting an enum to a string, make sure that we track any new
 # elements added to the enum by using a _LAST marker.
 sc_require_enum_last_marker:
-	@grep -A1 -nE '^[^#]*VIR_ENUM_IMPL *\(' $$($(VC_LIST_EXCEPT)) \
+	@$(VC_LIST_EXCEPT) | xargs \
+		$(GREP) -A1 -nE '^[^#]*VIR_ENUM_IMPL *\(' /dev/null \
 	   | $(SED) -ne '/VIR_ENUM_IMPL[^,]*,$$/N' \
 	     -e '/VIR_ENUM_IMPL[^,]*,[^,]*[^_,][^L,][^A,][^S,][^T,],/p' \
 	     -e '/VIR_ENUM_IMPL[^,]*,[^,]\{0,4\},/p' \
-	   | grep . && \
+	   | $(GREP) . && \
 	  { echo '$(ME): enum impl needs to use _LAST marker' 1>&2; \
 	    exit 1; } || :
 
@@ -867,8 +871,7 @@ sc_prohibit_atoi:
 	  $(_sc_search_regexp)
 
 sc_prohibit_wrong_filename_in_comment:
-	@fail=0; \
-	awk 'BEGIN { \
+	@$(VC_LIST_EXCEPT) | $(GREP) '\.[ch]$$'	| xargs awk 'BEGIN { \
 	  fail=0; \
 	} FNR < 3 { \
 	  n=match($$0, /[[:space:]][^[:space:]]*[.][ch][[:space:]:]/); \
@@ -884,11 +887,8 @@ sc_prohibit_wrong_filename_in_comment:
 	  if (fail == 1) { \
 	    exit 1; \
 	  } \
-	}' $$($(VC_LIST_EXCEPT) | grep '\.[ch]$$') || fail=1; \
-	if test $$fail -eq 1; then \
-	  { echo '$(ME): The file name in comments must match the' \
-	    'actual file name' 1>&2; exit 1; } \
-	fi;
+	}' || { echo '$(ME): The file name in comments must match the' \
+	    'actual file name' 1>&2; exit 1; }
 
 sc_prohibit_virConnectOpen_in_virsh:
 	@prohibit='\bvirConnectOpen[a-zA-Z]* *\(' \
@@ -919,22 +919,21 @@ sc_require_if_else_matching_braces:
 	  $(_sc_search_regexp)
 
 sc_curly_braces_style:
-	@files=$$($(VC_LIST_EXCEPT) | grep '\.[ch]$$'); \
-	if $(GREP) -nHP \
+	@if $(VC_LIST_EXCEPT) | $(GREP) '\.[ch]$$' | xargs $(GREP) -nHP \
 '^\s*(?!([a-zA-Z_]*for_?each[a-zA-Z_]*) ?\()([_a-zA-Z0-9]+( [_a-zA-Z0-9]+)* ?\()?(\*?[_a-zA-Z0-9]+(,? \*?[_a-zA-Z0-9\[\]]+)+|void)\) ?\{' \
-	$$files; then \
+	/dev/null; then \
 	  echo '$(ME): Non-K&R style used for curly braces around' \
 	    'function body' 1>&2; exit 1; \
 	fi; \
-	if $(GREP) -A1 -En ' ((if|for|while|switch) \(|(else|do)\b)[^{]*$$'\
-	  $$files | $(GREP) '^[^ ]*- *{'; then \
+	if $(VC_LIST_EXCEPT) | $(GREP) '\.[ch]$$' | xargs \
+	    $(GREP) -A1 -En ' ((if|for|while|switch) \(|(else|do)\b)[^{]*$$' \
+	    /dev/null | $(GREP) '^[^ ]*- *{'; then \
 	  echo '$(ME): Use hanging braces for compound statements' 1>&2; exit 1; \
 	fi
 
 sc_prohibit_windows_special_chars_in_filename:
-	@files=$$($(VC_LIST_EXCEPT) | grep '[:*?"<>|]'); \
-	test -n "$$files" && { echo '$(ME): Windows special chars' \
-	  'in filename not allowed:' 1>&2; echo $$files 1>&2; exit 1; } || :
+	@$(VC_LIST_EXCEPT) | $(GREP) '[:*?"<>|]' && \
+	{ echo '$(ME): Windows special chars in filename not allowed' 1>&2; echo exit 1; } || :
 
 sc_prohibit_mixed_case_abbreviations:
 	@prohibit='Pci|Usb|Scsi' \
@@ -950,11 +949,11 @@ sc_require_locale_h:
 	  $(_sc_search_regexp)
 
 sc_prohibit_empty_first_line:
-	@awk 'BEGIN { fail=0; } \
+	@$(VC_LIST_EXCEPT) | xargs awk 'BEGIN { fail=0; } \
 	FNR == 1 { if ($$0 == "") { print FILENAME ":1:"; fail=1; } } \
 	END { if (fail == 1) { \
 	  print "$(ME): Prohibited empty first line" > "/dev/stderr"; \
-	} exit fail; }' $$($(VC_LIST_EXCEPT));
+	} exit fail; }'
 
 sc_prohibit_paren_brace:
 	@prohibit='\)\{$$' \
@@ -997,8 +996,9 @@ sc_prohibit_sysconf_pagesize:
 	  $(_sc_search_regexp)
 
 sc_prohibit_virSecurity:
-	@grep -Pn 'virSecurityManager(?!Ptr)' $$($(VC_LIST_EXCEPT) | grep 'src/qemu/' | \
-		grep -v 'src/qemu/qemu_security') && \
+	@$(VC_LIST_EXCEPT) | $(GREP) 'src/qemu/' | \
+		$(GREP) -v 'src/qemu/qemu_security' | \
+		xargs $(GREP) -Pn 'virSecurityManager(?!Ptr)' /dev/null && \
 		{ echo '$(ME): prefer qemuSecurity wrappers' 1>&2; exit 1; } || :
 
 sc_prohibit_pthread_create:
@@ -1051,6 +1051,11 @@ sc_prohibit_http_urls:
 	halt='Links must use https:// protocol' \
 	  $(_sc_search_regexp)
 
+sc_prohibit_author:
+	@prohibit="(\*|#)\s*(A|a)uthors?:" \
+	halt="Author: statements are prohibited in source comments" \
+	  $(_sc_search_regexp)
+
 # Alignment is usually achieved through spaces (at least two of them)
 # or tabs (at least one of them) right before the trailing backslash
 sc_prohibit_backslash_alignment:
@@ -1062,7 +1067,7 @@ sc_prohibit_backslash_alignment:
 # Some syntax rules pertaining to the usage of cleanup macros
 # implementing GNU C's cleanup attribute
 
-# Rule to ensure that varibales declared using a cleanup macro are
+# Rule to ensure that variables declared using a cleanup macro are
 # always initialized.
 sc_require_attribute_cleanup_initialization:
 	@prohibit='VIR_AUTO((FREE|PTR)\(.+\)|CLOSE) *[^=]+;' \
@@ -1118,29 +1123,34 @@ _autogen_error:
 
 ifneq ($(_gl-Makefile),)
 syntax-check: spacing-check test-wrap-argv \
-	prohibit-duplicate-header mock-noinline group-qemu-caps
+	prohibit-duplicate-header mock-noinline group-qemu-caps \
+        header-ifdef
 endif
 
 # Don't include duplicate header in the source (either *.c or *.h)
 prohibit-duplicate-header:
-	$(AM_V_GEN)files=$$($(VC_LIST_EXCEPT) | grep '\.[chx]$$'); \
-	$(PERL) -W $(top_srcdir)/build-aux/prohibit-duplicate-header.pl $$files
+	$(AM_V_GEN)$(VC_LIST_EXCEPT) | $(GREP) '\.[chx]$$' | xargs \
+	$(PERL) -W $(top_srcdir)/build-aux/prohibit-duplicate-header.pl
 
 spacing-check:
-	$(AM_V_GEN)files=`$(VC_LIST) | grep '\.c$$'`; \
-	$(PERL) $(top_srcdir)/build-aux/check-spacing.pl $$files || \
+	$(AM_V_GEN)$(VC_LIST) | $(GREP) '\.c$$' | xargs \
+	$(PERL) $(top_srcdir)/build-aux/check-spacing.pl || \
 	  { echo '$(ME): incorrect formatting' 1>&2; exit 1; }
 
 mock-noinline:
-	$(AM_V_GEN)files=`$(VC_LIST) | grep '\.[ch]$$'`; \
-	$(PERL) $(top_srcdir)/build-aux/mock-noinline.pl $$files
+	$(AM_V_GEN)$(VC_LIST) | $(GREP) '\.[ch]$$' | xargs \
+	$(PERL) $(top_srcdir)/build-aux/mock-noinline.pl
+
+header-ifdef:
+	$(AM_V_GEN)$(VC_LIST) | $(GREP) '\.[h]$$' | xargs \
+	$(PERL) $(top_srcdir)/build-aux/header-ifdef.pl
 
 test-wrap-argv:
-	$(AM_V_GEN)files=`$(VC_LIST) | grep -E '\.(ldargs|args)'`; \
-	$(PERL) $(top_srcdir)/tests/test-wrap-argv.pl --check $$files
+	$(AM_V_GEN)$(VC_LIST) | $(GREP) -E '\.(ldargs|args)' | xargs \
+	$(PERL) $(top_srcdir)/tests/test-wrap-argv.pl --check
 
 group-qemu-caps:
-	$(PERL) $(top_srcdir)/tests/group-qemu-caps.pl --check $(top_srcdir)/
+	$(AM_V_GEN)$(PERL) $(top_srcdir)/tests/group-qemu-caps.pl --check $(top_srcdir)/
 
 # sc_po_check can fail if generated files are not built first
 sc_po_check: \
@@ -1179,7 +1189,7 @@ exclude_file_name_regexp--sc_copyright_usage = \
   ^COPYING(|\.LESSER)$$
 
 exclude_file_name_regexp--sc_flags_usage = \
-  ^(cfg\.mk|docs/|src/util/virnetdevtap\.c$$|tests/((vir(cgroup|pci|test|usb)|nss|qemuxml2argv)mock|virfilewrapper)\.c$$)
+  ^(cfg\.mk|docs/|src/util/virnetdevtap\.c$$|tests/((vir(cgroup|pci|test|usb)|nss|qemuxml2argv|qemusecurity)mock|virfilewrapper)\.c$$)
 
 exclude_file_name_regexp--sc_libvirt_unmarked_diagnostics = \
   ^(src/rpc/gendispatch\.pl$$|tests/)
@@ -1202,7 +1212,7 @@ exclude_file_name_regexp--sc_prohibit_strdup = \
   ^(docs/|examples/|src/util/virstring\.c|tests/vir(netserverclient|cgroup)mock.c|tests/commandhelper\.c$$)
 
 exclude_file_name_regexp--sc_prohibit_close = \
-  (\.p[yl]$$|\.spec\.in$$|^docs/|^(src/util/virfile\.c|src/libvirt-stream\.c|tests/vir.+mock\.c|tests/commandhelper\.c)$$)
+  (\.p[yl]$$|\.spec\.in$$|^docs/|^(src/util/virfile\.c|src/libvirt-stream\.c|tests/(vir.+mock\.c|commandhelper\.c|qemusecuritymock\.c))$$)
 
 exclude_file_name_regexp--sc_prohibit_empty_lines_at_EOF = \
   (^tests/(virhostcpu|virpcitest)data/|docs/js/.*\.js|docs/fonts/.*\.woff|\.diff|tests/virconfdata/no-newline\.conf$$)
@@ -1223,7 +1233,7 @@ exclude_file_name_regexp--sc_prohibit_newline_at_end_of_diagnostic = \
   ^src/rpc/gendispatch\.pl$$
 
 exclude_file_name_regexp--sc_prohibit_nonreentrant = \
-  ^((po|tests)/|docs/.*(py|js|html\.in)|run.in$$|tools/wireshark/util/genxdrstub\.pl$$)
+  ^((po|tests|examples/admin)/|docs/.*(py|js|html\.in)|run.in$$|tools/wireshark/util/genxdrstub\.pl$$)
 
 exclude_file_name_regexp--sc_prohibit_select = \
 	^cfg\.mk$$
@@ -1272,7 +1282,7 @@ exclude_file_name_regexp--sc_correct_id_types = \
 exclude_file_name_regexp--sc_m4_quote_check = m4/virt-lib.m4
 
 exclude_file_name_regexp--sc_prohibit_include_public_headers_quote = \
-  ^(src/internal\.h$$|tools/wireshark/src/packet-libvirt.h$$)
+  ^(src/internal\.h$$|tools/wireshark/src/packet-libvirt.c$$)
 
 exclude_file_name_regexp--sc_prohibit_include_public_headers_brackets = \
   ^(tools/|examples/|include/libvirt/(virterror|libvirt(-(admin|qemu|lxc))?)\.h$$)

config-post.h

@@ -19,7 +19,7 @@
 /*
  * Since virt-login-shell will be setuid, we must do everything
  * we can to avoid linking to other libraries. Many of them do
- * unsafe things in functions marked __atttribute__((constructor)).
+ * unsafe things in functions marked __attribute__((constructor)).
  * The only way to avoid such deps is to re-compile the
  * functions with the code in question disabled, and for that we
  * must override the main config.h rules. Hence this file :-(
@@ -69,7 +69,6 @@
 # undef WITH_VIRTUALPORT
 # undef WITH_SECDRIVER_SELINUX
 # undef WITH_SECDRIVER_APPARMOR
-# undef WITH_CAPNG
 #endif /* LIBVIRT_NSS */
 
 #ifndef __GNUC__

configure.ac

@@ -16,7 +16,7 @@ dnl You should have received a copy of the GNU Lesser General Public
 dnl License along with this library.  If not, see
 dnl <http://www.gnu.org/licenses/>.
 
-AC_INIT([libvirt], [4.9.0], [libvir-list@redhat.com], [], [https://libvirt.org])
+AC_INIT([libvirt], [5.1.0], [libvir-list@redhat.com], [], [https://libvirt.org])
 AC_CONFIG_SRCDIR([src/libvirt.c])
 AC_CONFIG_AUX_DIR([build-aux])
 AC_CONFIG_HEADERS([config.h])
@@ -225,7 +225,6 @@ if test "$with_libvirtd" = "no" ; then
   with_qemu=no
   with_lxc=no
   with_libxl=no
-  with_uml=no
   with_vbox=no
 fi
 
@@ -247,6 +246,7 @@ LIBVIRT_ARG_CAPNG
 LIBVIRT_ARG_CURL
 LIBVIRT_ARG_DBUS
 LIBVIRT_ARG_FIREWALLD
+LIBVIRT_ARG_FIREWALLD_ZONE
 LIBVIRT_ARG_FUSE
 LIBVIRT_ARG_GLUSTER
 LIBVIRT_ARG_HAL
@@ -287,6 +287,7 @@ LIBVIRT_CHECK_DBUS
 LIBVIRT_CHECK_DEVMAPPER
 LIBVIRT_CHECK_DLOPEN
 LIBVIRT_CHECK_FIREWALLD
+LIBVIRT_CHECK_FIREWALLD_ZONE
 LIBVIRT_CHECK_FUSE
 LIBVIRT_CHECK_GLUSTER
 LIBVIRT_CHECK_GNUTLS
@@ -445,7 +446,6 @@ LIBVIRT_DRIVER_ARG_VBOX
 LIBVIRT_DRIVER_ARG_LXC
 LIBVIRT_DRIVER_ARG_VZ
 LIBVIRT_DRIVER_ARG_BHYVE
-LIBVIRT_DRIVER_ARG_UML
 LIBVIRT_DRIVER_ARG_ESX
 LIBVIRT_DRIVER_ARG_HYPERV
 LIBVIRT_DRIVER_ARG_TEST
@@ -464,7 +464,6 @@ LIBVIRT_DRIVER_CHECK_VBOX
 LIBVIRT_DRIVER_CHECK_LXC
 LIBVIRT_DRIVER_CHECK_VZ
 LIBVIRT_DRIVER_CHECK_BHYVE
-LIBVIRT_DRIVER_CHECK_UML
 LIBVIRT_DRIVER_CHECK_ESX
 LIBVIRT_DRIVER_CHECK_HYPERV
 LIBVIRT_DRIVER_CHECK_TEST
@@ -947,7 +946,6 @@ AC_MSG_NOTICE([])
 AC_MSG_NOTICE([Drivers])
 AC_MSG_NOTICE([])
 LIBVIRT_DRIVER_RESULT_QEMU
-LIBVIRT_DRIVER_RESULT_UML
 LIBVIRT_DRIVER_RESULT_OPENVZ
 LIBVIRT_DRIVER_RESULT_VMWARE
 LIBVIRT_DRIVER_RESULT_VBOX
@@ -1004,6 +1002,7 @@ LIBVIRT_RESULT_CURL
 LIBVIRT_RESULT_DBUS
 LIBVIRT_RESULT_DLOPEN
 LIBVIRT_RESULT_FIREWALLD
+LIBVIRT_RESULT_FIREWALLD_ZONE
 LIBVIRT_RESULT_FUSE
 LIBVIRT_RESULT_GLUSTER
 LIBVIRT_RESULT_GNUTLS

docs/aclpolkit.html.in

@@ -287,6 +287,119 @@
       </tbody>
     </table>
 
+    <h2><a id="connect_driver">Hypervisor Driver connect_driver</a></h2>
+    <p>
+      The <code>connect_driver</code> parameter describes the
+      client's <a href="remote.html">remote Connection Driver</a>
+      name based on the <a href="uri.html">URI</a> used for the
+      connection.
+    </p>
+    <p>
+      <span class="since">Since 4.1.0</span>, when calling an API
+      outside the scope of the primary connection driver, the
+      primary driver will attempt to open a secondary connection
+      to the specific API driver in order to process the API. For
+      example, when hypervisor domain processing needs to make an
+      API call within the storage driver or the network filter driver
+      an attempt to open a connection to the "storage" or "nwfilter"
+      driver will be made. Similarly, a "storage" primary connection
+      may need to create a connection to the "secret" driver in order
+      to process secrets for the API. If successful, then calls to
+      those API's will occur in the <code>connect_driver</code> context
+      of the secondary connection driver rather than in the context of
+      the primary driver. This affects the <code>connect_driver</code>
+      returned from rule generation from the <code>action.loookup</code>
+      function. The following table provides a list of the various
+      connection drivers and the <code>connect_driver</code> name
+      used by each regardless of primary or secondary connection.
+      The access denied error message from libvirt will list the
+      connection driver by name that denied the access.
+    </p>
+
+    <h3><a id="object_connect_driver">Connection Driver Name</a></h3>
+    <table class="acl">
+      <thead>
+        <tr>
+          <th>Connection Driver</th>
+          <th><code>connect_driver</code> name</th>
+        </tr>
+      </thead>
+      <tbody>
+        <tr>
+          <td>bhyve</td>
+          <td>bhyve</td>
+        </tr>
+        <tr>
+          <td>esx</td>
+          <td>ESX</td>
+        </tr>
+        <tr>
+          <td>hyperv</td>
+          <td>Hyper-V</td>
+        </tr>
+        <tr>
+          <td>interface</td>
+          <td>interface</td>
+        </tr>
+        <tr>
+          <td>libxl</td>
+          <td>xenlight</td>
+        </tr>
+        <tr>
+          <td>lxc</td>
+          <td>LXC</td>
+        </tr>
+        <tr>
+          <td>network</td>
+          <td>network</td>
+        </tr>
+        <tr>
+          <td>nodedev</td>
+          <td>nodedev</td>
+        </tr>
+        <tr>
+          <td>nwfilter</td>
+          <td>NWFilter</td>
+        </tr>
+        <tr>
+          <td>openvz</td>
+          <td>OPENVZ</td>
+        </tr>
+        <tr>
+          <td>phyp</td>
+          <td>PHYP</td>
+        </tr>
+        <tr>
+          <td>qemu</td>
+          <td>QEMU</td>
+        </tr>
+        <tr>
+          <td>secret</td>
+          <td>secret</td>
+        </tr>
+        <tr>
+          <td>storage</td>
+          <td>storage</td>
+        </tr>
+        <tr>
+          <td>vbox</td>
+          <td>VBOX</td>
+        </tr>
+        <tr>
+          <td>vmware</td>
+          <td>VMWARE</td>
+        </tr>
+        <tr>
+          <td>vz</td>
+          <td>vz</td>
+        </tr>
+        <tr>
+          <td>xenapi</td>
+          <td>XenAPI</td>
+        </tr>
+      </tbody>
+    </table>
+
 
     <h2><a id="user">User identity attributes</a></h2>
 

docs/apibuild.py

@@ -1003,6 +1003,8 @@ class CParser:
                 # skip hidden macros
                 if name in hidden_macros:
                     return token
+                if name[-2:] == "_H" or name[-8:] == "_H_ALLOW":
+                    return token
 
                 strValue = None
                 if len(lst) == 1 and lst[0][0] == '"' and lst[0][-1] == '"':
@@ -2115,12 +2117,22 @@ class docBuilder:
                      self.modulename_file(id.header)))
         if id.info is not None:
             info = id.info
+            valhex = ""
             if info[0] is not None and info[0] != '':
                 try:
                     val = eval(info[0])
+                    valhex = hex(val)
                 except:
                     val = info[0]
                 output.write(" value='%s'" % (val))
+
+                if valhex != "":
+                    output.write(" value_hex='%s'" % (valhex))
+
+                m = re.match("\(?1<<(\d+)\)?", info[0])
+                if m:
+                    output.write(" value_bitshift='%s'" % (m.group(1)))
+
             if info[2] is not None and info[2] != '':
                 output.write(" type='%s'" % info[2])
             if info[1] is not None and info[1] != '':
@@ -2270,7 +2282,7 @@ class docBuilder:
         output.write("    <file name='%s'>\n" % (module))
         dict = self.headers[file]
         if dict.info is not None:
-            for data in ('Summary', 'Description', 'Author'):
+            for data in ('Summary', 'Description'):
                 try:
                     output.write("     <%s>%s</%s>\n" % (
                                  data.lower(),

docs/auth.html.in

@@ -184,15 +184,29 @@ Default policy will still allow any application to connect to the RO socket.
 </p>
     <p>
 The default policy can be overridden by creating a new policy file in the
-local override directory <code>/etc/polkit-1/localauthority/50-local.d/</code>.
-Policy files should have a unique name ending with .pkla.  Using reverse DNS
-naming works well. Information on the options available can be found by
-reading the pklocalauthority man page. The two libvirt daemon actions
-available are named <code>org.libvirt.unix.manage</code> for full management
-access, and <code>org.libvirt.unix.monitor</code> for read-only access.
-    </p>
+<code>/etc/polkit-1/rules.d</code> directory. Information on the options
+available can be found by reading the <code>polkit(8)</code> man page. The
+two libvirt actions are named <code>org.libvirt.unix.manage</code> for full
+management access, and <code>org.libvirt.unix.monitor</code> for read-only
+access.
+</p>
     <p>
-As an example, this gives the user <code>fred</code> full management access:
+As an example, creating <code>/etc/polkit-1/rules.d/80-libvirt-manage.rules</code>
+with the following gives the user <code>fred</code> full management access
+when accessing from an active local session:
+    </p>
+<pre>polkit.addRule(function(action, subject) {
+  if (action.id == "org.libvirt.unix.manage" &amp;&amp;
+      subject.local &amp;&amp; subject.active &amp;&amp; subject.user == "fred") {
+      return polkit.Result.YES;
+  }
+});</pre>
+    <p>
+Older versions of PolicyKit used policy files ending with .pkla in the
+local override directory <code>/etc/polkit-1/localauthority/50-local.d/</code>.
+Compatibility with this older format is provided by <a
+href="https://pagure.io/polkit-pkla-compat">polkit-pkla-compat</a>. As an
+example, this gives the user <code>fred</code> full management access:
     </p>
 <pre>[Allow fred libvirt management permissions]
 Identity=unix-user:fred
@@ -200,10 +214,6 @@ Action=org.libvirt.unix.manage
 ResultAny=yes
 ResultInactive=yes
 ResultActive=yes</pre>
-    <p>
-Further examples of PolicyKit setup can be found on the
-<a href="http://wiki.libvirt.org/page/SSHPolicyKitSetup">wiki page</a>.
-    </p>
     <h2><a id="ACL_server_sasl">SASL pluggable authentication</a></h2>
 
     <p>

docs/devhelp/devhelp.xsl

@@ -72,7 +72,6 @@
 	  <xsl:if test="deprecated">
 	    <p> WARNING: this module is deprecated !</p>
 	  </xsl:if>
-	  <p>Author(s): <xsl:value-of select="author"/></p>
 	  <div class="refsynopsisdiv">
 	  <h2>Synopsis</h2>
 	  <pre class="synopsis">

docs/drivers.html.in

@@ -29,7 +29,6 @@
       <li><strong><a href="drvopenvz.html">OpenVZ</a></strong></li>
       <li><strong><a href="drvqemu.html">QEMU</a></strong></li>
       <li><strong><a href="drvtest.html">Test</a></strong> - Used for testing</li>
-      <li><strong><a href="drvuml.html">UML</a></strong> - User Mode Linux</li>
       <li><strong><a href="drvvbox.html">VirtualBox</a></strong></li>
       <li><strong><a href="drvesx.html">VMware ESX</a></strong></li>
       <li><strong><a href="drvvmware.html">VMware Workstation/Player</a></strong></li>

docs/drvbhyve.html.in

@@ -462,5 +462,32 @@ Example:</p>
 &lt;/domain&gt;
 </pre>
 
+<h3><a id="bhyvecommand">Pass-through of arbitrary bhyve commands</a></h3>
+
+<p><span class="since">Since 5.1.0</span>, it's possible to pass additional command-line
+arguments to the bhyve process when starting the domain using the
+<code>&lt;bhyve:commandline&gt;</code> element under <code>domain</code>.
+To supply an argument, use the element <code>&lt;bhyve:arg&gt;</code> with
+the attribute <code>value</code> set to additional argument to be added.
+The arg element may be repeated multiple times. To use this XML addition, it is necessary
+to issue an XML namespace request (the special <code>xmlns:<i>name</i></code> attribute)
+that pulls in <code>http://libvirt.org/schemas/domain/bhyve/1.0</code>;
+typically, the namespace is given the name of <code>bhyve</code>.
+</p>
+<p>Example:</p>
+<pre>
+&lt;domain type="bhyve" xmlns:bhyve="http://libvirt.org/schemas/domain/bhyve/1.0"&gt;
+  ...
+  &lt;bhyve:commandline&gt;
+    &lt;bhyve:arg value='-somebhyvearg'/&gt;
+  &lt;/bhyve:commandline&gt;
+&lt;/domain&gt;
+</pre>
+
+<p>Note that these extensions are for testing and development purposes only.
+They are <b>unsupported</b>, using them may result in inconsistent state,
+and upgrading either bhyve or libvirtd maybe break behavior of a domain that
+was relying on a specific commands pass-through.</p>
+
   </body>
 </html>

docs/drvqemu.html.in

@@ -395,9 +395,8 @@ chmod o+x /path/to/directory
 <pre>
 /dev/null, /dev/full, /dev/zero,
 /dev/random, /dev/urandom,
-/dev/ptmx, /dev/kvm, /dev/kqemu,
-/dev/rtc, /dev/hpet, /dev/net/tun,
-/dev/sev
+/dev/ptmx, /dev/kvm,
+/dev/rtc, /dev/hpet
 </pre>
 
     <p>

docs/drvuml.html.in

@@ -1,93 +0,0 @@
-<?xml version="1.0" encoding="UTF-8"?>
-<!DOCTYPE html>
-<html xmlns="http://www.w3.org/1999/xhtml">
-  <body>
-    <h1>User Mode Linux driver</h1>
-
-    <p>
-    The UML driver for libvirt allows use and management of paravirtualized
-    guests built for User Mode Linux. UML requires no special support in
-    the host kernel, so can be used by any user of any linux system, provided
-    they have enough free RAM for their guest's needs, though there are
-    certain restrictions on network connectivity unless the administrator
-    has pre-created TAP devices.
-    </p>
-
-    <h2><a id="project">Project Links</a></h2>
-
-    <ul>
-      <li>
-        The <a href="http://user-mode-linux.sourceforge.net/">User
-        Mode Linux</a> paravirtualized kernel
-      </li>
-    </ul>
-
-    <h2>Connections to UML driver</h2>
-
-    <p>
-    The libvirt UML driver follows the QEMU driver in providing two
-    types of connection. There is one privileged instance per host,
-    which runs as root. This is called the "system" instance, and allows
-    full use of all host resources. Then, there is a per-user unprivileged
-    "session", instance. This has more restricted capabilities, and may
-    require the host administrator to setup certain resources ahead of
-    time to allow full integration with the network. Example connection
-    URIs are
-    </p>
-
-<pre>
-uml:///session                       (local access to per-user instance)
-uml+unix:///session                  (local access to per-user instance)
-
-uml:///system                        (local access to system instance)
-uml+unix:///system                   (local access to system instance)
-uml://example.com/system             (remote access, TLS/x509)
-uml+tcp://example.com/system         (remote access, SASl/Kerberos)
-uml+ssh://root@example.com/system    (remote access, SSH tunnelled)
-</pre>
-
-    <h2>Example XML configuration</h2>
-
-    <p>
-      User mode Linux driver only supports directly kernel boot at
-      this time. A future driver enhancement may allow a paravirt
-      bootloader in a similar style to Xen's pygrub. For now though,
-      the UML kernel must be stored on the host and referenced
-      explicitly in the "os" element. Since UML is a paravirtualized
-      technology, the kernel "type" is set to "uml"
-    </p>
-
-    <p>
-      There is not yet support for networking in the driver, but
-      disks can be specified in the usual libvirt manner. The main
-      variation is the target device naming scheme "ubd0", and
-      bus type of "uml".
-    </p>
-
-    <p>
-      Once booted the primary console is connected to a PTY, and
-      thus accessible with "virsh console" or equivalent tools
-    </p>
-
-<pre>
-&lt;domain type='uml'&gt;
-  &lt;name&gt;demo&lt;/name&gt;
-  &lt;uuid&gt;b4433fc2-a22e-ffb3-0a3d-9c173b395800&lt;/uuid&gt;
-  &lt;memory&gt;500000&lt;/memory&gt;
-  &lt;currentMemory&gt;500000&lt;/currentMemory&gt;
-  &lt;vcpu&gt;1&lt;/vcpu&gt;
-  &lt;os&gt;
-    &lt;type arch='x86_64'&gt;uml&lt;/type&gt;
-    &lt;kernel&gt;/home/berrange/linux-uml-2.6.26-x86_64&lt;/kernel&gt;
-  &lt;/os&gt;
-  &lt;devices&gt;
-    &lt;disk type='file' device='disk'&gt;
-      &lt;source file='/home/berrange/FedoraCore6-AMD64-root_fs'/&gt;
-      &lt;target dev='ubd0' bus='uml'/&gt;
-    &lt;/disk&gt;
-    &lt;console type='pty'/&gt;
-  &lt;/devices&gt;
-&lt;/domain&gt;
-</pre>
-  </body>
-</html>

docs/firewall.html.in

@@ -129,6 +129,44 @@ MASQUERADE all  --  *      *       192.168.122.0/24    !192.168.122.0/24</pre>
       </li>
     </ul>
 
+    <h3><a id="fw-firewalld-and-virtual-network-driver">firewalld and the virtual network driver</a>
+    </h3>
+    <p>
+      If <a href="https://firewalld.org">firewalld</a> is active on
+      the host, libvirt will attempt to place the bridge interface of
+      a libvirt virtual network into the firewalld zone named
+      "libvirt" (thus making all guest->host traffic on that network
+      subject to the rules of the "libvirt" zone). This is done
+      because, if firewalld is using its nftables backend (available
+      since firewalld 0.6.0) the default firewalld zone (which would
+      be used if libvirt didn't explicitly set the zone) prevents
+      forwarding traffic from guests through the bridge, as well as
+      preventing DHCP, DNS, and most other traffic from guests to
+      host. The zone named "libvirt" is installed into the firewalld
+      configuration by libvirt (not by firewalld), and allows
+      forwarded traffic through the bridge as well as DHCP, DNS, TFTP,
+      and SSH traffic to the host - depending on firewalld's backend
+      this will be implemented via either iptables or nftables
+      rules. libvirt's own rules outlined above will *always* be
+      iptables rules regardless of which backend is in use by
+      firewalld.
+    </p>
+    <p>
+      NB: It is possible to manually set the firewalld zone for a
+      network's interface with the "zone" attribute of the network's
+      "bridge" element.
+    </p>
+    <p>
+      NB: Prior to libvirt 5.1.0, the firewalld "libvirt" zone did not
+      exist, and prior to firewalld 0.7.0 a feature crucial to making
+      the "libvirt" zone operate properly (rich rule priority
+      settings) was not implemented in firewalld. In cases where one
+      or the other of the two packages is missing the necessary
+      functionality, it's still possible to have functional guest
+      networking by setting the firewalld backend to "iptables" (in
+      firewalld prior to 0.6.0, this was the only backend available).
+    </p>
+
     <h3><a id="fw-network-filter-driver">The network filter driver</a>
     </h3>
     <p>This driver provides a fully configurable network filtering capability

docs/formatcaps.html.in

@@ -74,19 +74,19 @@
         is able to run. Possible values are:
         <dl>
           <dt><code>xen</code></dt>
-          <dd>for XEN</dd>
+          <dd>for XEN PV</dd>
 
           <dt><code>linux</code></dt>
           <dd>legacy alias for <code>xen</code></dd>
 
+          <dt><code>xenpvh</code></dt>
+          <dd>for XEN PVH</dd>
+
           <dt><code>hvm</code></dt>
           <dd>Unmodified operating system</dd>
 
           <dt><code>exe</code></dt>
           <dd>Container based virtualization</dd>
-
-          <dt><code>uml</code></dt>
-          <dd>User Mode Linux</dd>
         </dl>
         </dd>
 
@@ -104,8 +104,8 @@
             <dt><code>machine</code></dt><dd>Machine type, for use in
               <a href="formatdomain.html#attributeOSTypeMachine">machine</a>
               attribute of os/type element in domain XML. For example Xen
-              supports <code>xenfv</code> for HVM or <code>xenpv</code> for
-              PV.</dd>
+              supports <code>xenfv</code> for HVM, <code>xenpv</code> for
+              PV, or <code>xenpvh</code> for PVH.</dd>
             <dt><code>domain</code></dt><dd>The <code>type</code> attribute of
               this element specifies the type of hypervisor required to run the
               domain. Use in <a href="formatdomain.html#attributeDomainType">type</a>

docs/formatdomain.html.in

@@ -22,7 +22,7 @@
       <a id="attributeDomainType"><code>type</code></a>
       specifies the hypervisor used for running
       the domain. The allowed values are driver specific, but
-      include "xen", "kvm", "qemu", "lxc" and "kqemu". The
+      include "xen", "kvm", "qemu" and "lxc". The
       second attribute is <code>id</code> which is a unique
       integer identifier for the running guest machine. Inactive
       machines have no id value.
@@ -759,6 +759,12 @@
     &lt;cachetune vcpus='0-3'&gt;
       &lt;cache id='0' level='3' type='both' size='3' unit='MiB'/&gt;
       &lt;cache id='1' level='3' type='both' size='3' unit='MiB'/&gt;
+      &lt;monitor level='3' vcpus='1'/&gt;
+      &lt;monitor level='3' vcpus='0-3'/&gt;
+    &lt;/cachetune&gt;
+    &lt;cachetune vcpus='4-5'&gt;
+      &lt;monitor level='3' vcpus='4'/&gt;
+      &lt;monitor level='3' vcpus='5'/&gt;
     &lt;/cachetune&gt;
     &lt;memorytune vcpus='0-3'&gt;
       &lt;node id='0' bandwidth='60'/&gt;
@@ -943,8 +949,8 @@
         <dl>
           <dt><code>cache</code></dt>
           <dd>
-            This element controls the allocation of CPU cache and has the
-            following attributes:
+            This optional element controls the allocation of CPU cache and has
+            the following attributes:
             <dl>
               <dt><code>level</code></dt>
               <dd>
@@ -978,6 +984,26 @@
               </dd>
             </dl>
           </dd>
+          <dt><code>monitor</code><span class="since">Since 4.10.0</span></dt>
+          <dd>
+            The optional element <code>monitor</code> creates the cache
+            monitor(s) for current cache allocation and has the following
+            required attributes:
+            <dl>
+              <dt><code>level</code></dt>
+              <dd>
+                Host cache level the monitor belongs to.
+              </dd>
+              <dt><code>vcpus</code></dt>
+              <dd>
+                vCPU list the monitor applies to. A monitor's vCPU list
+                can only be the member(s) of the vCPU list of the associated
+                allocation. The default monitor has the same vCPU list as the
+                associated allocation. For non-default monitors, overlapping
+                vCPUs are not permitted.
+              </dd>
+            </dl>
+          </dd>
         </dl>
       </dd>
 
@@ -1100,7 +1126,7 @@
     &lt;/hugepages&gt;
     &lt;nosharepages/&gt;
     &lt;locked/&gt;
-    &lt;source type="file|anonymous"/&gt;
+    &lt;source type="file|anonymous|memfd"/&gt;
     &lt;access mode="shared|private"/&gt;
     &lt;allocation mode="immediate|ondemand"/&gt;
     &lt;discard/&gt;
@@ -1151,9 +1177,10 @@
         suitable for the specific environment at the same time to mitigate
         the risks described above. <span class="since">Since 1.0.6</span></dd>
        <dt><code>source</code></dt>
-       <dd>Using the <code>type</code> attribute, it's possible to provide
-         "file" to utilize file memorybacking or keep the default
-         "anonymous".</dd>
+       <dd>Using the <code>type</code> attribute, it's possible to
+       provide "file" to utilize file memorybacking or keep the
+       default "anonymous". <span class="since">Since 4.10.0</span>,
+       you may choose "memfd" backing. (QEMU/KVM only)</dd>
        <dt><code>access</code></dt>
        <dd>Using the <code>mode</code> attribute, specify if the memory is
          to be "shared" or "private". This can be overridden per numa node by
@@ -1216,9 +1243,9 @@
         <a href="#elementsMemoryBacking">memory backing</a> because your
         workload demands it, you'll have to take into account the specifics of
         your deployment and figure out a value for <code>hard_limit</code> that
-        balances the risk of your guest being killed because the limit was set
-        too low and the risk of your host crashing because it cannot reclaim
-        the memory used by the guest due to <code>locked</code>. Good luck!</dd>
+        is large enough to support the memory requirements of your guest, but
+        small enough to protect your host against a malicious guest locking all
+        memory.</dd>
       <dt><code>soft_limit</code></dt>
       <dd> The optional <code>soft_limit</code> element is the memory limit to
         enforce during memory contention. The units for this value are
@@ -1981,6 +2008,9 @@
     &lt;frequencies state='on'/&gt;
     &lt;reenlightenment state='on'/&gt;
     &lt;tlbflush state='on'/&gt;
+    &lt;ipi state='on'/&gt;
+    &lt;evmcs state='on'/&gt;
+    &lt;msrs unknown='ignore'/&gt;
   &lt;/hyperv&gt;
   &lt;kvm&gt;
     &lt;hidden state='on'/&gt;
@@ -2052,7 +2082,7 @@
         <tr>
           <td>relaxed</td>
           <td>Relax constraints on timers</td>
-          <td> on, off</td>
+          <td>on, off</td>
           <td><span class="since">1.0.0 (QEMU 2.0)</span></td>
         </tr>
         <tr>
@@ -2070,31 +2100,31 @@
         <tr>
           <td>vpindex</td>
           <td>Virtual processor index</td>
-          <td> on, off</td>
+          <td>on, off</td>
           <td><span class="since">1.3.3 (QEMU 2.5)</span></td>
         </tr>
         <tr>
           <td>runtime</td>
           <td>Processor time spent on running guest code and on behalf of guest code</td>
-          <td> on, off</td>
+          <td>on, off</td>
           <td><span class="since">1.3.3 (QEMU 2.5)</span></td>
         </tr>
         <tr>
           <td>synic</td>
           <td>Enable Synthetic Interrupt Controller (SyNIC)</td>
-          <td> on, off</td>
+          <td>on, off</td>
           <td><span class="since">1.3.3 (QEMU 2.6)</span></td>
         </tr>
         <tr>
           <td>stimer</td>
           <td>Enable SyNIC timers</td>
-          <td> on, off</td>
+          <td>on, off</td>
           <td><span class="since">1.3.3 (QEMU 2.6)</span></td>
         </tr>
         <tr>
           <td>reset</td>
           <td>Enable hypervisor reset</td>
-          <td> on, off</td>
+          <td>on, off</td>
           <td><span class="since">1.3.3 (QEMU 2.5)</span></td>
         </tr>
         <tr>
@@ -2106,21 +2136,33 @@
         <tr>
           <td>frequencies</td>
           <td>Expose frequency MSRs</td>
-          <td> on, off</td>
+          <td>on, off</td>
           <td><span class="since">4.7.0 (QEMU 2.12)</span></td>
         </tr>
         <tr>
           <td>reenlightenment</td>
           <td>Enable re-enlightenment notification on migration</td>
-          <td> on, off</td>
+          <td>on, off</td>
           <td><span class="since">4.7.0 (QEMU 3.0)</span></td>
         </tr>
         <tr>
           <td>tlbflush</td>
           <td>Enable PV TLB flush support</td>
-          <td> on, off</td>
+          <td>on, off</td>
           <td><span class="since">4.7.0 (QEMU 3.0)</span></td>
         </tr>
+        <tr>
+          <td>ipi</td>
+          <td>Enable PV IPI support</td>
+          <td>on, off</td>
+          <td><span class="since">4.10.0 (QEMU 3.1)</span></td>
+        </tr>
+        <tr>
+          <td>evmcs</td>
+          <td>Enable Enlightened VMCS</td>
+          <td>on, off</td>
+          <td><span class="since">4.10.0 (QEMU 3.1)</span></td>
+        </tr>
       </table>
       </dd>
       <dt><code>pvspinlock</code></dt>
@@ -2254,6 +2296,27 @@
           defined, the hypervisor default will be used.
           <span class="since">Since 4.6.0</span> (QEMU/KVM only)
       </dd>
+      <dt><code>nested-hv</code></dt>
+      <dd>Configure nested HV availability for pSeries guests. This needs to
+          be enabled from the host (L0) in order to be effective; having HV
+          support in the (L1) guest is very desiderable if it's planned to
+          run nested (L2) guests inside it, because it will result in those
+          nested guests having much better performance than they would when
+          using KVM PR or TCG.
+          Possible values for the <code>state</code> attribute are
+          <code>on</code> and <code>off</code>. If the attribute is not
+          defined, the hypervisor default will be used.
+          <span class="since">Since 4.10.0</span> (QEMU/KVM only)
+      </dd>
+      <dt><code>msrs</code></dt>
+      <dd>Some guests might require ignoring unknown
+          Model Specific Registers (MSRs) reads and writes. It's possible
+          to switch this by setting <code>unknown</code> attribute
+          of <code>msrs</code> to <code>ignore</code>. If the attribute is
+          not defined, or set to <code>fault</code>, unknown reads and writes
+          will not be ignored.
+          <span class="since">Since 5.1.0</span> (bhyve only)
+      </dd>
     </dl>
 
     <h3><a id="elementsTime">Time keeping</a></h3>
@@ -2795,7 +2858,6 @@
     &lt;/source&gt;
     &lt;target dev='sdb' bus='scsi'/&gt;
   &lt;/disk&gt;
-  &lt;/disk&gt;
   &lt;disk type='network' device='lun'&gt;
     &lt;driver name='qemu' type='raw'/&gt;
     &lt;source protocol='iscsi' name='iqn.2013-07.com.example:iscsi-nopool/0'&gt;
@@ -3925,7 +3987,15 @@
         (<span class="since">since 0.9.7, requires QEMU
         0.13</span>). <code>multifunction</code> defaults to 'off',
         but should be set to 'on' for function 0 of a slot that will
-        have multiple functions used.<br/>
+        have multiple functions used.
+        (<span class="since">Since 4.10.0</span>), PCI address extensions
+        depending on the architecture are supported. For example, PCI
+        addresses for S390 guests will have a <code>zpci</code> child
+        element, with two attributes: <code>uid</code> (a hex value
+        between 0x0001 and 0xffff, inclusive), and <code>fid</code> (a
+        hex value between 0x00000000 and 0xffffffff, inclusive) used by
+        PCI devices on S390 for User-defined Identifiers and Function
+        Identifiers.<br/>
         <span class="since">Since 1.3.5</span>, some hypervisor
         drivers may accept an <code>&lt;address type='pci'/&gt;</code>
         element with no other attributes as an explicit request to
@@ -5168,7 +5238,6 @@
     &lt;virtualport&gt;
       &lt;parameters instanceid='09b11c53-8b5c-4eeb-8f00-d84eaa0aaa4f'/&gt;
     &lt;/virtualport&gt;
-
   &lt;/interface&gt;
 &lt;/devices&gt;
 ...</pre>
@@ -5661,8 +5730,7 @@ qemu-kvm -net nic,model=? /dev/null
       &lt;host csum='off' gso='off' tso4='off' tso6='off' ecn='off' ufo='off' mrg_rxbuf='off'/&gt;
       &lt;guest csum='off' tso4='off' tso6='off' ecn='off' ufo='off'/&gt;
     &lt;/driver&gt;
-    </b>
-  &lt;/interface&gt;
+    </b>&lt;/interface&gt;
 &lt;/devices&gt;
 ...</pre>
 
@@ -6164,7 +6232,7 @@ qemu-kvm -net nic,model=? /dev/null
     <b>&lt;route family='ipv4' address='192.168.122.0' prefix='24' gateway='192.168.122.1'/&gt;</b>
     <b>&lt;route family='ipv4' address='192.168.122.8' gateway='192.168.122.1'/&gt;</b>
   &lt;/hostdev&gt;
-
+  ...
 &lt;/devices&gt;
 ...
 </pre>
@@ -6646,12 +6714,17 @@ qemu-kvm -net nic,model=? /dev/null
               the other types, for practical reasons it should be paired with
               either <code>vnc</code> or <code>spice</code> graphics types.
               This display type is only supported by QEMU domains
-              (needs QEMU <span class="since">2.10</span> or newer) and doesn't
-              accept any attributes.
+              (needs QEMU <span class="since">2.10</span> or newer).
+              <span class="Since">5.0.0</span> this element accepts a
+              <code>&lt;gl/&gt;</code> sub-element with an optional attribute
+              <code>rendernode</code> which can be used to specify an absolute
+              path to a host's DRI device to be used for OpenGL rendering.
             </p>
             <pre>
 &lt;graphics type='spice' autoport='yes'/&gt;
-&lt;graphics type='egl-headless'/&gt;
+&lt;graphics type='egl-headless'&gt;
+  &lt;gl rendernode='/dev/dri/renderD128'/&gt;
+&lt;/graphics&gt;
             </pre>
           </dd>
         </dl>
@@ -7098,9 +7171,9 @@ qemu-kvm -net nic,model=? /dev/null
       Valid values for the <code>type</code> attribute are:
       <code>serial</code> (described below);
       <code>virtio</code> (usable whenever VirtIO support is available);
-      <code>xen</code>, <code>lxc</code>, <code>uml</code> and
-      <code>openvz</code> (available when the corresponding hypervisor is in
-      use). <code>sclp</code> and <code>sclplm</code> (usable for s390 and
+      <code>xen</code>, <code>lxc</code> and <code>openvz</code>
+      (available when the corresponding hypervisor is in use).
+      <code>sclp</code> and <code>sclplm</code> (usable for s390 and
       s390x QEMU guests) are supported for compatibility reasons but should
       not be used for new guests: use the <code>sclpconsole</code> and
       <code>sclplmconsole</code> target models, respectively, with the
@@ -8259,6 +8332,21 @@ qemu-kvm -net nic,model=? /dev/null
   &lt;memory model='nvdimm'&gt;
     &lt;source&gt;
       &lt;path&gt;/tmp/nvdimm&lt;/path&gt;
+      &lt;alignsize unit='KiB'&gt;2048&lt;/alignsize&gt;
+    &lt;/source&gt;
+    &lt;target&gt;
+      &lt;size unit='KiB'&gt;524288&lt;/size&gt;
+      &lt;node&gt;1&lt;/node&gt;
+      &lt;label&gt;
+        &lt;size unit='KiB'&gt;128&lt;/size&gt;
+      &lt;/label&gt;
+      &lt;readonly/&gt;
+    &lt;/target&gt;
+  &lt;/memory&gt;
+  &lt;memory model='nvdimm'&gt;
+    &lt;source&gt;
+      &lt;path&gt;/dev/dax0.0&lt;/path&gt;
+      &lt;pmem/&gt;
     &lt;/source&gt;
     &lt;target&gt;
       &lt;size unit='KiB'&gt;524288&lt;/size&gt;
@@ -8340,10 +8428,36 @@ qemu-kvm -net nic,model=? /dev/null
         </dl>
 
         <p>
-          For model <code>nvdimm</code> this element is mandatory and has a
-          single child element <code>path</code> that represents a path
-          in the host that backs the nvdimm module in the guest.
+          For model <code>nvdimm</code> this element is mandatory. The
+          mandatory child element <code>path</code> represents a path in
+          the host that backs the nvdimm module in the guest. The following
+          optional elements may be used:
         </p>
+
+        <dl>
+          <dt><code>alignsize</code></dt>
+          <dd>
+            <p>
+              The <code>alignsize</code> element defines the page size
+              alignment used to mmap the address range for the backend
+              <code>path</code>. If not supplied the host page size is used.
+              For example, to mmap a real NVDIMM device a 2M-aligned page may
+              be required.
+              <span class="since">Since 5.0.0</span>
+            </p>
+          </dd>
+
+          <dt><code>pmem</code></dt>
+          <dd>
+            <p>
+              If persistent memory is supported and enabled by the hypervisor
+              in order to guarantee the persistence of writes to the vNVDIMM
+              backend, then use the <code>pmem</code> element in order to
+              utilize the feature.
+              <span class="since">Since 5.0.0</span>
+            </p>
+          </dd>
+        </dl>
       </dd>
 
       <dt><code>target</code></dt>
@@ -8362,19 +8476,39 @@ qemu-kvm -net nic,model=? /dev/null
           NUMA nodes configured.
         </p>
         <p>
-          For NVDIMM type devices one can optionally use
-          <code>label</code> and its subelement <code>size</code>
-          to configure the size of namespaces label storage
-          within the NVDIMM module. The <code>size</code> element
-          has usual meaning described
-          <a href="#elementsMemoryAllocation">here</a>.
-          For QEMU domains the following restrictions apply:
+          The following optional elements may be used:
         </p>
-        <ol>
-          <li>the minimum label size is 128KiB,</li>
-          <li>the remaining size (total-size - label-size) has to be aligned to
-            4KiB</li>
-        </ol>
+
+        <dl>
+          <dt><code>label</code></dt>
+          <dd>
+            <p>
+              For NVDIMM type devices one can optionally use
+              <code>label</code> and its subelement <code>size</code>
+              to configure the size of namespaces label storage
+              within the NVDIMM module. The <code>size</code> element
+              has usual meaning described
+              <a href="#elementsMemoryAllocation">here</a>.
+              For QEMU domains the following restrictions apply:
+            </p>
+            <ol>
+              <li>the minimum label size is 128KiB,</li>
+              <li>the remaining size (total-size - label-size) will be aligned
+                to 4KiB as default.</li>
+            </ol>
+          </dd>
+
+          <dt><code>readonly</code></dt>
+          <dd>
+            <p>
+              The <code>readonly</code> element is used to mark the vNVDIMM
+              as read-only. Only the real NVDIMM device backend can guarantee
+              the guest write persistence, so other backend types should use
+              the <code>readonly</code> element.
+              <span class="since">Since 5.0.0</span>
+            </p>
+          </dd>
+        </dl>
       </dd>
     </dl>
 
@@ -8661,8 +8795,8 @@ qemu-kvm -net nic,model=? /dev/null
        different entity using a different key the encrypted guests data will
        be incorrectly decrypted, leading to unintelligible data.
 
-       For more information see various input parameters and its format see the SEV API spec
-       <a href="https://support.amd.com/TechDocs/55766_SEV-KM%20API_Specification.pdf"> https://support.amd.com/TechDocs/55766_SEV-KM%20API_Specification.pdf </a>
+       For more information see various input parameters and its format see the
+       <a href="https://support.amd.com/TechDocs/55766_SEV-KM_API_Specification.pdf">SEV API spec</a>
        <span class="since">Since 4.4.0</span>
        </p>
     <pre>

docs/formatdomaincaps.html.in

@@ -278,7 +278,6 @@
         <value>virtio</value>
         <value>xen</value>
         <value>usb</value>
-        <value>uml</value>
         <value>sata</value>
         <value>sd</value>
       </enum>
@@ -482,7 +481,7 @@
 
     <p>
     For more details on SEV feature see:
-      <a href="https://support.amd.com/TechDocs/55766_SEV-KM%20API_Specification.pdf">
+      <a href="https://support.amd.com/TechDocs/55766_SEV-KM_API_Specification.pdf">
         SEV API spec</a> and <a href="http://amd-dev.wpengine.netdna-cdn.com/wordpress/media/2013/12/AMD_Memory_Encryption_Whitepaper_v7-Public.pdf">
         SEV White Paper</a>
     </p>

docs/formatnetwork.html.in

@@ -107,13 +107,13 @@
         may also be connected to the LAN. When defining
         a new network with a <code>&lt;forward&gt;</code> mode of
 
-        "nat" or "route" (or an isolated network with
+        "nat", "route", or "open" (or an isolated network with
         no <code>&lt;forward&gt;</code> element), libvirt will
         automatically generate a unique name for the bridge device if
         none is given, and this name will be permanently stored in the
         network configuration so that that the same name will be used
         every time the network is started. For these types of networks
-        (nat, routed, and isolated), a bridge name beginning with the
+        (nat, route, open, and isolated), a bridge name beginning with the
         prefix "virbr" is recommended (and that is what is
         auto-generated), but not enforced.
         Attribute <code>stp</code> specifies if Spanning Tree Protocol
@@ -152,6 +152,23 @@
           <span class="since">Since 1.2.11, requires kernel 3.17 or
           newer</span>
         </p>
+
+        <p>
+          The optional <code>zone</code> attribute of
+          the <code>bridge</code> element is used to specify
+          the <a href="https://firewalld.org">firewalld</a>
+          zone for the bridge of a network with <code>forward</code>
+          mode of "nat", "route", "open", or one with
+          no <code>forward</code> specified. By default, the bridges
+          of all virtual networks with these forward modes are placed
+          in the firewalld zone named "libvirt", which permits
+          incoming DNS, DHCP, TFTP, and SSH to the host from guests on
+          the network. This behavior can be changed either by
+          modifying the libvirt zone (using firewalld management
+          tools), or by placing the network in a different zone (which
+          will also be managed using firewalld tools).
+          <span class="since">Since 5.1.0</span>
+        </p>
       </dd>
 
       <dt><code>mtu</code></dt>

docs/formatnwfilter.html.in

@@ -2265,7 +2265,7 @@ echo 3 > /proc/sys/net/netfilter/nf_conntrack_icmp_timeout
      to the incoming and outgoing direction. All this is related to the ftp
      data traffic originating from TCP port 20 of the VM. This then leads to
      the following solution
-     <span class="since">(since 0.8.5 (QEMU, KVM, UML))</span>:
+     <span class="since">(since 0.8.5 (QEMU, KVM))</span>:
     </p>
 <pre>
 &lt;filter name='test-eth0'&gt;

docs/formatsnapshot.html.in

@@ -33,7 +33,7 @@
         resume in a consistent state; but if the disks are modified
         externally in the meantime, this is likely to lead to data
         corruption.</dd>
-      <dt>system checkpoint</dt>
+      <dt>full system</dt>
       <dd>A combination of disk snapshots for all disks as well as VM
         memory state, which can be used to resume the guest from where it
         left off with symptoms similar to hibernation (that is, TCP
@@ -55,11 +55,12 @@
       as <code>virDomainSaveImageGetXMLDesc()</code> to work with
       those files.
     </p>
-    <p>System checkpoints are created
-      by <code>virDomainSnapshotCreateXML()</code> with no flags, and
+    <p>Full system snapshots are created
+      by <code>virDomainSnapshotCreateXML()</code> with no flags, while
       disk snapshots are created by the same function with
-      the <code>VIR_DOMAIN_SNAPSHOT_CREATE_DISK_ONLY</code> flag; in
-      both cases, they are restored by
+      the <code>VIR_DOMAIN_SNAPSHOT_CREATE_DISK_ONLY</code>
+      flag. Regardless of the flags provided, restoration of the
+      snapshot is handled by
       the <code>virDomainRevertToSnapshot()</code> function.  For
       these types of snapshots, libvirt tracks each snapshot as a
       separate <code>virDomainSnapshotPtr</code> object, and maintains
@@ -128,13 +129,10 @@
         what file name is created in an external snapshot.  On output,
         this is fully populated to show the state of each disk in the
         snapshot, including any properties that were generated by the
-        hypervisor defaults.  For system checkpoints, this field is
-        ignored on input and omitted on output (a system checkpoint
-        implies that all disks participate in the snapshot process,
-        and since the current implementation only does internal system
-        checkpoints, there are no extra details to add); a future
-        release may allow the use of <code>disks</code> with a system
-        checkpoint.  This element has a list of <code>disk</code>
+        hypervisor defaults.  For full system snapshots, this field is
+        ignored on input and omitted on output (a full system snapshot
+        implies that all disks participate in the snapshot process).
+        This element has a list of <code>disk</code>
         sub-elements, describing anywhere from zero to all of the
         disks associated with the domain.  <span class="since">Since
         0.9.5</span>
@@ -206,11 +204,12 @@
       </dd>
       <dt><code>state</code></dt>
       <dd>The state of the domain at the time this snapshot was taken.
-        If the snapshot was created as a system checkpoint, then this
-        is the state of the domain at that time; when the domain is
+        If a full system snapshot was created, then this
+        is the state of the domain at that time. When the domain is
         reverted to this snapshot, the domain's state will default to
-        whatever is in this field unless additional flags are passed
-        to <code>virDomainRevertToSnapshot()</code>.  Additionally,
+        this state, unless overridden
+        by <code>virDomainRevertToSnapshot()</code> flags to revert to
+        a running or paused state. Additionally,
         this field can be the value "disk-snapshot"
         (<span class="since">since 0.9.5</span>) when it represents
         only a disk snapshot (no VM memory state), and reverting to this

docs/formatstorage.html.in

@@ -19,14 +19,15 @@
       a single attribute <code>type</code>, which is one of <code>dir</code>,
       <code>fs</code>, <code>netfs</code>, <code>disk</code>,
       <code>iscsi</code>, <code>logical</code>, <code>scsi</code>
-      (all <span class="since">since 0.4.1</span>), <code>mpath</code>
-      (<span class="since">since 0.7.1</span>), <code>rbd</code>
-      (<span class="since">since 0.9.13</span>), <code>sheepdog</code>
-      (<span class="since">since 0.10.0</span>),
-      <code>gluster</code> (<span class="since">since
-      1.2.0</span>),  <code>zfs</code> (<span class="since">since
-      1.2.8</span>) or <code>vstorage</code> (<span class="since">since
-      3.1.0</span>). This corresponds to the
+      (all <span class="since">since 0.4.1</span>),
+      <code>mpath</code> (<span class="since">since 0.7.1</span>),
+      <code>rbd</code> (<span class="since">since 0.9.13</span>),
+      <code>sheepdog</code> (<span class="since">since 0.10.0</span>),
+      <code>gluster</code> (<span class="since">since 1.2.0</span>),
+      <code>zfs</code> (<span class="since">since 1.2.8</span>),
+      <code>vstorage</code> (<span class="since">since 3.1.0</span>),
+      or <code>iscsi-direct</code> (<span class="since">since 4.7.0</span>).
+      This corresponds to the
       storage backend drivers listed further along in this document.
     </p>
     <h3><a id="StoragePoolFirst">General metadata</a></h3>
@@ -121,15 +122,26 @@
 &lt;/source&gt;
 ...</pre>
 
+    <pre>
+...
+  &lt;source&gt;
+    &lt;host name='localhost'/&gt;
+    &lt;dir path='/var/lib/libvirt/images'/&gt;
+    &lt;format type='nfs'/&gt;
+    &lt;protocol ver='3'/&gt;
+  &lt;/source&gt;
+...</pre>
+
     <dl>
       <dt><code>device</code></dt>
       <dd>Provides the source for pools backed by physical devices
         (pool types <code>fs</code>, <code>logical</code>, <code>disk</code>,
-        <code>iscsi</code>, <code>zfs</code>, <code>vstorage</code>).
+        <code>iscsi</code>, <code>iscsi-direct</code>, <code>zfs</code>,
+        <code>vstorage</code>).
         May be repeated multiple times depending on backend driver. Contains
         a required attribute <code>path</code> which is either the fully
         qualified path to the block device node or for <code>iscsi</code>
-        the iSCSI Qualified Name (IQN).
+        or <code>iscsi-direct</code> the iSCSI Qualified Name (IQN).
         <span class="since">Since 0.4.1</span>
         <p>An optional attribute <code>part_separator</code> for each
         <code>path</code> may be supplied. Valid values for the attribute
@@ -334,6 +346,7 @@
       <dt><code>host</code></dt>
       <dd>Provides the source for pools backed by storage from a
         remote server (pool types <code>netfs</code>, <code>iscsi</code>,
+        <code>iscsi-direct</code>,
         <code>rbd</code>, <code>sheepdog</code>, <code>gluster</code>). Will be
         used in combination with a <code>directory</code>
         or <code>device</code> element. Contains an attribute <code>name</code>
@@ -348,11 +361,19 @@
         server. See the <a href="storage.html">storage driver page</a> for
         any restrictions for specific storage backends.
         <span class="since">Since 0.4.1</span></dd>
+      <dt><code>initiator</code></dt>
+      <dd>Required by the <code>iscsi-direct</code> pool in order to provide
+        the iSCSI Qualified Name (IQN) to communicate with the pool's
+        <code>device</code> target IQN. There is one sub-element
+        <code>iqn</code> with the <code>name</code> attribute to describe
+        the IQN for the initiator.
+        <span class="since">Since 4.7.0</span></dd>
       <dt><code>auth</code></dt>
       <dd>If present, the <code>auth</code> element provides the
         authentication credentials needed to access the source by the
         setting of the <code>type</code> attribute (pool
-        types <code>iscsi</code>, <code>rbd</code>). The <code>type</code>
+        types <code>iscsi</code>, <code>iscsi-direct</code>, <code>rbd</code>).
+        The <code>type</code>
         must be either "chap" or "ceph". Use "ceph" for
         Ceph RBD (Rados Block Device) network sources and use "iscsi" for CHAP
         (Challenge-Handshake Authentication Protocol) iSCSI
@@ -386,6 +407,12 @@
         LVM metadata type. All drivers are required to have a default
         value for this, so it is optional. <span class="since">Since 0.4.1</span></dd>
 
+      <dt><code>protocol</code></dt>
+      <dd>For a <code>netfs</code> Storage Pool provide a mechanism to
+        define which NFS protocol version number will be used to contact
+        the server's NFS service. The attribute <code>ver</code> accepts
+        an unsigned integer as the version number to use.
+        <span class="since">Since 5.1.0</span></dd>
       <dt><code>vendor</code></dt>
       <dd>Provides optional information about the vendor of the
         storage device. This contains a single
@@ -451,8 +478,8 @@
         The <code>owner</code> element contains the numeric user ID.
         The <code>group</code> element contains the numeric group ID.
         If <code>owner</code> or <code>group</code> aren't specified when
-        creating a directory, the values are inherited from the parent
-        directory. The <code>label</code> element contains the MAC (eg SELinux)
+        creating a directory, the UID and GID of the libvirtd process are used.
+        The <code>label</code> element contains the MAC (eg SELinux)
         label string.
         <span class="since">Since 0.4.1</span>
         For running directory or filesystem based pools, these fields
@@ -481,6 +508,119 @@
       device, measured in bytes.  <span class="since">Since 0.4.1</span>
     </p>
 
+    <h3><a id="StoragePoolNamespaces">Storage Pool Namespaces</a></h3>
+
+    <p>
+      Usage of Storage Pool Namespaces provides a mechanism to provide
+      pool type specific data in a free form or arbitrary manner via
+      XML syntax targeted solely for the needs of the specific pool type
+      which is not otherwise supported in standard XML. For the "fs" and
+      "netfs" pool types this provides a mechanism to provide additional
+      mount options on the command line. For the "rbd" pool this provides
+      a mechanism to override default settings for RBD configuration options.
+    </p>
+    <p>
+      Usage of namespaces comes with no support guarantees. It is intended
+      for developers testing out a concept prior to requesting an explicitly
+      supported XML option in libvirt, and thus should never be used in
+      production.
+    </p>
+    <dl>
+      <dt><code>fs:mount_opts</code></dt>
+      <dd>Provides an XML namespace mechanism to optionally utilize
+        specifically named options for the mount command via the "-o"
+        option for the <code>fs</code> or <code>netfs</code> type storage
+        pools. In order to designate that the Storage Pool will be using
+        the mechanism, the <code>pool</code> element must be modified to
+        provide the XML namespace attribute syntax as follows:
+
+        <p>
+        xmlns:fs='http://libvirt.org/schemas/storagepool/fs/1.0'
+        </p>
+
+        <p>
+        The <code>fs:mount_opts</code> defines the mount options by
+        specifying multiple <code>fs:option</code> subelements with
+        the attribute <code>name</code> specifying the mount option to
+        be added. The value of the named option is not checked since
+        it's possible options don't exist on all distributions. It is
+        expected that proper and valid options will be supplied for the
+        target host.
+        </p>
+
+        The following XML snippet shows the syntax required in order to
+        utilize for a netfs pool:
+      <pre>
+&lt;pool type="netfs" xmlns:fs='http://libvirt.org/schemas/storagepool/fs/1.0'&gt;
+  &lt;name&gt;nfsimages&lt;/name&gt;
+...
+  &lt;source&gt;
+...
+  &lt;/source&gt;
+...
+  &lt;target&gt;
+...
+  &lt;/target&gt;
+  &lt;fs:mount_opts&gt;
+    &lt;fs:option name='sync'/&gt;
+    &lt;fs:option name='lazytime'/&gt;
+  &lt;/fs:mount_opts&gt;
+&lt;/pool&gt;
+...</pre>
+
+      <span class="since">Since 5.1.0.</span></dd>
+
+      <dt><code>rbd:config_opts</code></dt>
+      <dd>Provides an XML namespace mechanism to optionally utilize
+        specifically named options for the RBD configuration options
+        via the rados_conf_set API for the <code>rbd</code> type
+        storage pools. In order to designate that the Storage Pool
+        will be using the mechanism, the <code>pool</code> element
+        must be modified to provide the XML namespace attribute
+        syntax as follows:
+
+        <p>
+        xmlns:rbd='http://libvirt.org/schemas/storagepool/rbd/1.0'
+        </p>
+
+        <p>
+        The <code>rbd:config_opts</code> defines the configuration options
+        by specifying multiple <code>rbd:option</code> subelements with
+        the attribute <code>name</code> specifying the configuration option
+        to be added and <code>value</code> specifying the configuration
+        option value. The name and value for each option is only checked
+        to be not empty. The name and value provided are not checked since
+        it's possible options don't exist on all distributions. It is
+        expected that proper and valid options will be supplied for the
+        target host.
+        </p>
+
+        The following XML snippet shows the syntax required in order to
+        utilize
+      <pre>
+&lt;pool type="rbd" xmlns:rbd='http://libvirt.org/schemas/storagepool/rbd/1.0'&gt;
+  &lt;name&gt;myrbdpool&lt;/name&gt;
+...
+  &lt;source&gt;
+...
+  &lt;/source&gt;
+...
+  &lt;target&gt;
+...
+  &lt;/target&gt;
+...
+  &lt;rbd:config_opts&gt;
+    &lt;rbd:option name='client_mount_timeout' value='45'/&gt;
+    &lt;rbd:option name='rados_mon_op_timeout' value='20'/&gt;
+    &lt;rbd:option name='rados_osd_op_timeout' value='10'/&gt;
+  &lt;/rbd:config_opts&gt;
+&lt;/pool&gt;
+</pre>
+
+      <span class="since">Since 5.1.0.</span></dd>
+
+    </dl>
+
     <h2><a id="StorageVol">Storage volume XML</a></h2>
     <p>
       A storage volume will generally be either a file or a device
@@ -636,8 +776,8 @@
         The <code>owner</code> element contains the numeric user ID.
         The <code>group</code> element contains the numeric group ID.
         If <code>owner</code> or <code>group</code> aren't specified when
-        creating a supported volume, the values are inherited from the parent
-        directory. The <code>label</code> element contains the MAC (eg SELinux)
+        creating a supported volume, the UID and GID of the libvirtd process
+        are used. The <code>label</code> element contains the MAC (eg SELinux)
         label string.
         For existing directory or filesystem based volumes, these fields
         will be filled with the values used by the existing file.

docs/governance.html.in

@@ -155,7 +155,7 @@
       also implicitly stating that they have the legal right to make the
       contribution, if doing so on behalf of a broader organization /
       company. Most of the project's code is distributed under the GNU
-      Lesser General Public License, version 2 or later. Details of the
+      Lesser General Public License, version 2.1 or later. Details of the
       exact license under which contributions will be presumed to be
       covered are found in the source repositories, or website in question.
     </p>

docs/internals/command.html.in

@@ -426,7 +426,7 @@ dprintf(logfd, "%s: ", timestamp);
 VIR_FREE(timestamp);
 virCommandWriteArgLog(cmd, logfd);
 
-string = virCommandToString(cmd);
+string = virCommandToString(cmd, false);
 if (string)
     VIR_DEBUG("about to run %s", string);
 VIR_FREE(string);

docs/libvirt.css

@@ -100,14 +100,15 @@
     margin-right: auto;
     padding: 0px;
     padding-bottom: 1em;
-    max-width: 60em;
+    max-width: 95%;
+    width: 70em;
 }
 
 body.index #content,
 body.docs #content,
 body.hvsupport #content
 {
-    max-width: inherit;
+    width: inherit;
 }
 
 pre {
@@ -393,6 +394,7 @@ table.acl {
 
 table.acl tr, table.acl td {
     padding: 0.3em;
+    border: 1px solid #ccc;
 }
 
 table.acl thead {
@@ -536,3 +538,7 @@ dl.mail dt a:hover {
     color:  rgb(255, 230, 0);
     text-decoration: none;
 }
+
+td.enumvalue {
+    white-space: nowrap;
+}

docs/newapi.xsl

@@ -288,6 +288,24 @@
     </xsl:choose>
   </xsl:template>
 
+  <xsl:template name="enumvalue">
+    <xsl:param name="value" select="@value"/>
+    <xsl:param name="valuehex" select="@value_hex"/>
+    <xsl:param name="valuebitshift" select="@value_bitshift"/>
+    <xsl:value-of select="@value"/>
+    <xsl:if test="$valuehex != '' or $valuebitshift != ''">
+      <xsl:text> (</xsl:text>
+      <xsl:if test="$valuehex != ''">
+        <xsl:value-of select="@value_hex"/>
+      </xsl:if>
+      <xsl:if test="$valuebitshift != ''">
+        <xsl:text>; 1 &lt;&lt; </xsl:text>
+        <xsl:value-of select="@value_bitshift"/>
+      </xsl:if>
+      <xsl:text>)</xsl:text>
+    </xsl:if>
+  </xsl:template>
+
   <xsl:template match="typedef[@type = 'enum']">
     <xsl:variable name="name" select="string(@name)"/>
     <h3><a name="{$name}"><code><xsl:value-of select="$name"/></code></a></h3>
@@ -306,7 +324,7 @@
             <td><xsl:text> = </xsl:text></td>
             <xsl:choose>
               <xsl:when test="@info != ''">
-                <td><xsl:value-of select="@value"/></td>
+                <td class="enumvalue"><xsl:call-template name="enumvalue"/></td>
                 <td>
                   <div class="comment">
                     <xsl:call-template name="dumptext">
@@ -316,7 +334,7 @@
                 </td>
               </xsl:when>
               <xsl:otherwise>
-                <td colspan="2"><xsl:value-of select="@value"/></td>
+                <td colspan="2" class="enumvalue"><xsl:call-template name="enumvalue"/></td>
               </xsl:otherwise>
             </xsl:choose>
           </tr>

docs/news.xml

@@ -33,8 +33,524 @@
      -->
 
 <libvirt>
-  <release version="v4.9.0" date="unreleased">
+  <release version="v5.1.0" date="2019-03-04">
     <section title="New features">
+      <change>
+        <summary>
+          bhyve: Add support for additional command-line arguments
+        </summary>
+        <description>
+          The bhyve driver now supports passing additional command-line
+          arguments to the bhyve process using the new
+          <code>&lt;bhyve:commandline&gt;</code> element in domain
+          configuration.
+        </description>
+      </change>
+      <change>
+        <summary>
+          network: Support setting a firewalld "zone" for virtual network bridges
+        </summary>
+        <description>
+          All libvirt virtual networks with bridges managed by libvirt
+          (i.e. those with forward mode of "nat", "route", "open", or
+          no forward mode) will now be placed in a special firewalld
+          zone called "libvirt" by default. The zone of any network
+          bridge can be changed using the <code>zone</code> attribute
+          of the network's <code>bridge</code> element.
+        </description>
+      </change>
+      <change>
+        <summary>
+          bhyve: Support for ignoring unknown MSRs reads and writes
+        </summary>
+        <description>
+          A new &lt;features&gt; element &lt;msrs unknown='ignore'/&gt; was
+          introduced and the bhyve driver supports it to control unknown
+          Model Specific Registers (MSRs) reads and writes.
+        </description>
+      </change>
+      <change>
+        <summary>
+          qemu: Add support for encrypted VNC TLS keys
+        </summary>
+        <description>
+          Use the password stored in the secret driver under the uuid
+          specified by the <code>vnc_tls_x509_secret_uuid</code> option
+          in qemu.conf.
+        </description>
+      </change>
+      <change>
+        <summary>
+          Add storage pool namespace options
+        </summary>
+        <description>
+          Allow for adjustment of RBD configuration options via Storage
+          Pool XML Namespace adjustments.
+        </description>
+      </change>
+      <change>
+        <summary>
+          qemu: Add support for setting post-copy migration bandwidth
+        </summary>
+        <description>
+          Users can now limit the bandwidth of post-copy migration, e.g.
+          via <code>virsh migrate --postcopy-bandwidth</code>.
+        </description>
+      </change>
+    </section>
+    <section title="Improvements">
+      <change>
+        <summary>
+          Create private chains for virtual network firewall rules
+        </summary>
+        <description>
+          Historically firewall rules for virtual networks were added
+          straight into the base chains. This works but has a number of
+          bugs and design limitations. To address them, libvirt now puts
+          firewall rules into its own chains.
+        </description>
+      </change>
+      <change>
+        <summary>
+          Detect CEPH and GPFS as shared FS
+        </summary>
+        <description>
+          When starting a migration libvirt performs some sanity checks
+          to make sure domain will be able to run on the destination.
+          One of the requirements is that the disk has to either be
+          migrated too or be accessible from a network filesystem. CEPH
+          and GPFS weren't detected as a network filesystem.
+        </description>
+      </change>
+      <change>
+        <summary>
+          Advertise network MTU via DHCP when specified
+        </summary>
+        <description>
+          If network MTU is set and the network has DHCP enabled,
+          advertise the MTU in DHCP transaction too so that clients can
+          adjust their link accordingly.
+        </description>
+      </change>
+      <change>
+        <summary>
+          qemu: Allocate memory at the configured NUMA nodes from start
+        </summary>
+        <description>
+          Libvirt used to just start QEMU, let it allocate memory for
+          the guest, and then use CGroups to move the memory to
+          configured NUMA nodes. This is suboptimal as huge chunks of
+          memory have to be moved. Moreover, this relies on ability to
+          move memory later which is not always true. A change was made
+          to set process affinity correctly from the start so that memory
+          is allocated on the configured nodes from the beginning.
+        </description>
+      </change>
+      <change>
+        <summary>
+          Support for newer Wireshark
+        </summary>
+        <description>
+          Adapt libvirt to use the more recent release requiring a
+          source build configuration of libvirt
+          <code>--with-wireshark</code> to upgrade to the more recent
+          version.
+        </description>
+      </change>
+      <change>
+        <summary>
+          Batch mode virsh and virt-admin parsing improvements
+        </summary>
+        <description>
+          When parsing a single-argument command_string in batch mode,
+          virsh and virt-admin now permit newlines in addition to
+          semicolons for splitting commands, and backslash-newline for
+          splitting long lines, to be more like shell parsing.
+        </description>
+      </change>
+    </section>
+    <section title="Bug fixes">
+      <change>
+        <summary>
+          qemu: Use CAP_DAC_OVERRIDE during QEMU capabilities probing
+        </summary>
+        <description>
+          By default, libvirt runs the QEMU process as <code>qemu:qemu</code>
+          which could cause issues during probing as some features like AMD SEV
+          might be inaccessible to QEMU because of file system permissions.
+          Therefore, <code>CAP_DAC_OVERRIDE</code> is granted to overcome these
+          for the purposes of probing.
+        </description>
+      </change>
+      <change>
+        <summary>
+          storage: Add default mount options for fs/netfs storage pools
+        </summary>
+        <description>
+          Altered the command line generation for fs/netfs storage pools to
+          add some default options. For Linux based systems, the options
+          added are "nodev, nosuid, noexec". For FreeBSD based systems,
+          the options added are "nosuid, noexec".
+        </description>
+      </change>
+      <change>
+        <summary>
+          qemu: Allow use of PCI for RISC-V guests
+        </summary>
+        <description>
+          This works with QEMU 4.0.0+ only and is opt-in at the moment, since
+          it requires users to manually assign PCI addresses, but is otherwise
+          fully functional.
+        </description>
+      </change>
+      <change>
+        <summary>
+          network: Fix virtual networks on systems using firewalld+nftables
+        </summary>
+        <description>
+          Because of the transitional state of firewalld's new support
+          for nftables, not all iptables features required by libvirt
+          are yet available, so libvirt must continue to use iptables
+          for its own packet filtering rules even when the firewalld
+          backend is set to use nftables. However, due to the way
+          iptables support is implemented in kernels using nftables
+          (iptables rules are converted to nftables rules and
+          processed in a separate hook from the native nftables
+          rules), guest networking was broken on hosts with firewalld
+          configured to use nftables as the backend. This has been
+          fixed by putting libvirt-managed bridges in their own
+          firewalld zone, so that guest traffic can be forwarded
+          beyond the host and host services can be exposed to guests
+          on the virtual network without opening up those same
+          services to the rest of the physical network. This means
+          that host access from virtual machines is no longer
+          controlled by the firewalld default zone (usually "public"),
+          but rather by the new firewalld zone called "libvirt"
+          (unless configured otherwise using the new zone
+          attribute of the network bridge element).
+        </description>
+      </change>
+      <change>
+        <summary>
+          qemu: Fix i6300esb watchdog hotplug on Q35
+        </summary>
+        <description>
+          Ensure that libvirt allocates a PCI address for the device so
+          that QEMU did not default to an address that would not allow
+          for device hotplug.
+        </description>
+      </change>
+      <change>
+        <summary>
+          lxc: Don't reboot host on virDomainReboot
+        </summary>
+        <description>
+          If the container is really a simple one (init is just bash and
+          the whole root is passed through) then virDomainReboot and
+          virDomainShutdown would reboot or shutdown the host. The
+          solution is to use different method to reboot or shutdown the
+          container in that case (e.g. signal).
+        </description>
+      </change>
+      <change>
+        <summary>
+          rpc: Various stream fixes
+        </summary>
+        <description>
+          One particular race was fixed, one locking problem and error
+          reporting from streams was made better.
+        </description>
+      </change>
+      <change>
+        <summary>
+          qemu: Fix guestfwd hotplug/hotunplug
+        </summary>
+        <description>
+          Fixed the generation of the guestfwd hotplug/unplug command
+          sent to QEMU to match the syntax used when creating the
+          initial command line.
+        </description>
+      </change>
+      <change>
+        <summary>
+          qemu: Forbid CDROMs on virtio bus
+        </summary>
+        <description>
+          Attempting to create an empty virtio-blk drive or attempting
+          to eject it results into an error.  Forbid configurations
+          where users would attempt to use CDROMs in virtio bus.
+        </description>
+      </change>
+      <change>
+        <summary>
+          qemu: Use 'raw' for 'volume' disks without format
+        </summary>
+        <description>
+          Storage pools might want to specify format of the image when
+          translating the volume thus libvirt can't add any default
+          format when parsing the XML. Add an explicit format when
+          starting the VM and format is not present neither by user
+          specifying it nor by the storage pool translation function.
+        </description>
+      </change>
+      <change>
+        <summary>
+          qemu: Assume 'raw' default storage format also for network storage
+        </summary>
+        <description>
+          Post parse callback adds the 'raw' type only for local files.
+          Remote files can also have backing store (even local) so we
+          should do this also for network backed storage.
+        </description>
+      </change>
+      <change>
+        <summary>
+          qemu: Fix block job progress reporting and advocate for READY event
+        </summary>
+        <description>
+          In some cases QEMU can get to 100% and still not reach the
+          synchronised phase. Initiating a pivot in that case will fail.
+          Therefore it is strongly advised to wait for
+          <code>VIR_DOMAIN_BLOCK_JOB_READY</code> event which does not
+          suffer from this problem.
+        </description>
+      </change>
+      <change>
+        <summary>
+          qemu: Don't format image properties for empty drive
+        </summary>
+        <description>
+          If a <code>-drive</code> has no image, then formatting
+          attributes such as cache, readonly, etc. would cause errors to
+          be reported from QEMU. This was fixed by not supplying the
+          attributes for devices without an image.
+        </description>
+      </change>
+      <change>
+        <summary>
+          External snapshot metadata redefinition is fixed
+        </summary>
+        <description>
+          Attempting to use VIR_DOMAIN_SNAPSHOT_CREATE_REDEFINE to
+          reinstate the metadata describing an external snapshot
+          created earlier for an offline domain no longer fails.
+        </description>
+      </change>
+    </section>
+  </release>
+  <release version="v5.0.0" date="2019-01-15">
+    <section title="New features">
+      <change>
+        <summary>
+          Xen: Add support for openvswitch
+        </summary>
+        <description>
+          The libxl driver now supports virtual interfaces that connect to
+          an openvswitch bridge, including interfaces with VLAN tagging and
+          trunking configuration.
+        </description>
+      </change>
+      <change>
+        <summary>
+          qemu: Report whether KVM nesting is available
+        </summary>
+        <description>
+          Running nested KVM guests requires specific configuration steps to
+          be performed on the host; libvirt will now report in the host
+          capabilities whether KVM nesting support is available.
+        </description>
+      </change>
+    </section>
+    <section title="Removed features">
+      <change>
+        <summary>
+          Drop UML driver
+        </summary>
+        <description>
+          The UML driver was unmaintained and not tested for
+          quite some time now. Worse, there is a bug that causes
+          it to deadlock on some very basic operations (e.g.
+          dumping domain XML). These facts make us believe no one
+          uses it.
+        </description>
+      </change>
+    </section>
+    <section title="Improvements">
+      <change>
+        <summary>
+          qemu: Add support for ARMv6l guests
+        </summary>
+      </change>
+      <change>
+        <summary>
+          Support more NVDIMM configuration options
+        </summary>
+        <description>
+          Introduce more configuration options. For the source element, add
+          the 'alignsize' and 'pmem' subelements. For the target element, add
+          the 'readonly' subelement.
+        </description>
+      </change>
+      <change>
+        <summary>
+          cpu: Add support for "stibp" x86_64 feature
+        </summary>
+        <description>
+          Add cpu flag stibp (Single Thread Indirect Branch Predictors) to
+          prevent indirect branch predictions from being controlled by the
+          sibling Hyperthread.
+        </description>
+      </change>
+      <change>
+        <summary>
+          libxl: Handle external domain destroy
+        </summary>
+        <description>
+          Historically, if a domain was destroyed using <code>xl</code>
+          rather than through libvirt APIs, libvirt would not be aware of
+          the fact and keep considering it as running. This is no longer the
+          case.
+        </description>
+      </change>
+      <change>
+        <summary>
+          Start selecting the first available DRI device for OpenGL operations
+        </summary>
+        <description>
+          If OpenGL support is needed (either with SPICE gl enabled or with
+          egl-headless), libvirt is now able to pick the first available DRI
+          device for the job. At the same time, this improvement is also a
+          bugfix as it prevents permission-related issues with regards to our
+          mount namespaces and the default DRI render node's permissions which
+          would normally prevent QEMU from accessing such a device.
+        </description>
+      </change>
+      <change>
+        <summary>
+          qemu: Add support for postcopy-requests migration statistics
+        </summary>
+        <description>
+          The <code>virDomainJobInfo</code> can get number page requests
+          received from the destination host during post-copy migration.
+        </description>
+      </change>
+    </section>
+    <section title="Bug fixes">
+      <change>
+        <summary>
+          lxc: Don't forbid interfaces with type=direct
+        </summary>
+        <description>
+          Such interfaces are supported by lxc and should be allowed.
+        </description>
+      </change>
+      <change>
+        <summary>
+          qemu: Fully clean up RNG devices on detach
+        </summary>
+        <description>
+          Some RNG device types, such as those using EGD, might need extra
+          clean up on the host in addition to removing the guest-side device.
+        </description>
+      </change>
+    </section>
+  </release>
+  <release version="v4.10.0" date="2018-12-03">
+    <section title="New features">
+      <change>
+        <summary>
+          qemu: Add Hyper-V PV IPI and Enlightened VMCS support
+        </summary>
+        <description>
+          The QEMU driver now has support for Hyper-V PV IPI and Enlightened VMCS
+          for Windows and Hyper-V guests.
+        </description>
+      </change>
+      <change>
+        <summary>
+          qemu: Added support for PCI devices on S390
+        </summary>
+        <description>
+          PCI addresses can now include the new zpci element which contains
+          uid (user-defined identifier) and fid (PCI function identifier)
+          attributes and makes the corresponding devices usable by S390
+          guests.
+        </description>
+      </change>
+      <change>
+        <summary>
+          Support changing IOThread polling parameters for a live guest
+        </summary>
+        <description>
+          Introduced virDomainSetIOThreadParams which allows dynamically
+          setting the IOThread polling parameters used by QEMU to manage
+          the thread polling interval and the algorithm for growth or
+          shrink of the polling time. The values only affect a running
+          guest with IOThreads. The guest's IOThread polling values can
+          be viewed via the domain statistics.
+        </description>
+      </change>
+      <change>
+        <summary>
+          Xen: Add support for PVH
+        </summary>
+        <description>
+          The libxl driver now supports Xen's PVH virtual machine type.
+          PVH machines are enabled with the new "xenpvh" OS type, e.g.
+          <code>&lt;os&gt;&lt;type&gt;xenpvh&lt;/type&gt;&lt;/os&gt;</code>
+        </description>
+      </change>
+      <change>
+        <summary>
+          qemu: Added support for CMT (Cache Monitoring Technology)
+        </summary>
+        <description>
+          Introduced cache monitoring using the <code>monitor</code>
+          element in <code>cachetune</code> for vCPU threads. Added
+          interfaces to get and display the cache utilization statistics
+          through the command 'virsh domstats' via the
+          virConnectGetAllDomainStats API.
+        </description>
+      </change>
+      <change>
+        <summary>
+          qemu: Add support for nested HV for pSeries guests
+        </summary>
+        <description>
+          Nested HV support makes it possible to run nested (L2) guests
+          with minimal performance penalty when compared to regular (L1)
+          guests on ppc64 hardware.
+        </description>
+      </change>
+    </section>
+    <section title="Improvements">
+    </section>
+    <section title="Bug fixes">
+      <change>
+        <summary>
+          Xen: Handle soft reset shutdown event
+        </summary>
+        <description>
+          The pvops Linux kernel uses soft reset to handle the crash
+          machine operation. The libxl driver now supports the soft
+          reset shutdown event, allowing proper crash handling of
+          pvops-based HVM domains.
+        </description>
+      </change>
+    </section>
+  </release>
+  <release version="v4.9.0" date="2018-11-04">
+    <section title="New features">
+      <change>
+        <summary>
+          util: Add cgroup v2 support
+        </summary>
+        <description>
+          cgroup v2 support has been implemented in libvirt, with both
+          "unified" (v2 only) and "hybrid" (v2 + v1) setups being usable;
+          existing "legacy" (v1 only) setups will keep working.
+        </description>
+      </change>
       <change>
         <summary>
           qemu: Add vfio AP support
@@ -46,8 +562,47 @@
       </change>
     </section>
     <section title="Improvements">
+      <change>
+        <summary>
+          rpc: Make 'genprotocol' output reproducible
+        </summary>
+        <description>
+          This is another step towards making libvirt builds fully
+          reproducible.
+        </description>
+      </change>
     </section>
     <section title="Bug fixes">
+      <change>
+        <summary>
+          security: Fix permissions for UNIX sockets
+        </summary>
+        <description>
+          Since 4.5.0, libvirt is using FD passing to hand sockets over to
+          QEMU, which in theory removes the need for them to be accessible by
+          the user under which the QEMU process is running; however, other
+          processes such as vdsm need to access the sockets as well, which
+          means adjusting permissions is still necessary.
+        </description>
+      </change>
+      <change>
+        <summary>
+          cpu_map: Add Icelake model definitions
+        </summary>
+        <description>
+          These CPU models will be available in the upcoming 3.1.0 QEMU
+          release.
+        </description>
+      </change>
+      <change>
+        <summary>
+          util: Properly parse URIs with missing trailing slash
+        </summary>
+        <description>
+          Some storage URIs were not parsed correctly, in which case libvirt
+          ended up emitting XML that it would then refuse to parse back.
+        </description>
+      </change>
     </section>
   </release>
   <release version="v4.8.0" date="2018-10-01">

docs/reformat-news.py

@@ -17,9 +17,6 @@
 # You should have received a copy of the GNU Lesser General Public
 # License along with this library.  If not, see
 # <http://www.gnu.org/licenses/>.
-#
-# Authors:
-#     Andrea Bolognani <abologna@redhat.com>
 
 from __future__ import print_function
 

docs/schemas/basictypes.rng

@@ -65,6 +65,17 @@
       </data>
     </choice>
   </define>
+  <define name="uint32">
+    <choice>
+      <data type="string">
+        <param name="pattern">(0x)?[0-9a-fA-F]{1,8}</param>
+      </data>
+      <data type="unsignedInt">
+        <param name="minInclusive">0</param>
+        <param name="maxInclusive">4294967295</param>
+      </data>
+    </choice>
+  </define>
 
   <define name="UUID">
     <choice>
@@ -111,6 +122,22 @@
       </attribute>
     </optional>
   </define>
+  <define name="zpciaddress">
+    <optional>
+      <element name="zpci">
+        <optional>
+          <attribute name="uid">
+            <ref name="uint16"/>
+          </attribute>
+        </optional>
+        <optional>
+          <attribute name="fid">
+            <ref name="uint32"/>
+          </attribute>
+        </optional>
+      </element>
+    </optional>
+  </define>
 
   <!-- a 6 byte MAC address in ASCII-hex format, eg "12:34:56:78:9A:BC" -->
   <!-- The lowest bit of the 1st byte is the "multicast" bit. a         -->
@@ -252,6 +279,12 @@
     </data>
   </define>
 
+  <define name="zoneName">
+    <data type="string">
+      <param name="pattern">[a-zA-Z0-9_\-]+</param>
+    </data>
+  </define>
+
   <define name="filePath">
     <data type="string">
       <param name="pattern">.+</param>
@@ -379,6 +412,7 @@
     <choice>
       <value>aarch64</value>
       <value>alpha</value>
+      <value>armv6l</value>
       <value>armv7l</value>
       <value>cris</value>
       <value>i686</value>

docs/schemas/capability.rng

@@ -412,7 +412,7 @@
                                   but is also used by phyp driver -->
         <value>hvm</value> <!-- unmodified OS -->
         <value>exe</value> <!-- For container based virt -->
-        <value>uml</value> <!-- user mode linux -->
+        <value>uml</value> <!-- user mode linux; NOT USED ANYMORE -->
       </choice>
     </element>
   </define>
@@ -484,7 +484,7 @@
           <value>kqemu</value>
           <value>kvm</value>
           <value>xen</value>
-          <value>uml</value>
+          <value>uml</value> <!-- NOT USED ANYMORE -->
           <value>lxc</value>
           <value>openvz</value>
           <value>test</value>

docs/schemas/domaincommon.rng

@@ -81,6 +81,9 @@
         <optional>
           <ref name='launchSecurity'/>
         </optional>
+        <optional>
+          <ref name='bhyvecmdline'/>
+        </optional>
       </interleave>
     </element>
   </define>
@@ -204,7 +207,7 @@
         <value>kvm</value>
         <value>xen</value>
         <value>lxc</value>
-        <value>uml</value>
+        <value>uml</value> <!-- NOT USED ANYMORE -->
         <value>openvz</value>
         <value>test</value>
         <value>vmware</value>
@@ -341,12 +344,14 @@
           <choice>
             <value>xenpv</value>
             <value>xenfv</value>
+            <value>xenpvh</value>
           </choice>
         </attribute>
       </optional>
       <choice>
         <value>xen</value>
         <value>linux</value>
+        <value>xenpvh</value>
       </choice>
     </element>
   </define>
@@ -655,6 +660,7 @@
                   <choice>
                     <value>file</value>
                     <value>anonymous</value>
+                    <value>memfd</value>
                   </choice>
                 </attribute>
               </element>
@@ -956,7 +962,7 @@
             <attribute name="vcpus">
               <ref name='cpuset'/>
             </attribute>
-            <oneOrMore>
+            <zeroOrMore>
               <element name="cache">
                 <attribute name="id">
                   <ref name='unsignedInt'/>
@@ -980,7 +986,17 @@
                   </attribute>
                 </optional>
               </element>
-            </oneOrMore>
+            </zeroOrMore>
+            <zeroOrMore>
+              <element name="monitor">
+                <attribute name="level">
+                  <ref name='unsignedInt'/>
+                </attribute>
+                <attribute name="vcpus">
+                  <ref name='cpuset'/>
+                </attribute>
+              </element>
+            </zeroOrMore>
           </element>
         </zeroOrMore>
         <zeroOrMore>
@@ -1894,7 +1910,7 @@
             <value>virtio</value>
             <value>xen</value>
             <value>usb</value>
-            <value>uml</value>
+            <value>uml</value> <!-- NOT USED ANYMORE -->
             <value>sata</value>
             <value>sd</value>
           </choice>
@@ -2752,7 +2768,7 @@
                         <ref name="usbAddr"/>
                       </attribute>
                       <attribute name="device">
-                        <ref name="usbPort"/>
+                        <ref name="usbAddr"/>
                       </attribute>
                     </group>
                   </choice>
@@ -3405,9 +3421,20 @@
             </attribute>
           </optional>
         </group>
-        <attribute name="type">
-          <value>egl-headless</value>
-        </attribute>
+        <group>
+          <attribute name="type">
+            <value>egl-headless</value>
+          </attribute>
+          <optional>
+            <element name="gl">
+              <optional>
+                <attribute name="rendernode">
+                  <ref name="absFilePath"/>
+                </attribute>
+              </optional>
+            </element>
+          </optional>
+        </group>
       </choice>
     </element>
   </define>
@@ -3701,7 +3728,7 @@
       <choice>
         <value>xen</value>
         <value>serial</value>
-        <value>uml</value>
+        <value>uml</value> <!-- NOT USED ANYMORE -->
         <value>virtio</value>
         <value>lxc</value>
         <value>openvz</value>
@@ -4685,7 +4712,7 @@
         <ref name="usbAddr"/>
       </attribute>
       <attribute name="device">
-        <ref name="usbPort"/>
+        <ref name="usbAddr"/>
       </attribute>
     </element>
   </define>
@@ -4965,6 +4992,14 @@
               <ref name="featurestate"/>
             </element>
           </optional>
+          <optional>
+            <element name="nested-hv">
+              <ref name="featurestate"/>
+            </element>
+          </optional>
+          <optional>
+            <ref name="msrs"/>
+          </optional>
         </interleave>
       </element>
     </optional>
@@ -5213,6 +5248,17 @@
     </element>
   </define>
 
+  <define name="msrs">
+    <element name="msrs">
+      <attribute name="unknown">
+        <choice>
+          <value>ignore</value>
+          <value>fault</value>
+        </choice>
+      </attribute>
+    </element>
+  </define>
+
   <define name="address">
     <element name="address">
       <choice>
@@ -5221,6 +5267,7 @@
             <value>pci</value>
           </attribute>
           <ref name="pciaddress"/>
+          <ref name="zpciaddress"/>
         </group>
         <group>
           <attribute name="type">
@@ -5354,9 +5401,21 @@
           </interleave>
         </group>
         <group>
-          <element name="path">
-            <ref name="absFilePath"/>
-          </element>
+          <interleave>
+            <element name="path">
+              <ref name="absFilePath"/>
+            </element>
+            <optional>
+              <element name="alignsize">
+                <ref name="scaledInteger"/>
+              </element>
+            </optional>
+            <optional>
+              <element name="pmem">
+                <empty/>
+              </element>
+            </optional>
+          </interleave>
         </group>
       </choice>
     </element>
@@ -5380,6 +5439,11 @@
             </element>
           </element>
         </optional>
+        <optional>
+          <element name="readonly">
+            <empty/>
+          </element>
+        </optional>
       </interleave>
     </element>
   </define>
@@ -5451,6 +5515,8 @@
       <attribute name="iommu">
         <ref name="virOnOff"/>
       </attribute>
+    </optional>
+    <optional>
       <attribute name="ats">
         <ref name="virOnOff"/>
       </attribute>
@@ -5769,6 +5835,16 @@
             <ref name="featurestate"/>
           </element>
         </optional>
+        <optional>
+          <element name="ipi">
+            <ref name="featurestate"/>
+          </element>
+        </optional>
+        <optional>
+          <element name="evmcs">
+            <ref name="featurestate"/>
+          </element>
+        </optional>
       </interleave>
     </element>
   </define>
@@ -6068,6 +6144,20 @@
     </element>
   </define>
 
+  <!--
+       Optional hypervisor extensions in their own namespace:
+         Bhyve
+    -->
+  <define name="bhyvecmdline">
+    <element name="commandline" ns="http://libvirt.org/schemas/domain/bhyve/1.0">
+      <zeroOrMore>
+        <element name="arg">
+          <attribute name='value'/>
+        </element>
+      </zeroOrMore>
+    </element>
+  </define>
+
   <!--
        Type library
     -->

docs/schemas/network.rng

@@ -58,6 +58,12 @@
               </attribute>
             </optional>
 
+            <optional>
+              <attribute name="zone">
+                <ref name="zoneName"/>
+              </attribute>
+            </optional>
+
             <optional>
               <attribute name="stp">
                 <ref name="virOnOff"/>

docs/schemas/storagecommon.rng

@@ -24,9 +24,7 @@
         </choice>
       </attribute>
       <interleave>
-        <zeroOrMore>
-          <ref name='secret'/>
-        </zeroOrMore>
+        <ref name='secret'/>
         <optional>
           <element name='cipher'>
             <ref name='keycipher'/>

docs/schemas/storagepool.rng

@@ -52,6 +52,9 @@
       <ref name='sourcefs'/>
       <ref name='target'/>
     </interleave>
+    <optional>
+      <ref name='fs_mount_opts'/>
+    </optional>
   </define>
 
   <define name='poolnetfs'>
@@ -64,6 +67,9 @@
       <ref name='sourcenetfs'/>
       <ref name='target'/>
     </interleave>
+    <optional>
+      <ref name='fs_mount_opts'/>
+    </optional>
   </define>
 
   <define name='poollogical'>
@@ -150,6 +156,9 @@
       <ref name='sizing'/>
       <ref name='sourcerbd'/>
     </interleave>
+    <optional>
+      <ref name='rbd_config_opts'/>
+    </optional>
   </define>
 
   <define name='poolsheepdog'>
@@ -531,6 +540,13 @@
             <ref name='sourceinfohost'/>
             <ref name='sourceinfodir'/>
             <ref name='sourcefmtnetfs'/>
+            <optional>
+              <element name='protocol'>
+                <attribute name='ver'>
+                  <ref name='unsignedInt'/>
+                </attribute>
+              </element>
+            </optional>
             <optional>
               <ref name='sourceinfovendor'/>
             </optional>
@@ -675,4 +691,41 @@
     </data>
   </define>
 
+  <!--
+       Optional storage pool extensions in their own namespace:
+         "fs" or "netfs"
+    -->
+
+  <define name="fs_mount_opts">
+    <element name="mount_opts" ns="http://libvirt.org/schemas/storagepool/fs/1.0">
+      <zeroOrMore>
+        <element name="option">
+          <attribute name='name'>
+            <text/>
+          </attribute>
+        </element>
+      </zeroOrMore>
+    </element>
+  </define>
+
+  <!--
+       Optional storage pool extensions in their own namespace:
+         RBD
+    -->
+
+  <define name="rbd_config_opts">
+    <element name="config_opts" ns="http://libvirt.org/schemas/storagepool/rbd/1.0">
+      <zeroOrMore>
+        <element name="option">
+          <attribute name='name'>
+            <text/>
+          </attribute>
+          <attribute name='value'>
+            <text/>
+          </attribute>
+        </element>
+      </zeroOrMore>
+    </element>
+  </define>
+
 </grammar>

docs/storage.html.in

@@ -437,9 +437,9 @@
 
     <h2><a id="StorageBackendISCSIDirect">iSCSI direct pool</a></h2>
     <p>
-      This is a variant of the iSCSI pool. Instead of unsing iscsiadm, it uses
+      This is a variant of the iSCSI pool. Instead of using iscsiadm, it uses
       libiscsi.
-      It require a host, a path which is the target iqn and an initiator iqn.
+      It requires a host, a path which is the target IQN, and an initiator IQN.
     </p>
 
     <h3>Example pool input</h3>
@@ -457,12 +457,12 @@
 
     <h3>Valid pool format types</h3>
     <p>
-      The iSCSI volume pool does not use the pool format type element.
+      The iSCSI direct volume pool does not use the pool format type element.
     </p>
 
     <h3>Valid volume format types</h3>
     <p>
-      The iSCSI volume pool does not use the volume format type element.
+      The iSCSI direct volume pool does not use the volume format type element.
     </p>
 
     <h2><a id="StorageBackendSCSI">SCSI pool</a></h2>

examples/Makefile.am

@@ -19,12 +19,6 @@
 FILTERS = $(wildcard $(srcdir)/xml/nwfilter/*.xml)
 
 EXTRA_DIST = \
-	apparmor/TEMPLATE.qemu \
-	apparmor/TEMPLATE.lxc \
-	apparmor/libvirt-qemu \
-	apparmor/libvirt-lxc \
-	apparmor/usr.lib.libvirt.virt-aa-helper \
-	apparmor/usr.sbin.libvirtd \
 	lxcconvert/virt-lxc-convert \
 	polkit/libvirt-acl.rules \
 	$(wildcard $(srcdir)/systemtap/*.stp) \
@@ -33,10 +27,10 @@ EXTRA_DIST = \
 	$(wildcard $(srcdir)/xml/test/*.xml)
 
 
-INCLUDES = -I$(top_builddir)/include -I$(top_srcdir)/include -I$(top_srcdir) \
-	-I$(top_builddir)/gnulib/lib -I$(top_srcdir)/gnulib/lib
+AM_CPPFLAGS = \
+	-I$(top_builddir)/include -I$(top_srcdir)/include -I$(top_srcdir)
 LDADD = $(STATIC_BINARIES) $(WARN_CFLAGS) $(COVERAGE_LDFLAGS) \
-	$(top_builddir)/src/libvirt.la $(top_builddir)/gnulib/lib/libgnu.la \
+	$(top_builddir)/src/libvirt.la \
 	$(top_builddir)/src/libvirt-admin.la
 
 noinst_PROGRAMS=dominfo/info1 dommigrate/dommigrate domsuspend/suspend \
@@ -70,36 +64,6 @@ admin_logging_SOURCES = admin/logging.c
 INSTALL_DATA_LOCAL =
 UNINSTALL_LOCAL =
 
-if WITH_APPARMOR_PROFILES
-apparmordir = $(sysconfdir)/apparmor.d/
-apparmor_DATA = \
-	apparmor/usr.lib.libvirt.virt-aa-helper \
-	apparmor/usr.sbin.libvirtd \
-	$(NULL)
-
-abstractionsdir = $(apparmordir)/abstractions
-abstractions_DATA = \
-	apparmor/libvirt-qemu \
-	apparmor/libvirt-lxc \
-	$(NULL)
-
-templatesdir = $(apparmordir)/libvirt
-templates_DATA = \
-	apparmor/TEMPLATE.qemu \
-	apparmor/TEMPLATE.lxc \
-	$(NULL)
-
-APPARMOR_LOCAL_DIR = "$(DESTDIR)$(apparmordir)/local"
-install-apparmor-local:
-	$(MKDIR_P) "$(APPARMOR_LOCAL_DIR)"
-	echo "# Site-specific additions and overrides for \
-		'usr.lib.libvirt.virt-aa-helper'" \
-		>$(APPARMOR_LOCAL_DIR)/usr.lib.libvirt.virt-aa-helper
-
-INSTALL_DATA_LOCAL += install-apparmor-local
-UNINSTALL_LOCAL += uninstall-apparmor-local
-endif WITH_APPARMOR_PROFILES
-
 if WITH_NWFILTER
 NWFILTER_DIR = "$(DESTDIR)$(sysconfdir)/libvirt/nwfilter"
 

examples/admin/client_close.c

@@ -1,7 +1,7 @@
-#include<stdio.h>
-#include<stdlib.h>
-#include<libvirt/libvirt.h>
-#include<libvirt/libvirt-admin.h>
+#include <stdio.h>
+#include <stdlib.h>
+#include <libvirt/libvirt.h>
+#include <libvirt/libvirt-admin.h>
 
 int main(void)
 {

examples/admin/client_info.c

@@ -1,9 +1,9 @@
 #define _GNU_SOURCE
-#include<stdio.h>
-#include<stdlib.h>
-#include<time.h>
-#include<string.h>
-#include<libvirt/libvirt-admin.h>
+#include <stdio.h>
+#include <stdlib.h>
+#include <time.h>
+#include <string.h>
+#include <libvirt/libvirt-admin.h>
 
 static const char *
 exampleTransportToString(int transport)
@@ -30,9 +30,13 @@ exampleGetTimeStr(time_t then)
 {
     char *ret = NULL;
     struct tm timeinfo;
+    struct tm *timeinfop;
 
-    if (!localtime_r(&then, &timeinfo))
+    /* localtime_r() is smarter, but since mingw lacks it and this
+     * example is single-threaded, we can get away with localtime */
+    if (!(timeinfop = localtime(&then)))
         return NULL;
+    timeinfo = *timeinfop;
 
     if (!(ret = calloc(64, sizeof(char))))
         return NULL;

examples/admin/client_limits.c

@@ -1,6 +1,6 @@
-#include<stdio.h>
-#include<stdlib.h>
-#include<libvirt/libvirt-admin.h>
+#include <stdio.h>
+#include <stdlib.h>
+#include <libvirt/libvirt-admin.h>
 
 int main(int argc, char **argv)
 {

examples/admin/list_clients.c

@@ -1,7 +1,7 @@
-#include<stdio.h>
-#include<stdlib.h>
-#include<time.h>
-#include<libvirt/libvirt-admin.h>
+#include <stdio.h>
+#include <stdlib.h>
+#include <time.h>
+#include <libvirt/libvirt-admin.h>
 
 static const char *
 exampleTransportToString(int transport)
@@ -28,9 +28,13 @@ exampleGetTimeStr(time_t then)
 {
     char *ret = NULL;
     struct tm timeinfo;
+    struct tm *timeinfop;
 
-    if (!localtime_r(&then, &timeinfo))
+    /* localtime_r() is smarter, but since mingw lacks it and this
+     * example is single-threaded, we can get away with localtime */
+    if (!(timeinfop = localtime(&then)))
         return NULL;
+    timeinfo = *timeinfop;
 
     if (!(ret = calloc(64, sizeof(char))))
         return NULL;

examples/admin/list_servers.c

@@ -1,6 +1,6 @@
-#include<stdio.h>
-#include<stdlib.h>
-#include<libvirt/libvirt-admin.h>
+#include <stdio.h>
+#include <stdlib.h>
+#include <libvirt/libvirt-admin.h>
 
 int main(void)
 {

examples/admin/logging.c

@@ -1,11 +1,10 @@
-#include<stdio.h>
-#include<stdlib.h>
-#include<stdbool.h>
+#include <stdio.h>
+#include <stdlib.h>
+#include <stdbool.h>
 
-#include "config.h"
-#include<unistd.h>
-#include<libvirt/libvirt-admin.h>
-#include<libvirt/virterror.h>
+#include <unistd.h>
+#include <libvirt/libvirt-admin.h>
+#include <libvirt/virterror.h>
 
 static void printHelp(const char *argv0)
 {

examples/admin/threadpool_params.c

@@ -1,6 +1,6 @@
-#include<stdio.h>
-#include<stdlib.h>
-#include<libvirt/libvirt-admin.h>
+#include <stdio.h>
+#include <stdlib.h>
+#include <libvirt/libvirt-admin.h>
 
 int main(int argc, char **argv)
 {

examples/dominfo/info1.c

@@ -5,7 +5,6 @@
  *          hypervisor and extract domain information.
  * usage: info1
  * test: info1
- * author: Daniel Veillard
  * copy: see Copyright for the status of this software.
  */
 

examples/dommigrate/dommigrate.c

@@ -18,8 +18,6 @@
  * You should have received a copy of the GNU Lesser General Public
  * License along with this library.  If not, see
  * <http://www.gnu.org/licenses/>.
- *
- * Sahid Orentino Ferdjaoui <sahid.ferdjaoui@cloudwatt.com>
  */
 
 #include <stdio.h>

examples/domsuspend/suspend.c

@@ -17,12 +17,8 @@
  * You should have received a copy of the GNU Lesser General Public
  * License along with this library.  If not, see
  * <http://www.gnu.org/licenses/>.
- *
- * Author: Michal Privoznik <mprivozn@redhat.com>
  */
 
-#include <config.h>
-
 #include <errno.h>
 #include <getopt.h>
 #include <libvirt/libvirt.h>

examples/domtop/domtop.c

@@ -16,12 +16,8 @@
  * You should have received a copy of the GNU Lesser General Public
  * License along with this library.  If not, see
  * <http://www.gnu.org/licenses/>.
- *
- * Author: Michal Privoznik <mprivozn@redhat.com>
  */
 
-#include <config.h>
-
 #include <errno.h>
 #include <getopt.h>
 #include <libvirt/libvirt.h>
@@ -245,7 +241,8 @@ print_cpu_usage(const char *dom_name,
 
         if (delim)
             printf("\t");
-        printf("CPU%zu: %.2lf", cpu + i, usage);
+        /* mingw lacks %zu */
+        printf("CPU%u: %.2lf", (unsigned)(cpu + i), usage);
         delim = true;
     }
 
@@ -269,10 +266,6 @@ do_top(virConnectPtr conn,
     int max_id = 0;
     int nparams = 0, then_nparams = 0, now_nparams = 0;
     virTypedParameterPtr then_params = NULL, now_params = NULL;
-    struct sigaction action_stop;
-
-    memset(&action_stop, 0, sizeof(action_stop));
-    action_stop.sa_handler = stop;
 
     /* Lookup the domain */
     if (!(dom = virDomainLookupByName(conn, dom_name))) {
@@ -298,8 +291,10 @@ do_top(virConnectPtr conn,
         goto cleanup;
     }
 
-    sigaction(SIGTERM, &action_stop, NULL);
-    sigaction(SIGINT, &action_stop, NULL);
+    /* The ideal program would use sigaction to set this handler, but
+     * this way is portable to mingw. */
+    signal(SIGTERM, stop);
+    signal(SIGINT, stop);
 
     run_top = true;
     while (run_top) {

examples/lxcconvert/virt-lxc-convert

@@ -17,7 +17,6 @@
 #  License along with this library.  If not, see
 #  <http://www.gnu.org/licenses/>.
 #
-#  Author: Cedric Bosdonnat <cbosdonnat@suse.com>
 
 handler_cleanup()
 {

examples/object-events/event-test.c

@@ -1,13 +1,9 @@
-#include <config.h>
-
 #include <stdio.h>
 #include <stdlib.h>
 #include <string.h>
 #include <signal.h>
 #include <inttypes.h>
 
-#include <verify.h>
-
 #define VIR_ENUM_SENTINELS
 
 #include <libvirt/libvirt.h>
@@ -17,6 +13,14 @@
 #define STREQ(a, b) (strcmp(a, b) == 0)
 #define NULLSTR(s) ((s) ? (s) : "<null>")
 
+#if (4 < __GNUC__ + (6 <= __GNUC_MINOR__) \
+     && (201112L <= __STDC_VERSION__  || !defined __STRICT_ANSI__) \
+     && !defined __cplusplus)
+# define verify(cond) _Static_assert(cond, "verify (" #cond ")")
+#else
+# define verify(cond)
+#endif
+
 #ifndef ATTRIBUTE_UNUSED
 # define ATTRIBUTE_UNUSED __attribute__((__unused__))
 #endif
@@ -944,10 +948,11 @@ myDomainEventBlockThresholdCallback(virConnectPtr conn ATTRIBUTE_UNUSED,
                                     unsigned long long excess,
                                     void *opaque ATTRIBUTE_UNUSED)
 {
+    /* Casts to uint64_t to work around mingw not knowing %lld */
     printf("%s EVENT: Domain %s(%d) block threshold callback dev '%s'(%s), "
-           "threshold: '%llu', excess: '%llu'",
+           "threshold: '%" PRIu64 "', excess: '%" PRIu64 "'",
            __func__, virDomainGetName(dom), virDomainGetID(dom),
-           dev, NULLSTR(path), threshold, excess);
+           dev, NULLSTR(path), (uint64_t)threshold, (uint64_t)excess);
     return 0;
 }
 
@@ -1142,13 +1147,8 @@ main(int argc, char **argv)
     virConnectPtr dconn = NULL;
     int callback1ret = -1;
     int callback16ret = -1;
-    struct sigaction action_stop;
     size_t i;
 
-    memset(&action_stop, 0, sizeof(action_stop));
-
-    action_stop.sa_handler = stop;
-
     if (argc > 1 && STREQ(argv[1], "--help")) {
         printf("%s uri\n", argv[0]);
         goto cleanup;
@@ -1179,8 +1179,10 @@ main(int argc, char **argv)
         goto cleanup;
     }
 
-    sigaction(SIGTERM, &action_stop, NULL);
-    sigaction(SIGINT, &action_stop, NULL);
+    /* The ideal program would use sigaction to set this handler, but
+     * this way is portable to mingw. */
+    signal(SIGTERM, stop);
+    signal(SIGINT, stop);
 
     printf("Registering event callbacks\n");
 

examples/systemtap/events.stp

@@ -16,7 +16,6 @@
 # License along with this library.  If not, see
 # <http://www.gnu.org/licenses/>.
 #
-# Author: Daniel P. Berrange <berrange@redhat.com>
 #
 # This script will monitor all operation of the libvirt event loop
 # in both client and server. Example output is:

examples/systemtap/lock-debug.stp

@@ -16,7 +16,6 @@
 #
 # Debug RWLock mechanisms as well.
 #
-# Author: Martin Kletzander <mkletzan@redhat.com>
 
 
 global mx_tolock

examples/systemtap/qemu-monitor.stp

@@ -16,7 +16,6 @@
 # License along with this library.  If not, see
 # <http://www.gnu.org/licenses/>.
 #
-# Author: Daniel P. Berrange <berrange@redhat.com>
 #
 # This script will monitor all messages sent/received between libvirt
 # and the QEMU monitor

examples/systemtap/rpc-monitor.stp

@@ -16,7 +16,6 @@
 # License along with this library.  If not, see
 # <http://www.gnu.org/licenses/>.
 #
-# Author: Daniel P. Berrange <berrange@redhat.com>
 #
 # This script will monitor all RPC messages going in/out of libvirtd and
 # any connected clients. Example output:

gnulib/lib/Makefile.am

@@ -27,4 +27,4 @@ noinst_LTLIBRARIES =
 
 include gnulib.mk
 
-INCLUDES = -I$(top_srcdir) $(GETTEXT_CPPFLAGS)
+AM_CPPFLAGS = -I$(top_srcdir)

gnulib/tests/Makefile.am

@@ -18,8 +18,6 @@
 
 include gnulib.mk
 
-INCLUDES = $(GETTEXT_CPPFLAGS)
-
 GNULIB_TESTS0 =
 GNULIB_TESTS1 = $(GNULIB_TESTS)
 if WITH_EXPENSIVE_TESTS

include/libvirt/libvirt-admin.h

@@ -19,12 +19,10 @@
  * You should have received a copy of the GNU Lesser General Public
  * License along with this library.  If not, see
  * <http://www.gnu.org/licenses/>.
- *
- * Author: Martin Kletzander <mkletzan@redhat.com>
  */
 
-#ifndef __VIR_ADMIN_H__
-# define __VIR_ADMIN_H__
+#ifndef LIBVIRT_ADMIN_H
+# define LIBVIRT_ADMIN_H
 
 # ifdef __cplusplus
 extern "C" {
@@ -424,4 +422,4 @@ int virAdmConnectSetLoggingFilters(virAdmConnectPtr conn,
 }
 # endif
 
-#endif /* __VIR_ADMIN_H__ */
+#endif /* LIBVIRT_ADMIN_H */

include/libvirt/libvirt-common.h.in

@@ -3,7 +3,6 @@
  * Summary: common macros and enums for the libvirt and libvirt-admin library
  * Description: Provides common macros and enums needed by both libvirt and
  *              libvirt-admin libraries
- * Author: Erik Skultety <eskultet@redhat.com>
  *
  * Copyright (C) 2015 Red Hat, Inc.
  *

include/libvirt/libvirt-domain-snapshot.h

@@ -2,7 +2,6 @@
  * libvirt-domain-snapshot.h
  * Summary: APIs for management of domain snapshots
  * Description: Provides APIs for the management of domain snapshots
- * Author: Daniel Veillard <veillard@redhat.com>
  *
  * Copyright (C) 2006-2014 Red Hat, Inc.
  *
@@ -21,8 +20,8 @@
  * <http://www.gnu.org/licenses/>.
  */
 
-#ifndef __VIR_LIBVIRT_DOMAIN_SNAPSHOT_H__
-# define __VIR_LIBVIRT_DOMAIN_SNAPSHOT_H__
+#ifndef LIBVIRT_DOMAIN_SNAPSHOT_H
+# define LIBVIRT_DOMAIN_SNAPSHOT_H
 
 # ifndef __VIR_LIBVIRT_H_INCLUDES__
 #  error "Don't include this file directly, only use libvirt/libvirt.h"
@@ -60,7 +59,7 @@ typedef enum {
     VIR_DOMAIN_SNAPSHOT_CREATE_HALT        = (1 << 3), /* Stop running guest
                                                           after snapshot */
     VIR_DOMAIN_SNAPSHOT_CREATE_DISK_ONLY   = (1 << 4), /* disk snapshot, not
-                                                          system checkpoint */
+                                                          full system */
     VIR_DOMAIN_SNAPSHOT_CREATE_REUSE_EXT   = (1 << 5), /* reuse any existing
                                                           external files */
     VIR_DOMAIN_SNAPSHOT_CREATE_QUIESCE     = (1 << 6), /* use guest agent to
@@ -79,6 +78,10 @@ virDomainSnapshotPtr virDomainSnapshotCreateXML(virDomainPtr domain,
                                                 const char *xmlDesc,
                                                 unsigned int flags);
 
+typedef enum {
+    VIR_DOMAIN_SNAPSHOT_XML_SECURE         = VIR_DOMAIN_XML_SECURE, /* dump security sensitive information too */
+} virDomainSnapshotXMLFlags;
+
 /* Dump the XML of a snapshot */
 char *virDomainSnapshotGetXMLDesc(virDomainSnapshotPtr snapshot,
                                   unsigned int flags);
@@ -211,4 +214,4 @@ int virDomainSnapshotDelete(virDomainSnapshotPtr snapshot,
 int virDomainSnapshotRef(virDomainSnapshotPtr snapshot);
 int virDomainSnapshotFree(virDomainSnapshotPtr snapshot);
 
-#endif /* __VIR_LIBVIRT_DOMAIN_SNAPSHOT_H__ */
+#endif /* LIBVIRT_DOMAIN_SNAPSHOT_H */

include/libvirt/libvirt-domain.h

@@ -2,7 +2,6 @@
  * libvirt-domain.h
  * Summary: APIs for management of domains
  * Description: Provides APIs for the management of domains
- * Author: Daniel Veillard <veillard@redhat.com>
  *
  * Copyright (C) 2006-2015 Red Hat, Inc.
  *
@@ -21,8 +20,8 @@
  * <http://www.gnu.org/licenses/>.
  */
 
-#ifndef __VIR_LIBVIRT_DOMAIN_H__
-# define __VIR_LIBVIRT_DOMAIN_H__
+#ifndef LIBVIRT_DOMAIN_H
+# define LIBVIRT_DOMAIN_H
 
 # ifndef __VIR_LIBVIRT_H_INCLUDES__
 #  error "Don't include this file directly, only use libvirt/libvirt.h"
@@ -145,6 +144,8 @@ typedef enum {
     VIR_DOMAIN_SHUTOFF_FAILED = 6,      /* domain failed to start */
     VIR_DOMAIN_SHUTOFF_FROM_SNAPSHOT = 7, /* restored from a snapshot which was
                                            * taken while domain was shutoff */
+    VIR_DOMAIN_SHUTOFF_DAEMON = 8,      /* daemon decides to kill domain
+                                           during reconnection processing */
 # ifdef VIR_ENUM_SENTINELS
     VIR_DOMAIN_SHUTOFF_LAST
 # endif
@@ -902,6 +903,15 @@ typedef enum {
  */
 # define VIR_MIGRATE_PARAM_BANDWIDTH         "bandwidth"
 
+/**
+ * VIR_MIGRATE_PARAM_BANDWIDTH_POSTCOPY:
+ *
+ * virDomainMigrate* params field: the maximum bandwidth (in MiB/s) that will
+ * be used for post-copy phase of a migration as VIR_TYPED_PARAM_ULLONG. If set
+ * to 0 or omitted, post-copy migration speed will not be limited.
+ */
+# define VIR_MIGRATE_PARAM_BANDWIDTH_POSTCOPY "bandwidth.postcopy"
+
 /**
  * VIR_MIGRATE_PARAM_GRAPHICS_URI:
  *
@@ -1061,6 +1071,12 @@ int virDomainMigrateSetCompressionCache(virDomainPtr domain,
                                         unsigned long long cacheSize,
                                         unsigned int flags);
 
+/* Domain migration speed flags. */
+typedef enum {
+    /* Set or get maximum speed of post-copy migration. */
+    VIR_DOMAIN_MIGRATE_MAX_SPEED_POSTCOPY = (1 << 0),
+} virDomainMigrateMaxSpeedFlags;
+
 int virDomainMigrateSetMaxSpeed(virDomainPtr domain,
                                 unsigned long bandwidth,
                                 unsigned int flags);
@@ -1203,6 +1219,7 @@ int                     virDomainRestoreFlags   (virConnectPtr conn,
                                                  const char *dxml,
                                                  unsigned int flags);
 
+/* See below for virDomainSaveImageXMLFlags */
 char *          virDomainSaveImageGetXMLDesc    (virConnectPtr conn,
                                                  const char *file,
                                                  unsigned int flags);
@@ -1555,6 +1572,10 @@ typedef enum {
     VIR_DOMAIN_XML_MIGRATABLE   = (1 << 3), /* dump XML suitable for migration */
 } virDomainXMLFlags;
 
+typedef enum {
+    VIR_DOMAIN_SAVE_IMAGE_XML_SECURE         = VIR_DOMAIN_XML_SECURE, /* dump security sensitive information too */
+} virDomainSaveImageXMLFlags;
+
 char *                  virDomainGetXMLDesc     (virDomainPtr domain,
                                                  unsigned int flags);
 
@@ -1911,6 +1932,50 @@ int                  virDomainDelIOThread(virDomainPtr domain,
                                           unsigned int iothread_id,
                                           unsigned int flags);
 
+/* IOThread set parameters */
+
+/**
+ * VIR_DOMAIN_IOTHREAD_POLL_MAX_NS:
+ *
+ * The maximum polling time that can be used by polling algorithm in ns.
+ * The polling time starts at 0 (zero) and is the time spent by the guest
+ * to process IOThread data before returning the CPU to the host. The
+ * polling time will be dynamically modified over time based on the
+ * poll_grow and poll_shrink parameters provided. A value set too large
+ * will cause more CPU time to be allocated the guest. A value set too
+ * small will not provide enough cycles for the guest to process data.
+ * The polling interval is not available for statistical purposes.
+ */
+# define VIR_DOMAIN_IOTHREAD_POLL_MAX_NS "poll_max_ns"
+
+/**
+ * VIR_DOMAIN_IOTHREAD_POLL_GROW:
+ *
+ * This provides a value for the dynamic polling adjustment algorithm to
+ * use to grow its polling interval up to the poll_max_ns value. A value
+ * of 0 (zero) allows the hypervisor to choose its own value. The algorithm
+ * to use for adjustment is hypervisor specific.
+ */
+# define VIR_DOMAIN_IOTHREAD_POLL_GROW "poll_grow"
+
+/**
+ * VIR_DOMAIN_IOTHREAD_POLL_SHRINK:
+ *
+ * This provides a value for the dynamic polling adjustment algorithm to
+ * use to shrink its polling interval when the polling interval exceeds
+ * the poll_max_ns value. A value of 0 (zero) allows the hypervisor to
+ * choose its own value. The algorithm to use for adjustment is hypervisor
+ * specific.
+ */
+# define VIR_DOMAIN_IOTHREAD_POLL_SHRINK "poll_shrink"
+
+int                  virDomainSetIOThreadParams(virDomainPtr domain,
+                                                unsigned int iothread_id,
+                                                virTypedParameterPtr params,
+                                                int nparams,
+                                                unsigned int flags);
+
+
 /**
  * VIR_USE_CPU:
  * @cpumap: pointer to a bit map of real CPUs (in 8-bit bytes) (IN/OUT)
@@ -2048,6 +2113,7 @@ typedef enum {
     VIR_DOMAIN_STATS_INTERFACE = (1 << 4), /* return domain interfaces info */
     VIR_DOMAIN_STATS_BLOCK = (1 << 5), /* return domain block info */
     VIR_DOMAIN_STATS_PERF = (1 << 6), /* return domain perf event info */
+    VIR_DOMAIN_STATS_IOTHREAD = (1 << 7), /* return iothread poll info */
 } virDomainStatsTypes;
 
 typedef enum {
@@ -2329,7 +2395,8 @@ int virDomainSetPerfEvents(virDomainPtr dom,
  * Describes various possible block jobs.
  */
 typedef enum {
-    VIR_DOMAIN_BLOCK_JOB_TYPE_UNKNOWN = 0, /* Placeholder */
+    /* Placeholder */
+    VIR_DOMAIN_BLOCK_JOB_TYPE_UNKNOWN = 0,
 
     /* Block Pull (virDomainBlockPull, or virDomainBlockRebase without
      * flags), job ends on completion */
@@ -3376,6 +3443,16 @@ typedef enum {
  */
 # define VIR_DOMAIN_JOB_MEMORY_ITERATION         "memory_iteration"
 
+/**
+ * VIR_DOMAIN_JOB_MEMORY_POSTCOPY_REQS:
+ *
+ * virDomainGetJobStats field: number page requests received from the
+ * destination host during post-copy migration, as VIR_TYPED_PARAM_ULLONG.
+ * This counter is incremented whenever the migrated domain tries to access
+ * a memory page which has not been transferred from the source host yet.
+ */
+# define VIR_DOMAIN_JOB_MEMORY_POSTCOPY_REQS     "memory_postcopy_requests"
+
 /**
  * VIR_DOMAIN_JOB_DISK_TOTAL:
  *
@@ -4793,4 +4870,4 @@ int virDomainGetLaunchSecurityInfo(virDomainPtr domain,
                                    int *nparams,
                                    unsigned int flags);
 
-#endif /* __VIR_LIBVIRT_DOMAIN_H__ */
+#endif /* LIBVIRT_DOMAIN_H */

include/libvirt/libvirt-event.h

@@ -2,7 +2,6 @@
  * libvirt-event.h
  * Summary: APIs for management of events
  * Description: Provides APIs for the management of events
- * Author: Daniel Veillard <veillard@redhat.com>
  *
  * Copyright (C) 2006-2014 Red Hat, Inc.
  *
@@ -21,8 +20,8 @@
  * <http://www.gnu.org/licenses/>.
  */
 
-#ifndef __VIR_LIBVIRT_EVENT_H__
-# define __VIR_LIBVIRT_EVENT_H__
+#ifndef LIBVIRT_EVENT_H
+# define LIBVIRT_EVENT_H
 
 # ifndef __VIR_LIBVIRT_H_INCLUDES__
 #  error "Don't include this file directly, only use libvirt/libvirt.h"
@@ -60,7 +59,7 @@ typedef void (*virEventHandleCallback)(int watch, int fd, int events, void *opaq
  * virEventAddHandleFunc:
  * @fd: file descriptor to listen on
  * @event: bitset of events on which to fire the callback
- * @cb: the callback to be called when an event occurrs
+ * @cb: the callback to be called when an event occurs
  * @opaque: user data to pass to the callback
  * @ff: the callback invoked to free opaque data blob
  *
@@ -187,4 +186,4 @@ void virEventUpdateTimeout(int timer, int frequency);
 int virEventRemoveTimeout(int timer);
 
 
-#endif /* __VIR_LIBVIRT_EVENT_H__ */
+#endif /* LIBVIRT_EVENT_H */

include/libvirt/libvirt-host.h

@@ -2,7 +2,6 @@
  * libvirt-host.h
  * Summary: APIs for management of hosts
  * Description: Provides APIs for the management of hosts
- * Author: Daniel Veillard <veillard@redhat.com>
  *
  * Copyright (C) 2006-2014 Red Hat, Inc.
  *
@@ -21,8 +20,8 @@
  * <http://www.gnu.org/licenses/>.
  */
 
-#ifndef __VIR_LIBVIRT_HOST_H__
-# define __VIR_LIBVIRT_HOST_H__
+#ifndef LIBVIRT_HOST_H
+# define LIBVIRT_HOST_H
 
 # ifndef __VIR_LIBVIRT_H_INCLUDES__
 #  error "Don't include this file directly, only use libvirt/libvirt.h"
@@ -744,4 +743,4 @@ int virNodeAllocPages(virConnectPtr conn,
                       unsigned int flags);
 
 
-#endif /* __VIR_LIBVIRT_HOST_H__ */
+#endif /* LIBVIRT_HOST_H */

include/libvirt/libvirt-interface.h

@@ -2,7 +2,6 @@
  * libvirt-interface.h
  * Summary: APIs for management of interfaces
  * Description: Provides APIs for the management of interfaces
- * Author: Daniel Veillard <veillard@redhat.com>
  *
  * Copyright (C) 2006-2014 Red Hat, Inc.
  *
@@ -21,8 +20,8 @@
  * <http://www.gnu.org/licenses/>.
  */
 
-#ifndef __VIR_LIBVIRT_INTERFACE_H__
-# define __VIR_LIBVIRT_INTERFACE_H__
+#ifndef LIBVIRT_INTERFACE_H
+# define LIBVIRT_INTERFACE_H
 
 # ifndef __VIR_LIBVIRT_H_INCLUDES__
 #  error "Don't include this file directly, only use libvirt/libvirt.h"
@@ -107,4 +106,4 @@ int                     virInterfaceChangeRollback(virConnectPtr conn,
 int virInterfaceIsActive(virInterfacePtr iface);
 
 
-#endif /* __VIR_LIBVIRT_INTERFACE_H__ */
+#endif /* LIBVIRT_INTERFACE_H */

include/libvirt/libvirt-lxc.h

@@ -19,12 +19,10 @@
  * You should have received a copy of the GNU Lesser General Public
  * License along with this library.  If not, see
  * <http://www.gnu.org/licenses/>.
- *
- * Author: Daniel P. Berrange <berrange@redhat.com>
  */
 
-#ifndef __VIR_LXC_H__
-# define __VIR_LXC_H__
+#ifndef LIBVIRT_LXC_H
+# define LIBVIRT_LXC_H
 
 # include <libvirt/libvirt.h>
 
@@ -53,4 +51,4 @@ int virDomainLxcEnterCGroup(virDomainPtr domain,
 }
 # endif
 
-#endif /* __VIR_LXC_H__ */
+#endif /* LIBVIRT_LXC_H */

include/libvirt/libvirt-network.h

@@ -2,7 +2,6 @@
  * libvirt-network.h
  * Summary: APIs for management of networks
  * Description: Provides APIs for the management of networks
- * Author: Daniel Veillard <veillard@redhat.com>
  *
  * Copyright (C) 2006-2014 Red Hat, Inc.
  *
@@ -21,8 +20,8 @@
  * <http://www.gnu.org/licenses/>.
  */
 
-#ifndef __VIR_LIBVIRT_NETWORK_H__
-# define __VIR_LIBVIRT_NETWORK_H__
+#ifndef LIBVIRT_NETWORK_H
+# define LIBVIRT_NETWORK_H
 
 # ifndef __VIR_LIBVIRT_H_INCLUDES__
 #  error "Don't include this file directly, only use libvirt/libvirt.h"
@@ -334,4 +333,4 @@ int virConnectNetworkEventRegisterAny(virConnectPtr conn,
 int virConnectNetworkEventDeregisterAny(virConnectPtr conn,
                                         int callbackID);
 
-#endif /* __VIR_LIBVIRT_NETWORK_H__ */
+#endif /* LIBVIRT_NETWORK_H */

include/libvirt/libvirt-nodedev.h

@@ -2,7 +2,6 @@
  * libvirt-nodedev.h
  * Summary: APIs for management of nodedevs
  * Description: Provides APIs for the management of nodedevs
- * Author: Daniel Veillard <veillard@redhat.com>
  *
  * Copyright (C) 2006-2014 Red Hat, Inc.
  *
@@ -21,8 +20,8 @@
  * <http://www.gnu.org/licenses/>.
  */
 
-#ifndef __VIR_LIBVIRT_NODEDEV_H__
-# define __VIR_LIBVIRT_NODEDEV_H__
+#ifndef LIBVIRT_NODEDEV_H
+# define LIBVIRT_NODEDEV_H
 
 # ifndef __VIR_LIBVIRT_H_INCLUDES__
 #  error "Don't include this file directly, only use libvirt/libvirt.h"
@@ -217,4 +216,4 @@ typedef void (*virConnectNodeDeviceEventLifecycleCallback)(virConnectPtr conn,
                                                            int detail,
                                                            void *opaque);
 
-#endif /* __VIR_LIBVIRT_NODEDEV_H__ */
+#endif /* LIBVIRT_NODEDEV_H */

include/libvirt/libvirt-nwfilter.h

@@ -2,7 +2,6 @@
  * libvirt-nwfilter.h
  * Summary: APIs for management of nwfilters
  * Description: Provides APIs for the management of nwfilters
- * Author: Daniel Veillard <veillard@redhat.com>
  *
  * Copyright (C) 2006-2014 Red Hat, Inc.
  *
@@ -21,8 +20,8 @@
  * <http://www.gnu.org/licenses/>.
  */
 
-#ifndef __VIR_LIBVIRT_NWFILTER_H__
-# define __VIR_LIBVIRT_NWFILTER_H__
+#ifndef LIBVIRT_NWFILTER_H
+# define LIBVIRT_NWFILTER_H
 
 # ifndef __VIR_LIBVIRT_H_INCLUDES__
 #  error "Don't include this file directly, only use libvirt/libvirt.h"
@@ -131,4 +130,4 @@ int                     virNWFilterBindingDelete(virNWFilterBindingPtr binding);
 int                     virNWFilterBindingRef(virNWFilterBindingPtr binding);
 int                     virNWFilterBindingFree(virNWFilterBindingPtr binding);
 
-#endif /* __VIR_LIBVIRT_NWFILTER_H__ */
+#endif /* LIBVIRT_NWFILTER_H */

include/libvirt/libvirt-qemu.h

@@ -19,12 +19,10 @@
  * You should have received a copy of the GNU Lesser General Public
  * License along with this library.  If not, see
  * <http://www.gnu.org/licenses/>.
- *
- * Author: Chris Lalancette <clalance@redhat.com>
  */
 
-#ifndef __VIR_QEMU_H__
-# define __VIR_QEMU_H__
+#ifndef LIBVIRT_QEMU_H
+# define LIBVIRT_QEMU_H
 
 # include <libvirt/libvirt.h>
 
@@ -103,4 +101,4 @@ int virConnectDomainQemuMonitorEventDeregister(virConnectPtr conn,
 }
 # endif
 
-#endif /* __VIR_QEMU_H__ */
+#endif /* LIBVIRT_QEMU_H */

include/libvirt/libvirt-secret.h

@@ -2,7 +2,6 @@
  * libvirt-secret.h
  * Summary: APIs for management of secrets
  * Description: Provides APIs for the management of secrets
- * Author: Daniel Veillard <veillard@redhat.com>
  *
  * Copyright (C) 2006-2014, 2016 Red Hat, Inc.
  *
@@ -21,8 +20,8 @@
  * <http://www.gnu.org/licenses/>.
  */
 
-#ifndef __VIR_LIBVIRT_SECRET_H__
-# define __VIR_LIBVIRT_SECRET_H__
+#ifndef LIBVIRT_SECRET_H
+# define LIBVIRT_SECRET_H
 
 # ifndef __VIR_LIBVIRT_H_INCLUDES__
 #  error "Don't include this file directly, only use libvirt/libvirt.h"
@@ -203,4 +202,4 @@ typedef void (*virConnectSecretEventLifecycleCallback)(virConnectPtr conn,
                                                        void *opaque);
 
 
-#endif /* __VIR_LIBVIRT_SECRET_H__ */
+#endif /* LIBVIRT_SECRET_H */

include/libvirt/libvirt-storage.h

@@ -2,7 +2,6 @@
  * libvirt-storage.h
  * Summary: APIs for management of storage pools and volumes
  * Description: Provides APIs for the management of storage pools and volumes
- * Author: Daniel Veillard <veillard@redhat.com>
  *
  * Copyright (C) 2006-2016 Red Hat, Inc.
  *
@@ -21,8 +20,8 @@
  * <http://www.gnu.org/licenses/>.
  */
 
-#ifndef __VIR_LIBVIRT_STORAGE_H__
-# define __VIR_LIBVIRT_STORAGE_H__
+#ifndef LIBVIRT_STORAGE_H
+# define LIBVIRT_STORAGE_H
 
 # ifndef __VIR_LIBVIRT_H_INCLUDES__
 #  error "Don't include this file directly, only use libvirt/libvirt.h"
@@ -496,4 +495,4 @@ typedef void (*virConnectStoragePoolEventLifecycleCallback)(virConnectPtr conn,
                                                             int detail,
                                                             void *opaque);
 
-#endif /* __VIR_LIBVIRT_STORAGE_H__ */
+#endif /* LIBVIRT_STORAGE_H */

include/libvirt/libvirt-stream.h

@@ -2,7 +2,6 @@
  * libvirt-stream.h
  * Summary: APIs for management of streams
  * Description: Provides APIs for the management of streams
- * Author: Daniel Veillard <veillard@redhat.com>
  *
  * Copyright (C) 2006-2014 Red Hat, Inc.
  *
@@ -21,8 +20,8 @@
  * <http://www.gnu.org/licenses/>.
  */
 
-#ifndef __VIR_LIBVIRT_STREAM_H__
-# define __VIR_LIBVIRT_STREAM_H__
+#ifndef LIBVIRT_STREAM_H
+# define LIBVIRT_STREAM_H
 
 # ifndef __VIR_LIBVIRT_H_INCLUDES__
 #  error "Don't include this file directly, only use libvirt/libvirt.h"
@@ -267,4 +266,4 @@ int virStreamAbort(virStreamPtr st);
 
 int virStreamFree(virStreamPtr st);
 
-#endif /* __VIR_LIBVIRT_STREAM_H__ */
+#endif /* LIBVIRT_STREAM_H */

include/libvirt/libvirt.h

@@ -19,12 +19,10 @@
  * You should have received a copy of the GNU Lesser General Public
  * License along with this library.  If not, see
  * <http://www.gnu.org/licenses/>.
- *
- * Author: Daniel Veillard <veillard@redhat.com>
  */
 
-#ifndef __VIR_VIRLIB_H__
-# define __VIR_VIRLIB_H__
+#ifndef LIBVIRT_H
+# define LIBVIRT_H
 
 # include <sys/types.h>
 
@@ -51,4 +49,4 @@ extern "C" {
 }
 # endif
 
-#endif /* __VIR_VIRLIB_H__ */
+#endif /* LIBVIRT_H */

include/libvirt/virterror.h

@@ -19,12 +19,10 @@
  * You should have received a copy of the GNU Lesser General Public
  * License along with this library.  If not, see
  * <http://www.gnu.org/licenses/>.
- *
- * Author: Daniel Veillard <veillard@redhat.com>
  */
 
-#ifndef __VIR_VIRERR_H__
-# define __VIR_VIRERR_H__
+#ifndef LIBVIRT_VIRTERROR_H
+# define LIBVIRT_VIRTERROR_H
 
 # include <libvirt/libvirt.h>
 
@@ -76,7 +74,7 @@ typedef enum {
     VIR_FROM_NETWORK = 19,      /* Error from network config */
 
     VIR_FROM_DOMAIN = 20,       /* Error from domain config */
-    VIR_FROM_UML = 21,          /* Error at the UML driver */
+    VIR_FROM_UML = 21,          /* Error at the UML driver; unused since 5.0.0 */
     VIR_FROM_NODEDEV = 22,      /* Error from node device monitor */
     VIR_FROM_XEN_INOTIFY = 23,  /* Error from xen inotify layer */
     VIR_FROM_SECURITY = 24,     /* Error from security framework */
@@ -133,6 +131,7 @@ typedef enum {
     VIR_FROM_PERF = 65,         /* Error from perf */
     VIR_FROM_LIBSSH = 66,       /* Error from libssh connection transport */
     VIR_FROM_RESCTRL = 67,      /* Error from resource control */
+    VIR_FROM_FIREWALLD = 68,    /* Error from firewalld */
 
 # ifdef VIR_ENUM_SENTINELS
     VIR_ERR_DOMAIN_LAST
@@ -323,6 +322,11 @@ typedef enum {
     VIR_ERR_DEVICE_MISSING = 99,        /* fail to find the desired device */
     VIR_ERR_INVALID_NWFILTER_BINDING = 100,  /* invalid nwfilter binding */
     VIR_ERR_NO_NWFILTER_BINDING = 101,  /* no nwfilter binding */
+
+# ifdef VIR_ENUM_SENTINELS
+    VIR_ERR_NUMBER_LAST
+# endif
+
 } virErrorNumber;
 
 /**
@@ -366,4 +370,4 @@ int                     virConnCopyLastError    (virConnectPtr conn,
 }
 # endif
 
-#endif /* __VIR_VIRERR_H__ */
+#endif /* LIBVIRT_VIRTERROR_H */

libvirt.spec.in

@@ -4,7 +4,7 @@
 # that's still supported by the vendor. It may work on other distros
 # or versions, but no effort will be made to ensure that going forward.
 %define min_rhel 7
-%define min_fedora 27
+%define min_fedora 28
 
 %if (0%{?fedora} && 0%{?fedora} >= %{min_fedora}) || (0%{?rhel} && 0%{?rhel} >= %{min_rhel})
     %define supported_platform 1
@@ -20,7 +20,6 @@
 # The hypervisor drivers that run in libvirtd
 %define with_qemu          0%{!?_without_qemu:1}
 %define with_lxc           0%{!?_without_lxc:1}
-%define with_uml           0%{!?_without_uml:1}
 %define with_libxl         0%{!?_without_libxl:1}
 %define with_vbox          0%{!?_without_vbox:1}
 
@@ -72,7 +71,7 @@
 %endif
 
 # We need a recent enough libiscsi (>= 1.18.0)
-%if 0%{?fedora} >= 28 || 0%{?rhel} > 7
+%if 0%{?fedora} || 0%{?rhel} > 7
     %define with_storage_iscsi_direct 0%{!?_without_storage_iscsi_direct:1}
 %else
     %define with_storage_iscsi_direct 0
@@ -83,6 +82,7 @@
 %define with_sanlock       0%{!?_without_sanlock:0}
 %define with_numad         0%{!?_without_numad:0}
 %define with_firewalld     0%{!?_without_firewalld:0}
+%define with_firewalld_zone 0%{!?_without_firewalld_zone:0}
 %define with_libssh2       0%{!?_without_libssh2:0}
 %define with_wireshark     0%{!?_without_wireshark:0}
 %define with_libssh        0%{!?_without_libssh:0}
@@ -110,14 +110,19 @@
     %define with_storage_zfs 0
 %endif
 
+# Ceph dropping support for 32-bit hosts
+%if 0%{?fedora} >= 30
+    %ifarch %{arm} %{ix86}
+        %define with_storage_rbd 0
+    %endif
+%endif
 
-# RHEL doesn't ship OpenVZ, VBox, UML, PowerHypervisor,
+# RHEL doesn't ship OpenVZ, VBox, PowerHypervisor,
 # VMware, libxenserver (xenapi), libxenlight (Xen 4.1 and newer),
 # or HyperV.
 %if 0%{?rhel}
     %define with_openvz 0
     %define with_vbox 0
-    %define with_uml 0
     %define with_phyp 0
     %define with_vmware 0
     %define with_xenapi 0
@@ -132,6 +137,11 @@
 
 %define with_firewalld 1
 
+%if 0%{?fedora} >= 30 || 0%{?rhel} > 7
+    %define with_firewalld_zone 0%{!?_without_firewalld_zone:1}
+%endif
+
+
 # fuse is used to provide virtualized /proc for LXC
 %if %{with_lxc}
     %define with_fuse      0%{!?_without_fuse:1}
@@ -156,11 +166,7 @@
 # Enable wireshark plugins for all distros shipping libvirt 1.2.2 or newer
 %if 0%{?fedora}
     %define with_wireshark 0%{!?_without_wireshark:1}
-%endif
-%if 0%{?fedora} || 0%{?rhel} > 7
-    %define wireshark_plugindir %(pkg-config --variable plugindir wireshark)
-%else
-    %define wireshark_plugindir %{_libdir}/wireshark/plugins
+    %define wireshark_plugindir %(pkg-config --variable plugindir wireshark)/epan
 %endif
 
 # Enable libssh transport for new enough distros
@@ -178,7 +184,7 @@
 %endif
 
 
-%if %{with_qemu} || %{with_lxc} || %{with_uml}
+%if %{with_qemu} || %{with_lxc}
 # numad is used to manage the CPU and memory placement dynamically,
 # it's not available on many non-x86 architectures.
     %ifnarch s390 s390x %{arm} riscv64
@@ -210,7 +216,7 @@
 Summary: Library providing a simple virtualization API
 Name: libvirt
 Version: @VERSION@
-Release: 1%{?dist}%{?extra_release}
+Release: 1%{?dist}
 License: LGPLv2+
 URL: https://libvirt.org/
 
@@ -231,9 +237,9 @@ Requires: libvirt-daemon-driver-lxc = %{version}-%{release}
 %if %{with_qemu}
 Requires: libvirt-daemon-driver-qemu = %{version}-%{release}
 %endif
-%if %{with_uml}
-Requires: libvirt-daemon-driver-uml = %{version}-%{release}
-%endif
+# We had UML driver, but we've removed it.
+Obsoletes: libvirt-daemon-driver-uml <= 5.0.0
+Obsoletes: libvirt-daemon-uml <= 5.0.0
 %if %{with_vbox}
 Requires: libvirt-daemon-driver-vbox = %{version}-%{release}
 %endif
@@ -258,7 +264,7 @@ BuildRequires: /usr/bin/pod2man
 %endif
 BuildRequires: gcc
 BuildRequires: git
-%if 0%{?fedora} >= 27 || 0%{?rhel} > 7
+%if 0%{?fedora} || 0%{?rhel} > 7
 BuildRequires: perl-interpreter
 %else
 BuildRequires: perl
@@ -379,18 +385,22 @@ BuildRequires: numad
 %endif
 
 %if %{with_wireshark}
-BuildRequires: wireshark-devel >= 2.1.0
+BuildRequires: wireshark-devel >= 2.4.0
 %endif
 
 %if %{with_libssh}
 BuildRequires: libssh-devel >= 0.7.0
 %endif
 
-%if 0%{?fedora} > 27 || 0%{?rhel} > 7
+%if 0%{?fedora} || 0%{?rhel} > 7
 BuildRequires: rpcgen
 BuildRequires: libtirpc-devel
 %endif
 
+%if %{with_firewalld_zone}
+BuildRequires: firewalld-filesystem
+%endif
+
 Provides: bundled(gnulib)
 
 %description
@@ -743,19 +753,6 @@ the Linux kernel
 %endif
 
 
-%if %{with_uml}
-%package daemon-driver-uml
-Summary: Uml driver plugin for the libvirtd daemon
-Requires: libvirt-daemon = %{version}-%{release}
-Requires: libvirt-libs = %{version}-%{release}
-
-%description daemon-driver-uml
-The UML driver plugin for the libvirtd daemon, providing
-an implementation of the hypervisor driver APIs using
-User Mode Linux
-%endif
-
-
 %if %{with_vbox}
 %package daemon-driver-vbox
 Summary: VirtualBox driver plugin for the libvirtd daemon
@@ -843,26 +840,6 @@ capabilities of LXC
 %endif
 
 
-%if %{with_uml}
-%package daemon-uml
-Summary: Server side daemon & driver required to run UML guests
-
-Requires: libvirt-daemon = %{version}-%{release}
-Requires: libvirt-daemon-driver-uml = %{version}-%{release}
-Requires: libvirt-daemon-driver-interface = %{version}-%{release}
-Requires: libvirt-daemon-driver-network = %{version}-%{release}
-Requires: libvirt-daemon-driver-nodedev = %{version}-%{release}
-Requires: libvirt-daemon-driver-nwfilter = %{version}-%{release}
-Requires: libvirt-daemon-driver-secret = %{version}-%{release}
-Requires: libvirt-daemon-driver-storage = %{version}-%{release}
-# There are no UML kernel RPMs in Fedora/RHEL to depend on.
-
-%description daemon-uml
-Server side daemon and driver required to manage the virtualization
-capabilities of UML
-%endif
-
-
 %if %{with_libxl}
 %package daemon-xen
 Summary: Server side daemon & driver required to run XEN guests
@@ -954,7 +931,7 @@ Bash completion script stub.
 %if %{with_wireshark}
 %package wireshark
 Summary: Wireshark dissector plugin for libvirt RPC transactions
-Requires: wireshark >= 1.12.6-4
+Requires: wireshark >= 2.4.0
 Requires: %{name}-libs = %{version}-%{release}
 
 %description wireshark
@@ -1068,12 +1045,6 @@ exit 1
     %define arg_vmware --without-vmware
 %endif
 
-%if %{with_uml}
-    %define arg_uml --with-uml
-%else
-    %define arg_uml --without-uml
-%endif
-
 %if %{with_storage_rbd}
     %define arg_storage_rbd --with-storage-rbd
 %else
@@ -1128,6 +1099,12 @@ exit 1
     %define arg_firewalld --without-firewalld
 %endif
 
+%if %{with_firewalld_zone}
+    %define arg_firewalld_zone --with-firewalld-zone
+%else
+    %define arg_firewalld_zone --without-firewalld-zone
+%endif
+
 %if %{with_wireshark}
     %define arg_wireshark --with-wireshark-dissector
 %else
@@ -1187,7 +1164,6 @@ rm -f po/stamp-po
            --with-avahi \
            --with-polkit \
            --with-libvirtd \
-           %{?arg_uml} \
            %{?arg_phyp} \
            %{?arg_esx} \
            %{?arg_hyperv} \
@@ -1227,6 +1203,7 @@ rm -f po/stamp-po
            --with-dtrace \
            --with-driver-modules \
            %{?arg_firewalld} \
+           %{?arg_firewalld_zone} \
            %{?arg_wireshark} \
            --without-pm-utils \
            --with-nss-plugin \
@@ -1316,9 +1293,6 @@ rm -rf $RPM_BUILD_ROOT%{_sysconfdir}/logrotate.d/libvirtd.libxl
 rm -f $RPM_BUILD_ROOT%{_datadir}/augeas/lenses/libvirtd_libxl.aug
 rm -f $RPM_BUILD_ROOT%{_datadir}/augeas/lenses/tests/test_libvirtd_libxl.aug
 %endif
-%if ! %{with_uml}
-rm -rf $RPM_BUILD_ROOT%{_sysconfdir}/logrotate.d/libvirtd.uml
-%endif
 
 # Copied into libvirt-docs subpackage eventually
 mv $RPM_BUILD_ROOT%{_datadir}/doc/libvirt-%{version} libvirt-docs
@@ -1397,6 +1371,16 @@ if [ -f %{_localstatedir}/lib/rpm-state/libvirt/restart ]; then
 fi
 rm -rf %{_localstatedir}/lib/rpm-state/libvirt || :
 
+%post daemon-driver-network
+%if %{with_firewalld}
+    %firewalld_reload
+%endif
+
+%postun daemon-driver-network
+%if %{with_firewalld}
+    %firewalld_reload
+%endif
+
 %post daemon-config-network
 if test $1 -eq 1 && test ! -f %{_sysconfdir}/libvirt/qemu/networks/default.xml ; then
     # see if the network used by default network creates a conflict,
@@ -1635,6 +1619,10 @@ exit 0
 %attr(0755, root, root) %{_libexecdir}/libvirt_leaseshelper
 %{_libdir}/%{name}/connection-driver/libvirt_driver_network.so
 
+%if %{with_firewalld_zone}
+%{_prefix}/lib/firewalld/zones/libvirt.xml
+%endif
+
 %files daemon-driver-nodedev
 %{_libdir}/%{name}/connection-driver/libvirt_driver_nodedev.so
 
@@ -1725,15 +1713,6 @@ exit 0
 %{_libdir}/%{name}/connection-driver/libvirt_driver_lxc.so
 %endif
 
-%if %{with_uml}
-%files daemon-driver-uml
-%dir %attr(0700, root, root) %{_localstatedir}/log/libvirt/uml/
-%config(noreplace) %{_sysconfdir}/logrotate.d/libvirtd.uml
-%ghost %dir %{_localstatedir}/run/libvirt/uml/
-%dir %attr(0700, root, root) %{_localstatedir}/lib/libvirt/uml/
-%{_libdir}/%{name}/connection-driver/libvirt_driver_uml.so
-%endif
-
 %if %{with_libxl}
 %files daemon-driver-libxl
 %config(noreplace) %{_sysconfdir}/libvirt/libxl.conf
@@ -1764,10 +1743,6 @@ exit 0
 %files daemon-lxc
 %endif
 
-%if %{with_uml}
-%files daemon-uml
-%endif
-
 %if %{with_libxl}
 %files daemon-xen
 %endif

m4/virt-driver-libxl.m4

@@ -75,6 +75,9 @@ AC_DEFUN([LIBVIRT_DRIVER_CHECK_LIBXL], [
     ])
   fi
 
+  dnl Check if Xen has support for PVH
+  AC_CHECK_DECL(LIBXL_DOMAIN_TYPE_PVH, [AC_DEFINE([HAVE_XEN_PVH], [1], [Define to 1 if Xen has PVH support.])], [], [#include <libxl.h>])
+
   AC_SUBST([LIBXL_CFLAGS])
   AC_SUBST([LIBXL_LIBS])
 ])

m4/virt-driver-uml.m4

@@ -1,54 +0,0 @@
-dnl The UML driver
-dnl
-dnl Copyright (C) 2005-2015 Red Hat, Inc.
-dnl
-dnl This library is free software; you can redistribute it and/or
-dnl modify it under the terms of the GNU Lesser General Public
-dnl License as published by the Free Software Foundation; either
-dnl version 2.1 of the License, or (at your option) any later version.
-dnl
-dnl This library is distributed in the hope that it will be useful,
-dnl but WITHOUT ANY WARRANTY; without even the implied warranty of
-dnl MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
-dnl Lesser General Public License for more details.
-dnl
-dnl You should have received a copy of the GNU Lesser General Public
-dnl License along with this library.  If not, see
-dnl <http://www.gnu.org/licenses/>.
-dnl
-
-AC_DEFUN([LIBVIRT_DRIVER_ARG_UML],[
-    LIBVIRT_ARG_WITH_FEATURE([UML], [UML], [check])
-])
-
-AC_DEFUN([LIBVIRT_DRIVER_CHECK_UML],[
-    if test "$with_libvirtd" = "no" || test "$with_linux" = "no"; then
-        if test "$with_uml" = "yes"; then
-            AC_MSG_ERROR([The UML driver cannot be enabled])
-        elif test "$with_uml" = "check"; then
-            with_uml="no"
-        fi
-    fi
-
-    if test "$with_uml" = "yes" || test "$with_uml" = "check"; then
-        AC_CHECK_HEADER([sys/inotify.h], [
-          with_uml=yes
-        ], [
-          if test "$with_uml" = "check"; then
-              with_uml=no
-              AC_MSG_NOTICE([<sys/inotify.h> is required for the UML driver, disabling it])
-          else
-              AC_MSG_ERROR([The <sys/inotify.h> is required for the UML driver. Upgrade your libc6.])
-          fi
-        ])
-    fi
-
-    if test "$with_uml" = "yes" ; then
-        AC_DEFINE_UNQUOTED([WITH_UML], 1, [whether UML driver is enabled])
-    fi
-    AM_CONDITIONAL([WITH_UML], [test "$with_uml" = "yes"])
-])
-
-AC_DEFUN([LIBVIRT_DRIVER_RESULT_UML],[
-    LIBVIRT_RESULT([UML], [$with_uml])
-])

m4/virt-firewalld-zone.m4

@@ -0,0 +1,45 @@
+dnl firewalld_zone check - whether or not to install the firewall "libvirt" zone
+dnl
+dnl Copyright (C) 2019 Red Hat, Inc.
+dnl
+dnl This library is free software; you can redistribute it and/or
+dnl modify it under the terms of the GNU Lesser General Public
+dnl License as published by the Free Software Foundation; either
+dnl version 2.1 of the License, or (at your option) any later version.
+dnl
+dnl This library is distributed in the hope that it will be useful,
+dnl but WITHOUT ANY WARRANTY; without even the implied warranty of
+dnl MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+dnl Lesser General Public License for more details.
+dnl
+dnl You should have received a copy of the GNU Lesser General Public
+dnl License along with this library.  If not, see
+dnl <http://www.gnu.org/licenses/>.
+dnl
+
+AC_DEFUN([LIBVIRT_ARG_FIREWALLD_ZONE], [
+  LIBVIRT_ARG_WITH([FIREWALLD_ZONE], [Whether to install firewalld libvirt zone], [check])
+])
+
+AC_DEFUN([LIBVIRT_CHECK_FIREWALLD_ZONE], [
+  AC_REQUIRE([LIBVIRT_CHECK_FIREWALLD])
+  AC_MSG_CHECKING([for whether to install firewalld libvirt zone])
+
+  if test "x$with_firewalld_zone" = "xcheck" ; then
+    with_firewalld_zone=$with_firewalld
+  fi
+
+  if test "x$with_firewalld_zone" = "xyes" ; then
+    if test "x$with_firewalld" != "xyes" ; then
+      AC_MSG_ERROR([You must have firewalld support enabled to enable firewalld-zone])
+    fi
+    AC_DEFINE_UNQUOTED([WITH_FIREWALLD_ZONE], [1], [whether firewalld libvirt zone is installed])
+  fi
+
+  AM_CONDITIONAL([WITH_FIREWALLD_ZONE], [test "x$with_firewalld_zone" != "xno"])
+  AC_MSG_RESULT($with_firewalld_zone)
+])
+
+AC_DEFUN([LIBVIRT_RESULT_FIREWALLD_ZONE], [
+  LIBVIRT_RESULT([firewalld-zone], [$with_firewalld_zone])
+])

m4/virt-firewalld.m4

@@ -32,10 +32,10 @@ AC_DEFUN([LIBVIRT_CHECK_FIREWALLD], [
     if test "x$with_dbus" != "xyes" ; then
       AC_MSG_ERROR([You must have dbus enabled for firewalld support])
     fi
-    AC_DEFINE_UNQUOTED([HAVE_FIREWALLD], [1], [whether firewalld support is enabled])
+    AC_DEFINE_UNQUOTED([WITH_FIREWALLD], [1], [whether firewalld support is enabled])
   fi
 
-  AM_CONDITIONAL([HAVE_FIREWALLD], [test "x$with_firewalld" != "xno"])
+  AM_CONDITIONAL([WITH_FIREWALLD], [test "x$with_firewalld" != "xno"])
 ])
 
 AC_DEFUN([LIBVIRT_RESULT_FIREWALLD], [

m4/virt-storage-rbd.m4

@@ -33,6 +33,7 @@ AC_DEFUN([LIBVIRT_STORAGE_CHECK_RBD], [
       old_LIBS="$LIBS"
       LIBS="$LIBS $LIBRBD_LIBS"
       AC_CHECK_FUNCS([rbd_get_features],[],[LIBRBD_FOUND=no])
+      AC_CHECK_FUNCS([rbd_list2])
       LIBS="$old_LIBS"
     fi
 

m4/virt-wireshark.m4

@@ -18,14 +18,14 @@ dnl <http://www.gnu.org/licenses/>.
 dnl
 
 AC_DEFUN([LIBVIRT_ARG_WIRESHARK],[
-  LIBVIRT_ARG_WITH_FEATURE([WIRESHARK_DISSECTOR], [wireshark], [check], [1.11.3])
+  LIBVIRT_ARG_WITH_FEATURE([WIRESHARK_DISSECTOR], [wireshark], [check], [2.4.0])
   LIBVIRT_ARG_WITH([WS_PLUGINDIR],
                    [wireshark plugins directory for use when installing
                    wireshark plugin], [check])
 ])
 
 AC_DEFUN([LIBVIRT_CHECK_WIRESHARK],[
-  LIBVIRT_CHECK_PKG([WIRESHARK_DISSECTOR], [wireshark], [1.11.3])
+  LIBVIRT_CHECK_PKG([WIRESHARK_DISSECTOR], [wireshark], [2.4.0])
 
   dnl Check for system location of wireshark plugins
   if test "x$with_wireshark_dissector" != "xno" ; then
@@ -50,6 +50,12 @@ AC_DEFUN([LIBVIRT_CHECK_WIRESHARK],[
         dnl time
         ws_plugindir='${exec_prefix}'"${ws_plugindir#$ws_exec_prefix}"
       fi
+
+      dnl Since wireshark 2.5.0 plugins can't live in top level
+      dnl plugindir but have to be under one of ["epan",
+      dnl "wiretap", "codecs"] subdir. The first one looks okay.
+      ws_plugindir="$ws_plugindir/epan"
+
     elif test "x$with_ws_plugindir" = "xno" || test "x$with_ws_plugindir" = "xyes"; then
       AC_MSG_ERROR([ws-plugindir must be used only with valid path])
     else

mingw-libvirt.spec.in

@@ -35,7 +35,7 @@
 
 Name:           mingw-libvirt
 Version:        @VERSION@
-Release:        1%{?dist}%{?extra_release}
+Release:        1%{?dist}
 Summary:        MinGW Windows libvirt virtualization library
 
 License:        LGPLv2+
@@ -177,7 +177,6 @@ autoreconf -if
   --without-avahi \
   --without-polkit \
   --without-libvirtd \
-  --without-uml \
   %{?_without_phyp} \
   %{?_without_esx} \
   %{?_without_hyperv} \

po/POTFILES

@@ -190,8 +190,6 @@ src/storage/storage_backend_zfs.c
 src/storage/storage_driver.c
 src/storage/storage_util.c
 src/test/test_driver.c
-src/uml/uml_conf.c
-src/uml/uml_driver.c
 src/util/iohelper.c
 src/util/viralloc.c
 src/util/virarptable.c

po/af.mini.po

@@ -5,9 +5,9 @@
 #
 msgid ""
 msgstr ""
-"Project-Id-Version: libvirt 4.6.0\n"
+"Project-Id-Version: libvirt 4.10.0\n"
 "Report-Msgid-Bugs-To: https://libvirt.org/bugs.html\n"
-"POT-Creation-Date: 2018-07-31 10:44+0100\n"
+"POT-Creation-Date: 2019-01-14 16:56+0000\n"
 "PO-Revision-Date: \n"
 "Last-Translator: \n"
 "Language-Team: Afrikaans\n"
@@ -16,4 +16,4 @@ msgstr ""
 "Content-Type: text/plain; charset=UTF-8\n"
 "Content-Transfer-Encoding: 8bit\n"
 "Plural-Forms: nplurals=2; plural=(n != 1)\n"
-"X-Generator: Zanata 4.5.0\n"
+"X-Generator: Zanata 4.6.2\n"

po/am.mini.po

@@ -5,9 +5,9 @@
 #
 msgid ""
 msgstr ""
-"Project-Id-Version: libvirt 4.6.0\n"
+"Project-Id-Version: libvirt 4.10.0\n"
 "Report-Msgid-Bugs-To: https://libvirt.org/bugs.html\n"
-"POT-Creation-Date: 2018-07-31 10:44+0100\n"
+"POT-Creation-Date: 2019-01-14 16:56+0000\n"
 "PO-Revision-Date: \n"
 "Last-Translator: \n"
 "Language-Team: Amharic\n"
@@ -16,4 +16,4 @@ msgstr ""
 "Content-Type: text/plain; charset=UTF-8\n"
 "Content-Transfer-Encoding: 8bit\n"
 "Plural-Forms: nplurals=2; plural=(n > 1)\n"
-"X-Generator: Zanata 4.5.0\n"
+"X-Generator: Zanata 4.6.2\n"

po/anp.mini.po

@@ -5,9 +5,9 @@
 #
 msgid ""
 msgstr ""
-"Project-Id-Version: libvirt 4.6.0\n"
+"Project-Id-Version: libvirt 4.10.0\n"
 "Report-Msgid-Bugs-To: https://libvirt.org/bugs.html\n"
-"POT-Creation-Date: 2018-07-31 10:44+0100\n"
+"POT-Creation-Date: 2019-01-14 16:56+0000\n"
 "PO-Revision-Date: \n"
 "Last-Translator: \n"
 "Language-Team: Angika\n"
@@ -16,4 +16,4 @@ msgstr ""
 "Content-Type: text/plain; charset=UTF-8\n"
 "Content-Transfer-Encoding: 8bit\n"
 "Plural-Forms: nplurals=2; plural=(n != 1)\n"
-"X-Generator: Zanata 4.5.0\n"
+"X-Generator: Zanata 4.6.2\n"

po/ar.mini.po

@@ -1,5 +1,5 @@
 # Libvirt package strings.
-# Copyright (C) 2018 Red Hat, Inc.
+# Copyright (C) 2019 Red Hat, Inc.
 # This file is distributed under the same license as the PACKAGE package.
 #
 # Translators:
@@ -7,9 +7,9 @@
 # Daniel Berrange <dan-zanata@berrange.com>, 2018. #zanata
 msgid ""
 msgstr ""
-"Project-Id-Version: libvirt 4.6.0\n"
+"Project-Id-Version: libvirt 4.10.0\n"
 "Report-Msgid-Bugs-To: https://libvirt.org/bugs.html\n"
-"POT-Creation-Date: 2018-07-31 10:44+0100\n"
+"POT-Creation-Date: 2019-01-14 16:56+0000\n"
 "PO-Revision-Date: 2018-04-24 04:33+0000\n"
 "Last-Translator: Copied by Zanata <copied-by-zanata@zanata.org>\n"
 "Language-Team: Arabic (http://www.transifex.com/projects/p/fedora/language/"
@@ -20,4 +20,4 @@ msgstr ""
 "Content-Transfer-Encoding: 8bit\n"
 "Plural-Forms: nplurals=6; plural=n==0 ? 0 : n==1 ? 1 : n==2 ? 2 : n%100>=3 "
 "&& n%100<=10 ? 3 : n%100>=11 && n%100<=99 ? 4 : 5;\n"
-"X-Generator: Zanata 4.5.0\n"
+"X-Generator: Zanata 4.6.2\n"

po/as.mini.po

@@ -1,5 +1,5 @@
 # Libvirt package strings.
-# Copyright (C) 2018 Red Hat, Inc.
+# Copyright (C) 2019 Red Hat, Inc.
 # This file is distributed under the same license as the PACKAGE package.
 #
 # Translators:
@@ -13,9 +13,9 @@
 # Nilamdyuti Goswami <ngoswami@redhat.com>, 2014
 msgid ""
 msgstr ""
-"Project-Id-Version: libvirt 4.6.0\n"
+"Project-Id-Version: libvirt 4.10.0\n"
 "Report-Msgid-Bugs-To: https://libvirt.org/bugs.html\n"
-"POT-Creation-Date: 2018-07-31 10:44+0100\n"
+"POT-Creation-Date: 2019-01-14 16:56+0000\n"
 "PO-Revision-Date: 2015-02-26 06:48+0000\n"
 "Last-Translator: Copied by Zanata <copied-by-zanata@zanata.org>\n"
 "Language-Team: Assamese (http://www.transifex.com/projects/p/libvirt/"
@@ -25,7 +25,7 @@ msgstr ""
 "Content-Type: text/plain; charset=UTF-8\n"
 "Content-Transfer-Encoding: 8bit\n"
 "Plural-Forms: nplurals=2; plural=(n != 1);\n"
-"X-Generator: Zanata 4.5.0\n"
+"X-Generator: Zanata 4.6.2\n"
 
 msgid ""
 "\n"
@@ -287,9 +287,6 @@ msgstr " নেটৱাৰ্কিং:"
 msgid " Storage:"
 msgstr " সংৰক্ষণ:"
 
-msgid " block_io_throttle reply was missing device list"
-msgstr "block_io_throttle উত্তৰত ডিভাইচ তালিকা নাছিল"
-
 #, c-format
 msgid ""
 "!!! SSH HOST KEY VERIFICATION FAILED !!!: Identity of host '%s:%d' differs "
@@ -598,9 +595,6 @@ msgstr "guest-get-vcpus ৰ উত্তৰত 'logical-id' নাই"
 msgid "'online' missing in reply of guest-get-vcpus"
 msgstr "guest-get-vcpus ৰ উত্তৰত 'online' নাই"
 
-msgid "'parent' for vHBA not specified, and cannot find one on this host"
-msgstr "vHBA ৰ বাবে 'parent' ধাৰ্য্য কৰা হোৱা নাই, আৰু এই হস্টত এটা পোৱা নাযায়"
-
 msgid "'peak' and 'burst' require 'average' attribute"
 msgstr "'peak' আৰু 'burst' ৰ বাবে 'average' বৈশিষ্ট্যৰ প্ৰয়োজন"
 
@@ -947,9 +941,6 @@ msgstr "NAT '%s' কৰাৰ চেষ্টা কৰা হৈছে। NAT
 msgid "Attribute mode is only allowed for guest CPU"
 msgstr "বৈশিষ্ট অৱস্থা কেৱল অতিথি CPU ৰ বাবে অনুমোদিত"
 
-msgid "Authentication Credentials not found"
-msgstr "প্ৰমাণীকৰণ তথ্যসমূহ পোৱা নগল"
-
 msgid "Authentication failed"
 msgstr "অনুমোদন বিফল"
 
@@ -1297,12 +1288,6 @@ msgstr "সংৰূপ ফাইল ল'ড কৰিব:  %s: %s"
 msgid "Can't modify device type '%s'"
 msgstr "ডিভাইচ ধৰণ '%s' পৰিবৰ্তন কৰিব নোৱাৰি"
 
-msgid "Can't parse barrier from "
-msgstr "ৰ পৰা বাধা বিশ্লেষণ কৰিব নোৱাৰি"
-
-msgid "Can't parse limit from "
-msgstr "ৰ পৰা সীমা বিশ্লেষণ কৰিব নোৱাৰি"
-
 msgid "Can't parse prlctl output"
 msgstr "prlctl আউটপুট বিশ্লেষণ কৰিব নোৱাৰি"
 
@@ -1422,9 +1407,6 @@ msgstr "বেলুন ডিভাইচ পথ নিৰ্ধাৰণ ক
 msgid "Cannot determine free memory"
 msgstr "মুক্ত মেমৰি নিৰ্ধাৰণ কৰিব নোৱাৰি"
 
-msgid "Cannot determine system clock HZ"
-msgstr "চিস্টেম ঘড়ী HZ নিৰ্ধাৰণ কৰিব নোৱাৰি"
-
 #, c-format
 msgid "Cannot directly attach floppy %s"
 msgstr "ফ্ল'পি %s পোনেপোনে সংযুক্ত কৰিব নোৱাৰি"
@@ -1474,10 +1456,6 @@ msgstr "পথত '%s' সন্ধান কৰিব নোৱাৰি"
 msgid "Cannot find CPU model with PVR 0x%08x"
 msgstr "PVR 0x%08x ৰ সৈতে CPU আৰ্হি পোৱা নাযায়"
 
-#, c-format
-msgid "Cannot find UML kernel %s"
-msgstr "UML কাৰ্ণেল %s বিচাৰিবলৈ ব্যৰ্থ"
-
 #, c-format
 msgid "Cannot find program %d version %d"
 msgstr "প্ৰগ্ৰাম %d সংস্কৰণ %d সন্ধান কৰিব নোৱাৰি"
@@ -1642,14 +1620,6 @@ msgstr "চকেট ঠিকনা '%s' বিশ্লেষণ কৰিব
 msgid "Cannot parse start time %s in %s"
 msgstr "%s ত আৰম্ভণি সময় %s বিশ্লেষণ কৰিব নোৱাৰি"
 
-#, c-format
-msgid "Cannot parse sys stat '%s'"
-msgstr "sys স্টেট '%s' বিশ্লেষণ কৰিব নোৱাৰি"
-
-#, c-format
-msgid "Cannot parse user stat '%s'"
-msgstr "ব্যৱহাৰকাৰী স্টেট '%s' বিশ্লেষণ কৰিব নোৱাৰি"
-
 #, c-format
 msgid ""
 "Cannot plug '%s' interface into '%s' because it would overcommit 'average' "
@@ -1798,10 +1768,6 @@ msgstr "আৰম্ভ নকৰা CURL হেণ্ডেল অংশীদ
 msgid "Cannot specify a label if relabelling is turned off. model=%s"
 msgstr "এটা লেবেল ধাৰ্য্য কৰিব নোৱাৰি যদি পুনৰলেবেলিং বন্ধ কৰা থাকে। model=%s"
 
-#, c-format
-msgid "Cannot stat %s"
-msgstr "%s স্টেট কৰিব নোৱাৰি"
-
 #, c-format
 msgid "Cannot undefine HostVirtualSwitch that has a '%s' port"
 msgstr "এটা '%s' পোৰ্ট থকা HostVirtualSwitch অবিৱৰিত কৰিব নোৱাৰি"
@@ -1974,14 +1940,6 @@ msgid ""
 msgstr ""
 "ডমেইন %s ৰ বাবে নিকট কলবেক ইতিমধ্যে অন্য সংযোগ %p ৰ সৈতে ৰেজিস্টাৰ কৰা আছে"
 
-#, c-format
-msgid "Command %s too long for destination"
-msgstr "গন্তব্যৰ ক্ষেত্ৰত আদেশ %s অত্যাধিক দীঘল"
-
-#, c-format
-msgid "Command '%s' is not found"
-msgstr "কমান্ড '%s' পোৱা নগল"
-
 msgid "Commit aborted"
 msgstr "Commit বাদ দিয়া হল"
 
@@ -2093,26 +2051,6 @@ msgstr "ডোমেইন বৰ্তমানে সক্ৰিয় নহয়
 msgid "Control groups not supported on this platform"
 msgstr "নিয়ন্ত্ৰণ দলসমূহ এই প্লেটফৰ্মত সমৰ্থিত নহয়"
 
-#, c-format
-msgid "Controller %d out of range"
-msgstr "নিয়ন্ত্ৰক %d বিস্তাৰৰ বাহিৰ"
-
-#, c-format
-msgid "Controller '%s' is not enabled for group"
-msgstr "নিয়ন্ত্ৰক '%s' দলৰ বাবে সামৰ্থবান নহয়"
-
-#, c-format
-msgid "Controller '%s' is not mounted"
-msgstr "নিয়ন্ত্ৰক '%s' মাউণ্ট কৰা নাই"
-
-#, c-format
-msgid "Controller '%s' is not wanted, but '%s' is co-mounted"
-msgstr "নিয়ন্ত্ৰক '%s' ৰ প্ৰয়োজন নাই, কিন্তু '%s' co-mount কৰা আছে"
-
-#, c-format
-msgid "Controller '%s' not mounted"
-msgstr "নিয়ন্ত্ৰক '%s' মাউণ্টেড নহয়"
-
 msgid "Controllers must use the 'ccid' address type"
 msgstr "নিয়ন্ত্ৰকসমূহে 'ccid' ঠিকনা ধৰণ ব্যৱহাৰ কৰিব লাগিব"
 
@@ -2306,9 +2244,6 @@ msgstr "নাম '%s' ৰ সৈতে PhysicalNic পোৱা নগল"
 msgid "Could not find any 'network' element in status file"
 msgstr "অৱস্থা ফাইলত কোনো 'network' উপাদান পোৱা নগল"
 
-msgid "Could not find any mounted controllers"
-msgstr "কোনো মাউণ্ট কৰা নিয়ন্ত্ৰক পোৱা নগল"
-
 #, c-format
 msgid "Could not find compute resource specified in '%s'"
 msgstr "'%s' ত ধাৰ্য্যত সম্পদ গণনা কৰিব পৰা নগল"
@@ -2325,10 +2260,6 @@ msgstr "প্ৰকৃত পথ '%s' অন্তৰ্ভুক্ত কৰ
 msgid "Could not find datastore with name '%s'"
 msgstr "নাম '%s' ৰ সৈতে তথ্যসংগ্ৰহ বিচাৰি পোৱা নগল"
 
-#, c-format
-msgid "Could not find directory separator in %s"
-msgstr "%s ত ডাইৰেকটৰি বিভাজক পোৱা নগল"
-
 #, c-format
 msgid "Could not find domain snapshot with internal name '%s'"
 msgstr "অভ্যন্তৰীক নাম '%s' ৰ সৈতে ডমেইন স্নেপস্বট পোৱা নগল"
@@ -2364,10 +2295,6 @@ msgstr "MAC ঠিকনা '%s' ৰ সৈতে ভৌতিক NIC পোৱ
 msgid "Could not find physical NIC with name '%s'"
 msgstr "নাম '%s' ৰ সৈতে ভৌতিক NIC পোৱা নগল"
 
-#, c-format
-msgid "Could not find placement for controller %s at %s"
-msgstr "%s ত নিয়ন্ত্ৰক %s ৰ বাবে স্থাপনা বিচাৰি পোৱা নগল"
-
 #, c-format
 msgid "Could not find snapshot with name '%s'"
 msgstr "'%s' নামৰ সৈতে স্নেপশ্বট বিচাৰি পোৱা নগল"
@@ -3063,10 +2990,6 @@ msgstr "ডিভাইচ %s ইতিমধ্যে অস্তিত্ব
 msgid "Device %s detached\n"
 msgstr "ডিভাইচ %s অসংলগ্ন কৰা হল\n"
 
-#, c-format
-msgid "Device %s in use"
-msgstr "ডিভাইচ %s ব্যৱহৃত"
-
 #, c-format
 msgid "Device %s is already in use"
 msgstr "%s ডিভাইচ বৰ্তমানে ব্যৱহৃত হৈছে"
@@ -3936,10 +3859,6 @@ msgstr "নেটৱৰ্ক সংৰূপ পৰিবৰ্তন লেন
 msgid "Failed to bind PCI device '%s' to %s"
 msgstr "PCI ডিভাইচ '%s' ক %s লৈ bind কৰিবলৈ বিফল"
 
-#, c-format
-msgid "Failed to bind cgroup '%s' on '%s'"
-msgstr "'%s' ত cgroup '%s' বাইণ্ড কৰিবলে ব্যৰ্থ"
-
 #, c-format
 msgid "Failed to bind mount directory %s to %s"
 msgstr "মাউণ্ট ডাইৰেকটৰি %s ক %s লে বান্ধিবলে ব্যৰ্থ"
@@ -4098,10 +4017,6 @@ msgstr "বান্ধনী লক্ষ্য %s সৃষ্টি কৰি
 msgid "Failed to create bridge node in xml document"
 msgstr "xml দস্তাবেজত ব্ৰিজ ন'ড সৃষ্টি কৰিবলে ব্যৰ্থ"
 
-#, c-format
-msgid "Failed to create controller %s for group"
-msgstr "দলৰ বাবে নিয়ন্ত্ৰক %s সৃষ্টি কৰিবলে ব্যৰ্থ"
-
 #, c-format
 msgid "Failed to create directory for '%s' dev '%s'"
 msgstr "'%s' dev '%s' ৰ বাবে ডাইৰেকটৰি সৃষ্টি কৰিবলে ব্যৰ্থ"
@@ -4385,9 +4300,6 @@ msgstr "আন্তঃপৃষ্ঠ %s ৰ বাবে নতুন না
 msgid "Failed to get %s minor number"
 msgstr "%s গৌণ সংখ্যা প্ৰাপ্ত কৰিবলে ব্যৰ্থ"
 
-msgid "Failed to get PCI Config Address String"
-msgstr "PCI সংৰূপ ঠিকনা স্ট্ৰিং প্ৰাপ্ত কৰিবলে ব্যৰ্থ"
-
 msgid "Failed to get PCI SYSFS file"
 msgstr "PCI SYSFS ফাইল প্ৰাপ্ত কৰিবলে ব্যৰ্থ"
 
@@ -4663,10 +4575,6 @@ msgstr "ডোমেইন %s স্বয়ংক্ৰিয় প্ৰাৰম
 msgid "Failed to mkdir %s"
 msgstr "mkdir %s কৰিবলৈ ব্যৰ্থযৰ্থ"
 
-#, c-format
-msgid "Failed to mount %s on %s type %s"
-msgstr "%s ধৰণ %s ত %s মাউণ্ট কৰিবলে ব্যৰ্থ"
-
 #, c-format
 msgid "Failed to mount %s on /dev"
 msgstr "%s ক /dev ত মাউণ্ট কৰিবলে ব্যৰ্থ"
@@ -5709,9 +5617,6 @@ msgstr "গন্তব্যৰ ক্ষেত্ৰত IP %s অত্যা
 msgid "IP address lookup for host '%s' failed: %s"
 msgstr "হস্ট '%s' ৰ বাবে IP ঠিকনা চোৱাটো ব্যৰ্থ হল: %s"
 
-msgid "IP address not supported for ethernet interface"
-msgstr "ইথাৰনেট আন্তঃপৃষ্ঠৰ বাবে IP ঠিকনা সমৰ্থিত নহয়"
-
 msgid ""
 "IP parameter must be given since libvirt was not compiled with IP address "
 "learning support"
@@ -6617,13 +6522,6 @@ msgstr "সৰ্বাধিক মেমৰি, স্কেইল্ড প
 msgid "Max memory:"
 msgstr "সৰ্বোচ্চ মেমৰি:"
 
-msgid "Maximum CPUs greater than specified machine type limit"
-msgstr "ধাৰ্য্যত মেচিন ধৰণ সীমাতকৈ সৰ্বাধিক CPUs অধিক"
-
-#, c-format
-msgid "Memory '%llu' must be less than %llu"
-msgstr "মেমৰি '%llu', %llu কে কম হব লাগিব"
-
 msgid "Memory allocation failure"
 msgstr "মেমৰি বিতৰণ কৰোঁতে ব্যৰ্থ"
 
@@ -6729,10 +6627,6 @@ msgstr "'%s' বৈশিষ্ট্য সন্ধানহীন"
 msgid "Missing '%s' property while looking for ManagedEntityStatus"
 msgstr "ManagedEntityStatus ৰ বাবে সন্ধান কৰোতে '%s' বৈশিষ্ট সন্ধানহীন"
 
-#, c-format
-msgid "Missing '/' separator in cgroup mount '%s'"
-msgstr "cgroup মাউণ্ট '%s' ত '/' বিভাজক নাই"
-
 msgid "Missing 'cores' attribute in CPU topology"
 msgstr "CPU টোপোলজিত 'core' নামক গুণ অনুপস্থিত"
 
@@ -6791,9 +6685,6 @@ msgstr "CPU গুণৰ নাম অনুপস্থিত"
 msgid "Missing CPU model name"
 msgstr "CPU ৰ মডেলৰ নাম অনুপস্থিত"
 
-msgid "Missing CPU vendor name"
-msgstr "CPU বিক্ৰেতা নাম সন্ধানহীন"
-
 msgid "Missing ID parameter for domain object"
 msgstr "ডমেইন অবজেক্টৰ বাবে ID প্ৰাচল সন্ধানহীন"
 
@@ -6936,9 +6827,6 @@ msgstr ""
 msgid "Missing or invalid PVR value in CPU model %s"
 msgstr "CPU আৰ্হি %s ত সন্ধানহীন অথবা অবৈধ PVR মান"
 
-msgid "Missing or invalid auth pointer"
-msgstr "সন্ধানহীন অথবা অবৈধ auth পইন্টাৰ"
-
 msgid "Missing or invalid scsi adapter 'unique_id' value"
 msgstr "সন্ধানহীন অথবা অবৈধ scsi adapter 'unique_id' মান"
 
@@ -7148,9 +7036,6 @@ msgstr "টোকা"
 msgid "NULL NetworkDef"
 msgstr "NULL NetworkDef"
 
-msgid "NULL or empty path"
-msgstr "NULL বা পথ ৰিক্ত"
-
 #, c-format
 msgid "NULL string parameter '%s'"
 msgstr "NULL স্ট্ৰিং প্ৰাচল '%s'"
@@ -7238,10 +7123,6 @@ msgstr "নে'টৱৰ্ক '%s' ইতিমধ্যে চলি আছে
 msgid "Network '%s' is still running"
 msgstr "নে'টৱৰ্ক '%s' এতিয়াও চলি আছে"
 
-#, c-format
-msgid "Network '%s' not found"
-msgstr "নে'টৱৰ্ক '%s' পোৱা নাযায়"
-
 msgid "Network config change transaction committed\n"
 msgstr "নেটৱৰ্ক সংৰূপ পৰিবৰ্তন লেন দেন commit কৰা হল\n"
 
@@ -7388,9 +7269,6 @@ msgstr "স্বাক্ষৰ %s ৰ বাবে কোনো args নাই
 msgid "No authentication callback available"
 msgstr "কোনো প্ৰমাণীকৰণ কলবেক উপলব্ধ নাই"
 
-msgid "No authentication callback provided."
-msgstr "অনুমোদনৰ কোনো কল-বেক উপলব্ধ কৰা নহয়।"
-
 msgid "No authentication methods and credentials provided"
 msgstr "কোনো প্ৰমাণীকৰণ পদ্ধতি আৰু তথ্য প্ৰদান কৰা হোৱা নাই"
 
@@ -7409,9 +7287,6 @@ msgstr "কোনো বিভাগ বিস্তাৰ উপলব্ধ
 msgid "No channel command provided"
 msgstr "কোনো চেনেল কমান্ড প্ৰদান কৰা হোৱা নাই"
 
-msgid "No controllers are mounted"
-msgstr "কোনো নিয়ন্ত্ৰক মাউণ্ট কৰা হোৱা নাই"
-
 msgid "No data supplied for <initarg> element"
 msgstr "<initarg> উপাদানৰ বাবে কোনো তথ্য প্ৰদান কৰা হোৱা নাই"
 
@@ -8518,9 +8393,6 @@ msgstr "SCSI ডিস্ক সূচী ('%s' ৰ পৰা বিশ্লে
 msgid "SCSI host device doesn't support managed mode"
 msgstr "SCSI হস্ট ডিভাইচে ব্যৱস্থাপিত অৱস্থা সমৰ্থন নকৰে"
 
-msgid "SCSI passthrough is not supported by this version of qemu"
-msgstr "qemu ৰ এই সংস্কৰণ দ্বাৰা SCSI পাছথ্ৰু সমৰ্থিত নহয়"
-
 #, c-format
 msgid "SCSI unit index %d out of [0..6,8..15] range"
 msgstr "SCSI একক সূচী %d [0..6,8..15] বিস্তাৰৰ বাহিৰ"
@@ -9060,12 +8932,6 @@ msgstr "চিস্টেম উপলব্ধ নহয়"
 msgid "System lacks NETNS support"
 msgstr "প্ৰণালীত NETNS সমৰ্থন নাই"
 
-msgid "TCP client networking type not supported"
-msgstr "TCP গ্ৰাহক প্ৰকৃতিৰ নে'টৱৰ্ক সমৰ্থিত নহয়"
-
-msgid "TCP server networking type not supported"
-msgstr "TCP সেৱক প্ৰকৃতিৰ নে'টৱৰ্ক সমৰ্থিত নহয়"
-
 #, c-format
 msgid "TLS handshake failed %s"
 msgstr "TLS হেণ্ডছেইক ব্যৰ্থ হল %s"
@@ -9630,9 +9496,6 @@ msgstr "এই কাৰ্য্য WIN32 প্লেটফৰ্মত সম
 msgid "This host is not managed by a vCenter"
 msgstr "এই হস্ট এটা vCenter দ্বাৰা ব্যৱস্থাপিত নহয়"
 
-msgid "This type of device cannot be hot unplugged"
-msgstr "এই ধৰণৰ ডিভাইচ হট-আনপ্লাগ কৰা সম্ভৱ নহয়।"
-
 msgid "This type of disk cannot be hot unplugged"
 msgstr "এই ধৰণৰ ডিস্ক হট আনপ্লাগ কৰিব নোৱাৰি"
 
@@ -9833,9 +9696,6 @@ msgstr "USB ডিভাইচ %s ইতিমধ্যে ব্যৱহৃত
 msgid "USB host device is missing bus/device information"
 msgstr "USB হোস্ট ডিভাইচত বাচ/ডিভাইচ সংক্ৰান্ত তথ্য অনুপস্থিত"
 
-msgid "USB redirection booting is not supported by this version of QEMU"
-msgstr "QEMU ৰ এই সংস্কৰণ দ্বাৰা USB পুনৰনিৰ্দেশ বুটিং সমৰ্থিত নহয়"
-
 msgid "USB redirection filter is not supported by this version of QEMU"
 msgstr "USB পুনৰনিৰ্দেশ ফিল্টাৰ QEMU ৰ এই সংস্কৰণ দ্বাৰা সমৰ্থিত নহয়"
 
@@ -10020,6 +9880,12 @@ msgstr "চকেট ফাইল হেণ্ডেল কপি কৰিব
 msgid "Unable to create %s"
 msgstr "%s সৃষ্টি কৰিবলে অক্ষম"
 
+msgid "Unable to create JSON formatter"
+msgstr "JSON ফৰমেটাৰ সৃষ্টি কৰিবলে অক্ষম"
+
+msgid "Unable to create JSON parser"
+msgstr "JSON বিশ্লেষক সৃষ্টি কৰিবলে অক্ষম"
+
 #, c-format
 msgid "Unable to create LPAR. Reason: '%s'"
 msgstr "LPAR সৃষ্টি কৰিবলে অক্ষম। কাৰণ: '%s'"
@@ -10049,10 +9915,6 @@ msgstr "ব্ৰিজ ডিভাইচ সৃষ্টি কৰিবলে
 msgid "Unable to create device %s"
 msgstr "ডিভাইচ %s সৃষ্টি কৰিবলে অক্ষম"
 
-#, c-format
-msgid "Unable to create directory %s"
-msgstr "ডাইৰেকটৰি %s সৃষ্টি কৰিবলে অক্ষম"
-
 msgid "Unable to create epoll fd"
 msgstr "epoll fd সৃষ্টি কৰিবলে অক্ষম"
 
@@ -10516,6 +10378,9 @@ msgstr "'%s' খোলিবলে অক্ষম"
 msgid "Unable to open /dev/loop-control"
 msgstr "/dev/loop-control খোলিবলৈ অক্ষম"
 
+msgid "Unable to open /proc/mounts"
+msgstr "/proc/mounts খোলিবলে অক্ষম"
+
 msgid "Unable to open UNIX socket"
 msgstr "UNIX চকেট খোলিবলে অক্ষম"
 
@@ -10803,13 +10668,6 @@ msgstr "এই প্লেটফৰ্মত %s ত STP বিলম্ব স
 msgid "Unable to set STP on %s on this platform"
 msgstr "এই প্লেটফৰ্মত %s ত STP সংহতি কৰিবলে অক্ষম"
 
-msgid "Unable to set VM logfile close-on-exec flag"
-msgstr "VM লগ ফাইলৰ close on exec ফ্লেগ %s নিৰ্ধাৰণ কৰোঁতে ব্যৰ্থ"
-
-#, c-format
-msgid "Unable to set bridge %s %s"
-msgstr "ব্ৰিজ %s %s সংহতি কৰিবলে অক্ষম"
-
 msgid "Unable to set cloexec flag"
 msgstr "cloexec ফ্লেগ সংহতি কৰিবলে অক্ষম"
 
@@ -10872,10 +10730,6 @@ msgstr "বান্ধনী উৎস %s stat কৰিবলে অক্ষ
 msgid "Unable to stat bind target %s"
 msgstr "বান্ধনী লক্ষ্য %s বান্ধীবলে অক্ষম"
 
-#, c-format
-msgid "Unable to symlink directory %s to %s"
-msgstr "ডাইৰেকটৰি %s ক %s লে symlink কৰিব নোৱাৰি"
-
 #, c-format
 msgid "Unable to truncate %s"
 msgstr "%s চুটি কৰিবলে অক্ষম"
@@ -11005,9 +10859,6 @@ msgstr "non-peer2peer প্ৰব্ৰজনৰ সৈতে অপ্ৰত
 msgid "Unexpected disk sgio mode '%d'"
 msgstr "অপ্ৰত্যাশিত ডিস্ক sgio অৱস্থা '%d'"
 
-msgid "Unexpected error"
-msgstr "অপ্ৰত্যাশিত ত্ৰুটি"
-
 #, c-format
 msgid "Unexpected filesystem type %s"
 msgstr "অপ্ৰত্যাশিত ফাইলচিস্টেম ধৰণ %s"
@@ -11077,10 +10928,6 @@ msgstr "অপ্ৰত্যাশিত ভলিউম পথ বিন্য
 msgid "Unhandled event %d for monitor fd %d"
 msgstr "মনিটৰ fd %d ৰ বাবে অনিয়ন্ত্ৰিত ঘটনা %d"
 
-#, c-format
-msgid "Unix path %s too long for destination"
-msgstr "গন্তব্যৰ ক্ষেত্ৰত Unix পথ %s অত্যাধিক দীঘল"
-
 msgid "Unknown"
 msgstr "অজ্ঞাত"
 
@@ -11525,9 +11372,6 @@ msgid "VMX entry 'sched.cpu.affinity' contains a %d, this value is too large"
 msgstr ""
 "VMX প্ৰবিষ্টি 'sched.cpu.affinity' এ এটা %d অন্তৰ্ভুক্ত কৰে, এই মান অত্যাধিক ডাঙৰ"
 
-msgid "VNC WebSockets are not supported with this QEMU binary"
-msgstr "এই QEMU বাইনাৰিৰ সৈতে VNC WebSockets সমৰ্থিত নহয়"
-
 msgid "VNC supports connected='keep' only"
 msgstr "VNC এ কেৱল connected='keep' সমৰ্থণ কৰে"
 
@@ -12137,25 +11981,6 @@ msgstr "এটাৰ অধিক ডিভাইচৰ বাবে ব্য
 msgid "booted"
 msgstr "বুটেড"
 
-msgid ""
-"booting from PCI devices assigned with VFIO is not supported with this "
-"version of qemu"
-msgstr ""
-"VFIO ৰ সৈতে ধাৰ্য্যত PCI ডিভাইচসমূহৰ পৰা বুট কৰাটো qemu ৰ এই সংস্কৰণৰ সৈতে সমৰ্থিত "
-"নহয়"
-
-msgid ""
-"booting from assigned PCI devices is not supported with this version of qemu"
-msgstr "qemu ৰ এই সংস্কৰণৰ সৈতে ধাৰ্য্যত PCI ডিভাইচসমূহৰ পৰা বুট কৰাটো সমৰ্থিত নহয়"
-
-msgid ""
-"booting from assigned SCSI devices is not supported with this version of qemu"
-msgstr "qemu ৰ এই সংস্কৰণৰ সৈতে ধাৰ্য্যত SCSI ডিভাইচসমূহৰ পৰা বুট কৰাটো সমৰ্থিত নহয়"
-
-msgid ""
-"booting from assigned USB devices is not supported with this version of qemu"
-msgstr "qemu ৰ এই সংস্কৰণৰ সৈতে ধাৰ্য্যত USB ডিভাইচসমূহৰ পৰা বুট কৰাটো সমৰ্থিত নহয়"
-
 msgid ""
 "booting from assigned devices is only supported for PCI, USB and SCSI devices"
 msgstr ""
@@ -12297,15 +12122,9 @@ msgstr "নেটলিঙ্কৰ বাবে প্লেইচহল্ড
 msgid "cannot apply process capabilities %d"
 msgstr "প্ৰক্ৰিয়া ক্ষমতাসমূহ %d প্ৰয়োগ কৰিব নোৱাৰি"
 
-msgid "cannot attach device on inactive domain"
-msgstr "নিষ্ক্ৰিয় ডোমেইনৰ সৈতে ডিভাইচ সংযুক্ত কৰা নাযাব"
-
 msgid "cannot become session leader"
 msgstr "অধিবেশন বিচাৰি পোৱা ন'গ'ল"
 
-msgid "cannot bind socket"
-msgstr "অধিবেশন বিচাৰি পোৱা ন'গ'ল"
-
 msgid "cannot block signals"
 msgstr "চিগ্নেল ৰোধ কৰিব নোৱাৰি"
 
@@ -12504,9 +12323,6 @@ msgstr "%d স্নেপশ্বটসমূহৰ সৈতে নিষ্
 msgid "cannot delete snapshots of running domain"
 msgstr "চলি থকা ডমেইনৰ স্নেপশ্বটসমূহ মচিব নোৱাৰি"
 
-msgid "cannot detach device on inactive domain"
-msgstr "নিষ্ক্ৰিয় ডোমেইনৰ সৈতে ডিভাইচ সংযুক্ত কৰা নাযাব"
-
 #, c-format
 msgid "cannot determine filesystem for '%s'"
 msgstr "'%s' ৰ বাবে ফাইলচিস্টেম নিৰ্ধাৰণ কৰিব নোৱাৰি"
@@ -12698,9 +12514,6 @@ msgstr "সুৰক্ষা props %d (%s) প্ৰাপ্ত কৰিব
 msgid "cannot get the host uuid"
 msgstr "হস্ট uuid প্ৰাপ্ত কৰিব নোৱাৰি"
 
-msgid "cannot get the path of MEMORY cgroup controller"
-msgstr "MEMORY cgroup নিয়ন্ত্ৰকৰ পথ প্ৰাপ্ত কৰিব নোৱাৰি"
-
 msgid "cannot get vCPU placement & pCPU time"
 msgstr "vCPU স্থাপনাও আৰু pCPU ৰ সময় প্ৰাপ্ত কৰিবলৈ ব্যৰ্থ"
 
@@ -12725,9 +12538,6 @@ msgstr "প্ৰমাণপত্ৰ অবজেক্ট আৰম্ভ ক
 msgid "cannot initialize condition variable"
 msgstr "condition মান আৰম্ভ কৰিব নোৱাৰি"
 
-msgid "cannot initialize inotify"
-msgstr "ব্ৰিজ সমৰ্থন আৰম্ভ কৰোঁতে ব্যৰ্থ"
-
 msgid ""
 "cannot initialize libxenlight context, probably not running in a Xen Dom0, "
 "disabling driver"
@@ -12852,9 +12662,6 @@ msgstr "macvtap tap ডিভাইচ %s খুলিবলৈ ব্যৰ্
 msgid "cannot open path '%s'"
 msgstr "পথ '%s' খোলোঁতে ব্যৰ্থ"
 
-msgid "cannot open socket"
-msgstr "ছকেট খুলিব নোৱাৰি"
-
 #, c-format
 msgid "cannot open volume '%s'"
 msgstr "ভলিউম '%s' খোলোঁতে ব্যৰ্থ"
@@ -12863,10 +12670,6 @@ msgstr "ভলিউম '%s' খোলোঁতে ব্যৰ্থ"
 msgid "cannot parse %s version number in '%.*s'"
 msgstr "%s সংস্কৰণ সংখ্যা বিশ্লেষণ কৰিব নোৱাৰি '%.*s'"
 
-#, c-format
-msgid "cannot parse CPU map for %s architecture"
-msgstr "%s স্থাপত্যৰ বাবে CPU মেপ বিশ্লেষণ কৰা সম্ভৱ নহয়"
-
 #, c-format
 msgid "cannot parse CPU topology '%s'"
 msgstr "CPU ৰ টোপোলজি '%s' বিশ্লেষণ কৰিবলৈ ব্যৰ্থ"
@@ -12958,6 +12761,10 @@ msgstr "interfaceid প্ৰাচলক uuid হিচাপে বিশ্
 msgid "cannot parse io mode '%s'"
 msgstr "io অৱস্থা '%s' বিশ্লেষণ কৰিব নোৱাৰি"
 
+#, c-format
+msgid "cannot parse json %s: %s"
+msgstr "json %s বিশ্লেষণ কৰা সম্ভৱ নহয়: %s"
+
 #, c-format
 msgid "cannot parse nbd filename '%s'"
 msgstr "nbd ফাইলনাম '%s' বিশ্লেষণ কৰিব নোৱাৰি"
@@ -13040,10 +12847,6 @@ msgstr "vbd ফাইলৰ নাম বিশ্লষণ কৰোঁতে
 msgid "cannot parse vendor id %s"
 msgstr "vendor id %s বিশ্লেষণ কৰিব নোৱাৰি"
 
-#, c-format
-msgid "cannot parse version %s"
-msgstr "%s পঢ়োঁতে ব্যৰ্থ"
-
 #, c-format
 msgid "cannot parse video heads '%s'"
 msgstr "ভিডিও হেড '%s' বিশ্লেষণ কৰিবলৈ ব্যৰ্থ"
@@ -13146,10 +12949,6 @@ msgstr "হেডাৰ '%s' পঢ়োঁতে ব্যৰ্থ"
 msgid "cannot read mount list '%s'"
 msgstr "তুলি লোৱাৰ তালিকা '%s' পঢ়োঁতে ব্যৰ্থ"
 
-#, c-format
-msgid "cannot read reply %s"
-msgstr "%s উত্তৰ পঢ়িবলৈ ব্যৰ্থ"
-
 #, c-format
 msgid "cannot receive data from volume %s"
 msgstr "ভলিউম %s ৰ পৰা তথ্য প্ৰাপ্ত কৰিব নোৱাৰি"
@@ -13224,10 +13023,6 @@ msgstr "ফাইল '%s' আৰম্ভণি বিচাৰিব নোৱ
 msgid "cannot seek to start of '%s'"
 msgstr "'%s' ৰ আৰম্ভণিত সন্ধান কৰিব নোৱাৰি"
 
-#, c-format
-msgid "cannot send command %s"
-msgstr "%s আদেশ পঠিয়াব নোৱাৰি"
-
 #, c-format
 msgid "cannot send data to volume %s"
 msgstr "তথ্যক ভলিউম %s লে পঠাব নোৱাৰি"
@@ -13235,10 +13030,6 @@ msgstr "তথ্যক ভলিউম %s লে পঠাব নোৱাৰ
 msgid "cannot send to netlink socket"
 msgstr "netlink ছকেটলৈ পঠিয়াবলৈ ব্যৰ্থ"
 
-#, c-format
-msgid "cannot send too long command %s (%d bytes)"
-msgstr "বৰ দীঘল আদেশ পঠিয়াব নোৱাৰি %s (%d bytes)"
-
 #, c-format
 msgid "cannot set CPU affinity on process %d"
 msgstr "%d প্ৰক্ৰিয়াৰ বাবে CPU এফিনিটি নিৰ্ধাৰণ কৰিবলৈ ব্যৰ্থ"
@@ -13261,15 +13052,9 @@ msgstr "'%s' ফাইল ধৰণ নিৰ্ধাৰণ কৰোঁতে
 msgid "cannot set file owner '%s'"
 msgstr "'%s' ফাইলৰ গৰাকী নিৰ্ধাৰণ কৰোঁতে ব্যৰ্থ"
 
-msgid "cannot set max memory lower than current memory"
-msgstr "বৰ্তমান মেমৰিৰ তূলনাত সৰ্বাধিক মেমৰিৰ পৰিমাণ কম হ'ব নোৱাৰে"
-
 msgid "cannot set memory higher than max memory"
 msgstr "সৰ্বাধিক মেমৰিতকৈ অধিক পৰিমাণৰ মেমৰি নিৰ্ধাৰণ কৰা নাযাব"
 
-msgid "cannot set memory of an active domain"
-msgstr "সক্ৰিয় ডোমেইনৰ মেমৰি নিৰ্ধাৰণ কৰা নাযাব"
-
 #, c-format
 msgid "cannot set mode of '%s' to %04o"
 msgstr "'%s' ৰ মোড %04o ৰূপে ধাৰ্য কৰা সম্ভৱ নহয়"
@@ -13394,14 +13179,6 @@ msgstr "%s ত cellNum %d কে কম বা সমান হব লাগি
 msgid "cellNum in %s only accepts %d as a negative value"
 msgstr "%s ত cellNum এ %d ক কেৱল ধনাত্মক মান হিচাপে গ্ৰহণ কৰে"
 
-#, c-format
-msgid "cfs_period '%llu' must be in range (1000, 1000000)"
-msgstr "cfs_period '%llu' বিস্তাৰ (1000, 1000000) ত হব লাগিব"
-
-#, c-format
-msgid "cfs_quota '%lld' must be in range (1000, %llu)"
-msgstr "cfs_quota '%lld' বিস্তাৰ (1000, %llu) ত হব লাগিব"
-
 msgid "cgroup CPU controller is not mounted"
 msgstr "cgroup CPU নিয়ন্ত্ৰক মাউণ্ট কৰা নহয়"
 
@@ -13544,10 +13321,6 @@ msgstr "সংৰূপ"
 msgid "config data file to import from"
 msgstr "আমদানি কৰিব লগা বিন্যাস তথ্যৰ ফাইল"
 
-#, c-format
-msgid "config value %s not a string"
-msgstr "সংৰূপ মান %s এটা স্ট্ৰিং নহয়"
-
 #, c-format
 msgid "config value %s was malformed"
 msgstr "বিন্যাসৰ মান %s ভুল"
@@ -13556,10 +13329,6 @@ msgstr "বিন্যাসৰ মান %s ভুল"
 msgid "config value %s was missing"
 msgstr "বিন্যাসৰ মান %s নাছিল"
 
-#, c-format
-msgid "config value %s was not a string"
-msgstr "বিন্যাসৰ মান %s এটা স্ট্ৰিং নাছিল"
-
 msgid "configuration file syntax error"
 msgstr "বিনেস ফাইলৰ শব্দবিনেসত ভুল"
 
@@ -14288,9 +14057,6 @@ msgstr "dir"
 msgid "direct migration"
 msgstr "সৰাসৰি প্ৰব্ৰজন"
 
-msgid "direct networking type not supported"
-msgstr "প্ৰত্যক্ষ নেটৱাৰ্কিং ধৰণ সমৰ্থিত নহয়"
-
 #, c-format
 msgid ""
 "direct setting of the vlan tag is not allowed for hostdev devices using %s "
@@ -14388,10 +14154,6 @@ msgstr "ডিস্ক event_idx কেৱল virtio বাচৰ বাবে
 msgid "disk format %s is not supported"
 msgstr "ডিস্ক বিন্যাস %s সমৰ্থিত নহয়"
 
-#, c-format
-msgid "disk format '%s' lacks backing file support"
-msgstr "ডিস্ক বিন্যাস '%s' ত ফাইল সমৰ্থন বেকিং নাই"
-
 msgid "disk ioeventfd mode supported only for virtio bus"
 msgstr "ডিস্ক ioeventfd অৱস্থা কেৱল virtio বাচৰ বাবে সমৰ্থিত"
 
@@ -15258,17 +15020,6 @@ msgstr "পুল %s ক autostarted হিচাপে চিহ্নিত
 msgid "failed to move file to %s "
 msgstr "ফাইলক %s লে স্থানান্তৰ কৰিবলে ব্যৰ্থ"
 
-#, c-format
-msgid "failed to open %s for reading"
-msgstr "পঢ়াৰ বাবে %s খোলোঁতে বিফল"
-
-#, c-format
-msgid "failed to open chardev file: %s"
-msgstr "chardev ফাইল খোলিবলে ব্যৰ্থ: %s"
-
-msgid "failed to open configuration file for reading"
-msgstr "পঢ়াৰ বাবে বিনেস ফাইল খোলোঁতে বিফল"
-
 msgid "failed to open file"
 msgstr "ফাইল খোলোঁতে ব্যৰ্থ"
 
@@ -15312,9 +15063,6 @@ msgstr "qemu ডিভাইচ তালিকা বিশ্লেষণ ক
 msgid "failed to parse value of %s"
 msgstr "%s ৰ বাবে মান বিশ্লেষণ কৰিবলে ব্যৰ্থ"
 
-msgid "failed to parse xml document"
-msgstr "xml নথি বিশ্লেষণ কৰোঁতে ব্যৰ্থ"
-
 #, c-format
 msgid "failed to pivot job for disk %s"
 msgstr "ডিস্ক %s ৰ বাবে কাৰ্য্য পিভট কৰিবলে ব্যৰ্থ"
@@ -15353,10 +15101,6 @@ msgstr "libxl হেডাৰ পঢ়িবলে ব্যৰ্থ"
 msgid "failed to read metadata length in '%s'"
 msgstr "'%s' ত মতাডাতাৰ দৈৰ্ঘ্য পঢ়োঁতে ব্যৰ্থ"
 
-#, c-format
-msgid "failed to read pid: %s"
-msgstr "পাইপ নিৰ্মাণ কৰোঁতে ব্যৰ্থ: %s"
-
 msgid "failed to read qemu header"
 msgstr "qemu হেডাৰ পঢ়োঁতে ব্যৰ্থ"
 
@@ -15388,9 +15132,6 @@ msgstr "তথ্যসমূহ উদ্ধাৰ কৰিবলে ব্য
 msgid "failed to retrieve decision to accept host key"
 msgstr "হস্ট কি' গ্ৰহণ কৰিবলে সিধান্ত উদ্ধাৰ কৰিবলে ব্যৰ্থ"
 
-msgid "failed to retrieve password"
-msgstr "পাছৱৰ্ড উদ্ধাৰ কৰিবলে ব্যৰ্থ"
-
 msgid "failed to retrieve private key passphrase: callback has failed"
 msgstr "ব্যক্তিগত কি' পাচফ্ৰেইছ উদ্ধাৰ কৰিবলে ব্যৰ্থ: কলবেক ব্যৰ্থ হৈছে"
 
@@ -15758,10 +15499,6 @@ msgstr "প্ৰদান কৰা uuid XML uuid ৰ সৈতে মিল
 msgid "got unexpected RPC call prog %d vers %d proc %d type %d"
 msgstr "অপ্ৰত্যাশিত RPC কল prog %d vers %d proc %d type %d প্ৰাপ্ত হল"
 
-#, c-format
-msgid "got unknown HTTP error code %d"
-msgstr "অজ্ঞাত HTTP ভুলৰ কোড পোৱা গ'ল %d"
-
 msgid "gracefully shutdown a domain"
 msgstr "সঠিক পদ্ধতিতে ডোমেইন বন্ধ কৰক"
 
@@ -15861,9 +15598,6 @@ msgstr "hostdev অবৈধ গোপন ধৰণ '%s'"
 msgid "hostdev mode '%s' not supported"
 msgstr "hostdev মোড '%s' সমৰ্থিত নহয়"
 
-msgid "hostdev networking type not supported"
-msgstr "hostdev নেটৱাৰ্কিং ধৰণ সমৰ্থিত নহয়"
-
 #, c-format
 msgid "hostdev subsys type '%s' not supported"
 msgstr "hostdev subsys ৰ ধৰণ '%s' সমৰ্থিত নহয়"
@@ -15886,9 +15620,6 @@ msgstr "hugepage আকাৰ শূন্য হব নোৱাৰিব"
 msgid "hypervisor connection URI"
 msgstr "হাইপাৰ ভাইসৰ সংযোগৰ URI"
 
-msgid "hypervisor lacks deviceboot feature"
-msgstr "হাইপাৰজৰত ডিভাইচবুট বৈশিষ্ট্য নাই"
-
 msgid "iSCSI storage pool does not support volume creation"
 msgstr "iSCSI সংৰক্ষণ পুলে ভলিউম সৃষ্টি সমৰ্থন নকৰে"
 
@@ -15945,10 +15676,6 @@ msgstr "যদি উপলব্ধ সংযোগ URl ত পাছৱৰ্
 msgid "incomplete metadata in '%s'"
 msgstr "'%s' ত মেটাডাটা অসম্পূৰ্ণ"
 
-#, c-format
-msgid "incomplete reply %s"
-msgstr "অসম্পূৰ্ণ উত্তৰ %s"
-
 msgid "incomplete return information"
 msgstr "অসম্পূৰ্ণ ঘুৰাই দিয়া তথ্য"
 
@@ -16031,9 +15758,6 @@ msgstr "আন্তঃপৃষ্ঠ নাম %s বাফাৰত খাপ
 msgid "interface name or MAC address"
 msgstr "সংযোগমাধ্যমৰ নাম বা MAC ঠিকনা"
 
-msgid "interface script execution not supported by this driver"
-msgstr "আন্তঃপৃষ্ঠ স্ক্ৰিপ্ট এক্সিকিউষণ এই ড্ৰাইভাৰ দ্বাৰা সমৰ্থিত নহয়"
-
 msgid "interface stats not implemented on this platform"
 msgstr "এই প্লেটফৰ্মত আন্তঃপৃষ্ঠ পৰিসংখ্যা প্ৰণয়ন কৰা হোৱা নাই"
 
@@ -16051,9 +15775,6 @@ msgstr "অভ্যন্তৰীক ত্ৰুটি: %s"
 msgid "internal error: bad options in command: '%s'"
 msgstr "অভ্যান্তৰীক ত্ৰুটি: কমান্ড: '%s' ত বেয়া বিকল্পসমূহ"
 
-msgid "internal networking type not supported"
-msgstr "অভ্যান্তৰীণ প্ৰকৃতিৰ নে'টৱৰ্ক সমৰ্থিত নহয়"
-
 #, c-format
 msgid "internal snapshot for disk %s unsupported for storage type %s"
 msgstr "ডিস্ক %s ৰ বাবে অভ্যন্তৰীক স্নেপশ্বট সংৰক্ষণ ধৰণ %s ৰ বাবে অসমৰ্থিত"
@@ -16423,10 +16144,6 @@ msgstr "অবৈধ ন'ড মেমৰি মান"
 msgid "invalid path %s not assigned to domain"
 msgstr "ডমেইনলে অবৈধ পথ %s ধাৰ্য্য কৰা হোৱা নাই"
 
-#, c-format
-msgid "invalid path '%s'"
-msgstr "অবৈধ পথ '%s'"
-
 #, c-format
 msgid "invalid path, '%s' is not a known interface"
 msgstr "পথ বৈধ নহয়, '%s' পৰিচিত সংযোগ মাধ্যম নহয়"
@@ -16648,13 +16365,6 @@ msgstr "libhal_get_all_devices ব্যৰ্থ হল"
 msgid "libnl was not available at build time"
 msgstr "libnl নিৰ্মাণ সময়ত উপলব্ধ নাছিল"
 
-#, c-format
-msgid "library call %s failed, possibly not supported"
-msgstr "library call %s বিফল, হয়তো সমৰ্থিত নহয়"
-
-msgid "library call failed, possibly not supported"
-msgstr "library call বিফল, হয়তো সমৰ্থিত নহয়"
-
 msgid "libselinux does not support LXC contexts path"
 msgstr "libselinux এ LXC পৰিপ্ৰেক্ষতিত পথ সমৰ্থন নকৰে"
 
@@ -17121,10 +16831,6 @@ msgstr "maxuuids > REMOTE_SECRET_LIST_MAX"
 msgid "mem(Suspend-to-RAM), disk(Suspend-to-Disk), hybrid(Hybrid-Suspend)"
 msgstr "mem(Suspend-to-RAM), disk(Suspend-to-Disk), hybrid(Hybrid-Suspend)"
 
-#, c-format
-msgid "memballoon unsupported with address type '%s'"
-msgstr "ঠিকনা ধৰণ '%s' ৰ সৈতে memballoon অসমৰ্থিত"
-
 msgid "memory attributes: [file=]name[,snapshot=type]"
 msgstr "মেমৰি বৈশিষ্ট্যসমূহ: [file=]name[,snapshot=type]"
 
@@ -18077,9 +17783,6 @@ msgstr "'%s' ৰ কাৰণে কোনো ব্ল'ক ডিভাইচ
 msgid "no call waiting for reply with prog %d vers %d serial %d"
 msgstr "prog %d vers %d serial %d ৰ সৈতে উত্তৰৰ বাবে অপেক্ষা কৰা কোনো কল নাই"
 
-msgid "no callback provided"
-msgstr "কোনো কলবেক প্ৰদান কৰা হোৱা নাই"
-
 msgid "no client username was found"
 msgstr "গ্ৰাহকৰ ব্যৱহাৰকৰোঁতাৰ নাম পোৱা নাযায়"
 
@@ -18109,10 +17812,6 @@ msgstr "এলিয়াচ %s ৰ সৈতে কোনো ডিভাইচ
 msgid "no disk format for %s and probing is disabled"
 msgstr "%s ৰ বাবে কোনো ডিস্ক বিন্যাস নাই আৰু প্ৰবিং অসামৰ্থবান কৰা আছে"
 
-#, c-format
-msgid "no disk found with alias %s"
-msgstr "এলিয়াচ %s ৰ সৈতে কোনো ডিস্ক পোৱা নগল"
-
 #, c-format
 msgid "no disk named '%s'"
 msgstr "'%s' নামৰ কোনো ডিস্ক নাই"
@@ -18161,9 +17860,6 @@ msgstr "কোনো internalFlags সমৰ্থন নাই"
 msgid "no job is active on the domain"
 msgstr "ডোমেইনত কোনো সক্ৰিয় কাৰ্য্য নাই"
 
-msgid "no kernel specified"
-msgstr "কোনো কাৰ্ণেল নিৰ্ধাৰণ কৰা হোৱা নাই"
-
 msgid "no large enough free extent"
 msgstr "পৰ্যাপ্ত মুক্ত extent নাই"
 
@@ -18432,9 +18128,6 @@ msgstr "ঠিক আছে"
 msgid "online commit not supported with this QEMU binary"
 msgstr "এই QEMU বাইনাৰিৰ সৈতে অনলাইন commit সমৰ্থিত নহয়"
 
-msgid "only TCP listen is supported for chr device"
-msgstr "কেৰেক্টাৰ ডিভাইচৰ বাবে স্থান বিতৰণ কৰোঁতে ব্যৰ্থ"
-
 msgid "only a single TPM device is supported"
 msgstr "কেৱল এটা TPM ডিভাইচ সমৰ্থিত"
 
@@ -19419,9 +19112,6 @@ msgstr "বন্ধ"
 msgid "shutdown"
 msgstr "বন্ধ কৰক"
 
-msgid "shutdown operation failed"
-msgstr "বন্ধ কৰাৰ কাৰ্য্য বিফল"
-
 msgid "shutting down"
 msgstr "বন্ধ কৰা হৈছে"
 
@@ -20075,12 +19765,6 @@ msgstr "udev_monitor_new_from_netlink এ NULL ঘুৰাই দিলে"
 msgid "uid and gid should be mapped both"
 msgstr "uid আৰু gid দুয়োটা মেপ কৰিব লাগিব"
 
-msgid "uml state driver is not active"
-msgstr "uml state চালক সক্ৰিয় নহয়"
-
-msgid "umlStartup: out of memory"
-msgstr "umlStartup: মেমৰি অৱশিষ্ট নাই"
-
 #, c-format
 msgid "unable to access device %s\n"
 msgstr "ডিভাইচ %s অভিগম কৰিবলে অক্ষম\n"
@@ -20265,9 +19949,6 @@ msgstr "স্নেপশ্বট ফিল্টাৰিং পৰিৱে
 msgid "unable to poll on child"
 msgstr "ছাইল্ডত পল কৰিবলে অক্ষম"
 
-msgid "unable to probe for add-fd"
-msgstr "add-fd ৰ বাবে প্ৰৌব কৰিবলে অক্ষম"
-
 msgid "unable to read child stderr"
 msgstr "ছাইল্ড stderr পঢ়িবলে অক্ষম"
 
@@ -20418,14 +20099,6 @@ msgstr "অপ্ৰত্যাশিত QEMU URI পথ '%s', qemu:///session
 msgid "unexpected QEMU URI path '%s', try qemu:///system"
 msgstr "অপ্ৰত্যাশিত QEMU URI পথ '%s', qemu:///system প্ৰচেষ্টা কৰক"
 
-#, c-format
-msgid "unexpected UML URI path '%s', try uml:///session"
-msgstr "অপ্ৰত্যাশিত UML URI পথ '%s', uml:///session প্ৰচেষ্টা কৰক"
-
-#, c-format
-msgid "unexpected UML URI path '%s', try uml:///system"
-msgstr "অপ্ৰত্যাশিত UML URI পথ '%s', uml:///system প্ৰচেষ্টা কৰক"
-
 #, c-format
 msgid ""
 "unexpected VMware URI path '%s', try vmwareplayer:///session, vmwarews:///"
@@ -21515,10 +21188,6 @@ msgstr "অনুমোদন প্ৰণালী সমৰ্থিত নহ
 msgid "unsupported chardev '%s'"
 msgstr "অসমৰ্থিত chardev '%s'"
 
-#, c-format
-msgid "unsupported chr device type %d"
-msgstr "অসমৰ্থিত chr ডিভাইচৰ ধৰণ %d"
-
 #, c-format
 msgid "unsupported chr device type '%s'"
 msgstr "অসমৰ্থিত chr ডিভাইচ ধৰণ '%s'"

po/ast.mini.po

@@ -5,9 +5,9 @@
 #
 msgid ""
 msgstr ""
-"Project-Id-Version: libvirt 4.6.0\n"
+"Project-Id-Version: libvirt 4.10.0\n"
 "Report-Msgid-Bugs-To: https://libvirt.org/bugs.html\n"
-"POT-Creation-Date: 2018-07-31 10:44+0100\n"
+"POT-Creation-Date: 2019-01-14 16:56+0000\n"
 "PO-Revision-Date: \n"
 "Last-Translator: \n"
 "Language-Team: Asturian\n"
@@ -16,4 +16,4 @@ msgstr ""
 "Content-Type: text/plain; charset=UTF-8\n"
 "Content-Transfer-Encoding: 8bit\n"
 "Plural-Forms: nplurals=2; plural=(n != 1)\n"
-"X-Generator: Zanata 4.5.0\n"
+"X-Generator: Zanata 4.6.2\n"

po/bal.mini.po

@@ -5,9 +5,9 @@
 #
 msgid ""
 msgstr ""
-"Project-Id-Version: libvirt 4.6.0\n"
+"Project-Id-Version: libvirt 4.10.0\n"
 "Report-Msgid-Bugs-To: https://libvirt.org/bugs.html\n"
-"POT-Creation-Date: 2018-07-31 10:44+0100\n"
+"POT-Creation-Date: 2019-01-14 16:56+0000\n"
 "PO-Revision-Date: \n"
 "Last-Translator: \n"
 "Language-Team: Baluchi\n"
@@ -16,4 +16,4 @@ msgstr ""
 "Content-Type: text/plain; charset=UTF-8\n"
 "Content-Transfer-Encoding: 8bit\n"
 "Plural-Forms: nplurals=1; plural=0\n"
-"X-Generator: Zanata 4.5.0\n"
+"X-Generator: Zanata 4.6.2\n"

po/be.mini.po

@@ -5,9 +5,9 @@
 #
 msgid ""
 msgstr ""
-"Project-Id-Version: libvirt 4.6.0\n"
+"Project-Id-Version: libvirt 4.10.0\n"
 "Report-Msgid-Bugs-To: https://libvirt.org/bugs.html\n"
-"POT-Creation-Date: 2018-07-31 10:44+0100\n"
+"POT-Creation-Date: 2019-01-14 16:56+0000\n"
 "PO-Revision-Date: \n"
 "Last-Translator: \n"
 "Language-Team: Belarusian\n"
@@ -17,4 +17,4 @@ msgstr ""
 "Content-Transfer-Encoding: 8bit\n"
 "Plural-Forms: nplurals=3; plural=(n%10==1 && n%100!=11 ? 0 : n%10>=2 && n"
 "%10<=4 && (n%100<10 || n%100>=20) ? 1 : 2)\n"
-"X-Generator: Zanata 4.5.0\n"
+"X-Generator: Zanata 4.6.2\n"

po/bg.mini.po

@@ -1,5 +1,5 @@
 # Libvirt package strings.
-# Copyright (C) 2018 Red Hat, Inc.
+# Copyright (C) 2019 Red Hat, Inc.
 # This file is distributed under the same license as the PACKAGE package.
 #
 # Translators:
@@ -7,9 +7,9 @@
 # Miroslav Ivanov <kiro.kopeleto@gmail.com>, 2007.
 msgid ""
 msgstr ""
-"Project-Id-Version: libvirt 4.6.0\n"
+"Project-Id-Version: libvirt 4.10.0\n"
 "Report-Msgid-Bugs-To: https://libvirt.org/bugs.html\n"
-"POT-Creation-Date: 2018-07-31 10:44+0100\n"
+"POT-Creation-Date: 2019-01-14 16:56+0000\n"
 "PO-Revision-Date: 2015-02-26 07:16+0000\n"
 "Last-Translator: Copied by Zanata <copied-by-zanata@zanata.org>\n"
 "Language-Team: Bulgarian (http://www.transifex.com/projects/p/fedora/"
@@ -19,7 +19,7 @@ msgstr ""
 "Content-Type: text/plain; charset=UTF-8\n"
 "Content-Transfer-Encoding: 8bit\n"
 "Plural-Forms: nplurals=2; plural=(n != 1);\n"
-"X-Generator: Zanata 4.5.0\n"
+"X-Generator: Zanata 4.6.2\n"
 
 msgid ""
 "\n"
@@ -778,13 +778,6 @@ msgstr "неуспешно получаване версията на библи
 msgid "failed to mark network %s as autostarted"
 msgstr "Неуспешно маркиране на мрежата %s като авто-стартирана"
 
-#, c-format
-msgid "failed to open %s for reading"
-msgstr "грешка при отваряне на конфигурационен файл %s за четене"
-
-msgid "failed to open configuration file for reading"
-msgstr "грешка при отваряне на конфигурационния файл за четене"
-
 msgid "failed to open file"
 msgstr "неуспешно отваряне на файл"
 
@@ -844,10 +837,6 @@ msgstr "извличане състоянието на мрежов интерф
 msgid "getting time of day"
 msgstr "вземане на времето"
 
-#, c-format
-msgid "got unknown HTTP error code %d"
-msgstr "получен бе непознат HTTP код на грешка %d"
-
 msgid "gracefully shutdown a domain"
 msgstr "внимателно изключване на домейн"
 
@@ -884,14 +873,6 @@ msgstr "невалиден мрежов указател за връзка в"
 msgid "invalid network pointer in %s"
 msgstr "невалиден мрежов указател за връзка в %s"
 
-#, c-format
-msgid "library call %s failed, possibly not supported"
-msgstr ""
-"неуспешно извикване на библиотечната функция %s, може би не се поддържа"
-
-msgid "library call failed, possibly not supported"
-msgstr "неуспешно извикване на библиотечна функция, може би не се поддържа"
-
 msgid "list domains"
 msgstr "показване на домейните"
 

po/bn.mini.po

@@ -8,7 +8,7 @@ msgid ""
 msgstr ""
 "Project-Id-Version: libvirt 4.3.0\n"
 "Report-Msgid-Bugs-To: https://libvirt.org/bugs.html\n"
-"POT-Creation-Date: 2018-07-31 10:44+0100\n"
+"POT-Creation-Date: 2019-01-14 16:56+0000\n"
 "PO-Revision-Date: 2018-04-24 06:13+0000\n"
 "Last-Translator: Copied by Zanata <copied-by-zanata@zanata.org>\n"
 "Language-Team: Bengali (http://www.transifex.com/projects/p/fedora/language/"
@@ -18,4 +18,4 @@ msgstr ""
 "Content-Type: text/plain; charset=UTF-8\n"
 "Content-Transfer-Encoding: 8bit\n"
 "Plural-Forms: nplurals=2; plural=(n != 1);\n"
-"X-Generator: Zanata 4.5.0\n"
+"X-Generator: Zanata 4.6.2\n"

po/bn_IN.mini.po

@@ -1,5 +1,5 @@
 # Libvirt package strings.
-# Copyright (C) 2018 Red Hat, Inc.
+# Copyright (C) 2019 Red Hat, Inc.
 # This file is distributed under the same license as the PACKAGE package.
 #
 # Translators:
@@ -8,9 +8,9 @@
 # runab <runab@redhat.com>, 2006-2010
 msgid ""
 msgstr ""
-"Project-Id-Version: libvirt 4.6.0\n"
+"Project-Id-Version: libvirt 4.10.0\n"
 "Report-Msgid-Bugs-To: https://libvirt.org/bugs.html\n"
-"POT-Creation-Date: 2018-07-31 10:44+0100\n"
+"POT-Creation-Date: 2019-01-14 16:56+0000\n"
 "PO-Revision-Date: 2015-02-26 07:10+0000\n"
 "Last-Translator: Copied by Zanata <copied-by-zanata@zanata.org>\n"
 "Language-Team: Bengali (India) (http://www.transifex.com/projects/p/libvirt/"
@@ -20,7 +20,7 @@ msgstr ""
 "Content-Type: text/plain; charset=UTF-8\n"
 "Content-Transfer-Encoding: 8bit\n"
 "Plural-Forms: nplurals=2; plural=(n != 1);\n"
-"X-Generator: Zanata 4.5.0\n"
+"X-Generator: Zanata 4.6.2\n"
 
 msgid ""
 "\n"
@@ -534,10 +534,6 @@ msgstr "চলমান %s হাইপার-ভাইসরের সংস্
 msgid "Cannot find CPU model with PVR 0x%08x"
 msgstr "CPU মডেল PVR 0x%08x সমেত খুঁজে পাওয়া যাবে না"
 
-#, c-format
-msgid "Cannot find UML kernel %s"
-msgstr "UML কার্নেল %s অনুসন্ধান করতে ব্যর্থ"
-
 #, c-format
 msgid "Cannot find security driver '%s'"
 msgstr "নিরাপত্তা ড্রাইভার '%s' খুঁজে পাওয়া যাচ্ছে না"
@@ -671,10 +667,6 @@ msgid ""
 msgstr ""
 "spicevmc থেকে/এ ডিভাইস ধরন পরিবর্তন ডিফল্ট টার্গেট চ্যানেল নাম পরিবর্তন করবে"
 
-#, c-format
-msgid "Command %s too long for destination"
-msgstr "গন্তব্যের ক্ষেত্রে কমান্ড %s অত্যাধিক লম্বা"
-
 msgid "Compute baseline CPU for a set of given CPUs."
 msgstr "সুনির্দিষ্ট CPU-র সংকলনের জন্য CPU বেস-লাইন গণনা করুন।"
 
@@ -2291,9 +2283,6 @@ msgstr "CPU বৈশিষ্ট্যের নাম অনুপস্থি
 msgid "Missing CPU model name"
 msgstr "CPU-র মডেলের নাম অনুপস্থিত"
 
-msgid "Missing CPU vendor name"
-msgstr "CPU ভেন্ডার নাম অনুপস্থিত"
-
 #, c-format
 msgid "Missing IP address in network '%s' DNS HOST record"
 msgstr "নেটওয়ার্ক '%s' DNS HOST রেকর্ডে IP ঠিকানা অনুপস্থিত"
@@ -2345,9 +2334,6 @@ msgstr ""
 msgid "Missing or invalid PVR value in CPU model %s"
 msgstr "CPU মডেল %s এ PVR মান অনুপস্থিত বা অবৈধ"
 
-msgid "Missing or invalid auth pointer"
-msgstr "auth পয়েন্টার হয় অনুপস্থিত বা অবৈধ"
-
 #, c-format
 msgid "Missing required address attribute in network '%s'"
 msgstr "'%s' নেটওয়ার্কে প্রয়োজনীয় ঠিকানা অ্যাট্রিবিউট অনুপস্থিত"
@@ -2406,9 +2392,6 @@ msgstr "N/A"
 msgid "NULL NetworkDef"
 msgstr "NULL NetworkDef"
 
-msgid "NULL or empty path"
-msgstr "NULL অথবা পাথ ফাঁকা"
-
 msgid "NUMA cell number"
 msgstr "NUMA সেল সংখ্যা:"
 
@@ -2474,10 +2457,6 @@ msgstr "নেটওয়ার্ক  '%s' পূর্বেই সক্রি
 msgid "Network '%s' is still running"
 msgstr "নেটওয়ার্ক '%s' এখনো সক্রিয়"
 
-#, c-format
-msgid "Network '%s' not found"
-msgstr "নেটওয়ার্ক '%s' পাওয়া যায়নি"
-
 #, c-format
 msgid "Network config filename '%s' does not match network name '%s'"
 msgstr ""
@@ -2531,9 +2510,6 @@ msgstr "কোনো UNIX প্রক্রিয়া অাইডি উপ
 msgid "No address associated with hostname"
 msgstr "হোস্টনামের সংগে কোনো ঠিকানা সংশ্লিষ্ট নেই"
 
-msgid "No authentication callback provided."
-msgstr "অনুমোদনের কোনো কল-ব্যাক উপলব্ধ করা হয়নি।"
-
 msgid "No data supplied for <initarg> element"
 msgstr "<initarg> উপাদানের জন্য কোনো ডেটা সরবরাহ করা হয়নি"
 
@@ -3065,12 +3041,6 @@ msgstr "সিস্টেম সংক্রান্ত সমস্যা"
 msgid "System lacks NETNS support"
 msgstr "সিস্টেমের মধ্যে NETNS সমর্থন অনুপস্থিত"
 
-msgid "TCP client networking type not supported"
-msgstr "TCP ক্লায়েন্ট প্রকৃতির নেটওয়ার্ক সমর্থিত নয়"
-
-msgid "TCP server networking type not supported"
-msgstr "TCP সার্ভার প্রকৃতির নেটওয়ার্ক সমর্থিত নয়"
-
 msgid "Target"
 msgstr "টার্গেট"
 
@@ -3452,9 +3422,6 @@ msgstr "ডোমেইন বর্তমানে সক্রিয় নয়"
 msgid "This host is not managed by a vCenter"
 msgstr "এই হোস্ট একটি vCenter দ্বারা পরিচালিত নয়"
 
-msgid "This type of device cannot be hot unplugged"
-msgstr "এই ধরনের ডিভাইস হট-আনপ্লাগ করা সম্ভব নয়"
-
 msgid "Thread(s) per core:"
 msgstr "প্রতি কোরে থ্রেড সংখ্যা:"
 
@@ -3580,9 +3547,6 @@ msgstr "%s PCI ডিভাইস পুনরায় নির্ধারণ
 msgid "Unable to send container continue message"
 msgstr "ধারণকারীর উদ্দেশ্যে কর্মে এগিয়ে যাওয়ার বার্তা পাঠাতে ব্যর্থ"
 
-msgid "Unable to set VM logfile close-on-exec flag"
-msgstr "VM লগ-ফাইল সংক্রান্ত close-on-exec ফ্ল্যাগ নির্ধারণ করতে ব্যর্থ"
-
 msgid "Unable to set monitor close-on-exec flag"
 msgstr "মনিটর সংক্রান্ত close-on-exec ফ্ল্যাগের মান নির্ধারণ করতে ব্যর্থ"
 
@@ -3623,10 +3587,6 @@ msgstr "অপ্রত্যাশিত ডিস্ক sgio মোড '%d'"
 msgid "Unexpected hostdev mode %d"
 msgstr "অপ্রত্যাশিত hostdev মোড %d"
 
-#, c-format
-msgid "Unix path %s too long for destination"
-msgstr "গন্তব্যের ক্ষেত্রে Unix পাথ %s অত্যাধিক লম্বা"
-
 msgid "Unknown"
 msgstr "অজানা"
 
@@ -4063,15 +4023,9 @@ msgstr "কর্মের mutex প্রাপ্ত করতে ব্যর
 msgid "cannot acquire state change lock"
 msgstr "অবস্থা পরিবর্তনের লক প্রাপ্ত করতে ব্যর্থ"
 
-msgid "cannot attach device on inactive domain"
-msgstr "নিষ্ক্রিয় ডোমেইনের সাথে ডিভাইস সংযুক্ত করা যাবে না"
-
 msgid "cannot become session leader"
 msgstr "সেশানের অধিকর্তা হতে ব্যর্থ"
 
-msgid "cannot bind socket"
-msgstr "সকেট বাইন্ড করতে ব্যর্থ"
-
 msgid "cannot block signals"
 msgstr "সিগন্যাল ব্লক করা সম্ভব নয়"
 
@@ -4154,9 +4108,6 @@ msgstr "পাইপ নির্মাণ করতে ব্যর্থ"
 msgid "cannot decode CPU data for %s architecture"
 msgstr "%s আর্কিটেকচারের জন্য CPU-র জন্য ডি-কোড করা সম্ভব নয়"
 
-msgid "cannot detach device on inactive domain"
-msgstr "নিষ্ক্রিয় ডোমেইন থেকে ডিভাইস বিচ্ছিন্ন করা সম্ভব নয়"
-
 #, c-format
 msgid "cannot disable %s"
 msgstr "%s নিষ্ক্রিয় করতে ব্যর্থ"
@@ -4279,9 +4230,6 @@ msgstr "vCPU স্থাপনাও ও pCPU-র সময় প্রাপ্
 msgid "cannot initialize condition variable"
 msgstr "কন্ডিশন ভেরিয়েবল আরম্ভ করতে ব্যর্থ"
 
-msgid "cannot initialize inotify"
-msgstr "inotify আরম্ভ করতে ব্যর্থ"
-
 msgid "cannot initialize monitor condition"
 msgstr "মনিটর কন্ডিশন আরম্ভ করতে ব্যর্থ"
 
@@ -4317,17 +4265,10 @@ msgstr "macvtap tap ডিভাইস %s খুলতে ব্যর্থ"
 msgid "cannot open path '%s'"
 msgstr "পাথ '%s' খুলতে ব্যর্থ"
 
-msgid "cannot open socket"
-msgstr "সকেট খুলতে ব্যর্থ: %s"
-
 #, c-format
 msgid "cannot open volume '%s'"
 msgstr "ভলিউম '%s' খুলতে ব্যর্থ"
 
-#, c-format
-msgid "cannot parse CPU map for %s architecture"
-msgstr "%s আর্কিটেকচারের জন্য CPU ম্যাপ পার্স করা সম্ভব নয়"
-
 #, c-format
 msgid "cannot parse CPU topology '%s'"
 msgstr "CPU-র টোপোলজি '%s' পার্স করতে ব্যর্থ"
@@ -4400,6 +4341,10 @@ msgstr "instanceid প্যারামিটার uuid হিসাবে প
 msgid "cannot parse interfaceid parameter as a uuid"
 msgstr "instanceid প্যারামিটার uuid হিসাবে পার্জ করা যাবে না"
 
+#, c-format
+msgid "cannot parse json %s: %s"
+msgstr "json %s পার্স করা সম্ভব নয়: %s"
+
 #, c-format
 msgid "cannot parse partition number from target '%s'"
 msgstr "'%s' টার্গেট থেকে পার্টিশনের সংখ্যা পার্স করা সম্ভব নয়"
@@ -4455,10 +4400,6 @@ msgstr "vbd ফাইলের নাম পার্স করতে ব্য
 msgid "cannot parse vendor id %s"
 msgstr "বিক্রেতার id %s পার্স করতে ব্যর্থ"
 
-#, c-format
-msgid "cannot parse version %s"
-msgstr "%s সংস্করণ পার্স করতে ব্যর্থ"
-
 #, c-format
 msgid "cannot parse video heads '%s'"
 msgstr "ভিডিও হেড '%s' পার্স করতে ব্যর্থ"
@@ -4536,10 +4477,6 @@ msgstr "হেডার '%s' পড়তে ব্যর্থ"
 msgid "cannot read mount list '%s'"
 msgstr "মাউন্টের তালিকা '%s' পড়তে ব্যর্থ"
 
-#, c-format
-msgid "cannot read reply %s"
-msgstr "%s-র উত্তর দিতে ব্যর্থ"
-
 msgid "cannot register file watch on stream"
 msgstr "স্ট্রিমের মধ্যে ফাইল ওয়াচ নিবন্ধন করা সম্ভব নয়"
 
@@ -4566,17 +4503,9 @@ msgstr "%s ড্রাইভার লিংক মীমাংসা করত
 msgid "cannot seek to beginning of file '%s'"
 msgstr "'%s' ফাইলের প্রারম্ভে অনুসন্ধান করতে ব্যর্থ"
 
-#, c-format
-msgid "cannot send command %s"
-msgstr "কমান্ড %s পাঠাতে ব্যর্থ"
-
 msgid "cannot send to netlink socket"
 msgstr "netlink সকেটে পাঠাতে ব্যর্থ"
 
-#, c-format
-msgid "cannot send too long command %s (%d bytes)"
-msgstr "অত্যাধিক লম্বা কমান্ড %s (%d বাইট) পাঠানো সম্ভব নয়"
-
 #, c-format
 msgid "cannot set CPU affinity on process %d"
 msgstr "%d প্রসসের জন্য CPU অ্যাফিনিটি নির্ধারণ করতে ব্যর্থ"
@@ -4600,16 +4529,9 @@ msgstr "'%s' ফাইল মোড নির্ধারণ করতে ব্
 msgid "cannot set file owner '%s'"
 msgstr "'%s' ফাইলের মালিকানা নির্ধারণ করতে ব্যর্থ"
 
-msgid "cannot set max memory lower than current memory"
-msgstr ""
-"সর্বাধিক মেমরির পরিমাণ বর্তমান মেমরির তূলনায় কম পরিমাণে নির্ধারণ করা যাবে না"
-
 msgid "cannot set memory higher than max memory"
 msgstr "সর্বাধিক মেমরির পরিমাণের তূলনায় অধিক পরিমাণে মেমরি নির্ধারণ করা যাবে না"
 
-msgid "cannot set memory of an active domain"
-msgstr "সক্রিয় ডোমেইনের মেমরি নির্ধারণ করা যাবে না"
-
 #, c-format
 msgid "cannot set mode of '%s' to %04o"
 msgstr "'%s'-র মোড %04o রূপে ধার্য করা সম্ভব নয়"
@@ -4741,10 +4663,6 @@ msgstr "%s কনফিগের মান ত্রুটিপূর্ণ"
 msgid "config value %s was missing"
 msgstr "%s কনফিগ মান অনুপস্থিত"
 
-#, c-format
-msgid "config value %s was not a string"
-msgstr "%s কনফিগের মান স্ট্রিং প্রকৃতির নয়"
-
 msgid "configuration file syntax error"
 msgstr "কনফিগারেশন ফাইলের মধ্যে সিন্টেক্স সংক্রান্ত সমস্যা"
 
@@ -5369,13 +5287,6 @@ msgstr "নেটওয়ার্ক %s, স্বয়ং প্রারম্ভ
 msgid "failed to mark pool %s as autostarted"
 msgstr "পুল %s, স্বয়ং প্রারম্ভকারী রূপে চিহ্নিত করতে ব্যর্থ"
 
-#, c-format
-msgid "failed to open %s for reading"
-msgstr "পড়ার উদ্দেশ্যে %s খুলতে ব্যর্থ"
-
-msgid "failed to open configuration file for reading"
-msgstr "পড়ার উদ্দেশ্যে কনফিগারেশন ফাইল খুলতে ব্যর্থ"
-
 msgid "failed to open file"
 msgstr "ফাইল খুলতে ব্যর্থ"
 
@@ -5389,9 +5300,6 @@ msgstr "কনফিগারেশন ফাইল পার্স করতে
 msgid "failed to parse configuration file %s"
 msgstr "কনফিগারেশন ফাইল %s পার্স করতে ব্যর্থ"
 
-msgid "failed to parse xml document"
-msgstr "xml নথি পার্স করতে ব্যর্থ"
-
 msgid "failed to read XML"
 msgstr "XML পড়তে ব্যর্থ"
 
@@ -5406,10 +5314,6 @@ msgstr "কনফিগারেশন ফাইল %s পড়তে ব্যর
 msgid "failed to read metadata length in '%s'"
 msgstr "'%s'-র মধ্যে মিটাডাটার দৈর্ঘ্য পড়তে ব্যর্থ"
 
-#, c-format
-msgid "failed to read pid: %s"
-msgstr "pid পড়তে ব্যর্থ: %s"
-
 msgid "failed to read qemu header"
 msgstr "qemu হেডার পড়তে ব্যর্থ"
 
@@ -5549,10 +5453,6 @@ msgstr "ডোমেইনের জন্যা নেটওয়ার্ক ই
 msgid "getting time of day"
 msgstr "দিনের বর্তমান সময় সংগ্রহ"
 
-#, c-format
-msgid "got unknown HTTP error code %d"
-msgstr "অজানা HTTP ত্রুটির কোড %d প্রাপ্ত"
-
 msgid "gracefully shutdown a domain"
 msgstr "সঠিক পদ্ধতিতে ডোমেইন বন্ধ করুন"
 
@@ -5631,10 +5531,6 @@ msgstr "নিষ্ক্রিয়"
 msgid "include security sensitive information in XML dump"
 msgstr "XML ডাম্পের মধ্যে নিরাপত্তা সংক্রান্ত সংবেদনশীল তথ্য অন্তর্ভুক্ত করা হবে"
 
-#, c-format
-msgid "incomplete reply %s"
-msgstr "অসম্পূর্ণ উত্তর %s"
-
 #, c-format
 msgid "incomplete save header in '%s'"
 msgstr "'%s'-র মধ্যে সংরক্ষণের অসম্পূর্ণ হেডার"
@@ -5680,9 +5576,6 @@ msgstr "ইন্টারফেসের নাম অথবা MAC ঠিক
 msgid "internal error"
 msgstr "অভ্যন্তরীণ ত্রুটি"
 
-msgid "internal networking type not supported"
-msgstr "অভ্যান্তরীণ প্রকৃতির নেটওয়ার্ক সমর্থিত নয়"
-
 #, c-format
 msgid "invalid \"trunk='%s'\" in <vlan> - must be yes or no"
 msgstr "\"trunk='%s'\" <vlan> এ অবৈধ - অবশ্যই হ্যাঁ বা না হতে হবে"
@@ -6020,13 +5913,6 @@ msgstr "লেবেল ওভার-রাইডের ক্ষেত্রে
 msgid "length of metadata out of range"
 msgstr "মিটা-ডাটার দৈর্ঘ্য সীমা বহির্ভূত"
 
-#, c-format
-msgid "library call %s failed, possibly not supported"
-msgstr "লাইব্রেরি কল %s বিফল, সম্ভবত সমর্থিত নয়"
-
-msgid "library call failed, possibly not supported"
-msgstr "লাইব্রেরি কল বিফল, সম্ভবত সমর্থিত নয়"
-
 msgid "list devices in a tree"
 msgstr "ট্রি রূপে ডিভাইসের তালিকা প্রদর্শন করা হবে"
 
@@ -6707,9 +6593,6 @@ msgstr "স্বয়ংক্রিয় প্রারম্ভকরণ হব
 msgid "no block device path supplied for '%s'"
 msgstr "'%s'-র জন্য কোনো ব্লক ডিভাইসের পাথ উল্লিখিত হয়নি"
 
-msgid "no callback provided"
-msgstr "কোনো কলব্যাক প্রদান করা হয়নি"
-
 msgid "no client username was found"
 msgstr "ক্লায়েন্টের ব্যবহারকারীর নাম পাওয়া যায়নি"
 
@@ -6759,9 +6642,6 @@ msgstr "কোনো এক্সটেন্ডেড পার্টিশন
 msgid "no job is active on the domain"
 msgstr "ডোমেইনের মধ্যে কোনো সক্রিয় কাজ উপস্থিত নেই"
 
-msgid "no kernel specified"
-msgstr "কোনো কার্নেল উল্লিখিত হয়নি"
-
 msgid "no large enough free extent"
 msgstr "পর্যাপ্ত স্থানবিশিষ্ট ফাঁকা এক্সটেন্ট অনুপস্থিত"
 
@@ -6873,9 +6753,6 @@ msgstr "VMX বিন্যাসের সংখ্যা অনুমোদি
 msgid "offline"
 msgstr "অফ-লাইন"
 
-msgid "only TCP listen is supported for chr device"
-msgstr "chr ডিভাইসের জন্য শুধুমাত্র TCP listen সমর্থিত"
-
 msgid "only a single TPM device is supported"
 msgstr "শুধুমাত্র একটি TPM ডিভাইস সমর্থিত হবে"
 
@@ -7200,9 +7077,6 @@ msgstr "সময় নির্ধারণকারী সংক্রান্
 msgid "shut off"
 msgstr "বন্ধ"
 
-msgid "shutdown operation failed"
-msgstr "বন্ধ করার কর্ম বিফল"
-
 msgid "size > maximum buffer size"
 msgstr "মাপ > বাফারের সর্বাধিক মাপ"
 
@@ -7523,12 +7397,6 @@ msgstr "পুলের ধরন"
 msgid "uid and gid should be mapped both"
 msgstr "uid এবং gid এর উভয়ই ম্যাপ করা উচিত"
 
-msgid "uml state driver is not active"
-msgstr "uml state ড্রাইভার সক্রিয় নয়"
-
-msgid "umlStartup: out of memory"
-msgstr "umlStartup: মেমরি অবশিষ্ট নেই"
-
 #, c-format
 msgid "unable to create hugepage path %s"
 msgstr "hugepage পাথ %s নির্মাণ করতে ব্যর্থ"
@@ -7644,14 +7512,6 @@ msgstr "অপ্রত্যাশিত QEMU URI পাথ '%s', qemu:///sessi
 msgid "unexpected QEMU URI path '%s', try qemu:///system"
 msgstr "অপ্রত্যাশিত QEMU URI পাথ '%s', qemu:///system প্রচেষ্টা করুন"
 
-#, c-format
-msgid "unexpected UML URI path '%s', try uml:///session"
-msgstr "অপ্রত্যাশিত UML URI পাথ '%s', uml:///session প্রচেষ্টা করুন"
-
-#, c-format
-msgid "unexpected UML URI path '%s', try uml:///system"
-msgstr "অপ্রত্যাশিত UML URI পাথ '%s', uml:///system প্রচেষ্টা করুন"
-
 #, c-format
 msgid "unexpected accessmode %d"
 msgstr "অপ্রত্যাশিত accessmode %d"
@@ -8464,10 +8324,6 @@ msgstr "অসমর্থিত ঠিকানা ধরন '%s' %s নেট
 msgid "unsupported authentication type %d"
 msgstr "অনুমোদন প্রণালী সমর্থিত নয় %d"
 
-#, c-format
-msgid "unsupported chr device type %d"
-msgstr "অসমর্থিত chr ডিভাইসের ধরন %d"
-
 #, c-format
 msgid "unsupported clock offset '%s'"
 msgstr "ঘড়ির offset '%s' সমর্থিত নয়"

po/bo.mini.po

@@ -5,9 +5,9 @@
 #
 msgid ""
 msgstr ""
-"Project-Id-Version: libvirt 4.6.0\n"
+"Project-Id-Version: libvirt 4.10.0\n"
 "Report-Msgid-Bugs-To: https://libvirt.org/bugs.html\n"
-"POT-Creation-Date: 2018-07-31 10:44+0100\n"
+"POT-Creation-Date: 2019-01-14 16:56+0000\n"
 "PO-Revision-Date: \n"
 "Last-Translator: \n"
 "Language-Team: Tibetan\n"
@@ -16,4 +16,4 @@ msgstr ""
 "Content-Type: text/plain; charset=UTF-8\n"
 "Content-Transfer-Encoding: 8bit\n"
 "Plural-Forms: nplurals=1; plural=0\n"
-"X-Generator: Zanata 4.5.0\n"
+"X-Generator: Zanata 4.6.2\n"

po/br.mini.po

@@ -5,9 +5,9 @@
 #
 msgid ""
 msgstr ""
-"Project-Id-Version: libvirt 4.6.0\n"
+"Project-Id-Version: libvirt 4.10.0\n"
 "Report-Msgid-Bugs-To: https://libvirt.org/bugs.html\n"
-"POT-Creation-Date: 2018-07-31 10:44+0100\n"
+"POT-Creation-Date: 2019-01-14 16:56+0000\n"
 "PO-Revision-Date: \n"
 "Last-Translator: \n"
 "Language-Team: Breton\n"
@@ -16,4 +16,4 @@ msgstr ""
 "Content-Type: text/plain; charset=UTF-8\n"
 "Content-Transfer-Encoding: 8bit\n"
 "Plural-Forms: nplurals=2; plural=(n > 1)\n"
-"X-Generator: Zanata 4.5.0\n"
+"X-Generator: Zanata 4.6.2\n"

po/brx.mini.po

@@ -5,9 +5,9 @@
 #
 msgid ""
 msgstr ""
-"Project-Id-Version: libvirt 4.6.0\n"
+"Project-Id-Version: libvirt 4.10.0\n"
 "Report-Msgid-Bugs-To: https://libvirt.org/bugs.html\n"
-"POT-Creation-Date: 2018-07-31 10:44+0100\n"
+"POT-Creation-Date: 2019-01-14 16:56+0000\n"
 "PO-Revision-Date: \n"
 "Last-Translator: \n"
 "Language-Team: Bodo\n"
@@ -16,4 +16,4 @@ msgstr ""
 "Content-Type: text/plain; charset=UTF-8\n"
 "Content-Transfer-Encoding: 8bit\n"
 "Plural-Forms: nplurals=2; plural=(n != 1)\n"
-"X-Generator: Zanata 4.5.0\n"
+"X-Generator: Zanata 4.6.2\n"