1
0
mirror of https://github.com/OpenNebula/one.git synced 2024-12-22 13:33:52 +03:00
Commit Graph

19935 Commits

Author SHA1 Message Date
Ruben S. Montero
e433ccb85b
F #5516: New backup interface for OpenNebula
co-authored-by: Frederick Borges <fborges@opennebula.io>
co-authored-by: Neal Hansen <nhansen@opennebula.io>
co-authored-by: Daniel Clavijo Coca <dclavijo@opennebula.io>
co-authored-by: Pavel Czerný <pczerny@opennebula.systems>

BACKUP INTERFACE
=================

* Backups are exposed through a a special Datastore (BACKUP_DS) and
  Image (BACKUP) types. These new types can only be used for backup'ing
  up VMs. This approach allows to:

  - Implement tier based backup policies (backups made on different
    locations).

  - Leverage access control and quota systems

  - Support differnt storage and backup technologies

* Backup interface for the VMs:

  - VM configures backups with BACKUP_CONFIG. This attribute can be set
    in the VM template or updated with updateconf API call. It can include:

    + BACKUP_VOLATILE: To backup or not volatile disks

    + FS_FREEZE: How the FS is freeze for running VMs (qemu-agent,
      suspend or none). When possible backups are crash consistent.

    + KEEP_LAST: keep only a given number of backups.

  - Backups are initiated by the one.vm.backup API call that requires
    the target Datastore to perform the backup (one-shot). This is
    exposed by the onevm backup command.

  - Backups can be periodic through scheduled actions.

  - Backup configuration is updated with one.vm.updateconf API call.

* Restore interface:

  - Restores are initiated by the one.image.restore API call. This is
    exposed by oneimage restore command.

  - Restore include configurable options for the VM template

    + NO_IP: to not preserve IP addresses (but keep the NICs and network
      mapping)

    + NO_NIC: to not preserve network mappings

  - Other template attributes:

    + Clean PCI devices, including network configuration in case of TYPE=NIC
    attributes. By default it removes SHORT_ADDRESS and leave the "auto"
    selection attributes.

    + Clean NUMA_NODE, removes node id and cpu sets. It keeps the NUMA node

  - It is possible to restore single files stored in the repository by
    using the backup specific URL.

* Sunstone (Ruby version) has been updated to expose this feautres.

BACKUP DRIVERS & IMPLEMENTATION
===============================

* Backup operation is implemented by a combination of 3 driver operations:

  - VMM. New (internal oned <-> one_vmm_exec.rb) to orchestrate
    backups for RUNNING VMs.

  - TM. This commit introduces 2 new operations (and their
    corresponding _live variants):

    + pre_backup(_live): Prepares the disks to be back'ed up in the
      repository. It is specific to the driver: (i) ceph uses the export
      operation; (ii) qcow2/raw uses snapshot-create-as and fs_freeze as
      needed.
    + post_backup(_live): Performs cleanning operations, i.e. KVM
      snapshots or tmp dirs.

  - DATASTORE. Each backup technology is represented by its
    corresponfing driver, that needs to implement:

    + backup: it takes the VM disks in file (qcow2) format and stores it
      the backup repository.

    + restore: it takes a backup image and restores the associated disks
      and VM template.

    + monitor: to gather available space in the repository

    + rm: to remove existing backups

    + stat: to return the "restored" size of a disk stored in a backup

    + downloader pseudo-URL handler: in the form
      <backup_proto>://<driver_snapshot_id>/<disk filename>

BACKUP MANAGEMENT
=================

Backup actions may potentially take some time, leaving some vmm_exec threads in
use for a long time, stucking other vmm operations. Backups are planned
by the scheduler through the sched action interface.

Two attributes has been added to sched.conf:
  * MAX_BACKUPS max active backup operations in the cloud. No more
    backups will be started beyond this limit.

  * MAX_BACKUPS_HOST max number of backups per host

* Fix onevm CLI to properly show and manage schedule actions. --schedule
  supports now, as well as relative times +<seconds_from_stime>

  onvm backup --schedule now -d 100 63

* Backup is added as VM_ADMIN_ACTIONS in oned.conf. Regular users needs
  to use the batch interface or request specific permissions

Internal restructure of Scheduler:

- All sched_actions interface is now in SchedActionsXML class and files.
  This class uses references to VM XML, and MUST be used in the same
  lifetime scope.

- XMLRPC API calls for sched actions has been moved to ScheduledActionXML.cc as
  static functions.

- VirtualMachineActionPool includes counters for active backups (total
  and per host).

SUPPORTED PLATFORMS
====================
* hypervisor: KVM
* TM: qcow2/shared/ssh, ceph
* backup: restic, rsync

Notes on Ceph

* Ceph backups are performed in the following steps:
    1. A snapshot of each disk is taken (group snapshots cannot be used as
       it seems we cannot export the disks afterwards)
    2. Disks are export to a file
    3. File is converted to qcow2 format
    4. Disk files are upload to the backup repo

TODO:
  * Confirm crash consistent snapshots cannot be used in Ceph

TODO:
  * Check if using VM dir instead of full path is better to accomodate
    DS migrations i.e.:
    - Current path: /var/lib/one/datastores/100/53/backup/disk.0
    - Proposal: 53/backup/disk.0

RESTIC DRIVER
=============
Developed together with this feature is part of the EE edtion.

* It supports the SFTP protocol, the following attributes are
  supported:

  - RESTIC_SFTP_SERVER
  - RESTIC_SFTP_USER: only if different from oneadmin
  - RESTIC_PASSWORD
  - RESTIC_IONICE: Run restic under a given ionice priority (class 2)
  - RESTIC_NICE: Run restic under a given nice
  - RESTIC_BWLIMIT: Limit restic upload/download BW
  - RESTIC_COMPRESSION: Restic 0.14 implements compression (three modes:
    off, auto, max). This requires repositories version 2. By default,
    auto is used (average compression without to much CPU usage)
  - RESTIC_CONNECTIONS: Sets the number of concurrent connections to a
    backend (5 by default). For high-latency backends this number can be
    increased.

* downloader URL: restic://<datastore_id>/<snapshot_id>/<file_name>
  snapshot_id is the restic snapshot hash. To recover single disk images
  from a backup. This URLs support:

  - RESTIC_CONNECTIONS
  - RESTIC_BWLIMIT
  - RESTIC_IONICE
  - RESTIC_NICE

  These options needs to be defined in the associated datastore.

RSYNC DRIVER
=============
A rsync driver is included as part of the CE distribution. It uses the
rsync tool to store backups in a remote server through SSH:

* The following attributes are supported to configure the backup
  datastore:

  - RSYNC_HOST
  - RSYNC_USER
  - RSYNC_ARGS: Arguments to perform the rsync operatin (-aS by default)

* downloader URL: rsync://<ds_id>/<vmid>/<hash>/<file> can be used to recover
  single files from an existing backup. (RSYNC_HOST and RSYN_USER needs
  to be set in ds_id

EMULATOR_CPUS
=============

This commit includes a non related backup feature:

* Add EMULATOR_CPUS (KVM). This host (or cluster attribute) defines the
  CPU IDs where the emulator threads will be pinned. If this value is
  not defined the allocated CPU wll be used when using a PIN policy.

(cherry picked from commit a9e6a8e000e9a5a2f56f80ce622ad9ffc9fa032b)

F OpenNebula/one#5516: adding rsync backup driver

(cherry picked from commit fb52edf5d009dc02b071063afb97c6519b9e8305)

F OpenNebula/one#5516: update install.sh, add vmid to source, some polish

Signed-off-by: Neal Hansen <nhansen@opennebula.io>
(cherry picked from commit 6fc6f8a67e435f7f92d5c40fdc3d1c825ab5581d)

F OpenNebula/one#5516: cleanup

Signed-off-by: Neal Hansen <nhansen@opennebula.io>
(cherry picked from commit 12f4333b833f23098142cd4762eb9e6c505e1340)

F OpenNebula/one#5516: update downloader, default args, size check

Signed-off-by: Neal Hansen <nhansen@opennebula.io>
(cherry picked from commit 510124ef2780a4e2e8c3d128c9a42945be38a305)

LL

(cherry picked from commit d4fcd134dc293f2b862086936db4d552792539fa)
2022-10-07 22:01:37 +02:00
Ruben S. Montero
ae136f0d97
M #-: Better error messages for x509 driver
(cherry picked from commit 6e14f51ab9)
2022-10-07 13:46:58 +02:00
Tino Vázquez
57403566b2
L #-: Change max line length in ruby scripts
from 80 to 100
2022-10-06 16:55:55 +02:00
Christian González
ab48cd242b
L #: Lint OneFlow files (#2300) 2022-10-06 16:40:54 +02:00
Victor Palma
3f300f3bf9
B #5968: Fix GPU/vGPU list and handle (#2299)
(cherry picked from commit bd4f53e15c)
2022-10-06 11:05:22 +02:00
Christian González
d39c229d93
B #5814: OneFlow server creates clients as needed
Oneflow do not caches OpenNebulaClient objects and generate a new one
whenever an user operation needs to be made.

* onflow-server sends the @username down to the flow components, so it
  can create serveradmin tokens when needed in callbacks. Athentication is
  performed in the flow-server

* Direct (non-cb) actions receive a fresh client each time to execute
  the operation

(cherry picked from commit 8980e1b0ff)
2022-10-05 12:48:11 +02:00
Ruben S. Montero
74bc751bd7
F #5940: Improve PCI Passthrough and SRIOV support
- SHORT_ADDRESS can be used to select specific devices  (useful on
  homogenous clusters or nic attach operations). This name has been
  selected because of:
    1. It is the attrbute shown host info
    2. It does not collide with the reserved ADDRESS attribute

- New test and add functions that considers both allocation methods: by
  name (VENDOR/CLASS/DEVICE) or address (SHORT_ADDRESS)

- Parameter check on VM creation

- revert and add method use the same pci_attribute function to add info
  to the VM PCI attribute

- Remove well-known attributes when parsing PCI devices (ADDRESS,
  PREV_ADDRES, BUS, FUNCTION, SLOT, NUMA_NODE, UUID)

- Support for attach and detach NIC with PCI attributes
    * onevm_exec.rb looks for PCI devices for ATTACH=YES when attaching/detaching an interface
    * script action are now written in Ruby
    * KVM module with common actions (hostdev/interface device str)
    * Minor changes in xmlparser and OpenNebulaVM classes

- PCI selection options to onevm nic-attach:
    * pci short_address
    * pci_device device ID
    * pci_vendor vendor ID
    * pci_class class ID

- VF can be configured by setting some parameters through IP link (e.g.
  MAC or VLAN_ID). This commit includes a mixin to activate_vf

    * one_vmm_exec.rb looks for PCI VN_MAD drivers
    * VM class (VNM) adds a @pcis array
    * activate_vf should be called in the pre stage. The following drivers
      acticate VFs (VLAN_ID is implemented as 802.1Q tag)
            - 802.1Q
            - bridge
            - fw
            - ovswitch
    * Supported attributes for VF:
      - MAC
      - VLAN_ID
      - spoof checking (SPOOFCHK)
      - trust (TRUST)

- Predictable PCI addresses for guests is only enabled if PCI bus 1
  is present (PCI bridge bus cannot be hotplugged)

- Improve integration with Libvirt/QEMU:

    * When attach, only activate the VF being attached
    * Attach: Use <interface> and not <hostdev> for VF. There seems to be a race
      condition between accessing the vfio device and permission setup.
    * Attach: Remove address on attach as it may fail beacuse PCI controller
      is not present, e.g.:

        ATTACHNIC: Could not attach NIC to 28534240: error: Failed to attach device
        from /dev/fd/63 error: XML error: Invalid PCI address 0000:01:01.0.
        Only PCI buses up to 0 are available ExitCode: 1

    * Detach: Detach always use <hostdev> as libvirt fails to identified the
      device just by address when using <interface>

- Suntone Support: The "Hardware" profile of a network interface (NIC) of a VM can be of three types, now exposed in Sunstone:

    * "Emulated" it includes the hardware model emulated by Qemu
    * "PCI - Automatic" oned hw scheduler will pick the best PCI device for the NIC
    * "PCI - Manual" user can specify the PCI device by its short-address as shown in host information

This commits also enables the attach/detach operations on PCI based NICs in Suntone. *Note*: only for KVM VMs

(reverts commit aafd5f3014)
(reverts commit 671ef0b2d91aba00b1e6c63e19c4a50c3af20f6f)
2022-10-04 20:53:08 +02:00
Ruben S. Montero
a411993e5e
M #-: Reword extra providers
(cherry picked from commit af4332f939)
2022-10-04 19:00:36 +02:00
onenhansen
febcadef8b
B #331: Fix default scope (#2294)
OpenNebula/terraform-provider-opennebula#331
2022-10-04 10:34:32 +02:00
Daniel Boca
304126d9b0
F #5917: Added proxy feature for datastore (#2292)
also .gitignore for vscode workspace file
2022-09-27 11:10:49 +02:00
Tino Vázquez
e28896940b M #-: Add onelog support for dev deployments 2022-09-23 14:55:57 +02:00
Jorge Miguel Lobo Escalona
de731ec3e2
M #~: Fix CPU capacity with cpu_factor (#2291) 2022-09-23 13:35:22 +02:00
Ruben S. Montero
7967ffd714
M #-: Fix CPU capacity
For some versions of lscpu scaling is also returned in the form:

CPU(s):                          8
CPU(s) scaling MHz:              55%

So /CPU\(s\)/ matches both lines and the TOTAL_CPU value is not properly
computed

(cherry picked from commit 62c265b502)
2022-09-23 00:28:04 +02:00
Jorge Miguel Lobo Escalona
8d3c11de75
F #5903: Security Groups Sunstone (#2288) 2022-09-19 18:41:18 +02:00
Pavel Czerný
4ac2cd4f77
B #5960: Do not release VNC port if undeploy fails (#2272)
(cherry picked from commit 9b8487ec04)
2022-09-16 12:14:22 +02:00
Christian González
970b24722a
M #: Add kvm-shared to LIVE_DISK_SNAPSHOTS (#2282)
After merging both qcow2 and shared TM_MADs the resulting driver
automatically identifies the image format and perform the snapshot
using the corresponding format. This enable the support to perform
live disk snapshots when using shared storage.
2022-09-16 10:28:25 +02:00
Victor Palma
e411d0d4fc
B #5927: Fix domfsthaw timeout (#2280)
(cherry picked from commit a2caade29a)
2022-09-15 13:08:53 +02:00
Victor Palma
3411e80ff0
B #5243: Fix encoding in java binding (#2279)
(cherry picked from commit bcd319feb3)
2022-09-13 10:35:29 +02:00
onenhansen
6b1127f180
F #5328: Update logrotate behavior to avoid long restarts (#2275) 2022-09-12 18:57:07 +02:00
Frederick Borges
aafd5f3014
F #5940: Support PCI Network Devices on RSunstone (#2274)
The "Hardware" profile of a network interface (NIC) of a VM can be of three types, now exposed in Sunstone:

- "Emulated" it includes the hardware model emulated by Qemu
- "PCI - Automatic" oned hw scheduler will pick the best PCI device for the NIC
- "PCI - Manual" user can specify the PCI device by its short-address as shown in host information

This commits also enables the attach/detach operations on PCI based NICs

*Note*: only for KVM VMs

Signed-off-by: Frederick Borges <fborges@opennebula.io>
(cherry picked from commit a3d5d61d4245a7936372e4a6c5dee4b6939f62f4)
2022-09-12 16:00:49 +02:00
Jorge Miguel Lobo Escalona
5b2dc75474
F #5928: Add missing dependencies (#2277) 2022-09-12 15:34:36 +02:00
Tino Vázquez
2f21cd1383
L #-: Fix linting issues 2022-09-12 13:18:29 +02:00
Jorge Miguel Lobo Escalona
a06b82293f
F #5928: Graphs (#2276) 2022-09-12 11:40:36 +02:00
Christian González
b27302cc7d
B #5933: honor DRIVER attribute when cloning imgs (#2273)
Ensure that if the destination DS when cloning an image have a DRIVER set. The image is automatically converted during the cloning process for the fs driver.

(cherry picked from commit 69759b30cc)
2022-09-08 18:27:15 +02:00
Anton Todorov
7961ae2416
B #5869: Filter out unsupported CPU models
Decided to format it as a patch than an entire rewrite of the probe script.
This could be rewritten to populate the models array with the supported only.
2022-09-08 10:10:02 +02:00
Alex
542fb9873d
M #-: GitHub Workflows security hardening
This PR adds explicit permissions section to workflows. This is a security best practice because by default workflows run with extended set of permissions (except from on: pull_request from external forks). By specifying any permission explicitly all others are set to none. By using the principle of least privilege the damage a compromised workflow can do (because of an injection or compromised third party tool or action) is restricted.
It is recommended to have most strict permissions on the top level and grant write permissions on job level case by case.

Signed-off-by: sashashura <93376818+sashashura@users.noreply.github.com>
(cherry picked from commit b23ad3a54c)
2022-09-08 09:48:32 +02:00
Ruben S. Montero
907f26050f
F #5940: Improve PCI Passthrough and SRIOV support
- SHORT_ADDRESS can be used to select specific devices  (useful on
  homogenous clusters or nic attach operations). This name has been
  selected because of:
    1. It is the attrbute shown host info
    2. It does not collide with the reserved ADDRESS attribute

- New test and add functions that considers both allocation methods: by
  name (VENDOR/CLASS/DEVICE) or address (SHORT_ADDRESS)

- Parameter check on VM creation

- revert and add method use the same pci_attribute function to add info
  to the VM PCI attribute

- Remove well-known attributes when parsing PCI devices (ADDRESS,
  PREV_ADDRES, BUS, FUNCTION, SLOT, NUMA_NODE, UUID)

- Support for attach and detach NIC with PCI attributes
    * onevm_exec.rb looks for PCI devices for ATTACH=YES when attaching/detaching an interface
    * script action are now written in Ruby
    * KVM module with common actions (hostdev/interface device str)
    * Minor changes in xmlparser and OpenNebulaVM classes

- PCI selection options to onevm nic-attach:
    * pci short_address
    * pci_device device ID
    * pci_vendor vendor ID
    * pci_class class ID

- VF can be configured by setting some parameters through IP link (e.g.
  MAC or VLAN_ID). This commit includes a mixin to activate_vf.

    * one_vmm_exec.rb looks for PCI VN_MAD drivers
    * VM class (VNM) adds a @pcis array
    * activate_vf should be called in the pre stage. The following drivers
      acticate VFs (VLAN_ID is implemented as 802.1Q tag)
            - 802.1Q
            - bridge
            - fw
            - ovswitch

- Improve integration with Libvirt/QEMU:

    * When attach, only activate the VF being attached
    * Attach: Use <interface> and not <hostdev> for VF. There seems to be a race
      condition between accessing the vfio device and permission setup.
    * Attach: Remove address on attach as it may fail beacuse PCI controller
      is not present, e.g.:

        ATTACHNIC: Could not attach NIC to 28534240: error: Failed to attach device
        from /dev/fd/63 error: XML error: Invalid PCI address 0000:01:01.0.
        Only PCI buses up to 0 are available ExitCode: 1

    * Detach: Detach always use <hostdev> as libvirt fails to identified the
      device just by address when using <interface>
2022-09-07 15:54:38 +02:00
Frederick Borges
f3f28e3227
B #~: Fix VMRC with users passwords with special chars (#2271) 2022-09-05 10:21:15 +02:00
Frederick Borges
bf31d21a17
B #~: Fix VMRC with Apache (#2270) 2022-08-31 12:44:35 +02:00
Jan Orel
57e738c424
B #5946: Compare group_admin groups case-insens. (#2269) 2022-08-31 10:37:44 +02:00
Pavel Czerný
c96f43a782
B #5954: Do not reuse Cipher instance (#2268)
(cherry picked from commit 4ea39c0ee0)
2022-08-29 17:17:28 +02:00
Tino Vazquez
193b789c13 Merge branch 'master' of https://github.com/OpenNebula/one-ee 2022-08-26 10:47:39 +02:00
Pavel Czerný
0b3f786441
F #5943: Update verbose msg for async commands (#2263)
(cherry picked from commit cd35ad4eaa)
2022-08-25 20:07:07 +02:00
Jan Orel
c1f5c649f2
B #5947: PyOne: allow set https_verify = False (#2265) 2022-08-25 19:11:19 +02:00
Kristian Feldsam
7577762f04
M #-: Fix install by removing obsolte share dirs
Related to commit M #-: Get rid of obsolete .vib files d019bd49a6

Signed-off-by: Kristian Feldsam <feldsam@gmail.com>
(cherry picked from commit dcc9b57e26)
2022-08-25 18:11:38 +02:00
Jorge Miguel Lobo Escalona
bf27770617
F #5928: monitoring graphics (#2260) 2022-08-25 12:57:10 +02:00
Pavel Czerný
a09aa7fab8
F #937: Do not release image if other disk uses it (#2262)
(cherry picked from commit 015d842467)
2022-08-25 10:20:17 +02:00
Jan Orel
479bfd0807
B #5946: Fix parsing * in the group list (#2261)
Regression introduced by68ce7dc0 

With the addition to skipws, peek() will read the next whitespace in the buffer. The logic has been changed to use the extraction operator so ws are consumed. The peek - get is now changed by >> - unget calls
2022-08-22 11:10:56 +02:00
Frederick Borges
906eea460a
F #5930: Crtl + click for multiple selection (#2258) 2022-08-16 11:39:22 +02:00
Frederick Borges
d83176923c
F #5931: Deprecate ebtables and vcenter on vnets (#2257) 2022-08-16 11:38:09 +02:00
Pierre Lafievre
24a3c4cf20
B #5914: fix double lines
Signed-off-by: Pierre Lafievre <pierre.lafievre@iguanesolutions.com>
(cherry picked from commit df3f44d68d)
2022-08-09 17:10:27 +02:00
Jan Orel
39a4108e32
F OpenNebula/one-infra#331: Alma9/RHEL9 support (#2248)
* gem locks
* npm openssl legacy
2022-08-05 09:46:45 +02:00
Ruben S. Montero
6591620fcc
commit 84fb0bb65a24afe860c6d32d111a38438a932ff6
Author: vickmp <vpalma@opennebula.io>
Date:   Thu Jul 7 17:31:56 2022 +0200

    B #1276: Remove ec2/occi auth references
2022-08-02 11:39:12 +02:00
Jan Orel
5a01a4d0a2
M #-: Add guacd onecfg definition, allow yaml aliases (#2247)
* M #-: Add guacd onecfg definition

* M #-: Load sunstone yamls with aliases
2022-08-02 10:32:18 +02:00
Tino Vazquez
26059fe5fc Merge branch 'master' of https://github.com/OpenNebula/one-ee 2022-07-28 13:54:30 +02:00
Ruben S. Montero
24d4c8b9d4
B #5936: Honor VALIDATE in updateconf
(cherry picked from commit 1c1151d966f1255f81619c0f571883e5703e1e5f)
(cherry picked from commit c0ba720d31)
2022-07-28 13:38:04 +02:00
Tino Vazquez
a0436b8415 Merge branch 'master' of https://github.com/OpenNebula/one-ee 2022-07-28 12:00:37 +02:00
Jorge Miguel Lobo Escalona
c5e400580b
F #5902: Add admin and user view yaml (#2253) 2022-07-28 11:59:10 +02:00
Jorge Miguel Lobo Escalona
b1b37fb77c
F #5902: Sunstone File Tab (#2252) 2022-07-28 11:26:58 +02:00
Pavel Czerný
34630f1128
B #5935: onedb fsck rm network quota with empty ID (#2254)
(cherry picked from commit 665e2bb802)
2022-07-28 11:25:02 +02:00