1
0
mirror of https://github.com/systemd/systemd.git synced 2025-01-10 05:18:17 +03:00
Commit Graph

74805 Commits

Author SHA1 Message Date
Zbigniew Jędrzejewski-Szmek
fefd60bf7a cryptenroll,homectl,journalctl: adjust messages before qrcodes
Users will generally know what a qrcode is, so let's not treat them as dumb and
explain that it can be scanned. OTOH, we should say what the qrcode contains
and it is useful to give a hint why the users would want to scan it. Reword
messages accordingly.

(Also, don't say "to your phone", when somebody might be using a stolen phone,
or something else then a phone.)

(cherry picked from commit 10faa40ba7)
2024-11-13 19:48:10 +00:00
Zbigniew Jędrzejewski-Szmek
0ec7854d44 bsod: make message for qrcode more useful
People know what a qrcode is. We don't need to tell them to scan it.
Instead, we should say what the code contains.

While at it, rename "stream" to "f" in line with the usual style.

(cherry picked from commit abf1cae0a7)
2024-11-13 19:48:10 +00:00
Daan De Meyer
e22d571f6b docs: Align some comments in HACKING.md
(cherry picked from commit a33f453702)
2024-11-13 19:48:10 +00:00
hugo303
40cab4a387 analyze: Add times in seconds for Activating and Activated in tooltip
Print the times in seconds in the tooltip to remove the need to count
and trying to follow the lines in the svg diagram in order to see at
what times these events happen.

(cherry picked from commit f172dfddde)
2024-11-13 19:48:10 +00:00
Mike Yuan
b2496d151a TEST-80-NOTIFYACCESS: don't specify --pid= if MAINPID= is provided explicitly
Otherwise, with recent additions, the MAINPIDFDID= generated by
systemd-notify would mismatch with overridden MAINPID=.

(cherry picked from commit c3ecb747f1)
2024-11-13 19:48:10 +00:00
Zbigniew Jędrzejewski-Szmek
bbda54c671 qrcode-util: avoid memleak in error path
(cherry picked from commit 439306da8b)
2024-11-13 19:48:10 +00:00
Zbigniew Jędrzejewski-Szmek
bbdb5f97a9 test-terminal-util: print value of colors_enabled()
This makes it easier to diagnose why colors are disabled.

(cherry picked from commit b137b29798)
2024-11-13 19:48:10 +00:00
Zbigniew Jędrzejewski-Szmek
f23efaf96d bsod: do not check for color support
When invoked on a running system, bsod would not print the qrcode.
The check for "color support" on stdout is pointless, since we're not
printing to stdout but to a terminal fd that is opened separately.

(cherry picked from commit 5a64c86936)
2024-11-13 19:48:10 +00:00
Zbigniew Jędrzejewski-Szmek
b3fd2104bc qrcode-util: add debug message to show why a qrcode wasn't printed
(cherry picked from commit f0764b98e5)
2024-11-13 19:48:10 +00:00
Zbigniew Jędrzejewski-Szmek
6a4ff7a5c1 sysv-generator: break long message into lines
The journal handles multi-line messages nicely, and they are easier
to read. Drop the recycling symbol, there is no circular process here,
we go from a to b and never back to a again.

(cherry picked from commit bb56c27fc8)
2024-11-13 19:48:10 +00:00
Zbigniew Jędrzejewski-Szmek
3190a427b9 sd-id128: mark functions as const, not pure
We would need to use pure if the funtion was getting pointers and
dereferencing them. But sd128_t is a structure and those functions
only access the parameters of the call.

(cherry picked from commit dc32b09b70)
2024-11-13 19:48:10 +00:00
Zbigniew Jędrzejewski-Szmek
a5e128ca26 sd-common: add __const__
const is stronger than pure, see
https://gcc.gnu.org/onlinedocs/gcc/Common-Function-Attributes.html#index-pure-function-attribute
and
https://gcc.gnu.org/onlinedocs/gcc/Common-Function-Attributes.html#index-const-function-attribute.

(cherry picked from commit 955c51c087)
2024-11-13 19:48:10 +00:00
Zhou Qiankang
963171cf41 meson: add loongarch64's definition to cpu_arch_defines
The default definition to add is `-D__loongarch64__`, which is not searched in [bpf_tracing.h](09b9e83102/src/bpf_tracing.h (L68))

This may avoid `error: Must specify a BPF target arch via __TARGET_ARCH_xxx` in loongarch64

Signed-off-by: Zhou Qiankang <wszqkzqk@qq.com>
(cherry picked from commit 85d0aff84c)
2024-11-13 19:48:10 +00:00
Mike Yuan
b9ff85ece7 core/service: use log_unit_* where appropriate
(cherry picked from commit 1e8f0beee4)
2024-11-13 19:48:10 +00:00
Yu Watanabe
7455e76221 sd-event: fix memleak when built without assertion
Fixes a bug introduced by baf3fdec27.

This also adds several assertions at the beginning of the function.

Fixes #34899.

(cherry picked from commit 5dc0668802)
2024-11-13 19:48:10 +00:00
Lennart Poettering
3f40451c0b test: add quick test to verify the PAM stack really ran in all run0 modes of operation
(cherry picked from commit f515ea1cd4)
2024-11-13 19:48:10 +00:00
Lennart Poettering
0f7efb0cfc core: make sure that if PAMName= is set we always do the full user changing even if no user is specified explicitly
When PAMName= is set this should be enough to go through our entire user
changing story, so that PAM is definitely run, and environment variables
definitely pulled in and so on.

Previously, it would happen that under some circumstances we might no do
this when transitioning from root to root itself even though PAM was
enabled.

Fixes: #34682
(cherry picked from commit e4b4d9cc7a)
2024-11-13 19:48:10 +00:00
Antonio Alvarez Feijoo
7a369c3971 man/veritysetup-generator: document veritytab kernel command line option
(cherry picked from commit e98e3f856d)
2024-11-13 19:48:10 +00:00
Antonio Alvarez Feijoo
139106140e man: fix links to veritysetup(8)
(cherry picked from commit dcbfc7872e)
2024-11-13 19:48:10 +00:00
Łukasz Stelmach
7408f26538 core: don't forget about fallback_smack_process_label
Call setup_smack() also when only fallback_smack_process_label is set.

Fixes: 75689fb2d4
(cherry picked from commit 20bbf5ee4c)
2024-11-13 19:48:10 +00:00
Luca Boccassi
0852240f92 logind: allow read/write to char-hvc devices
virtio console uses /dev/hvc* so we need access to write wall
messages

(cherry picked from commit 5ff6841c23)
2024-11-13 19:48:10 +00:00
Yu Watanabe
5cd2f61a05 TEST-02-UNITTESTS: reuse $TEST_MATCH_SUBTEST to specify unit tests to be run
Then, we can easily test specific unit tests in qemu or container.

(cherry picked from commit aa7507ea4a)
2024-11-13 19:48:10 +00:00
Yu Watanabe
eaab857aba test-execute: update permission of credstore
Follow-up for 40fb9eebbc.

(cherry picked from commit c443f6924f)
2024-11-13 19:48:10 +00:00
Luca Boccassi
4a3fc628a2 test: CET/EET are deprecated, use Europe/Berlin and Kyiv
The links moved to the legacy dataset so they won't be available by
default, so stop using them and just use the city ones instead

(cherry picked from commit aa077884c1)
2024-11-13 19:48:10 +00:00
Ronan Pigott
76a73088b0 test-dhcp6: terminate fqdn option
The encoded fqdn in this option must be properly terminated. We will
soon validate that this field is correctly encoded, so correct it in the
test.

(cherry picked from commit 2d9822b634)
2024-11-13 19:48:10 +00:00
Daan De Meyer
206c1a0d5a pcrlock: Take VirtualSize > SizeOfRawData into account
If VirtualSize > SizeOfRawData, measure extra zeros to take into
account the extra zeros also measured by the stub.

(cherry picked from commit b53f2d5ed8)
2024-11-13 19:48:10 +00:00
Ronan Pigott
92eca86c15 test: exercise bypass mode on the sd-resolved stub
A basic test will verify that we provide the right flags.

(cherry picked from commit b7b1c50c6a)
2024-11-13 19:48:10 +00:00
Lennart Poettering
cd4e8dd7d3 resolved: when adding names to packet fails, remove them from label compression hash table again
let's make sure we undo any pollution of the label compression hash
table.

Fixes: #33671
(cherry picked from commit 360105f1e7)
2024-11-13 19:48:10 +00:00
Lennart Poettering
edaab82ccd dns-domain: tweak hash table comparison function for DNS names
Currently, when comparing two DNS names when storing them in a
hashtable, and the DNS names are not actually valid we'll compare the
error codes.

This is not very smart however, since this means two invalid DNS names
that happen to be equally "invalid" will be considered identical, even
if their strings are entirely different.

Let's find a better solution for this niche case: let's simple compare
the domains as strings.

This matters in case of DNS label compression: if we already added added
an invalid DNS name into the label compression hash table, and lookup
any other invalid DNS name, this lookup will likely return what the
earlier one already returned, and that's confusing.

(cherry picked from commit 8ed2c62d46)
2024-11-13 19:48:10 +00:00
Ronan Pigott
2a7dbbbfa2 resolved: update condition for caching full packets
Previously a full packet was cached only if the CD bit was set, but this
no longer corresponds to the cases where bypass is enabled.

Update the cache to retain a full packet in the cases where it might
actually be useful.

(cherry picked from commit fa02d04ee9)
2024-11-13 19:48:10 +00:00
Ronan Pigott
be6c7b7914 resolved: enable CD bit without DO set
This is useful for a validating resolver to indicate to a non-validating
resolver when checking was disabled for the query. This matches the
behavior of the major public resovlers in response to queries with CD bu
tnot DO set.

(cherry picked from commit 36074e0149)
2024-11-13 19:48:10 +00:00
Ronan Pigott
8e78fd0f7d resolved: authenticate bypass queries
Following 13e15dae9f, resolved does not forward the AD bit for bypass
queries, but resolved also didn't do it's own validation, making these
replies appear to never be authentic. We should enable validation for
bypass queries.

Let's disable our own validation when processing a +cd query, and also
ensure that it skips the cache so that we don't accidentally fail to
return inauthentic replies from upstream.

Previously, when we had a bypass transaction without cd, a cached,
authenticated, reply with cd could be served, leaving the cd bit
erroneously set in the reply. Only reply with a CD bit if the client
requested it.

Fixes: 13e15dae9f (resolved: clear the AD bit for bypass packets)
(cherry picked from commit 008f23b7c5)
2024-11-13 19:48:10 +00:00
Zbigniew Jędrzejewski-Szmek
a816075978 man/systemd-nspawn: emphasise that user namespaces are strongly recommended
(cherry picked from commit 9b1a5bc365)
2024-11-13 19:48:10 +00:00
Luca Boccassi
602e12f340 test: customize /etc/os-release instead of /usr/lib/os-release
As per spec image builders can create a local /etc/os-release
with per-image IDs, so modify that one instead of the original
one in /usr/lib. For example we do this when we build debian
unstable images in mkosi.

(cherry picked from commit 2f6fe4e113)
2024-11-13 19:48:10 +00:00
Lennart Poettering
452cfd91fe dissect-image: generate better log message for EUCLEAN dissect error
Fixes: #31799
(cherry picked from commit 2186334e00)
2024-11-13 19:48:10 +00:00
Lennart Poettering
f2833a50bd dissect-image: uppercase first char of dissect error message systematically
Some of the log message stricts used proper uppercasing, others didn't.
Fix that to make it uniform.

(cherry picked from commit 620a03f669)
2024-11-13 19:48:10 +00:00
Lennart Poettering
7280607377 resolved: refresh resolv.conf files when link goes away
This might have the effect that some DNS server or search domain
disappears, hence rewrite the relevant files.

See: #27543
(cherry picked from commit 562f7bde88)
2024-11-13 19:48:10 +00:00
Lennart Poettering
dc47ba69fc networkd: raise limits on number of address 8x
Limits should be enforced, but not in a way real setups collide with
them.

There have been multiple reports that current limits are too low, hence
raise them 8x.

Fixes: #24852
(cherry picked from commit af7674f4ad)
2024-11-13 19:48:10 +00:00
Adrian Vovk
b3fc902116 GREEDY_REALLOC_APPEND: Make more type safe
Previously, GREEDY_REALLOC_APPEND would compile perfectly fine and cause
subtle memory corruption if the caller messes up the type they're passing
in (i.e. by forgetting to pass-by-reference when appending a Type* to an
array of Type*). Now this will lead to compilation failure

(cherry picked from commit fafc3c2d5c)
2024-11-13 19:48:10 +00:00
Lennart Poettering
7803507b6e udev: consider serial ports as unconfigured only if both port and iomem_base sysattr is zero
Various archs do not know the "io port" concept, hence check for the
"iomem" configuration, too.

Fixes: #34800
(cherry picked from commit 9da582984b)
2024-11-13 19:48:10 +00:00
Yu Watanabe
b0a0156bc9 TEST-60-MOUNT-RATELIMIT: disable journal ratelimiting
Otherwise, journal check in testcase_mount_ratelimit() may fail and we
need to wait 2 minutes.

(cherry picked from commit 73970cdcd1)
2024-11-13 19:48:10 +00:00
Yu Watanabe
dcae004218 TEST-60-MOUNT-RATEMINIT: split into small test cases
Then, use run_testcases().

(cherry picked from commit 805d0eed0b)
2024-11-13 19:48:10 +00:00
Yu Watanabe
3b171cb7bc TEST-60-MOUNT-RATELIMIT: wait for mount unit being started or stopped
(cherry picked from commit c5928a7684)
2024-11-13 19:48:10 +00:00
Luca Boccassi
2590b77f39 Fix maybe-uninitialized warnings with gcc 14.2
../src/resolve/resolved-bus.c: In function ‘call_link_method’:
../src/resolve/resolved-bus.c:1769:16: warning: ‘l’ may be used uninitialized [-Wmaybe-uninitialized]
 1769 |         return handler(message, l, error);
      |                ^~~~~~~~~~~~~~~~~~~~~~~~~~
../src/resolve/resolved-bus.c:1755:15: note: ‘l’ was declared here
 1755 |         Link *l;
      |               ^
../src/resolve/resolved-bus.c: In function ‘bus_method_get_link’:
../src/resolve/resolved-bus.c:1828:13: warning: ‘l’ may be used uninitialized [-Wmaybe-uninitialized]
 1828 |         p = link_bus_path(l);
      |             ^~~~~~~~~~~~~~~~
../src/resolve/resolved-bus.c:1816:15: note: ‘l’ was declared here
 1816 |         Link *l;
      |               ^

(cherry picked from commit 5f911aca84)
2024-11-13 19:48:10 +00:00
Yu Watanabe
28f7c958fb journalctl: erase verify key before free
Even optarg is erased, copied string was not erased.
Let's erase the copied key for safety.

(cherry picked from commit d0ad4e88d4)
2024-11-13 19:48:10 +00:00
Yu Watanabe
4042a6a8f6 TEST-55-OOMD: check slice property before stressing slice
(cherry picked from commit a6092b532e)
2024-11-13 19:48:10 +00:00
Yu Watanabe
0dfd4d6996 TEST-55-OOMD: stop test units when unnecessary
Then, sleep becomes not necessary anymore. This greatly improve performance.

(cherry picked from commit 98a0bb8a64)
2024-11-13 19:48:10 +00:00
Yu Watanabe
0932445e1e TEST-55-OOMD: split into small testcases
Then, we can run each small test cases separately.

(cherry picked from commit 6bba058076)
2024-11-13 19:48:10 +00:00
Yu Watanabe
fe5e2af10e TEST-55-OOMD: check global config earlier
'Default Memory Pressure Duration' field in oomctl, which can be configured
with DefaultMemoryPressureDurationSec= in oomd.conf, is a global config.
Let's check it earlier.

This also drops unnecessary cleanup at the beginning.

(cherry picked from commit 23fb9b63cd)
2024-11-13 19:48:10 +00:00
Yu Watanabe
4c9e59ec9a TEST-55-OOMD: set ManagedOOMMemoryPressure= and friends in a drop-in config
Fedora and friends has a drop-in config for the settings in
/usr/lib/systemd/user/slice.d/ . Hence, settings in the main .slice may be
overridden. Let's set below in a drop-in with higher decimal prefix.

Also, rename override.conf -> 99-managed-oom-preference.conf for the same reason.

(cherry picked from commit 1473836a1e)
2024-11-13 19:48:10 +00:00