Cole Robinson
23bf115024
uiutil: Rename select_list_row* to match getter functions
2015-05-19 18:29:46 -04:00
Cole Robinson
490aee74de
uiutil: select_list_row_by_value: Handle value=None
...
Which is a legit value we use as a key in several places. Fix up
a potentially problematic caller
2015-05-19 18:29:46 -04:00
Cole Robinson
08116d2869
uiutil: Group similar functions with comment blocks
2015-05-19 18:29:45 -04:00
Cole Robinson
5219e49eec
uiutil: Merge get_combo_entry into get_list_selection
...
There's no reason we can't handle it together
2015-05-19 18:29:45 -04:00
Cole Robinson
fdad3efe24
uiutil: streamline column vs rowidx parameter name
2015-05-19 18:29:45 -04:00
Cole Robinson
e8e2c831bf
addhardware: Don't list device 'default' options
...
This is really only useful for building default XML internally, and
for virt-install stuff like --watchdog default. Instead just select
the 'default' value in the wizard
2015-05-19 18:29:45 -04:00
Cole Robinson
f33b6d2750
addhardware: Modernize the code
...
- Privatize the actually private functions
- Drop the largely redundant get_config helpers
2015-05-19 18:29:45 -04:00
Cole Robinson
b17c00ecca
details: Clean up media eject/insert code
2015-05-19 18:29:45 -04:00
Cole Robinson
776c1d97c6
domain: Fix changing USB device model
...
Broken before v1.2.0
2015-05-19 18:29:45 -04:00
Cole Robinson
2168f33799
details: Unify controller model handling with addhardware
2015-05-19 18:29:45 -04:00
Giuseppe Scrivano
4b5c836a16
interface: read the start mode from the inactive conf XML
...
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1154480
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2015-05-15 09:14:09 +02:00
Giuseppe Scrivano
2c1e482b2d
virt-manager: fix --show-host-summary error windows flooding
...
Break an endless loop vmmHost.overview_name_changed ->
vmmHost.conn_state_changed -> vmmHost._overview_name_changed.
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1220322
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2015-05-11 20:20:10 +02:00
Chen Hanxiao
24302dfdfd
tests: fix test cases failed by 'vmport'
...
Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2015-05-11 04:55:14 -04:00
Giuseppe Scrivano
fbdf574c53
add-hardware: fix shortcut key for USB redir dev type
...
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1172108
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2015-05-11 10:17:11 +02:00
Cole Robinson
34a19e497e
man: virt-xml: Fix example
2015-05-10 18:10:21 -04:00
Cole Robinson
88e18c86d3
connection: Fix sending net-removed signal
2015-05-07 12:30:28 -04:00
Cole Robinson
a65c1f62ec
conn: Audit get_$obj callers, drop KeyError handling
...
These functions don't throw KeyErrors anymore, so adjust callers that
were handling it
2015-05-07 12:26:10 -04:00
Giuseppe Scrivano
ac2be79658
storage: do not throw exception if the volume or the pool don't exist
...
commit 5357b91402
changed the semantic of
conn.get_(vm|pool|interface|nodedev|net), to return None instead of
raising KeyError. Leave the exception handling code in case the
semantic is going to be reverted.
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1219427
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2015-05-07 17:42:58 +02:00
Michał Kępień
c4d26d16a6
pollhelpers: Fix VM polling on old libvirt
...
https://bugzilla.redhat.com/show_bug.cgi?id=1219443
2015-05-07 11:10:20 -04:00
Cole Robinson
2d54949719
virtinst: Drop a bunch of uses of xmlbuilder make_xpath_cb
...
I'd like to drop that functionality from xmlbuilder, and just open
code it at the callers... this is most of the way there
2015-05-06 16:26:51 -04:00
Giuseppe Scrivano
ebcb7c064c
sshtunnels: fix exception when the address is not an IP
...
bug introduced with commit a2d453f3e2
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1218958
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2015-05-06 21:27:50 +02:00
Cole Robinson
32d998b216
domain: Properly prime stat lists at object creation
...
Fixes graph spikes when initially connecting to a running VM
2015-05-04 18:42:26 -04:00
Cole Robinson
cb0eaf23d8
conn/domain: Privatize stats list
2015-05-04 18:42:17 -04:00
Cole Robinson
fbf841151d
conn/domain: Condense the internal stats APIs
2015-05-04 18:05:54 -04:00
Cole Robinson
848123e6c8
domain: Fix memory stats for shutoff VM (bz 1215453)
...
memory doesn't have a separate input/output stats, so we shouldn't use
the in_out_vector_helper. This resulted in shutoff VMs appearing to still
use memory in the manager window.
2015-05-04 15:50:01 -04:00
Cole Robinson
feb9c7e9b2
Prep for release 1.2.0
2015-05-04 15:10:48 -04:00
Cole Robinson
1a5b87b066
details: Remove unused function
2015-05-04 14:18:03 -04:00
Marc-André Lureau
e2184ea2cf
tests: add some vmport tests
...
Message-Id: <1428012248-5767-6-git-send-email-marcandre.lureau@gmail.com>
2015-05-04 12:40:14 -04:00
Marc-André Lureau
ddfca74e54
virtinst: set vmport off by default when has_spice()
...
Spice is better off without vmport enabled, to be able to switch between
absolute and relative mouse mode easily.
Message-Id: <1428012248-5767-5-git-send-email-marcandre.lureau@gmail.com>
2015-05-04 12:40:13 -04:00
Marc-André Lureau
ede876e792
virtinst: set_graphics_defaults() first
...
Some later options may require Spice (or other) to be enabled,
so call set_graphics_defaults() earlier.
Message-Id: <1428012248-5767-4-git-send-email-marcandre.lureau@gmail.com>
2015-05-04 12:40:13 -04:00
Marc-André Lureau
b44cfde6ac
virtinst: add features.vmport option
...
Message-Id: <1428012248-5767-3-git-send-email-marcandre.lureau@gmail.com>
2015-05-04 12:40:13 -04:00
Marc-André Lureau
ea4aa9ffc4
virtinst: add new vmport domain feature
...
This should be available with libvirt 1.2.16
Message-Id: <1428012248-5767-2-git-send-email-marcandre.lureau@gmail.com>
2015-05-04 12:40:13 -04:00
Cole Robinson
cc67f8f194
addstorage: Clarify that VM will fail if cant set path search perms
...
https://bugzilla.redhat.com/show_bug.cgi?id=1181025
2015-05-03 17:33:26 -04:00
Cole Robinson
cca34185c0
create: customize: Hide bus=virtio-scsi
...
We don't handle it correctly, need to duplicate the addhw logic
2015-05-03 17:24:02 -04:00
Cole Robinson
4547031152
addhardware: Generate disk targets for disks via customize dialog
...
Since the XML we use now is with the defaults filled in. Fixes some
issues in the log here:
https://bugzilla.redhat.com/show_bug.cgi?id=1213475
2015-05-03 17:17:53 -04:00
Cole Robinson
a8d3afbcd9
domain: Log initial XML for virtinst/customize object
2015-05-03 17:01:16 -04:00
Cole Robinson
53703117d9
storagebrowser: Don't log about closing, if already closed.
2015-05-03 16:57:31 -04:00
Cole Robinson
68ce97d533
create: customize: cancel now cancels the entire installation
...
Trying to fall back to the create wizard can give weird results, since
it's really hard to ensure the customized changes are preserved if
the user changes things in the 'new' wizard.
2015-05-03 16:53:43 -04:00
Cole Robinson
c8a0b8310c
create: Fix a logging typo
2015-05-03 16:37:42 -04:00
Cole Robinson
252c216fb9
createpool: Don't unconditionally use /var/lib/libvirt
...
Doesn't make sense for session URIs
2015-05-02 19:54:14 -04:00
Cole Robinson
45e6cd4cac
Remove redundant 'default dir' functions
2015-05-02 19:48:04 -04:00
Cole Robinson
7e7c606ff7
pylint: Disable unidiomatic-typecheck, not really worth fixing
2015-05-02 19:48:04 -04:00
Cole Robinson
892e13d2c0
connection: Tweak pretty names a bit
2015-05-02 19:20:18 -04:00
Cole Robinson
015da05973
storage: Use .local/libvirt/images for session URIs
...
.config isn't really appropriate
2015-05-02 19:09:14 -04:00
Cole Robinson
95cda55376
spec: Don't use hardcode lookup of qemu-system-x86
...
libvirt-daemon-kvm pulls in the correct emulator dep per architecture
2015-05-02 18:25:41 -04:00
Cole Robinson
cc3c6e24a3
packageutils: Add some extra logging
2015-05-02 18:01:52 -04:00
Cole Robinson
fa08d0ada5
clitest: Fix tests on F21
2015-05-02 16:41:21 -04:00
Cole Robinson
46ecafd820
migrate: Fix typos pointed out by translator
2015-05-01 09:38:25 -04:00
Ján Tomko
be7611b645
connection: refresh domain XML on device hotplug
...
Listen to the VIR_DOMAIN_EVENT_ID_DEVICE_ADDED event
too, added by libvirt 1.2.15.
https://bugzilla.redhat.com/show_bug.cgi?id=1179138
Signed-off-by: Ján Tomko <jtomko@redhat.com>
2015-04-29 09:52:10 -04:00
Cole Robinson
0aeee5c449
serialcon: Fix opening with xen (bz 1215357)
...
Apparently xen doesn't set <serial> device alias names, and OpenConsole
just opens the first <console> device unconditionally.
Properly handling that would be to report it in the UI that we can
only open the first console, but for now just drop the alias check.
Apparently SUSE already does this as mentioned in the RH bug
https://bugzilla.redhat.com/show_bug.cgi?id=1215357
2015-04-26 11:54:55 -04:00