shaba/virt-manager
1
0
Fork 0
mirror of https://github.com/virt-manager/virt-manager.git synced 2025-01-07 17:18:00 +03:00
Code Issues Projects Releases Wiki Activity
7,420 Commits 2 Branches 64 Tags 98 MiB
64e3ff1d08
Commit Graph

7420 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Cole Robinson
64e3ff1d08 uitests: console/keyring/viewer coverage work 
Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-29 13:23:34 -04:00
Cole Robinson
2c86eefa5b virt-manager: Drop the DISPLAY error handling 
Gtk nowadays doesn't raise an exception, it just exits directly

Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-29 13:21:43 -04:00
Cole Robinson
c8ed6534e5 connection: Remove some outdated pretty hv labels 
And also the embedded label, our default behavior covers
this well enough for what is likely to be an obscure case

Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-29 13:21:21 -04:00
Cole Robinson
87eb36dda1 uitests: Finish virtmanager.py coverage 
Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-29 12:37:52 -04:00
Cole Robinson
687658832e uitests: details/domain/config coverage additions 
Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-29 12:37:52 -04:00
Cole Robinson
301892f6b9 serialcon: Modernize code style 
* Privatize a bunch of stuff
* Make public API explicit
* Add a few minor public APIs to avoid accessing internal state

Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-29 12:37:12 -04:00
Cole Robinson
e9c937691d uitests: Finish serialcon.py coverage 
Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-29 12:37:12 -04:00
Cole Robinson
fa82508e53 virt-manager: drop libvirt 0.6.0 version check 
This is comically old and completely unrealistic anyone would
attempt to use that nowadays.

Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-29 12:37:12 -04:00
Cole Robinson
6006b7b628 tests: Remove some unused testdriver.xml domains 
Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-28 10:42:29 -04:00
Cole Robinson
a2ad7b4f2f domain: Add test mocking for IP address APIs 
Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-28 08:47:20 -04:00
Cole Robinson
f06cc11546 config: Move more password handling to keyring.py 
Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-28 08:47:20 -04:00
Cole Robinson
ab903ef69b domain: Fix clearing topology when VM has dies= in XML 
We need to use the topology.clear() helper to properly empty
out everything

Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-27 19:41:28 -04:00
Cole Robinson
34c6d1c7ea virtinst: cpu: Move topology elements to their own class 
This is a no-op but will help with a future bug fix

Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-27 19:41:28 -04:00
Cole Robinson
ade6c34a96 domain: Have test driver report fake job_info data 
Helps us test more of the UI

Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-27 19:41:28 -04:00
Cole Robinson
b764773cfe domain: Remove qemu VNC SKIPAUTH bug workaround 
This was added in cb182f7e3 in Mar 2017 to work around a bug in
qemu 2.9. This bug only affects the case of virt-manager running
locally with that version, which after three years should be rare
to non-existent. Remove the workaround

Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-27 19:41:28 -04:00
Cole Robinson
eda08f4c79 details: Big code modernization 
* Privatize a lot of stuff
* Separate out many callbacks as thin wrappers around the real code
* Simplify registering EDIT_ handlers
* Organize things better

Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-27 18:10:11 -04:00
Cole Robinson
a289676574 uitests: More use of safer utility helpers 
Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-27 18:10:11 -04:00
Cole Robinson
eea394b9d3 uitests: Increase details + domain + vmwindow coverage 
Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-27 18:10:11 -04:00
Cole Robinson
701164c664 details: Don't blacklist machine 'none' 
Libvirt has done this for us for a long time

Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-27 18:10:11 -04:00
Cole Robinson
7d22f7b5dc details: Fix handling failed 'unapplied changes' 
The return values from config_apply were not consistent

Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-27 18:10:11 -04:00
Cole Robinson
138856c6df uitests: make manager test less flakey 
Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-27 18:10:11 -04:00
Cole Robinson
4fd9255f9a details: Remove the threads warning for CPUs that don't support it 
This is pretty obscure, and if it's problematic then libvirt
or qemu should be throwing an error or otherwise reporting it

Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-27 18:10:11 -04:00
Cole Robinson
70a5cb7b55 gfxdetails: Improve UI interaction with spice GL + rendernode 
* Unset rendernode when spicegl is de-selected
* Set rendernode by default when spicegl is first selected

Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-27 08:35:52 -04:00
Cole Robinson
632f07b2bb uitests: Give more time for graceful app shutdown 
Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-26 16:24:40 -04:00
Cole Robinson
69ebf852ca uitests: make onscreen property work for menus 
Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-26 16:24:40 -04:00
Cole Robinson
f74c061061 uitests: Finish asyncjob.py coverage 
Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-26 16:24:39 -04:00
Cole Robinson
cfd6d6ead4 uitests: Finish vmmenu.py coverage 
Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-26 16:24:39 -04:00
Cole Robinson
4c1b35f7e7 uitests: Finish migrate.py coverage 
Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-26 16:01:30 -04:00
Cole Robinson
b06d7c47f3 domain: Fake jobinfo support for the test driver 
This let's us test more code, including behavior that's closer to
standard QEMU driver behavior

Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-26 16:01:30 -04:00
Cole Robinson
3425d514be migrate: Remove localhost hostname warning 
Latest libvirt actually checks against UUID so this isn't accurate
anymore

Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-26 16:01:30 -04:00
Cole Robinson
25d23b1d8b uitests: finish manager.py coverage 
Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-26 16:01:30 -04:00
Cole Robinson
e9ee0f6d4b uitests: add some mock inspection.py testing 
Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-26 15:26:12 -04:00
Cole Robinson
0af6bdb56f inspection: Fill in fake data for test:/// URIs 
This helps with testing

Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-26 15:20:06 -04:00
Cole Robinson
48695199c5 inspection: Break out _perform_inspection 
This clearly separates the pieces where we interact with
libguestfs, vs our internal wiring

Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-26 15:20:06 -04:00
Cole Robinson
b59a30ad77 uitests: Finish addhardware.py coverage 
Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-26 15:20:06 -04:00
Cole Robinson
8f76c97705 uitests: Make createpool test less flaky 
Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-26 15:20:06 -04:00
Cole Robinson
d140596ce9 uitests: try to make flakey createvm test more robust 
Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-26 15:20:06 -04:00
Cole Robinson
1684049fa3 virtManager: Misc coverage annotations 
Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-26 15:20:06 -04:00
Cole Robinson
dc41f61e5e uitests: Add combo selection helpers and use them 
Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-26 15:20:06 -04:00
Cole Robinson
c405dd2741 setup: Add --tb=native to pytest options 
I find it much easier to read

Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-26 15:20:06 -04:00
Cole Robinson
3f59d9de84 uitests: More usage of storagebrowser helper 
Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-26 15:20:06 -04:00
Cole Robinson
73b61ffbc9 uitests: Use our loop check() helper for all asserts 
Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-26 15:20:06 -04:00
Cole Robinson
627fa2f611 addhardware: Simplify input_pretty_name 
Drop the 'Generic' prefix for all strings which isn't particularly
meaningful.

Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-26 15:20:05 -04:00
Cole Robinson
147f918ffd addhardware: Use dictionary pattern for pretty labels 
It's shorter and saves us the pain of adding coverage
for every option

Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-26 15:20:05 -04:00
Cole Robinson
ab92693a56 uitests: finish preferences.py coverage 
Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-26 15:20:05 -04:00
Cole Robinson
b1ddc6344a uitests: make test_createvm.py asserts more robust 
Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-26 15:20:05 -04:00
Cole Robinson
fd5216c184 uitests: Finish createconn.py coverage 
Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-26 15:20:05 -04:00
Cole Robinson
35d4687237 uitests: Rename test_newvm.py to test_createvm.py 
To mirror the code name

Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-26 15:20:05 -04:00
Cole Robinson
bb1180fb40 Move virtmanager test cli handling to testmock.py 
We will be adding more stuff here, so let's move it out
of the main virt-manager script

Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-26 15:20:05 -04:00
Cole Robinson
5ccbcb898f uitests: Finish netlist.py coverage 
Signed-off-by: Cole Robinson <crobinso@redhat.com>
 2020-08-26 15:20:05 -04:00