Cole Robinson
65e1187c10
osdict: Add a helpful __repr__
2018-09-30 09:37:14 -04:00
Cole Robinson
31e4b72a8b
osdict: Drop Glib.Date API usage
...
Use python datetime instead, it's more python friendly
2018-09-29 15:22:44 -04:00
Cole Robinson
97ea737386
devices: interface: Have x86 fallback model be e1000
...
libvirt will use rtl8139, but the qemu default changed a while
ago to e1000, and libvirt has diverged. e1000 is more modern and
considered the better default here, so use it
2018-09-29 14:35:28 -04:00
Cole Robinson
627bfabc32
pylint: Silence output on Fedora 29
2018-09-29 14:27:34 -04:00
Cole Robinson
4adb1c8c30
pycodestyle: fix W605 invalid escape sequence
2018-09-29 13:59:19 -04:00
Cole Robinson
2d44912a70
pycodestyle: Disable W504 line break after binary operator
2018-09-29 13:59:15 -04:00
Cole Robinson
7356afcca7
osdict: Use USB tablet if no OS specified
...
Most OS users will be installing benefit from it, so make it the
default
2018-09-29 13:36:42 -04:00
Cole Robinson
184b96a815
virtinst: util: Remove unused validate_uuid
...
We let libvirt error nowadays
2018-09-14 15:19:03 -04:00
Cole Robinson
87d19ebf36
tests: Add rhel5 and win10 kvm XML tests
2018-09-14 14:37:12 -04:00
Cole Robinson
e2c817f06f
ui: details: Get rid of some unused widgets
2018-09-13 16:06:18 -04:00
Cole Robinson
a741f595ea
guest: Drop update_defaults
...
Fold its one purpose into the UEFI setting bits, fix it and test it
2018-09-13 15:59:27 -04:00
Cole Robinson
d7ff46f7f5
guest: Encode the cli --os-variant in the XML
...
And add some testdriver examples of it
2018-09-13 15:11:22 -04:00
Cole Robinson
86ef998023
guest: Lookup osinfo object from libosinfo metadata XML
2018-09-13 15:03:36 -04:00
Cole Robinson
bad5eabd93
domain: Add metadata.libosinfo
...
From the libosinfo discussion here:
https://www.redhat.com/archives/libosinfo/2018-September/msg00003.html
This is a cross-app schema for tracking libosinfo OS ID in the
domain <metadata> XML. Example:
<metadata>
<libosinfo:libosinfo xmlns:libosinfo="http://libosinfo.org/xmlns/libvirt/domain/1.0 ">
<libosinfo:os id="http://fedoraproject.org/fedora/17 "/>
</libosinfo:libosinfo>
</metadata>
2018-09-13 12:39:56 -04:00
Cole Robinson
baaab74b6d
xmlapi: Rework xmlns setting slightly
...
So the xmlns is not always set on the top element. We need this for
custom <metadata> support
2018-09-13 12:39:56 -04:00
Cole Robinson
841d5126d2
xmlapi: Move namespace mappings to the relevant classes
...
So we don't need to update xmlapi.py to account for additions
2018-09-13 09:34:04 -04:00
Cole Robinson
6063538750
guest: Replace os_variant with set_os_name
...
And have callers directly access osinfo.name if they need it
2018-09-12 17:24:28 -04:00
Cole Robinson
2549e60698
guest: Add an entry point for setting machine=q35 default
...
We will want this at some point, but it's dependent on libosinfo
work
2018-09-12 15:35:49 -04:00
Cole Robinson
d60229825f
create: update caps state when machine type changes
...
And drop old dtb virtio stuff which we don't care about anymore
2018-09-12 15:35:49 -04:00
Cole Robinson
bc248b3eb5
create: Drop arm kernel warning
...
This case should be uncommon, and is wrong with UEFI, so drop it
and let qemu error
2018-09-12 14:06:13 -04:00
Cole Robinson
4e30161f44
guest: Absorb UEFI default setup
...
Rather than force callers to deal with it
2018-09-12 14:02:23 -04:00
Cole Robinson
d669ce8417
tests: Add a set_defaults idempotent test
2018-09-12 12:36:58 -04:00
Cole Robinson
2d53f7223d
clitest: Test comparison against --os-variant fedora-unknown
...
Which always maps to the latest Fedora. May help catch accidental
changes
2018-09-12 12:33:16 -04:00
Cole Robinson
e903d374c2
guest: Always encode machine= in XML
...
Don't rely on libvirt's default. This makes any XML changes more
explicit, and can help other parts of the code that may depend on
a machine type being encoded
2018-09-12 12:16:47 -04:00
Cole Robinson
ec69ae44b6
capabilities: Drop build_virtinst_guest
...
Same as lookup_virtinst_guest
2018-09-06 20:54:59 -04:00
Cole Robinson
1c05db691d
guest: Cache capsinfo
...
Don't repeatedly look it up, was slowing down the test suite by about 5%
2018-09-06 20:38:59 -04:00
Cole Robinson
a2fa799478
capabilities: Drop lookup_virtinst_guest
...
Users should just init Guest() directly, and call
set_capabilities_defaults if they need default arch data
2018-09-06 20:28:05 -04:00
Cole Robinson
e61f2b991b
guest: Re-organize function locations
2018-09-06 20:12:49 -04:00
Cole Robinson
5f22f41da4
guest: Absorb capabilities defaults setup
...
Rather than forcing API users to go through the capabilities APIs.
This lets us simplify things in virt-install quite a bit, and is
needed for smarter machine type defaults
2018-09-06 20:12:49 -04:00
Cole Robinson
12a7a18be0
cli: Fix traceback detection
2018-09-06 18:39:14 -04:00
Cole Robinson
a754718889
devices: disk: Use uppercase naming for mode lists
2018-09-06 16:51:14 -04:00
Cole Robinson
63287c83fb
addhardware: Move disk bus listing to virtinst
...
Drop the stable_default stuff as domcaps usage should make
it obsolete for any cases we care about
2018-09-06 16:40:49 -04:00
Cole Robinson
a09a46289a
addhardware: Move controller list logic to virtinst
...
And tweak the UI defaults a bit, preferring virtio-scsi and
usb3
2018-09-06 16:05:12 -04:00
Cole Robinson
7994dc90c8
addhardware: Move video model list to virtinst
...
And make it smart about the hypervisor
2018-09-06 14:45:05 -04:00
Cole Robinson
7baa296aed
details: Update IP addr UI after refresh_ip call
2018-09-06 14:04:00 -04:00
Lin Ma
838822b242
Fix error while refreshing ip if the virtual nic only has ipv6
...
Signed-off-by: Lin Ma <lma@suse.com>
2018-09-06 13:49:12 -04:00
Lin Ma
be8dfc25f7
Fix error while refreshing ip if the virtual nic doesn't have any ip
...
Signed-off-by: Lin Ma <lma@suse.com>
2018-09-06 13:48:58 -04:00
Lin Ma
b99731397b
addhardware: Add support for disk io mode option
...
Signed-off-by: Lin Ma <lma@suse.com>
2018-09-06 13:28:21 -04:00
Lin Ma
f2679df719
addhardware: Use consistent combo init for disk io mode option
...
Signed-off-by: Lin Ma <lma@suse.com>
2018-09-06 13:28:21 -04:00
Cole Robinson
b3865d7b0d
addhardware: Drop tcp/udp/dev char support
...
I know openstack uses tcp consoles but for end users I've never
really heard about it. RHEL compiles out udp as well. I'm fine telling
users to go to the cli and use virt-xml for this use case.
Use this opportunity to drop a lot of code that only simplified the
case when there are tons of char options we need to consider
2018-09-06 13:28:21 -04:00
Cole Robinson
954d2687d0
domain: Drop stable_defaults wrapper
...
Have callers invoke it directly on Guest
2018-09-06 13:28:21 -04:00
Cole Robinson
cd07d6af34
sound: Track recommended models in virtinst
...
Change addhardware to show an editable model entry, like the
details wizard
2018-09-06 13:28:21 -04:00
Cole Robinson
be1f5a6e25
devices: Remove a bunch of unused static lists
2018-09-06 13:28:21 -04:00
Cole Robinson
84a68d56de
addhardware: Don't disable filesystem on rhel
...
It might be compiled out, but just let qemu reporting fail. The
proper way to fix this expose it in domain capabilities or similar
2018-09-06 13:28:21 -04:00
Cole Robinson
da00a52159
storagebrowser: Remove stable_defaults handling
...
It simply makes vmdk disk images not selectable. I don't even know
if that's relevant for RHEL7+ anymore, but if it is, maintaining
code for disabling this in the UI doesn't make the situation any
better IMO
2018-09-06 13:28:21 -04:00
Cole Robinson
2b7043cd85
createpool: Fix showing formats
...
But shrink the format list to 'auto' only, but also add a text entry
so users can type their own
2018-09-06 13:28:21 -04:00
Cole Robinson
c5033c02d5
fsdetails: Use combo entry for format list
...
And stop listing all the crazy qemu formats
2018-09-06 13:28:21 -04:00
Cole Robinson
f13d10590d
createvol: Only show raw+qcow2 as file formats
...
And turn the combo into a text entry, so users can enter their
own if they want. raw and qcow2 covers the vast majority of usecases
2018-09-06 13:28:21 -04:00
Cole Robinson
68907f1e6e
addhardware: Use browse mode for hw-list
2018-09-05 19:42:52 -04:00
Cole Robinson
f499bc9638
details: Use browse mode for hw-list
...
Meaning a row can never be unselected. Drop some redundant code
afterwards
2018-09-05 19:37:55 -04:00