7831 Commits

Author SHA1 Message Date
WGH
d9b5090e06 Fix forgetting password from keyring
First, Item.Delete never accepted any arguments, so this code likely
never worked.

Second, Item.Delete might return a Prompt object, which client
is supposed to call if keyring wants to confirm deletion.
2021-04-06 18:30:08 -04:00
Cole Robinson
5b93a43622 pylint: Make sure we lint against Gtk3
We need to pass virtmanager.py to pylint first, so it detects
the require_version() call

Signed-off-by: Cole Robinson <crobinso@redhat.com>
2021-04-06 18:28:48 -04:00
Cole Robinson
511857b288 pylint: Exclude use-a-generator
Signed-off-by: Cole Robinson <crobinso@redhat.com>
2021-04-06 18:11:19 -04:00
Cole Robinson
12517e0a28 tests: Fix --sound audio.id test
libvirt validates this, but we don't support <audio> devices yet,
so find another way

Signed-off-by: Cole Robinson <crobinso@redhat.com>
2021-04-06 17:06:41 -04:00
Cole Robinson
87ce425197 tests: storage: Fix with latest libvirt XML output
Signed-off-by: Cole Robinson <crobinso@redhat.com>
2021-04-06 15:21:00 -04:00
Cole Robinson
fe8722e763 createnet: Remove some unnecessary max_length annotations
Fixes: #238

Signed-off-by: Cole Robinson <crobinso@redhat.com>
2021-04-06 13:35:15 -04:00
Cole Robinson
f4eed36863 DESIGN: Hiding viewer menu bar has been rejected
Signed-off-by: Cole Robinson <crobinso@redhat.com>
2021-03-10 16:55:19 -05:00
Jonathan Schwender
f9a0c3ccb2 cli: --cputune: add vcpusched[0-9]* config
This adds the following suboptions to configure <cputune>:

- vcpusched.vcpus
- vcpusched.scheduler
- vcpusched.priority

Reviewed-by: Cole Robinson <crobinso@redhat.com>
Signed-off-by: Jonathan Schwender <schwenderjonathan@gmail.com>
2021-02-16 16:37:15 -05:00
Cole Robinson
d304a9b205 tests: More bhyve UEFI testing
Signed-off-by: Cole Robinson <crobinso@redhat.com>
2021-02-15 13:39:16 -05:00
Roman Bogorodskiy
1bcd442bfd virtinst: bhyve: configure nmdm console
Bhyve only supports nmdm console type, so use it instead of TYPE_PTY.

Reviewed-by: Cole Robinson <crobinso@redhat.com>
Signed-off-by: Roman Bogorodskiy <bogorodskiy@gmail.com>
2021-02-15 13:27:48 -05:00
Roman Bogorodskiy
6c7080a39b virtinst: bhyve: properly configure loader
Bhyve requires explicit loader configuration. So query
domain capabilities, try to find the "official"
firmware and configure all the necessary loader options.

Reviewed-by: Cole Robinson <crobinso@redhat.com>
Signed-off-by: Roman Bogorodskiy <bogorodskiy@gmail.com>
2021-02-15 13:27:48 -05:00
Roman Bogorodskiy
dab099d413 virtinst: prefer SATA bus for bhyve
Choose SATA as a default bus for bhyve as it doesn't support IDE.

Reviewed-by: Cole Robinson <crobinso@redhat.com>
Signed-off-by: Roman Bogorodskiy <bogorodskiy@gmail.com>
2021-02-15 13:27:48 -05:00
Roman Bogorodskiy
2d254f2815 tests: cli: start testing bhyve
Reviewed-by: Cole Robinson <crobinso@redhat.com>
Signed-off-by: Roman Bogorodskiy <bogorodskiy@gmail.com>
2021-02-15 13:27:48 -05:00
Cole Robinson
404507b3ad virt-manager: Require pygobject >= 3.31.3
This is the first version that universally treats a None value as
bool False. Most recent code changes have been developed against this
version of pygobject, and several backwards incompatible None usages
have slipped in, and I suspect there's more lurking.

Signed-off-by: Cole Robinson <crobinso@redhat.com>
2021-02-10 12:43:53 -05:00
Cole Robinson
8bf03dad2c spec: gtk3 >= 3.22.0 is required
This is already forced in the code

Signed-off-by: Cole Robinson <crobinso@redhat.com>
2021-02-10 12:43:53 -05:00
Cole Robinson
db44332791 tests: Fix virt-xml test case
This would have caught the bug Roman just fixed

Signed-off-by: Cole Robinson <crobinso@redhat.com>
2021-02-10 10:27:35 -05:00
Roman Bogorodskiy
143c6befc3 virtinst: fix error message format string
Fix a regression introduced by commit 71f034d6b where
format string expects kwarg "domain", but "vm" is passed instead.

Reviewed-by: Cole Robinson <crobinso@redhat.com>
Signed-off-by: Roman Bogorodskiy <bogorodskiy@gmail.com>
2021-02-10 10:26:23 -05:00
Pavel Hrdina
cf93e2dbff console: fix error with old pygobject
The code doesn't work as expected. From python documentation:

    x and y

is the same as

    x if not x or y

so in the code if for some reasone `dev` is None the value stored in
`sensitive` will be None as well.

No the code itself works with pygobject >= 3.31.3 where they allowed
None as a valid boolean value, but with older versions it will fail
with this error message:

    TypeError: Argument 1 does not allow None as a value

Resolves: https://github.com/virt-manager/virt-manager/issues/226

Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
2021-02-05 12:15:46 +01:00
Cole Robinson
d3c627f189 volumeupload: Use 1MiB read size
Rather than 1K. This drastically speeds up the volumeupload case
for a local URI for the cost of some higher runtime memory but
I think that's worth it

Fixes: #221

Signed-off-by: Cole Robinson <crobinso@redhat.com>
2021-02-03 14:15:57 -05:00
freddii
1c98328e82 fixed typos 2021-02-02 17:02:24 -05:00
Cole Robinson
56cb813d42 cli: Add --tpm persistent_state=
Signed-off-by: Cole Robinson <crobinso@redhat.com>
2021-01-24 18:54:54 -05:00
Cole Robinson
2862f1be98 cli: Add --memballoon freePageReporting=
Signed-off-by: Cole Robinson <crobinso@redhat.com>
2021-01-24 18:49:55 -05:00
Cole Robinson
5c1ace02c9 cli: Add --sound audio.id=
Signed-off-by: Cole Robinson <crobinso@redhat.com>
2021-01-24 18:48:09 -05:00
Cole Robinson
d3517ded62 cli: Add --filesystem fmode, dmode
Signed-off-by: Cole Robinson <crobinso@redhat.com>
2021-01-24 18:46:47 -05:00
Cole Robinson
5a152712d9 details: Log the active_edits list when warning about unapplied changes
This pops up randomly sometimes for reasons I can't determine yet.
logging this will help narrow it down when it does crop up

Signed-off-by: Cole Robinson <crobinso@redhat.com>
2021-01-19 12:22:31 -05:00
Cole Robinson
60ecc1c223 uitests: createvm: Fix with latest osinfo
Signed-off-by: Cole Robinson <crobinso@redhat.com>
2020-12-07 14:54:13 -05:00
Cole Robinson
41eda8a431 tests: Remove now redundant LANG overrides
We added a central one in the previous commit

Signed-off-by: Cole Robinson <crobinso@redhat.com>
2020-12-07 14:32:27 -05:00
Pino Toscano
fdc621e05f tests: force an English UTF-8 locale
Various checks in the test suite try to match for error/status messages,
so using a localized libvirt (or even using translations of an installed
version of virt-manager in the system) makes those check fail.
Hence, force (using $LANG, and unsetting $LANGUAGE) an English UTF-8
locale.

Thanks Cole Robinson for spotting the right place where to inject the
locale settings.

Fixes: #199

Signed-off-by: Pino Toscano <ptoscano@redhat.com>
2020-12-07 13:50:00 -05:00
Martin Pitt
4d0e323227 virtinst: Fix TOCTOU in domain enumeration
Similar to commit 49a01b5482, _fetch_all_domains_raw() has a race
condition where a domain may disappear (from parallel libvirt
operations) in between enumerating and inspecting the objects.

Ignore these missing domains instead of crashing.

https://bugzilla.redhat.com/show_bug.cgi?id=1901081
2020-12-01 13:56:30 -05:00
Igor Ryzhov
19fc6c1708 spec: fix python macro
It looks like there is no %{python3} macro in CentOS 8.
Using %{__python3} should be always safe.

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
2020-12-01 10:26:43 -05:00
Cole Robinson
e7222b5058 addstorage: Don't pass None to widget.set_active()
Older pygobject can't handle it. Mentioned here:
https://github.com/virt-manager/virt-manager/issues/188

Signed-off-by: Cole Robinson <crobinso@redhat.com>
2020-11-21 17:17:33 -05:00
Igor Ryzhov
ac9316cce1 virtinst: add support for controller target subelement
Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
2020-11-21 14:47:22 -05:00
Cole Robinson
7541065d09 systray: Appindicator tweaks
- Prefer ayatana if it's available, since that's the modern library
- Fix some pylint and code coverage issues

Signed-off-by: Cole Robinson <crobinso@redhat.com>
2020-11-16 11:11:19 -05:00
Laurent Bigonville
ac7e6a0966 Try to load AyatanaAppIndicator3 in addition of AppIndicator3
AyatanaAppIndicator3 is the successor or AppIndicator3 it uses the same API for the time being

Just try to load AyatanaAppIndicator3 in addition of AppIndicator3

Fixes: #181
2020-11-16 10:09:19 -05:00
Cole Robinson
ddc55c8ba5 hostdev: Log XML of the source nodedev device
Signed-off-by: Cole Robinson <crobinso@redhat.com>
2020-11-14 18:17:32 -05:00
Cole Robinson
cd788e9303 Prep for release 3.2.0
Signed-off-by: Cole Robinson <crobinso@redhat.com>
v3.2.0
2020-11-14 16:15:22 -05:00
Weblate
88ec96a932 Update translation files
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: virt-manager/virt-manager
Translate-URL: https://translate.fedoraproject.org/projects/virt-manager/virt-manager/
2020-11-14 16:13:46 -05:00
Jan Nerad
d380ed2e8e Translated using Weblate (German)
Currently translated at 71.6% (1012 of 1413 strings)

Translation: virt-manager/virt-manager
Translate-URL: https://translate.fedoraproject.org/projects/virt-manager/virt-manager/de/
2020-11-14 16:13:46 -05:00
Samuel Heinzmann
263cbbe5e1 Translated using Weblate (German)
Currently translated at 71.6% (1012 of 1413 strings)

Translation: virt-manager/virt-manager
Translate-URL: https://translate.fedoraproject.org/projects/virt-manager/virt-manager/de/
2020-11-14 16:13:46 -05:00
Pino Toscano
1af30029b5 Translated using Weblate (Italian)
Currently translated at 98.5% (1392 of 1413 strings)

Translation: virt-manager/virt-manager
Translate-URL: https://translate.fedoraproject.org/projects/virt-manager/virt-manager/it/

Translated using Weblate (Italian)

Currently translated at 98.5% (1392 of 1413 strings)

Translation: virt-manager/virt-manager
Translate-URL: https://translate.fedoraproject.org/projects/virt-manager/virt-manager/it/
2020-11-14 16:13:46 -05:00
scootergrisen
40391c67d2 Translated using Weblate (Danish)
Currently translated at 16.0% (227 of 1413 strings)

Translation: virt-manager/virt-manager
Translate-URL: https://translate.fedoraproject.org/projects/virt-manager/virt-manager/da/

Translated using Weblate (Danish)

Currently translated at 15.9% (226 of 1413 strings)

Translation: virt-manager/virt-manager
Translate-URL: https://translate.fedoraproject.org/projects/virt-manager/virt-manager/da/
2020-11-14 16:13:46 -05:00
Oğuz Ersen
ce3df9727b Translated using Weblate (Turkish)
Currently translated at 100.0% (1413 of 1413 strings)

Translation: virt-manager/virt-manager
Translate-URL: https://translate.fedoraproject.org/projects/virt-manager/virt-manager/tr/

Translated using Weblate (Turkish)

Currently translated at 73.8% (1043 of 1413 strings)

Translation: virt-manager/virt-manager
Translate-URL: https://translate.fedoraproject.org/projects/virt-manager/virt-manager/tr/
2020-11-14 16:13:46 -05:00
Github Actions
6946573d72 Refresh translation .pot template 2020-11-14 16:13:46 -05:00
Github Actions
01930b0d58 Refresh translation .pot template 2020-11-14 16:13:46 -05:00
Github Actions
b7e14eef03 Refresh translation .pot template 2020-11-14 16:13:46 -05:00
Github Actions
9a655bd31a Refresh translation .pot template 2020-11-14 16:13:46 -05:00
Cole Robinson
110959a371 tests: test_urls: Fix dead links
Signed-off-by: Cole Robinson <crobinso@redhat.com>
2020-11-14 16:11:28 -05:00
Cole Robinson
f81c07d2da details: Add simplified wrapper for change_config_helper
Signed-off-by: Cole Robinson <crobinso@redhat.com>
2020-11-14 16:09:21 -05:00
Cole Robinson
488f153655 fsdetails: Rework XML building logic
Make it work more like gfxdetails. The problem with the current
approach is that it requires effectively rebuilding the whole device
to match the original device when we want to edit a single field,
which is error prone.

Signed-off-by: Cole Robinson <crobinso@redhat.com>
2020-11-14 16:09:21 -05:00
Cole Robinson
fca338d2d1 fsdetails: Remove some dead code
Signed-off-by: Cole Robinson <crobinso@redhat.com>
2020-11-13 17:05:00 -05:00