Commit Graph

4590 Commits

Author SHA1 Message Date
Daniel P. Berrange
df92749286 virt-install: document virtual port profile parameters
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
2015-08-28 12:40:19 +01:00
Daniel P. Berrange
d6ea493d1b virtinst: support virtual port parameters for non-802.1Qbg NICs
Previous commit added support for virtual port profiles
on NICs, but only defined the attributes needed by the
802.1Qbg NIC type.

  commit 34e2ca8389
  Author: Cole Robinson <crobinso@redhat.com>
  Date:   Fri Jan 31 16:51:02 2014 -0500

    cli: --network: Wire up virtualport options

This commit adds the profileid and interfaceid parameters
needed by 801.Qbh, openvswitch and midonet

Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
2015-08-28 12:40:18 +01:00
Cole Robinson
40d4c37868 domain: Use UpdateDevice for CDROM media change (bz 1229819)
This has been supported for a long time now, and is more tested these
days, so let's use it rather than the old style AttachDevice method

It also works around a libvirt issue described in bz 1229819
2015-08-10 18:47:12 -04:00
Cole Robinson
5f2913e5e1 createvol: Log parent pool XML when opening
And chosen volume XML
2015-08-10 16:58:09 -04:00
Lin Ma
7be81e6300 Get framebuffer size from 'vgamem' attribute for qxl device
Libvirt commit#742d49f introduces vgamem attribute to set the VGA
framebuffer size for QXL device of qemu, So we use vgamem instead
of vram here for qxl.

Signed-off-by: Lin Ma <lma@suse.com>
2015-08-10 16:26:06 -04:00
Pavel Hrdina
9f26bbb5e9 addstorage: remove _check_ideal_path
This feature has been added few years ago.  I don't think, that it's a
good feature, as it can ask a user to use different storage than he
actually wants to use.  One thing is automatically create a new storage
for user, if he let as do that, but we shouldn't annoy a user with this
question as he probably don't want to use the proposed storage.  For
example he would like to use different storage pool or while importing
existing storage.

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1232599

Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
2015-08-10 15:07:38 -04:00
Cole Robinson
6279c3a3d8 tests: Add clitest for USB duplicate checking 2015-08-10 15:01:03 -04:00
Cole Robinson
7d08d3d981 addhw: Drop unused columns from host-device list 2015-08-10 14:18:43 -04:00
Cole Robinson
b4a7d89d4b addhardware: Fix USB host device listing 2015-08-10 14:12:27 -04:00
Cole Robinson
531260be36 details: Raise upper limits for lxc ID namespaces (bz 1244490) 2015-08-10 13:14:37 -04:00
Cole Robinson
473eaf4aa5 create: Invalid os lookup should be a validation error dialog 2015-08-10 13:02:27 -04:00
Cole Robinson
55b43dcbb8 osdict: Fix unix alias
Needs to point to proper libosinfo name freebsd9.0
2015-08-10 13:01:04 -04:00
Cole Robinson
cca72a73c4 create: Fix backtrace when reporting OS error (bz 1241902) 2015-08-10 12:56:11 -04:00
Cole Robinson
82ea5bfc62 tests: Add qemu:///session unit tests 2015-08-10 12:46:47 -04:00
Cole Robinson
e22aeac5ae storage: session path should be ~/.local/share/libvirt/images
Not .local/libvirt/images :/ App dirs aren't supposed to be in ~/.local
2015-08-10 12:35:13 -04:00
Cole Robinson
59b30c81a0 spec: Add LXC to default connection list (bz 1235972) 2015-08-09 18:15:37 -04:00
Cole Robinson
f2dac84173 connect: Fix some pylint 2015-08-09 14:01:22 -04:00
Cole Robinson
5f497b4d79 Mark a couple strings as translatable 2015-08-09 14:01:01 -04:00
Cole Robinson
4970615f48 addconnection: Fix qemu:///session vs. lxc:/// detection 2015-08-09 12:27:20 -04:00
Pavel Hrdina
aebebbf879 virt-install: report an error for pxe install without network
Fix a regression where we used to report an error message if user
specified pxe installation without any network (--nonetworks or
--network none).

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1250382

Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
2015-08-06 14:56:30 +02:00
Giuseppe Scrivano
76d6c5b597 virtinst: fix two undefined variable warnings
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2015-08-05 13:53:19 +02:00
Pavel Hrdina
745fa9fa5e scsi-storage: unify SCSI storage code and logic
There is no virtio-scsi or spapr-vscsi bus, but only 'scsi' bus.  There
are several types of SCSI controllers, but the SCSI storage don't care
about the SCSI controller and there is also no difference in address
specification or address type.  Use only 'scsi' bus for all SCSI storages
to correspond the reality and also the libvirt domain XML.  The only
difference is in the type of SCSI controller

Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
2015-08-05 13:41:47 +02:00
Pavel Hrdina
db9d851c96 Revert "create: customize: Hide bus=virtio-scsi"
This reverts commit cca34185c0.

Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
2015-08-05 13:41:45 +02:00
Pavel Hrdina
f81358b02d details: don't display error if machine is missing in XML
Commint 0ddec919 updated the details page.  Now the detail page of
existing domain cannot update the 'machine' value, only prints that
value.  If we cannot get the machine from domain XML, don't pass a None,
but "Unknown" instead.  This can happen if you are connecting with
virt-manager to really old libvirt, the machine value is present in
domain XML since libvirt v0.9.5.

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1238981

Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
2015-08-05 13:32:04 +02:00
Pavel Hrdina
b06c91d2fc hostdev: add an address element for USB host devs if necessary
This issue was fixed for few years but only in virt-manager,
virt-install has the same bug.  If you have two USB devices with same
vendor and product ID, you need to use also address element to create
a valid XML to define that device into a guest.

This patch moves the logic from vmmAddHardware into VirtualHostDevice in
order to not duplicate that code for virt-manager and virt-install.

Also update the tests files to properly check this functionality.  I've
changed the USB device according the 'tests/testdriver.xml' and picked
one of the USB HUBs, because they have the same vendor and product ID.

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1230611

Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
2015-08-05 13:32:04 +02:00
Chen Hanxiao
a51eea16f8 cli: fix a comment typo
s/uncoditionally/unconditionally

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
2015-07-30 11:05:59 +08:00
Pavel Hrdina
466bf929ea osxml: detect all pseries machine types
For example the machine type could be "pseries-<host-os-version>".

Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
2015-07-22 15:20:04 +02:00
Pavel Hrdina
cce1f89a34 virtManager/create: update capsinfo sooner in set_conn_state
We need to update/initialize the capsinfo sooner in that function to be
able to call has_install_options().

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1244566

Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
2015-07-21 11:55:11 -04:00
Pavel Hrdina
2d9587c114 support: enable hv_time since qemu-kvm 1.5.3 from RHEL
This feature is available in upstream Qemu since 2.0.0 but it was also
back-ported to downstream Qemu into qemu-kvm-1.5.3 released in RHEL-7.
Add a new check and enable hv_time also in RHEL systems if qemu new
enough.

Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
2015-07-21 10:51:41 +02:00
Pavel Hrdina
1590490fa3 capabilities: detect ACPI and APIC capabilites properly
Instead of hard-coding that ACPI and APIC are enabled by default, detect
their presence from libvirt capabilities and use it.

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1215692

(crobinso: Adjust for recently added test case)

Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
2015-07-14 13:26:42 -04:00
Pavel Hrdina
3ff35898a4 refactor detection of guest type capabilities
Each guest type can have its own capabilities and we should always ask
only for those capabilities.

The old approach was to get capabilities from libvirt and then for
example cycle trough all guests and return True, if any guest type
supports kvm or pae, etc.

Now we check those capabilities only for the correct guest type
according to defaults and input from user.

Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
2015-07-14 13:11:40 -04:00
Pavel Hrdina
a2505def2c pep8 E731: do not assign a lambda expression, use a def
Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
2015-07-14 13:01:20 -04:00
Pavel Hrdina
c7049eb120 pep8 W503: line break before binary operator
Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
2015-07-14 13:01:20 -04:00
Pavel Hrdina
349220d188 tests/virtconvtest: skip test if unar is missing
If you are running all tests, we should properly skip the test, if something
is missing instead of silently ignore that tests.

Signed-off-by: Pavel Hrdina <phrdina@redhat.com>

(crobinso: make it skip the test, rather than raise an exception)
2015-07-14 13:00:04 -04:00
Kevin Zhao
8dbe96fc01 virt-manager : add support for architecture type "s390x".
For architecture "s390x",the disk and the network device are base
on "virtio" bus.The cdrom is based on "scsi".So set the default
cdrom bus as "scsi",the default bus as "virtio".Also the default
machine type is set to "s390-ccw-virtio" as it is the only supported
in "s390x".Also add a test cast of virt-install by cdrom in s390x.

(crobinso: Tweak test suite and minor formatting stuff)
2015-07-14 12:45:32 -04:00
Cole Robinson
612123563e tests: Add test for CPU clearing
Currently broken, fixed by the next patch
2015-07-14 11:53:02 -04:00
Pavel Hrdina
a9b303fb14 virtinst.cpu: fix copy host cpu definition
Commit cac4ac14 updated cpu features to use XMLBuilder and this change
removes the 'Features' class.  There is no longer any '.names()'
method to return names, so just cycle through all features and use a
name attribute instead.

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1240938

Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
2015-07-14 11:53:02 -04:00
Pavel Hrdina
76bad650de virt-xml: refactor the handling of --define and --update options
The code was wrong in many ways.  The main issue was, that for live
updates we were using config XML instead of live XML.

This patch fixes the --update and --define options to work properly as
described in man page.

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1192875

Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
2015-07-07 10:42:32 -04:00
Cole Robinson
34db1af7b6 createpool: Fix adding iscsi pools (bz 1231558) 2015-06-21 15:47:31 -04:00
Cole Robinson
fc93e154dc addhardware: Fix udp/tcp host vs mode UI
We had the UI label names swapped, so were showing the incorrect fields
2015-06-21 15:14:30 -04:00
Pavel Hrdina
cbd7e33a09 spec: we don't need to depend on qemu-kvm
Similarly as in commit 95cda553, just remove the dependency on qemu-kvm
package for RHEL builds.  We don't need it, becase libvirt-daemon-kvm
will handle this dependency correctly for us even in case that only
qemu-kvm-rhev is present.

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1046651

Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
2015-06-21 15:06:10 -04:00
Pavel Hrdina
3a3a1d5bd4 doc: make --sparse documentation in man page consistent
Commit 549c93be fixed a man page to make --sparse documentation
consistent, but it forget to updated also the next paragraph.

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1210572

Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
2015-06-21 12:47:59 +02:00
Cole Robinson
77423e7a8d connection: catch more errors in filter_nodedevs (bug 1225771)
https://bugzilla.redhat.com/show_bug.cgi?id=1225771 Has an example of
libvirt failing to generate nodedev XML, so handle that too.
2015-06-09 11:41:39 -04:00
Cole Robinson
b82b739d5a tests: Fix output to work the same with libvirt <console> change
See this thread for the original patches:

https://www.redhat.com/archives/virt-tools-list/2015-June/msg00091.html

But this fix is nicer since it will work before those libvirt changes as
well.
2015-06-08 17:41:16 -04:00
Cole Robinson
2d921c6eb7 Prep for release 1.2.1 2015-06-06 18:15:40 -04:00
Cole Robinson
bfa5762d9e guest: Add install cdrom in set_defaults, not start_install (bz 1220180)
Fixes weirdness when using addhardware wizard for a customized VM,
and makes the code easier to follow anyways.
2015-06-06 17:02:20 -04:00
Cole Robinson
cdc0a8fe41 guest: Remove unused code
We don't support the transient install disks anymore
2015-06-06 14:59:48 -04:00
Cole Robinson
19e35b0a5b Fix test output with libvirt 1.2.16 2015-06-06 14:52:16 -04:00
Cole Robinson
8033d33fe3 createinterface: Avoid gtk warning about double setting text renderer 2015-06-06 14:40:19 -04:00
Cole Robinson
853cefbfe8 createinterface: Don't double log about closing dialog 2015-06-06 14:32:04 -04:00