Jelmer Vernooij
03abc846ee
Fix the valid NetBIOS name tests.
2009-04-20 11:11:25 +02:00
Volker Lendecke
4afcde91b9
Convert the domain handles to type-safe policy handles
2009-04-20 08:27:23 +02:00
Günther Deschner
62480385c1
s3-printing: use ARRAY_SIZE() macro in forms functions.
...
Guenther
2009-04-20 01:06:01 +02:00
Günther Deschner
d9aaf3759a
s3-printing: use sec_initial_uid() instead "0" in print_access_check().
...
Another babystep in order to make us pass RPC-SPOOLSS.
Guenther
2009-04-20 00:59:36 +02:00
Günther Deschner
5f0c9c57f5
s4-smbtorture: test all levels in test_GetJob().
...
Guenther
2009-04-20 00:59:36 +02:00
Volker Lendecke
dd073a333e
Make force_flush_samr_cache use a dom_sid to find what to flush
2009-04-19 22:58:06 +02:00
Volker Lendecke
46317ce214
Remove flag "builtin_domain" from disp_info
2009-04-19 11:39:47 +02:00
Volker Lendecke
bf196df52f
Remove flag "builtin_domain" from samr_info
2009-04-19 09:27:15 +02:00
Volker Lendecke
386511b8e1
Make get_samr_info_by_sid use recent coding conventions
2009-04-19 09:27:15 +02:00
Volker Lendecke
35e6a0e618
Add "uint32_t access_granted" to policy handles
...
All policy handles have a mask of allowed operations attached that were
calculated at creation time, so they should carry this mask. This is the basis
for consolidating all our policy handle access checks.
If you want to do your own more complicated access checks further down, just
pass "0" to policy_handle_find.
2009-04-19 09:27:15 +02:00
Volker Lendecke
9b3f2e69f7
Make "struct policy" private to srv_lsa_hnd.c
2009-04-19 09:27:14 +02:00
Volker Lendecke
fa4ff87acd
Convert the samr connect_handles to type-safe calls
2009-04-18 13:58:48 +02:00
Volker Lendecke
c9bc1728f9
Add type-safe policy_handle_create/find
2009-04-18 13:58:48 +02:00
Volker Lendecke
fd558b37f6
Add some const
2009-04-18 13:58:48 +02:00
Günther Deschner
81b18464be
s3-spoolss: remove some direct checks for 0 uid in AddForm,SetForm,DelForm.
...
Also add some become_root()/unbecome_root() pairs which were missing IMHO.
Guenther
2009-04-17 23:20:22 +02:00
Stefan Metzmacher
cdbbc81bad
s3:docs: document the --request-timeout option of net
...
metze
2009-04-17 21:46:48 +02:00
Stefan Metzmacher
257809558b
s3:net: add --request-timeout option
...
metze
2009-04-17 21:46:47 +02:00
Stefan Metzmacher
c0dfe0cf80
s3:net_rpc: don't shutdown a cli_state passed from the caller
...
This fixes a crash bug if we timeout in net rpc trustdom list.
metze
2009-04-17 21:46:46 +02:00
Günther Deschner
6f90cdaf63
s3-selftest: enable RPC-SPOOLSS.
...
Guenther
2009-04-17 17:28:23 +02:00
Günther Deschner
fe2828c353
s4-smbtorture: Skip Job pause and resume on paused printers for Samba 3 for now.
...
Guenther
2009-04-17 17:27:42 +02:00
Günther Deschner
6900d61d36
s3-spoolss: add support for _spoolss_EnumPrinterDrivers() level 6.
...
Guenther
2009-04-17 17:27:32 +02:00
Günther Deschner
5e563ee508
s3-spoolss: add support for _spoolss_EnumPrinterDrivers() level 5.
...
Guenther
2009-04-17 17:27:26 +02:00
Günther Deschner
d76837f6da
s3-spoolss: add support for _spoolss_EnumPrinterDrivers() level 4.
...
Guenther
2009-04-17 17:27:18 +02:00
Günther Deschner
cb9c0cefaf
s4-smbtorture: rework test_EnumPrinterDrivers() a little to succeed with s3.
...
Yes, I feel dirty for this but promise to come back and fix appropriately.
Guenther
2009-04-17 17:25:14 +02:00
Günther Deschner
81253ec146
s4-smbtorture: Fix RPC-SPOOLSS-WIN for printers with a lot of jobs in the queue.
...
Guenther
2009-04-17 17:23:59 +02:00
Michael Adam
d43a49d449
s3: make installmo and uninstallmo scripts executable
...
Michael
2009-04-17 15:57:30 +02:00
Michael Adam
bf1b7ba480
s3: Fix uninstallmo
...
Michael
2009-04-17 15:57:30 +02:00
Günther Deschner
4f9d3400e5
s3-selftest: samba 3 also passes RPC-JOIN so enable it.
...
Guenther
2009-04-17 15:14:44 +02:00
Michael Adam
8c023fea86
s3:registry: Prevent creation of keys containing the '/' character.
...
This creates a broken registry that can only be fixed with
tdbtool, since the '/' sign is used as a key separator after
normalization at a lower level.
This makes e.g. "net conf setparm abc/def comment xyz" fail with
WERR_INVALID_PARAM, which is much more desirable than a broken
registry.tdb.
Michael
2009-04-17 11:46:14 +02:00
Günther Deschner
0ba833f3ee
s3-samr: set the builtin_domain bool flag in get_samr_dispinfo_by_sid().
...
Volker, please check.
Found by torture test RPC-SAMR-PASSWORDS-PWDLASTSET (which we pass with
this fix).
Guenther
2009-04-17 11:21:20 +02:00
Günther Deschner
490f6c418d
s3-selftest: enable RPC-SAMR-PASSWORDS-PWDLASTSET whilte testing Samba3.
...
Guenther
2009-04-17 11:16:00 +02:00
Günther Deschner
32add69632
s4-smbtorture: disable CreateUser2 tests when running RPC-SAMR-PASSWORDS-PWDLAST
...
against Samba3.
Samba 3 does not (yet) get all the ACB_flag settings right upon creation.
Guenther
2009-04-17 11:15:58 +02:00
Jim McDonough
1214bf606d
Merge branch 'master' of /home/jmcd/samba/git.samba.org/samba-master into mymaster
2009-04-17 09:28:01 +02:00
Günther Deschner
05ea8daaca
s3-docs: fix typo in smb.conf.5.
...
Guenther
2009-04-17 01:32:45 +02:00
Günther Deschner
deb719a62e
s3-selftest: enable RPC-LSA-LOOKUPSIDS against samba 3.
...
Guenther
2009-04-17 01:32:45 +02:00
Günther Deschner
c794ba71b7
s4-smbtorture: add LSA-LOOKUPSIDS to verify bug #6263 .
...
Guenther
2009-04-17 01:32:45 +02:00
Günther Deschner
b0a0d2a0ae
s4-smbtorture: Fix crash in RPC-LSA-LOOKUP
...
Guenther
2009-04-17 01:32:44 +02:00
Günther Deschner
5517c0bcdd
s3-docs: document warn_pwd_expire pam_winbind option in manpage.
...
Andreas, please check.
Guenther
2009-04-17 01:32:44 +02:00
Jeremy Allison
37b1b9cfe9
Add torture tester to ensure we don't regress the ulogoff bug.
...
Jeremy.
2009-04-16 16:22:37 -07:00
Jeremy Allison
d55ec4fd23
Fix bug found by Tim Prouty, logging off and then re-using a vuid can cause smbd to
...
access a freed structure.
Jeremy.
2009-04-16 16:22:30 -07:00
Jeremy Allison
265829c32f
When doing a cli_ulogoff don't invalidate the cnum, invalidate the vuid.
...
Jeremy.
2009-04-16 15:16:28 -07:00
Jeremy Allison
6fc8ed7b1f
Fix IDL licensing file that got missed when IDL files were moved.
...
Jeremy.
2009-04-16 12:09:16 -07:00
Jim McDonough
75ccf934ac
Don't look up local user for remote changes, even when root.
2009-04-16 17:14:29 +02:00
Volker Lendecke
32a36e4703
Add notify_onelevel.tdb
...
This optimizes non-recursive notifys. For non-recursive notifies we can use a
per-directory file-id indexed notify record. This matters for the Windows
Explorer and IIS cases which do not use recursive notifies. In these cases, we
do not have to shuffle around the whole notify record on every change.
For the cluster case, this improves correctness of the notifies, ctdb only
distributes the tdb seqnum once a second, so we can lose notifies.
2009-04-16 15:07:06 +02:00
Volker Lendecke
ea3a022ca3
Rename notify_context->db to db_recursive
2009-04-16 15:07:06 +02:00
Martin Schwenke
448b434a86
In net_conf_import, start a transaction when importing a single share.
...
Commit d69c3db9d44ad5d9fd1f5d7a9499f3bd79ecfb47 caused the transaction
start to be conditional but the commit is still unconditional, so an
error occurs when importing a single share.
An alternate fix would be to return the transaction start to be
unconditional but then it would occur before other error checking.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Signed-off-by: Michael Adam <obnox@samba.org>
2009-04-16 10:38:38 +02:00
Stefan Metzmacher
56aae35a23
tsocket: fix the build without ipv6 support
...
metze
2009-04-16 09:31:14 +02:00
Günther Deschner
14304fc5e5
s3-lsa: Fix Bug #6263 . Unexpected LookupSids reply crashes XP pre-SP3.
...
LookupSids needs to bounce back string sids in case of NT_STATUS_NONE_MAPPED.
Guenther
(cherry picked from commit 1c9266c8ca
)
2009-04-16 01:52:56 +02:00
Jeremy Allison
d9804ae3cc
Fix bug #6089 - Winbind samr_OpenDomain not possible with Samba 3.2.6+
...
What a difference a name makes... :-). Just because something is missnamed
SAMR_ACCESS_OPEN_DOMAIN, when it should actually be SAMR_ACCESS_LOOKUP_DOMAIN,
don't automatically use it for a security check in _samr_OpenDomain().
Jeremy.
2009-04-15 15:40:00 -07:00
Günther Deschner
e6aa3f2d09
s4-smbtorture: Fix crash bugs in RPC-SAMR_ACCESSMASK.
...
Also disable security descriptor based tests while testing samba3.
Guenther
2009-04-15 22:50:05 +02:00