1
0
mirror of https://github.com/samba-team/samba.git synced 2024-12-27 03:21:53 +03:00
Commit Graph

65329 Commits

Author SHA1 Message Date
Michael Adam
0dc3cd75a1 s3:groupdb: allocate a gid after allocating a rid in pdb_default_create_alias()
Michael
2010-08-14 02:10:29 +02:00
Michael Adam
b28371b9a4 s3:idmap_tdb2: fix a debug message 2010-08-14 02:10:29 +02:00
Michael Adam
a8492d2a92 s3:test: add a new "valgrindtestenv" target, similar to gdbtestenv
this runs the daemins in xterm under valgrind instead of in gdb
2010-08-14 01:54:37 +02:00
Michael Adam
1bc1fbe5fd s3:gdbtestenv: also start an xterm with nmbd. and start winbindd before smbd. 2010-08-14 01:52:41 +02:00
Michael Adam
40090d9b24 s3:gdbtestenv: also set the xterm's window title appropriately 2010-08-14 01:51:39 +02:00
Michael Adam
e051f3bd62 s3:gdbtestenv: print the server's name in the icontitle instead of "server" 2010-08-14 01:48:09 +02:00
Michael Adam
045f4c96d5 pidl: fix printing of server side ndr request debug messages
The macros NDR_PRINT_IN_DEBUG and NDR_PRINT_OUT_DEBUG are made for
the client side. For the server side, the NDR_SET_VALUES flag needs
to be added for the OUT struct and not for the IN struct, otherwise,
the OUT part can print uninitialized data and the IN part may
recalculate string lengths illegally.
2010-08-13 23:50:41 +02:00
Volker Lendecke
ad871b73a2 s3: Fix some error messages 2010-08-13 22:53:06 +02:00
Jeremy Allison
15d3541c67 Eliminate any chance of a class of "uninitialized auto variable" errors.
Jeremy.
2010-08-13 10:49:18 -07:00
Rusty Russell
11ab43084b tdb: workaround starvation problem in locking entire database.
We saw tdb_lockall() take 71 seconds under heavy load; this is because Linux
(at least) doesn't prevent new small locks being obtained while we're waiting
for a big log.

The workaround is to do divide and conquer using non-blocking chainlocks: if
we get down to a single chain we block.  Using a simple test program where
children did "hold lock for 100ms, sleep for 1 second" the time to do
tdb_lockall() dropped signifiantly.  There are ln(hashsize) locks taken in
the contended case, but that's slow anyway.

More analysis is given in my blog at http://rusty.ozlabs.org/?p=120

This may also help transactions, though in that case it's the initial
read lock which uses this gradual locking routine; the update-to-write-lock
code is separate and still tries to update in one go.

Even though ABI doesn't change, minor version bumped so behavior change
can be easily detected.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2010-08-14 02:31:22 +09:30
Günther Deschner
f00b61c7d4 s3-selftest: move make test to selftest.
The old "make test" can be still called as "make oldtest".

Guenther
2010-08-13 18:30:50 +02:00
Günther Deschner
472d2a356f s3-selftest: fix testparm tests as non-root.
Thanks to Andreas for pointing this out.

Guenther
2010-08-13 18:30:37 +02:00
Andreas Schneider
ca8db7fd63 s3-smbd: Publish nt printers.
Reloading of the printers requires rpc services up and running! The
first call in reload_services will be skipped.

Signed-off-by: Simo Sorce <idra@samba.org>
2010-08-13 12:20:10 -04:00
Andreas Schneider
aff002e829 s3-smbd: Move rpc services init to smbd parent.
The move to the parent makes it possible to use an internal rpc pipe
really early and as we migrated serveral parts of samba to rpc function
this is required. This should speed up the fork of a smbd a bit cause
the rpc services are already running.

We still have several problems here which aren't solved. We don't have a
dependency tree here. For example we have to make sure that the registry
is initialized before we can use the winreg pipe. The spoolss server
requires winreg, so we have to start winreg before we can start the
spoolss server. I'm sure there are more dependencies.

Signed-off-by: Simo Sorce <idra@samba.org>
2010-08-13 12:20:10 -04:00
Andreas Schneider
62a2a9e27f s3-smbd: Regroup some init functions.
Signed-off-by: Simo Sorce <idra@samba.org>
2010-08-13 12:20:10 -04:00
Andreas Schneider
9ab62b774f s3-smbd: Fixed indent.
Signed-off-by: Simo Sorce <idra@samba.org>
2010-08-13 12:20:10 -04:00
Andreas Schneider
4a5cef82d8 s3-loadparm: Added some comments to lp_load_ex calls.
Signed-off-by: Simo Sorce <idra@samba.org>
2010-08-13 12:20:10 -04:00
Andreas Schneider
e18039062c s3-smbd: Cleanup the order of the init functions.
Signed-off-by: Simo Sorce <idra@samba.org>
2010-08-13 12:20:10 -04:00
Andreas Schneider
120bd9775a s3-smbd: Make sure the event context is initialized.
Signed-off-by: Simo Sorce <idra@samba.org>
2010-08-13 12:20:10 -04:00
Günther Deschner
2c99eef355 s3-build: remove pointless RPC_PARSE_OBJ2.
Guenther
2010-08-13 16:04:41 +02:00
Günther Deschner
0f264935e0 s3-waf: remove pointless RPC_PARSE_SRC2.
Guenther
2010-08-13 16:04:40 +02:00
Volker Lendecke
734f581906 s3: Replace some cli_errstr calls by nt_errstr 2010-08-13 16:03:04 +02:00
Günther Deschner
06a2c23641 s3-libnet: also remove libnet/libnet_samsync_keytab.c.orig.
Guys, what are you doing here ? ;-)

Guenther
2010-08-13 15:24:00 +02:00
Günther Deschner
f0475ac36c s3-libnet: remove source3/libnet/libnet_join.c.orig, added by a previous commit.
Guenther
2010-08-13 15:22:06 +02:00
Günther Deschner
bb8936c087 s3-dcerpc: fix build warning seen with -O3.
"warning: assuming signed overflow does not occur when assuming that (X + c) < X is always false"

Guenther
2010-08-13 15:20:58 +02:00
Andrew Bartlett
71d80e6be0 s3-krb5 Only build ADS support if arcfour-hmac-md5 is available
Modern Kerberos implementations have either defines or enums for these
key types, which makes doing #ifdef difficult.  This shows up in files
such as libnet_samsync_keytab.c, the bulk of which is not compiled on
current Fedora 12, for example.

The downside is that this makes Samba unconditionally depend on the
arcfour-hmac-md5 encryption type at build time.  We will no longer
support libraries that only support the DES based encryption types.
However, the single-DES types that are supported in common with AD are
already painfully weak - so much so that they are disabled by default
in modern Kerberos libraries.

If not found, ADS support will not be compiled in.

This means that our 'net ads join' will no longer set the
ACB_USE_DES_KEY_ONLY flag, and we will always try to use
arcfour-hmac-md5.

A future improvement would be to remove the use of the DES encryption
types totally, but this would require that any ACB_USE_DES_KEY_ONLY
flag be removed from existing joins.

Andrew Bartlett

Signed-off-by: Simo Sorce <idra@samba.org>
2010-08-13 09:08:27 -04:00
Andrew Bartlett
fff6fa72ff s3:libnet Add other required headers for libnet_samsync_keytab.c
Due to missing defines in modern kerberos libraries, this code was
not compiled and so this wasn't noticed.

Andrew Bartlett

Signed-off-by: Simo Sorce <idra@samba.org>
2010-08-13 09:08:27 -04:00
Björn Jacke
5390baeb6b tdb: add TDB_DEPS variable filled with required libraries
This is required for Solaris, which needs to link in librt to make use of
fdatasync().
2010-08-13 14:57:44 +02:00
Günther Deschner
37177f1c05 s3-build: pointless to link in libads and dcutils into smbcacls.
Guenther
2010-08-13 13:55:52 +02:00
Günther Deschner
3f76555ebe s3-build: separate out libads_printer.
Guenther
2010-08-13 12:02:06 +02:00
Günther Deschner
d1be71f1e0 s3-waf: separate out libads_printer.
Guenther
2010-08-13 12:01:58 +02:00
Günther Deschner
b0343b2c0b s3-selftest: add testparm tests to selftest.
Guenther
2010-08-13 11:44:40 +02:00
Jeremy Allison
84fd910c34 Fix bug #7617 - smbd coredump due to uninitialized variables in the performance counter code.
In the file rpc_server.c, function _winreg_QueryValue()

uint8_t *outbuf

Should be :

uint8_t *outbuf = NULL;

As it is later freed by

      if (free_buf) SAFE_FREE(outbuf);

in some cases, this frees the unintialized outbuf, which causes a coredump.
2010-08-12 15:16:42 -07:00
Jim McDonough
c67b4ed3a4 s3-libnet: fix bug #6364: Pull realm from supplied username on libnet join 2010-08-12 17:51:02 -04:00
Günther Deschner
73a69e2d0f s3-waf: fix the build.
Guenther
2010-08-12 16:51:48 +02:00
Björn Jacke
616e187d68 s3: fall back to cups-config for underlinked libs
some OpenBSD systems have underlinked cups libraries. If linking against cups
alone fails, try to link against all the cups-config --libs cruft, which we
usually don't want. (bugzila #7244)
2010-08-12 16:30:35 +02:00
Björn Jacke
1d443f6bc2 Revert "s3: Use cups-config --libs"
This reverts commit 911db76114. This was introduced in 18f1f5b56b
intentionally.
2010-08-12 16:30:35 +02:00
Günther Deschner
feb432292e ntlmssp: fix unitialized variable in ntlmssp_server_postauth().
Guenther
2010-08-12 16:28:10 +02:00
Stefan Metzmacher
5130e664b9 pidl:Samba3/ClientNDR: implement rpccli_ stubs on top of dcerpc_ stubs
metze
2010-08-12 14:31:23 +02:00
Stefan Metzmacher
56a6a972f2 s3:Makefile: link in dcerpc client stubs
metze
2010-08-12 14:31:23 +02:00
Stefan Metzmacher
7e24d1dd57 s3:winbindd: add wbint dcerpc_binding_handle backend
metze
2010-08-12 14:31:22 +02:00
Stefan Metzmacher
262dcfcd87 s3:rpc_server: add rpc_pipe_open_internal dcerpc_binding_handle backend
metze
2010-08-12 14:31:22 +02:00
Stefan Metzmacher
2c0e296dd7 s3:rpc_client: add dcerpc_binding_handle backend
metze
2010-08-12 14:31:21 +02:00
Stefan Metzmacher
b34209006f s4:librpc/rpc: make struct dcerpc_binding_handle private
metze
2010-08-12 14:31:21 +02:00
Stefan Metzmacher
51fb4c3860 pidl:Samba4/NDR/Client: add sync dcerpc_pipe based stubs as compat for OpenChange
This will activate the compat wrappers for all functions of an interface:
 #define DCERPC_IFACE_MYPROTO_COMPAT 1
 #include <ndr_myproto_c.h>

This will activates the compat wrappers just for specific functions:
 #define DCERPC_CALL_MYFN1_COMPAT 1
 #define DCERPC_CALL_MYFN2_COMPAT 1
 #include <ndr_myproto_c.h>

metze
2010-08-12 14:31:20 +02:00
Stefan Metzmacher
719981adfd pidl:Samba4/NDR/Client: add non struct base dcerpc_binding_handle client stubs
metze
2010-08-12 14:31:20 +02:00
Stefan Metzmacher
62297dff8f pidl:Samba4/NDR/Client: convert code to $self->pidl()
metze
2010-08-12 14:31:19 +02:00
Stefan Metzmacher
570eefc57a pidl:Samba4/NDR/Client: s/interface/if/
metze
2010-08-12 14:31:19 +02:00
Stefan Metzmacher
76691e9eaf pidl:Samba4/NDR/Client: make use of the new dcerpc_binding_handle_call() infrastructure
metze
2010-08-12 14:31:18 +02:00
Stefan Metzmacher
db89fdac73 pidl:Samba4/NDR/Client: remove old dcerpc_pipe based sync stubs
They're unused in Samba and only used by OpenChange.
I'll add a compat functions for OpenChange later.

metze
2010-08-12 14:31:18 +02:00