1
0
mirror of https://github.com/samba-team/samba.git synced 2025-01-12 09:18:10 +03:00
Commit Graph

3534 Commits

Author SHA1 Message Date
Volker Lendecke
23998e1da8 r24320: Fix the wct checks in reply_trans2 and the reply_trans calls
No idea what I've been smoking here.

Thanks to Stefan for closely looking
(This used to be commit 708f5af2e8)
2007-10-10 12:29:28 -05:00
Volker Lendecke
d465b468c1 r24319: Check wct in reply_read_and_X
(This used to be commit 9ddacdfa13)
2007-10-10 12:29:28 -05:00
Volker Lendecke
c898c51984 r24318: Print a prominent warning when reply_prep_legacy is called
This is a temporary function anyway
(This used to be commit 9269e3d588)
2007-10-10 12:29:27 -05:00
Volker Lendecke
3c5811c272 r24314: Attempt to fix bug 4868
(This used to be commit 0ced8fcfe1)
2007-10-10 12:29:27 -05:00
Stefan Metzmacher
5cc4dbd449 r24312: revision 24091 removed the 'FORCE'...
metze
(This used to be commit 34d821daf0)
2007-10-10 12:29:27 -05:00
Stefan Metzmacher
a5f412f305 r24311: add a reply_force_nterror() macro
metze
(This used to be commit b9ae00f498)
2007-10-10 12:29:27 -05:00
Stefan Metzmacher
c25f22562e r24310: we should not call END_PROFILE(SMBntcreateX); twice...
metze
(This used to be commit 7a98e09f2e)
2007-10-10 12:29:27 -05:00
Stefan Metzmacher
66294f9db5 r24309: if no protocol matches, just return choise 0xffff
as we've done before revision 24002

metze
(This used to be commit 6014ecbbfd)
2007-10-10 12:29:26 -05:00
Stefan Metzmacher
aece6db714 r24308: this needs a better fix that compiles...
metze
(This used to be commit 1a177eb08d)
2007-10-10 12:29:26 -05:00
Stefan Metzmacher
f210f7c432 r24307: fill in choise with value -1 on error
as we've done before revision 24002

metze
(This used to be commit 2961a35e90)
2007-10-10 12:29:26 -05:00
Stefan Metzmacher
9239b8e8d3 r24306: the check_fsp() function has an explicit user argument
so use it...

metze
(This used to be commit 4154bee0d9)
2007-10-10 12:29:26 -05:00
Volker Lendecke
12d94f77f9 r24279: Remove reply_prep_legacy from reply_write_and_X
(This used to be commit f18b7a9a28)
2007-10-10 12:29:24 -05:00
Volker Lendecke
a6810cb9a3 r24278: Push down reply_prep_legacy in reply_write_and_X
Remove the need for reply_prep_legacy for reply_pipe_write_and_X
(This used to be commit de143d5fa6)
2007-10-10 12:29:24 -05:00
Stefan Metzmacher
3e8fc031c8 r24272: try to fix the build on irix...
metze
(This used to be commit dd7e94258b)
2007-10-10 12:29:24 -05:00
Volker Lendecke
b0dc209c19 r24271: Push reply_prep_legacy into reply_write_and_X
(This used to be commit 607e7d2447)
2007-10-10 12:29:24 -05:00
Volker Lendecke
1f67efab7c r24270: Fix some END_PROFILE(SMBwriteX)
(This used to be commit 36f2347561)
2007-10-10 12:29:23 -05:00
Volker Lendecke
bb9664302b r24269: Check wct in reply_write_and_X
(This used to be commit 1297fac117)
2007-10-10 12:29:23 -05:00
Volker Lendecke
456305325c r24268: Fix two crashes for spoolss
strlcpy does not like a NULL source. Fix a use-after-free.
(This used to be commit c2a2145017)
2007-10-10 12:29:22 -05:00
Volker Lendecke
d18b7b1223 r24254: Fix a segfault in r24102
The really pure bugfix would have replaced pparam by *pparam, but we pulled
the fid anyway.

Metze, in line 2421 the FSP_BELONGS_CONN is commented out, is that intended?
The FSCTL_CREATE_OR_GET_OBJECT_ID ioctl did not have it.

Volker
(This used to be commit 2c1376225b)
2007-10-10 12:29:21 -05:00
Jeremy Allison
d75a38ae26 r24253: From Jan Martin <Jan.Martin@rwedea.com>.
----------------------------------------------------------
In rare cases, Samba 3.0.25b shows directory contents at the wrong
position in the file tree when displaying a subdirectory of a DFS link.

The problem occurs whenever Windows XP asks for a DFS referral for a
subdirectory of a DFS link with a trailing backslash.
Windows does not do this very often, but we saw it several times per day
on our central DFS server.

smbd/msdfs.c, dfs_path_lookup() does the following with the requested
path:
- in line 390, the local copy 'localpath' is 'unix_convert'ed; the
trailing backslash is removed inside unix_convert
- in lines 417-20, 'dfspath' (another copy of the requested path) is
mangled another way without removing trailing backslashes

That's why the following loop (lines 435-461) that is meant to
synchronously cut off the last path component from both strings until it
comes to a DFS link, does not handle both strings the same.  When the
original path ended with a backslash, 'canon_dfspath' has always one
component more than 'localpath', so that *consumedcntp gets too big in
line 446. This value is reported to the client.
----------------------------------------------------------

Bug #4860.

Jeremy.
(This used to be commit 42d1c6713a)
2007-10-10 12:29:21 -05:00
Volker Lendecke
b0ed26faf0 r24244: Complete the conversion of reply_trans[s]
Remove reply_prep/post_legacy from send_trans_replies
(This used to be commit c08366f840)
2007-10-10 12:29:20 -05:00
Volker Lendecke
d274724ebb r24243: Remove reply_prep_legacy from api_reply
(This used to be commit b01664b43b)
2007-10-10 12:29:20 -05:00
Volker Lendecke
43a77ab149 r24242: Remove reply_prep_legacy from api_rpc_trans_reply
(This used to be commit 160f65946a)
2007-10-10 12:29:20 -05:00
Volker Lendecke
40f6afcea2 r24241: Remove reply_prep_legacy from api_WNPHS and api_SNPHS
(This used to be commit 8702450e91)
2007-10-10 12:29:20 -05:00
Volker Lendecke
b8de67a2f2 r24240: Push down reply_prep_legacy one level inside api_fd_reply
(This used to be commit 0bb95639d6)
2007-10-10 12:29:20 -05:00
Volker Lendecke
fbe15d8db9 r24239: Push reply_prep_legacy into api_fd_reply
(This used to be commit e2a9649792)
2007-10-10 12:29:20 -05:00
Volker Lendecke
bcd0bf8e5e r24238: Push down reply_prep_legacy one level
(This used to be commit a6a2d97fac)
2007-10-10 12:29:19 -05:00
Volker Lendecke
d57a88a994 r24237: Add send_trans_reply_new
(This used to be commit f0598b3ca0)
2007-10-10 12:29:19 -05:00
Volker Lendecke
97a817dceb r24236: Push reply_prep_legacy() into named_pipe()
(This used to be commit b38f9347e8)
2007-10-10 12:29:19 -05:00
Volker Lendecke
3bb9f20bc3 r24235: Make handle_trans reply to errors itself
(This used to be commit 06d0c74b74)
2007-10-10 12:29:19 -05:00
Volker Lendecke
abc519ff43 r24234: Reformatting -- SCNR
(This used to be commit 040d6d5db6)
2007-10-10 12:29:19 -05:00
Volker Lendecke
e41528c3f4 r24233: Push reply_prep_legacy into handle_trans
(This used to be commit dc27c3c668)
2007-10-10 12:29:19 -05:00
Volker Lendecke
0cfea6de67 r24232: Push down reply_prep_legacy inside reply_transs
(This used to be commit 511f8bc030)
2007-10-10 12:29:18 -05:00
Volker Lendecke
1d3c1de502 r24231: Push allocating InBuffer/OutBuffer into reply_transs
(This used to be commit 74ae19cca6)
2007-10-10 12:29:18 -05:00
Volker Lendecke
f1822fe737 r24230: Push down reply_prep_legacy in reply_trans
The last checkin was for reply_trans, not reply_transs
(This used to be commit 50a2bfd9e0)
2007-10-10 12:29:18 -05:00
Volker Lendecke
133ef281c0 r24229: Push allocating InBuffer/OutBuffer into reply_transs
(This used to be commit 39a7809aa4)
2007-10-10 12:29:18 -05:00
Volker Lendecke
5d2031915e r24225: Convert reply_flush to the new API
(This used to be commit f843c02f07)
2007-10-10 12:29:18 -05:00
Volker Lendecke
bf160bb621 r24224: Check wct in reply_trans
(This used to be commit fc8759e63c)
2007-10-10 12:29:18 -05:00
Volker Lendecke
c847b2afe7 r24223: Convert reply_echo to the new API
(This used to be commit 4863ff2899)
2007-10-10 12:29:17 -05:00
Jeremy Allison
01ee1c7909 r24164: Fix for write cache corruption bug reported by Jean-Francois Panisset <panisset@A52.com>.
Awaiting confirmation from reporter.
Jeremy.
(This used to be commit 7bd65060bd)
2007-10-10 12:29:17 -05:00
Volker Lendecke
c7a425f30f r24163: Remove the send_trans2_replies_new wrapper
This changes send_trans2_replies to not depend on large buffers anymore
and finishes the trans2 conversion.
(This used to be commit b1d133e4ff)
2007-10-10 12:29:16 -05:00
Volker Lendecke
c2fb81bbf0 r24162: send_trans2_replies is now static in trans2.c
(This used to be commit 47261fb6fe)
2007-10-10 12:29:16 -05:00
Volker Lendecke
72ce8ef168 r24161: handle_trans2 takes care of errors itself, no need to do it in reply_transs2
(This used to be commit ca26b43e02)
2007-10-10 12:29:16 -05:00
Volker Lendecke
9f3062d8a7 r24160: process_trans2 in smbd/blocking.c used send_trans2_replies.
Fake a struct smb_request here.

Volker
(This used to be commit f712d1c92b)
2007-10-10 12:29:16 -05:00
Volker Lendecke
1d8851f4c7 r24159: Convert reply_transs2 to the new API
(This used to be commit a55a4d71ff)
2007-10-10 12:29:15 -05:00
Volker Lendecke
e2f0b5dd2a r24156: Convert reply_trans2 to the new API
(This used to be commit a9c2d75b42)
2007-10-10 12:29:15 -05:00
Volker Lendecke
675a484670 r24155: Check wct in reply_trans2
(This used to be commit e0a708c79b)
2007-10-10 12:29:15 -05:00
Volker Lendecke
c28bd38aa6 r24154: handle_trans2 does not reference inbuf/outbuf anymore
(This used to be commit 8eb016a91e)
2007-10-10 12:29:14 -05:00
Volker Lendecke
2516942a4b r24153: Convert call_trans2setfsinfo to the new API.
This *might* break the transport encryption stuff. I need to check that.
(This used to be commit 82b34d7bdb)
2007-10-10 12:29:14 -05:00
Volker Lendecke
4514ea2034 r24152: Convert call_trans2ioctl to the new API
(This used to be commit db4e6781c4)
2007-10-10 12:29:14 -05:00