1
0
mirror of https://github.com/samba-team/samba.git synced 2025-01-12 09:18:10 +03:00
Commit Graph

3534 Commits

Author SHA1 Message Date
Volker Lendecke
70496e030f r24151: Convert call_trans2getdfsreferral to the new API
(This used to be commit 642c58648b)
2007-10-10 12:29:14 -05:00
Volker Lendecke
ccd0b815e8 r24150: Convert call_trans2qfsinfo to the new API
(This used to be commit cdd86497b9)
2007-10-10 12:29:14 -05:00
Volker Lendecke
24e97edc78 r24149: Convert call_trans2setfilepathinfo to the new API
(This used to be commit 50aa149cef)
2007-10-10 12:29:13 -05:00
Volker Lendecke
67fde05d68 r24148: Remove some inbuf refs from subcommands of call_trans2setfilepathinfo
(This used to be commit 09ed6537b3)
2007-10-10 12:29:13 -05:00
Volker Lendecke
f2e2c22b6f r24147: Remove some inbuf refs from call_trans2setfilepathinfo
(This used to be commit a13c42be75)
2007-10-10 12:29:13 -05:00
Volker Lendecke
fe92fdc67d r24145: Fix a comment
(This used to be commit 34a00d8aa9)
2007-10-10 12:29:13 -05:00
Volker Lendecke
bd627a1597 r24144: Fix the build
In a function returning void the "return;" needs to stand alone on some
compilers
(This used to be commit 28affcca8e)
2007-10-10 12:29:12 -05:00
Volker Lendecke
44c5ee4ca6 r24143: Convert call_trans2qfilepathinfo to the new API
(This used to be commit 0b84e29120)
2007-10-10 12:29:12 -05:00
Volker Lendecke
fa2b8a447a r24142: Remove some direct inbuf references from call_trans2qfilepathinfo
(This used to be commit c9c0133d55)
2007-10-10 12:29:12 -05:00
Volker Lendecke
2945d4492d r24141: Add check_fsp as a replacement for CHECK_FSP
(This used to be commit a3d77a576f)
2007-10-10 12:29:12 -05:00
Volker Lendecke
e3a53acafe r24140: Convert call_trans2findnotifyfirst/next to the new API
(This used to be commit 46d9c51631)
2007-10-10 12:29:11 -05:00
Volker Lendecke
133a8bbe07 r24139: Convert call_trans2mkdir to the new API
(This used to be commit d0b7f409e1)
2007-10-10 12:29:11 -05:00
Volker Lendecke
a1d70fcad7 r24138: Convert call_trans2findnext to the new API
(This used to be commit af1855e4ce)
2007-10-10 12:29:11 -05:00
Volker Lendecke
e5ad62702b r24137: Convert call_trans2findfirst to the new API
(This used to be commit 238edebab7)
2007-10-10 12:29:11 -05:00
Volker Lendecke
4d34c5eef7 r24136: get_lanman2_dir_entry() does not need access to inbuf/outbuf
It did not use inbuf anyway. Outbuf was used for alignment and to the
flags2. The alignment works ok if we align relative to base_data because this
and outbuf are both malloc'ed, and we put send_trans2_replies aligns out_data
properly relative to the start of the outbuf.

I don't know if the explicit align_string() calls in get_lanman2_dir_entry are
really necessary. I think that srvstr_push also does the same.

Please also note that this changes dst_len in srvstr_push from -1 to the real
length remaining.

Volker
(This used to be commit 9b1614f8cb)
2007-10-10 12:29:10 -05:00
Volker Lendecke
b91704d47b r24135: Convert call_trans2open to the new API
This itself won't help much, because send_trans2_replies_new still allocates
the big buffers, but stay tuned :-)

Also add/update my copyright on stuff I recently touched.

Volker
(This used to be commit 248f15ff14)
2007-10-10 12:29:10 -05:00
Volker Lendecke
d526657d5f r24134: talloc smb_request for handle_trans2
When starting to convert the individual trans2 subcalls, I need the new
API conventions to be present there. This means that those calls fill in
req->outbuf when there's something to ship
(This used to be commit d9eef977dc)
2007-10-10 12:29:10 -05:00
Volker Lendecke
b62bd05b93 r24133: Explicitly pass flags2 down to push_string_fn
This needs a bit closer review, it also touches the client libs
(This used to be commit 824eb26738)
2007-10-10 12:29:10 -05:00
Volker Lendecke
6c6fed5e65 r24130: Explicitly pass flags2 to srvstr_push
This is in preparation of the trans2 conversion: srvstr_push should not
look at inbuf directly.
(This used to be commit 5fd7e6a382)
2007-10-10 12:29:09 -05:00
Stefan Metzmacher
4b15f31f10 r24120: add a file_id_create() hook into the VFS layer
it's needed for some cluster filesystems to
overload this function.

metze
(This used to be commit cdaa24e804)
2007-10-10 12:29:08 -05:00
Volker Lendecke
a0a9a301d2 r24119: Convert reply_exit to the new API
(This used to be commit d4d550aa2b)
2007-10-10 12:29:08 -05:00
Volker Lendecke
bfbd756535 r24106: Pass fnum instead of buf/offset into get_rpc_pipe_p
(This used to be commit eb353412c6)
2007-10-10 12:29:07 -05:00
Volker Lendecke
a2d6aa829f r24102: Pass the fid instead of inbuf and an offset to file_fsp.
This removes the buf==NULL condition in file_fsp(), but wherever it is called
we do have a buffer anyway.

Volker
(This used to be commit d70a1f82fe)
2007-10-10 12:29:07 -05:00
Volker Lendecke
3d769de244 r24101: Move prohibited_ea_names[] into samba_private_attr_name()
Minor cleanup
(This used to be commit 0487971722)
2007-10-10 12:29:06 -05:00
Volker Lendecke
4473a5ec54 r24100: Convert reply_ntcancel to the new API
(This used to be commit 6e5f39379f)
2007-10-10 12:29:06 -05:00
Volker Lendecke
ae5da66e23 r24097: Convert reply_ntcreate_and_X_quota to the new API
(This used to be commit 08acadae56)
2007-10-10 12:29:06 -05:00
Volker Lendecke
04dcbbbd68 r24092: Convert do_ntcreate_pipe_open to the new API
nt_open_pipe_new() is a copy of nt_open_pipe(). It will stick for a bit
until do_nt_transact_create_pipe is converted as well.
(This used to be commit 247d6baaed)
2007-10-10 12:29:05 -05:00
Volker Lendecke
d95725370f r24091: Convert reply_ntcreate_and_X to the new API
The routines called will follow
(This used to be commit 28025fc17e)
2007-10-10 12:29:05 -05:00
Volker Lendecke
5e9d12cd30 r24090: Separate parsing in reply_ntcreate_and_X
In particular, check if we have enough parameters
(This used to be commit 7a19b3071e)
2007-10-10 12:29:05 -05:00
Volker Lendecke
15dc8917db r24089: Add reply_prep/post_legacy
Routines to ease the transition to the new API
(This used to be commit 1bb2b341e2)
2007-10-10 12:29:04 -05:00
Volker Lendecke
4254af7180 r24088: Convert reply_unlink to the new API
(This used to be commit fb0a1b7bd0)
2007-10-10 12:29:04 -05:00
Volker Lendecke
8084a39ce0 r24086: Convert reply_ulogoffX to the new API
(This used to be commit bbc99e1c3b)
2007-10-10 12:29:04 -05:00
Volker Lendecke
4694e757ba r24085: Convert reply_rmdir to the new API
(This used to be commit 7689048d71)
2007-10-10 12:29:03 -05:00
Volker Lendecke
68513d521d r24084: Convert reply_mkdir to the new API
(This used to be commit e93f3996fc)
2007-10-10 12:29:03 -05:00
Volker Lendecke
ef97e2dece r24079: Convert reply_dskattr to the new API
(This used to be commit c8e0aa5752)
2007-10-10 12:29:03 -05:00
Volker Lendecke
4392d47b34 r24078: Add reply_unixerror
(This used to be commit 10ac991750)
2007-10-10 12:29:02 -05:00
Volker Lendecke
09b3d25252 r24077: Convert reply_tdis to the new API
(This used to be commit bd0cb48dde)
2007-10-10 12:29:02 -05:00
Volker Lendecke
dd98820185 r24071: Fix a missing END_PROFILE call
(This used to be commit c9f12326dd)
2007-10-10 12:29:01 -05:00
Volker Lendecke
c1ca4c298b r24070: Apply some const
(This used to be commit e6d592dcb8)
2007-10-10 12:29:01 -05:00
Volker Lendecke
7d2d4ddfa2 r24056: Another big one: This converts reply_sesssetup_and_X to the new API. As usual,
its history can be found on http://samba.org/~vlendec/sesssetup/. This very
obviously needs close review.

Volker
(This used to be commit 35675a6a33)
2007-10-10 12:29:00 -05:00
Volker Lendecke
e29325a6ce r24050: Fix a typo
(This used to be commit 53027d0ee2)
2007-10-10 12:29:00 -05:00
Volker Lendecke
115062e7ce r24049: Some more 64-bit warnings
(This used to be commit eabe796e46)
2007-10-10 12:28:59 -05:00
Volker Lendecke
e5cdc454aa r24046: Fix a 64-bit warning
(This used to be commit a2ecc34aa4)
2007-10-10 12:28:59 -05:00
Stefan Metzmacher
1ba6f17278 r24029: merge from http://samba.org/~tridge/samba_3_2_ctdb/:
the claim_connection() must come after the sockets are open

metze
(This used to be commit 306846a14f)
2007-10-10 12:28:57 -05:00
Volker Lendecke
8e2aa47b3f r24009: Revert to the 3.0.25 logic for parsing the client's protocols. hpisgr8
with gcc still gives timeouts which worry me.

Volker
(This used to be commit c30835b4f0)
2007-10-10 12:28:56 -05:00
Volker Lendecke
3a836c3ee4 r24006: Some more paranoia in reply_negprot
Some hosts see the smb_bufrem(req->inbuf, p) as an unsigned int. And as
the p += strlen(p) + 2 went one beyond the buffer, this was a very
large positive. Also take the chance to add one more consistency check.
(This used to be commit 3673707f9f)
2007-10-10 12:28:55 -05:00
Volker Lendecke
01d5091c26 r24004: Convert reply_checkpath to the new API
(This used to be commit e5c7c6406a)
2007-10-10 12:28:55 -05:00
Volker Lendecke
db9f25c1c5 r24003: Convert reply_tcon_and_X to the new API
(This used to be commit 9422385d9c)
2007-10-10 12:28:55 -05:00
Volker Lendecke
3d12c53eb3 r24002: Convert reply_negprot to the new API
(This used to be commit bd981f5328)
2007-10-10 12:28:54 -05:00
Volker Lendecke
de1c9f1f6d r24001: Separate out the parsing of the client's requested protocols
This way the range checking only needs to be done once
(This used to be commit befaa9713a)
2007-10-10 12:28:54 -05:00
Volker Lendecke
944fe69d03 r24000: Add message_push_blob() and message_push_string().
The proposed new API convention is to start with a 0 bcc length and then
push things step by step. These routines reallocate the outbuf and
adjust the length and bcc fields as necessary.
(This used to be commit 624f1fe4f6)
2007-10-10 12:28:54 -05:00
Volker Lendecke
9e40557047 r23999: Convert reply_open_and_X
This is an example of chained code that is executed in make test
(This used to be commit e3a10e9ffb)
2007-10-10 12:28:54 -05:00
Volker Lendecke
47cdfc0413 r23998: Convert reply_close to the new API
(This used to be commit dbf74cb747)
2007-10-10 12:28:54 -05:00
Volker Lendecke
cc6a41017c r23997: Check in the infrastructure for getting rid of the global InBuffer/OutBuffer
The complete history of this patch can be found under
http://www.samba.org/~vlendec/inbuf-checkin/.

Jeremy, Jerry: If possible I would like to see this in 3.2.0. I'm only
checking into 3_2 at the moment, as it currently will slow down operations for
all non-converted (i.e. all at this moment) operations, as it will copy the
talloc'ed inbuf over the global InBuffer. It will need quite a bit of effort
to convert everything necessary for the normal operations an XP box does.

I have patches for negprot, session setup, tcon_and_X, open_and_X, close. More
to come, but I would appreciate some help here.

Volker
(This used to be commit 5594af2b20)
2007-10-10 12:28:53 -05:00
Volker Lendecke
041204d1a4 r23996: One more const
(This used to be commit a54fa551a4)
2007-10-10 12:28:53 -05:00
Volker Lendecke
530f6a927b r23992: Some const
(This used to be commit bc106cf507)
2007-10-10 12:28:53 -05:00
Volker Lendecke
8579dd4ded r23990: Reformatting for 80 cols and trailing whitespace
(This used to be commit 0484de27d9)
2007-10-10 12:28:53 -05:00
Volker Lendecke
941db29ab4 r23988: Looks a lot more scary than it is: This just unwraps the else-branch of
if (smb_messages[type].fn == NULL) { into the function top-level. Makes
this function a bit easier to understand IMO.

Volker
(This used to be commit ada23b7f06)
2007-10-10 12:28:52 -05:00
Volker Lendecke
799c3ec8d4 r23987: Remove static pid in switch_message()
There's no point in duplicating functionality that exists in
sys_getpid() that also only used in a debug statement
(This used to be commit ebf1b1e97c)
2007-10-10 12:28:52 -05:00
Volker Lendecke
16443996b5 r23967: Memleak fix from Atsushi Nakabayashi <nakabayashi@miraclelinux.com>
Thanks!

Volker
(This used to be commit 46997a7019)
2007-10-10 12:28:50 -05:00
Jeremy Allison
e6c6c0438d r23942: Fix issue found by Shlomi Yaakobovich <Shlomi@exanet.com> where
invalid names sent as a resume name were incorrectly mapped into
. and .. Ensure they really *are . and ..
Jeremy.
(This used to be commit 78d0c5194f)
2007-10-10 12:28:47 -05:00
Jeremy Allison
921ac7da4f r23941: Don't use "False" when you mean "MARSHALL".
Jeremy.
(This used to be commit 57d4d5f2cd)
2007-10-10 12:28:47 -05:00
Jeremy Allison
cf09627894 r23940: Added missing line that was deleted accidently.
Should fix the build.
Jeremy.
(This used to be commit b085366d5b)
2007-10-10 12:28:47 -05:00
Jeremy Allison
ed9e0d9a3a r23939: Fixes for notify returns. Returned param value must fix inside
max_param or return NT_STATUS_OK.
Jeremy.
(This used to be commit ab4af60d1a)
2007-10-10 12:28:47 -05:00
Jeremy Allison
14826b0a79 r23935: We were lying to the client in the case of POSIX_UNLINK
if a Windows client had the file open. We were setting
delete on close and returning "ok". The POSIX client then
believed the file was gone (and it wasn't). Fix this to
return SHARING_VIOLATION if there is an existing NTcreateX
open on the file and someone calls POSIX_UNLINK. Still one
more Cthon test to fix but getting closer now. Should
be in 3.0.25c also.
Jeremy.
(This used to be commit 24e625a615)
2007-10-10 12:28:46 -05:00
Stefan Metzmacher
63e93ad012 r23914: try to fix the build on Tru64
/usr/include/sys/acl.h:#define acl_type acl_common.entry_type
was the problem...

metze
(This used to be commit 8557b8b570)
2007-10-10 12:28:41 -05:00
Jeremy Allison
1ffa14ff92 r23913: Revert back to Volker's original logic to fix the
RAW-SFILEINFO-RENAME until I can figure out what
is different from the way CIFSFS drives this in
the cthon tests and the way smbtorture drives it.
Jeremy.
(This used to be commit 99f72dd9af)
2007-10-10 12:28:41 -05:00
Jeremy Allison
02730aa86c r23911: Revert r23910 to try and fix the build farm. I
need to look at this more closely tomorrow.
Stevef's cthon tests definately show we're not
matching Windows behaviour (as his tests pass
against Windows but not SAMBA_3_2) but this isn't
the fix.
Jeremy.
(This used to be commit 90bbc077e1)
2007-10-10 12:28:41 -05:00
Jeremy Allison
cfb7c04696 r23910: We used to deny renames on the
source open for non-delete open.
Turns out this is not the case.
VL please test but this matches
Windows behaviour. (I'll add a
torture test tomorrow).
Jeremy.
(This used to be commit 03e3d58746)
2007-10-10 12:28:41 -05:00
Jeremy Allison
5e3e15f754 r23909: Get closer to passing the cthon tests for delete open file.
It matters how the target is open.
Jeremy.
(This used to be commit 0989877fd1)
2007-10-10 12:28:40 -05:00
Jeremy Allison
b3d471d367 r23906: Fix POSIX unlink bug found by Steve. If we
used lstat during the open (which we always
do for POSIX) then use lstat for the unlink.
Jeremy.
(This used to be commit 4aad77c27c)
2007-10-10 12:28:40 -05:00
Volker Lendecke
f798837c23 r23904: Remove an unused variable reference
(This used to be commit 7f4ceb1bf0)
2007-10-10 12:28:40 -05:00
Volker Lendecke
5e8590753c r23903: Fix a potential reason for the segfault Steve found
(This used to be commit c06bc91085)
2007-10-10 12:28:40 -05:00
Jeremy Allison
b4366f6c37 r23902: Fix uninitialized read in devicetype noticed by Volker.
Jeremy
(This used to be commit 98c2393973)
2007-10-10 12:28:39 -05:00
Volker Lendecke
d537225c4c r23879: Fix two memleaks, found by the IBM checker
(This used to be commit 4d1b33f513)
2007-10-10 12:28:37 -05:00
Volker Lendecke
e84f8662e6 r23878: Fix an error return, found by the IBM checker
(This used to be commit a369c67f66)
2007-10-10 12:28:37 -05:00
Volker Lendecke
3912eebdc9 r23877: Fix two segfaults in (very unlikely) error paths, found by the IBM
checker.
(This used to be commit 33068885e6)
2007-10-10 12:28:37 -05:00
Volker Lendecke
ac51ffb77b r23866: Fix a 1-byte buffer overrun
(This used to be commit 2ed83d36fe)
2007-10-10 12:28:36 -05:00
Jeremy Allison
e8dc2ea03d r23858: Added srvstr_pull_buf_talloc() and srvstr_pull_talloc()
calls and converted reply_tcon and reply_tconX to use
them - to show the boilerplate usage (valgrind tested).
In conjunction with Volker's srvstr_get_path_talloc()
work this should allow us to start eliminating all
pstrings/fstrings out of the main path processing
code.
I'll watch the build farm tonight...
Jeremy.
(This used to be commit b4eff3f680)
2007-10-10 12:28:35 -05:00
Jeremy Allison
967b22827f r23855: Setting the allocation size updates the modified time
as a write does. Fix bug #4779.
Jeremy.
(This used to be commit ed0e2174a8)
2007-10-10 12:28:35 -05:00
Jeremy Allison
b114d3dc70 r23846: Belt-and-braces on the msdfs bug. Ensure ELOOP maps
correctly.
Jeremy.
(This used to be commit f2cf4b6b9d)
2007-10-10 12:28:34 -05:00
Jeremy Allison
f01698027d r23844: Add patch series from Volker (after review and consultation).
0001-Save-a-strdup-in-stat_cache_add.patch
0002-Use-ISDOT-and-ISDOTDOT.patch
0003-Move-fname_equal-around.patch
0004-unix_convert-pstring-dirpath-char.patch
0005-Ignore-.o-files.patch
0006-Get-rid-of-pstrings-inside-unix_convert.patch
0007-revert-pstring-unix_convert.patch
0008-Make-name-an-allocated-pstring-inside-unix_convert.patch
0009-Pass-explicit-pstring-to-mangle_check_cache.patch
0010-Don-t-overwrite-orig_path-unnecessarily.patch
0011-Defer-allocating-name.patch
0012-Make-sure-dirpath-is-always-correctly-allocated.patch
0013-Remove-one-pstring-dependency-in-unix_convert.patch
0014-Remove-more-name-pstring-dependencies.patch
0015-Hide-the-nasty-API-of-mangle_check_cache-in-mangle_c.patch
0016-name-does-not-need-to-be-pstring-size-anymore.patch
0017-Make-use-of-ISDOT-and-ISDOTDOT.patch
0018-Remove-pstring-from-stat_cache_lookup.patch
0019-Add-my-copyright.patch

To remove pstrings from statcache and unix_convert.

Jeremy.
(This used to be commit ea6ef36889)
2007-10-10 12:28:34 -05:00
Jeremy Allison
188b84f9d0 r23843: Fix bug #4777, reported by Bill Marshall <bmarsh@us.ibm.com>.
Doing a DFS traverse through a deep link could fail (not using
explorer).
Jeremy.
(This used to be commit cd93f0cb00)
2007-10-10 12:28:33 -05:00
Volker Lendecke
0ff8556f8b r23823: Memory leak fix from Atsushi Nakabayashi <nakabayashi@miraclelinux.com>
Thanks!

Volker
(This used to be commit 17b875ae5b)
2007-10-10 12:28:30 -05:00
Volker Lendecke
fa919f24f0 r23813: Remove unused global variable
(This used to be commit 3b811134c0)
2007-10-10 12:28:29 -05:00
Andrew Tridgell
153cfb9c83 r23801: The FSF has moved around a lot. This fixes their Mass Ave address.
(This used to be commit 87c91e4362)
2007-10-10 12:28:27 -05:00
Andrew Tridgell
ef591178d0 r23786: Use linux/dqblk_xfs.h rather than a private copy of this header in the
Samba3 tree.

This is neater, plus it avoids the need to get legal approval from SGI
to use their GPLv2-only code under GPLv3.

If/when SGI legal sort things out, we could consider adding back this
header for very old systems where linux/dqblk_xfs.h is not available.
(This used to be commit cb435543f8)
2007-10-10 12:28:24 -05:00
Andrew Tridgell
5e54558c6d r23784: use the GPLv3 boilerplate as recommended by the FSF and the license text
(This used to be commit b0132e94fc)
2007-10-10 12:28:22 -05:00
Andrew Tridgell
df2465298b r23783: Processing the UAS change message was causing problems on ppc64 Linux
systems. Rather than trying to fix this, it's much better just to
remove the code, as it serves no purpose at all (the message that is
generated is ignored by smbd).

This sort of parsing should really be done by PIDL generated code.
(This used to be commit 22e8404cef)
2007-10-10 12:28:21 -05:00
Jeremy Allison
d824b98f80 r23779: Change from v2 or later to v3 or later.
Jeremy.
(This used to be commit 407e6e695b)
2007-10-10 12:28:20 -05:00
Volker Lendecke
f850ba5787 r23773: One pstring a day...
(This used to be commit 0c3016d32b)
2007-10-10 12:23:55 -05:00
Volker Lendecke
5daa21f558 r23768: Get rid of the three global variables for the case semantics. I think
this is really not worth globals.

Jeremy, please check for 3.0.26.
(This used to be commit 6e655500c0)
2007-10-10 12:23:55 -05:00
Volker Lendecke
c13f62a675 r23765: Another error-path restore_case_semantics().
(This used to be commit a3e5fe1693)
2007-10-10 12:23:54 -05:00
Volker Lendecke
a3f69f3710 r23764: Do restore_case_semantics in an error path. Jeremy, please check!
(This used to be commit 3b5422c9a4)
2007-10-10 12:23:54 -05:00
Volker Lendecke
ead70dc92e r23761: Rename reduce_name to check_reduced_name
The function name reduce_name is misleading, making the user believe it
changes an argument.
(This used to be commit 68234f0bc6)
2007-10-10 12:23:53 -05:00
Jeremy Allison
59590a1c4d r23752: Fix bug introduced by checkin 22920, allow large
readX. Fix from Dmitry Shatrov <dhsatrov@linux.vnet.ibm.com>.

"In send_file_readX(), if startpos > sbuf.st_size, then smb_maxcnt is set
to an invalid large value due to integer overflow.
As for me, this resulted in MS Word hanging while trying to save
a 1.5Mb document."

This isn't in shipping code.

Jeremy.
(This used to be commit af715c602a)
2007-10-10 12:23:52 -05:00
Volker Lendecke
c35d814e39 r23743: Simplify stat_cache_lookup() logic. For the history of this, see
http://article.gmane.org/gmane.network.samba.internals/32486.
(This used to be commit e5e42fe3d5)
2007-10-10 12:23:51 -05:00
Volker Lendecke
0e43c1e80d r23738: Re-add commented out code snipped that got lost by accident
(This used to be commit c38c31afb7)
2007-10-10 12:23:50 -05:00
Jeremy Allison
d3965a2689 r23736: Use local variable of smb_flag2 instead of using the macro every time.
Jeremy.
(This used to be commit 9e1663b1f1)
2007-10-10 12:23:50 -05:00
Jeremy Allison
10c83ace04 r23735: Second part of the bugfix for #4763
This should coalesce identical adjacent notify records - making the "too large"
bug very rare indeed. Please test.
Jeremy.
(This used to be commit 1aaa1f5bbe)
2007-10-10 12:23:50 -05:00