1
0
mirror of https://github.com/samba-team/samba.git synced 2025-01-26 10:04:02 +03:00

3534 Commits

Author SHA1 Message Date
Volker Lendecke
944fe69d03 r24000: Add message_push_blob() and message_push_string().
The proposed new API convention is to start with a 0 bcc length and then
push things step by step. These routines reallocate the outbuf and
adjust the length and bcc fields as necessary.
(This used to be commit 624f1fe4f6e022d73e78fa8c9646f6f64035f3ee)
2007-10-10 12:28:54 -05:00
Volker Lendecke
9e40557047 r23999: Convert reply_open_and_X
This is an example of chained code that is executed in make test
(This used to be commit e3a10e9ffb06f429208f8b8e8482bbfd56dace91)
2007-10-10 12:28:54 -05:00
Volker Lendecke
47cdfc0413 r23998: Convert reply_close to the new API
(This used to be commit dbf74cb747d34dac571d85d6bae9398558086456)
2007-10-10 12:28:54 -05:00
Volker Lendecke
cc6a41017c r23997: Check in the infrastructure for getting rid of the global InBuffer/OutBuffer
The complete history of this patch can be found under
http://www.samba.org/~vlendec/inbuf-checkin/.

Jeremy, Jerry: If possible I would like to see this in 3.2.0. I'm only
checking into 3_2 at the moment, as it currently will slow down operations for
all non-converted (i.e. all at this moment) operations, as it will copy the
talloc'ed inbuf over the global InBuffer. It will need quite a bit of effort
to convert everything necessary for the normal operations an XP box does.

I have patches for negprot, session setup, tcon_and_X, open_and_X, close. More
to come, but I would appreciate some help here.

Volker
(This used to be commit 5594af2b208c860d3f4b453af6a649d9e4295d1c)
2007-10-10 12:28:53 -05:00
Volker Lendecke
041204d1a4 r23996: One more const
(This used to be commit a54fa551a4b9ffe3f29b339a54e563cdfe924959)
2007-10-10 12:28:53 -05:00
Volker Lendecke
530f6a927b r23992: Some const
(This used to be commit bc106cf50732ed6c169dcf593797501fcb3ae675)
2007-10-10 12:28:53 -05:00
Volker Lendecke
8579dd4ded r23990: Reformatting for 80 cols and trailing whitespace
(This used to be commit 0484de27d97306707ae0243443d18e9dec6d80f3)
2007-10-10 12:28:53 -05:00
Volker Lendecke
941db29ab4 r23988: Looks a lot more scary than it is: This just unwraps the else-branch of
if (smb_messages[type].fn == NULL) { into the function top-level. Makes
this function a bit easier to understand IMO.

Volker
(This used to be commit ada23b7f06acb00c36763a3e7a6f6e0caac86951)
2007-10-10 12:28:52 -05:00
Volker Lendecke
799c3ec8d4 r23987: Remove static pid in switch_message()
There's no point in duplicating functionality that exists in
sys_getpid() that also only used in a debug statement
(This used to be commit ebf1b1e97c709f5ffe48c85b4227a0af1f88b0ab)
2007-10-10 12:28:52 -05:00
Volker Lendecke
16443996b5 r23967: Memleak fix from Atsushi Nakabayashi <nakabayashi@miraclelinux.com>
Thanks!

Volker
(This used to be commit 46997a70199296d4ec45780f002898f23029bb26)
2007-10-10 12:28:50 -05:00
Jeremy Allison
e6c6c0438d r23942: Fix issue found by Shlomi Yaakobovich <Shlomi@exanet.com> where
invalid names sent as a resume name were incorrectly mapped into
. and .. Ensure they really *are . and ..
Jeremy.
(This used to be commit 78d0c5194fe42ad4f096657e2210a15541303a2a)
2007-10-10 12:28:47 -05:00
Jeremy Allison
921ac7da4f r23941: Don't use "False" when you mean "MARSHALL".
Jeremy.
(This used to be commit 57d4d5f2cd1ad7bae28f40478f4c2f9b6a475ce6)
2007-10-10 12:28:47 -05:00
Jeremy Allison
cf09627894 r23940: Added missing line that was deleted accidently.
Should fix the build.
Jeremy.
(This used to be commit b085366d5b982b635561f1d3211a6f3197258e6f)
2007-10-10 12:28:47 -05:00
Jeremy Allison
ed9e0d9a3a r23939: Fixes for notify returns. Returned param value must fix inside
max_param or return NT_STATUS_OK.
Jeremy.
(This used to be commit ab4af60d1ab4583fd27deb63b3f7baa1ede3473d)
2007-10-10 12:28:47 -05:00
Jeremy Allison
14826b0a79 r23935: We were lying to the client in the case of POSIX_UNLINK
if a Windows client had the file open. We were setting
delete on close and returning "ok". The POSIX client then
believed the file was gone (and it wasn't). Fix this to
return SHARING_VIOLATION if there is an existing NTcreateX
open on the file and someone calls POSIX_UNLINK. Still one
more Cthon test to fix but getting closer now. Should
be in 3.0.25c also.
Jeremy.
(This used to be commit 24e625a615447c025b73fed2d3db03c1f11ae596)
2007-10-10 12:28:46 -05:00
Stefan Metzmacher
63e93ad012 r23914: try to fix the build on Tru64
/usr/include/sys/acl.h:#define acl_type acl_common.entry_type
was the problem...

metze
(This used to be commit 8557b8b570ac8f8d3d14aaeb894c8b3532558736)
2007-10-10 12:28:41 -05:00
Jeremy Allison
1ffa14ff92 r23913: Revert back to Volker's original logic to fix the
RAW-SFILEINFO-RENAME until I can figure out what
is different from the way CIFSFS drives this in
the cthon tests and the way smbtorture drives it.
Jeremy.
(This used to be commit 99f72dd9af82921de4827b9b9d90d75127332295)
2007-10-10 12:28:41 -05:00
Jeremy Allison
02730aa86c r23911: Revert r23910 to try and fix the build farm. I
need to look at this more closely tomorrow.
Stevef's cthon tests definately show we're not
matching Windows behaviour (as his tests pass
against Windows but not SAMBA_3_2) but this isn't
the fix.
Jeremy.
(This used to be commit 90bbc077e15de0493dccda50be9bcdf6e2649137)
2007-10-10 12:28:41 -05:00
Jeremy Allison
cfb7c04696 r23910: We used to deny renames on the
source open for non-delete open.
Turns out this is not the case.
VL please test but this matches
Windows behaviour. (I'll add a
torture test tomorrow).
Jeremy.
(This used to be commit 03e3d587468ce66044814a8a58308b2fe9ab5499)
2007-10-10 12:28:41 -05:00
Jeremy Allison
5e3e15f754 r23909: Get closer to passing the cthon tests for delete open file.
It matters how the target is open.
Jeremy.
(This used to be commit 0989877fd191f7c9e195dc6e45dda5fd026f09dd)
2007-10-10 12:28:40 -05:00
Jeremy Allison
b3d471d367 r23906: Fix POSIX unlink bug found by Steve. If we
used lstat during the open (which we always
do for POSIX) then use lstat for the unlink.
Jeremy.
(This used to be commit 4aad77c27cc277e3d937f674ee620729411e3eaf)
2007-10-10 12:28:40 -05:00
Volker Lendecke
f798837c23 r23904: Remove an unused variable reference
(This used to be commit 7f4ceb1bf0c7aad50d93bb963c49dbc405e9524a)
2007-10-10 12:28:40 -05:00
Volker Lendecke
5e8590753c r23903: Fix a potential reason for the segfault Steve found
(This used to be commit c06bc91085c24bf6cc4491448ba12c5c2f1c7937)
2007-10-10 12:28:40 -05:00
Jeremy Allison
b4366f6c37 r23902: Fix uninitialized read in devicetype noticed by Volker.
Jeremy
(This used to be commit 98c23939731654440d2f008e44e11371eaddf014)
2007-10-10 12:28:39 -05:00
Volker Lendecke
d537225c4c r23879: Fix two memleaks, found by the IBM checker
(This used to be commit 4d1b33f51308c95293fa2494b47ba1255af8d216)
2007-10-10 12:28:37 -05:00
Volker Lendecke
e84f8662e6 r23878: Fix an error return, found by the IBM checker
(This used to be commit a369c67f6678bdcc0689929238bc96f45cdeeb25)
2007-10-10 12:28:37 -05:00
Volker Lendecke
3912eebdc9 r23877: Fix two segfaults in (very unlikely) error paths, found by the IBM
checker.
(This used to be commit 33068885e62f3681644c128e381822d48298ea05)
2007-10-10 12:28:37 -05:00
Volker Lendecke
ac51ffb77b r23866: Fix a 1-byte buffer overrun
(This used to be commit 2ed83d36fec918e6ad9605f43e1a49fa5b61f17b)
2007-10-10 12:28:36 -05:00
Jeremy Allison
e8dc2ea03d r23858: Added srvstr_pull_buf_talloc() and srvstr_pull_talloc()
calls and converted reply_tcon and reply_tconX to use
them - to show the boilerplate usage (valgrind tested).
In conjunction with Volker's srvstr_get_path_talloc()
work this should allow us to start eliminating all
pstrings/fstrings out of the main path processing
code.
I'll watch the build farm tonight...
Jeremy.
(This used to be commit b4eff3f68089f082781afcf90d43faa317949566)
2007-10-10 12:28:35 -05:00
Jeremy Allison
967b22827f r23855: Setting the allocation size updates the modified time
as a write does. Fix bug #4779.
Jeremy.
(This used to be commit ed0e2174a895b25ce2b4e8ffd912ad57b31dd2e9)
2007-10-10 12:28:35 -05:00
Jeremy Allison
b114d3dc70 r23846: Belt-and-braces on the msdfs bug. Ensure ELOOP maps
correctly.
Jeremy.
(This used to be commit f2cf4b6b9d1ce561fdf9f6815564d5b4f033dd10)
2007-10-10 12:28:34 -05:00
Jeremy Allison
f01698027d r23844: Add patch series from Volker (after review and consultation).
0001-Save-a-strdup-in-stat_cache_add.patch
0002-Use-ISDOT-and-ISDOTDOT.patch
0003-Move-fname_equal-around.patch
0004-unix_convert-pstring-dirpath-char.patch
0005-Ignore-.o-files.patch
0006-Get-rid-of-pstrings-inside-unix_convert.patch
0007-revert-pstring-unix_convert.patch
0008-Make-name-an-allocated-pstring-inside-unix_convert.patch
0009-Pass-explicit-pstring-to-mangle_check_cache.patch
0010-Don-t-overwrite-orig_path-unnecessarily.patch
0011-Defer-allocating-name.patch
0012-Make-sure-dirpath-is-always-correctly-allocated.patch
0013-Remove-one-pstring-dependency-in-unix_convert.patch
0014-Remove-more-name-pstring-dependencies.patch
0015-Hide-the-nasty-API-of-mangle_check_cache-in-mangle_c.patch
0016-name-does-not-need-to-be-pstring-size-anymore.patch
0017-Make-use-of-ISDOT-and-ISDOTDOT.patch
0018-Remove-pstring-from-stat_cache_lookup.patch
0019-Add-my-copyright.patch

To remove pstrings from statcache and unix_convert.

Jeremy.
(This used to be commit ea6ef368891af24164d2e76700c405a82b3dfc19)
2007-10-10 12:28:34 -05:00
Jeremy Allison
188b84f9d0 r23843: Fix bug #4777, reported by Bill Marshall <bmarsh@us.ibm.com>.
Doing a DFS traverse through a deep link could fail (not using
explorer).
Jeremy.
(This used to be commit cd93f0cb00207098014e41e0ba16210cb150b895)
2007-10-10 12:28:33 -05:00
Volker Lendecke
0ff8556f8b r23823: Memory leak fix from Atsushi Nakabayashi <nakabayashi@miraclelinux.com>
Thanks!

Volker
(This used to be commit 17b875ae5bab9473f0f896e63fff4a65588c2fb8)
2007-10-10 12:28:30 -05:00
Volker Lendecke
fa919f24f0 r23813: Remove unused global variable
(This used to be commit 3b811134c02ff9b24d3e36c1ff94b32946c6183c)
2007-10-10 12:28:29 -05:00
Andrew Tridgell
153cfb9c83 r23801: The FSF has moved around a lot. This fixes their Mass Ave address.
(This used to be commit 87c91e4362c51819032bfbebbb273c52e203b227)
2007-10-10 12:28:27 -05:00
Andrew Tridgell
ef591178d0 r23786: Use linux/dqblk_xfs.h rather than a private copy of this header in the
Samba3 tree.

This is neater, plus it avoids the need to get legal approval from SGI
to use their GPLv2-only code under GPLv3.

If/when SGI legal sort things out, we could consider adding back this
header for very old systems where linux/dqblk_xfs.h is not available.
(This used to be commit cb435543f84955be75368a3294bc6b627414d876)
2007-10-10 12:28:24 -05:00
Andrew Tridgell
5e54558c6d r23784: use the GPLv3 boilerplate as recommended by the FSF and the license text
(This used to be commit b0132e94fc5fef936aa766fb99a306b3628e9f07)
2007-10-10 12:28:22 -05:00
Andrew Tridgell
df2465298b r23783: Processing the UAS change message was causing problems on ppc64 Linux
systems. Rather than trying to fix this, it's much better just to
remove the code, as it serves no purpose at all (the message that is
generated is ignored by smbd).

This sort of parsing should really be done by PIDL generated code.
(This used to be commit 22e8404cef4961f7468a9f24e23024c827233b84)
2007-10-10 12:28:21 -05:00
Jeremy Allison
d824b98f80 r23779: Change from v2 or later to v3 or later.
Jeremy.
(This used to be commit 407e6e695b8366369b7c76af1ff76869b45347b3)
2007-10-10 12:28:20 -05:00
Volker Lendecke
f850ba5787 r23773: One pstring a day...
(This used to be commit 0c3016d32b5277b901788b13aa7d3f4b647728f2)
2007-10-10 12:23:55 -05:00
Volker Lendecke
5daa21f558 r23768: Get rid of the three global variables for the case semantics. I think
this is really not worth globals.

Jeremy, please check for 3.0.26.
(This used to be commit 6e655500c05f2584094329a95ad5791160147fd9)
2007-10-10 12:23:55 -05:00
Volker Lendecke
c13f62a675 r23765: Another error-path restore_case_semantics().
(This used to be commit a3e5fe1693a3e1830561d60254d6a3bfc0c30686)
2007-10-10 12:23:54 -05:00
Volker Lendecke
a3f69f3710 r23764: Do restore_case_semantics in an error path. Jeremy, please check!
(This used to be commit 3b5422c9a401321788d824c68da31a39d85aece1)
2007-10-10 12:23:54 -05:00
Volker Lendecke
ead70dc92e r23761: Rename reduce_name to check_reduced_name
The function name reduce_name is misleading, making the user believe it
changes an argument.
(This used to be commit 68234f0bc6fb4d6d99ae94ff067db118c60804aa)
2007-10-10 12:23:53 -05:00
Jeremy Allison
59590a1c4d r23752: Fix bug introduced by checkin 22920, allow large
readX. Fix from Dmitry Shatrov <dhsatrov@linux.vnet.ibm.com>.

"In send_file_readX(), if startpos > sbuf.st_size, then smb_maxcnt is set
to an invalid large value due to integer overflow.
As for me, this resulted in MS Word hanging while trying to save
a 1.5Mb document."

This isn't in shipping code.

Jeremy.
(This used to be commit af715c602a8ef6038e6272c7cc6a08501617ae67)
2007-10-10 12:23:52 -05:00
Volker Lendecke
c35d814e39 r23743: Simplify stat_cache_lookup() logic. For the history of this, see
http://article.gmane.org/gmane.network.samba.internals/32486.
(This used to be commit e5e42fe3d5b26c0ec48d98c001b9cb1623c0b5a7)
2007-10-10 12:23:51 -05:00
Volker Lendecke
0e43c1e80d r23738: Re-add commented out code snipped that got lost by accident
(This used to be commit c38c31afb770350e47713bf1025c23fd774607ab)
2007-10-10 12:23:50 -05:00
Jeremy Allison
d3965a2689 r23736: Use local variable of smb_flag2 instead of using the macro every time.
Jeremy.
(This used to be commit 9e1663b1f18d716a7f307bea2b09dadeef392ab8)
2007-10-10 12:23:50 -05:00
Jeremy Allison
10c83ace04 r23735: Second part of the bugfix for #4763
This should coalesce identical adjacent notify records - making the "too large"
bug very rare indeed. Please test.
Jeremy.
(This used to be commit 1aaa1f5bbe9222acbe3dea1daa1c6c5ce72e1c2c)
2007-10-10 12:23:50 -05:00