Matthieu Patou
0cdc39e730
Add a comment to tdb_wrap to explain why it should be used instead of directly using tdb
2010-01-21 07:11:18 +13:00
Wilco Baan Hofman
8067bf629c
Fix unintentional free of the last value when adding a new value to a key.
...
Signed-off-by: Jelmer Vernooij <jelmer@samba.org>
2010-01-20 09:59:18 +13:00
Jelmer Vernooij
aa1fce645a
ldap: Fix test failure that seemed to go unreported previously.
2010-01-17 12:35:26 +13:00
Jelmer Vernooij
a18889fd77
ldap.py: Remove unused imports.
2010-01-17 12:26:53 +13:00
Jelmer Vernooij
28577aae92
Import testtools as well, required for subunit.
2010-01-16 19:53:49 +13:00
Andrew Tridgell
a56ede9027
s4-ldb: cope with bad ptr alignment in ldb_index.c
...
We can't assume that a rec_ptr will come back from a tdb traverse with
alignment sufficient for a pointer.
2010-01-16 09:34:27 +11:00
Stefan Metzmacher
7d41afece7
s4:ldb/tests: do a "schemaUpdateNow" after creating a new attribute in ldap_schema.py
...
It seems that windows doesn't need that.
And we should think about a check for reloading the schema
at the start of each "write" operation.
metze
2010-01-13 16:03:52 +01:00
Stefan Metzmacher
ca9bc96b96
s4:ldb_msg: first try to decode integers as signed and then fallback to unsigned
...
LDAP only knowns about signed integers, so let
ldb_msg_find_attr_as_uint() and ldb_msg_find_attr_as_uint64() cope
with it.
metze
2010-01-13 14:52:00 +01:00
Stefan Metzmacher
8d4b913ce2
s4:ldb: be more strict in parsing ldb time strings
...
metze
2010-01-13 14:51:59 +01:00
Andrew Tridgell
a3e089db19
s4-ldb: display security descriptors with correct SDL for known SIDs
...
This makes it much easier to compare SDs
2010-01-10 13:23:38 +11:00
Andrew Tridgell
651ddb720a
s4-messaging: remove only usage of debug_ctx()
2010-01-09 10:15:13 +11:00
Andrew Tridgell
6a36799d30
s4-messaging: fixed a memory leak in messaging_path()
...
It is a bit convoluted to fix, as cluster_id_string() may return a
const string.
2010-01-09 10:15:12 +11:00
Andrew Tridgell
39a4e2a38d
s4-ldb: validate the type of the ldb argument to ldb_dn_new()
...
It has been a common bug to get the first two arguments the wrong way
around
2010-01-09 10:15:12 +11:00
Andrew Tridgell
66f161dee1
s4-acl: fixed acl.py test to use correct ldif
...
same problem as sec_descriptor.py
2010-01-08 13:03:07 +11:00
Andrew Tridgell
81c0b01585
s4-secdesc: fixed the sec_descriptor.py test
...
The test was using a "changetype: add" to try and add a member to a
group, where it should use a "changetype: modify" with a "add: member"
Also fixed the recovery when the test fails part way through (delete
the test users at the start as well as the end)
Nadya, please check!
2010-01-08 13:03:07 +11:00
Andrew Tridgell
fdf12a607d
s4-ldb: improve error handling in indexing code
...
When we get an indexing failure we want a clear error message
2010-01-08 13:03:03 +11:00
Andrew Tridgell
dcbba583d9
s4-event: added s4_event_context_set_default()
...
we're still not weaned off event_context_find()
2010-01-08 13:03:02 +11:00
Andrew Tridgell
805ab0ef15
s4-messaging: added a new msg type MSG_DREPL_ALLOCATE_RID
...
This will be used to ask the drepl task for a new RID pool
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
2010-01-08 13:03:01 +11:00
Andrew Tridgell
bd6d0e9379
s4-ldb: added nice ldif display of 64 bit ranges for RIDs
2010-01-08 13:02:58 +11:00
Matthias Dieter Wallnöfer
bbf9885013
s4:ldap_schema.py - add an additional check for validity of "defaultObjectCategory"
2010-01-05 20:55:45 +01:00
Matthias Dieter Wallnöfer
d8ca002a8c
s4:ldap_schema.py - Move generated attributes check
...
Make more clear that they're created before the "schemaUpdateNow".
2010-01-05 20:55:32 +01:00
Jeremy Allison
2a66db8f93
Fix the merged build. Probably not strictly correct but allows us to "make test".
...
Jeremy.
2010-01-04 13:27:48 -08:00
Jelmer Vernooij
a214ebc3d6
ldb: Fix the standalone ldb build.
2010-01-02 02:40:30 +01:00
Andrew Tridgell
00b39c70f5
s4-dsdb: switched to using RMD_FLAGS instead of DELETED in extended DNs
...
This allows for more flags in the future
2010-01-02 08:16:57 +11:00
Andrew Tridgell
335af02218
s4-ldb: fixed valgrind error: ares can be freed by callback
2010-01-02 08:16:56 +11:00
Andrew Tridgell
1c5a268f34
s4-ldaptest: need to use MessageElement for modify messages
...
Without MessageElement() the flags are not set, which is invalid
2010-01-02 08:16:56 +11:00
Andrew Tridgell
e410a91ff4
s4-ldb: show an error string, as well as error message
...
This makes it easier to track down error mismatches from the test
suite
2010-01-02 08:16:56 +11:00
Andrew Tridgell
98d94cca6f
s4-ldbtest: fixed message element in modify
...
a flags value of zero is not valid
2010-01-02 08:16:55 +11:00
Andrew Tridgell
81e8a18181
s4-ldb: allow modules to override error return values
...
The samldb module overrides the error code for some returns when
handling primaryGroupID. We need to take the error from the async
callback to allow this to work reliably
2010-01-02 08:16:55 +11:00
Andrew Tridgell
302dcd0226
s4-ldbmodify: show the error code as well as error string
2010-01-02 08:16:55 +11:00
Andrew Tridgell
1ab5020ef2
s4-ldb: declate ldb_val_to_time()
2010-01-02 08:16:55 +11:00
Andrew Tridgell
53e86ac5b2
s4-ldb: use safe length limited conversions for int64 and time
2010-01-02 08:16:55 +11:00
Andrew Tridgell
708ad42b0b
s4-dsdb: use safe length limiting in string->integer conversion
...
The ldap.py test suite could trigger a read past the end of the struct
ldb_val buffer
2010-01-02 08:16:55 +11:00
Andrew Tridgell
baae6ef9d2
s4-ldb: added ldb_val_to_time()
...
This is intended as a replacement for ldb_string_to_time() for ldb_val
inputs. This ensures it is length limited and includes additional
validity checks
2010-01-02 08:16:55 +11:00
Andrew Tridgell
36f8ece9de
s4-ldb: show the error code as well as errstr
...
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
2010-01-02 08:16:54 +11:00
Andrew Tridgell
e1ffcfc783
s4-ldb: added ldb_module_get_ops()
...
This is needed to support DSDB_FLAG_OWN_MODULE
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
2010-01-02 08:16:51 +11:00
Andrew Tridgell
b34db0840d
s4-ldb: use the RELAX control to disable single value checking on replace
...
When using w2k3 linked attributes we are allowed to have multiple
values on a single valued attribute. This happens when the other
values are deleted.
Setting the RELAX control tell the ldb-tdb backend to not check for
this on replace, which means the caller has to check for single valued
violations.
2010-01-02 08:16:51 +11:00
Andrew Tridgell
f1b6484232
s4-dsdb: split RMD_USN into RMD_LOCAL_USN and RMD_ORIGINATING_USN
...
We need a separate RMD_LOCAL_USN to allow us to tell what attributes
need to be sent in a getncchanges request. Thanks to Metze for
pointing this out.
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
2010-01-02 08:16:50 +11:00
Jelmer Vernooij
ea5af6e30c
pyldb: Add dom_sid.split in favor of less powerful dom_sid_to_rid().
...
Signed-off-by: Andrew Tridgell <tridge@samba.org>
2009-12-31 17:33:30 +11:00
Matthias Dieter Wallnöfer
1aed373b11
s4:lib/registry/util.c - Reintroduce "FIXME"s
...
Jelmer suggested to put them in again.
2009-12-30 12:39:55 +01:00
Stefan Metzmacher
d3ee0f021b
s4:lib/socket: add socket_get_{remote|local}_addr() to get a tsocket_address instead of a socket_address
...
metze
2009-12-24 17:38:33 +01:00
Stefan Metzmacher
445baf53a9
s4:lib/socket: add helpers functions to convert between socket_address and tsocket_address
...
metze
2009-12-24 17:38:32 +01:00
Simo Sorce
7e8b042b07
s4:ldb Fix declaration in the middle of the code
2009-12-23 10:33:26 -05:00
Simo Sorce
4cc0bb7d04
s4: Fix the build
2009-12-23 10:28:44 -05:00
Matthieu Patou
8dc636ad67
s4: tests controls parsing and using for ldbadd/ldbedit/ldbmodify
2009-12-23 08:09:19 -05:00
Matthieu Patou
3bd4f6792c
s4: make ldbadd/ldbmodify/ldbdelete really use the --controls switch
2009-12-23 08:09:19 -05:00
Andrew Bartlett
551ea65c96
Samba4 and LDB requires talloc 2.0.1
...
reported by ewoud@kohlvanwijngaarden.nl
2009-12-22 17:27:03 +11:00
Jelmer Vernooij
5b9e98a382
provision/pyldb: Avoid linking in static python ldb module.
2009-12-21 23:40:12 +01:00
Jelmer Vernooij
1d9a243d68
ldb_wrap: Fix compilation when using system ldb.
2009-12-21 23:40:12 +01:00
Kamen Mazdrashki
ee48f583b5
s4-tort: Tests for "msDS-IntId" attribute implemented
...
Signed-off-by: Andrew Tridgell <tridge@samba.org>
2009-12-21 23:44:13 +11:00