sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2024-12-25 23:21:54 +03:00
Code
62,869 Commits 60 Branches 1,144 Tags 452 MiB
ae02691200
Commit Graph

31958 Commits

Author SHA1 Message Date
Andrew Tridgell
6f895fedf3 s3-idl: auto-build IDL files in Samba3 2010-05-04 13:47:07 +02:00
Andrew Tridgell
5bff08d9a9 s3-idl: removed gen_ndr files from source3/ as well 2010-05-04 13:47:07 +02:00
Volker Lendecke
a7b06f4c0d s3: Fix a memleak in check_pac_checksum 2010-05-04 12:00:13 +02:00
Günther Deschner
4affc58c6a s3-lanman: before trying to call spoolss_ClosePrinter make sure we have a connection. 
Guenther
 2010-05-03 17:04:00 +02:00
Günther Deschner
9cc10e6a57 s3-rpcclient: Fix Bug #7277. rpcclient was sending invalid data, causing cupsaddsmb to fail. 
Guenther
 2010-05-03 16:30:13 +02:00
Günther Deschner
fe1617a818 s3-lanman: fix api_DosPrintQEnum(). 
This was a subtile bug where the OpenPrinter call (called directly via
dispatcher table) was modifiying r->in.printername in a way that all printers on
a server had the printername stripped off the server unc. Once we switch to full
NDR marshalling in inter RAP<->RPC server communication there is no danger
anymore to have these kind of nasty effects.

Guenther
 2010-05-03 14:45:26 +02:00
Günther Deschner
fe33db6c06 s3-lanman: exit early for unsupported levels in api_PrintJobInfo(). 
Guenther
 2010-05-03 14:43:34 +02:00
Matthew McGillis
6be5bc8e80 Consolidate all get SEC_DESC into single procedure get_secdesc 2010-05-03 08:07:03 +02:00
Matthew McGillis
0a8b2b2119 always pass filename as const char 2010-05-03 08:06:56 +02:00
Volker Lendecke
668e28b80e s3: Unify DEBUG_KRB5_TKT_REGAIN and DEBUG_KRB5_TKT_RENEWAL 
I don't think it makes sense to #ifdef this one case separately.

Metze, Bo Yang, please check!
 2010-05-02 15:16:14 +02:00
Volker Lendecke
ef0adbff93 s3: Fix a typo 2010-05-02 15:16:14 +02:00
Volker Lendecke
685b4625bc s3: Fix the code order in append_auth_data 
This is to comply with the comment

"currently, anything from here on potentially overwrites extra_data."

Günther, please check!
 2010-05-02 15:15:56 +02:00
Jeremy Allison
f4092ecec7 Plumb the SMB2 front end into the blocking lock backend. 
Metze, you'll probably be happier with this work as it
doesn't abuse tevent in the way you dislike. This is a
first cut at the code, which will need lots of testing
but I'm hoping this will give people an idea of where I'm
going with this.

Jeremy.
 2010-04-30 21:03:20 -07:00
Simo Sorce
dffeb12f3d smbd: move printfile_offset() within write_file() 2010-04-30 11:52:39 -07:00
Jeremy Allison
e90444319c Carefully label SMB1-specific locking calls. 
Jeremy.
 2010-04-29 17:08:12 -07:00
Jeremy Allison
ebf6340bb5 Move the global blocking lock records into the smb1 state. 
Jeremy
 2010-04-29 16:50:15 -07:00
Jeremy Allison
1f69a7a80e Attempt to fix bug #7399 - SMB2: QUERY_DIRECTORY is returning invalid values. 
Based on an initial patch from Ira Cooper <samba@ira.wakeful.net>.

Jeremy.
 2010-04-29 13:40:25 -07:00
Volker Lendecke
ca860e4279 s3: range-check idmap script output 
Not doing so results in the id mapping succeeding once unchecked and later on
being refused, because when reading from the tdb we do the checks.
 2010-04-29 14:33:08 +02:00
Volker Lendecke
fcdba1b36f s3: Fix an uninitialized variable in idmap_tdb2_sid_to_id() 
When we find an invalid record in the database, there's no point in checking
the non-existing value against the range limits.
 2010-04-29 14:33:08 +02:00
Volker Lendecke
81e75bacd3 s3: Fix some nonempty blank lines 2010-04-29 14:33:07 +02:00
Günther Deschner
9a313bbac0 s3-lanman: fix api_DosPrintQGetInfo(). 
Found by torture test.

Guenther
 2010-04-29 13:47:33 +02:00
Günther Deschner
f5ac746091 s3-pdb_ldap: fix memleak. 
Guenther
 2010-04-29 12:05:42 +02:00
Günther Deschner
7e678ef0cf s3-lanman: fix api_DosPrintQEnum. 
Found by torture test.

Guenther
 2010-04-29 12:05:42 +02:00
Jeremy Allison
4e7195be36 Update (C) for 2010. 
Jeremy.
 2010-04-28 14:56:12 -07:00
Günther Deschner
8878be3c45 s3-selftest: enable RAP-PRINTING against s3. 
Guenther
 2010-04-28 23:23:38 +02:00
Günther Deschner
d53544800f s3-lanman: support level 0 NetPrintQEnum RAP query. 
Guenther
 2010-04-28 23:23:38 +02:00
Jeremy Allison
ac09506d36 Connect set security descriptor into SMB2 code. 
Jeremy.
 2010-04-28 14:13:22 -07:00
Stefan Metzmacher
d5cc067367 s3:smbd: make fsp->fake_file_handle a talloc child of fsp 
metze
 2010-04-28 15:46:58 +02:00
Stefan Metzmacher
4783f84264 s3:smbd: add comment about returning STATUS_BUFFER_OVERFLOW in pipe_read_andx_done() 
metze
 2010-04-28 15:46:23 +02:00
Volker Lendecke
5197d76faa s3: Make a debug msg more readable 2010-04-28 10:55:50 +02:00
Jeremy Allison
c9a3661c4b Fix the "allow_smb2" bug being set to false that was driving me mad :-). 
The first packet from a rebooted Win7 on an SMB2 connection is an SMB1
negprot...

Jeremy.
 2010-04-27 22:15:17 -07:00
Jeremy Allison
4d1f0436bd Don't return a potentially uninitialized NT_STATUS. We can now see user lists in Windows ACLs. 
Jeremy.
 2010-04-27 17:09:40 -07:00
Jeremy Allison
33256e41e1 Add debug statements so I can track the flow of RPC data. 
Jeremy.
 2010-04-27 17:07:44 -07:00
Günther Deschner
f56d9006d5 s3-lanman: use spoolss for api_WPrintDestGetInfo() and api_WPrintDestEnum(). 
With this, I think, all implemented RAP printing calls are routed over SPOOLSS.
Torture tests to follow...

Guenther
 2010-04-28 01:27:40 +02:00
Günther Deschner
c88ff10d69 s3-lanman: fix debug message in api_WPrintJobEnumerate(). 
Guenther
 2010-04-28 01:27:40 +02:00
Günther Deschner
566ea59b27 s3-lanman: remove a unnecessary memset in api_WPrintJobEnumerate(). 
Guenther
 2010-04-28 01:27:40 +02:00
Günther Deschner
fe1f503a95 s3-lanman: remove unused code. 
Guenther
 2010-04-28 01:27:40 +02:00
Günther Deschner
f23bcb5c5e s3-lanman: use spoolss for api_DosPrintQGetInfo and api_DosPrintQEnum. 
Guenther
 2010-04-28 01:27:40 +02:00
Jeremy Allison
f11a5d196d Don't return an intermediate reply on async on a pipe call (Windows doesn't). 
Jeremy.
 2010-04-27 16:07:12 -07:00
Günther Deschner
f4f9d54721 s3-lanman: use spoolss for api_PrintJobInfo(). 
Guenther
 2010-04-28 00:10:41 +02:00
Günther Deschner
1691eb73da s3-spoolss: add support for SetJobInfo level 1 (for jobfile rename). 
Guenther
 2010-04-28 00:10:40 +02:00
Günther Deschner
2b7002f385 s3-lanman: remove unsupported print_job_set_place(). 
Guenther
 2010-04-28 00:10:40 +02:00
Jeremy Allison
ce8595f68e Fix more S3 build breakage. Matthias, please ensure S3 builds when 
changing common code.

Jeremy.
 2010-04-27 12:10:20 -07:00
Matthias Dieter Wallnöfer
079897709e s3:libads/ldap.c - fix a build breakage 2010-04-27 20:45:06 +02:00
Matthias Dieter Wallnöfer
eceffe6909 nbt: samlogon/netlogon structures - unify denominations 2010-04-27 18:45:41 +02:00
Günther Deschner
8f8e7c788a Revert "s3-build: Remove --enable-merged support." 
This reverts commit f8fc7fcbeb.

Was that pushed by coincidence ? merged build is really, really required over
here.
 2010-04-27 18:14:09 +02:00
Günther Deschner
7532640a74 s3-spoolss: publish "Monitor" in winreg for drivers. 
Found by torture test.

Guenther
 2010-04-27 17:56:48 +02:00
Günther Deschner
70ec7e0700 s3-spoolss: fix winreg attribute for storing datatype. 
Found by torture test (and checked with w2k, w2k3 and w2k8).

Guenther
 2010-04-27 17:56:47 +02:00
Günther Deschner
03a9ac4e2b s3-spoolss: fix some uninitialized variables. 
Guenther
 2010-04-27 17:55:55 +02:00
Stefan Metzmacher
b764145ac8 s3:smbd: keep local and remote tsocket_address per connection 
metze
 2010-04-27 17:22:31 +02:00
Günther Deschner
6864828d9d s3: use shared registry functions. 
Guenther
 2010-04-27 16:42:15 +02:00
Jeremy Allison
3f643f18d9 Correctly report share types (now Win7 makes RPC calls against us). 
Jeremy.
 2010-04-26 21:36:01 -07:00
Jeremy Allison
a94a4b788c Plumb in get_nt_acl into SMB2. 
Jeremy.
 2010-04-26 20:11:59 -07:00
Jelmer Vernooij
f8fc7fcbeb s3-build: Remove --enable-merged support. 2010-04-26 23:50:16 +02:00
Günther Deschner
232b9e556c s3: remove unused rap.h. 
Guenther
 2010-04-26 22:53:00 +02:00
Günther Deschner
dbfff90185 s3: fix some build warnings. 
Guenther
 2010-04-26 22:53:00 +02:00
Günther Deschner
7259762909 s3: use generated rap header. 
Guenther
 2010-04-26 22:52:59 +02:00
Jeremy Allison
1055b3c229 When walking the SMB2 requests queue, ensure the request is still "in flight" 
before examining the details.

SMB2 requests stay on the queue until their out.vector has been
send, only then are they talloc_free'd.

Thanks for Ira Cooper <ira@wakeful.net> for giving me the
backtrace showing this.

Jeremy.
 2010-04-26 12:29:03 -07:00
Jeremy Allison
6beba782f1 Fix crash when rescheduling oplock open. 
Jeremy.
 2010-04-26 10:54:33 -07:00
Volker Lendecke
abdb96b8ff s3: Implement "net rpc user setprimarygroup" 2010-04-26 17:10:31 +02:00
Volker Lendecke
fd3eeb3878 s3: async_domain_request is no longer used 2010-04-25 12:32:02 +02:00
Volker Lendecke
d53e3450c7 s3: Convert add_trusted_domains() to wb_domain_request_send() 2010-04-25 12:32:02 +02:00
Volker Lendecke
d41836fb62 s3: Simplify trustdom_state 
Don't store information explicitly as boolean flags that can be easily
retrieved from the domain when it's actually needed.
 2010-04-25 10:55:19 +02:00
Volker Lendecke
13cdaf9417 s3: Make "struct trustdom_state" its own talloc context 2010-04-25 10:55:19 +02:00
Volker Lendecke
dbb7db6c25 s3: sendto_domain() is lo longer used 2010-04-24 11:12:19 +02:00
Volker Lendecke
678a3c4e6d s3: Simplify (bool != True) to !bool 2010-04-24 10:50:12 +02:00
Jeremy Allison
a796542a93 Implement oplocks within SMB2. Plumb into the existing SMB1 oplock system. 
Seems to work but needs more tests (to be added).

Jeremy.
 2010-04-24 00:29:41 -07:00
Jeremy Allison
247273196f When sending the initial async response, this is never part of a chain. 
Get the reply flags correct.

Jeremy.
 2010-04-23 15:35:34 -07:00
Jeremy Allison
0e6f4ed703 Don't free the entire tevent_req on cancel, only the part we need (the immediate event). 
Jeremy.
 2010-04-23 15:34:58 -07:00
Volker Lendecke
7099a3c446 s3: Allow pdb password change using WINBINDD_PAM_CHNG_PSWD_AUTH_CRAP 2010-04-23 23:41:05 +02:00
Volker Lendecke
f43d1827f3 s3: init_dc_connection() can't init for internal domains 
This fixes a crash in winbindd_dual_pam_chng_pswd_auth_crap when given
global_sam_name() in the domain field
 2010-04-23 23:41:04 +02:00
Volker Lendecke
6eec46ec44 s3: replace some data_blob_talloc by data_blob_const 2010-04-23 23:41:04 +02:00
Volker Lendecke
f2f0fed8aa s3: Convert WINBINDD_PAM_CHNG_PSWD_AUTH_CRAP to the new async API 2010-04-23 23:41:04 +02:00
Simo Sorce
168b86c384 s3-smbd: group print relate data in own structure 2010-04-23 14:26:33 -07:00
Jeremy Allison
2bbb8c917e Allow smb2 create requests to be cancelled. 
Jeremy.
 2010-04-23 13:10:15 -07:00
Ira Cooper
dd20259471 Fix bug #7384 - dptr_Close has a bitmap leak. 
s3: Fix to dptr_Close

This fixes a bitmap "leak" in dptr_Close by making it use the same internal
routines the rest of the code does.
 2010-04-23 10:55:46 -07:00
Jeremy Allison
350f4e348c At simo's request return struct tevent_req *treq -> treq. For consistency :-(. 2010-04-23 10:53:44 -07:00
Jeremy Allison
2b13a8d650 Rename - no functional change. Stop all variables being called "req". 
tevent_req -> treq
struct smb_request -> smb1req
struct smbd_smb2_request -> smb2req

Jeremy.
 2010-04-23 10:29:48 -07:00
Andreas Schneider
251cd42ed5 s3-spoolss: Added a winreg_get_printer function. 
Signed-off-by: Günther Deschner <gd@samba.org>
 2010-04-23 16:33:07 +02:00
Andreas Schneider
e15d624c0a s3-spoolss: Added a winreg_create_printer function. 
Signed-off-by: Günther Deschner <gd@samba.org>
 2010-04-23 16:32:16 +02:00
Andreas Schneider
a61297647d s3-spoolss: Added a winreg_update_printer function. 
Signed-off-by: Günther Deschner <gd@samba.org>
 2010-04-23 16:31:04 +02:00
Simo Sorce
8cb79bf4cd s3-spoolss: Added a winreg_get_driver_list function. 
Signed-off-by: Günther Deschner <gd@samba.org>
 2010-04-23 16:30:57 +02:00
Simo Sorce
8db203a4a6 s3-spoolss: Added a winreg_del_driver function. 
Signed-off-by: Günther Deschner <gd@samba.org>
 2010-04-23 16:29:48 +02:00
Simo Sorce
16e0f80687 s3-spoolss: Added a winreg_get_driver function. 
Signed-off-by: Günther Deschner <gd@samba.org>
 2010-04-23 16:26:24 +02:00
Simo Sorce
a91f6f8b03 s3-spoolss: Added a winreg_add_driver function. 
Signed-off-by: Günther Deschner <gd@samba.org>
 2010-04-23 16:24:25 +02:00
Simo Sorce
8f56cdfaee s3-spoolss: Move info_ctr conversion to a public helper. 
Signed-off-by: Günther Deschner <gd@samba.org>
 2010-04-23 16:23:49 +02:00
Andreas Schneider
94a8482261 s3-spoolss: Fixed winreg_delete_printer_key if key is NULL or emtpy. 
Signed-off-by: Günther Deschner <gd@samba.org>
 2010-04-23 16:23:49 +02:00
Simo Sorce
96a04b067e s3-spoolss: Add date and version winreg helpers. 
Signed-off-by: Günther Deschner <gd@samba.org>
 2010-04-23 16:23:49 +02:00
Andreas Schneider
b33e877aad s3-spoolss: Added more winreg hepler functions. 
Signed-off-by: Günther Deschner <gd@samba.org>
 2010-04-23 16:23:48 +02:00
Simo Sorce
d4f563d9d4 s3-spoolss: Added winreg helper functions 
Signed-off-by: Günther Deschner <gd@samba.org>
 2010-04-23 16:23:48 +02:00
Andreas Schneider
0ed5e36c67 s3-spoolss: Added a winreg function to query a dword. 
Signed-off-by: Günther Deschner <gd@samba.org>
 2010-04-23 16:23:47 +02:00
Andreas Schneider
e7d6742821 s3-spoolss: Added a function to get the ChangeID from a printer. 
Signed-off-by: Günther Deschner <gd@samba.org>
 2010-04-23 16:23:40 +02:00
Andreas Schneider
b04a260e4e s3-spoolss: Added a function to update the ChangeID of a printer. 
Signed-off-by: Günther Deschner <gd@samba.org>
 2010-04-23 16:23:36 +02:00
Andreas Schneider
a18cd32a34 s3-spoolss: Added winreg helper functions to write registry values. 
Signed-off-by: Günther Deschner <gd@samba.org>
 2010-04-23 16:07:09 +02:00
Andreas Schneider
b320fad6e4 s3-spoolss: Fixed return values of winreg_printer_deleteform1. 
Signed-off-by: Günther Deschner <gd@samba.org>
 2010-04-23 16:07:04 +02:00
Andreas Schneider
012c1feda5 s3-spoolss: Added missing return value to winreg_printer_enumforms1 docs. 
Signed-off-by: Günther Deschner <gd@samba.org>
 2010-04-23 16:07:00 +02:00
Andreas Schneider
d65485b3c5 s3-spoolss: Use const values for notify functions. 
Signed-off-by: Günther Deschner <gd@samba.org>
 2010-04-23 16:06:51 +02:00
Andreas Schneider
3f1cc29814 s3-time: Added a function to get the startup time of the server. 
Signed-off-by: Günther Deschner <gd@samba.org>
 2010-04-23 16:06:42 +02:00
Günther Deschner
bb22855af5 s3-lanman: fix uninitialized variable in api_RDosPrintJobDel(). 
Guenther
 2010-04-23 15:31:21 +02:00
Günther Deschner
30b1e44382 s3-selftest: enable RPC-SPOOLSS-DRIVER against s3. 
Guenther
 2010-04-23 13:52:57 +02:00
Günther Deschner
14bb3f71aa s3-selftest: add print$ share with two arch dirs. 
(make test variant)

Guenther
 2010-04-23 13:51:33 +02:00
Günther Deschner
4b1dab5b11 s3-winbind: fix setup_domain_child() callers. 
Volker, please check.

Guenther
 2010-04-23 12:17:25 +02:00
Günther Deschner
698b7780c9 s3-spoolss: make switch in _spoolss_AddPrinterDriver() a bit more clear. 
Guenther
 2010-04-23 11:41:25 +02:00
Volker Lendecke
c82fd3ed30 s3: Fix a winbind crash when scanning trusts 
add_trusted_domain() for a new domain always needs to be followed by a
setup_domain_child(). This was not always done, in particular not when walking
to the forest root for additional trusts.

This is a minimal patch, we need to fix add_trusted_domain().
 2010-04-23 10:35:52 +02:00
Jeremy Allison
8f67f873ac Make deferred opens (NT_STATUS_SHARING_VIOLATION) work over SMB2. 
Makes SMB2Create call re-entrant internally.
Now this infrastructure is in place, oplocks will follow shortly.
Tested with Win7 client and with W2K8R2.

Jeremy.
 2010-04-22 23:52:19 -07:00
Volker Lendecke
9cd712d1bc s3: Fix a cut&paste error in a debug message in check_oem_password() 2010-04-23 07:07:04 +02:00
Günther Deschner
a14938377e s3-spoolss: make sure AddPrinterDriver calls into AddPrinterDriverEx. 
Not vice versa. Also disable some info levels in AddPrinterDriver according to
MS-RPRN 3.1.4.4.1.

Found by torture test.

Guenther
 2010-04-23 03:04:47 +02:00
Günther Deschner
413ffe9adb s3-spoolss: fix some crash bugs and missing error codes in AddDriver paths. 
Found by torture test.

Guenther
 2010-04-23 02:34:43 +02:00
Jim McDonough
61bdffbf8e Fix i18n of net conf import error message. 
Thanks gd
 2010-04-20 17:45:06 -04:00
Jim McDonough
a22f03e02c Display an error on net conf import failures. 
When something goes wrong, such as a typo in a parameter
name, we'll now display the failure instead of just returning
with -1 and no message.
 2010-04-20 16:28:47 -04:00
Günther Deschner
58549ab44a s3-spoolss: fix winreg spoolss helper call documentation. 
Guenther
 2010-04-20 10:57:36 +02:00
Günther Deschner
7e4eb13ba4 s3-spoolss: avoid passing down full "struct pipes_struct". 
Guenther
 2010-04-20 10:57:36 +02:00
Jeremy Allison
60d3692918 Now SMB2 error messages are correctly being returned with the 1 byte data area, smbd_smb2_request_error_ex() must call smbd_smb2_request_done_ex() in order to do the padding correctly on compound replies. 
Jeremy.
 2010-04-19 14:35:46 -07:00
Jeremy Allison
8bf7942fa4 Ensure vectors are always allocated with consistent size. Removes one byte alloc on SMB2 error packet. Always use talloc_zero_array on out vectors - fixes valgrind errors in tevent writes. 
Jeremy.
 2010-04-19 14:35:39 -07:00
Jeremy Allison
eacf5b235d Fix valgrind error where a strdup of name reads one byte beyond the end. Ensure buffer returned from inotify is null terminated. 
Jeremy.
 2010-04-19 14:35:33 -07:00
Jeremy Allison
cea24c4620 Remove an unused auto variable. 
Jeremy.
 2010-04-19 11:38:49 -07:00
Volker Lendecke
c293359daf s3: Remove a leftover of my lua experiments 2010-04-19 15:25:57 +02:00
Volker Lendecke
56b4aa3266 s3: Move the in-memory ccache to the parent 
None of this blocks, so there is no reason to keep this in
a winbind child process
 2010-04-19 14:27:24 +02:00
Volker Lendecke
e0d7a84242 s3: Test for wb ccache access by smbclient 2010-04-19 14:27:24 +02:00
Volker Lendecke
5aa88782ce libwbclient: remove async libwbclient and talloc from libwbclient.so 
Except for tests there is right now no active user of this. We can easily
re-add this when smbd makes more use of it.
 2010-04-19 14:27:24 +02:00
Volker Lendecke
460e2d5dad s3: Change the make test password to "testPw" 
This way we can change back to it when testing testing wbcChangeUserPassword,
"test" is too short (<5 chars)
 2010-04-19 14:27:20 +02:00
Volker Lendecke
9d0629d155 s3-winbind: Allow changing the password for pdb 2010-04-19 14:27:20 +02:00
Volker Lendecke
45eeed2893 s3: Convert WINBINDD_PAM_LOGOFF to the new async API 2010-04-19 14:27:20 +02:00
Volker Lendecke
518a4f5423 s3: Convert WINBINDD_PAM_CHAUTHTOK to the new async API 2010-04-19 14:27:20 +02:00
Volker Lendecke
d869e7a0d8 s3: Convert WINBINDD_PAM_AUTH_CRAP to the new async API 2010-04-19 14:27:19 +02:00
Volker Lendecke
61ec0f571a s3: Convert WINBINDD_PAM_AUTH to the new async API 2010-04-19 14:27:19 +02:00
Volker Lendecke
cafba3d7a7 winbindd: Fill in num_entries where available 
The server implementation of WINBINDD_LIST_USERS, WINBINDD_LIST_GROUPS and
WINBINDD_LIST_TRUSTDOM knows the number of entries returned.

Bump up the version number so that a newer lib does not rely on something an
older winbind does not do.
 2010-04-19 14:27:18 +02:00
Volker Lendecke
fec712aca5 s3: Add some debug to GETSIDALIASES 2010-04-19 14:27:18 +02:00
Günther Deschner
0b2e5debb0 s3-smb2: fix some c++ warnings. 
Guenther
 2010-04-19 11:54:00 +02:00
Günther Deschner
7b84d36f19 s3-spoolss: fix samr_ValidatePassword_Change. 
Guenther
 2010-04-19 11:53:59 +02:00
Günther Deschner
2033314a7c s3-lanman: use spoolss for api_WPrintJobGetInfo(). 
Guenther
 2010-04-19 11:53:55 +02:00
Günther Deschner
0c80d12656 s3-lanman: use spoolss for api_WPrintJobEnumerate(). 
Guenther
 2010-04-19 11:23:44 +02:00
Kai Blin
8208f8e5e5 s3 i18n: Fix up missing newlines in more pam_winbind translations 2010-04-19 09:27:50 +02:00
Kai Blin
e56dc83162 s3 i18n: Fix up missing newlines in pam_winbind translations 
At least in the languages I could read, the newlines were indeed
missing.
 2010-04-19 09:04:37 +02:00
Jeremy Allison
59fa1e1890 Final fix for #7331 - Compound async SMB 2 requests don't work right. 
Don't free the cancelled SMB2 req early, let the cancelation
function take care of it. Return a NT_STATUS_CANCELLED when
we find and cancel a request. Fix our SMB2 error returns to
correctly set the structuresize to 9, and add the expected
zero byte (see section 2.2.2 in the SMB2 spec.).

This causes Samba to pass the test program in this bug report
that W2K8R2 fails (heh heh :-). This is because we always cause
compound requests to get to a cancelation point before dealing
with a cancel request.

Jeremy.
 2010-04-18 20:23:54 -07:00
Volker Lendecke
058d4a21af s3: Fix indentation in remove_ccache 2010-04-18 15:25:03 +02:00
Volker Lendecke
0264c0c337 s3: Fix a memleak in discover_dc_netbios 2010-04-18 15:25:03 +02:00
Volker Lendecke
36e57fa728 s3: Fix a typo in winbindd_ccache_save 2010-04-18 15:25:03 +02:00
Ira Cooper
e1ca451794 s3: Improved support for GAMIN. 
Support the FAMNoExists API for gamin to reduce cpu use and problems when
using GAMIN as FAM for vfs_notify_fam.
 2010-04-18 15:12:41 +02:00
Jeremy Allison
1aa80f5788 Second part of fix for bug #7331 - Compound async SMB 2 requests don't work right. 
Cause us to match W2K8R2 by sending an interim compound reply
followed by a async reply.

Jeremy.
 2010-04-17 22:42:23 -07:00
Jeremy Allison
bf45b4f4fd First part of fix for bug #7331 - Compound async SMB 2 requests don't work right. 
Gets us handling SMB2 compound async requests similar to W2K8R2
(and triggers the same client bug in the Win7 redirector). Great
thanks to Ira Cooper <samba@ira.wakeful.net> for helping with
this and to Metze for the wonderful async framework. The one
thing I need to fix to make us identical to W2K8R2 is that
when a compound request goes async at the end W2K8R2 splits
the replies up into a compound non-async reply followed by
a separate async reply. Currently we're doing the whole thing
in a compound reply.

Jeremy.
 2010-04-17 21:20:17 -07:00
Volker Lendecke
f4b73f4e24 s3: Slightly simpify samr_ValidatePassword_Reset 2010-04-17 12:01:18 +02:00
Volker Lendecke
3a362b45c6 s3: Slightly simpify samr_ValidatePassword_Change 2010-04-17 12:01:18 +02:00
Volker Lendecke
6f998b4b9a s3: Slightly simplify the logic of check_password_complexity() 
The whole routine was just one if-branch. Do an early return instead.
 2010-04-17 12:01:18 +02:00
Volker Lendecke
b0b077f27c s3: Fix some nonempty blank lines 2010-04-17 12:01:18 +02:00
Andreas Schneider
4567bf9df5 s3-winreg_nt: Fixed QueryValue with data=NULL to get the length. 2010-04-16 15:17:59 +02:00
Volker Lendecke
8693ae741c s3: Fix a typo 2010-04-14 21:50:00 +02:00
Jeremy Allison
74c4c7fe4f Don't set "requested_posix_capabilities" in the sync code, already done in the async. 
Jeremy.
 2010-04-13 19:12:43 -07:00
Jeremy Allison
a1e0e1cbcf Add basic DFS tests. 
Jeremy.
 2010-04-13 18:42:24 -07:00
Jeremy Allison
f3b8e31f83 Split out the client unix capabilities to those the server offered, and those the client asked for. 
This fixes a bug when using encrypted transport and DFS links. Found
by my basic DFS torture test, which I'll check in next. Testing *rocks* :-).

Jeremy.
 2010-04-13 18:41:14 -07:00
Volker Lendecke
577bceb19b s3-winbind: Authenticate SAM users 2010-04-13 21:21:34 +02:00
Karolin Seeger
b0a9e5ba77 s3-winbindd: Fix typo in comment. 
Karolin
 2010-04-13 20:08:22 +02:00
Volker Lendecke
5fc2801c09 s3: Cache the username map in gencache 
This is for uses with a heavy-weight username map script
 2010-04-13 09:30:06 +02:00
Jeremy Allison
7984243768 Move to using 64-bit mid values in our internal open file database. 
This will allow us to share logic much easier between SMB1 and SMB2
servers.

Jeremy
 2010-04-12 21:40:28 -07:00
Volker Lendecke
b1a27e81d7 s3: Apply some const 2010-04-12 21:42:54 +02:00
Matthias Dieter Wallnöfer
1a27343366 s3/s4:netlogon IDL - fix up "struct netr_SamInfo6" regarding the "forest" attribute 
According to MS-NRPC 2.2.1.4.13 this should be the DNS domainname, not the
forest one.
 2010-04-12 18:49:01 +02:00
Volker Lendecke
d73a7e7e90 s3: Little refactoring: Factor out skip_space 2010-04-12 13:18:18 +02:00
Volker Lendecke
8c3fa16686 s3: Remove a bogus 0-check, "isspace" can not return true for \0 2010-04-12 13:18:17 +02:00
Volker Lendecke
757766d5af s3: Cache the result of the username map script 2010-04-12 13:09:08 +02:00
Volker Lendecke
8e95db9eea s3: Move serverinfo_to_SamInfoX to auth/server_info.c 2010-04-11 22:59:47 +02:00
Volker Lendecke
b8829e74fd s3: Move [make|free]_user_info to auth/user_info.c 2010-04-11 22:59:47 +02:00
Volker Lendecke
18909879cc s3: Move make_server_info_sam to auth/server_info_sam.c 2010-04-11 22:59:47 +02:00
Volker Lendecke
2b1a50c2e5 s3: Move sanitize_username to lib/util_str.c 2010-04-11 22:59:47 +02:00
Volker Lendecke
80708b75f8 s3: Move make_server_info to auth/server_info.c 2010-04-11 22:59:46 +02:00
Volker Lendecke
5792ccc7c8 s3: Move check_sam_security to auth/check_sam.c 2010-04-11 22:59:46 +02:00
Volker Lendecke
04f9e33de1 s3: Make check_sam_security public 2010-04-11 22:59:46 +02:00
Volker Lendecke
a0c175eca9 s3: Replace "auth_context" by "challenge" in need_to_increment_bad_pw_count args 2010-04-11 22:59:45 +02:00
Volker Lendecke
19c0086553 s3: Replace "auth_context" by "challenge" in sam_password_ok args 2010-04-11 22:59:45 +02:00
Volker Lendecke
7ba21a339c s3: Move user_in_group() and create_token_from_username() to token_utils.c 
Goal is to be able to call check_sam_security from winbind
 2010-04-11 22:59:45 +02:00
Derrell Lipman
0ee1985b05 [Bug 7345] Incomplete description of function return values in libsmbclient.h 
- Fixed documentation on smbc_fstat(), smbc_statvfs(), and smbc_fstatvfs():
  All were missing return value upon success

- Fixed documentation on smbc_read:
  Documented return value upon EOF

Derrell
 2010-04-11 11:37:00 -04:00
Volker Lendecke
59d68899c4 s3: Use sizeof(chal) instead of a constant 2010-04-11 15:28:39 +02:00
Volker Lendecke
b0d65f827e s3: Use talloc_stackframe() in user_in_group 2010-04-11 13:53:21 +02:00
Volker Lendecke
9655f63642 s3: Use talloc_stackframe() in user_in_group_sid 2010-04-11 13:53:21 +02:00
Volker Lendecke
9cf448a30e s3: Use talloc_stackframe() in create_token_from_username 2010-04-11 13:53:21 +02:00
Volker Lendecke
3c169c0475 s3: Fix a memleak in user_in_group_sid 2010-04-11 13:53:20 +02:00
Volker Lendecke
a2d1e5e0f7 s3: Remove the make_auth_methods routine 
This was just TALLOC_ZERO_P
 2010-04-11 13:53:19 +02:00
Volker Lendecke
bc619586f2 s3: Fix a typo 2010-04-11 13:53:19 +02:00
Volker Lendecke
c5c40f2648 s3: Make "auth_context" its own talloc parent 
Remove "mem_ctx" from "struct auth_context"
 2010-04-11 13:53:19 +02:00
Volker Lendecke
e35a2f89b2 s3: Fix some nonempty lines 2010-04-11 13:53:18 +02:00
Volker Lendecke
b91484a1a0 s3: Cosmetics -- I could not spot where "chal" was initialized 2010-04-11 11:15:44 +02:00
Volker Lendecke
18078ec445 s3: Use IS_DC macro in get_global_sam_name() 
Much as I dislike macros, this one is there. So why not use it...
 2010-04-10 22:55:06 +02:00
Volker Lendecke
f73e480e19 s3: Remove domain selection from dual_pam_auth 
We're in a child, the parent already has chosen the domain by
picking the right child to connect to.

Metze, you've done work on winbind lately, so it goes to you:

Please check :-)
 2010-04-10 22:42:25 +02:00
Volker Lendecke
4085e189a1 s3: Check 0 termination in GETALIASES 2010-04-10 17:05:38 +02:00
Jeremy Allison
e15939b456 Plumb SMB2 stubs into all the places we defer SMB1 operations. 
Rename functions to be internally consistent. Next step is
to cope queueing single (non-compounded) SMB2 requests to
put some code inside the stubs.

Jeremy.
 2010-04-09 19:26:34 -07:00
Günther Deschner
357006bf07 s3-spoolss: Fix two uninitialized vars in spoolss util code. 
Guenther
 2010-04-09 18:44:19 +02:00
Günther Deschner
63b111bd32 s3: add iconv_convenience handle to pull/push sz helpers. 
Guenther
 2010-04-09 18:33:45 +02:00
Volker Lendecke
bfeab64ebf s3: Fix a typo 2010-04-09 16:49:49 +02:00
Volker Lendecke
c666b8af96 s3: Use talloc_tos() as talloc ctx for fd_lines_load() in map_username() 2010-04-09 14:09:23 +02:00
Volker Lendecke
d3e9e83d7e s3: TALLOC_FREE(command) correctly in map_username() 2010-04-09 14:08:00 +02:00
Jeremy Allison
08b24e923d Stop smb2 from calling into smb1 blocking lock request code. 
Allocate a uint16_t internal SMB1 mid for an SMB2 request.
Add a back pointer from the faked up smb_request struct
to the smb2 request.

Getting ready to add restart code for blocking locks,
share mode violations and oplocks in SMB2.

Jeremy.
 2010-04-08 22:15:55 -07:00
Jeremy Allison
3491f6d119 Simplify call_trans2qfilepathinfo() and smbd_do_qfilepathinfo() 
Remove the bool ms_dfs_link parameter from smbd_do_qfilepathinfo.
It is not possible for this to be a DFS link. Remove the check_msdfs_link()
call from call_trans2qfilepathinfo() - the call to filename_convert()
above with a ucf_flags of zero *MUST* catch a DFS link and return
NT_STATUS_PATH_NOT_COVERED in this case, so the code below checking
for msdfs links is redundent. Don't add this to 3.5.x, as it's an
optimization but not needed to fix bug #7339 - MSDFS is non-functional in 3.5.x.

Jeremy.
 2010-04-08 21:24:23 -07:00
Jeremy Allison
3587815595 Fix bug #7339 - MSDFS is non-functional in 3.5.x 
In the refactoring around filename_convert, the split between the functions
resolve_dfspath() and resolve_dfspath_wcard() was lost, leaving us only with
resolve_dfspath_wcard().

Internally resolve_dfspath_wcard() calls dfs_redirect() only with a
"allow_wcards" flag of true, wheras the old resolve_dfspath() would call with a
value of false. The loss of this case causes dfs_redirect to always masquerade
DFS links as directories, even when they are being queried directly by a trans2
QPATHINFO call. We should only masquerade DFS links as directories when called
from a SMBsearch or trans2 findfirst/findnext - which was the intent of the
"allow_wcards" flag.

This patch adds back an allow_wcards bool parameter to
resolve_dfspath_wcard(). This bool is set from the state of the ucf_flags when
filename_convert() is called.

I will follow this up with a new smbclient-based torture test that will prevent
us from ever regressing our DFS support again.

Jeremy.
 2010-04-08 20:32:36 -07:00
Günther Deschner
ffcaa73280 s3-winreg: add winreg_DeleteKeyEx stub. 
Guenther
 2010-04-09 00:27:58 +02:00
Günther Deschner
8d588e96d9 s3-lanman: use spoolss for api_RDosPrintJobDel(). 
Guenther
 2010-04-08 16:24:33 +02:00
Günther Deschner
d5e2b43176 s3-lanman: use spoolss for api_WPrintQueueCtrl(). 
Guenther
 2010-04-08 16:24:25 +02:00
Günther Deschner
84f3eeeca3 s3-registry: fix fill_in_printer_values() for datatype and printprocessor. 
It is wise and good to enforce RAW and winprint, but we need to be consistent
with spoolss (and enforce it there).

Found by torture test.

Guenther
 2010-04-08 16:21:40 +02:00
Volker Lendecke
3d5732fc13 s3: Remove the separate "child" argument from setup_domain_child() 2010-04-08 15:12:42 +02:00
Stefan Metzmacher
eb9b7d0363 s3:winbindd: make "smbcontrol winbindd validate-cache" reliable again 
commit 73577205cf
(s3:winbindd: fix problems with SIGCHLD handling (bug #7317))
broke this.

metze
 2010-04-08 12:48:32 +02:00
Volker Lendecke
ca74246b4b s3: Fix a typo 2010-04-08 10:49:57 +02:00
Jeremy Allison
3413cf7a6b Start to plumb smb2 into the oplock system. Calls dummy functions for now. 
Jeremy.
 2010-04-07 19:00:44 -07:00