Jeremy Allison
d5b6dedfdd
r16365: Fix Klocwork #895 , #898 , #899 , #915 , #932 , #938 and a
...
few other problems Klocwork missed.
Jeremy.
(This used to be commit fe05769a1a
)
2007-10-10 11:18:49 -05:00
Volker Lendecke
3d672717e0
r16363: Fix Klocwork ID 981 1652
...
Volker
(This used to be commit ce1d8423ef
)
2007-10-10 11:18:49 -05:00
Volker Lendecke
a70bbb921a
r16362: That's the best way to fix a Klocwork bug: Remove the (unused...;-) code
...
altogether. This was essentially a second implementation if string_to_sid.
Klocwork ID 1038
Volker
(This used to be commit e35f901067
)
2007-10-10 11:18:49 -05:00
Volker Lendecke
dfa4760eea
r16361: Fix Klocwork ID 1731 1770 1771 1775 1796
...
Volker
(This used to be commit 8a5cebc19e
)
2007-10-10 11:18:49 -05:00
Volker Lendecke
e7fc37cf0f
r16360: Fix Klocwork ID 136 520 521 522 523 542 574 575 576 607
...
in net_rpc.c: 715 716 732 734 735 736 737 738 739 749
in net_rpc_audit.c: 754 755 756
in net_rpc_join.c: 757
in net_rpc_registry: 766 767
in net_rpc_samsync.c: 771 773
in net_sam.c: 797 798
Volker
(This used to be commit 3df0bf7d60
)
2007-10-10 11:18:48 -05:00
Jeremy Allison
5c822ecc49
r16358: ALWAYS compile this stuff on a 64-bit box before
...
checking in. size_t != uint32 on a 64-bit machine.
Jeremy.
(This used to be commit 09c8973286
)
2007-10-10 11:18:48 -05:00
Jeremy Allison
f40e9fcc5b
r16356: Helping derrell out. Jeremy.
...
Only set the DFS capability flag if the share is a DFS root. Fixes bug 3814.
(This used to be commit 6193f11708
)
2007-10-10 11:18:48 -05:00
Günther Deschner
17cbb65317
r16350: Fix the build.
...
GUenther
(This used to be commit 3203ce3b49
)
2007-10-10 11:17:37 -05:00
Günther Deschner
c6a47bb4f3
r16349: Another fix to make winbind more robust in large domains:
...
We may only feed rpc_useraliases with chunks of 1024 entries. This is
important as the token generation otherwise fails when a user is member
of more then 1024 groups.
Volker, please check.
Guenther
(This used to be commit d8fd94648f
)
2007-10-10 11:17:37 -05:00
Günther Deschner
c53262d677
r16346: Allow to exit a "net rpc shell" with 'quit' or 'exit'.
...
Guenther
(This used to be commit 232566e1cb
)
2007-10-10 11:17:37 -05:00
Günther Deschner
bf9b5b9baf
r16345: Improve the chance that our users can discover one of the coolest 'net'
...
features.
Guenther
(This used to be commit 446d79a000
)
2007-10-10 11:17:37 -05:00
Günther Deschner
c893dfa500
r16344: Allow to set passwords directly when creating users via "net rpc user
...
add" (as the documentation says, and currently onle "net ads user add"
did). Fixes #3843 .
Guenther
(This used to be commit 5d776d5fab
)
2007-10-10 11:17:36 -05:00
Volker Lendecke
0f14e3eb8d
r16340: Commit Bjoern's fix for the AIX PIC suffix. 'make test' still does the first
...
tests, and vfstest is still able to load modules. Looks like this is ok :-)
Volker
(This used to be commit c08bfdf87a
)
2007-10-10 11:17:36 -05:00
Volker Lendecke
8961048d24
r16339: Fix Klocwork ID
...
277 278 (cmd_*)
485 487 488 (ldap.c)
Volker
(This used to be commit 5b1eba76b3
)
2007-10-10 11:17:36 -05:00
Volker Lendecke
ec49dff326
r16338: Fix Klocwork ID 150
...
(This used to be commit ded2952e00
)
2007-10-10 11:17:36 -05:00
Volker Lendecke
9cee5574e9
r16337: Add configure fixes by Bjoern Jacke <samba@j3e.de>.
...
Volker
(This used to be commit 1b3a24732d
)
2007-10-10 11:17:36 -05:00
Volker Lendecke
8ceeef3266
r16336: Fix Klocwork ID's 1087, 1095, 1096, 1098, 1099, 1101, 1102, 1105, 1107, 1109,
...
1111
Volker
(This used to be commit def075baf8
)
2007-10-10 11:17:35 -05:00
Volker Lendecke
ee4ee4c541
r16335: Fix Klocwork IDs 107 108 109 111 112 113 114 116 117 118 121
...
(This used to be commit 555984ea77
)
2007-10-10 11:17:34 -05:00
Volker Lendecke
e279878b28
r16334: Fix Klocwork ID's 1087, 1095, 1096, 1098, 1099, 1101, 1102, 1105, 1107, 1109,
...
1111
Volker
(This used to be commit d3f5acb16e
)
2007-10-10 11:17:34 -05:00
Jeremy Allison
86a13b97e4
r16326: Klocwork #509 . Always check return allocs.
...
Jeremy.
(This used to be commit 7e397b534a
)
2007-10-10 11:17:33 -05:00
Jeremy Allison
d730df0493
r16324: Klocwork #499 . Allways check results from alloc.
...
Jeremy.
(This used to be commit 2b69d436da
)
2007-10-10 11:17:33 -05:00
Jeremy Allison
be6fd76436
r16322: Klocwork #481., Don't deref null on malloc fail.
...
Jeremy.
(This used to be commit dd31f3fc0e
)
2007-10-10 11:17:33 -05:00
Jeremy Allison
61c96308fb
r16320: Ensure variable is not null before calling fclose.
...
Klocwork #412 .
Jeremy.
(This used to be commit fed55d653a
)
2007-10-10 11:17:33 -05:00
Jeremy Allison
52d6b8339a
r16317: Klocwork #300 . Check for error return on malloc.
...
Jeremy.
(This used to be commit aa0d739834
)
2007-10-10 11:17:33 -05:00
Jeremy Allison
4433376361
r16313: Not a problem - but ensure Klocwork is quiet ( #872 ).
...
Jeremy.
(This used to be commit 22a345deed
)
2007-10-10 11:17:33 -05:00
Jeremy Allison
b85b18d794
r16311: Check for NULL return. Klocwork #998 .
...
Jeremy.
(This used to be commit c430730f5a
)
2007-10-10 11:17:33 -05:00
Jeremy Allison
17621ea080
r16309: Fix Klocwork #1596 . Check for NULL on talloc.
...
Jeremy.
(This used to be commit 34b6b6723b
)
2007-10-10 11:17:32 -05:00
Jeremy Allison
a90026e7a6
r16307: Make sure we know we must pass a valid pointer here.
...
Klocwork #1129 .
Jeremy.
(This used to be commit e8d86362ba
)
2007-10-10 11:17:32 -05:00
Jeremy Allison
3a8bf11ae3
r16306: Error handling in this asn1 code *sucks*. Fix a generic
...
class of memory leak bugs on error found by Klocwork (#123 ).
Many of these functions didn't free allocated memory on
error exit.
Jeremy.
(This used to be commit 8ef11a7c6d
)
2007-10-10 11:17:32 -05:00
Volker Lendecke
eb41bfb91b
r16301: Fix a memleak
...
(This used to be commit 21aaede518
)
2007-10-10 11:17:32 -05:00
Jeremy Allison
4ba1a36d4c
r16299: Fix another "dereferencing type-punned pointer will break
...
strict-aliasing rules" gcc4 warning.
Jeremy.
(This used to be commit ee77dde9b6
)
2007-10-10 11:17:32 -05:00
Jeremy Allison
0a5b892aee
r16298: On request of jiri sasek - Sun Microsystems - Prague Czech Republic <Jiri.Sasek@Sun.COM>
...
change priv_op and priv_info to names that don't
conflict with the solaris namespace.
Jeremy.
(This used to be commit db5b4e3f13
)
2007-10-10 11:17:32 -05:00
Jeremy Allison
4b6fef6b6a
r16295: Fix gcc4 "warning: dereferencing type-punned pointer will break
...
strict-aliasing rules" warning.
Jeremy.
(This used to be commit 7ac5aee88c
)
2007-10-10 11:17:32 -05:00
Lars Müller
4f3e19950d
r16294: Fix syntax error.
...
Credits to Andreas Schwab from SUSE Linux for this fix.
(This used to be commit da4c5c3b75
)
2007-10-10 11:17:31 -05:00
Volker Lendecke
366a2d498d
r16290: Fix Coverity bugs 298 and 298
...
(This used to be commit b96808bb62
)
2007-10-10 11:17:31 -05:00
James Peach
e0055ce8f5
r16289: Fix smbclient test hang. This is caused by readline refusing to believe
...
the end of file it receives when reading from a pipe after we force
interactive mode.
(This used to be commit 3eee126458
)
2007-10-10 11:17:31 -05:00
Jeremy Allison
0eb9bd176e
r16287: Use intptr_t to return an integer of an unknown type cast
...
to void *.
Jeremy.
(This used to be commit e24361ecdd
)
2007-10-10 11:17:31 -05:00
Jeremy Allison
193830091f
r16285: On a 64-bit box, size_t != uint32. Ensure we use
...
the right parameter type.
Jeremy.
(This used to be commit 938545f535
)
2007-10-10 11:17:31 -05:00
Jeremy Allison
300acb99ad
r16284: Start fixing up gcc4 -O6 warnings on an x86_64 box. size_t != unsigned
...
int
in a format string.
Jeremy.
(This used to be commit face01ef01
)
2007-10-10 11:17:31 -05:00
Jeremy Allison
c115570b85
r16281: Start fixing up gcc4 -O6 warnings on an x86_64 box. size_t != unsigned
...
int
in a format string.
Jeremy.
(This used to be commit c49ad9200b
)
2007-10-10 11:17:30 -05:00
Jeremy Allison
87967b90c4
r16280: Start fixing up gcc4 -O6 warnings on an x86_64 box. size_t != unsigned
...
int
in a format string.
Jeremy.
(This used to be commit 45d5cad8c2
)
2007-10-10 11:17:30 -05:00
Jeremy Allison
17e1b83996
r16277: Start fixing up gcc4 -O6 warnings on an x86_64 box. size_t != unsigned int
...
in a format string.
Jeremy.
(This used to be commit 3a15fff219
)
2007-10-10 11:17:30 -05:00
Jeremy Allison
9bcaf47c63
r16275: Start fixing up gcc4 -O6 warnings on an x86_64 box. size_t != unsigned int
...
in a format string.
Jeremy.
(This used to be commit 952547471f
)
2007-10-10 11:17:30 -05:00
James Peach
06491a4cb1
r16274: Fix the smbclient prompting behaviour for both systems that have
...
libreadline and those that don't. We always use the built-in readline
replacement for non-interactive mode. Interactive prompts are always
emitted to stdout and non-interactive mode never prompts at all.
Introduce x_fdup to avoid spuriously closing stdout when a logfile is
specified on the command line and setup_logging is called a second time.
(This used to be commit 848ac756f6
)
2007-10-10 11:17:30 -05:00
James Peach
ae2fb4f109
r16273: Add smbclient tests to verify that
...
in interactive mode, smbclient always prompts on stdout
in non-interactive mode, smbclient never prompts
(This used to be commit dff1eba81e
)
2007-10-10 11:17:30 -05:00
Günther Deschner
d4ad11ccd8
r16272: Fix memleak.
...
Guenther
(This used to be commit afdb118902
)
2007-10-10 11:17:30 -05:00
Jeremy Allison
c2528679d8
r16270: Fix Klocwork #706 - ensure sscanf has correct format
...
specifier.
Jeremy.
(This used to be commit dc53d35b0a
)
2007-10-10 11:17:29 -05:00
Günther Deschner
9e7377e81f
r16269: Fix the build.
...
Guenther
(This used to be commit 546710d58c
)
2007-10-10 11:17:29 -05:00
Günther Deschner
e030a9e9dc
r16268: Add TCP fallback for our implementation of the CHANGEPW kpasswd calls.
...
This patch is mainly based on the work of Todd Stecher
<tstecher@isilon.com> and has been reviewed by Jeremy.
I sucessfully tested and valgrinded it with MIT 1.4.3, 1.3.5, Heimdal
0.7.2 and 0.6.1rc3.
Guenther
(This used to be commit 535d03cbe8
)
2007-10-10 11:17:29 -05:00
Jeremy Allison
835bfbb8ac
r16267: Fix Klocwork #401 , #402 - ensure format specifier
...
limited. Fix memleak in printing gencache contents.
Jeremy.
(This used to be commit 81731e1f68
)
2007-10-10 11:17:28 -05:00