1
0
mirror of https://github.com/samba-team/samba.git synced 2025-11-25 00:23:52 +03:00
Commit Graph

24641 Commits

Author SHA1 Message Date
Günther Deschner
ec86852fc6 clikrb5: remove unrequired create_kerberos_key_from_string_direct() prototype.
Guenther
2008-06-17 19:51:52 +02:00
Günther Deschner
d20353d30c dsgetdcname: allow to use NULL mem_ctx.
Guenther
2008-06-17 19:51:24 +02:00
Günther Deschner
132b038581 libads: fix logic error in ads_get_kvno().
Guenther
2008-06-17 19:51:14 +02:00
Volker Lendecke
675bb53398 Fix a memleak in svcctl_init_keys() 2008-06-17 16:09:22 +02:00
Volker Lendecke
5b12d8aa51 Fix a segfault in wbcLookupRids
The done: part could access uninitialized memory if intermediate
BAIL_ON_WBC_ERROR fire.

Jerry, please check!

Thanks,

Volker
(cherry picked from commit 31f4c33dcc)
2008-06-17 15:22:13 +02:00
Volker Lendecke
ac5ba26bb0 Fix a segfault in wbcLookupSid
If the BAIL_ON_WBC_ERROR directly after wbcRequestResponse kicks in, *domain
and *name have not been initialized yet. So the cleanup routine in the done:
part of the routine (which did not check for domain!=NULL etc) would access
uninitialized memory.

Jerry, please check!

Thanks,

Volker
(cherry picked from commit 3d7e0cc40b)
2008-06-17 15:22:04 +02:00
Andrew Bartlett
a09ed6016a Merge branch 'v3-3-test' of ssh://git.samba.org/data/git/samba into 3-3-abartlet 2008-06-17 22:46:34 +10:00
Andrew Bartlett
d013f6fadc Without stdlib.h we don't get a prototype for free().
This test fails if GCC emits any warnings (presumably to detect the
function propertly), but unless we include this message then free()
fail.  Why we need to call free in a configure test is probably
something to blame on valgrind...

Andrew Bartlett
2008-06-17 22:45:29 +10:00
Volker Lendecke
9c1f334af3 Replace a very unusual variable declaration by a more conventional one 2008-06-17 14:35:44 +02:00
Volker Lendecke
20110ee5f1 Fix a memleak in wbcAuthenticateUserEx()
(cherry picked from commit 72b381689a)
2008-06-17 13:10:18 +02:00
Volker Lendecke
80c2e8295a Revert "Fix a memleak caused by a crappy get_sorted_dc_list() API"
This reverts commit 2ea03a1e95.
2008-06-17 12:21:03 +02:00
Volker Lendecke
342f885820 Revert "Fix a memleak in ads_find_dc() in case get_sorted_dc_list() fails"
This reverts commit df8d089bc6.
2008-06-17 12:20:54 +02:00
Günther Deschner
71f4cf7730 netapi: Fix Bug #5545 (libnetapi_init without $USER)
Based on patch from Erik van Pienbroek.

Guenther
2008-06-17 10:49:38 +02:00
Günther Deschner
7d8d60bcba net_vampire: fix samsync_process_database().
Turns out the password hashes are not rid encrypted in the samsync reply.

Guenther
2008-06-17 10:49:14 +02:00
Günther Deschner
eb4232fec0 net_vampire: fix build warning.
Guenther
2008-06-17 10:49:14 +02:00
Günther Deschner
e0843e631e net_vampire: use generic output filename and use correct argv element.
Guenther
2008-06-17 10:49:13 +02:00
Günther Deschner
1d5758ec3a net_vampire: move ldif code out of net_rpc_samsync.c
Guenther
2008-06-17 10:49:13 +02:00
Günther Deschner
b3b6af0a3e net_vampire: move some samsync functions to libnet.
Guenther
2008-06-17 10:49:13 +02:00
Volker Lendecke
4394235378 Add some debug to notify 2008-06-17 10:48:40 +02:00
Karolin Seeger
9d69a809e3 Remove references to SVN.
Karolin
2008-06-17 10:43:19 +02:00
Michael Adam
50fbfa0348 Remove reference to current_user from modules/nfs4_acls.c .
Michael
2008-06-17 10:33:12 +02:00
Karolin Seeger
94a4d7fa32 idmap: Fix typos in comments.
Karolin
2008-06-17 10:30:19 +02:00
Karolin Seeger
16b5b772d2 Fix typo.
arguements -> arguments

Karolin
2008-06-17 09:46:17 +02:00
Karolin Seeger
b58e4f6b3d winbind cache: Don't create SN cache entries during name-to-sid queries.
Clients can request name-to-sid queries for different combinations of
upper and lower case names. We don't want to create the reverse caching
entries for each combination used.

This avoids inconsistent answers on sid-to-name queries.

Please review!

Karolin
2008-06-16 15:21:28 +02:00
Volker Lendecke
1f86c7a2a1 Fix bug 5500 -- thanks to mathion at thorrovydeti.com for reporting
(cherry picked from commit 996c3ce6f0)
2008-06-16 13:27:47 +02:00
Volker Lendecke
dee60935d4 Add forgotten protoypes 2008-06-15 18:46:10 +02:00
Volker Lendecke
d0386914ff Remove the current_user references from open.c
current_user_info was "only" used in a debug msg, and current_user.ut.uid is
also available via conn->server_info
2008-06-15 13:41:16 +02:00
Volker Lendecke
c8fd5eef32 Remove the current_user reference from fake_file.c
The current vuid is not only available there, it is also in the current
smb_request structure.
2008-06-15 13:37:53 +02:00
Volker Lendecke
b92cfd19b4 Remove unused "extern struct current_user" from dir.c 2008-06-15 11:40:33 +02:00
Volker Lendecke
093bc5f2b3 Remove the reference to current_user from file_access.c
conn holds the current user info
2008-06-15 11:39:31 +02:00
Volker Lendecke
5663587e5e Fix an uninitialized variable found by the IBM checker
BAIL_ON_PTR_ERROR jumps to done: which will access extra_data before it's
initialized.

Stefan, please check!

Volker
(cherry picked from commit b59636f78d)
2008-06-15 00:24:18 +02:00
Volker Lendecke
26c05a52b7 Fix group parsing in libwbclient's copy_group_entry()
This (also) fixes a flaw pointed out by the IBM checker. When verifying that I
found out that the parsing was not working as I would have expected it to.

Jerry, please check!
(cherry picked from commit c2c7790155)
2008-06-15 00:17:27 +02:00
Volker Lendecke
1025f68791 Move connection-specific vuid cache clear to uid.c 2008-06-14 19:49:49 +02:00
Volker Lendecke
68944ea1ea Slight refactoring for check_user_ok: It only needs vuid and server_info 2008-06-14 19:49:49 +02:00
Volker Lendecke
45662b5e8b Group the access checks together in check_user_ok() 2008-06-14 19:49:49 +02:00
Volker Lendecke
b14e59bfdb Consistently use snum in check_user_ok
Most already used it, these two still used SNUM(conn), where the only caller of
this routine (change_to_user) had set snum = SNUM(conn).
2008-06-14 19:49:49 +02:00
Volker Lendecke
5c916549f0 Compare the pointer "vuser" to NULL, not 0 2008-06-14 19:49:49 +02:00
Volker Lendecke
a42d7e1146 Use the correct cups-devel test for HAVE_IPRINT also 2008-06-14 11:10:13 +02:00
Volker Lendecke
2408d2493f Correctly check for presence of cups-devel
On SuSE at least cups-config belongs to cups-libs which does not contain the
headers which are in cups-devel.
2008-06-14 10:39:25 +02:00
Günther Deschner
cf382a8760 net_vampire: rename process_database to samsync_process_database.
Guenther
2008-06-13 23:39:09 +02:00
Günther Deschner
94d45b1bb9 net_vampire: fix ldif_init_context().
Guenther
2008-06-13 23:39:09 +02:00
Günther Deschner
bcc6d3a0eb net_vampire: split out rpc_vampire_ldif().
Guenther
2008-06-13 23:39:09 +02:00
Günther Deschner
63ca4414b6 net_vampire: add samsync_init_context().
Guenther
2008-06-13 23:39:09 +02:00
Günther Deschner
bbfe5bcaf5 net_vampire: add samsync_debug_str().
Guenther
2008-06-13 23:39:08 +02:00
Günther Deschner
9557504d70 net_vampire: restructure internal code more.
Guenther
2008-06-13 23:39:08 +02:00
Günther Deschner
ae179e4f3f net_vampire: start using talloc for the ldif vampire code.
Guenther
2008-06-13 23:39:08 +02:00
Günther Deschner
e9b79f34d5 net_vampire: join dump and process function into one callback.
Guenther
2008-06-13 23:39:08 +02:00
Günther Deschner
0707d32042 net_vampire: let fetch_database and fetch_database_to_ldif use sid pointers.
Guenther
2008-06-13 23:39:08 +02:00
Günther Deschner
b5a0e2d18f net_vampire: let dump_database() return NTSTATUS.
Guenther
2008-06-13 23:39:08 +02:00
Volker Lendecke
f30bc6503d Fix a handle leak for error returns in ldb_try_load_dso
Coverity ID 464
(cherry picked from commit 496d44d2f2)
2008-06-13 16:15:12 +02:00