1
0
mirror of https://github.com/samba-team/samba.git synced 2025-03-11 16:58:40 +03:00

23084 Commits

Author SHA1 Message Date
Simo Sorce
fdc20894a0 r24603: In case of error we need to free prefix_cache otherwise on re-init the first
statement will return positively but prefix_cache_hashes would be NULL
2007-10-10 12:30:10 -05:00
Michael Adam
d13eaa60f5 r24602: Add function lp_string_is_valid_boolean() to check if a string
contains a correct representation of a boolean value (in the
understanding of loadparm.c).

Make set_boolean() catch passing NULL for the boolean target.

Michael
2007-10-10 12:30:09 -05:00
Lars Müller
12cb06d6ad r24601: Fix if statements where we still expected cli_connect() to return BOOL. 2007-10-10 12:30:09 -05:00
Stefan Metzmacher
8532e3182a r24599: patch from Karolin Seeger <ks@sernet.de>:
smbd, nmbd and winbindd can be started with invalid options currently.
The first patch attached would be a possible solution.
It contains an exit if an invalid option has been used. The main problem
is, that existing setups with wrong options or missing arguments in start
scripts will break (which is the right behaviour from my point of view).

metze
2007-10-10 12:30:09 -05:00
Stefan Metzmacher
5c4d998300 r24597: - talloc request structure for the samba3 server bindings
and make that the primary context for the request
  which the implementations can also use.
- go via functions pointers in the ndr_interface_table
  instead of calling functions directly.

metze
2007-10-10 12:30:08 -05:00
Volker Lendecke
751834fff9 r24595: Fix Coverity ID 393
In this error case we would have used "start" not having it initialized
2007-10-10 12:30:08 -05:00
Stefan Metzmacher
5e3d4df9bc r24594: pass down the ndr_interface_table in the samba3 client bindings
instead of the pull and push functions

metze
2007-10-10 12:30:08 -05:00
Jeremy Allison
41611a22ed r24590: Reformatting to coding standards. Added my (C) in places it already should
have been :-).
Jeremy.
2007-10-10 12:30:08 -05:00
Jeremy Allison
a54f2805df r24589: Refactor our vuid code so that we keep the same
vuid that was allocated whilst the connection is
being constructed and after the connection has been set up.
This is what Windows does and at least one client
(and HP printer) depends on this behaviour. As it
depends on the req struct not yet ported to SAMBA_3_2_0
(Volker, hint hint.... :-) I am not yet adding this
to that branch, but will investigate that tomorrow.
Jeremy.
2007-10-10 12:30:08 -05:00
Günther Deschner
8c56ee2c58 r24584: Merge all pam post-processing code (in particular all extra_data code) into
append_data().

Guenther
2007-10-10 12:30:07 -05:00
Günther Deschner
8a493cce98 r24583: Make sure we don't accept invalid request options.
Thanks to Michael for his bit-magic.

Guenther
2007-10-10 12:30:07 -05:00
Günther Deschner
d5bd8b1d61 r24579: Merge error reporting to the end of winbindd_pam_auth().
Guenther
2007-10-10 12:30:07 -05:00
Günther Deschner
27ecb0df79 r24578: Fix build warning.
Guenther
2007-10-10 12:30:07 -05:00
Günther Deschner
1bae53e39f r24573: Fix build without LDAP. Thanks Volker for pointing this out.
Guenther
2007-10-10 12:30:07 -05:00
Michael Adam
07dc0fecf5 r24572: Allow for functions map_parameter_canonical() and is_synonym_of() to
be called with inverse == NULL.

Add a new function lp_parameter_is_canonical() to check whether a
parameter name is the canonical name (as apposed to an alias).

Michael
2007-10-10 12:30:07 -05:00
Volker Lendecke
888e657d75 r24571: Only look at errno if the close call actually failed
Patch from Ofir Azoulay <Ofir.Azoulay@expand.com> -- thanks
2007-10-10 12:30:06 -05:00
Stefan Metzmacher
ec8858c374 r24564: regenerate after pidl changes...
metze
2007-10-10 12:30:05 -05:00
Stefan Metzmacher
8f07b8ab65 r24561: merge from SAMBA_4_0:
rename some DCERPC_ prefixes into NDR_

metze
2007-10-10 12:30:03 -05:00
Stefan Metzmacher
4e5908cd59 r24558: merge from SAMBA_4_0:
rename 'dcerpc_table_' -> 'ndr_table_'

metze
2007-10-10 12:29:57 -05:00
Stefan Metzmacher
f57d23d0f1 r24552: merge from SAMBA_4_0:
rename dcerpc_interface_table -> ndr_interface_table
rename dcerpc_interface_list  -> ndr_interface_list

and move them to libndr.h

metze
2007-10-10 12:29:56 -05:00
Volker Lendecke
0d29426741 r24550: Attempt to fix the non-LDAP build
For example host "bigboy" doesn't have it.

Günther, please fix it properly and merge to 3_2_0

Thanks,

Volker
2007-10-10 12:29:56 -05:00
Volker Lendecke
d4f442ed9b r24549: Fix unix_convert to return the already converted part
This API will change anyway when moving away from pstrings.

It took so long to fix, because that rename bug I just fixed gave make
test failures that had nothing to do with this one.

I have samba4 tests for both bugs, will check them in when the build
farm has caught up
2007-10-10 12:29:56 -05:00
Volker Lendecke
fddc9db911 r24548: Fix the case-changing renames
This was broken when I changed reply_mv to wrap in a open_file_ntcreate
call, unix_convert on the destination was called twice
2007-10-10 12:29:56 -05:00
Volker Lendecke
4a90264d17 r24547: Fix #4897, patch from David S. Collier-Brown <davecb@spamcop.net> -- Thanks! 2007-10-10 12:29:56 -05:00
Derrell Lipman
5a83c306bb r24543: Apply missing portion of correction for bug 4750 2007-10-10 12:29:55 -05:00
Stefan Metzmacher
9fec0d6c2c r24541: merge from SAMBA_4_0:
rename struct dcerpc_endpoint_list/struct dcerpc_authservice_list
into ndr_interface_string_array and move it to libndr.h

metze
2007-10-10 12:29:55 -05:00
Stefan Metzmacher
24e096b365 r24538: merge from SAMBA_4_0:
rename struct dcerpc_interface_call -> struct ndr_interface_call
and move it to librpc/ndr/libndr.h

metze
2007-10-10 12:29:55 -05:00
Stefan Metzmacher
e827c7311c r24537: regenerate after pidl fixes
metze
2007-10-10 12:29:54 -05:00
Stefan Metzmacher
7facd9bf3f r24533: merge from SAMBA_4_0:
rename dcerpc_syntax_id -> ndr_syntax_id

metze
2007-10-10 12:29:54 -05:00
Michael Adam
3b762ab183 r24527: Add a function lp_canonicalize_parameter_with_value that turns
a parameter and value into the canonical paramter with the value
inverted if it was in invers boolean synonym.

Make net conf use this function when storing parameters.

Michael
2007-10-10 12:29:54 -05:00
Michael Adam
0dfb5eee25 r24526: Refactor determiniation of the index of the canonical form of a
parameter given in string representation into a function of its
own (map_parameter_canonical).

Michael
2007-10-10 12:29:54 -05:00
Michael Adam
fd2dbae825 r24525: Add output of synonym information to show_parameter_list().
Also simplify lp_canonicalize_parameter by making use of
the new function "is_synonym_of".

Michael

Note: If anything depends on the exact former output format of
show_parameter list, I would trigger the output of synonym information
by a boolean verbose switch (that could be passed to testparm
via the "-v" command line switch).
2007-10-10 12:29:53 -05:00
Michael Adam
70dfe5d098 r24519: Refactor printing of one parameter into a helper function of its own. 2007-10-10 12:29:53 -05:00
Michael Adam
00432bcd69 r24513: Reformatting: eliminate trailing spaces, overly long lines
and adjust some formattings to standard.

Michael
2007-10-10 12:29:53 -05:00
Volker Lendecke
2b8ecda30f r24512: Fix RAW-NOTIFY
With the inbuf consistency checks we have to more correctly fake the
inbuf
2007-10-10 12:29:53 -05:00
Michael Adam
ce1d7ad1ac r24510: Fix logic. Thanks to Volker for the hint!
Michael
2007-10-10 12:29:53 -05:00
Jeremy Allison
9d9ed41f21 r24501: Added bcc test for reply_tcon & removed Vl's comment :-).
Jeremy.
2007-10-10 12:29:53 -05:00
Jeremy Allison
267a0ac48d r24500: Add check that bcc is correct in an incoming packet.
Jeremy.
2007-10-10 12:29:52 -05:00
Jeremy Allison
43ddfb8c91 r24498: More extra code into a function, reply_openerror.
Jeremy.
2007-10-10 12:29:52 -05:00
Volker Lendecke
01f701ba1e r24497: Revert r24485 -- this needs more thought 2007-10-10 12:29:52 -05:00
Michael Adam
95447dde86 r24496: Add initial synonym handling to "net conf":
When storing parameters in the smbconf portion of the registry,
up to now, synonyms could be misused to store a parameter twice.
Now this is prevented by canonicalizing the paramter name first.

Also, the value for a boolean parameter checked for validity
before storing the bool in registry.

(The canonicalization should finally go into the registry smbconf
code to also prevent e.g. "regedit" or "net rpc registry" from
storing synonyms. - This is in the making.)

Michael
2007-10-10 12:29:52 -05:00
Michael Adam
113ac07199 r24495: Add a function lp_canonicalize_parameter: It takes a name of a parameter
and produces the "canonical" (or main) name of the parameter (the one
synonym that does not have the flag FLAG_HIDE). The function also sets
a flag as to whether the synonym is a reverse boolean synonym.

Add some functions for the handling of string representations of boolean
values: return the canonical string representation of a bool, invert
a bool given as a string, canonicalize a bool given as a string.

Michael
2007-10-10 12:29:52 -05:00
Volker Lendecke
301ae3d68b r24485: Even in the failure case unix_convert must pass the already converted
part of the string to the caller.
2007-10-10 12:29:51 -05:00
Stefan Metzmacher
51507a0d76 r24481: copy .bzrignore => .gitignore
metze
2007-10-10 12:29:51 -05:00
Jeremy Allison
74d10b09a6 r24476: Fix the mappings in reply_opeXXX calls. Now to test renames.
Jeremy.
2007-10-10 12:29:51 -05:00
Jeremy Allison
6dac315ba1 r24475: Fix the error mapping for SMB_POSIX_PATH_OPEN.
Jeremy.
2007-10-10 12:29:51 -05:00
Jeremy Allison
5b2316d173 r24474: Map error value NT_STATUS_OBJECT_NAME_COLLISION
to ERRDOS, ERRfilexists for NTCreateX and NTTransCreate.
Jeremy.
2007-10-10 12:29:51 -05:00
Jeremy Allison
4674486450 r24470: Start fixing up the mapping of OBJECT_NAME_COLLISION
to DOS error ERRDOS, ERRfilexists on open calls.
Jeremy.
2007-10-10 12:29:50 -05:00
Jeremy Allison
4d01e0b744 r24468: Don't forget the +4 for length :-).
Jeremy.
2007-10-10 12:29:50 -05:00
Jeremy Allison
dbd58dd647 r24467: Do range checking on incoming smb request.
Jeremy.
2007-10-10 12:29:50 -05:00