Jeremy Allison 2757c0711d s3: smbd: Only set xconn->smb1.negprot.done = true after supported_protocols[protocol].proto_reply_fn() succeeds. ...

Otherwise we can end up with negprot.done set, but
without smbXsrv_connection_init_tables() being called.

This can cause a client self-crash.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14205

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed Dec  4 21:27:24 UTC 2019 on sn-devel-184

(cherry picked from commit 8db0c1bff6f42feabd2e4d9dfb13ae12cc29607b)

2019-12-16 08:22:36 +00:00

..

notifyd

notifyd: Fix SIGBUS on sparc

2019-03-05 19:29:10 +00:00

aio.c

Revert "smbd: add an effective {smb,smbd_smb2}_request->ev_ctx that holds the event context used for the request processing"

2019-01-11 23:11:16 +01:00

avahi_register.c

s3-smbd: use fruit:model string for mDNS registration

2019-02-21 12:30:41 +01:00

blocking.c

Revert "smbd: use sconn->root_ev_ctx for brl_timeout_fn()"

2019-01-11 23:11:17 +01:00

close.c

s3: smbd: Prevent valgrind errors in smbtorture3 POSIX test.

2018-09-29 05:32:41 +02:00

conn_idle.c

…

conn_msg.c

…

conn.c

Revert "smbd: add an effective connection_struct->user_ev_ctx that holds the event context used for the current user"

2019-01-11 23:11:16 +01:00

connection.c

…

dfree.c

s3: smbd: Convert dfree code to use file_lines_ploadv().

2019-06-13 08:52:29 +00:00

dir.c

smbd: Add "hide new files" option

2018-11-09 00:47:22 +01:00

dmapi.c

Convert all uses of uint8/16/32 to _t in source3/smbd.

2015-05-06 04:14:14 +02:00

dnsregister.c

…

dosmode.c

s3:smbd: Fix sync dosmode fallback in async dosmode codepath

2019-11-08 09:57:33 +00:00

durable.c

smbd: Add some structure protection for durable reconnect

2018-09-14 07:49:13 +02:00

error.c

s3:smbd: Fix converity warning with _smb_setlen_large()

2018-05-16 21:30:23 +02:00

fake_file.c

Convert three include files from uint32/16/8 to _t types as well as the source that includes them.

2015-05-01 19:15:10 +02:00

file_access.c

s3: Filenames: Add uint32_t flags parameter to synthetic_smb_fname().

2016-03-24 22:57:16 +01:00

fileio.c

Revert "smbd: explain that/why we use the raw tevent_context for update_write_time_handler()"

2019-01-11 23:11:18 +01:00

filename.c

smbd: allow case insensitive opens of named streams

2019-05-16 10:37:51 +00:00

files.c

s3:vfs: Correctly check if OFD locks should be enabled or not

2019-02-21 12:30:43 +01:00

globals.c

printing: use housekeeping period that matches cache time

2016-04-19 09:37:14 +02:00

globals.h

s3: smbd: Change (*proto_reply_fn()) to return an NTSTATUS.

2019-12-16 08:22:36 +00:00

ipc.c

Revert "smbd: add an effective {smb,smbd_smb2}_request->ev_ctx that holds the event context used for the request processing"

2019-01-11 23:11:16 +01:00

lanman.c

s3: rename talloc_sub_advanced() to talloc_sub_full()

2019-11-18 09:18:14 +00:00

mangle_hash2.c

…

mangle_hash.c

smbd: Convert valid.dat to C code

2015-03-24 00:00:20 +01:00

mangle.c

s3/smbd: convert "mangled names" option to an enum

2017-01-09 19:31:20 +01:00

message.c

Update smbrun to allow for settings environment variables.

2016-10-13 04:26:26 +02:00

msdfs.c

Revert "smbd: add smbd_server_connection->raw_ev_ctx pointer"

2019-01-11 23:11:19 +01:00

negprot.c

s3: smbd: Only set xconn->smb1.negprot.done = true after supported_protocols[protocol].proto_reply_fn() succeeds.

2019-12-16 08:22:36 +00:00

notify_fam.c

smbd: Allow passing notify filter from inotify and fam

2016-07-18 15:14:11 +02:00

notify_inotify.c

s3: smbd: inotify_map_mask_to_filter incorrectly indexes an array.

2017-04-28 03:18:23 +02:00

notify_msg.c

smbd: remove unused tevent_context argument from notify_init

2018-06-18 08:59:18 +02:00

notify.c

smbd: remove unused tevent_context argument from notify_init

2018-06-18 08:59:18 +02:00

ntquotas.c

smbd: Use dom_sid_str_buf

2018-12-20 23:40:24 +01:00

nttrans.c

smbd: Use dom_sid_str_buf

2018-12-20 23:40:24 +01:00

open.c

smbd: Fix a panic

2019-06-13 08:52:29 +00:00

oplock_linux.c

Revert "smbd: explain that/why we use the raw tevent_context for linux_oplock_signal_handler()"

2019-01-11 23:11:17 +01:00

oplock.c

Revert "smbd: explain that/why we use the raw tevent_context for lease_timeout_handler()"

2019-01-11 23:11:18 +01:00

password.c

s3:smbd: Make sure we do not export "/" (root) as home dir

2018-12-05 01:38:14 +01:00

perfcount.c

lib:util: Make probing of modules more secure

2017-06-06 18:36:07 +02:00

pipes.c

Revert "smbd: add an effective {smb,smbd_smb2}_request->ev_ctx that holds the event context used for the request processing"

2019-01-11 23:11:16 +01:00

posix_acls.c

smbd: Use dom_sid_str_buf

2018-12-20 23:40:24 +01:00

process.c

s3: smbd: Ensure we exit on smbd_smb2_process_negprot() fail.

2019-12-16 08:22:36 +00:00

proto.h

Revert "smbd: add [un]become_guest() helper functions"

2019-01-11 23:11:15 +01:00

pysmbd.c

CVE-2019-3870 pysmbd: Ensure a zero umask is set for smbd.mkdir()

2019-04-05 10:14:36 +02:00

quotas.c

s3: VFS: Change SMB_VFS_GET_QUOTA to use const struct smb_filename * instead of const char *.

2017-06-18 02:49:25 +02:00

reply.c

s3:smbd: Incomplete conversion of former parametric options

2019-11-08 09:57:33 +00:00

scavenger.c

lib: Remove unused serverid.tdb

2017-12-05 04:58:26 +01:00

scavenger.h

…

seal.c

auth: Always supply both the remote and local address to the auth subsystem

2017-03-29 02:37:26 +02:00

sec_ctx.c

s3:smbd: Fix incorrect use of sys_getgroups()

2017-04-18 15:43:02 +02:00

server_exit.c

gencache: Remove transaction-based tdb

2018-11-06 18:57:26 +01:00

server_reload.c

smbd: remove useless set_current_service(NULL,0,True) from reload_services()

2018-06-18 08:59:17 +02:00

server.c

s3:smbd: call reinit_guest_session_info() in the conf updated handler

2019-06-21 06:49:29 +00:00

service.c

s3: rename talloc_sub_advanced() to talloc_sub_full()

2019-11-18 09:18:14 +00:00

session.c

rpc_server: Fix NetSessEnum with stale sessions

2018-04-25 22:49:07 +02:00

sesssetup.c

s3:smbd: Fix build on AIX

2019-01-04 16:29:50 +01:00

share_access.c

smbd: remove redundant comment (with typo) from token_contains_name()

2016-08-04 18:26:07 +02:00

signing.c

…

smb2_break.c

Revert "smbd: add an effective {smb,smbd_smb2}_request->ev_ctx that holds the event context used for the request processing"

2019-01-11 23:11:16 +01:00

smb2_close.c

Revert "smbd: add an effective {smb,smbd_smb2}_request->ev_ctx that holds the event context used for the request processing"

2019-01-11 23:11:16 +01:00

smb2_create.c

Revert "smbd: add an effective {smb,smbd_smb2}_request->ev_ctx that holds the event context used for the request processing"

2019-01-11 23:11:16 +01:00

smb2_flush.c

Revert "smbd: add an effective {smb,smbd_smb2}_request->ev_ctx that holds the event context used for the request processing"

2019-01-11 23:11:16 +01:00

smb2_getinfo.c

smbd: implement SMB_FILE_NORMALIZED_NAME_INFORMATION handling

2019-05-16 10:37:52 +00:00

smb2_glue.c

Revert "smbd: add an effective {smb,smbd_smb2}_request->ev_ctx that holds the event context used for the request processing"

2019-01-11 23:11:16 +01:00

smb2_ioctl_dfs.c

s3: debug: smb2: Create a new DBGC_SMB2 debug class and mark all smbd/smb2_*.c files with it.

2018-03-22 02:15:13 +01:00

smb2_ioctl_filesys.c

s3: debug: smb2: Create a new DBGC_SMB2 debug class and mark all smbd/smb2_*.c files with it.

2018-03-22 02:15:13 +01:00

smb2_ioctl_named_pipe.c

Revert "smbd: add an effective {smb,smbd_smb2}_request->ev_ctx that holds the event context used for the request processing"

2019-01-11 23:11:16 +01:00

smb2_ioctl_network_fs.c

s3: debug: smb2: Create a new DBGC_SMB2 debug class and mark all smbd/smb2_*.c files with it.

2018-03-22 02:15:13 +01:00

smb2_ioctl_private.h

…

smb2_ioctl.c

Revert "smbd: add an effective {smb,smbd_smb2}_request->ev_ctx that holds the event context used for the request processing"

2019-01-11 23:11:16 +01:00

smb2_keepalive.c

s3: debug: smb2: Create a new DBGC_SMB2 debug class and mark all smbd/smb2_*.c files with it.

2018-03-22 02:15:13 +01:00

smb2_lock.c

Revert "smbd: use sconn->root_ev_ctx for brl_timeout_fn()"

2019-01-11 23:11:17 +01:00

smb2_negprot.c

s3: smbd: Change (*proto_reply_fn()) to return an NTSTATUS.

2019-12-16 08:22:36 +00:00

smb2_notify.c

Revert "smbd: add an effective {smb,smbd_smb2}_request->ev_ctx that holds the event context used for the request processing"

2019-01-11 23:11:16 +01:00

smb2_query_directory.c

s3:smbd: perform impersonation in smb2_query_directory_fetch_write_time_done()

2019-01-14 22:30:24 +01:00

smb2_read.c

Revert "smbd: add an effective {smb,smbd_smb2}_request->ev_ctx that holds the event context used for the request processing"

2019-01-11 23:11:16 +01:00

smb2_server.c

s3: smbd: Allow smbd_smb2_process_negprot() to return NTSTATUS as it can fail.

2019-12-16 08:22:35 +00:00

smb2_sesssetup.c

smb2_sesssetup: avoid STATUS_PENDING completely on session logoff

2019-04-16 08:51:21 +00:00

smb2_setinfo.c

Revert "smbd: add an effective {smb,smbd_smb2}_request->ev_ctx that holds the event context used for the request processing"

2019-01-11 23:11:16 +01:00

smb2_tcon.c

smb2_tcon: avoid STATUS_PENDING completely on tdis

2019-04-16 08:51:21 +00:00

smb2_write.c

Revert "smbd: add an effective {smb,smbd_smb2}_request->ev_ctx that holds the event context used for the request processing"

2019-01-11 23:11:16 +01:00

smbd_cleanupd.c

s3:cleanupd: sends MSG_SMB_UNLOCK twice to interested peers

2018-05-04 03:02:27 +02:00

smbd_cleanupd.h

smbd: Implement a cleanup daemon

2015-11-16 14:51:33 +01:00

smbd.h

s3: smbd: Add UCF_GMT_PATHNAME, which represents FLAGS2_REPARSE_PATH.

2017-05-22 18:41:16 +02:00

smbXsrv_client.c

smbd: Replace some GUID_string by GUID_buf_string

2018-10-25 17:58:24 +02:00

smbXsrv_open.c

lib: Pass mem_ctx to lock_path()

2018-08-17 11:30:10 +02:00

smbXsrv_session.c

s3: Rename server_messaging_context() to global_messaging_context()

2018-09-07 17:26:17 +02:00

smbXsrv_tcon.c

s3:smbd: reorder tcon global record deletion and closing files of a tcon

2018-08-31 22:22:23 +02:00

smbXsrv_version.c

lib: Pass mem_ctx to lock_path()

2018-08-17 11:30:10 +02:00

srvstr.c

s3: smbd: Chain code can return uninitialized memory when talloc buffer is grown.

2017-11-21 19:42:22 +01:00

statcache.c

s3: Don't copy back the stat struct from stat_cache_lookup if we did not get a hit on the full path.

2018-09-19 17:52:13 +02:00

statvfs.c

statvfs: rename linux_statvfs to posix_statvfs

2019-01-11 02:53:57 +01:00

trans2.c

s3:smbd: Incomplete conversion of former parametric options

2019-11-08 09:57:33 +00:00

uid.c

CVE-2019-10197: smbd: split change_to_user_impersonate() out of change_to_user_internal()

2019-08-27 13:16:24 +02:00

utmp.c

s3/smbd: fix utmp hostname logging on Solaris

2019-01-10 22:46:11 +01:00

vfs.c

vfs: perform impersonation in smb_vfs_call_getxattrat_done()

2019-01-14 19:13:14 +01:00