Commit Graph

7697 Commits

Author SHA1 Message Date
Cole Robinson
ddc55c8ba5 hostdev: Log XML of the source nodedev device
Signed-off-by: Cole Robinson <crobinso@redhat.com>
2020-11-14 18:17:32 -05:00
Cole Robinson
cd788e9303 Prep for release 3.2.0
Signed-off-by: Cole Robinson <crobinso@redhat.com>
2020-11-14 16:15:22 -05:00
Weblate
88ec96a932 Update translation files
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: virt-manager/virt-manager
Translate-URL: https://translate.fedoraproject.org/projects/virt-manager/virt-manager/
2020-11-14 16:13:46 -05:00
Jan Nerad
d380ed2e8e Translated using Weblate (German)
Currently translated at 71.6% (1012 of 1413 strings)

Translation: virt-manager/virt-manager
Translate-URL: https://translate.fedoraproject.org/projects/virt-manager/virt-manager/de/
2020-11-14 16:13:46 -05:00
Samuel Heinzmann
263cbbe5e1 Translated using Weblate (German)
Currently translated at 71.6% (1012 of 1413 strings)

Translation: virt-manager/virt-manager
Translate-URL: https://translate.fedoraproject.org/projects/virt-manager/virt-manager/de/
2020-11-14 16:13:46 -05:00
Pino Toscano
1af30029b5 Translated using Weblate (Italian)
Currently translated at 98.5% (1392 of 1413 strings)

Translation: virt-manager/virt-manager
Translate-URL: https://translate.fedoraproject.org/projects/virt-manager/virt-manager/it/

Translated using Weblate (Italian)

Currently translated at 98.5% (1392 of 1413 strings)

Translation: virt-manager/virt-manager
Translate-URL: https://translate.fedoraproject.org/projects/virt-manager/virt-manager/it/
2020-11-14 16:13:46 -05:00
scootergrisen
40391c67d2 Translated using Weblate (Danish)
Currently translated at 16.0% (227 of 1413 strings)

Translation: virt-manager/virt-manager
Translate-URL: https://translate.fedoraproject.org/projects/virt-manager/virt-manager/da/

Translated using Weblate (Danish)

Currently translated at 15.9% (226 of 1413 strings)

Translation: virt-manager/virt-manager
Translate-URL: https://translate.fedoraproject.org/projects/virt-manager/virt-manager/da/
2020-11-14 16:13:46 -05:00
Oğuz Ersen
ce3df9727b Translated using Weblate (Turkish)
Currently translated at 100.0% (1413 of 1413 strings)

Translation: virt-manager/virt-manager
Translate-URL: https://translate.fedoraproject.org/projects/virt-manager/virt-manager/tr/

Translated using Weblate (Turkish)

Currently translated at 73.8% (1043 of 1413 strings)

Translation: virt-manager/virt-manager
Translate-URL: https://translate.fedoraproject.org/projects/virt-manager/virt-manager/tr/
2020-11-14 16:13:46 -05:00
Github Actions
6946573d72 Refresh translation .pot template 2020-11-14 16:13:46 -05:00
Github Actions
01930b0d58 Refresh translation .pot template 2020-11-14 16:13:46 -05:00
Github Actions
b7e14eef03 Refresh translation .pot template 2020-11-14 16:13:46 -05:00
Github Actions
9a655bd31a Refresh translation .pot template 2020-11-14 16:13:46 -05:00
Cole Robinson
110959a371 tests: test_urls: Fix dead links
Signed-off-by: Cole Robinson <crobinso@redhat.com>
2020-11-14 16:11:28 -05:00
Cole Robinson
f81c07d2da details: Add simplified wrapper for change_config_helper
Signed-off-by: Cole Robinson <crobinso@redhat.com>
2020-11-14 16:09:21 -05:00
Cole Robinson
488f153655 fsdetails: Rework XML building logic
Make it work more like gfxdetails. The problem with the current
approach is that it requires effectively rebuilding the whole device
to match the original device when we want to edit a single field,
which is error prone.

Signed-off-by: Cole Robinson <crobinso@redhat.com>
2020-11-14 16:09:21 -05:00
Cole Robinson
fca338d2d1 fsdetails: Remove some dead code
Signed-off-by: Cole Robinson <crobinso@redhat.com>
2020-11-13 17:05:00 -05:00
Cole Robinson
41023192ca fsdetails: Stop showing the 'driver' combo for qemu
The only valid value now is 'path' which is also the default,
so drop the UI

Signed-off-by: Cole Robinson <crobinso@redhat.com>
2020-11-13 13:17:41 -05:00
Cole Robinson
b7b75ab8fc fsdetails: Drop driver="handle" UI
It was removed in qemu 4.0.0

Signed-off-by: Cole Robinson <crobinso@redhat.com>
2020-11-13 13:09:03 -05:00
Cole Robinson
2b864a9294 fsdetails: Remove the combo vs label dynamic
If something would normally be shown only in a label, just
hide the row entirely. This was interesting for viewer XML
properties before we had the XML editor, but now it doesn't
add much

Signed-off-by: Cole Robinson <crobinso@redhat.com>
2020-11-13 12:53:10 -05:00
Cole Robinson
374ea52be0 fsdetails: Remove wrpolicy UI
This is an obscure setting. If users need it they can set
it manually in the XML editor

Signed-off-by: Cole Robinson <crobinso@redhat.com>
2020-11-13 12:20:57 -05:00
Cole Robinson
4cfb3aeff1 cloner: more detailed error messages about supported network vols
Signed-off-by: Cole Robinson <crobinso@redhat.com>
2020-11-11 19:06:32 -05:00
Cole Robinson
6a6c1c13d7 diskbackend: Fix volume lookup for existing rbd disk
Signed-off-by: Cole Robinson <crobinso@redhat.com>
2020-11-11 19:06:32 -05:00
Cole Robinson
3d07b28a36 device: disk: Rename path property to get/set_source_path
This makes it more clear that 'path' is really a special designation
with a bunch of complicated logic behind it. It's also easier to
grep for

Signed-off-by: Cole Robinson <crobinso@redhat.com>
2020-11-11 19:06:32 -05:00
Cole Robinson
c4f5812290 device: disk: Group related functions
Signed-off-by: Cole Robinson <crobinso@redhat.com>
2020-11-11 18:07:50 -05:00
Cole Robinson
b3ff59c75c device: disk: Move <source> XML handling to its own class
Makes DeviceDisk less complicated, helps with readability

Signed-off-by: Cole Robinson <crobinso@redhat.com>
2020-11-11 18:07:50 -05:00
Cole Robinson
9f930bd329 tests: uitests: fix clone case after recent changes
Signed-off-by: Cole Robinson <crobinso@redhat.com>
2020-11-11 18:07:50 -05:00
Cole Robinson
98ca65f183 connection: Unconditionally report connection leak
Leaked connection may mean the app keeps libvirtd socket activated
daemon running for longer than necessary, so it's useful to report
this

Signed-off-by: Cole Robinson <crobinso@redhat.com>
2020-11-10 17:41:20 -05:00
Cole Robinson
2773bc35bf storagepool: cleanup() volumes on pool cleanup()
Fixes connection leaks

Resolves: #172

Signed-off-by: Cole Robinson <crobinso@redhat.com>
2020-11-10 17:40:31 -05:00
Cole Robinson
d9c6df951f installer: Remove cloudinit media after initial boot
We do this by faking an install phase whenever cloudinit media is
specified, which isn't really the right abstraction and will leak
into virt-install behavior (like doing 2 boots), but it's the simplest
fix for now

Fixes: #178

Signed-off-by: Cole Robinson <crobinso@redhat.com>
2020-11-10 12:04:25 -05:00
Cole Robinson
b132820244 devices: disk: Skip check_path_search for path=""
virt-manager can trigger this when ejecting cdrom media

Fixes: #180

Signed-off-by: Cole Robinson <crobinso@redhat.com>
2020-11-10 12:04:25 -05:00
Martin Pitt
49a01b5482 virtinst: Fix TOCTOU in pool and volume enumeration
_fetch_all_pools_raw() and _fetch_vols_raw() have a race condition where
a pool/volume may disappear (from parallel libvirt operations) in
between enumerating and inspecting the objects.

_fetch_vols_raw() already expected that failure in the loop, but not for
the initial storagePoolLookupByName() call.

Also tighten the expected exception: This *should* crash on errors like
AttributeError or SystemExit, just not on dynamic libvirt errors. (Bare
exceptions are highly frowned upon in Python)

https://bugzilla.redhat.com/show_bug.cgi?id=1894359
2020-11-08 17:01:40 -05:00
emojifreak
04ad8df752 Added Debian's armv7l UEFI binary. Closes #174 2020-11-03 13:49:27 -05:00
Cole Robinson
f4dc418e66 virtclone: Only print/log 'clone successful' if we actually clone
Signed-off-by: Cole Robinson <crobinso@redhat.com>
2020-11-03 13:15:47 -05:00
Cole Robinson
8988572776 virtclone: Drop --print-xml special --auto-clone behavior
For unclear reasons we allowed --print-xml without --file or
--auto-clone, like is required for a traditional clone, which
can lead to some weird behavior.

Signed-off-by: Cole Robinson <crobinso@redhat.com>
2020-11-03 13:03:22 -05:00
Cole Robinson
1a1e4580c0 cloner: Explicitly reject 'network' disks we don't know how to clone
Signed-off-by: Cole Robinson <crobinso@redhat.com>
2020-11-03 13:03:03 -05:00
Cole Robinson
2d4b85b5bf domain: use makedirs exist_ok=True
Signed-off-by: Cole Robinson <crobinso@redhat.com>
2020-11-03 12:23:13 -05:00
Charles Arnold
9dc057e3e7 Add /usr/sbin to search path for non-root user
On a fresh install where no previous connection has been made a
non-root user starting virt-manager won't find the installed libvirtd
because the location is not in the user path.

Reviewed-by: Cole Robinson <crobinso@redhat.com>
Signed-off-by: Charles Arnold <carnold@suse.com>
2020-11-03 12:23:13 -05:00
Martin Pitt
7cb6a6062a virtinst: Fix TOCTOU race in user scratch dir creation
When starting many virt-install processes in parallel, some often crash
with

    ERROR    [Errno 17] File exists: '/home/kstest/.cache/virt-manager/boot'

Fix that by ignoring existing directories instead of explicitly testing
for existence.

The `exist_ok` parameter exists since Python 3.2, and the minimum
supported version is 3.4 now.
2020-11-03 11:52:46 -05:00
Cole Robinson
d0650aa48f osdict: Handle possible conflicting os named 'generic'
It's not impossible osinfo-db adds a 'generic' OS of its own, in
which case we will start misbehaving. Rework the way we implement
our synthetic 'generic' OS internally, using a stub Libosinfo.Os()

Signed-off-by: Cole Robinson <crobinso@redhat.com>
2020-10-21 18:49:11 -04:00
Cole Robinson
b17914591a Prep for release 3.1.0 2020-09-30 18:06:22 -04:00
Cole Robinson
0643adfc49 uitests: Make sure we hit details perf page coverage
Signed-off-by: Cole Robinson <crobinso@redhat.com>
2020-09-30 17:44:15 -04:00
Cole Robinson
af63df9793 tests: Fix test_urls after pytest conversion
Signed-off-by: Cole Robinson <crobinso@redhat.com>
2020-09-30 16:55:13 -04:00
Cole Robinson
3b96c32c49 po: Fix format error in cs.po
Signed-off-by: Cole Robinson <crobinso@redhat.com>
2020-09-30 16:52:13 -04:00
Whired Planck
0c40a60c0c Translated using Weblate (Chinese (Simplified))
Currently translated at 98.9% (1398 of 1413 strings)

Translation: virt-manager/virt-manager
Translate-URL: https://translate.fedoraproject.org/projects/virt-manager/virt-manager/zh_CN/
2020-09-30 16:51:16 -04:00
Oğuz Ersen
7b4abfc238 Translated using Weblate (Turkish)
Currently translated at 71.8% (1015 of 1413 strings)

Translation: virt-manager/virt-manager
Translate-URL: https://translate.fedoraproject.org/projects/virt-manager/virt-manager/tr/
2020-09-30 16:51:16 -04:00
Weblate
bc5f98e833 Update translation files
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: virt-manager/virt-manager
Translate-URL: https://translate.fedoraproject.org/projects/virt-manager/virt-manager/

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: virt-manager/virt-manager
Translate-URL: https://translate.fedoraproject.org/projects/virt-manager/virt-manager/
2020-09-30 16:51:15 -04:00
Pino Toscano
d8a69d41e4 Translated using Weblate (Italian)
Currently translated at 98.5% (1392 of 1413 strings)

Translation: virt-manager/virt-manager
Translate-URL: https://translate.fedoraproject.org/projects/virt-manager/virt-manager/it/
2020-09-30 16:51:15 -04:00
Fabio Tomat
a30ac4cbdd Translated using Weblate (Friulian)
Currently translated at 39.3% (556 of 1413 strings)

Translation: virt-manager/virt-manager
Translate-URL: https://translate.fedoraproject.org/projects/virt-manager/virt-manager/fur/
2020-09-30 16:51:15 -04:00
Yuri Chornoivan
f264994507 Translated using Weblate (Ukrainian)
Currently translated at 100.0% (1413 of 1413 strings)

Translation: virt-manager/virt-manager
Translate-URL: https://translate.fedoraproject.org/projects/virt-manager/virt-manager/uk/
2020-09-30 16:51:15 -04:00
Oğuz Ersen
7c7a24a0b6 Translated using Weblate (Turkish)
Currently translated at 56.2% (795 of 1413 strings)

Translation: virt-manager/virt-manager
Translate-URL: https://translate.fedoraproject.org/projects/virt-manager/virt-manager/tr/
2020-09-30 16:51:15 -04:00