1819 Commits

Author SHA1 Message Date
Daniel P. Berrangé
aa6b4b40b8 src: update action sensitivity when creating window
If we don't explicitly set action sensitivity after associating a
display with the window, the actions will end up with the wrong
state. This exhibits itself as send key actions being marked
disabled despite being connected,

Related: https://gitlab.com/virt-viewer/virt-viewer/-/issues/37
Closes: https://gitlab.com/virt-viewer/virt-viewer/-/issues/41
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
2021-05-26 17:32:08 +01:00
Daniel P. Berrangé
4820d05c82 src: correctly set display state when cancelling quit request
When the last window is closed we optionally show a confirmation dialog
to check if user wants to quit. If the user cancels, we need to ensure
the display menu state gets set back to checked.

We called g_action_change_state correctly, but a later call to
g_simple_action_set_state used the "visible" variable which was not
correctly reset back to TRUE upon cancel.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
2021-05-05 12:40:52 +00:00
Daniel P. Berrangé
73f567ea94 src: ensure auth entry fields are cleared
If authentication fails we reshow the same authentication dialog box
again. Rather than leaving the previous incorrect information in the
text entry boxes we need to clear them.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
2021-05-05 12:00:29 +01:00
Daniel P. Berrangé
f48b17e4d0 Remove remaining traces of changelog
We intentionally stopped generating a changelog from git history in the
switch to meson, since the tiny number of people who care can just look
at the git history directly. For end users the "NEWS" file is a more
consumable record of what's changed at a high level.

The empty ChangeLog was still in git though from the autoconf days and
thus ended up in the meson generated dist. It was also still mentioned
in syntax check rules and the RPM spec.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
2021-05-04 18:18:27 +01:00
Daniel P. Berrangé
dc378540ec rpm: set os-id when building for RHEL
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
2021-04-26 15:01:58 +01:00
Daniel P. Berrangé
65fe7379f8 config.h: conditionally define REMOTE_VIEWER_OS_ID
It should only be set in config.h if it is not the empty string

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
2021-04-26 15:01:50 +01:00
Daniel P. Berrangé
d07b1e5bad config.h: avoid extra hyphen in build ID value
The meson.build file already adds a hyphen.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
2021-04-26 14:57:22 +01:00
Daniel P. Berrangé
7dc64fef6b rpm: explicitly tell meson to disable spice/ovirt
%meson will force enable all features, so simply omitting the
BuildRequires is not sufficient to disable spice/ovirt. Meson
must be explicitly told to do so.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
2021-04-26 10:24:23 +01:00
Ján Tomko
9e36a59c80 src: initialize keymaps variable
My clang version 11.0.0 (Fedora 11.0.0-2.fc33) complains:
../src/virt-viewer-app.c:610:9: error: variable 'keymaps' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized]
    if (keymap_string) {
        ^~~~~~~~~~~~~
../src/virt-viewer-app.c:614:10: note: uninitialized use occurs here
    if (!keymaps || g_strv_length(keymaps) == 0) {
         ^~~~~~~
../src/virt-viewer-app.c:610:5: note: remove the 'if' if its condition is always true
    if (keymap_string) {
    ^~~~~~~~~~~~~~~~~~~
../src/virt-viewer-app.c:595:27: note: initialize the variable 'keymaps' to silence this warning
    gchar **key, **keymaps, **valkey, **valuekeys = NULL;
                          ^
                           = NULL
1 error generated.

Initialize the variable to fix the uninitialized use.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
2021-04-23 15:59:49 +02:00
Daniel P. Berrangé
09f268b05f rpm: remove obsolete icon path from file list
This fixes

  commit 7040dded11aa363d54684da3295d8cd50a2eab3a
  Author: Daniel P. Berrangé <berrange@redhat.com>
  Date:   Fri Feb 19 12:51:44 2021 +0000

    icons: remove obsolete usb icon

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
v10.0
2021-04-20 17:16:19 +01:00
Daniel P. Berrangé
6a9909b105 Add NEWS for 10.0 release
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
2021-04-20 14:00:07 +01:00
Pino Toscano
ed58a1bd45 Translated using Weblate (Italian)
Currently translated at 100.0% (178 of 178 strings)

Translation: virt-viewer/virt-viewer
Translate-URL: https://translate.fedoraproject.org/projects/virt-viewer/virt-viewer/it/

Signed-off-by: Pino Toscano <toscano.pino@tiscali.it>
2021-04-20 10:46:51 +02:00
Daniel P. Berrangé
16714e97a5 src: fix case sensitive accelerator parsing
The gtk_accelerator_parse code is case sensitive when resolving key
names, however, the spice_hotkey_to_gtk_accelerator method converts
everything to uppercase. The latter allows the user to provide "f"
as the key and get it converted to "F" which matches a GDK key name.
The latter breaks for most other keys though, eg "comma" is required
to be all lowercase and "Menu" must have the initial capital.

To cope with this we try the gtk_accelerator_parse call twice, once
with the spice munged key name for back compat, and once with the
exact user specified key name.

https://gitlab.com/virt-viewer/virt-viewer/-/issues/30
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
2021-04-19 14:54:37 +01:00
Jan Kuparinen
6f73712a16 Translated using Weblate (Finnish)
Currently translated at 100.0% (178 of 178 strings)

Translation: virt-viewer/virt-viewer
Translate-URL: https://translate.fedoraproject.org/projects/virt-viewer/virt-viewer/fi/

Signed-off-by: Jan Kuparinen <copper_fin@hotmail.com>
2021-04-18 12:02:08 +02:00
Yuri Chornoivan
5f52dfc320 Translated using Weblate (Ukrainian)
Currently translated at 100.0% (178 of 178 strings)

Translation: virt-viewer/virt-viewer
Translate-URL: https://translate.fedoraproject.org/projects/virt-viewer/virt-viewer/uk/

Signed-off-by: Yuri Chornoivan <yurchor@ukr.net>
2021-04-18 12:02:07 +02:00
Oğuz Ersen
3f0c5648b3 Translated using Weblate (Turkish)
Currently translated at 100.0% (178 of 178 strings)

Translation: virt-viewer/virt-viewer
Translate-URL: https://translate.fedoraproject.org/projects/virt-viewer/virt-viewer/tr/

Signed-off-by: Oğuz Ersen <oguzersen@protonmail.com>
2021-04-18 12:02:07 +02:00
Göran Uddeborg
eab4097841 Translated using Weblate (Swedish)
Currently translated at 100.0% (178 of 178 strings)

Translation: virt-viewer/virt-viewer
Translate-URL: https://translate.fedoraproject.org/projects/virt-viewer/virt-viewer/sv/

Signed-off-by: Göran Uddeborg <goeran@uddeborg.se>
2021-04-18 12:02:07 +02:00
simmon
8ab6c1b02a Translated using Weblate (Korean)
Currently translated at 100.0% (178 of 178 strings)

Translation: virt-viewer/virt-viewer
Translate-URL: https://translate.fedoraproject.org/projects/virt-viewer/virt-viewer/ko/

Signed-off-by: simmon <simmon@nplob.com>
2021-04-18 12:02:07 +02:00
Pino Toscano
ec6a76f7a5 Translated using Weblate (Italian)
Currently translated at 92.6% (165 of 178 strings)

Translation: virt-viewer/virt-viewer
Translate-URL: https://translate.fedoraproject.org/projects/virt-viewer/virt-viewer/it/

Signed-off-by: Pino Toscano <toscano.pino@tiscali.it>
2021-04-18 12:02:07 +02:00
Pavel Borecki
68b3f7685a Translated using Weblate (Czech)
Currently translated at 100.0% (178 of 178 strings)

Translation: virt-viewer/virt-viewer
Translate-URL: https://translate.fedoraproject.org/projects/virt-viewer/virt-viewer/cs/

Signed-off-by: Pavel Borecki <pavel.borecki@gmail.com>
2021-04-18 12:02:06 +02:00
Piotr Drąg
3556498bff Translated using Weblate (Polish)
Currently translated at 100.0% (178 of 178 strings)

Translation: virt-viewer/virt-viewer
Translate-URL: https://translate.fedoraproject.org/projects/virt-viewer/virt-viewer/pl/

Signed-off-by: Piotr Drąg <piotrdrag@gmail.com>
2021-04-15 17:29:56 +02:00
Yuri Chornoivan
c97fa32d3f Translated using Weblate (Ukrainian)
Currently translated at 100.0% (154 of 154 strings)

Translation: virt-viewer/virt-viewer
Translate-URL: https://translate.fedoraproject.org/projects/virt-viewer/virt-viewer/uk/

Signed-off-by: Yuri Chornoivan <yurchor@ukr.net>
2021-04-14 18:15:44 +02:00
Oğuz Ersen
25f2a7822b Translated using Weblate (Turkish)
Currently translated at 100.0% (154 of 154 strings)

Translation: virt-viewer/virt-viewer
Translate-URL: https://translate.fedoraproject.org/projects/virt-viewer/virt-viewer/tr/

Signed-off-by: Oğuz Ersen <oguzersen@protonmail.com>
2021-04-14 18:15:44 +02:00
simmon
b178007a7b Translated using Weblate (Korean)
Currently translated at 100.0% (154 of 154 strings)

Translation: virt-viewer/virt-viewer
Translate-URL: https://translate.fedoraproject.org/projects/virt-viewer/virt-viewer/ko/

Signed-off-by: simmon <simmon@nplob.com>
2021-04-14 18:15:44 +02:00
Piotr Drąg
ec1894e1de Translated using Weblate (Polish)
Currently translated at 100.0% (154 of 154 strings)

Translation: virt-viewer/virt-viewer
Translate-URL: https://translate.fedoraproject.org/projects/virt-viewer/virt-viewer/pl/

Signed-off-by: Piotr Drąg <piotrdrag@gmail.com>
2021-04-14 18:15:44 +02:00
Weblate
955ffbaee6 Update translation files
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: virt-viewer/virt-viewer
Translate-URL: https://translate.fedoraproject.org/projects/virt-viewer/virt-viewer/

Signed-off-by: Fedora Weblate Translation <i18n@lists.fedoraproject.org>

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: virt-viewer/virt-viewer
Translate-URL: https://translate.fedoraproject.org/projects/virt-viewer/virt-viewer/

Signed-off-by: Fedora Weblate Translation <i18n@lists.fedoraproject.org>
2021-04-14 18:15:44 +02:00
Jan Kuparinen
6813440baa Translated using Weblate (Finnish)
Currently translated at 100.0% (179 of 179 strings)

Translation: virt-viewer/virt-viewer
Translate-URL: https://translate.fedoraproject.org/projects/virt-viewer/virt-viewer/fi/

Signed-off-by: Jan Kuparinen <copper_fin@hotmail.com>
2021-04-14 18:15:43 +02:00
simmon
0b1fc2e97f Translated using Weblate (Korean)
Currently translated at 100.0% (179 of 179 strings)

Translation: virt-viewer/virt-viewer
Translate-URL: https://translate.fedoraproject.org/projects/virt-viewer/virt-viewer/ko/

Signed-off-by: simmon <simmon@nplob.com>

Translated using Weblate (Korean)

Currently translated at 100.0% (179 of 179 strings)

Translation: virt-viewer/virt-viewer
Translate-URL: https://translate.fedoraproject.org/projects/virt-viewer/virt-viewer/ko/

Signed-off-by: simmon <simmon@nplob.com>
2021-04-14 18:15:43 +02:00
Daniel P. Berrangé
8140b6448d po: regenerate POT file with missing UI files added
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
2021-04-14 16:58:10 +01:00
Daniel P. Berrangé
e734a52cec po: add missing UI files to POTFILES
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
2021-04-14 16:57:17 +01:00
Daniel P. Berrangé
82c14f3dea po: sort the POTFILES contents alphabetically
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
2021-04-14 16:55:55 +01:00
Daniel P. Berrangé
32ad23bff7 Refresh translatable strings in pot file
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
2021-04-14 11:39:57 +01:00
Daniel P. Berrangé
30e6f4cd03 src: update for renamed GTK-VNC zoom API
The API was renamed before GTK-VNC 1.2.0 release.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
2021-04-14 11:39:26 +01:00
Daniel P. Berrangé
47c22dc23b src: enable remote desktop resize with VNC
GTK-VNC has native support for remote desktop resize, provided that we
always give the widget the full available allocation. This requires that
we turn off VirtViewerDisplay's code for keeping aspect ratio, and
instead enable GTK-VNC's equivalent.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
2021-04-08 15:08:07 +01:00
Daniel P. Berrangé
20f5b18b6a src: add prop to control forced aspect ratio
When the VirtViewerDisplay class resizes the child display widget, it
attempts to preserve the remote desktop aspect ratio. This is useful in
general, if the display widget can't do this itself. The implication,
however, is that VirtViewerDisplay also has to take ownership of the
remote framebuffer resize functionality.

It is thus useful to disable VirtViewerDisplay's aspect ratio
preservation when the display widget can do this natively, as it can
then also do desktop resizes natively.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
2021-04-08 15:08:07 +01:00
Daniel P. Berrangé
e9e2ebb796 src: add --auto-resize <always|never> CLI arg
This is used to control whether resizing of the remote framebuffer
is permitted.

Fixes: https://gitlab.com/virt-viewer/virt-viewer/-/issues/20
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
2021-04-08 15:08:06 +01:00
Daniel P. Berrangé
707f74b9c4 src: add menu to control whether framebuffer resize is attempted
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
2021-04-08 15:07:08 +01:00
Daniel P. Berrangé
512efe70c6 src: initialize actions during instance init
Currently the GActionMap is registered during the application
startup. This takes place after the command line args are processed,
so prevents the CLI processing from using actions.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
2021-04-08 15:07:08 +01:00
Daniel P. Berrangé
83db5b3c64 src: remove unused property constant
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
2021-04-08 15:07:08 +01:00
Daniel P. Berrangé
3125e8f507 src: fix version check for power control
The next gtk-vnc will be 1.2.0, not 2.0.0

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
2021-04-08 15:07:08 +01:00
Daniel P. Berrangé
15fbaa3fb4 src: introduce "--cursor auto|local" command line
Normally we will honour the server requested behaviour for cursor,
either letting the server render it directly, or locally rendering
a cursor that the server provided us.

There are times, however, where the server does the wrong thing. For
example it might tell us to render an empty cursor, leaving the user
with no visible cursor at all. In this case it can be helpful to ignore
what the server requests, and always display the default local cursor.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
2021-04-08 12:52:59 +00:00
Jan Kuparinen
1589f90601 Added translation using Weblate (Finnish)
Signed-off-by: Jan Kuparinen <copper_fin@hotmail.com>
2021-04-06 19:17:35 +02:00
simmon
330418f69c Translated using Weblate (Korean)
Currently translated at 100.0% (179 of 179 strings)

Translation: virt-viewer/virt-viewer
Translate-URL: https://translate.fedoraproject.org/projects/virt-viewer/virt-viewer/ko/

Signed-off-by: simmon <simmon@nplob.com>

Translated using Weblate (Korean)

Currently translated at 33.5% (60 of 179 strings)

Translation: virt-viewer/virt-viewer
Translate-URL: https://translate.fedoraproject.org/projects/virt-viewer/virt-viewer/ko/

Signed-off-by: simmon <simmon@nplob.com>
2021-03-24 11:00:41 +01:00
Daniel P. Berrangé
ada810c088 src: support power control actions with VNC
VNC can support graceful shutdown, hard reset and hard power off.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
2021-03-23 17:59:29 +00:00
Daniel P. Berrangé
f42a1a7eaa src: conditionally enable VM action UIs
We only want to enable VM actions that are supported by
the session.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
2021-03-23 17:59:29 +00:00
Daniel P. Berrangé
897543880c src: wire up reporting of whether VM actions are supported in SPICE
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
2021-03-23 17:59:29 +00:00
Daniel P. Berrangé
27aa853981 src: add method to test whether a VM action is supported
SPICE provides a number of VM actions, but they are only supported if
the QMP tunnel is available. VNC doesn't currently support any, but
in future it will support some.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
2021-03-23 17:59:29 +00:00
Daniel P. Berrangé
a511365d78 rpm: disable spice for RHEL-9
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
2021-03-23 15:22:19 +00:00
Daniel P. Berrangé
2b9c9c51f8 rpm: disable govirt for RHEL-9
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
2021-03-23 15:21:59 +00:00
Daniel P. Berrangé
6db5b71419 src: hide password/username auth widgets if not required
When a password is sufficiently, we should not even show the username
field, and vica-verca.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
2021-03-18 11:26:37 +00:00