7696 Commits

Author SHA1 Message Date
Cole Robinson
fa322588b4 tests: Drop most unittest usage from virtinst tests
Kill usage of the TestCase class, move more to pytest standard
style

Signed-off-by: Cole Robinson <crobinso@redhat.com>
2020-09-19 13:46:46 -04:00
Cole Robinson
b79ee9565f tests: Rename test_xmlconfig.py to test_misc.py
That's what it is now, just a collection of misc virtinst tests

Signed-off-by: Cole Robinson <crobinso@redhat.com>
2020-09-19 13:46:33 -04:00
Cole Robinson
4c4753d910 tests: break out test_disk.py
Move a bunch of misc disk/diskbackend tests to this file

Signed-off-by: Cole Robinson <crobinso@redhat.com>
2020-09-19 13:46:22 -04:00
Cole Robinson
0ac9ff3488 tests: Drop a bunch of redundant xmlparse/xmlconfig tests
For the few bits we are hitting specific code paths, break them
out or fold them into other test cases

Signed-off-by: Cole Robinson <crobinso@redhat.com>
2020-09-19 13:46:08 -04:00
Cole Robinson
1b93c17564 cli: Add --controller vectors=X
Signed-off-by: Cole Robinson <crobinso@redhat.com>
2020-09-19 13:45:07 -04:00
Cole Robinson
71ac3ee044 tests: Convert to use pytest style 'assert'
Signed-off-by: Cole Robinson <crobinso@redhat.com>
2020-09-19 13:44:50 -04:00
Cole Robinson
2d8c1c5ab9 tests: capabilities: Fix coverage after string changes
Signed-off-by: Cole Robinson <crobinso@redhat.com>
2020-09-17 15:38:42 -04:00
Pino Toscano
748bb7d774 i18n: fix string puzzles in capabilities lookup error msgs
Create complete sentences with all the details available; there are not
many combinations, so this makes it possible to properly translate them.

Signed-off-by: Pino Toscano <ptoscano@redhat.com>
2020-09-17 15:38:42 -04:00
Pino Toscano
a74f22c49a i18n: use a single string for error message
Signed-off-by: Pino Toscano <ptoscano@redhat.com>
2020-09-17 15:38:42 -04:00
Pino Toscano
adeabb6e40 i18n: use plural forms where needed
In particular, when the number of objects depends on a variable.

Signed-off-by: Pino Toscano <ptoscano@redhat.com>
2020-09-17 15:38:42 -04:00
Pino Toscano
fb8a31ba76 i18n: translate UI messages
Signed-off-by: Pino Toscano <ptoscano@redhat.com>
2020-09-17 15:38:42 -04:00
Pino Toscano
76593f8a08 virtinst: use fail_conflicting
Make use of the new helper for showing a standard error message for two
conflicting cli options. This also catches one untranslatable message.

Signed-off-by: Pino Toscano <ptoscano@redhat.com>
2020-09-17 15:38:42 -04:00
Pino Toscano
8501206cb3 cli: add fail helper for 2 conflicting cli options
It will avoid repeating the same message in different places.

Signed-off-by: Pino Toscano <ptoscano@redhat.com>
2020-09-17 15:38:42 -04:00
Pino Toscano
924d766112 i18n: fix string puzzles in virt-xml hotplug/hotunplug/update
Do not use the action string (which is an identifer) as replaced
placeholder in messages for device hotplug/hotunplug/update.
Instead, use complete strings for all the actions, and also for all the
usages (confirmation message, success message, error message).

Since the action is the same for all the devices, create the messages
outside the iteration to avoid translating them more than once.

Signed-off-by: Pino Toscano <ptoscano@redhat.com>
2020-09-17 15:38:42 -04:00
Pino Toscano
8fbb985a8c i18n: improve title of connection dialog
Instead of using the title of the dialog and prepending the connection
label, create a new title as a single string. This way it is possible to
translate this title as single sentence.

Signed-off-by: Pino Toscano <ptoscano@redhat.com>
2020-09-17 15:38:42 -04:00
Pino Toscano
519d409718 i18n: fix string puzzle in volume creation dialog
Use a single label to show the single sentence describing the available
space on the storage pool. This avoids the use of 3 different labels,
partially translated separately, and whose content cannot be moved.

Signed-off-by: Pino Toscano <ptoscano@redhat.com>
2020-09-17 14:25:59 -04:00
Cole Robinson
c7ce770170 Prep for release 3.0.0 v3.0.0 2020-09-15 17:14:00 -04:00
Cole Robinson
282f9cf91c domain: Switch to non-deprecated thread.is_alive
Signed-off-by: Cole Robinson <crobinso@redhat.com>
2020-09-15 16:27:00 -04:00
Cole Robinson
83fcab0177 connectauth: Drop systemd libvirtd service startup
Latest libvirt uses socket activation, so libvirtd.service in
offline state does not indicate a problem necessarily.

Also on Fedora nowadays we have a weak RPM dependency on
libvirt-daemon which we didn't in the past.

Both things combine to make this code less useful and less accurate,
so let's remove most of it.

Signed-off-by: Cole Robinson <crobinso@redhat.com>
2020-09-15 14:46:36 -04:00
Cole Robinson
54ae6f2723 tests: uitests: Try to fix some clone flakiness
Signed-off-by: Cole Robinson <crobinso@redhat.com>
2020-09-15 13:50:58 -04:00
Cole Robinson
9fdbccec2b Fix pylint raise-missing-from
Signed-off-by: Cole Robinson <crobinso@redhat.com>
2020-09-15 12:36:27 -04:00
Chen Hanxiao
3238594028 fix some pylint
virtManager/createvm.py:982:8: W0128: Redeclared variable 'ignore' in assignment (redeclared-assigned-name)

tests/uitests/lib/app.py:12:0: C0411: third party import "from gi.repository import Gio" should be placed before "import dogtail.rawinput" (wrong-import-order)

Signed-off-by: Chen Hanxiao <chenhx.fnst@cn.fujitsu.com>
2020-09-15 12:20:18 -04:00
Cole Robinson
a242894182 cli: Add --os-variant require=on|off
If specified, this errors if no OS name was detected or manually set.
So --os-variant detect=on,require=on will error if no OS is detected.

name= can be used as a fallback, so test and document this case

Signed-off-by: Cole Robinson <crobinso@redhat.com>
2020-09-14 20:36:12 -04:00
Cole Robinson
17f47a44c5 cli: --os-variant: add explicit suboptions
This adds the following --os-variant suboptions

* name=, short-id=
* id=
* detect=on|off

Functionally this does not change behavior, just adds explicit
sub options for behavior we already support

Signed-off-by: Cole Robinson <crobinso@redhat.com>
2020-09-14 20:15:20 -04:00
Cole Robinson
67703ec7a5 cli: Add --osinfo as alternate name for --os-variant
The --os-variant option naming is pretty crappy and mostly a historical
artifact. Ideally this would be named just `--os` but I'm afraid that
would cause confusion with libvirt's <os> XML

Add --osinfo as an alternate commandline naming. If we ever want to
transition documented use of --os-variant it will help to have the
alternative around for a few releases

Signed-off-by: Cole Robinson <crobinso@redhat.com>
2020-09-14 18:12:41 -04:00
Cole Robinson
9e8a72537e hoststorage: Fix variable reference in error path
Signed-off-by: Cole Robinson <crobinso@redhat.com>
2020-09-14 14:40:47 -04:00
Göran Uddeborg
a8aec2da33 Translated using Weblate (Swedish)
Currently translated at 88.6% (1247 of 1407 strings)

Translation: virt-manager/virt-manager
Translate-URL: https://translate.fedoraproject.org/projects/virt-manager/virt-manager/sv/
2020-09-14 11:34:36 -04:00
Cole Robinson
080e84517e tests: test_dist: filter out harmless xgettext warning
Signed-off-by: Cole Robinson <crobinso@redhat.com>
2020-09-14 09:57:23 -04:00
Cole Robinson
e513422166 po/ru.po: Fix msgfmt string error
Signed-off-by: Cole Robinson <crobinso@redhat.com>
2020-09-14 09:55:36 -04:00
Cole Robinson
b60403d65b po: Fill in Project-Id-Version to not produce msgfmt errors
Signed-off-by: Cole Robinson <crobinso@redhat.com>
2020-09-14 09:54:43 -04:00
Weblate
4eee04a3f2 Update translation files
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: virt-manager/virt-manager
Translate-URL: https://translate.fedoraproject.org/projects/virt-manager/virt-manager/
2020-09-14 09:45:32 -04:00
Göran Uddeborg
9079596467 Translated using Weblate (Swedish)
Currently translated at 87.0% (1225 of 1407 strings)

Translation: virt-manager/virt-manager
Translate-URL: https://translate.fedoraproject.org/projects/virt-manager/virt-manager/sv/
2020-09-14 09:45:32 -04:00
Pino Toscano
beeb83fb2a Translated using Weblate (Italian)
Currently translated at 98.2% (1383 of 1407 strings)

Translation: virt-manager/virt-manager
Translate-URL: https://translate.fedoraproject.org/projects/virt-manager/virt-manager/it/
2020-09-14 09:45:32 -04:00
Pavel Borecki
d1d287c93f Translated using Weblate (Czech)
Currently translated at 99.8% (1405 of 1407 strings)

Translation: virt-manager/virt-manager
Translate-URL: https://translate.fedoraproject.org/projects/virt-manager/virt-manager/cs/
2020-09-14 09:45:32 -04:00
Piotr Drąg
68ee0dc4d3 Translated using Weblate (Polish)
Currently translated at 100.0% (1407 of 1407 strings)

Translation: virt-manager/virt-manager
Translate-URL: https://translate.fedoraproject.org/projects/virt-manager/virt-manager/pl/
2020-09-14 09:45:32 -04:00
Yuri Chornoivan
604dd59439 Translated using Weblate (Ukrainian)
Currently translated at 100.0% (1407 of 1407 strings)

Translation: virt-manager/virt-manager
Translate-URL: https://translate.fedoraproject.org/projects/virt-manager/virt-manager/uk/
2020-09-14 09:45:32 -04:00
Weblate
c9c1dcbc6f Update translation files
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: virt-manager/virt-manager
Translate-URL: https://translate.fedoraproject.org/projects/virt-manager/virt-manager/
2020-09-14 09:45:32 -04:00
Whired Planck
434ff783d3 Translated using Weblate (Chinese (Simplified))
Currently translated at 100.0% (1405 of 1405 strings)

Translation: virt-manager/virt-manager
Translate-URL: https://translate.fedoraproject.org/projects/virt-manager/virt-manager/zh_CN/
2020-09-14 09:45:32 -04:00
Yuri Chornoivan
e8b01e3a32 Translated using Weblate (Ukrainian)
Currently translated at 100.0% (1405 of 1405 strings)

Translation: virt-manager/virt-manager
Translate-URL: https://translate.fedoraproject.org/projects/virt-manager/virt-manager/uk/
2020-09-14 09:45:32 -04:00
Fabio Tomat
46029b1021 Translated using Weblate (Friulian)
Currently translated at 34.1% (480 of 1405 strings)

Translation: virt-manager/virt-manager
Translate-URL: https://translate.fedoraproject.org/projects/virt-manager/virt-manager/fur/
2020-09-14 09:45:32 -04:00
Pavel Borecki
4b8893927b Translated using Weblate (Czech)
Currently translated at 99.8% (1403 of 1405 strings)

Translation: virt-manager/virt-manager
Translate-URL: https://translate.fedoraproject.org/projects/virt-manager/virt-manager/cs/
2020-09-14 09:45:32 -04:00
Piotr Drąg
e12128ff55 Translated using Weblate (Polish)
Currently translated at 100.0% (1405 of 1405 strings)

Translation: virt-manager/virt-manager
Translate-URL: https://translate.fedoraproject.org/projects/virt-manager/virt-manager/pl/
2020-09-14 09:45:32 -04:00
Weblate
e1ac4a5fe0 Update translation files
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: virt-manager/virt-manager
Translate-URL: https://translate.fedoraproject.org/projects/virt-manager/virt-manager/
2020-09-14 09:45:32 -04:00
Yuri Chornoivan
2c755e8fda Translated using Weblate (Ukrainian)
Currently translated at 100.0% (1405 of 1405 strings)

Translation: virt-manager/virt-manager
Translate-URL: https://translate.fedoraproject.org/projects/virt-manager/virt-manager/uk/
2020-09-14 09:45:32 -04:00
Pino Toscano
d901ba475e Translated using Weblate (Italian)
Currently translated at 98.2% (1381 of 1405 strings)

Translation: virt-manager/virt-manager
Translate-URL: https://translate.fedoraproject.org/projects/virt-manager/virt-manager/it/
2020-09-14 09:45:32 -04:00
Pavel Borecki
f90ef17d46 Translated using Weblate (Czech)
Currently translated at 99.8% (1403 of 1405 strings)

Translation: virt-manager/virt-manager
Translate-URL: https://translate.fedoraproject.org/projects/virt-manager/virt-manager/cs/

Translated using Weblate (Czech)

Currently translated at 99.7% (1402 of 1405 strings)

Translation: virt-manager/virt-manager
Translate-URL: https://translate.fedoraproject.org/projects/virt-manager/virt-manager/cs/
2020-09-14 09:45:32 -04:00
Piotr Drąg
8050ebca64 Translated using Weblate (Polish)
Currently translated at 100.0% (1405 of 1405 strings)

Translation: virt-manager/virt-manager
Translate-URL: https://translate.fedoraproject.org/projects/virt-manager/virt-manager/pl/
2020-09-14 09:45:32 -04:00
Weblate
5bcd441f50 Update translation files
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: virt-manager/virt-manager
Translate-URL: https://translate.fedoraproject.org/projects/virt-manager/virt-manager/
2020-09-14 09:45:32 -04:00
Yuri Chornoivan
c4f7475562 Translated using Weblate (Ukrainian)
Currently translated at 100.0% (1421 of 1421 strings)

Translation: virt-manager/virt-manager
Translate-URL: https://translate.fedoraproject.org/projects/virt-manager/virt-manager/uk/
2020-09-14 09:45:31 -04:00
Pavel Borecki
7a8a0df03b Translated using Weblate (Czech)
Currently translated at 99.8% (1419 of 1421 strings)

Translation: virt-manager/virt-manager
Translate-URL: https://translate.fedoraproject.org/projects/virt-manager/virt-manager/cs/
2020-09-14 09:45:31 -04:00